Skip to content

Commit fe11bb8

Browse files
author
Michael
authored
React refactor (#16)
* refactored both layouts into one layout * fixed error in yarn.lock file caused by branch merge updated about text * refactored scss file directory
1 parent 8817f0f commit fe11bb8

15 files changed

+64
-80
lines changed

app/FullPage.js

-27
This file was deleted.

app/data/about.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,4 +75,4 @@ Palo Alto, Mountain View, San Francisco, Seattle, and New York.
7575
- always finding inspiration.
7676
- enabling a brighter future.
7777
- doing better.
78-
- no one checking my commit history for early drafts of this branch.
78+
- no one checking my commit history for early drafts of this file.

app/main.js app/entry.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ import ReactDOM from 'react-dom';
33
import { Router, Route, IndexRoute, browserHistory } from 'react-router';
44
import ReactGA from 'react-ga';
55

6-
import App from './App';
7-
import FullPage from './FullPage';
6+
// Layouts
7+
import Main from './layouts/Main';
88

99
import Index from './pages/Index';
1010
import About from './pages/About';
@@ -34,15 +34,16 @@ require('../public/css/main.scss');
3434

3535
ReactDOM.render(
3636
<Router onUpdate={update} history={browserHistory}>
37-
<Route path="/" component={App}>
37+
<Route path="/" component={Main}>
3838
<IndexRoute component={Index} />
3939
<Route path="/about" component={About} />
4040
<Route path="/resume" component={Resume} />
4141
<Route path="/projects" component={Projects} />
4242
<Route path="/stats" component={Stats} />
4343
<Route path="/contact" component={Contact} />
4444
</Route>
45-
<Route path="/" component={FullPage}>
45+
46+
<Route path="/" component={props => (<Main fullPage>{props.children}</Main>)}>
4647
<Route path="/music" component={Music} />
4748
</Route>
4849
<Route path="*" component={NotFound} status={404} />

app/App.js app/layouts/Main.js

+10-8
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,31 @@
11
import React, { PropTypes } from 'react';
22
import Helmet from 'react-helmet';
33

4-
import Header from './components/Template/Header';
5-
import Nav from './components/Template/Nav';
4+
import Header from '../components/Template/Header';
5+
import Nav from '../components/Template/Nav';
66

7-
const App = ({ children }) => (
7+
const Main = props => (
88
<div id="wrapper">
99
<Helmet titleTemplate="%s | Michael D'Angelo" defaultTitle="Michael D'Angelo" />
1010
<Header />
1111
<div id="main">
12-
{children}
12+
{props.children}
1313
</div>
14-
<Nav />
14+
{props.fullPage ? '' : <Nav />}
1515
</div>
1616
);
1717

18-
App.propTypes = {
18+
Main.propTypes = {
1919
children: PropTypes.oneOfType([
2020
PropTypes.arrayOf(PropTypes.node),
2121
PropTypes.node,
2222
]),
23+
fullPage: PropTypes.boolean,
2324
};
2425

25-
App.defaultProps = {
26+
Main.defaultProps = {
2627
children: null,
28+
fullPage: false,
2729
};
2830

29-
export default App;
31+
export default Main;

public/css/main.scss

+7-7
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,10 @@
5959
@import 'layout/footer';
6060
@import 'layout/menu';
6161

62-
@import 'layout/about';
63-
@import 'layout/resume';
64-
@import 'layout/skills';
65-
@import 'layout/stats';
66-
@import 'layout/contact';
67-
@import 'layout/music';
68-
@import 'layout/notFound';
62+
@import 'pages/about';
63+
@import 'pages/contact';
64+
@import 'pages/music';
65+
@import 'pages/notFound';
66+
@import 'pages/resume';
67+
@import 'pages/skills';
68+
@import 'pages/stats';
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

webpack/webpack.config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export default {
66
devtool: 'eval-source-map',
77
entry: [
88
'webpack-hot-middleware/client?path=//localhost:7999/__webpack_hmr&reload=true',
9-
path.join(__dirname, '../app/main.js'),
9+
path.join(__dirname, '../app/entry.js'),
1010
],
1111
output: {
1212
path: path.join(__dirname, '../dist/'),

webpack/webpack.production.config.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import StatsPlugin from 'stats-webpack-plugin';
66

77
export default {
88
entry: [
9-
path.join(__dirname, '../app/main.js'),
9+
path.join(__dirname, '../app/entry.js'),
1010
],
1111
output: {
1212
path: path.join(__dirname, '../tmp/'),

yarn.lock

+39-31
Original file line numberDiff line numberDiff line change
@@ -222,13 +222,17 @@ async-foreach@^0.1.3:
222222
version "0.1.3"
223223
resolved "https://registry.yarnpkg.com/async-foreach/-/async-foreach-0.1.3.tgz#36121f845c0578172de419a97dbeb1d16ec34542"
224224

225-
[email protected], [email protected], async@~0.2.6, async@~0.2.9:
225+
226226
version "0.2.9"
227227
resolved "https://registry.yarnpkg.com/async/-/async-0.2.9.tgz#df63060fbf3d33286a76aaf6d55a2986d9ff8619"
228228

229+
[email protected], async@~0.2.6, async@~0.2.9:
230+
version "0.2.10"
231+
resolved "https://registry.yarnpkg.com/async/-/async-0.2.10.tgz#b6bbe0b0674b9d719708ca38de8c237cb526c3d1"
232+
229233
async@^2.0.1, async@^2.1.2:
230-
version "2.1.4"
231-
resolved "https://registry.yarnpkg.com/async/-/async-2.1.4.tgz#2d2160c7788032e4dd6cbe2502f1f9a2c8f6cde4"
234+
version "2.1.5"
235+
resolved "https://registry.yarnpkg.com/async/-/async-2.1.5.tgz#e587c68580994ac67fc56ff86d3ac56bdbe810bc"
232236
dependencies:
233237
lodash "^4.14.0"
234238

@@ -1058,10 +1062,10 @@ browserify-zlib@^0.1.4:
10581062
pako "~0.2.0"
10591063

10601064
browserslist@^1.0.1, browserslist@^1.5.2, browserslist@^1.7.2:
1061-
version "1.7.3"
1062-
resolved "https://registry.yarnpkg.com/browserslist/-/browserslist-1.7.3.tgz#25ead9c917b278ad668b83f39c8025697797b2ab"
1065+
version "1.7.4"
1066+
resolved "https://registry.yarnpkg.com/browserslist/-/browserslist-1.7.4.tgz#56a12da876f787223743a866224ccd8f97014628"
10631067
dependencies:
1064-
caniuse-db "^1.0.30000623"
1068+
caniuse-db "^1.0.30000624"
10651069
electron-to-chromium "^1.2.2"
10661070

10671071
buffer-shims@^1.0.0:
@@ -1147,9 +1151,9 @@ caniuse-api@^1.5.2:
11471151
lodash.memoize "^4.1.0"
11481152
lodash.uniq "^4.3.0"
11491153

1150-
caniuse-db@^1.0.30000346, caniuse-db@^1.0.30000623:
1151-
version "1.0.30000623"
1152-
resolved "https://registry.yarnpkg.com/caniuse-db/-/caniuse-db-1.0.30000623.tgz#6e9dc4385d00a8f587efbb23fcbed7916f186e5d"
1154+
caniuse-db@^1.0.30000346, caniuse-db@^1.0.30000623, caniuse-db@^1.0.30000624:
1155+
version "1.0.30000624"
1156+
resolved "https://registry.yarnpkg.com/caniuse-db/-/caniuse-db-1.0.30000624.tgz#554b87547895e36f5fe128f4b7448a2ea5bf2213"
11531157

11541158
caseless@~0.11.0:
11551159
version "0.11.0"
@@ -1663,13 +1667,13 @@ date-now@^0.1.4:
16631667
version "0.1.4"
16641668
resolved "https://registry.yarnpkg.com/date-now/-/date-now-0.1.4.tgz#eaf439fd4d4848ad74e5cc7dbef200672b9e345b"
16651669

1666-
debug@2, [email protected], debug@^2.1.1, debug@^2.2.0:
1670+
debug@2, [email protected], debug@^2.2.0:
16671671
version "2.6.1"
16681672
resolved "https://registry.yarnpkg.com/debug/-/debug-2.6.1.tgz#79855090ba2c4e3115cc7d8769491d58f0491351"
16691673
dependencies:
16701674
ms "0.7.2"
16711675

1672-
[email protected], debug@~2.2.0:
1676+
[email protected], debug@^2.1.1, debug@~2.2.0:
16731677
version "2.2.0"
16741678
resolved "https://registry.yarnpkg.com/debug/-/debug-2.2.0.tgz#f87057e995b1a1f6ae6a4960664137bc56f039da"
16751679
dependencies:
@@ -2751,8 +2755,8 @@ html-entities@^1.2.0:
27512755
resolved "https://registry.yarnpkg.com/html-entities/-/html-entities-1.2.0.tgz#41948caf85ce82fed36e4e6a0ed371a6664379e2"
27522756

27532757
html-minifier@^3.2.3:
2754-
version "3.3.1"
2755-
resolved "https://registry.yarnpkg.com/html-minifier/-/html-minifier-3.3.1.tgz#dd38e60571537bf34a8171889c64fce73c45edad"
2758+
version "3.3.3"
2759+
resolved "https://registry.yarnpkg.com/html-minifier/-/html-minifier-3.3.3.tgz#5e85516b2aff3c3fb9bda351879375868386d6f6"
27562760
dependencies:
27572761
camel-case "3.0.x"
27582762
clean-css "4.0.x"
@@ -3063,7 +3067,7 @@ is-plain-obj@^1.0.0:
30633067

30643068
is-posix-bracket@^0.1.0:
30653069
version "0.1.1"
3066-
resolved "http://registry.npmjs.org/is-posix-bracket/-/is-posix-bracket-0.1.1.tgz#3334dc79774368e92f016e6fbc0a88f5cd6e6bc4"
3070+
resolved "https://registry.yarnpkg.com/is-posix-bracket/-/is-posix-bracket-0.1.1.tgz#3334dc79774368e92f016e6fbc0a88f5cd6e6bc4"
30673071

30683072
is-primitive@^2.0.0:
30693073
version "2.0.0"
@@ -3078,8 +3082,10 @@ is-redirect@^1.0.0:
30783082
resolved "https://registry.yarnpkg.com/is-redirect/-/is-redirect-1.0.0.tgz#1d03dded53bd8db0f30c26e4f95d36fc7c87dc24"
30793083

30803084
is-regex@^1.0.3:
3081-
version "1.0.3"
3082-
resolved "https://registry.yarnpkg.com/is-regex/-/is-regex-1.0.3.tgz#0d55182bddf9f2fde278220aec3a75642c908637"
3085+
version "1.0.4"
3086+
resolved "https://registry.yarnpkg.com/is-regex/-/is-regex-1.0.4.tgz#5517489b547091b0930e095654ced25ee97e9491"
3087+
dependencies:
3088+
has "^1.0.1"
30833089

30843090
is-resolvable@^1.0.0:
30853091
version "1.0.0"
@@ -4339,8 +4345,8 @@ postcss-zindex@^2.0.1:
43394345
uniqs "^2.0.0"
43404346

43414347
postcss@^5.0.10, postcss@^5.0.11, postcss@^5.0.12, postcss@^5.0.13, postcss@^5.0.14, postcss@^5.0.16, postcss@^5.0.2, postcss@^5.0.4, postcss@^5.0.5, postcss@^5.0.6, postcss@^5.0.8, postcss@^5.2.13:
4342-
version "5.2.13"
4343-
resolved "https://registry.yarnpkg.com/postcss/-/postcss-5.2.13.tgz#1be52a32cf2ef58c0d75f1aedb3beabcf257cef3"
4348+
version "5.2.14"
4349+
resolved "https://registry.yarnpkg.com/postcss/-/postcss-5.2.14.tgz#47b4fbde363fd4f81e547f7e0e43d6d300267330"
43444350
dependencies:
43454351
chalk "^1.1.3"
43464352
js-base64 "^2.1.9"
@@ -4518,13 +4524,13 @@ raw-loader@^0.5.1:
45184524
resolved "https://registry.yarnpkg.com/raw-loader/-/raw-loader-0.5.1.tgz#0c3d0beaed8a01c966d9787bf778281252a979aa"
45194525

45204526
rc@^1.0.1, rc@~1.1.6:
4521-
version "1.1.6"
4522-
resolved "https://registry.yarnpkg.com/rc/-/rc-1.1.6.tgz#43651b76b6ae53b5c802f1151fa3fc3b059969c9"
4527+
version "1.1.7"
4528+
resolved "https://registry.yarnpkg.com/rc/-/rc-1.1.7.tgz#c5ea564bb07aff9fd3a5b32e906c1d3a65940fea"
45234529
dependencies:
45244530
deep-extend "~0.4.0"
45254531
ini "~1.3.0"
45264532
minimist "^1.2.0"
4527-
strip-json-comments "~1.0.4"
4533+
strip-json-comments "~2.0.1"
45284534

45294535
react-burger-menu@^1.10.12:
45304536
version "1.10.12"
@@ -4701,8 +4707,8 @@ regenerate@^1.2.1:
47014707
resolved "https://registry.yarnpkg.com/regenerate/-/regenerate-1.3.2.tgz#d1941c67bad437e1be76433add5b385f95b19260"
47024708

47034709
regenerator-runtime@^0.10.0:
4704-
version "0.10.1"
4705-
resolved "https://registry.yarnpkg.com/regenerator-runtime/-/regenerator-runtime-0.10.1.tgz#257f41961ce44558b18f7814af48c17559f9faeb"
4710+
version "0.10.3"
4711+
resolved "https://registry.yarnpkg.com/regenerator-runtime/-/regenerator-runtime-0.10.3.tgz#8c4367a904b51ea62a908ac310bf99ff90a82a3e"
47064712

47074713
47084714
version "0.9.8"
@@ -4714,7 +4720,7 @@ [email protected]:
47144720

47154721
regex-cache@^0.4.2:
47164722
version "0.4.3"
4717-
resolved "https://registry.yarnpkg.com/regex-cache/-/regex-cache-0.4.3.tgz#9b1a6c35d4d0dfcef5711ae651e8e9d3d7114145"
4723+
resolved "http://registry.npmjs.org/regex-cache/-/regex-cache-0.4.3.tgz#9b1a6c35d4d0dfcef5711ae651e8e9d3d7114145"
47184724
dependencies:
47194725
is-equal-shallow "^0.1.3"
47204726
is-primitive "^2.0.0"
@@ -4860,7 +4866,13 @@ right-align@^0.1.1:
48604866
dependencies:
48614867
align-text "^0.1.1"
48624868

4863-
rimraf@2, [email protected], rimraf@^2.2.8, rimraf@^2.4.0, rimraf@^2.5.4, rimraf@~2.5.1, rimraf@~2.5.4:
4869+
rimraf@2, [email protected], rimraf@^2.2.8, rimraf@^2.4.0, rimraf@^2.5.4:
4870+
version "2.6.0"
4871+
resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.6.0.tgz#89b8a0fe432b9ff9ec9a925a00b6cdb3a91bbada"
4872+
dependencies:
4873+
glob "^7.0.5"
4874+
4875+
rimraf@~2.5.1, rimraf@~2.5.4:
48644876
version "2.5.4"
48654877
resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.5.4.tgz#96800093cbf1a0c86bd95b4625467535c29dfa04"
48664878
dependencies:
@@ -5200,10 +5212,6 @@ strip-json-comments@~0.1.1:
52005212
version "0.1.3"
52015213
resolved "https://registry.yarnpkg.com/strip-json-comments/-/strip-json-comments-0.1.3.tgz#164c64e370a8a3cc00c9e01b539e569823f0ee54"
52025214

5203-
strip-json-comments@~1.0.4:
5204-
version "1.0.4"
5205-
resolved "https://registry.yarnpkg.com/strip-json-comments/-/strip-json-comments-1.0.4.tgz#1e15fbcac97d3ee99bf2d73b4c656b082bbafb91"
5206-
52075215
strip-json-comments@~2.0.1:
52085216
version "2.0.1"
52095217
resolved "https://registry.yarnpkg.com/strip-json-comments/-/strip-json-comments-2.0.1.tgz#3c531942e908c2697c0ec344858c286c7ca0a60a"
@@ -5563,8 +5571,8 @@ watchpack@^1.2.0:
55635571
graceful-fs "^4.1.2"
55645572

55655573
webpack-dev-middleware@^1.10.0:
5566-
version "1.10.0"
5567-
resolved "https://registry.yarnpkg.com/webpack-dev-middleware/-/webpack-dev-middleware-1.10.0.tgz#7d5be2651e692fddfafd8aaed177c16ff51f0eb8"
5574+
version "1.10.1"
5575+
resolved "https://registry.yarnpkg.com/webpack-dev-middleware/-/webpack-dev-middleware-1.10.1.tgz#c6b4cf428139cf1aefbe06a0c00fdb4f8da2f893"
55685576
dependencies:
55695577
memory-fs "~0.4.1"
55705578
mime "^1.3.4"

0 commit comments

Comments
 (0)