Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eurosat_dataset() might be improved in code style and data design #124

Open
3 tasks
cregouby opened this issue Feb 12, 2025 · 0 comments
Open
3 tasks

eurosat_dataset() might be improved in code style and data design #124

cregouby opened this issue Feb 12, 2025 · 0 comments

Comments

@cregouby
Copy link
Contributor

Hello,

Current situation

The function could have improved code style

[eurosat_dataset()](#122 ) has a code styling that inherits from other language and prevent readability and portability :

  • use of sprintf() instead of glue:: styled message concatenation
  • use of base R warning() and if (){stop()} instead of package functions runtime_error("") and value_error("")
  • reuse existing message for consistency with other _dataset() functions and preventing specific translation of messages. Example is "Dataset not found. You can use download = TRUE to download it." , ...

The function could have improved data movement design

[eurosat_dataset()](#122 ) uses it's own data folder for archive caching instead of reusing the common torchvision cache folder.

Expected situation

  • maximize reuse of existing messages,
  • utils.R message functions, and consistent code-style with other _dataset() functions
  • reuse the download_and_cache() function for consistent large file storage on end-user machine
@cregouby cregouby mentioned this issue Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant