You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[eurosat_dataset()](#122 ) has a code styling that inherits from other language and prevent readability and portability :
use of sprintf() instead of glue:: styled message concatenation
use of base R warning() and if (){stop()} instead of package functions runtime_error("") and value_error("")
reuse existing message for consistency with other _dataset() functions and preventing specific translation of messages. Example is "Dataset not found. You can use download = TRUE to download it." , ...
The function could have improved data movement design
[eurosat_dataset()](#122 ) uses it's own data folder for archive caching instead of reusing the common torchvision cache folder.
Expected situation
maximize reuse of existing messages,
utils.R message functions, and consistent code-style with other _dataset() functions
reuse the download_and_cache() function for consistent large file storage on end-user machine
The text was updated successfully, but these errors were encountered:
Hello,
Current situation
The function could have improved code style
[
eurosat_dataset()](#122 )
has a code styling that inherits from other language and prevent readability and portability :sprintf()
instead ofglue::
styled message concatenationwarning()
andif (){stop()}
instead of package functionsruntime_error("")
andvalue_error("")
_dataset()
functions and preventing specific translation of messages. Example is "Dataset not found. You can usedownload = TRUE
to download it." , ...The function could have improved data movement design
[
eurosat_dataset()](#122 )
uses it's own data folder for archive caching instead of reusing the common torchvision cache folder.Expected situation
utils.R
message functions, and consistent code-style with other_dataset()
functionsdownload_and_cache()
function for consistent large file storage on end-user machineThe text was updated successfully, but these errors were encountered: