Refactor login steps and update BrowserStack build name

Removed redundant navigation and page load logic from login steps and base page. Updated BrowserStack build name format in GitHub Actions workflow for clarity.

Author: mnashed13

.github/workflows/browserstack-ui-tests.yml

@@ -40,7 +40,7 @@ jobs:
           BROWSERSTACK_USERNAME: ${{ secrets.BROWSERSTACK_USERNAME }}
           BROWSERSTACK_ACCESS_KEY: ${{ secrets.BROWSERSTACK_ACCESS_KEY }}
           BROWSERSTACK_PROJECT_NAME: Playwright Testing Framework
-          BROWSERSTACK_BUILD_NAME: build-${{ github.run_number }}-${{ github.sha }}
+          BROWSERSTACK_BUILD_NAME: Playwright Build-${{ github.run_number }}-${{ github.sha }}
           BROWSERSTACK_SESSION_NAME: browserstack_${{ github.workflow }}
           BROWSERSTACK_DEBUG: true
           BROWSERSTACK_CONSOLE_LOGS: true

src/pages/base.page.ts

@@ -19,8 +19,4 @@ export class BasePage {
 		console.log(`Navigating to: ${url}`); // Debug log
 		await this.page.goto(url);
 	}
-
-	async waitForPageLoad() {
-		await this.page.waitForLoadState('networkidle');
-	}
 }

src/steps/login.steps.ts

@@ -8,22 +8,10 @@ Given('I am on the login page', async function (this: World) {
 	await loginPage.navigate(process.env.BASE_URL);
 });
 
-When('I login with valid credentials', async function (this: World) {
-	const loginPage = new LoginPage(this.page);
-	await loginPage.navigate(process.env.BASE_URL);
-});
+When('I login with valid credentials', async function (this: World) {});
 
-When('I login with invalid credentials', async function (this: World) {
-	const loginPage = new LoginPage(this.page);
-	await loginPage.navigate(process.env.BASE_URL);
-});
+When('I login with invalid credentials', async function (this: World) {});
 
-Then('I should be logged in successfully', async function (this: World) {
-	const loginPage = new LoginPage(this.page);
-	await loginPage.navigate(process.env.BASE_URL);
-});
+Then('I should be logged in successfully', async function (this: World) {});
 
-Then('I should see an error message', async function (this: World) {
-	const loginPage = new LoginPage(this.page);
-	await loginPage.navigate(process.env.BASE_URL);
-});
+Then('I should see an error message', async function (this: World) {});