Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH generalize plot_ica_properties to channels #2747

Open
jona-sassenhagen opened this issue Dec 24, 2015 · 6 comments
Open

ENH generalize plot_ica_properties to channels #2747

jona-sassenhagen opened this issue Dec 24, 2015 · 6 comments

Comments

@jona-sassenhagen
Copy link
Contributor

jona-sassenhagen commented Dec 24, 2015

One EEGALB function I miss and find myself reproducing manually a lot is pop_prop.
These give a summary of a sensor or component that is helpful especially for identifying artefact types.
(They also work with raw files, segmenting the raw stream into 2-second epochs and showing you were gross artefacts are located in the data.)

plot_ica_properties should be generalized to channels. @mmagnuski

screen shot 2015-12-24 at 13 33 36
screen shot 2015-12-24 at 13 33 29

Maybe if others also find these interesting, we could implement them.

@jona-sassenhagen
Copy link
Contributor Author

For channels rather than ICs, the sensor position is highlighted instead of showing the mixing weights.

@jona-sassenhagen jona-sassenhagen changed the title pop_prop equivalent (sensor or component summary) ENH pop_prop equivalent (sensor or component summary) Dec 24, 2015
@jona-sassenhagen
Copy link
Contributor Author

If nobody is interested in this, I'll close.

@agramfort
Copy link
Member

at least make a gist of your code so we know where to start to implement this.

@jona-sassenhagen
Copy link
Contributor Author

closed by #3275

@mmagnuski
Copy link
Member

Although the logic of OR (in the issue title) is fulfilled I think you can leave this open until channel properties are ready. :)

@jona-sassenhagen jona-sassenhagen changed the title ENH pop_prop equivalent (sensor or component summary) ENH generalize plot_ica_properties to channels Jun 28, 2016
@jona-sassenhagen
Copy link
Contributor Author

jona-sassenhagen commented Apr 26, 2019

@agramfort I would like to also allow this for channels (like EEGLAB has). It's good to quickly see e.g. what kind of artefacts a channel has (just 2 or 3, or more). Ok?

mne.viz.plot_channel_properties(inst, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants