Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WCOW: need support for llb.AddMount and RUN --mount for WCOW #5678

Open
profnandaa opened this issue Jan 21, 2025 · 2 comments
Open

WCOW: need support for llb.AddMount and RUN --mount for WCOW #5678

profnandaa opened this issue Jan 21, 2025 · 2 comments
Assignees
@profnandaa
Labels
area/windows area/windows-wcow

Comments

@profnandaa
Copy link
Collaborator

profnandaa commented Jan 21, 2025 •
edited
Loading

Currently, llb.AddMount and RUN --mount ... is not supported for WCOW. You end up with failures like:

failed to create shim task: invalid OCI spec - Type 'windows-layer' not supported: unknown

Related issues:
@profnandaa profnandaa self-assigned this Jan 21, 2025
@profnandaa profnandaa mentioned this issue Jan 21, 2025
Draft
@profnandaa profnandaa mentioned this issue Jan 29, 2025
Open
@profnandaa
Copy link
Collaborator Author

cross-linking adamrehn/ue4-docker#365

@profnandaa profnandaa mentioned this issue Feb 6, 2025
Merged
5 tasks
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 7, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
ec20b95 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [ ] add client integration tests
- [ ] add documentatio
- [ ] add note and plan on the missing feature(s)
	i.e. secret mounts (that need tmpfs)
- [ ] spec out / second attempt for SSH mount

Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 7, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
9c74564 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [ ] add client integration tests
- [ ] add documentatio
- [ ] add note and plan on the missing feature(s)
	i.e. secret mounts (that need tmpfs)
- [ ] spec out / second attempt for SSH mount

Fixes moby#5603
Addresses part of moby#5678

Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 10, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
261ee88 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [ ] add client integration tests
- [ ] add documentatio
- [ ] add note and plan on the missing feature(s)
	i.e. secret mounts (that need tmpfs)
- [ ] spec out / second attempt for SSH mount

Fixes moby#5603
Addresses part of moby#5678

Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 11, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
b2c2b01 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [ ] add client integration tests
- [ ] add documentatio
- [ ] add note and plan on the missing feature(s)
	i.e. secret mounts (that need tmpfs)
- [ ] spec out / second attempt for SSH mount

Fixes moby#5603
Addresses part of moby#5678

Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 11, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
00b9867 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [ ] add client integration tests
- [ ] add documentatio
- [ ] add note and plan on the missing feature(s)
	i.e. secret mounts (that need tmpfs)
- [ ] spec out / second attempt for SSH mount

Fixes moby#5603
Addresses part of moby#5678

Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 12, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
42f8214 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [ ] add client integration tests
- [ ] add documentatio
- [ ] add note and plan on the missing feature(s)
	i.e. secret mounts (that need tmpfs)
- [ ] spec out / second attempt for SSH mount

Fixes moby#5603

Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 12, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
ba74219 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [ ] add client integration tests
- [ ] add documentatio
- [ ] add note and plan on the missing feature(s)
	i.e. secret mounts (that need tmpfs)
- [ ] spec out / second attempt for SSH mount

Fixes moby#5603

Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 14, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
6fef8df 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [ ] add client integration tests
- [ ] add documentatio
- [ ] add note and plan on the missing feature(s)
	i.e. secret mounts (that need tmpfs)
- [ ] spec out / second attempt for SSH mount

Fixes moby#5603

Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 14, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
59b5b09 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [ ] add client integration tests
- [ ] add documentation

Fixes moby#5603

Signed-off-by: Anthony Nandaa <[email protected]>
@profnandaa
Copy link
Collaborator Author

profnandaa commented Feb 14, 2025 •
edited
Loading

Note for llb.AddMount support

With #5708 -- not all llb.AddMount scenarios are supported yet. I have encountered a these two classes of errors from running client tests:

Lower mount invalid: number of mounts should always be 1 for Windows layers: invalid argument

UPDATE:
// second one has been fixed now with this simplification:

Image

profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 14, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
39e3ff8 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [x] add client integration tests (not all, `llb.AddMount` not
  complete)

Fixes moby#5603

Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 20, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
54924cc 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [x] add client integration tests (not all, `llb.AddMount` not
  complete)

Fixes moby#5603

Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 20, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
b94b60c 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [x] add client integration tests (not all, `llb.AddMount` not
  complete)

Fixes moby#5603

Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 20, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
c583ec5 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [x] add client integration tests (not all, `llb.AddMount` not
  complete)

Fixes moby#5603

Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 20, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
26dfae5 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [x] add client integration tests (not all, `llb.AddMount` not
  complete)

Fixes moby#5603

Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 20, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
7ba4fb1 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [x] add client integration tests (not all, `llb.AddMount` not
  complete)

Fixes moby#5603

Signed-off-by: Anthony Nandaa <[email protected]>
profnandaa added a commit to profnandaa/buildkit that referenced this issue Feb 20, 2025
@profnandaa
feat: wcow: add support for bind and cache mounts
877d8a7 
Currently, mounts are not supported for WCOW builds,
see moby#5678. This commit introduces support for
bind and cache mounts. The remaining two require
a little more work and consultation with the platform
teams for enlightment.

WIP Checklist:

- [x] Support for bind mounts
- [x] Support for cache mounts
- [x] add frontend/dockerfile integration tests
- [x] add client integration tests (not all, `llb.AddMount` not
  complete)

Fixes moby#5603

Signed-off-by: Anthony Nandaa <[email protected]>
@profnandaa profnandaa mentioned this issue Feb 26, 2025
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@profnandaa profnandaa

Labels
area/windows area/windows-wcow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@profnandaa