fix: disable newline translation in stdio TextIOWrapper to prevent CRLF on Windows

On Windows, TextIOWrapper without newline="" performs universal newline
translation (\n -> \r\n on write), corrupting the newline-delimited JSON
wire format used by MCP's stdio transport.

Pass newline="" to both the stdin and stdout TextIOWrapper calls in
stdio_server() to disable translation on all platforms.

Add a regression test that inspects the raw bytes written to the output
buffer and asserts no \r bytes are present.

Fixes #2433

Author: Maanik23

src/mcp/server/stdio.py

@@ -38,10 +38,14 @@ async def stdio_server(stdin: anyio.AsyncFile[str] | None = None, stdout: anyio.
     # standard process handles. Encoding of stdin/stdout as text streams on
     # python is platform-dependent (Windows is particularly problematic), so we
     # re-wrap the underlying binary stream to ensure UTF-8.
+    #
+    # newline="" disables universal newline translation, which is critical on
+    # Windows: without it, TextIOWrapper translates \n -> \r\n on write and
+    # \r\n -> \n on read, corrupting the newline-delimited JSON wire format.
     if not stdin:
-        stdin = anyio.wrap_file(TextIOWrapper(sys.stdin.buffer, encoding="utf-8", errors="replace"))
+        stdin = anyio.wrap_file(TextIOWrapper(sys.stdin.buffer, encoding="utf-8", errors="replace", newline=""))
     if not stdout:
-        stdout = anyio.wrap_file(TextIOWrapper(sys.stdout.buffer, encoding="utf-8"))
+        stdout = anyio.wrap_file(TextIOWrapper(sys.stdout.buffer, encoding="utf-8", newline=""))
 
     read_stream_writer, read_stream = create_context_streams[SessionMessage | Exception](0)
     write_stream, write_stream_reader = create_context_streams[SessionMessage](0)

tests/server/test_stdio.py

@@ -274,3 +274,53 @@ def test_mcpserver_run_stdio_serves_a_modern_connection(monkeypatch: pytest.Monk
     # request was served at the discovered version, not the handshake era.
     assert responses[1].result["tools"] == []
     assert responses[1].result["resultType"] == "complete"
+
+
+@pytest.mark.anyio
+async def test_stdio_server_no_crlf_on_windows(monkeypatch: pytest.MonkeyPatch) -> None:
+    """Verify stdout uses bare LF (\\n) line endings, not CRLF (\\r\\n).
+
+    The MCP protocol uses newline-delimited JSON with \\n as the delimiter.
+    On Windows, TextIOWrapper without newline="" translates \\n -> \\r\\n,
+    corrupting the wire format. This test ensures the fix is effective on
+    all platforms by going through the default sys.stdout.buffer path.
+    """
+
+    class NonClosingBytesIO(io.BytesIO):
+        """BytesIO subclass that ignores close() so we can inspect data after
+        the owning TextIOWrapper is closed."""
+
+        def close(self) -> None:
+            pass  # Keep the buffer open for inspection
+
+    raw_stdin_buf = io.BytesIO(b"")
+    raw_stdout_buf = NonClosingBytesIO()
+
+    # Create a fake sys.stdin / sys.stdout that expose .buffer attributes
+    # pointing to our BytesIO objects.  This exercises the real code path in
+    # stdio_server() which accesses sys.stdin.buffer / sys.stdout.buffer.
+    fake_stdin = TextIOWrapper(raw_stdin_buf, encoding="utf-8")
+    fake_stdout = TextIOWrapper(raw_stdout_buf, encoding="utf-8")
+    monkeypatch.setattr(sys, "stdin", fake_stdin)
+    monkeypatch.setattr(sys, "stdout", fake_stdout)
+
+    with anyio.fail_after(5):
+        async with stdio_server() as (read_stream, write_stream):
+            # Send a message through the server's write stream
+            response = JSONRPCResponse(jsonrpc="2.0", id=1, result={})
+            session_message = SessionMessage(response)
+            await write_stream.send(session_message)
+            await write_stream.aclose()
+            # Drain the read stream so the stdin_reader task can exit cleanly
+            await read_stream.aclose()
+
+    # The stdio_server wraps sys.stdout.buffer (= raw_stdout_buf) with its own
+    # TextIOWrapper(newline="").  After the context manager exits, all data
+    # should be flushed to raw_stdout_buf.
+    raw_bytes = raw_stdout_buf.getvalue()
+    assert raw_bytes, "Expected output bytes but got empty buffer"
+    # Must end with bare \n, not \r\n
+    assert raw_bytes.endswith(b"\n"), f"Output must end with LF: {raw_bytes!r}"
+    assert not raw_bytes.endswith(b"\r\n"), f"Output must NOT contain CRLF: {raw_bytes!r}"
+    # No \r anywhere in the output
+    assert b"\r" not in raw_bytes, f"Output contains CR byte: {raw_bytes!r}"