Conversation
|
@robinroy03 Thank you for your contribution! I see that currently this PR has changes that are related to the proposed "module not found" fix, as well as general formatting changes across the python client file. To make it easier for reviewers to review and accept your changes, and also for the history, could you please split this PR into 2: one with a fix, and another one with formatting changes? |
| path = Path(server_script_path).resolve() | ||
| server_params = StdioServerParameters( | ||
| command="uv", | ||
| args=["--directory", path.parent, "run", path.name], |
There was a problem hiding this comment.
@robinroy03 currently this example fails because path.parent should be a string. Suggest changing to:
args=["--directory", str(path.parent), "run", path.name],
|
@robinroy03 This PR cannot be merged because the code fails as |
|
@a-akimov I'm not working on this anymore. You could either close it or write code on top of it. |
|
Closing in favor of #75. |
Motivation and Context
Solved #25. Earlier when the user did a command like
uv run client.py "C:\Users\Robin Roy\Desktop\quickstart-resources\weather-server-python\weather.py"it'll throwModuleNotFoundErrorbecause the spawned process was unable to use the.venvlibs. I modifieduvto use the libs.How Has This Been Tested?
I tested it locally for the problems #23 and #24.
Breaking Changes
None.
Types of changes
Checklist