Basic chores to improve and clean up#58
Closed
a-akimov wants to merge 4 commits intomodelcontextprotocol:mainfrom
Closed
Basic chores to improve and clean up#58a-akimov wants to merge 4 commits intomodelcontextprotocol:mainfrom
a-akimov wants to merge 4 commits intomodelcontextprotocol:mainfrom
Conversation
1. Added .idea to gitignore to support those working in JetBrains IDEs 2. Created an ANTHROPIC_MODEL constant in clients to avoid updating a model in 2 places 3. Added a package description to the Python MCP client 4. Upgraded many package versions, especially the MCP ones
Member
jonathanhefner
left a comment
There was a problem hiding this comment.
- Added .idea to gitignore to support those working in JetBrains IDEs
- Created an ANTHROPIC_MODEL constant in clients to avoid updating a model in 2 places
- Added a package description to the Python MCP client
- Upgraded many package versions, especially the MCP ones
I think these are good changes, but I would say split them into separate PRs, or at least separate commits in the same PR. Even though the changes aren't likely to cause issues, it is helpful to be able to reference, bisect, and/or revert individual commits.
Contributor
Author
|
Hi @jonathanhefner, thank you for your feedback. I've split it into several PRs for better traceability, so I will close this one. #65 Fix a placeholder description for the MCP client |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Tested locally all variations - servers in Claude and also in clients in this repo.
Breaking Changes
No.
Types of changes
Checklist
Additional context
No