Skip to content

Basic chores to improve and clean up#58

Closed
a-akimov wants to merge 4 commits intomodelcontextprotocol:mainfrom
a-akimov:chores
Closed

Basic chores to improve and clean up#58
a-akimov wants to merge 4 commits intomodelcontextprotocol:mainfrom
a-akimov:chores

Conversation

@a-akimov
Copy link
Copy Markdown
Contributor

Motivation and Context

  1. Added .idea to gitignore to support those working in JetBrains IDEs
  2. Created an ANTHROPIC_MODEL constant in clients to avoid updating a model in 2 places
  3. Added a package description to the Python MCP client
  4. Upgraded many package versions, especially the MCP ones

How Has This Been Tested?

Tested locally all variations - servers in Claude and also in clients in this repo.

Breaking Changes

No.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

No

1. Added .idea to gitignore to support those working in JetBrains IDEs
2. Created an ANTHROPIC_MODEL constant in clients to avoid updating a model in 2 places
3. Added a package description to the Python MCP client
4. Upgraded many package versions, especially the MCP ones
@a-akimov a-akimov requested a review from zckly October 14, 2025 15:11
@a-akimov a-akimov added enhancement New feature or request dependencies Pull requests that update a dependency file labels Oct 14, 2025
@a-akimov a-akimov self-assigned this Oct 14, 2025
Copy link
Copy Markdown
Member

@jonathanhefner jonathanhefner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Added .idea to gitignore to support those working in JetBrains IDEs
  • Created an ANTHROPIC_MODEL constant in clients to avoid updating a model in 2 places
  • Added a package description to the Python MCP client
  • Upgraded many package versions, especially the MCP ones

I think these are good changes, but I would say split them into separate PRs, or at least separate commits in the same PR. Even though the changes aren't likely to cause issues, it is helpful to be able to reference, bisect, and/or revert individual commits.

@a-akimov
Copy link
Copy Markdown
Contributor Author

a-akimov commented Nov 9, 2025

Hi @jonathanhefner, thank you for your feedback. I've split it into several PRs for better traceability, so I will close this one.

#65 Fix a placeholder description for the MCP client
#66 Add .idea to the global .gitignore
#67 Refactor the Python client to define the model only once
#68 Refactor the Node client to define the model only once
#69 Python server upgrade dependencies
#70 Python client upgrade dependencies

@a-akimov a-akimov closed this Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants