-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QC check for cross-species analog #8790
Comments
We use hgnc for human, and ncbigene for animals - we do not know, at least in the ontology as it is right now - whether two genes are orthologous, so we cant build a test around that. The QC check though is reasonable, @twhetzel will take a stab at it! |
Thank you @matentzn and @twhetzel! @twhetzel - chatgpt and I wrote some SPARQL queries to:
Can you take a look at these and see what I did right or wrong as a starting point for the QC check? |
Sure @katiermullen! Can you point me to the files to review? |
Hi @katiermullen - I had time to look into this and have worked some things out and also have some questions. Do you want separate queries for "Find all non-human animal diseases with cross-species analogs to a human disease" and then also "Find all non-human animal diseases with cross-species analogs to a human disease where that human disease has a gene association"? Also, are these queries intended to be run as reports or as part of the Mondo QC checks that are run with each Mondo PR? |
Thank you @twhetzel! I would like to have two separate queries:
|
Thanks Katie. I will treat these as queries for information until we hear back from Sabrina about (2) Find all non-human animal diseases with cross-species analogs to a human disease where that human disease has a gene association. |
I pushed a minor refactor of In order to get all results though, I had to use the reasoned version of the ontology which uses the format |
For the query to get the cross-species analogs where there is a gene or some value from the list of specific properties, I pushed a separate query for comparison. In the original query, there is an OPTIONAL statement and I am not sure what is intended there. Also, I do not think that all of the RO properties would have a gene as the object, but included them all since they were in the original. |
@katiermullen let me know if you have any questions about the changes in the PR |
Consider adding a QC check for non-human animal terms that have a cross-species analog term to a human disease with a germline mutation axioms.
Generally, non-human animal diseases should not have cross-species analogs to human diseases with germline mutations:
Example: MONDO:1010291 'achondroplasia, non-human animal' should not have cross-species analog to MONDO:0007037 'achondroplasia' because 'achondroplasia' has material basis in germline mutation in some FGFR3 and 'achondroplasia, non-human animal' does not.
Question: What about cases where the non-human animal disease has a germline mutation in an orthologous gene? Do these relationships belong in the ontology or only in the KG?
Example: Should MONDO:1012791 'osteogenesis imperfecta, COL1A2-related, dog' have cross-species analog to NTR 'COL1A2-related osteogenesis imperfecta' in issue #8757?
@sabrinatoro @nicolevasilevsky
The text was updated successfully, but these errors were encountered: