RUST-1398 Pin clippy version to 1.62.0 (#366)

Author: isabelatkinson

.evergreen/check-clippy.sh

@@ -4,7 +4,12 @@ set -o errexit
 
 . ~/.cargo/env
 
-cargo clippy --all-targets --all-features -p bson -- -D warnings
+# Pin clippy to the latest version. This should be updated when new versions of Rust are released.
+CLIPPY_VERSION=1.62.0
+
+rustup install $CLIPPY_VERSION
+
+cargo +$CLIPPY_VERSION clippy --all-targets --all-features -p bson -- -D warnings
 
 cd serde-tests
-cargo clippy --all-targets --all-features -p serde-tests -- -D warnings
+cargo +$CLIPPY_VERSION clippy --all-targets --all-features -p serde-tests -- -D warnings

src/datetime.rs

@@ -292,7 +292,7 @@ impl crate::DateTime {
         } else {
             // need to convert to i128 before calculating absolute value since i64::MIN.abs()
             // overflows and panics.
-            SystemTime::UNIX_EPOCH - Duration::from_millis((self.0 as i128).abs() as u64)
+            SystemTime::UNIX_EPOCH - Duration::from_millis((self.0 as i128).unsigned_abs() as u64)
         }
     }
 

src/de/raw.rs

@@ -1673,7 +1673,7 @@ struct RawBsonDeserializer<'a> {
     value: BsonContent<'a>,
 }
 
-impl<'de, 'a> serde::de::Deserializer<'de> for RawBsonDeserializer<'de> {
+impl<'de> serde::de::Deserializer<'de> for RawBsonDeserializer<'de> {
     type Error = Error;
 
     fn deserialize_any<V>(self, visitor: V) -> Result<V::Value>

src/document.rs

@@ -165,7 +165,7 @@ impl FromIterator<(String, Bson)> for Document {
     }
 }
 
-impl<'a> Iterator for IntoIter {
+impl Iterator for IntoIter {
     type Item = (String, Bson);
 
     fn next(&mut self) -> Option<(String, Bson)> {

src/raw/bson.rs

@@ -447,7 +447,7 @@ impl Serialize for RawBson {
     }
 }
 
-impl<'a> TryFrom<RawBson> for Bson {
+impl TryFrom<RawBson> for Bson {
     type Error = Error;
 
     fn try_from(rawbson: RawBson) -> Result<Bson> {

src/raw/test/mod.rs

@@ -249,7 +249,7 @@ fn null() {
     let rawdoc = rawdoc! {
         "null": null,
     };
-    let () = rawdoc
+    rawdoc
         .get("null")
         .expect("error finding key null")
         .expect("no key null")

src/tests/modules/bson.rs

@@ -433,7 +433,7 @@ fn system_time() {
     );
     assert_eq!(
         crate::DateTime::MIN.to_system_time(),
-        SystemTime::UNIX_EPOCH - Duration::from_millis((i64::MIN as i128).abs() as u64)
+        SystemTime::UNIX_EPOCH - Duration::from_millis((i64::MIN as i128).unsigned_abs() as u64)
     );
 
     assert_eq!(