Skip to content

Commit 34e799a

Browse files
committed
add admin_views w/ObjectIdAutoField.to_python() fix for string integers
1 parent 0d45d29 commit 34e799a

File tree

3 files changed

+19
-5
lines changed

3 files changed

+19
-5
lines changed

.github/workflows/test-python1.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ jobs:
5555
admin_ordering
5656
admin_scripts
5757
admin_utils
58+
admin_views
5859
admin_widgets
5960
apps
6061
async

django_mongodb/features.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,11 @@ def django_test_expected_failures(self):
252252
"update.tests.AdvancedTests.test_update_ordered_by_m2m_annotation_desc",
253253
},
254254
"QuerySet.dates() is not supported on MongoDB.": {
255+
"admin_views.tests.AdminViewBasicTest.test_change_list_sorting_override_model_admin",
256+
"admin_views.tests.AdminViewBasicTest.test_multiple_sort_same_field",
257+
"admin_views.tests.AdminViewListEditable.test_inheritance",
258+
"admin_views.tests.CSSTest.test_changelist_field_classes",
259+
"admin_views.tests.DateHierarchyTests",
255260
"aggregation.tests.AggregateTestCase.test_dates_with_aggregation",
256261
"annotations.tests.AliasTests.test_dates_alias",
257262
"aggregation_regress.tests.AggregationTests.test_more_more_more2",
@@ -294,6 +299,11 @@ def django_test_expected_failures(self):
294299
"queryset_pickle.tests.PickleabilityTestCase.test_specialized_queryset",
295300
},
296301
"QuerySet.datetimes() is not supported on MongoDB.": {
302+
"admin_views.test_templatetags.DateHierarchyTests",
303+
"admin_views.test_templatetags.AdminTemplateTagsTest.test_override_change_list_template_tags",
304+
"admin_views.tests.AdminViewBasicTest.test_date_hierarchy_empty_queryset",
305+
"admin_views.tests.AdminViewBasicTest.test_date_hierarchy_local_date_differ_from_utc",
306+
"admin_views.tests.AdminViewBasicTest.test_date_hierarchy_timezone_dst",
297307
"annotations.tests.AliasTests.test_datetimes_alias",
298308
"datetimes.tests.DateTimesTests.test_21432",
299309
"datetimes.tests.DateTimesTests.test_datetimes_has_lazy_iterator",

django_mongodb/fields/auto.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,14 @@ def to_python(self, value):
4040
try:
4141
return ObjectId(value)
4242
except errors.InvalidId:
43-
raise exceptions.ValidationError(
44-
self.error_messages["invalid"],
45-
code="invalid",
46-
params={"value": value},
47-
) from None
43+
try:
44+
return int(value)
45+
except ValueError:
46+
raise exceptions.ValidationError(
47+
self.error_messages["invalid"],
48+
code="invalid",
49+
params={"value": value},
50+
) from None
4851

4952
@cached_property
5053
def validators(self):

0 commit comments

Comments
 (0)