fix efficiency of QuerySet.bulk_create()

Author: timgraham

.github/workflows/test-python.yml

@@ -70,6 +70,7 @@ jobs:
           auth_tests.test_models.UserManagerTestCase
           backends.base.test_base.DatabaseWrapperTests
           basic
+          bulk_create
           dates
           datetimes
           empty

django_mongodb/compiler.py

@@ -189,9 +189,7 @@ def get_collection(self):
 class SQLInsertCompiler(SQLCompiler):
     def execute_sql(self, returning_fields=None):
         self.pre_sql_setup()
-
-        # pk_field = self.query.get_meta().pk
-        keys = []
+        objs = []
         for obj in self.query.objs:
             field_values = {}
             for field in self.query.fields:
@@ -207,18 +205,16 @@ def execute_sql(self, returning_fields=None):
                     )
 
                 field_values[field.column] = value
-            # TODO: pass the key value through db converters (use pk_field).
-            keys.append(self.insert(field_values, returning_fields=returning_fields))
-
-        return keys
+            objs.append(field_values)
+        return [self.insert(objs, returning_fields=returning_fields)]
 
     @wrap_database_errors
-    def insert(self, doc, returning_fields=None):
-        """Store a document using field columns as element names."""
+    def insert(self, docs, returning_fields=None):
+        """Store a list of documents using field columns as element names."""
         collection = self.get_collection()
         options = self.connection.operation_flags.get("save", {})
-        inserted_id = collection.insert_one(doc, **options).inserted_id
-        return [inserted_id] if returning_fields else []
+        inserted_ids = collection.insert_many(docs, **options).inserted_ids
+        return inserted_ids if returning_fields else []
 
 
 class SQLDeleteCompiler(SQLCompiler):

django_mongodb/features.py

@@ -4,6 +4,7 @@
 class DatabaseFeatures(BaseDatabaseFeatures):
     supports_date_lookup_using_string = False
     supports_foreign_keys = False
+    supports_ignore_conflicts = False
     # Not implemented: https://github.com/mongodb-labs/django-mongodb/issues/8
     supports_json_field = False
     # Not implemented: https://github.com/mongodb-labs/django-mongodb/issues/7
@@ -63,6 +64,10 @@ class DatabaseFeatures(BaseDatabaseFeatures):
     }
 
     django_test_skips = {
+        "Insert expressions aren't supported.": {
+            "bulk_create.tests.BulkCreateTests.test_bulk_insert_now",
+            "bulk_create.tests.BulkCreateTests.test_bulk_insert_expressions",
+        },
         "Pattern lookups on UUIDField are not supported.": {
             "model_fields.test_uuid.TestQuerying.test_contains",
             "model_fields.test_uuid.TestQuerying.test_endswith",
@@ -82,6 +87,7 @@ class DatabaseFeatures(BaseDatabaseFeatures):
             "update.tests.AdvancedTests.test_update_transformed_field",
         },
         "AutoField not supported.": {
+            "bulk_create.tests.BulkCreateTests.test_bulk_insert_nullable_fields",
             "lookup.tests.LookupTests.test_in_ignore_none_with_unhashable_items",
             "model_fields.test_autofield.AutoFieldTests",
             "model_fields.test_autofield.BigAutoFieldTests",

django_mongodb/utils.py

@@ -84,7 +84,7 @@ def wrapper(self, *args, **kwargs):
 
     # These are the operations that this backend uses.
     count_documents = logging_wrapper("count_documents")
-    insert_one = logging_wrapper("insert_one")
+    insert_many = logging_wrapper("insert_many")
     delete_many = logging_wrapper("delete_many")
     update_many = logging_wrapper("update_many")