Skip to content

Commit eff5bb7

Browse files
committed
forms: max_length -> max_num
1 parent 18c9d58 commit eff5bb7

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

django_mongodb_backend/fields/embedded_model_array.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,14 @@ def get_db_prep_value(self, value, connection, prepared=False):
3636
return value
3737

3838
def formfield(self, **kwargs):
39-
# Skip ArrayField.formfield() which has unneeded base_field.
39+
# Skip ArrayField.formfield() which has some differeences, including
40+
# unneeded "base_field" and "max_length" instea d of "max_num".
4041
return Field.formfield(
4142
self,
4243
**{
4344
"form_class": forms.EmbeddedModelArrayField,
4445
"model": self.base_field.embedded_model,
45-
"max_length": self.max_size,
46+
"max_num": self.max_size,
4647
"prefix": self.name,
4748
**kwargs,
4849
},

django_mongodb_backend/forms/fields/embedded_model_array.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ def models_to_dicts(models):
1414

1515

1616
class EmbeddedModelArrayField(forms.Field):
17-
def __init__(self, model, prefix, max_length=None, *args, **kwargs):
17+
def __init__(self, model, prefix, max_num=None, *args, **kwargs):
1818
self.model = model
1919
self.prefix = prefix
2020
self.formset = formset_factory(
2121
form=modelform_factory(model, fields="__all__"),
2222
can_delete=True,
23-
max_num=max_length,
23+
max_num=max_num,
2424
extra=3,
2525
validate_max=True,
2626
)

docs/source/ref/forms.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Some MongoDB-specific fields are available in ``django_mongodb_backend.forms``.
2626
``EmbeddedModelArrayField``
2727
---------------------------
2828

29-
.. class:: EmbeddedModelArrayField(model, prefix, max_length=None, **kwargs)
29+
.. class:: EmbeddedModelArrayField(model, prefix, max_num=None, **kwargs)
3030

3131
.. versionadded:: 5.2.0b1
3232

@@ -43,7 +43,7 @@ Some MongoDB-specific fields are available in ``django_mongodb_backend.forms``.
4343
in this field's subform will have so that the names don't collide with
4444
fields in the main form.
4545

46-
.. attribute:: max_length
46+
.. attribute:: max_num
4747

4848
This is an optional argument which validates that the array does not
4949
exceed the stated length.

0 commit comments

Comments
 (0)