Add explicit client closure to V1 Lambdas (#840)

* Update jobs.ts

* [fix] Make linter happy

* Deploy to preprd

* Await client.close invocation

* Consolidate logic

Author: casthewiz

.github/workflows/deploy-stg-ecs.yml

@@ -3,6 +3,7 @@ on:
     branches:
       - "master"
       - "integration"
+      - "close-lambda-mdb-clients"
 concurrency:
   group: environment-stg-${{ github.ref }}
   cancel-in-progress: true

api/controllers/v1/jobs.ts

@@ -19,22 +19,26 @@ export const TriggerLocalBuild = async (event: any = {}, context: any = {}): Pro
   const consoleLogger = new ConsoleLogger();
   const sqs = new SQSConnector(consoleLogger, c);
   const body = JSON.parse(event.body);
+  let resp = {};
   try {
     consoleLogger.info(body.jobId, 'enqueuing Job');
     await sqs.sendMessage(new JobQueueMessage(body.jobId, JobStatus.inQueue), c.get('jobUpdatesQueueUrl'), 0);
     consoleLogger.info(body.jobId, 'Job Queued Job');
-    return {
+    resp = {
       statusCode: 202,
       headers: { 'Content-Type': 'text/plain' },
       body: body.jobId,
     };
   } catch (err) {
     consoleLogger.error('TriggerLocalBuild', err);
-    return {
+    resp = {
       statusCode: 500,
       headers: { 'Content-Type': 'text/plain' },
       body: err,
     };
+  } finally {
+    await client.close();
+    return resp;
   }
 };
 
@@ -108,6 +112,8 @@ export const FailStuckJobs = async () => {
     await jobRepository.failStuckJobs(hours);
   } catch (err) {
     consoleLogger.error('FailStuckJobs', err);
+  } finally {
+    await client.close();
   }
 };
 
@@ -126,6 +132,8 @@ async function saveTaskId(jobId: string, taskExecutionRes: any, consoleLogger: C
     await jobRepository.addTaskIdToJob(jobId, taskId);
   } catch (err) {
     consoleLogger.error('saveTaskId', err);
+  } finally {
+    await client.close();
   }
 }
 
@@ -181,6 +189,7 @@ async function NotifyBuildSummary(jobId: string): Promise<any> {
     ),
     entitlement['slack_user_id']
   );
+  await client.close();
   return {
     statusCode: 200,
   };
@@ -284,6 +293,7 @@ async function NotifyBuildProgress(jobId: string): Promise<any> {
     ),
     entitlement['slack_user_id']
   );
+  await client.close();
   return {
     statusCode: 200,
   };
@@ -333,4 +343,5 @@ async function SubmitArchiveJob(jobId: string) {
     repo.prefix[environment]
   );
   consoleLogger.info('submit archive job', JSON.stringify({ jobId: jobId, batchJobId: response.jobId }));
+  await client.close();
 }