Use DB tx manager in ManagesTransactions trait

`DatabaseTransactionsManager` was introduced in Laravel to keep track of
things like pending transactions and fire transaction events, so that
e.g. dispatches could hook into transaction state.

Our trait was not using it yet, resulting in missing `afterCommit`
behavior (see PHPLIB-373)

Author: paulinevos

src/Concerns/ManagesTransactions.php

@@ -55,6 +55,8 @@ private function getSessionOrThrow(): Session
      */
     public function beginTransaction(array $options = []): void
     {
+        $this->transactionsManager?->begin($this->getName(), 0);
+
         $this->getSessionOrCreate()->startTransaction($options);
         $this->transactions = 1;
     }
@@ -65,6 +67,8 @@ public function beginTransaction(array $options = []): void
     public function commit(): void
     {
         $this->getSessionOrThrow()->commitTransaction();
+
+        $this->transactionsManager?->commit($this->getName(), 0, 0);
         $this->transactions = 0;
     }
 
@@ -88,6 +92,8 @@ public function transaction(Closure $callback, $attempts = 1, array $options = [
         $callbackResult = null;
         $throwable      = null;
 
+        $this->transactionsManager?->begin($this->getName(), 0);
+
         $callbackFunction = function (Session $session) use ($callback, &$attemptsLeft, &$callbackResult, &$throwable) {
             $attemptsLeft--;
 
@@ -113,6 +119,8 @@ public function transaction(Closure $callback, $attempts = 1, array $options = [
             throw $throwable;
         }
 
+        $this->transactionsManager?->commit($this->getName(), 0, 0);
+
         return $callbackResult;
     }
 }

tests/Ticket/GH3328Test.php

@@ -0,0 +1,91 @@
+<?php
+
+namespace MongoDB\Laravel\Tests\Ticket;
+
+use Exception;
+use Illuminate\Contracts\Events\ShouldDispatchAfterCommit;
+use Illuminate\Foundation\Events\Dispatchable;
+use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Facades\Event;
+use MongoDB\Laravel\Tests\TestCase;
+
+use function event;
+
+/**
+ * @see https://github.com/mongodb/laravel-mongodb/issues/3328
+ * @see https://jira.mongodb.org/browse/PHPORM-373
+ */
+class GH3328Test extends TestCase
+{
+    public function testAfterCommitOnSuccessfulTransaction(): void
+    {
+        Event::fake();
+
+        try {
+            DB::transaction(static function (): void {
+                event(new RegularEvent());
+                event(new AfterCommitEvent());
+            });
+        } catch (Exception) {
+        }
+
+        Event::assertDispatched(RegularEvent::class);
+        Event::assertDispatched(AfterCommitEvent::class);
+    }
+
+    public function testAfterCommitOnFailedTransaction(): void
+    {
+        Event::fake();
+
+        try {
+            DB::transaction(static function (): void {
+                event(new RegularEvent());
+                event(new AfterCommitEvent());
+
+                throw new Exception('Transaction failed; after commit event should not be dispatched');
+            });
+        } catch (Exception) {
+        }
+
+        Event::assertDispatched(RegularEvent::class);
+        Event::assertNotDispatched(AfterCommitEvent::class);
+    }
+
+    public function testAfterCommitOnSuccessfulManualTransaction(): void
+    {
+        Event::fake();
+
+        DB::beginTransaction();
+
+        event(new RegularEvent());
+        event(new AfterCommitEvent());
+
+        DB::commit();
+
+        Event::assertDispatched(RegularEvent::class);
+        Event::assertDispatched(AfterCommitEvent::class);
+    }
+
+    public function testAfterCommitOnUncommitedManualTransaction(): void
+    {
+        Event::fake();
+
+        DB::beginTransaction();
+
+        event(new RegularEvent());
+        event(new AfterCommitEvent());
+
+        Event::assertDispatched(RegularEvent::class);
+        Event::assertNotDispatched(AfterCommitEvent::class);
+    }
+}
+
+class AfterCommitEvent implements ShouldDispatchAfterCommit
+{
+    use Dispatchable;
+}
+
+class RegularEvent
+{
+    use Dispatchable;
+}