staticcheck: fix warnings in x/mongo/driver/topology

Author: prestonvasquez

x/mongo/driver/topology/CMAP_spec_test.go

@@ -428,6 +428,7 @@ func runOperationInThread(t *testing.T, operation map[string]any, testInfo *test
 		}
 
 		for {
+			// nolint:staticcheck // QF1006: staticcheck solution onflicts with revive
 			if atomic.LoadInt32(&thread.JobsCompleted) == atomic.LoadInt32(&thread.JobsAssigned) {
 				break
 			}

x/mongo/driver/topology/connection.go

@@ -654,7 +654,7 @@ var (
 	_ driver.Expirable     = (*Connection)(nil)
 )
 
-// WriteWireMessage handles writing a wire message to the underlying connection.
+// Write handles writing a wire message to the underlying connection.
 func (c *Connection) Write(ctx context.Context, wm []byte) error {
 	c.mu.RLock()
 	defer c.mu.RUnlock()
@@ -664,8 +664,8 @@ func (c *Connection) Write(ctx context.Context, wm []byte) error {
 	return c.connection.writeWireMessage(ctx, wm)
 }
 
-// ReadWireMessage handles reading a wire message from the underlying connection. The dst parameter
-// will be overwritten with the new wire message.
+// Read handles reading a wire message from the underlying connection. The dst
+// parameter will be overwritten with the new wire message.
 func (c *Connection) Read(ctx context.Context) ([]byte, error) {
 	c.mu.RLock()
 	defer c.mu.RUnlock()

x/mongo/driver/topology/server_test.go

@@ -365,7 +365,7 @@ func TestServerConnectionTimeout(t *testing.T) {
 }
 
 func TestServer(t *testing.T) {
-	var serverTestTable = []struct {
+	serverTestTable := []struct {
 		name            string
 		connectionError bool
 		networkError    bool
@@ -1280,7 +1280,7 @@ func includesClientMetadata(t *testing.T, wm []byte) bool {
 		t.Fatal("could not read numberToReturn")
 	}
 	var query bsoncore.Document
-	query, wm, ok = wiremessage.ReadQueryQuery(wm)
+	query, _, ok = wiremessage.ReadQueryQuery(wm)
 	if !ok {
 		t.Fatal("could not read query")
 	}

x/mongo/driver/topology/topology.go

@@ -549,10 +549,10 @@ func (t *Topology) SelectServer(ctx context.Context, ss description.ServerSelect
 			// try again if there are no servers available
 			if mustLogServerSelection(t, logger.LevelInfo) {
 				elapsed := time.Since(startTime)
-				remainingTimeMS := t.cfg.ServerSelectionTimeout - elapsed
+				remainingTime := t.cfg.ServerSelectionTimeout - elapsed
 
 				logServerSelection(ctx, t, logger.LevelInfo, logger.ServerSelectionWaiting, ss,
-					logger.KeyRemainingTimeMS, remainingTimeMS.Milliseconds())
+					logger.KeyRemainingTimeMS, remainingTime.Milliseconds())
 			}
 
 			continue
@@ -687,7 +687,6 @@ func (t *Topology) selectServerFromSubscription(
 	subscriptionCh <-chan description.Topology,
 	srvSelector description.ServerSelector,
 ) ([]description.Server, error) {
-
 	current := t.Description()
 	for {
 		select {
@@ -713,7 +712,6 @@ func (t *Topology) selectServerFromDescription(
 	desc description.Topology,
 	srvSelector description.ServerSelector,
 ) ([]description.Server, error) {
-
 	// Unlike selectServerFromSubscription, this code path does not check ctx.Done or selectionState.timeoutChan because
 	// selecting a server from a description is not a blocking operation.