Skip to content

Commit 2094b17

Browse files
authored
Go back to default distinct_id (#915)
1 parent cc203a3 commit 2094b17

File tree

4 files changed

+30
-9
lines changed

4 files changed

+30
-9
lines changed

packages/inspection-capture-web/src/hooks/useTracking.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ export function useTracking({ inspectionId, authToken }: TrackingParams) {
2525
const monitoring = useMonitoring();
2626

2727
useEffect(() => {
28-
analytics.setUserId(inspectionId);
2928
monitoring.setTags({
3029
inspectionId,
3130
});

packages/inspection-capture-web/test/hooks/useTracking.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ describe('useTracking hook', () => {
2424
const analytics = (useAnalytics as jest.Mock).mock.results[0].value;
2525
const monitoring = (useMonitoring as jest.Mock).mock.results[0].value;
2626

27-
expect(analytics.setUserId).toBeCalledWith(initialProps.inspectionId);
2827
expect(monitoring.setTags).toBeCalledWith({ inspectionId: initialProps.inspectionId });
2928

3029
expect(analytics.setUserProperties).toBeCalledWith({ authToken: monkJwtPayloadMock.sub });
@@ -40,7 +39,6 @@ describe('useTracking hook', () => {
4039
const analytics = (useAnalytics as jest.Mock).mock.results[0].value;
4140
const monitoring = (useMonitoring as jest.Mock).mock.results[0].value;
4241

43-
expect(analytics.setUserId).toBeCalledWith(initialProps.inspectionId);
4442
expect(monitoring.setTags).toBeCalledWith({ inspectionId: initialProps.inspectionId });
4543

4644
expect(analytics.setUserProperties).not.toBeCalled();

packages/posthog/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"dependencies": {
3434
"@monkvision/analytics": "5.0.7",
3535
"@monkvision/types": "5.0.7",
36-
"posthog-js": "^1.139.1"
36+
"posthog-js": "^1.232.0"
3737
},
3838
"peerDependencies": {
3939
"react": "^17.0.2",

yarn.lock

Lines changed: 29 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3872,7 +3872,7 @@ __metadata:
38723872
eslint-utils: ^3.0.0
38733873
jest: ^29.3.1
38743874
mkdirp: ^1.0.4
3875-
posthog-js: ^1.139.1
3875+
posthog-js: ^1.232.0
38763876
prettier: ^2.7.1
38773877
regexpp: ^3.2.0
38783878
rimraf: ^3.0.2
@@ -8324,6 +8324,13 @@ __metadata:
83248324
languageName: node
83258325
linkType: hard
83268326

8327+
"core-js@npm:^3.38.1":
8328+
version: 3.41.0
8329+
resolution: "core-js@npm:3.41.0"
8330+
checksum: 05331e92f354d3b92fa296fb3fc90c7b25d1a65230046c68651be29d67245bb156bdde7bf5c8cf8b3ecddfff93273a9ba6567f5e4ee6ceb70f39cee430693509
8331+
languageName: node
8332+
linkType: hard
8333+
83278334
"core-util-is@npm:~1.0.0":
83288335
version: 1.0.3
83298336
resolution: "core-util-is@npm:1.0.3"
@@ -17797,13 +17804,23 @@ __metadata:
1779717804
languageName: node
1779817805
linkType: hard
1779917806

17800-
"posthog-js@npm:^1.139.1":
17801-
version: 1.139.1
17802-
resolution: "posthog-js@npm:1.139.1"
17807+
"posthog-js@npm:^1.232.0":
17808+
version: 1.232.0
17809+
resolution: "posthog-js@npm:1.232.0"
1780317810
dependencies:
17811+
core-js: ^3.38.1
1780417812
fflate: ^0.4.8
1780517813
preact: ^10.19.3
17806-
checksum: 365f0aac0d7db27530bf58737211f9fc222c5ef81b34c9ab9a9c76f85877f8def3bb8630da7a2b6688fd961b6b4388902f189611e156cc11248ab88cdf1a3393
17814+
web-vitals: ^4.2.4
17815+
peerDependencies:
17816+
"@rrweb/types": 2.0.0-alpha.17
17817+
rrweb-snapshot: 2.0.0-alpha.17
17818+
peerDependenciesMeta:
17819+
"@rrweb/types":
17820+
optional: true
17821+
rrweb-snapshot:
17822+
optional: true
17823+
checksum: 8883b920aafc581c42c8cfd3f3d025755a4029e34fe8b4989932124fda07f34bdca6a7ed4dba1de744425e2ef98fdd8e94a76ddf626be3ff5c8c416398ff4891
1780717824
languageName: node
1780817825
linkType: hard
1780917826

@@ -21810,6 +21827,13 @@ __metadata:
2181021827
languageName: node
2181121828
linkType: hard
2181221829

21830+
"web-vitals@npm:^4.2.4":
21831+
version: 4.2.4
21832+
resolution: "web-vitals@npm:4.2.4"
21833+
checksum: 5b3ffe1db33f23aebf8cc8560ac574401a95939baafde5841835c1bb1c01f9a2478442f319f77aa0d7914739fc2f6b020c5d5b128c16c5c77ca6be2f9dfbbde6
21834+
languageName: node
21835+
linkType: hard
21836+
2181321837
"webidl-conversions@npm:^3.0.0":
2181421838
version: 3.0.1
2181521839
resolution: "webidl-conversions@npm:3.0.1"

0 commit comments

Comments
 (0)