Remove the toolbar button

This feature should only be in the Insert menu.

Author: timhunt

amd/build/commands.min.js

@@ -67,13 +67,6 @@ const registerManagerCommand = async(editor, buttonText, buttonImage) => {
     };
 
     editor.ui.registry.addIcon(icon, buttonImage.html);
-    editor.ui.registry.addButton(buttonName, {
-        icon: icon,
-        tooltip: buttonText,
-        onAction: async() => {
-            await handleDialogManager();
-        }
-    });
 
     editor.ui.registry.addMenuItem(buttonName, {
         icon: icon,
@@ -82,20 +75,4 @@ const registerManagerCommand = async(editor, buttonText, buttonImage) => {
             await handleDialogManager();
         }
     });
-
-    // Register the Menu Button as a toggle.
-    editor.ui.registry.addToggleButton(buttonName, {
-        icon: icon,
-        tooltip: buttonText,
-        onAction: async() => {
-            await handleDialogManager();
-        },
-        onSetup: (api) => {
-            editor.on('NodeChange', () => {
-                const dialog = new DialogManager(editor);
-                // Set the button to be active if the current selection matches the embed question code format.
-                api.setActive(!!dialog.getEmbedCodeFromTextSelection(editor));
-            });
-        },
-    });
 };

amd/build/commands.min.js.map

@@ -22,18 +22,7 @@
  */
 
 import {buttonName} from './common';
-import {addMenubarItem, addToolbarButton} from 'editor_tiny/utils';
-
-/**
- * This function control where the button is display in the editor.
- *
- * @param {Object} toolbar
- * @returns {addToolbarButton}
- */
-const configureToolbar = (toolbar) => {
-    toolbar = addToolbarButton(toolbar, 'formatting', buttonName);
-    return toolbar;
-};
+import {addMenubarItem} from 'editor_tiny/utils';
 
 /**
  * This function control where the button is display in the menu bar of the editor.
@@ -43,7 +32,6 @@ const configureToolbar = (toolbar) => {
  */
 export const configure = (instanceConfig) => {
     return {
-        toolbar: configureToolbar(instanceConfig.toolbar),
         menu: addMenubarItem(instanceConfig.menu, 'insert', buttonName),
     };
 };

amd/build/configuration.min.js

@@ -29,7 +29,7 @@
  * @copyright   2024 The Open University
  * @license     https://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-class plugininfo extends plugin implements plugin_with_buttons, plugin_with_configuration {
+class plugininfo extends plugin implements plugin_with_configuration {
 
     public static function is_enabled(context $context, array $options, array $fpoptions,
             ?\editor_tiny\editor $editor = null): bool {
@@ -39,12 +39,6 @@ public static function is_enabled(context $context, array $options, array $fpopt
         return has_any_capability(['moodle/question:useall', 'moodle/question:usemine'], $context);
     }
 
-    public static function get_available_buttons(): array {
-        return [
-            'tiny_embedquestion',
-        ];
-    }
-
     public static function get_plugin_configuration_for_context(
         context $context,
         array $options,