300-medium-bugs.json

[
  {
    "repo": "microsoft/vscode",
    "prNumber": 218357,
    "prTitle": "Fix two bugs in #214589 fixing #213535.",
    "prLink": "https://github.com/microsoft/vscode/pull/218357",
    "commentAuthor": "alexr00",
    "commentBody": "I think now `this._commentThreadWidget` is never disposed. It can be added to the object's disposables by doing this when it's created:\n\n```ts\n\tprivate readonly _commentThreadWidget = this._register(new MutableDisposable<CommentThreadWidget<ICellRange>>);\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/microsoft/vscode/pull/218357#discussion_r1654875519",
    "filePath": "src/vs/workbench/contrib/notebook/browser/view/cellParts/cellComments.ts",
    "diffHunk": "@@ -108,7 +107,7 @@ export class CellComments extends CellContentPart {\n \t\tif (this._commentThreadWidget.value) {\n \t\t\tif (!info) {\n \t\t\t\tthis._commentThreadDisposables.clear();\n-\t\t\t\tthis._commentThreadWidget.dispose();\n+\t\t\t\tthis._commentThreadWidget.value = undefined;",
    "line": 30,
    "reactionCount": 0,
    "timestamp": "2024-06-26T13:43:44Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2141902990,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "rehmsen",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:07.772Z"
  },
  {
    "repo": "microsoft/vscode",
    "prNumber": 213252,
    "prTitle": "Fixes #44237: Add `columnNumber` variable",
    "prLink": "https://github.com/microsoft/vscode/pull/213252",
    "commentAuthor": "alexr00",
    "commentBody": "Just getting the end character doesn't actually give the column if there are characters that span more than one column, like tabs.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/microsoft/vscode/pull/213252#discussion_r1696728024",
    "filePath": "src/vs/workbench/api/common/extHostVariableResolverService.ts",
    "diffHunk": "@@ -100,20 +107,24 @@ class ExtHostVariableResolverService extends AbstractVariableResolverService {\n \t\t\t\treturn undefined;\n \t\t\t},\n \t\t\tgetSelectedText: (): string | undefined => {\n-\t\t\t\tif (editorService) {\n-\t\t\t\t\tconst activeEditor = editorService.activeEditor();\n-\t\t\t\t\tif (activeEditor && !activeEditor.selection.isEmpty) {\n-\t\t\t\t\t\treturn activeEditor.document.getText(activeEditor.selection);\n-\t\t\t\t\t}\n+\t\t\t\tconst selection = getSelection(editorService);\n+\t\t\t\tif (selection && !selection.isEmpty) {\n+\t\t\t\t\treturn editorService?.activeEditor()?.document.getText(selection);\n+\n \t\t\t\t}\n \t\t\t\treturn undefined;\n \t\t\t},\n \t\t\tgetLineNumber: (): string | undefined => {\n-\t\t\t\tif (editorService) {\n-\t\t\t\t\tconst activeEditor = editorService.activeEditor();\n-\t\t\t\t\tif (activeEditor) {\n-\t\t\t\t\t\treturn String(activeEditor.selection.end.line + 1);\n-\t\t\t\t\t}\n+\t\t\t\tconst selection = getSelection(editorService);\n+\t\t\t\tif (selection) {\n+\t\t\t\t\treturn String(selection.end.line + 1);\n+\t\t\t\t}\n+\t\t\t\treturn undefined;\n+\t\t\t},\n+\t\t\tgetColumnNumber: (): string | undefined => {\n+\t\t\t\tconst selection = getSelection(editorService);\n+\t\t\t\tif (selection) {\n+\t\t\t\t\treturn String(selection.end.character + 1);",
    "line": 45,
    "reactionCount": 1,
    "timestamp": "2024-07-30T10:29:01Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2207303007,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "keithel",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:08.405Z"
  },
  {
    "repo": "microsoft/vscode",
    "prNumber": 199220,
    "prTitle": "show tooltip on icon label keyboard focus ",
    "prLink": "https://github.com/microsoft/vscode/pull/199220",
    "commentAuthor": "Tyriar",
    "commentBody": "This doesn't get disposed",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/microsoft/vscode/pull/199220#discussion_r1406722403",
    "filePath": "src/vs/base/browser/ui/iconLabel/iconLabelHover.ts",
    "diffHunk": "@@ -219,6 +219,21 @@ export function setupCustomHover(hoverDelegate: IHoverDelegate, htmlElement: HTM\n \t\thoverPreparation = toDispose;\n \t};\n \tconst mouseOverDomEmitter = dom.addDisposableListener(htmlElement, dom.EventType.MOUSE_OVER, onMouseOver, true);\n+\n+\tconst onFocus = () => {\n+\t\tif (hoverPreparation) {\n+\t\t\treturn;\n+\t\t}\n+\t\tconst target: IHoverDelegateTarget = {\n+\t\t\ttargetElements: [htmlElement],\n+\t\t\tdispose: () => { }\n+\t\t};\n+\t\tconst toDispose: DisposableStore = new DisposableStore();",
    "line": 13,
    "reactionCount": 1,
    "timestamp": "2023-11-27T20:44:06Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1751323437,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "meganrogge",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:07.784Z"
  },
  {
    "repo": "microsoft/vscode",
    "prNumber": 179214,
    "prTitle": "Suggest uses aria-describedby for description",
    "prLink": "https://github.com/microsoft/vscode/pull/179214",
    "commentAuthor": "jrieken",
    "commentBody": " `_details.getId()` is unique only per editor instance so theoretically we have two different `ariaDescribedBy` attributes using the same id (of different dom nodes). Tho, practically this shouldn't happen because suggest needs focus but we could add an instance id to the details widget",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/microsoft/vscode/pull/179214#discussion_r1193676472",
    "filePath": "src/vs/editor/contrib/suggest/browser/suggestWidget.ts",
    "diffHunk": "@@ -708,6 +708,7 @@ export class SuggestWidget implements IDisposable {\n \t\tthis._pendingShowDetails.value = dom.runAtThisOrScheduleAtNextAnimationFrame(() => {\n \t\t\tthis._pendingShowDetails.clear();\n \t\t\tthis._details.show();\n+\t\t\tthis._list.ariaDescribedBy = this._details.getId();",
    "line": 4,
    "reactionCount": 0,
    "timestamp": "2023-05-15T11:01:01Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1426301855,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "jjaeggli",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:07.963Z"
  },
  {
    "repo": "microsoft/vscode",
    "prNumber": 191138,
    "prTitle": "Re #183449. Roaming kernel history.",
    "prLink": "https://github.com/microsoft/vscode/pull/191138",
    "commentAuthor": "rzhao271",
    "commentBody": "Should `linkedMap` get saved back to `this._mostRecentKernelsMap`?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/microsoft/vscode/pull/191138#discussion_r1303602713",
    "filePath": "src/vs/workbench/contrib/notebook/browser/services/notebookKernelHistoryServiceImpl.ts",
    "diffHunk": "@@ -79,12 +82,28 @@ export class NotebookKernelHistoryService extends Disposable implements INoteboo\n \n \t\tif (notEmpty) {\n \t\t\tconst serialized = this._serialize();\n-\t\t\tthis._storageService.store(NotebookKernelHistoryService.STORAGE_KEY, JSON.stringify(serialized), StorageScope.WORKSPACE, StorageTarget.MACHINE);\n+\t\t\tthis._storageService.store(NotebookKernelHistoryService.STORAGE_KEY, JSON.stringify(serialized), StorageScope.WORKSPACE, StorageTarget.USER);\n \t\t} else {\n \t\t\tthis._storageService.remove(NotebookKernelHistoryService.STORAGE_KEY, StorageScope.WORKSPACE);\n \t\t}\n \t}\n \n+\tprivate _restoreState(): void {\n+\t\tconst serialized = this._storageService.get(NotebookKernelHistoryService.STORAGE_KEY, StorageScope.WORKSPACE);\n+\t\tif (serialized) {\n+\t\t\ttry {\n+\t\t\t\tfor (const [viewType, kernels] of JSON.parse(serialized)) {\n+\t\t\t\t\tconst linkedMap = this._mostRecentKernelsMap[viewType] ?? new LinkedMap<string, string>();\n+\t\t\t\t\tfor (const entry of kernels.entries) {\n+\t\t\t\t\t\tlinkedMap.set(entry, entry, Touch.AsOld);\n+\t\t\t\t\t}",
    "line": 38,
    "reactionCount": 0,
    "timestamp": "2023-08-23T22:32:16Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1592500545,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "rebornix",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:07.750Z"
  },
  {
    "repo": "microsoft/vscode",
    "prNumber": 180527,
    "prTitle": "innosetup to start/stop tunnel service",
    "prLink": "https://github.com/microsoft/vscode/pull/180527",
    "commentAuthor": "joaomoreno",
    "commentBody": "Not setting the `StartTunnelService` variable in this `else` condition.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/microsoft/vscode/pull/180527#discussion_r1193927372",
    "filePath": "build/win32/code.iss",
    "diffHunk": "@@ -1359,14 +1375,50 @@ begin\n end;\n \n // Updates\n-function IsBackgroundUpdate(): Boolean;\n+\n+var\n+\tStartTunnelService: Boolean;\n+\n+procedure StopTunnelServiceIfNeeded();\n+var\n+\tStopServiceResultCode: Integer;\n+\tKillServiceResultCode: Integer;\n+\tWaitCounter: Integer;\n begin\n-  Result := ExpandConstant('{param:update|false}') <> 'false';\n+ \tif CheckForMutexes('{#TunnelServiceMutex}') then begin\n+\t\t// stop the tunnel service\n+\t\tLog('Stopping the tunnel service using ' + ExpandConstant('\"{app}\\bin\\{#ApplicationName}.cmd\"'));\n+\t\tShellExec('', ExpandConstant('\"{app}\\bin\\{#ApplicationName}.cmd\"'), 'tunnel service uninstall', '', SW_HIDE, ewWaitUntilTerminated, StopServiceResultCode);\n+\n+\t\t// issue 175268\n+\t\tShellExec('', ExpandConstant('\"{app}\\bin\\{#ApplicationName}.cmd\"'), 'tunnel kill', '', SW_HIDE, ewWaitUntilTerminated, KillServiceResultCode);\n+\n+\t\tLog('Stopping the tunnel service completed with result codes ' + IntToStr(StopServiceResultCode) + ' (uninstall) ' + IntToStr(KillServiceResultCode) + ' (kill) ');\n+\n+\t\tWaitCounter := 10\n+\t\twhile (WaitCounter > 0) and CheckForMutexes('{#TunnelServiceMutex}') do\n+\t\tbegin\n+\t\t\tLog('Tunnel service is still running, waiting');\n+\t\t\tSleep(500);\n+\t\t\tWaitCounter := WaitCounter - 1\n+\t\tend;\n+\t\tif (WaitCounter = 0) then\n+\t\t\tLog('Unable to stop tunnel service')\n+\t\telse",
    "line": 84,
    "reactionCount": 0,
    "timestamp": "2023-05-15T14:29:12Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1426693766,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "aeschli",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:10.205Z"
  },
  {
    "repo": "microsoft/vscode",
    "prNumber": 200775,
    "prTitle": "fix: don't reshow remote source picker after it's been cancelled",
    "prLink": "https://github.com/microsoft/vscode/pull/200775",
    "commentAuthor": "TylerLeonhardt",
    "commentBody": "this function has a few events that aren't getting disposed.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/microsoft/vscode/pull/200775#discussion_r1425766964",
    "filePath": "extensions/git-base/src/remoteSource.ts",
    "diffHunk": "@@ -70,12 +89,17 @@ class RemoteSourceProviderQuickPick {\n \t\t\tthis.quickpick!.items = [{ label: l10n.t('{0} Error: {1}', '$(error)', err.message), alwaysShow: true }];\n \t\t\tconsole.error(err);\n \t\t} finally {\n-\t\t\tthis.quickpick!.busy = false;\n+\t\t\tif (!this.isDisposed) {\n+\t\t\t\tthis.quickpick!.busy = false;\n+\t\t\t}\n \t\t}\n \t}\n \n \tasync pick(): Promise<RemoteSource | undefined> {\n \t\tawait this.query();\n+\t\tif (this.isDisposed) {\n+\t\t\treturn;\n+\t\t}\n \t\tconst result = await getQuickPickResult(this.quickpick!);",
    "line": 92,
    "reactionCount": 0,
    "timestamp": "2023-12-13T19:00:28Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1780299983,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "joyceerhl",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:10.060Z"
  },
  {
    "repo": "facebook/react-native",
    "prNumber": 41715,
    "prTitle": "Add `NDEBUG` flag for Release builds for both architectures",
    "prLink": "https://github.com/facebook/react-native/pull/41715",
    "commentAuthor": "cipolleschi",
    "commentBody": "The problem with the test is that, by removing these lines, the function `modify_flags_for_new_architecture` does not alter the `OTHER_CFLAGS` attribute anymore.\r\n\r\nSo, now, when we execute `modify_flags_for_new_architecture`, nothing access the `attribute[\"OTHER_CFLAGS\"]` which remains `nil`. Instead, the test that is failing expect to find the `\"$(inherithed)\"` string.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/facebook/react-native/pull/41715#discussion_r1410709003",
    "filePath": "packages/react-native/scripts/cocoapods/new_architecture.rb",
    "diffHunk": "@@ -49,18 +49,11 @@ def self.modify_flags_for_new_architecture(installer, is_new_arch_enabled)\n         unless is_new_arch_enabled\n             return\n         end\n-        ndebug_flag = \" -DNDEBUG\"\n         # Add RCT_NEW_ARCH_ENABLED to Target pods xcconfig\n         installer.aggregate_targets.each do |aggregate_target|\n             aggregate_target.xcconfigs.each do |config_name, config_file|\n                 config_file.attributes['OTHER_CPLUSPLUSFLAGS'] = @@new_arch_cpp_flags\n \n-                if config_name == \"Release\"\n-                    config_file.attributes['OTHER_CPLUSPLUSFLAGS'] = config_file.attributes['OTHER_CPLUSPLUSFLAGS'] + ndebug_flag\n-                    other_cflags = config_file.attributes['OTHER_CFLAGS'] != nil ? config_file.attributes['OTHER_CFLAGS'] : \"$(inherited)\"\n-                    config_file.attributes['OTHER_CFLAGS'] = other_cflags + ndebug_flag\n-                end",
    "line": 23,
    "reactionCount": 0,
    "timestamp": "2023-11-30T13:55:38Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1757525643,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "tjzel",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:09.868Z"
  },
  {
    "repo": "facebook/react-native",
    "prNumber": 41715,
    "prTitle": "Add `NDEBUG` flag for Release builds for both architectures",
    "prLink": "https://github.com/facebook/react-native/pull/41715",
    "commentAuthor": "cipolleschi",
    "commentBody": "The problem with the test is that, by removing these lines, the function `modify_flags_for_new_architecture` does not alter the `OTHER_CFLAGS` attribute anymore.\r\n\r\nSo, now, when we execute `modify_flags_for_new_architecture`, nothing access the `attribute[\"OTHER_CFLAGS\"]` which remains `nil`. Instead, the test that is failing expect to find the `\"$(inherithed)\"` string.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/facebook/react-native/pull/41715#discussion_r1410709003",
    "filePath": "packages/react-native/scripts/cocoapods/new_architecture.rb",
    "diffHunk": "@@ -49,18 +49,11 @@ def self.modify_flags_for_new_architecture(installer, is_new_arch_enabled)\n         unless is_new_arch_enabled\n             return\n         end\n-        ndebug_flag = \" -DNDEBUG\"\n         # Add RCT_NEW_ARCH_ENABLED to Target pods xcconfig\n         installer.aggregate_targets.each do |aggregate_target|\n             aggregate_target.xcconfigs.each do |config_name, config_file|\n                 config_file.attributes['OTHER_CPLUSPLUSFLAGS'] = @@new_arch_cpp_flags\n \n-                if config_name == \"Release\"\n-                    config_file.attributes['OTHER_CPLUSPLUSFLAGS'] = config_file.attributes['OTHER_CPLUSPLUSFLAGS'] + ndebug_flag\n-                    other_cflags = config_file.attributes['OTHER_CFLAGS'] != nil ? config_file.attributes['OTHER_CFLAGS'] : \"$(inherited)\"\n-                    config_file.attributes['OTHER_CFLAGS'] = other_cflags + ndebug_flag\n-                end",
    "line": 23,
    "reactionCount": 0,
    "timestamp": "2023-11-30T13:55:38Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1757525643,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "tjzel",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:09.868Z"
  },
  {
    "repo": "pandas-dev/pandas",
    "prNumber": 55764,
    "prTitle": "REGR: fix return class in _constructor_from_mgr for simple subclasses",
    "prLink": "https://github.com/pandas-dev/pandas/pull/55764",
    "commentAuthor": "jorisvandenbossche",
    "commentBody": "Although we have a `check_frame_type` (\"Whether to check the DataFrame class is identical.\") that defaults to True, that seems to only check that the left frame is an instance of the class of the right frame. So that won't actually catch the issue if `result` was still a subclass instead of a DataFrame.\r\n\r\nSo in addition I would add an explicit:\r\n```suggestion\r\n        assert type(result) is DataFrame\r\n        tm.assert_frame_equal(result, expected)\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/pandas-dev/pandas/pull/55764#discussion_r1386865607",
    "filePath": "pandas/tests/frame/test_subclass.py",
    "diffHunk": "@@ -773,3 +773,31 @@ def test_constructor_with_metadata():\n     )\n     subset = df[[\"A\", \"B\"]]\n     assert isinstance(subset, MySubclassWithMetadata)\n+\n+\n+class SimpleDataFrameSubClass(DataFrame):\n+    \"\"\"A subclass of DataFrame that does not define a constructor.\"\"\"\n+\n+\n+class SimpleSeriesSubClass(Series):\n+    \"\"\"A subclass of Series that does not define a constructor.\"\"\"\n+\n+\n+class TestSubclassWithoutConstructor:\n+    def test_copy_df(self):\n+        expected = DataFrame({\"a\": [1, 2, 3]})\n+        result = SimpleDataFrameSubClass(expected).copy()\n+\n+        tm.assert_frame_equal(result, expected)",
    "line": 22,
    "reactionCount": 0,
    "timestamp": "2023-11-08T16:04:51Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1720733857,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "ivirshup",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:53:46.613Z"
  },
  {
    "repo": "microsoft/vscode",
    "prNumber": 179178,
    "prTitle": "Add support for attachment cleaning on notebook save",
    "prLink": "https://github.com/microsoft/vscode/pull/179178",
    "commentAuthor": "rebornix",
    "commentBody": "It seems we didn't dipose the delayer on AttachmentCleaner.dispose",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/microsoft/vscode/pull/179178#discussion_r1157637645",
    "filePath": "extensions/ipynb/src/notebookAttachmentCleaner.ts",
    "diffHunk": "@@ -32,15 +32,10 @@ export class AttachmentCleaner implements vscode.CodeActionProvider {\n \n \tprivate _disposables: vscode.Disposable[];\n \tprivate _imageDiagnosticCollection: vscode.DiagnosticCollection;\n+\tprivate readonly _delayer = new Delayer(750);\n+",
    "line": 14,
    "reactionCount": 0,
    "timestamp": "2023-04-04T18:46:32Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1371568339,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "Yoyokrazy",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:11.812Z"
  },
  {
    "repo": "pandas-dev/pandas",
    "prNumber": 54527,
    "prTitle": "BUG: Special-case setting nan into integer series",
    "prLink": "https://github.com/pandas-dev/pandas/pull/54527",
    "commentAuthor": "jorisvandenbossche",
    "commentBody": "So one thing that this doesn't yet do, is checking for the proper range for lower bitwidth integers. \r\n\r\nFor example setting [1000.0, np.nan] into a int8 Series should still raise the warning because 1000 is too big, but this helper function will now say it are only integers or NaN.\r\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/pandas-dev/pandas/pull/54527#discussion_r1300156497",
    "filePath": "pandas/_libs/lib.pyx",
    "diffHunk": "@@ -530,6 +530,22 @@ def has_infs(floating[:] arr) -> bool:\n     return ret\n \n \n+@cython.boundscheck(False)\n+@cython.wraparound(False)\n+def has_only_ints_or_nan(floating[:] arr) -> bool:\n+    cdef:\n+        floating val\n+        intp_t i\n+\n+    for i in range(len(arr)):\n+        val = arr[i]\n+        if (val != val) or (val == <int64_t>val):\n+            continue\n+        else:\n+            return False\n+    return True",
    "line": 17,
    "reactionCount": 0,
    "timestamp": "2023-08-21T14:01:09Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1587066600,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "MarcoGorelli",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:11.995Z"
  },
  {
    "repo": "facebook/react",
    "prNumber": 15998,
    "prTitle": "Slightly improve performance of hydration.",
    "prLink": "https://github.com/facebook/react/pull/15998",
    "commentAuthor": "sebmarkbage",
    "commentBody": "This should actually have been `if (nodeType !== COMMENT_NODE) continue`. Logic is hard. :)",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/facebook/react/pull/15998#discussion_r310397709",
    "filePath": "packages/react-dom/src/client/ReactDOMHostConfig.js",
    "diffHunk": "@@ -670,44 +670,40 @@ export function registerSuspenseInstanceRetry(\n   instance._reactRetry = callback;\n }\n \n-export function getNextHydratableSibling(\n-  instance: HydratableInstance,\n-): null | HydratableInstance {\n-  let node = instance.nextSibling;\n+function getNextHydratable(node) {\n   // Skip non-hydratable nodes.\n-  while (\n-    node &&\n-    node.nodeType !== ELEMENT_NODE &&\n-    node.nodeType !== TEXT_NODE &&\n-    (!enableSuspenseServerRenderer ||\n-      node.nodeType !== COMMENT_NODE ||\n-      ((node: any).data !== SUSPENSE_START_DATA &&\n-        (node: any).data !== SUSPENSE_PENDING_START_DATA &&\n-        (node: any).data !== SUSPENSE_FALLBACK_START_DATA))\n-  ) {\n-    node = node.nextSibling;\n+  for (; node != null; node = node.nextSibling) {\n+    const nodeType = node.nodeType;\n+    if (nodeType === ELEMENT_NODE || nodeType === TEXT_NODE) {\n+      break;\n+    }\n+    if (enableSuspenseServerRenderer) {\n+      if (nodeType === COMMENT_NODE) {\n+        break;",
    "line": 28,
    "reactionCount": 1,
    "timestamp": "2019-08-04T18:05:53Z",
    "isReviewComment": true,
    "pullRequestReviewId": 270508436,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "bmeurer",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:12.043Z"
  },
  {
    "repo": "facebook/react",
    "prNumber": 13767,
    "prTitle": "Suspense settles even if timeout and ping coincide",
    "prLink": "https://github.com/facebook/react/pull/13767",
    "commentAuthor": "sebmarkbage",
    "commentBody": ":'( We compared mode to effect? Should've been `!== NoContext`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/facebook/react/pull/13767#discussion_r222691101",
    "filePath": "packages/react-reconciler/src/ReactFiberBeginWork.js",
    "diffHunk": "@@ -949,27 +949,19 @@ function updatePlaceholderComponent(\n \n     // Check if we already attempted to render the normal state. If we did,\n     // and we timed out, render the placeholder state.\n-    const alreadyCaptured =\n-      (workInProgress.effectTag & DidCapture) === NoEffect;\n+    const nextDidTimeout = workInProgress.updateQueue !== null;\n \n-    let nextDidTimeout;\n-    if (current !== null && workInProgress.updateQueue !== null) {\n-      if (enableSchedulerTracing) {\n+    if ((workInProgress.mode & StrictMode) === NoEffect) {\n+      if (enableSchedulerTracing && nextDidTimeout) {\n         // Handle special case of rendering a Placeholder for a sync, suspended tree.\n         // We flag this to properly trace and count interactions.\n         // Otherwise interaction pending count will be decremented too many times.\n         captureWillSyncRenderPlaceholder();\n       }\n-\n-      // We're outside strict mode. Something inside this Placeholder boundary\n-      // suspended during the last commit. Switch to the placholder.\n+      // The next time we render, we try the primary children again even if no\n+      // promise has timed out.\n       workInProgress.updateQueue = null;\n-      nextDidTimeout = true;\n     } else {\n-      nextDidTimeout = !alreadyCaptured;\n-    }\n-\n-    if ((workInProgress.mode & StrictMode) !== NoEffect) {",
    "line": 29,
    "reactionCount": 0,
    "timestamp": "2018-10-04T14:26:24Z",
    "isReviewComment": true,
    "pullRequestReviewId": 161639065,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "sophiebits",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:13.870Z"
  },
  {
    "repo": "facebook/react",
    "prNumber": 13534,
    "prTitle": "Make IE 11 not complain about non-crucial style attribute hydration mismatch",
    "prLink": "https://github.com/facebook/react/pull/13534",
    "commentAuthor": "gaearon",
    "commentBody": "This should be in try-finally. Even if test fails you want to delete it to avoid breaking other tests",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/facebook/react/pull/13534#discussion_r214876413",
    "filePath": "packages/react-dom/src/__tests__/ReactServerRenderingHydration.js",
    "diffHunk": "@@ -258,6 +258,67 @@ describe('ReactDOMServerHydration', () => {\n     expect(element.firstChild.focus).not.toHaveBeenCalled();\n   });\n \n+  it('should warn when the style property differs', () => {\n+    const element = document.createElement('div');\n+    element.innerHTML = ReactDOMServer.renderToString(\n+      <div style={{textDecoration: 'none', color: 'black', height: '10px'}} />,\n+    );\n+    expect(element.firstChild.style.textDecoration).toBe('none');\n+    expect(element.firstChild.style.color).toBe('black');\n+\n+    expect(() =>\n+      ReactDOM.hydrate(\n+        <div\n+          style={{textDecoration: 'none', color: 'white', height: '10px'}}\n+        />,\n+        element,\n+      ),\n+    ).toWarnDev(\n+      'Warning: Prop `style` did not match. Server: ' +\n+        '\"text-decoration:none;color:black;height:10px\" Client: ' +\n+        '\"text-decoration:none;color:white;height:10px\"',\n+      {withoutStack: true},\n+    );\n+  });\n+\n+  it('should not warn when the style property differs on whitespace or order in IE', () => {\n+    document.documentMode = 11;\n+    const element = document.createElement('div');\n+\n+    // Simulate IE normalizing the style attribute. IE makes it equal to\n+    // what's available under `node.style.cssText`.\n+    element.innerHTML =\n+      '<div style=\"height: 10px; color: black; text-decoration: none;\" data-reactroot=\"\"></div>';\n+\n+    ReactDOM.hydrate(\n+      <div style={{textDecoration: 'none', color: 'black', height: '10px'}} />,\n+      element,\n+    );\n+\n+    delete document.documentMode;",
    "line": 41,
    "reactionCount": 1,
    "timestamp": "2018-09-04T11:16:51Z",
    "isReviewComment": true,
    "pullRequestReviewId": 152017407,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "mgol",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:13.537Z"
  },
  {
    "repo": "facebook/react",
    "prNumber": 13745,
    "prTitle": "Remove useless code",
    "prLink": "https://github.com/facebook/react/pull/13745",
    "commentAuthor": "acdlite",
    "commentBody": "If `currentFirstChild !== null && currentFirstChild.tag !== HostText`, then yes we do need to delete the remaining children.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/facebook/react/pull/13745#discussion_r221139072",
    "filePath": "packages/react-reconciler/src/ReactChildFiber.js",
    "diffHunk": "@@ -1095,9 +1095,7 @@ function ChildReconciler(shouldTrackSideEffects) {\n       existing.return = returnFiber;\n       return existing;\n     }\n-    // The existing first child is not a text node so we need to create one\n-    // and delete the existing ones.\n-    deleteRemainingChildren(returnFiber, currentFirstChild);\n+    // The existing first child is not a text node so we need to create one.",
    "line": 7,
    "reactionCount": 0,
    "timestamp": "2018-09-28T04:32:06Z",
    "isReviewComment": true,
    "pullRequestReviewId": 159716863,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "NE-SmallTown",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:13.748Z"
  },
  {
    "repo": "facebook/react",
    "prNumber": 11332,
    "prTitle": "(WIP) Use only public api for SyntheticEvent-test.js",
    "prLink": "https://github.com/facebook/react/pull/11332",
    "commentAuthor": "gaearon",
    "commentBody": "This is not testing anything in React. You are creating a jsdom event (equivalent to a browser event) and then check that jsdom was dispatched. Even if the entire React source code was deleted, this test would still pass.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/facebook/react/pull/11332#discussion_r150282926",
    "filePath": "packages/react-dom/src/events/__tests__/SyntheticEvent-test.js",
    "diffHunk": "@@ -18,63 +17,122 @@ describe('SyntheticEvent', () => {\n   var createEvent;\n \n   beforeEach(() => {\n-    // TODO: can we express this test with only public API?\n-    SyntheticEvent = require('SyntheticEvent');\n     React = require('react');\n     ReactDOM = require('react-dom');\n     ReactTestUtils = require('react-dom/test-utils');\n-\n-    createEvent = function(nativeEvent) {\n-      var target = require('getEventTarget')(nativeEvent);\n-      return SyntheticEvent.getPooled({}, '', nativeEvent, target);\n+    createEvent = (eventInit, eventOptions) => {\n+      const defaultEventInit = {\n+        bubbles: true,\n+        cancelable: true,\n+        ...eventOptions,\n+      };\n+      var event = new Event(eventInit, defaultEventInit);\n+      event.initEvent(\n+        eventInit,\n+        defaultEventInit.bubbles,\n+        defaultEventInit.cancelable,\n+      );\n+      return event;\n     };\n   });\n \n   it('should normalize `target` from the nativeEvent', () => {\n-    var target = document.createElement('div');\n-    var syntheticEvent = createEvent({srcElement: target});\n+    var click = jest.fn();\n+    var container = document.createElement('div');\n+\n+    var onClick = e => click(e.target);\n+\n+    var instance = ReactDOM.render(<div onClick={onClick} />, container);\n \n-    expect(syntheticEvent.target).toBe(target);\n-    expect(syntheticEvent.type).toBe(undefined);\n+    document.body.appendChild(container);\n+\n+    var event = createEvent('click');\n+\n+    instance.dispatchEvent(event);\n+    expect(click).toBeCalledWith(instance);\n+    document.body.removeChild(container);\n   });\n \n   it('should be able to `preventDefault`', () => {\n-    var nativeEvent = {};\n-    var syntheticEvent = createEvent(nativeEvent);\n+    var click = jest.fn();\n+    var container = document.createElement('div');\n+\n+    var onClick = e => {\n+      click(e.isDefaultPrevented());\n+      e.preventDefault();\n+      click(e.isDefaultPrevented());\n+      click(e.defaultPrevented);\n+      click(e.nativeEvent.returnValue);\n+    };\n \n-    expect(syntheticEvent.isDefaultPrevented()).toBe(false);\n-    syntheticEvent.preventDefault();\n-    expect(syntheticEvent.isDefaultPrevented()).toBe(true);\n+    var instance = ReactDOM.render(<div onClick={onClick} />, container);\n \n-    expect(syntheticEvent.defaultPrevented).toBe(true);\n+    document.body.appendChild(container);\n \n-    expect(nativeEvent.returnValue).toBe(false);\n+    var event = createEvent('click');\n+    instance.dispatchEvent(event);\n+    expect(click.mock.calls[0][0]).toBe(false);",
    "line": 83,
    "reactionCount": 0,
    "timestamp": "2017-11-10T16:41:24Z",
    "isReviewComment": true,
    "pullRequestReviewId": 75814686,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "dleitee",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:15.665Z"
  },
  {
    "repo": "facebook/react",
    "prNumber": 10707,
    "prTitle": "[Gatsby Docs Update] Initial version of new sidebar",
    "prLink": "https://github.com/facebook/react/pull/10707",
    "commentAuthor": "bvaughn",
    "commentBody": "This line causes errors for me.\r\n\r\n`yarn build` fails with:\r\n> WebpackError: Cannot read property 'items' of null\r\n\r\n`yarn dev` shows a runtime redbox with:\r\n> TypeError: Cannot read property 'items' of undefined",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/facebook/react/pull/10707#discussion_r139535135",
    "filePath": "www/src/components/StickyResponsiveSidebar/StickyResponsiveSidebar.js",
    "diffHunk": "@@ -0,0 +1,149 @@\n+/**\n+ * Copyright 2015-present, Facebook, Inc.\n+ * All rights reserved.\n+ *\n+ * This source code is licensed under the BSD-style license found in the\n+ * LICENSE file in the root directory of this source tree. An additional grant\n+ * of patent rights can be found in the PATENTS file in the same directory.\n+ *\n+ * @emails react-core\n+*/\n+\n+'use strict';\n+\n+import Container from 'components/Container';\n+import {Component, React} from 'react';\n+import isItemActive from 'utils/isItemActive';\n+import {Sticky} from 'react-sticky';\n+import Sidebar from 'templates/components/Sidebar';\n+import {colors, media} from 'theme';\n+\n+// TODO: memoize to save doing O(n) on the active section items + subitems every\n+// time.\n+function findActiveItemTitle(location, defaultActiveSection) {\n+  const {items} = defaultActiveSection;",
    "line": 24,
    "reactionCount": 0,
    "timestamp": "2017-09-18T20:44:35Z",
    "isReviewComment": true,
    "pullRequestReviewId": 63481907,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "flarnie",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:15.584Z"
  },
  {
    "repo": "facebook/react",
    "prNumber": 9293,
    "prTitle": "WIP - convert public React core properties to strings so uglify/gcc can mangle",
    "prLink": "https://github.com/facebook/react/pull/9293",
    "commentAuthor": "simonkberg",
    "commentBody": "This will throw in environments without Symbol",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/facebook/react/pull/9293#discussion_r113985382",
    "filePath": "src/shared/utils/ReactElementSymbol.js",
    "diffHunk": "@@ -14,9 +14,9 @@\n \n // The Symbol used to tag the ReactElement type. If there is no native Symbol\n // nor polyfill, then a plain number is used for performance.\n-var REACT_ELEMENT_TYPE = (typeof Symbol === 'function' &&\n-  Symbol.for &&\n-  Symbol.for('react.element')) ||\n+const SymbolFor = Symbol.for;",
    "line": 7,
    "reactionCount": 0,
    "timestamp": "2017-04-28T17:53:36Z",
    "isReviewComment": true,
    "pullRequestReviewId": 35422260,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "trueadm",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:15.530Z"
  },
  {
    "repo": "facebook/react",
    "prNumber": 7800,
    "prTitle": "Fix for #7767",
    "prLink": "https://github.com/facebook/react/pull/7800",
    "commentAuthor": "jimfb",
    "commentBody": "The fact that a component is disabled does not mean it is uncontrolled.  This logic is not correct.  You could imagine a controlled component becoming temporarily disabled if some background action is being performed; that doesn't mean the component becomes uncontrolled at that point.\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/facebook/react/pull/7800#discussion_r80352945",
    "filePath": "src/renderers/dom/client/wrappers/ReactDOMInput.js",
    "diffHunk": "@@ -34,8 +34,12 @@ function forceUpdateIfMounted() {\n }\n \n function isControlled(props) {\n-  var usesChecked = props.type === 'checkbox' || props.type === 'radio';\n-  return usesChecked ? props.checked != null : props.value != null;\n+  if (props.disabled) return false;",
    "line": 6,
    "reactionCount": 0,
    "timestamp": "2016-09-24T04:44:05Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1428253,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "troydemonbreun",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:15.768Z"
  },
  {
    "repo": "facebook/react",
    "prNumber": 6255,
    "prTitle": "Fix #6153: Warn for PropTypes that don't exist but do exist with a di…",
    "prLink": "https://github.com/facebook/react/pull/6255",
    "commentAuthor": "gaearon",
    "commentBody": "Please don’t use `for of` syntax as it relies on ES6 `Symbol` being available, and we don’t polyfill it.\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/facebook/react/pull/6255#discussion_r68508373",
    "filePath": "src/isomorphic/devtools/ReactMiscapitalizedPropNameWarningDevTool.js",
    "diffHunk": "@@ -0,0 +1,61 @@\n+/**\n+ * Copyright 2016-present, Facebook, Inc.\n+ * All rights reserved.\n+ *\n+ * This source code is licensed under the BSD-style license found in the\n+ * LICENSE file in the root directory of this source tree. An additional grant\n+ * of patent rights can be found in the PATENTS file in the same directory.\n+ *\n+ * @providesModule ReactMiscapitalizedPropNameWarningDevTool\n+ */\n+\n+'use strict';\n+\n+var warning = require('warning');\n+\n+if (__DEV__) {\n+\n+  var warnedProperties = {};\n+\n+  var warnMiscapitalizedPropName = function(\n+                                     componentName,\n+                                     allPropNames,\n+                                     missingPropName\n+                                   ) {\n+    var missingPropNameLowerCase = missingPropName.toLowerCase();\n+    var incorrectlyCapitalizedPropName;\n+\n+    for (var propName of allPropNames) {",
    "line": 28,
    "reactionCount": 0,
    "timestamp": "2016-06-26T19:43:27Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "ghost",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:17.400Z"
  },
  {
    "repo": "facebook/react",
    "prNumber": 6158,
    "prTitle": "Warn if the included mixin is undefined",
    "prLink": "https://github.com/facebook/react/pull/6158",
    "commentAuthor": "gaearon",
    "commentBody": "As far as I can see, this will print `Expected object but got object.` for arrays.\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/facebook/react/pull/6158#discussion_r59251936",
    "filePath": "src/isomorphic/classic/class/ReactClass.js",
    "diffHunk": "@@ -437,6 +437,21 @@ function validateMethodOverride(isAlreadyDefined, name) {\n  */\n function mixSpecIntoComponent(Constructor, spec) {\n   if (!spec) {\n+    if (__DEV__) {\n+      var typeofSpec = typeof spec;\n+      var isMixinValid = typeofSpec === 'object' && spec !== null;\n+\n+      warning(\n+        isMixinValid,\n+        '%s: You\\'re attempting to include a mixin that is either null ' +\n+        'or not an object. Check the mixins included by the component, ' +\n+        'as well as any mixins they include themselves. ' +\n+        'Expected object but got %s.',",
    "line": 13,
    "reactionCount": 0,
    "timestamp": "2016-04-11T18:05:06Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "swaroopsm",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:17.398Z"
  },
  {
    "repo": "facebook/react",
    "prNumber": 725,
    "prTitle": "Add invariant to check getInitialState return value. Fixes #397",
    "prLink": "https://github.com/facebook/react/pull/725",
    "commentAuthor": "vjeux",
    "commentBody": "`undefined` should also be valid. Otherwise a function like this would fatal:\n\n```\ngetInitialState: function() {\n  if (something) {\n    return {some: 'abc'};\n  }\n}\n```\n",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/facebook/react/pull/725#discussion_r8573802",
    "filePath": "src/core/ReactCompositeComponent.js",
    "diffHunk": "@@ -686,6 +686,12 @@ var ReactCompositeComponentMixin = {\n       }\n \n       this.state = this.getInitialState ? this.getInitialState() : null;\n+      invariant(\n+        typeof this.state === 'object' && !Array.isArray(this.state),",
    "line": 5,
    "reactionCount": 0,
    "timestamp": "2013-12-27T22:38:47Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "cpojer",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:19.830Z"
  },
  {
    "repo": "tensorflow/tensorflow",
    "prNumber": 62409,
    "prTitle": "Register complex dtypes for TruncateDiv Op",
    "prLink": "https://github.com/tensorflow/tensorflow/pull/62409",
    "commentAuthor": "cantonios",
    "commentBody": "Complex types are _not_ supported.  This breaks a bunch of stuff, and as you can see from the functor, is only supported by _real_ values.  Floor/truncation doesn't make much sense for complex inputs.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/tensorflow/tensorflow/pull/62409#discussion_r1442110876",
    "filePath": "tensorflow/core/kernels/cwise_op_div.cc",
    "diffHunk": "@@ -23,8 +23,8 @@ REGISTER8(BinaryOp, CPU, \"Div\", functor::safe_div, uint8, uint16, uint32,\n           uint64, int8, int16, int32, int64_t);\n REGISTER8(BinaryOp, CPU, \"TruncateDiv\", functor::safe_div, uint8, uint16,\n           uint32, uint64, int8, int16, int32, int64_t);\n-REGISTER4(BinaryOp, CPU, \"TruncateDiv\", functor::truncate_div_real, Eigen::half,\n-          bfloat16, float, double);\n+REGISTER6(BinaryOp, CPU, \"TruncateDiv\", functor::truncate_div_real, Eigen::half,\n+          bfloat16, float, double, complex64, complex128);",
    "line": 7,
    "reactionCount": 0,
    "timestamp": "2024-01-04T18:21:45Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1804746910,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "SuryanarayanaY",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:24.390Z"
  },
  {
    "repo": "tensorflow/tensorflow",
    "prNumber": 59755,
    "prTitle": "Update image_ops_impl.convert_image_dtype.py",
    "prLink": "https://github.com/tensorflow/tensorflow/pull/59755",
    "commentAuthor": "cantonios",
    "commentBody": "This is not correct.\r\n\r\nThe case covered here is the input being floating-point and the output being an integer type.\r\n\r\nLet's say you start with an image in the range [0, 1.0], then you are converting to uint8.  You want 1.0 to map to 255.  That's why the scale factor is by 255.5 - so that 255.5 * 1.0, rounded, is 255.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/tensorflow/tensorflow/pull/59755#discussion_r1113396504",
    "filePath": "tensorflow/python/ops/image_ops_impl.py",
    "diffHunk": "@@ -2531,7 +2531,7 @@ def convert_image_dtype(image, dtype, saturate=False, name=None):\n         return math_ops.multiply(cast, scale, name=name)\n       else:\n         # Converting from float: first scale, then cast\n-        scale = dtype.max + 0.5  # avoid rounding problems in the cast\n+        scale = 1./(dtype.max + 0.5)  # avoid rounding problems in the cast",
    "line": 5,
    "reactionCount": 0,
    "timestamp": "2023-02-21T17:52:28Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1307917624,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "SuryanarayanaY",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:24.413Z"
  },
  {
    "repo": "tensorflow/tensorflow",
    "prNumber": 59266,
    "prTitle": "Correct index check for Tensor::SubSlice() method accordingly to documentation and SubBuffer() checks",
    "prLink": "https://github.com/tensorflow/tensorflow/pull/59266",
    "commentAuthor": "cantonios",
    "commentBody": "The case of `dim0_size == 0` but `index > 0` should fail.  It looks like it returns an invalid tensor. \r\n Consider a tensor with shape `[0, 5, 5, 5]`.  This is empty and the buffer pointer would be `nullptr`.  This code as written will return a tensor of size `[5, 5, 5]` but a `nullptr` buffer.\r\n\r\nIn fact, whenever `index >= dim0_size`, we would get an invalid tensor, even if `dim0_size > 0`.  It's an invalid index, so we can't chip away a subtensor.\r\n\r\nThe original check should be `CHECK_LT(index, dim0_size)`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/tensorflow/tensorflow/pull/59266#discussion_r1072424857",
    "filePath": "tensorflow/core/framework/tensor.cc",
    "diffHunk": "@@ -1016,13 +1016,13 @@ Tensor Tensor::SubSlice(int64_t index) const {\n   CHECK_GE(dims(), 1);  // Crash ok.\n   CHECK_LE(0, index);   // Crash ok.\n   int64_t dim0_size = shape_.dim_size(0);\n-  CHECK_LE(index, dim0_size);  // Crash ok.\n   Tensor ret;\n   ret.shape_ = shape_;\n   ret.shape_.RemoveDim(0);\n   ret.set_dtype(dtype());\n   ret.buf_ = nullptr;\n   if (dim0_size > 0) {\n+    CHECK_LT(index, dim0_size);  // Crash ok.",
    "line": 11,
    "reactionCount": 0,
    "timestamp": "2023-01-17T16:23:49Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1251918158,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "avoskoboinyk-lohika",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:24.216Z"
  },
  {
    "repo": "tensorflow/tensorflow",
    "prNumber": 53627,
    "prTitle": "Xla const output cache on GPU ",
    "prLink": "https://github.com/tensorflow/tensorflow/pull/53627",
    "commentAuthor": "akuegel",
    "commentBody": "The race seems to be between this line and the assignment of cache_ in rm_->LookupOrCreate.\r\nSo I think you need a mutex lock here around this block (and I guess everywhere where cache_ is accessed).",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/tensorflow/tensorflow/pull/53627#discussion_r800513010",
    "filePath": "tensorflow/compiler/jit/kernels/xla_ops.cc",
    "diffHunk": "@@ -562,12 +605,26 @@ void XlaRunOp::Compute(OpKernelContext* ctx) {\n       ctx, *closure.compilation_result(), closure.num_constant_args());\n   OP_REQUIRES_OK(ctx, variable_infos.status());\n   OP_REQUIRES_OK(ctx, LockVariables(absl::MakeSpan(*variable_infos)));\n+\n+  if (cache_ == nullptr) {",
    "line": 79,
    "reactionCount": 0,
    "timestamp": "2022-02-07T10:27:35Z",
    "isReviewComment": true,
    "pullRequestReviewId": 874467703,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "zhaozheng09",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:26.774Z"
  },
  {
    "repo": "tensorflow/tensorflow",
    "prNumber": 43900,
    "prTitle": "[TF-TRT] Cast now supports more conversions if TRT >= 7.0.0.11",
    "prLink": "https://github.com/tensorflow/tensorflow/pull/43900",
    "commentAuthor": "bixia1",
    "commentBody": "I am getting this error with I run and the tests with --test_env=TF2_BEHAVIOR=1:\r\n\r\n\r\n File \"/build/work/fa3a0e10bc497b211fc2e1e6537b38cd4e12/google3/runfiles/google3/third_party/tensorflow/python/compiler/tensorrt/test/tf_trt_integration_test_base.py\", line 895, in _VerifyGraphDefV2\r\n    expected_engines = set(expected_engines.keys())\r\nAttributeError: 'list' object has no attribute 'keys'",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/tensorflow/tensorflow/pull/43900#discussion_r535770905",
    "filePath": "tensorflow/python/compiler/tensorrt/test/tf_trt_integration_test_base.py",
    "diffHunk": "@@ -879,12 +879,31 @@ def _VerifyGraphDefV2(self, run_params, original_gdef, gdef_to_verify,\n       # 2.0, but we still make sure that the converted ops are gone from the\n       # graph.\n       unexpected_names = set(nest.flatten(expected_engines.values()))\n-      self.assertEmpty(\n-          [name for name in unexpected_names if name in all_op_names])\n-      expected_engines = set(expected_engines.keys())\n-\n-    self.assertEqual(set(expected_engines), trt_op_names)\n-\n+      try:\n+        self.assertEmpty(\n+            [name for name in unexpected_names if name in all_op_names])\n+      except AssertionError:\n+        raise RuntimeError(\"\"\"Unexpected TF-TRT Engines returned:,\n+All Op Names: {},\n+TRT Op Names: {},\n+Expected: {}\"\"\".format(\n+          all_op_names,\n+          trt_op_names,\n+          unexpected_names,\n+        ))\n+\n+    expected_engines = set(expected_engines.keys())\n+    try:\n+      self.assertEqual(expected_engines, trt_op_names)\n+    except AssertionError:\n+      raise RuntimeError(\"\"\"Unexpected TF-TRT Engines returned:,\n+        All Op Names: {},\n+        TRT Op Names: {},\n+        Expected Engines: {}\"\"\".format(\n+          all_op_names,\n+          trt_op_names,\n+          expected_engines,",
    "line": 34,
    "reactionCount": 1,
    "timestamp": "2020-12-04T01:35:09Z",
    "isReviewComment": true,
    "pullRequestReviewId": 544595052,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "DEKHTIARJonathan",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:28.446Z"
  },
  {
    "repo": "tensorflow/tensorflow",
    "prNumber": 37668,
    "prTitle": "TFLu: replace old cmsis scratch buffer",
    "prLink": "https://github.com/tensorflow/tensorflow/pull/37668",
    "commentAuthor": "wangtz",
    "commentBody": "That's a good point. I should check if buf_size is 0.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/tensorflow/tensorflow/pull/37668#discussion_r398600460",
    "filePath": "tensorflow/lite/micro/kernels/cmsis-nn/conv.cc",
    "diffHunk": "@@ -111,12 +110,59 @@ TfLiteStatus CalculateOpData(TfLiteContext* context, TfLiteNode* node,\n }\n \n void* Init(TfLiteContext* context, const char* buffer, size_t length) {\n-  return nullptr;\n+  void* raw;\n+  context->AllocatePersistentBuffer(\n+      context, sizeof(int), &raw);\n+  return raw;\n }\n \n void Free(TfLiteContext* context, void* buffer) {}\n \n TfLiteStatus Prepare(TfLiteContext* context, TfLiteNode* node) {\n+#if defined(__ARM_FEATURE_DSP)\n+  OpData data;\n+  int32_t buf_size;\n+\n+  auto* params = reinterpret_cast<TfLiteConvParams*>(node->builtin_data);\n+\n+  const TfLiteTensor* input = GetInput(context, node, kInputTensor);\n+  const TfLiteTensor* filter = GetInput(context, node, kFilterTensor);\n+  const TfLiteTensor* output = GetOutput(context, node, kOutputTensor);\n+\n+  RuntimeShape input_shape = GetTensorShape(input);\n+\n+  const int input_depth = input_shape.Dims(3);\n+  const int input_width = input->dims->data[2];\n+  const int input_height = input->dims->data[1];\n+  const int filter_width = filter->dims->data[2];\n+  const int filter_height = filter->dims->data[1];\n+  const int output_width = output->dims->data[2];\n+  const int output_height = output->dims->data[1];\n+\n+  int* buffer_idx = reinterpret_cast<int*>(node->user_data);\n+\n+  TF_LITE_ENSURE_STATUS(CalculateOpData(\n+      context, node, params, input_width, input_height, filter_width,\n+      filter_height, output_width, output_height, input->type, &data));\n+\n+  if (data.padding.width == 0 &&\n+      data.padding.height == 0 && (input_depth % 4 == 0) &&\n+      params->stride_width == 1 &&\n+      params->stride_height == 1 && filter_width == 1 && filter_height == 1) {\n+    buf_size = arm_convolve_1x1_s8_fast_get_buffer_size(input_depth);\n+  }\n+  else\n+  {\n+    buf_size = arm_convolve_s8_get_buffer_size(input_depth, filter_width, filter_height);\n+  }\n+\n+  node->user_data = buffer_idx;\n+  if (buf_size > 0)  {",
    "line": 60,
    "reactionCount": 0,
    "timestamp": "2020-03-26T14:08:14Z",
    "isReviewComment": true,
    "pullRequestReviewId": 382043640,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "mansnils",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:28.697Z"
  },
  {
    "repo": "tensorflow/tensorflow",
    "prNumber": 37020,
    "prTitle": "Modified metric_utils.py to fix conflicts with floatx and float32",
    "prLink": "https://github.com/tensorflow/tensorflow/pull/37020",
    "commentAuthor": "MarkDaoust",
    "commentBody": "This doesn't look right.\r\n\r\n`logical_and` only works if both inputs are dtype `bool`, it returns tensor with dtype `bool`. so here you're casting a bool to type bool.\r\n\r\nIt needs to be cast to a floating type so the rest of the function works (`*` and `reduce_sum` don't work on bool).",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/tensorflow/tensorflow/pull/37020#discussion_r383401165",
    "filePath": "tensorflow/python/keras/utils/metrics_utils.py",
    "diffHunk": "@@ -424,7 +424,7 @@ def update_confusion_matrix_variables(variables_to_update,\n \n   def weighted_assign_add(label, pred, weights, var):\n     label_and_pred = math_ops.cast(\n-        math_ops.logical_and(label, pred), dtype=dtypes.float32)\n+        math_ops.logical_and(label, pred), dtype=pred.dtype)",
    "line": 5,
    "reactionCount": 0,
    "timestamp": "2020-02-24T17:18:40Z",
    "isReviewComment": true,
    "pullRequestReviewId": 363561361,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "ashutosh1919",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:32.678Z"
  },
  {
    "repo": "tensorflow/tensorflow",
    "prNumber": 33368,
    "prTitle": "Fix missing activation methods",
    "prLink": "https://github.com/tensorflow/tensorflow/pull/33368",
    "commentAuthor": "lrdxgm",
    "commentBody": "Note that in C++ (std::)signbit returns true if the parameter is *negative*, false if it's positive, so this is a totally useless activation function.\r\n\r\nIt's even worse in C: it returns *any* nonzero value if the value is negative. It can be 1, 255, -128, etc..",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/tensorflow/tensorflow/pull/33368#discussion_r349359159",
    "filePath": "tensorflow/lite/experimental/micro/kernels/activation_utils.h",
    "diffHunk": "@@ -33,9 +33,18 @@ inline float ActivationValFloat(TfLiteFusedActivation act, float a) {\n       return a;\n     case kTfLiteActRelu:\n       return a < 0.f ? 0.f : a;\n+    case kTfLiteActRelu1:\n+      return a < 0.f ? 0.f : ((a > 1.f) ? 1.f : a);\n+    case kTfLiteActRelu6:\n+      return a < 0.f ? 0.f : ((a > 6.f) ? 6.f : a);\n+    case kTfLiteActTanh:\n+      return (expf(a) - expf(-a)) / (expf(a) + expf(-a));\n+    case kTfLiteActSignBit:\n+      return signbit(a);",
    "line": 11,
    "reactionCount": 0,
    "timestamp": "2019-11-21T22:53:57Z",
    "isReviewComment": true,
    "pullRequestReviewId": 321241925,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "kwagyeman",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:34.388Z"
  },
  {
    "repo": "tensorflow/tensorflow",
    "prNumber": 34537,
    "prTitle": "[tflite] add int8 input/output to label_image",
    "prLink": "https://github.com/tensorflow/tensorflow/pull/34537",
    "commentAuthor": "srjoglekar246",
    "commentBody": "The issue is with these lines. The input actually *is* uint8 (and not float). Line 31 initializes the `Settings` object to its default values, which assumes `TfLiteType input_type = kTfLiteFloat32;`. So these values `0x15` & `0x11` should not be changed, we should rather set `s.input_type = kTfLiteUInt8` (after importing `tensorflow/lite/c/common.h`).",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/tensorflow/tensorflow/pull/34537#discussion_r390446018",
    "filePath": "tensorflow/lite/examples/label_image/label_image_test.cc",
    "diffHunk": "@@ -37,15 +37,15 @@ TEST(LabelImageTest, GraceHopper) {\n \n   std::vector<uint8_t> output(606 * 517 * 3);\n   resize<uint8_t>(output.data(), input.data(), 606, 517, 3, 214, 214, 3, &s);\n-  ASSERT_EQ(output[0], 0x15);\n-  ASSERT_EQ(output[214 * 214 * 3 - 1], 0x11);\n+  ASSERT_EQ(output[0], 0x0);\n+  ASSERT_EQ(output[214 * 214 * 3 - 1], 0x0);",
    "line": 7,
    "reactionCount": 0,
    "timestamp": "2020-03-10T16:28:48Z",
    "isReviewComment": true,
    "pullRequestReviewId": 372119327,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "freedomtan",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:34.215Z"
  },
  {
    "repo": "tensorflow/tensorflow",
    "prNumber": 28918,
    "prTitle": "fix huber loss function for when delta = inf",
    "prLink": "https://github.com/tensorflow/tensorflow/pull/28918",
    "commentAuthor": "alextp",
    "commentBody": "This uses the result of a tensor operation as a python boolean, which is only supported inside tf.function / autograph.\r\n\r\nAs it is right now I believe this code always raises an exception, so please add unit tests to convince yourself the implementation is correct.\r\n\r\nAlso, why not just modify the huber loss kernel to do the right thing in the presence of infinity there?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/tensorflow/tensorflow/pull/28918#discussion_r291272863",
    "filePath": "tensorflow/python/ops/losses/losses_impl.py",
    "diffHunk": "@@ -419,6 +420,9 @@ def huber_loss(labels, predictions, weights=1.0, delta=1.0, scope=None,\n     raise ValueError(\"predictions must not be None.\")\n   with ops.name_scope(scope, \"huber_loss\",\n                       (predictions, labels, weights)) as scope:\n+    if not gen_math_ops.is_finite(delta):",
    "line": 12,
    "reactionCount": 0,
    "timestamp": "2019-06-06T16:40:34Z",
    "isReviewComment": true,
    "pullRequestReviewId": 246687004,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "cfifty",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:36.268Z"
  },
  {
    "repo": "pytorch/pytorch",
    "prNumber": 142476,
    "prTitle": "Fix timeout check workflow lint job",
    "prLink": "https://github.com/pytorch/pytorch/pull/142476",
    "commentAuthor": "ZainRizvi",
    "commentBody": "Isn't this only setting they PYTHONPATH env var,  resulting in no test files being executed or discovered?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/pytorch/pytorch/pull/142476#discussion_r1878866746",
    "filePath": ".github/workflows/lint.yml",
    "diffHunk": "@@ -207,8 +207,8 @@ jobs:\n         conda activate \"${CONDA_ENV}\"\n \n         # Test tools\n-        python3 -m unittest discover -vs tools/test -p 'test_*.py'\n-        python3 -m unittest discover -vs .github/scripts -p 'test_*.py'\n+        PYTHONPATH=$(pwd) pytest tools/test/test_*.py\n+        PYTHONPATH=$(pwd) pytest .github/scripts/test_*.py",
    "line": 7,
    "reactionCount": 0,
    "timestamp": "2024-12-10T21:15:37Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2493622367,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "huydhn",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:51:17.420Z"
  },
  {
    "repo": "pytorch/pytorch",
    "prNumber": 141371,
    "prTitle": "ir.ExternKernel: correctly handle kwarg default arguments",
    "prLink": "https://github.com/pytorch/pytorch/pull/141371",
    "commentAuthor": "desertfire",
    "commentBody": "I don't see an early return or an else-branch. Won't this cause shard 2 to run both opinfo tests and all other tests?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/pytorch/pytorch/pull/141371#discussion_r1901011712",
    "filePath": ".ci/pytorch/test.sh",
    "diffHunk": "@@ -382,15 +382,28 @@ test_inductor_aoti() {\n   CPP_TESTS_DIR=\"${BUILD_BIN_DIR}\" LD_LIBRARY_PATH=\"${TORCH_LIB_DIR}\" python test/run_test.py --cpp --verbose -i cpp/test_aoti_abi_check cpp/test_aoti_inference\n }\n \n-test_inductor_cpp_wrapper() {\n+test_inductor_cpp_wrapper_shard() {\n+  if [[ -z \"$NUM_TEST_SHARDS\" ]]; then\n+    echo \"NUM_TEST_SHARDS must be defined to run a Python test shard\"\n+    exit 1\n+  fi\n+\n   export TORCHINDUCTOR_CPP_WRAPPER=1\n   TEST_REPORTS_DIR=$(pwd)/test/test-reports\n   mkdir -p \"$TEST_REPORTS_DIR\"\n \n-  # Run certain inductor unit tests with cpp wrapper. In the end state, we should be able to run all the inductor\n-  # unit tests with cpp wrapper.\n-  python test/run_test.py --include inductor/test_torchinductor.py --verbose\n+  if [[ \"$1\" -eq \"2\" ]]; then",
    "line": 18,
    "reactionCount": 0,
    "timestamp": "2025-01-02T15:50:07Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2527802630,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "benjaminglass1",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:38.194Z"
  },
  {
    "repo": "pytorch/pytorch",
    "prNumber": 139833,
    "prTitle": "Add type annotations to Configs",
    "prLink": "https://github.com/pytorch/pytorch/pull/139833",
    "commentAuthor": "jansel",
    "commentBody": "This change causes many `options=...` passed to `torch.compile` to be ignored (setting self.config should go outside the `if`). ",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/pytorch/pytorch/pull/139833#discussion_r1920902710",
    "filePath": "torch/__init__.py",
    "diffHunk": "@@ -2280,13 +2281,18 @@ def apply_options(self, options: _Optional[_Dict[str, _Any]]):\n                 raise RuntimeError(\n                     f\"Unexpected optimization option {key}, known options are {list(current_config.keys())}\"\n                 )\n-            if type(val) is not type(current_config[attr_name]):\n-                val_type_str = type(val).__name__\n-                expected_type_str = type(current_config[attr_name]).__name__\n-                raise RuntimeError(\n-                    f\"Unexpected type of attr {key}, got {val_type_str} should be {expected_type_str}\"\n-                )\n-            self.config[attr_name] = val\n+            attr_type = config.get_type(attr_name)  # type: ignore[attr-defined]\n+            # Subscriptable generic types don't support isinstance so skip the type\n+            # check. There doesn't seem to be a good way of checking membership without\n+            # 3rd party libraries.\n+            if _get_origin(attr_type) is None:\n+                if not isinstance(val, attr_type):\n+                    val_type_str = type(val).__name__\n+                    expected_type_str = type(current_config[attr_name]).__name__\n+                    raise RuntimeError(\n+                        f\"Unexpected type of attr {key}, got {val_type_str} should be {expected_type_str}\"\n+                    )\n+                self.config[attr_name] = val",
    "line": 30,
    "reactionCount": 0,
    "timestamp": "2025-01-18T00:34:13Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2560202594,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "prAuthor": "exclamaforte",
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:38.145Z"
  },
  {
    "repo": "pytorch/pytorch",
    "prNumber": 136792,
    "prTitle": "FlexAttention support for NJT",
    "prAuthor": "jbschlosser",
    "prLink": "https://github.com/pytorch/pytorch/pull/136792",
    "commentAuthor": "jataylo",
    "commentBody": "Why is this disabled for AMD/ROCm?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/pytorch/pytorch/pull/136792#discussion_r1827667937",
    "filePath": "torch/testing/_internal/common_device_type.py",
    "diffHunk": "@@ -1950,3 +1950,12 @@ def skipPRIVATEUSE1(fn):\n #  This should probably enumerate all available device type test base classes.\n def get_all_device_types() -> List[str]:\n     return [\"cpu\"] if not torch.cuda.is_available() else [\"cpu\", \"cuda\"]\n+\n+\n+flex_attention_supported_platform = unittest.skipUnless(\n+    torch.cuda.is_available()\n+    and torch.version.hip is None",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-11-04T12:39:33Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2412959035,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:40.541Z"
  },
  {
    "repo": "pytorch/pytorch",
    "prNumber": 134726,
    "prTitle": "Fix unintentional deduplication of returned tensors",
    "prAuthor": "benjaminglass1",
    "prLink": "https://github.com/pytorch/pytorch/pull/134726",
    "commentAuthor": "zou3519",
    "commentBody": "What happens if we have:\r\n```py\r\ndef fn(val: torch.Tensor) -> Tuple[torch.Tensor, torch.Tensor]:\r\n    x = val * 2\r\n    y = val * 2\r\n    return x[0], y[0]\r\n```\r\nI'm worried that CSE will change the graph into:\r\n```py\r\ndef fn(val: torch.Tensor) -> Tuple[torch.Tensor, torch.Tensor]:\r\n    x = val * 2\r\n    return x[0], x[0]\r\n```\r\nwhich then has the same problem",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/pytorch/pytorch/pull/134726#discussion_r1738774371",
    "filePath": "test/dynamo/test_repros.py",
    "diffHunk": "@@ -5752,6 +5752,42 @@ def fn(x):\n \n         fn(torch.randn(4))\n \n+    # https://github.com/pytorch/pytorch/issues/88813\n+    def test_return_value_duplication_grad(self) -> None:\n+        def fn(val: torch.Tensor) -> Tuple[torch.Tensor, torch.Tensor]:\n+            return val * 2, val * 2",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-08-30T14:22:28Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2272514183,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:39.972Z"
  },
  {
    "repo": "kubernetes/kubernetes",
    "prNumber": 128272,
    "prTitle": "[FG:InPlacePodVerticalScaling] Implement resize for sidecar containers",
    "prAuthor": "vivzbansal",
    "prLink": "https://github.com/kubernetes/kubernetes/pull/128272",
    "commentAuthor": "tallclair",
    "commentBody": "make sure `AllocatedResources` is non-nil",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/kubernetes/kubernetes/pull/128272#discussion_r1811583699",
    "filePath": "pkg/api/v1/resource/helpers.go",
    "diffHunk": "@@ -129,6 +139,17 @@ func PodRequests(pod *v1.Pod, opts PodResourcesOptions) v1.ResourceList {\n \treturn reqs\n }\n \n+// setContainerReqs will return a copy of the container requests based on if resizing is feasible or not.\n+func setContainerReqs(pod *v1.Pod, container v1.Container, cs *v1.ContainerStatus) v1.ResourceList {\n+\tcp := v1.ResourceList{}\n+\tif pod.Status.Resize == v1.PodResizeStatusInfeasible {\n+\t\tcp = cs.AllocatedResources.DeepCopy()",
    "line": 75,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-10-23T00:07:28Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2386591984,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:40.676Z"
  },
  {
    "repo": "kubernetes/kubernetes",
    "prNumber": 127298,
    "prTitle": "simplify code to avoid unnecessary logic checks",
    "prAuthor": "mmungdong",
    "prLink": "https://github.com/kubernetes/kubernetes/pull/127298",
    "commentAuthor": "xuzhenglun",
    "commentBody": "IMHO, this sliding check is necessary. considering when `immediate=true`:\r\n1. if `sliding` is disabled, the timer should start before `condition func` run, just like L44 does.\r\n2. if `sliding` is enabled, the timer should start after `condition func` runs, just like L60 does.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/kubernetes/kubernetes/pull/127298#discussion_r1754929520",
    "filePath": "staging/src/k8s.io/apimachinery/pkg/util/wait/loop.go",
    "diffHunk": "@@ -37,13 +36,9 @@ import (\n func loopConditionUntilContext(ctx context.Context, t Timer, immediate, sliding bool, condition ConditionWithContextFunc) error {\n \tdefer t.Stop()\n \n-\tvar timeCh <-chan time.Time\n+\ttimeCh := t.C()\n \tdoneCh := ctx.Done()",
    "line": 14,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-09-11T15:19:29Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2297557318,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:42.385Z"
  },
  {
    "repo": "kubernetes/kubernetes",
    "prNumber": 127035,
    "prTitle": "Rename TypedNewDelayingQueue to NewTypedDelayingQueue",
    "prAuthor": "alvaroaleman",
    "prLink": "https://github.com/kubernetes/kubernetes/pull/127035",
    "commentAuthor": "liggitt",
    "commentBody": "this isn't signature compatible, right? it takes an arg and the old one does not... won't this make it hard to straddle / adopt new versions?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/kubernetes/kubernetes/pull/127035#discussion_r1781399854",
    "filePath": "staging/src/k8s.io/client-go/util/workqueue/delaying_queue.go",
    "diffHunk": "@@ -64,26 +64,33 @@ type TypedDelayingQueueConfig[T comparable] struct {\n // NewDelayingQueue does not emit metrics. For use with a MetricsProvider, please use\n // NewDelayingQueueWithConfig instead and specify a name.\n //\n-// Deprecated: use TypedNewDelayingQueue instead.\n+// Deprecated: use NewTypedDelayingQueue instead.\n func NewDelayingQueue() DelayingInterface {\n \treturn NewDelayingQueueWithConfig(DelayingQueueConfig{})\n }\n \n-// TypedNewDelayingQueue constructs a new workqueue with delayed queuing ability.\n-// TypedNewDelayingQueue does not emit metrics. For use with a MetricsProvider, please use\n-// TypedNewDelayingQueueWithConfig instead and specify a name.\n-func TypedNewDelayingQueue[T comparable]() TypedDelayingInterface[T] {\n+// NewTypedDelayingQueue constructs a new workqueue with delayed queuing ability.\n+// NewTypedDelayingQueue does not emit metrics. For use with a MetricsProvider, please use\n+// NewTypedDelayingQueueWithConfig instead and specify a name.\n+func NewTypedDelayingQueue[T comparable]() TypedDelayingInterface[T] {\n \treturn NewTypedDelayingQueueWithConfig(TypedDelayingQueueConfig[T]{})\n }\n \n // NewDelayingQueueWithConfig constructs a new workqueue with options to\n // customize different properties.\n //\n-// Deprecated: use TypedNewDelayingQueueWithConfig instead.\n+// Deprecated: use NewTypedDelayingQueueWithConfig instead.\n func NewDelayingQueueWithConfig(config DelayingQueueConfig) DelayingInterface {\n \treturn NewTypedDelayingQueueWithConfig[any](config)\n }\n \n+// TypedNewDelayingQueue exists for backwards compatibility only.\n+//\n+// Deprecated: use NewTypedDelayingQueueWithConfig instead.\n+func TypedNewDelayingQueue[T comparable](config TypedDelayingQueueConfig[T]) TypedDelayingInterface[T] {",
    "line": 33,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-09-30T16:03:06Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2338000555,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:42.248Z"
  },
  {
    "repo": "kubernetes/kubernetes",
    "prNumber": 126556,
    "prTitle": "Collect more info for debugging #124136",
    "prAuthor": "carlory",
    "prLink": "https://github.com/kubernetes/kubernetes/pull/126556",
    "commentAuthor": "liggitt",
    "commentBody": "this will hotloop once the watch closes... the receive from ResultChan needs to handle the channel closed case",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/kubernetes/kubernetes/pull/126556#discussion_r1724984941",
    "filePath": "test/integration/volume/persistent_volumes_test.go",
    "diffHunk": "@@ -1058,6 +1058,25 @@ func TestPersistentVolumeProvisionMultiPVCs(t *testing.T) {\n \tdefer testClient.CoreV1().PersistentVolumes().DeleteCollection(context.TODO(), metav1.DeleteOptions{}, metav1.ListOptions{})\n \tdefer testClient.StorageV1().StorageClasses().DeleteCollection(context.TODO(), metav1.DeleteOptions{}, metav1.ListOptions{})\n \n+\t// Watch all events in the namespace, and save them to artifacts for debugging.\n+\t// TODO: This is a temporary solution to debug flaky tests `panic: test timed out after 10m0s`.\n+\t// We should remove this once https://github.com/kubernetes/kubernetes/issues/124136 is fixed.\n+\tgo func() {\n+\t\tw, err := testClient.EventsV1().Events(ns.Name).Watch(tCtx, metav1.ListOptions{})\n+\t\tif err != nil {\n+\t\t\treturn\n+\t\t}\n+\t\tfor {",
    "line": 12,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-08-21T12:41:27Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2250693793,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:42.210Z"
  },
  {
    "repo": "kubernetes/kubernetes",
    "prNumber": 124284,
    "prTitle": "DRA: fix data race",
    "prAuthor": "bart0sh",
    "prLink": "https://github.com/kubernetes/kubernetes/pull/124284",
    "commentAuthor": "pohly",
    "commentBody": "How is access to `cache.claimInfo` protected against concurrent access?\r\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/kubernetes/kubernetes/pull/124284#discussion_r1562422207",
    "filePath": "pkg/kubelet/cm/dra/claiminfo.go",
    "diffHunk": "@@ -216,7 +216,10 @@ func (cache *claimInfoCache) syncToCheckpoint() error {\n \n \tclaimInfoStateList := make(state.ClaimInfoStateList, 0, len(cache.claimInfo))\n \tfor _, infoClaim := range cache.claimInfo {\n-\t\tclaimInfoStateList = append(claimInfoStateList, infoClaim.ClaimInfoState)\n+\t\tinfoClaim.Lock()",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-04-12T11:28:56Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1996536131,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:44.231Z"
  },
  {
    "repo": "kubernetes/kubernetes",
    "prNumber": 123874,
    "prTitle": "All Pods option for `kubectl logs` ",
    "prAuthor": "cmwylie19",
    "prLink": "https://github.com/kubernetes/kubernetes/pull/123874",
    "commentAuthor": "eddiezane",
    "commentBody": "We either need to add the pod we waited for to `podList` or return a new list containing it.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/kubernetes/kubernetes/pull/123874#discussion_r1591671074",
    "filePath": "staging/src/k8s.io/kubectl/pkg/polymorphichelpers/helpers.go",
    "diffHunk": "@@ -71,13 +76,27 @@ func GetFirstPod(client coreclient.PodsGetter, namespace string, selector string\n \tdefer cancel()\n \tevent, err := watchtools.UntilWithoutRetry(ctx, w, condition)\n \tif err != nil {\n-\t\treturn nil, 0, err\n+\t\treturn nil, err\n \t}\n-\tpod, ok := event.Object.(*corev1.Pod)\n+\n+\t_, ok := event.Object.(*corev1.Pod)\n \tif !ok {\n-\t\treturn nil, 0, fmt.Errorf(\"%#v is not a pod event\", event)\n+\t\treturn nil, fmt.Errorf(\"%#v is not a pod event\", event)\n+\t}\n+\treturn podList, nil",
    "line": 56,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-05-07T00:09:56Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2041854096,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:44.231Z"
  },
  {
    "repo": "kubernetes/kubernetes",
    "prNumber": 122068,
    "prTitle": "fix(scheduler): fix incorrect loop logic in MultiPoint to avoid a plugin being loaded multiple times",
    "prAuthor": "caohe",
    "prLink": "https://github.com/kubernetes/kubernetes/pull/122068",
    "commentAuthor": "Huang-Wei",
    "commentBody": "the root cause is that during orderedset.delete(), the length of the list get changed, so some item missed its chance to be iterated in the outer for loop.\r\n\r\nThe fix can be snapshotting this list in the outer for loop - as you're proposing here. Could you help check if slice.CopyStrings is available in all supported versions 1.25? ~ 1.28? as we want to cherrypick this fix.\r\n\r\nOr, another fix is to make the for loop logic accurate w/o copying/snapshotting the list:\r\n\r\n```diff\r\ndiff --git a/pkg/scheduler/framework/runtime/framework.go b/pkg/scheduler/framework/runtime/framework.go\r\nindex 8caa8ec1cb4..f238bcbdfb7 100644\r\n--- a/pkg/scheduler/framework/runtime/framework.go\r\n+++ b/pkg/scheduler/framework/runtime/framework.go\r\n@@ -450,12 +450,10 @@ func (os *orderedSet) has(s string) bool {\r\n \treturn found\r\n }\r\n \r\n-func (os *orderedSet) delete(s string) {\r\n-\tif i, found := os.set[s]; found {\r\n-\t\tdelete(os.set, s)\r\n-\t\tos.list = append(os.list[:i-os.deletionCnt], os.list[i+1-os.deletionCnt:]...)\r\n-\t\tos.deletionCnt++\r\n-\t}\r\n+func (os *orderedSet) delete(i int) {\r\n+\tdelete(os.set, os.list[i])\r\n+\tos.list = append(os.list[:i], os.list[i+1:]...)\r\n+\tos.deletionCnt++\r\n }\r\n \r\n func (f *frameworkImpl) expandMultiPointPlugins(logger klog.Logger, profile *config.KubeSchedulerProfile, pluginsMap map[string]framework.Plugin) error {\r\n@@ -526,10 +524,12 @@ func (f *frameworkImpl) expandMultiPointPlugins(logger klog.Logger, profile *con\r\n \t\t// - part 3: other plugins (excluded by part 1 & 2) in regular extension point.\r\n \t\tnewPlugins := reflect.New(reflect.TypeOf(e.slicePtr).Elem()).Elem()\r\n \t\t// part 1\r\n-\t\tfor _, name := range enabledSet.list {\r\n+\t\tfor i := range enabledSet.list {\r\n+\t\t\tj := i - enabledSet.deletionCnt\r\n+\t\t\tname := enabledSet.list[j]\r\n \t\t\tif overridePlugins.has(name) {\r\n \t\t\t\tnewPlugins = reflect.Append(newPlugins, reflect.ValueOf(pluginsMap[name]))\r\n-\t\t\t\tenabledSet.delete(name)\r\n+\t\t\t\tenabledSet.delete(j)\r\n \t\t\t}\r\n \t\t}\r\n \t\t// part 2\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/kubernetes/kubernetes/pull/122068#discussion_r1409746099",
    "filePath": "pkg/scheduler/framework/runtime/framework.go",
    "diffHunk": "@@ -526,7 +527,7 @@ func (f *frameworkImpl) expandMultiPointPlugins(logger klog.Logger, profile *con\n \t\t// - part 3: other plugins (excluded by part 1 & 2) in regular extension point.\n \t\tnewPlugins := reflect.New(reflect.TypeOf(e.slicePtr).Elem()).Elem()\n \t\t// part 1\n-\t\tfor _, name := range enabledSet.list {\n+\t\tfor _, name := range slice.CopyStrings(enabledSet.list) {",
    "line": 13,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-11-29T19:03:29Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1756002257,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:44.574Z"
  },
  {
    "repo": "kubernetes/kubernetes",
    "prNumber": 121940,
    "prTitle": "Add sleep in websocket unit tests whose test server returning instantly",
    "prAuthor": "ardaguclu",
    "prLink": "https://github.com/kubernetes/kubernetes/pull/121940",
    "commentAuthor": "aojea",
    "commentBody": "this is not a sleep problem, this has to wait until the request finish, a channel will just do it",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/kubernetes/kubernetes/pull/121940#discussion_r1420194643",
    "filePath": "staging/src/k8s.io/client-go/tools/remotecommand/websocket_test.go",
    "diffHunk": "@@ -714,6 +714,7 @@ func TestWebSocketClient_ProtocolVersions(t *testing.T) {\n \t\t\tt.Fatalf(\"unable to upgrade to create websocket connection: %v\", err)\n \t\t}\n \t\tdefer conn.Close()\n+\t\ttime.Sleep(100 * time.Millisecond)",
    "line": 4,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-12-08T09:49:57Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1772005657,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:43.885Z"
  },
  {
    "repo": "kubernetes/kubernetes",
    "prNumber": 119657,
    "prTitle": "NCC-E003660-WHE: Low Entropy Bootstrap Tokens",
    "prAuthor": "charles-chenzz",
    "prLink": "https://github.com/kubernetes/kubernetes/pull/119657",
    "commentAuthor": "liggitt",
    "commentBody": "this is an incompatible change that will break all callers of ParseToken / IsValidBootstrapToken / etc",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/kubernetes/kubernetes/pull/119657#discussion_r1280834629",
    "filePath": "staging/src/k8s.io/cluster-bootstrap/token/api/types.go",
    "diffHunk": "@@ -96,7 +96,7 @@ const (\n \tBootstrapGroupPattern = `\\Asystem:bootstrappers:[a-z0-9:-]{0,255}[a-z0-9]\\z`\n \n \t// BootstrapTokenPattern defines the {id}.{secret} regular expression pattern\n-\tBootstrapTokenPattern = `\\A([a-z0-9]{6})\\.([a-z0-9]{16})\\z`\n+\tBootstrapTokenPattern = `\\A([a-z0-9]{6})\\.([a-z0-9]{24})\\z`",
    "line": 16,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-08-01T15:45:00Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1557315581,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:46.174Z"
  },
  {
    "repo": "rust-lang/rust",
    "prNumber": 135035,
    "prTitle": "Fix formatting command",
    "prAuthor": "Noratrieb",
    "prLink": "https://github.com/rust-lang/rust/pull/135035",
    "commentAuthor": "the8472",
    "commentBody": "`InProgress` should be unreachable when passing `block: true`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rust-lang/rust/pull/135035#discussion_r1901129329",
    "filePath": "src/bootstrap/src/core/build_steps/format.rs",
    "diffHunk": "@@ -251,22 +255,38 @@ pub fn format(build: &Builder<'_>, check: bool, all: bool, paths: &[PathBuf]) {\n \n             // Poll completion before waiting.\n             for i in (0..children.len()).rev() {\n-                if children[i](false) {\n-                    children.swap_remove_back(i);\n-                    break;\n+                match children[i](false) {\n+                    RustfmtStatus::InProgress => {}\n+                    RustfmtStatus::Failed => {\n+                        result = Err(());\n+                        children.swap_remove_back(i);\n+                        break;\n+                    }\n+                    RustfmtStatus::Ok => {\n+                        children.swap_remove_back(i);\n+                        break;\n+                    }\n                 }\n             }\n \n             if children.len() >= max_processes {\n                 // Await oldest child.\n-                children.pop_front().unwrap()(true);\n+                match children.pop_front().unwrap()(true) {\n+                    RustfmtStatus::InProgress | RustfmtStatus::Ok => {}",
    "line": 89,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2025-01-02T18:03:21Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2527996592,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:51:58.770Z"
  },
  {
    "repo": "rust-lang/rust",
    "prNumber": 134212,
    "prTitle": "refactor: replace format! with concat! for string literals",
    "prAuthor": "Integral-Tech",
    "prLink": "https://github.com/rust-lang/rust/pull/134212",
    "commentAuthor": "bjorn3",
    "commentBody": "This doesn't work. If `BUILTIN_BACKEND` is not set, this `env!()` will still report an error rather than take the code path below.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rust-lang/rust/pull/134212#discussion_r1882188451",
    "filePath": "compiler/rustc_codegen_cranelift/scripts/cargo-clif.rs",
    "diffHunk": "@@ -13,8 +13,8 @@ fn main() {\n     }\n \n     let mut rustflags = vec![\"-Cpanic=abort\".to_owned(), \"-Zpanic-abort-tests\".to_owned()];\n-    if let Some(name) = option_env!(\"BUILTIN_BACKEND\") {\n-        rustflags.push(format!(\"-Zcodegen-backend={name}\"));\n+    if let Some(_) = option_env!(\"BUILTIN_BACKEND\") {\n+        rustflags.push(concat!(\"-Zcodegen-backend=\", env!(\"BUILTIN_BACKEND\")).to_owned());",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-12-12T14:02:50Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2499735549,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:51:47.680Z"
  },
  {
    "repo": "rust-lang/rust",
    "prNumber": 131405,
    "prTitle": "bootstrap/codegen_ssa: ship llvm-strip and use it for -Cstrip",
    "prAuthor": "davidtwco",
    "prLink": "https://github.com/rust-lang/rust/pull/131405",
    "commentAuthor": "bjorn3",
    "commentBody": "This breaks bootstrapping when the bootstrap compiler doesn't contain any LLVM tools as is the case when cg_clif bootstraps rustc:\r\n\r\n```\r\nBuilding stage0 tool lld-wrapper (x86_64-unknown-linux-gnu)\r\n     Compiling lld-wrapper v0.1.0 (/home/runner/work/rustc_codegen_cranelift/rustc_codegen_cranelift/rust/src/tools/lld-wrapper)\r\n      Finished `release` profile [optimized] target(s) in 0.43s\r\n  thread 'main' panicked at src/lib.rs:1714:24:\r\nsrc.symlink_metadata() failed with No such file or directory (os error 2) (\"src = /home/runner/work/rustc_codegen_cranelift/rustc_codegen_cranelift/rust/build/x86_64-unknown-linux-gnu/stage1/lib/rustlib/x86_64-unknown-linux-gnu/bin/llvm-objcopy\")\r\n```\r\n\r\nIt should probably check `builder.config.llvm_enabled(target_compiler.host) && builder.config.llvm_tools_enabled` before copying to ensure that `llvm-objcopy` exists in the first place.",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/rust-lang/rust/pull/131405#discussion_r1832498798",
    "filePath": "src/bootstrap/src/core/build_steps/compile.rs",
    "diffHunk": "@@ -1977,6 +1976,14 @@ impl Step for Assemble {\n             }\n         }\n \n+        {\n+            // `llvm-strip` is used by rustc, which is actually just a symlink to `llvm-objcopy`,\n+            // so copy and rename `llvm-objcopy`.\n+            let src_exe = exe(\"llvm-objcopy\", target_compiler.host);\n+            let dst_exe = exe(\"rust-objcopy\", target_compiler.host);\n+            builder.copy_link(&libdir_bin.join(src_exe), &libdir_bin.join(dst_exe));\n+        }",
    "line": 20,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-11-07T11:12:32Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2420670540,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:46.992Z"
  },
  {
    "repo": "rust-lang/rust",
    "prNumber": 130598,
    "prTitle": "Add recursion limit to FFI safety lint",
    "prAuthor": "gurry",
    "prLink": "https://github.com/rust-lang/rust/pull/130598",
    "commentAuthor": "compiler-errors",
    "commentBody": "This was never being decremented.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rust-lang/rust/pull/130598#discussion_r1771799224",
    "filePath": "compiler/rustc_lint/src/types.rs",
    "diffHunk": "@@ -1296,12 +1298,23 @@ impl<'a, 'tcx> ImproperCTypesVisitor<'a, 'tcx> {\n \n         // Protect against infinite recursion, for example\n         // `struct S(*mut S);`.\n-        // FIXME: A recursion limit is necessary as well, for irregular\n-        // recursive types.\n         if !acc.cache.insert(ty) {\n             return FfiSafe;\n         }\n \n+        // Additional recursion check for more complex types like\n+        // `struct A<T> { v: *const A<A<T>>, ... }` for which the\n+        // cache check above won't be enough (fixes #130310)\n+        if !tcx.recursion_limit().value_within_limit(acc.recursion_depth) {\n+            return FfiUnsafe {\n+                ty: acc.base_ty,\n+                reason: fluent::lint_improper_ctypes_recursion_limit_reached,\n+                help: None,\n+            };\n+        }\n+\n+        acc.recursion_depth += 1;",
    "line": 30,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-09-23T17:00:01Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2322848973,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:46.065Z"
  },
  {
    "repo": "rust-lang/rust",
    "prNumber": 129584,
    "prTitle": "warn the user if the upstream master branch is old",
    "prAuthor": "lolbinarycat",
    "prLink": "https://github.com/rust-lang/rust/pull/129584",
    "commentAuthor": "RalfJung",
    "commentBody": "This logic is incorrect for git worktrees, where `.git` is not a folder -- it is a file containing the path to where the .git folder lies.\r\n\r\nPlease either fix this PR or revert it, currently it causes incorrect warnings for everyone using worktrees.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rust-lang/rust/pull/129584#discussion_r1749998446",
    "filePath": "src/tools/build_helper/src/git.rs",
    "diffHunk": "@@ -159,3 +159,37 @@ pub fn get_git_untracked_files(\n         .collect();\n     Ok(Some(files))\n }\n+\n+/// Print a warning if the branch returned from `updated_master_branch` is old\n+///\n+/// For certain configurations of git repository, this remote will not be\n+/// updated when running `git pull`.\n+///\n+/// This can result in formatting thousands of files instead of a dozen,\n+/// so we should warn the user something is wrong.\n+pub fn warn_old_master_branch(\n+    config: &GitConfig<'_>,\n+    git_dir: &Path,\n+) -> Result<(), Box<dyn std::error::Error>> {\n+    use std::time::Duration;\n+    const WARN_AFTER: Duration = Duration::from_secs(60 * 60 * 24 * 10);\n+    let updated_master = updated_master_branch(config, Some(git_dir))?;\n+    let branch_path = git_dir.join(\".git/refs/remotes\").join(&updated_master);",
    "line": 19,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-09-09T10:24:24Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2289499249,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:48.475Z"
  },
  {
    "repo": "rust-lang/rust",
    "prNumber": 129467,
    "prTitle": "derive(SmartPointer): assume pointee from the single generic and better error messages",
    "prAuthor": "dingxiangfei2009",
    "prLink": "https://github.com/rust-lang/rust/pull/129467",
    "commentAuthor": "nnethercote",
    "commentBody": "Why is this `fuse` here? `type_params` is a `Vec` so there is no way that this iterator could return `None` and then later return `Some`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rust-lang/rust/pull/129467#discussion_r1879671470",
    "filePath": "compiler/rustc_builtin_macros/src/deriving/smart_ptr.rs",
    "diffHunk": "@@ -68,43 +67,63 @@ pub fn expand_deriving_smart_ptr(\n     };\n \n     // Convert generic parameters (from the struct) into generic args.\n-    let mut pointee_param = None;\n-    let mut multiple_pointee_diag: SmallVec<[_; 2]> = smallvec![];\n-    let self_params = generics\n+    let self_params: Vec<_> = generics\n         .params\n         .iter()\n-        .enumerate()\n-        .map(|(idx, p)| match p.kind {\n+        .map(|p| match p.kind {\n             GenericParamKind::Lifetime => GenericArg::Lifetime(cx.lifetime(p.span(), p.ident)),\n-            GenericParamKind::Type { .. } => {\n-                if p.attrs().iter().any(|attr| attr.has_name(sym::pointee)) {\n-                    if pointee_param.is_some() {\n-                        multiple_pointee_diag.push(cx.dcx().struct_span_err(\n-                            p.span(),\n-                            \"`SmartPointer` can only admit one type as pointee\",\n-                        ));\n-                    } else {\n-                        pointee_param = Some(idx);\n-                    }\n-                }\n-                GenericArg::Type(cx.ty_ident(p.span(), p.ident))\n-            }\n+            GenericParamKind::Type { .. } => GenericArg::Type(cx.ty_ident(p.span(), p.ident)),\n             GenericParamKind::Const { .. } => GenericArg::Const(cx.const_ident(p.span(), p.ident)),\n         })\n-        .collect::<Vec<_>>();\n-    let Some(pointee_param_idx) = pointee_param else {\n+        .collect();\n+    let type_params: Vec<_> = generics\n+        .params\n+        .iter()\n+        .enumerate()\n+        .filter_map(|(idx, p)| {\n+            if let GenericParamKind::Type { .. } = p.kind {\n+                Some((idx, p.span(), p.attrs().iter().any(|attr| attr.has_name(sym::pointee))))\n+            } else {\n+                None\n+            }\n+        })\n+        .collect();\n+\n+    let pointee_param_idx = if type_params.is_empty() {\n+        // `#[derive(SmartPointer)]` requires at least one generic type on the target `struct`\n         cx.dcx().struct_span_err(\n             span,\n-            \"At least one generic type should be designated as `#[pointee]` in order to derive `SmartPointer` traits\",\n+            \"`SmartPointer` can only be derived on `struct`s that are generic over at least one type\",\n         ).emit();\n         return;\n-    };\n-    if !multiple_pointee_diag.is_empty() {\n-        for diag in multiple_pointee_diag {\n-            diag.emit();\n+    } else if type_params.len() == 1 {\n+        // Regardless of the only type param being designed as `#[pointee]` or not, we can just use it as such\n+        type_params[0].0\n+    } else {\n+        let mut pointees = type_params\n+            .iter()\n+            .filter_map(|&(idx, span, is_pointee)| is_pointee.then_some((idx, span)))\n+            .fuse();",
    "line": 73,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-12-11T09:15:22Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2494868891,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:48.896Z"
  },
  {
    "repo": "rust-lang/rust",
    "prNumber": 127680,
    "prTitle": "Bootstrap command refactoring: port remaining commands with access to `Build` (step 6)",
    "prAuthor": "Kobzol",
    "prLink": "https://github.com/rust-lang/rust/pull/127680",
    "commentAuthor": "lukas-code",
    "commentBody": "This broke working on a detached HEAD:\r\n\r\n<details>\r\n<summary>error message</summary>\r\n\r\n```\r\nUpdating submodule src/doc/book\r\nfatal: ref HEAD is not a symbolic ref\r\n\r\nCommand cd \"/data/code/rust\" && env -u GIT_ALTERNATE_OBJECT_DIRECTORIES -u GIT_DIR -u GIT_INDEX_FILE -u GIT_OBJECT_DIRECTORY -u GIT_WORK_TREE \"git\" \"symbolic-ref\" \"--short\" \"HEAD\" (failure_mode=Exit, stdout_mode=Capture, stderr_mode=Print) did not execute successfully.\r\nExpected success, got exit status: 128\r\nCreated at: src/lib.rs:536:34\r\nExecuted at: src/lib.rs:540:18\r\n\r\nSTDOUT ----\r\n\r\n\r\nBuild completed unsuccessfully in 0:00:00\r\n```\r\n\r\n</details>\r\n\r\nI think we need `.allow_failure()` here.",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/rust-lang/rust/pull/127680#discussion_r1682868094",
    "filePath": "src/bootstrap/src/lib.rs",
    "diffHunk": "@@ -522,21 +534,16 @@ impl Build {\n         let update = |progress: bool| {\n             // Git is buggy and will try to fetch submodules from the tracking branch for *this* repository,\n             // even though that has no relation to the upstream for the submodule.\n-            let current_branch = {\n-                let output = helpers::git(Some(&self.src))\n-                    .args([\"symbolic-ref\", \"--short\", \"HEAD\"])\n-                    .as_command_mut()\n-                    .stderr(Stdio::inherit())\n-                    .output();\n-                let output = t!(output);\n-                if output.status.success() {\n-                    Some(String::from_utf8(output.stdout).unwrap().trim().to_owned())\n-                } else {\n-                    None\n-                }\n-            };\n+            let current_branch = helpers::git(Some(&self.src))\n+                .capture_stdout()\n+                .run_always()\n+                .args([\"symbolic-ref\", \"--short\", \"HEAD\"])\n+                .run(self)\n+                .stdout_if_ok()\n+                .map(|s| s.trim().to_owned());",
    "line": 87,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-07-18T13:43:20Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2185866292,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:48.995Z"
  },
  {
    "repo": "rust-lang/rust",
    "prNumber": 127485,
    "prTitle": "Suggest removing `.unwrap()` or `.expect()` if followed by a failed `?` operator",
    "prAuthor": "trevyn",
    "prLink": "https://github.com/rust-lang/rust/pull/127485",
    "commentAuthor": "fee1-dead",
    "commentBody": "In `baz3` the suggestion shouldn't fire because removing the `.unwrap` does not help. You probably want to check that the return type of the function is compatible with the non-`unwrap`ped reciever",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rust-lang/rust/pull/127485#discussion_r1677362781",
    "filePath": "tests/ui/try-trait/try-after-unwrap-issue-127345.rs",
    "diffHunk": "@@ -0,0 +1,62 @@\n+fn foo() -> Option<usize> {\n+    let x = Some(42).expect(\"moop\")?;\n+    //~^ ERROR the `?` operator can only be applied to values that implement `Try`\n+    //~| HELP the trait `Try` is not implemented for `{integer}`\n+    //~| HELP remove the `.expect()`\n+    let x = Some(42).unwrap()?;\n+    //~^ ERROR the `?` operator can only be applied to values that implement `Try`\n+    //~| HELP the trait `Try` is not implemented for `{integer}`\n+    //~| HELP remove the `.unwrap()`\n+    x\n+}\n+\n+fn bar() -> Option<usize> {\n+    foo().or(Some(43)).unwrap()?\n+    //~^ ERROR the `?` operator can only be applied to values that implement `Try`\n+    //~| HELP the trait `Try` is not implemented for `usize`\n+    //~| HELP remove the `.unwrap()`\n+}\n+\n+fn baz() -> Result<usize, ()> {\n+    Ok(44).unwrap()?\n+    //~^ ERROR the `?` operator can only be applied to values that implement `Try`\n+    //~| HELP the trait `Try` is not implemented for `{integer}`\n+    //~| HELP remove the `.unwrap()`\n+}\n+\n+fn baz2() -> Result<String, ()> {\n+    Ok(44).unwrap()?\n+    //~^ ERROR the `?` operator can only be applied to values that implement `Try`\n+    //~| HELP the trait `Try` is not implemented for `{integer}`\n+    //~| HELP remove the `.unwrap()`\n+}\n+\n+fn baz3() -> Option<usize> {\n+    Ok(44).unwrap()?\n+    //~^ ERROR the `?` operator can only be applied to values that implement `Try`\n+    //~| HELP the trait `Try` is not implemented for `{integer}`\n+    //~| HELP remove the `.unwrap()`\n+}",
    "line": 39,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-07-15T06:33:01Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2176941811,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:50.567Z"
  },
  {
    "repo": "rust-lang/rust",
    "prNumber": 127312,
    "prTitle": "Make CI more agnostic of the owning GitHub organization",
    "prAuthor": "Kobzol",
    "prLink": "https://github.com/rust-lang/rust/pull/127312",
    "commentAuthor": "nikic",
    "commentBody": "This means that the docker cache is no longer used in local builds, because GITHUB_REPOSITORY_OWNER Is not set.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rust-lang/rust/pull/127312#discussion_r1671795242",
    "filePath": "src/ci/docker/run.sh",
    "diffHunk": "@@ -93,8 +93,7 @@ if [ -f \"$docker_dir/$image/Dockerfile\" ]; then\n     docker --version\n \n     REGISTRY=ghcr.io\n-    # PR CI runs on rust-lang, but we want to use the cache from rust-lang-ci\n-    REGISTRY_USERNAME=rust-lang-ci\n+    REGISTRY_USERNAME=${GITHUB_REPOSITORY_OWNER}",
    "line": 6,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 255213530,
        "node_id": "REA_lATOAAsO6M5jpZIqzg82P9o",
        "user": {
          "login": "Kobzol",
          "id": 4539057,
          "node_id": "MDQ6VXNlcjQ1MzkwNTc=",
          "avatar_url": "https://avatars.githubusercontent.com/u/4539057?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/Kobzol",
          "html_url": "https://github.com/Kobzol",
          "followers_url": "https://api.github.com/users/Kobzol/followers",
          "following_url": "https://api.github.com/users/Kobzol/following{/other_user}",
          "gists_url": "https://api.github.com/users/Kobzol/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/Kobzol/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/Kobzol/subscriptions",
          "organizations_url": "https://api.github.com/users/Kobzol/orgs",
          "repos_url": "https://api.github.com/users/Kobzol/repos",
          "events_url": "https://api.github.com/users/Kobzol/events{/privacy}",
          "received_events_url": "https://api.github.com/users/Kobzol/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2024-07-10T07:56:25Z"
      }
    ],
    "timestamp": "2024-07-10T07:50:05Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2168311579,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:50.597Z"
  },
  {
    "repo": "rust-lang/rust",
    "prNumber": 125127,
    "prTitle": "Add support for -Cforce-frame-poiners=non-leaf",
    "prAuthor": "jsgf",
    "prLink": "https://github.com/rust-lang/rust/pull/125127",
    "commentAuthor": "workingjubilee",
    "commentBody": "This changes the behavior. The code did not previously override the value of `fp` if `force_frame_pointers` was `Some(false)`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rust-lang/rust/pull/125127#discussion_r1602402154",
    "filePath": "compiler/rustc_codegen_llvm/src/attributes.rs",
    "diffHunk": "@@ -108,8 +108,10 @@ pub fn frame_pointer_type_attr<'ll>(cx: &CodegenCx<'ll, '_>) -> Option<&'ll Attr\n     let opts = &cx.sess().opts;\n     // \"mcount\" function relies on stack pointer.\n     // See <https://sourceware.org/binutils/docs/gprof/Implementation.html>.\n-    if opts.unstable_opts.instrument_mcount || matches!(opts.cg.force_frame_pointers, Some(true)) {\n-        fp = FramePointer::Always;\n+    match (opts.unstable_opts.instrument_mcount, opts.cg.force_frame_pointers) {\n+        (true, _) => fp = FramePointer::Always,\n+        (_, Some(fp_opt)) => fp = fp_opt,",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-05-16T00:34:18Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2059271130,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:50.816Z"
  },
  {
    "repo": "rust-lang/rust",
    "prNumber": 120948,
    "prTitle": "Fix 120499",
    "prAuthor": "carlosguealv",
    "prLink": "https://github.com/rust-lang/rust/pull/120948",
    "commentAuthor": "onur-ozkan",
    "commentBody": "This will not work in the following cases:\r\n\r\n- If the last commit only exists in downstream (meaning not pushed to the upstream yet)\r\n- If it's tarball source tree (which doesn't include `.git` in it)",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rust-lang/rust/pull/120948#discussion_r1496082351",
    "filePath": "src/bootstrap/bootstrap.py",
    "diffHunk": "@@ -1031,6 +1031,11 @@ def check_vendored_status(self):\n                             \"--sync ./src/tools/rust-analyzer/Cargo.toml \" \\\n                             \"--sync ./compiler/rustc_codegen_cranelift/Cargo.toml \" \\\n                             \"--sync ./src/bootstrap/Cargo.toml \"\n+\n+                # get the last commit hash of the rustc directory\n+                last_commit = subprocess.check_output(['git', 'rev-parse', 'HEAD']) \\\n+                                .decode('ascii').strip()",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-02-20T16:01:03Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1890836540,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:52.581Z"
  },
  {
    "repo": "rust-lang/rust",
    "prNumber": 119086,
    "prTitle": "Query panic!() to useful diagnostic",
    "prAuthor": "RossSmyth",
    "prLink": "https://github.com/rust-lang/rust/pull/119086",
    "commentAuthor": "Zoxc",
    "commentBody": "This branch now introduces a panic, which is not correct.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rust-lang/rust/pull/119086#discussion_r1446765722",
    "filePath": "compiler/rustc_query_system/src/query/plumbing.rs",
    "diffHunk": "@@ -277,11 +284,14 @@ where\n                     // We didn't find the query result in the query cache. Check if it was\n                     // poisoned due to a panic instead.\n                     let lock = query.query_state(qcx).active.get_shard_by_value(&key).lock();\n+\n                     match lock.get(&key) {\n-                        // The query we waited on panicked. Continue unwinding here.\n-                        Some(QueryResult::Poisoned) => FatalError.raise(),\n+                        Some(QueryResult::Poisoned) => {\n+                            panic!(\"query '{}' not cached due to poisoning\", query.name())",
    "line": 53,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-01-10T00:39:11Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1812241097,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:54.999Z"
  },
  {
    "repo": "rust-lang/rust",
    "prNumber": 116633,
    "prTitle": "Do not inline integer literals which are out of range in format_args!",
    "prAuthor": "agluszak",
    "prLink": "https://github.com/rust-lang/rust/pull/116633",
    "commentAuthor": "lukas-code",
    "commentBody": "This uses the host's `isize`, but should be using use the target's `isize`. Same for `usize` below.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rust-lang/rust/pull/116633#discussion_r1355185566",
    "filePath": "compiler/rustc_ast/src/ast.rs",
    "diffHunk": "@@ -1795,6 +1795,26 @@ pub enum LitIntType {\n     Unsuffixed,\n }\n \n+impl LitIntType {\n+    pub const fn max_literal_value(&self) -> u128 {\n+        match self {\n+            LitIntType::Signed(IntTy::I8) => i8::MAX as u128,\n+            LitIntType::Signed(IntTy::I16) => i16::MAX as u128,\n+            LitIntType::Signed(IntTy::I32) => i32::MAX as u128,\n+            LitIntType::Signed(IntTy::I64) => i64::MAX as u128,\n+            LitIntType::Signed(IntTy::I128) => i128::MAX as u128,\n+            LitIntType::Signed(IntTy::Isize) => isize::MAX as u128,",
    "line": 12,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-10-11T15:11:49Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1671516813,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:54.741Z"
  },
  {
    "repo": "ggerganov/llama.cpp",
    "prNumber": 9912,
    "prTitle": "rpc : backend refactoring",
    "prAuthor": "rgerganov",
    "prLink": "https://github.com/ggerganov/llama.cpp/pull/9912",
    "commentAuthor": "Green-Sky",
    "commentBody": "this is not really how `pack(1)` works. every struct after a single `pack(1)` will be affected, only after another `pack()` (empty), it will be the value from before.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/ggerganov/llama.cpp/pull/9912#discussion_r1806830024",
    "filePath": "ggml/src/ggml-rpc.cpp",
    "diffHunk": "@@ -96,6 +95,77 @@ enum rpc_cmd {\n     RPC_CMD_COUNT,\n };\n \n+#pragma pack(1)\n+struct rpc_msg_alloc_buffer_req {\n+    uint64_t size;\n+};",
    "line": 24,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-10-18T17:43:46Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2378662553,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:54.706Z"
  },
  {
    "repo": "ggerganov/llama.cpp",
    "prNumber": 9358,
    "prTitle": "llama : fix empty ring buffer push",
    "prAuthor": "ggerganov",
    "prLink": "https://github.com/ggerganov/llama.cpp/pull/9358",
    "commentAuthor": "slaren",
    "commentBody": "I think this is not correct, it should check the capacity rather than the size (which will always be zero unless something is pushed). I will push a fix later, but at the moment this sampler is probably broken.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/ggerganov/llama.cpp/pull/9358#discussion_r1749204525",
    "filePath": "src/llama-sampling.cpp",
    "diffHunk": "@@ -1226,7 +1226,9 @@ static struct llama_sampler_i llama_sampler_penalties_i = {\n     /* .name   = */ [](const struct llama_sampler * /*smpl*/) { return \"penalties\"; },\n     /* .accept = */ [](struct llama_sampler * smpl, llama_token token) {\n         auto * ctx = (llama_sampler_penalties *) smpl->ctx;\n-        ctx->prev.push_back(token);\n+        if (ctx->prev.size()) {\n+            ctx->prev.push_back(token);\n+        }",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-09-08T11:55:57Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2288518539,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:56.896Z"
  },
  {
    "repo": "ggerganov/llama.cpp",
    "prNumber": 7388,
    "prTitle": "server : tuning tests",
    "prAuthor": "ggerganov",
    "prLink": "https://github.com/ggerganov/llama.cpp/pull/7388",
    "commentAuthor": "JohannesGaessler",
    "commentBody": "This should be set to temperature 1, not temperature 0. With temperature 0 you get greedy decoding in which case the seed is irrelevant. So this test can no longer detect issues with e.g. the RNG state being shared between slots.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/ggerganov/llama.cpp/pull/7388#discussion_r1606398144",
    "filePath": "examples/server/tests/features/results.feature",
    "diffHunk": "@@ -13,6 +13,7 @@ Feature: Results\n \n   Scenario Outline: consistent results with same seed\n     Given <n_slots> slots\n+    And   0.0 temperature",
    "line": 4,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-05-20T07:58:01Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2065602520,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:56.749Z"
  },
  {
    "repo": "ggerganov/llama.cpp",
    "prNumber": 7342,
    "prTitle": "Another threadpool: Avoid creating hundreds of threads in GGML",
    "prAuthor": "besnardjb",
    "prLink": "https://github.com/ggerganov/llama.cpp/pull/7342",
    "commentAuthor": "slaren",
    "commentBody": "Might need to add a `num_threads(n_threads)` here to make sure that omp always launches all the threads, otherwise it will deadlock.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/ggerganov/llama.cpp/pull/7342#discussion_r1606165355",
    "filePath": "ggml.c",
    "diffHunk": "@@ -20086,44 +20097,50 @@ enum ggml_status ggml_graph_compute(struct ggml_cgraph * cgraph, struct ggml_cpl\n     };\n     struct ggml_compute_state * workers = alloca(sizeof(struct ggml_compute_state)*n_threads);\n \n-    // create thread pool\n-    if (n_threads > 1) {\n-        for (int j = 1; j < n_threads; ++j) {\n-            workers[j] = (struct ggml_compute_state) {\n-                .thrd   = 0,\n-                .ith = j,\n-                .shared = &state_shared,\n-                .ec = GGML_STATUS_SUCCESS,\n-            };\n+    const int64_t perf_start_cycles  = ggml_perf_cycles();\n+    const int64_t perf_start_time_us = ggml_perf_time_us();\n \n+    /* Loop is reversed as in the NO_OMP case we want threads to start\n+    before the main thread (j==0) */\n+    #pragma omp parallel for shared(workers,state_shared)",
    "line": 58,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-05-20T01:58:36Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2065224533,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:56.752Z"
  },
  {
    "repo": "ggerganov/llama.cpp",
    "prNumber": 6829,
    "prTitle": "ggml : add RPC backend",
    "prAuthor": "rgerganov",
    "prLink": "https://github.com/ggerganov/llama.cpp/pull/6829",
    "commentAuthor": "chraac",
    "commentBody": "Hi @rgerganov, thank you for your valuable contribution to enhance the distribution capability in llama.cpp. have been using your implementation for several days and have noticed an issue: \r\nWhen the client closes the connection, the server does not free the memory it has allocated.\r\n\r\nUpon investigating the source code, I discovered that instead of releasing the memory, we simply exit the inner loop and immediately wait for a new connection.\r\n\r\nWondering if we should monitor the `ALLOC_BUFFER` and `FREE_BUFFER`, specifically by maintaining a list of allocated buffers. This would allow us to free any remaining buffers once the client closes the connection.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/ggerganov/llama.cpp/pull/6829#discussion_r1605660259",
    "filePath": "ggml-rpc.cpp",
    "diffHunk": "@@ -0,0 +1,1023 @@\n+#include \"ggml-rpc.h\"\n+#include \"ggml.h\"\n+#include \"ggml-backend-impl.h\"\n+\n+#include <cinttypes>\n+#include <string>\n+#include <vector>\n+#include <memory>\n+#include <unordered_map>\n+#include <unordered_set>\n+#ifdef _WIN32\n+#  define WIN32_LEAN_AND_MEAN\n+#  ifndef NOMINMAX\n+#     define NOMINMAX\n+#  endif\n+#  include <windows.h>\n+#  include <winsock2.h>\n+#else\n+#  include <arpa/inet.h>\n+#  include <sys/socket.h>\n+#  include <sys/types.h>\n+#  include <netinet/in.h>\n+#  include <netinet/tcp.h>\n+#  include <netdb.h>\n+#  include <unistd.h>\n+#endif\n+#include <string.h>\n+\n+#define UNUSED GGML_UNUSED\n+\n+#define GGML_DEBUG 1\n+#if (GGML_DEBUG >= 1)\n+#define GGML_PRINT_DEBUG(...) printf(__VA_ARGS__)\n+#else\n+#define GGML_PRINT_DEBUG(...)\n+#endif\n+\n+#ifdef _WIN32\n+typedef SOCKET sockfd_t;\n+using ssize_t = __int64;\n+#else\n+typedef int sockfd_t;\n+#endif\n+\n+// cross-platform socket\n+struct socket_t {\n+    sockfd_t fd;\n+    socket_t(sockfd_t fd) : fd(fd) {}\n+    ~socket_t() {\n+#ifdef _WIN32\n+        closesocket(this->fd);\n+#else\n+        close(this->fd);\n+#endif\n+    }\n+};\n+\n+// ggml_tensor is serialized into rpc_tensor\n+struct rpc_tensor {\n+    uint64_t id;\n+    uint32_t type;\n+    uint64_t buffer;\n+    uint32_t ne[GGML_MAX_DIMS];\n+    uint32_t nb[GGML_MAX_DIMS];\n+    uint32_t op;\n+    int32_t  op_params[GGML_MAX_OP_PARAMS / sizeof(int32_t)];\n+    int32_t  flags;\n+    uint64_t src[GGML_MAX_SRC];\n+    uint64_t view_src;\n+    uint64_t view_offs;\n+    uint64_t data;\n+    char name[GGML_MAX_NAME];\n+};\n+\n+// RPC commands\n+enum rpc_cmd {\n+    ALLOC_BUFFER = 0,\n+    GET_ALIGNMENT,\n+    GET_MAX_SIZE,\n+    BUFFER_GET_BASE,\n+    FREE_BUFFER,\n+    BUFFER_CLEAR,\n+    SET_TENSOR,\n+    GET_TENSOR,\n+    COPY_TENSOR,\n+    GRAPH_COMPUTE,\n+    GET_DEVICE_MEMORY,\n+};\n+\n+// RPC data structures\n+\n+static ggml_guid_t ggml_backend_rpc_guid() {\n+    static ggml_guid guid = {0x99, 0x68, 0x5b, 0x6c, 0xd2, 0x83, 0x3d, 0x24, 0x25, 0x36, 0x72, 0xe1, 0x5b, 0x0e, 0x14, 0x03};\n+    return &guid;\n+}\n+\n+struct ggml_backend_rpc_buffer_type_context {\n+    std::shared_ptr<socket_t> sock;\n+    std::string name;\n+    size_t alignment;\n+    size_t max_size;\n+};\n+\n+struct ggml_backend_rpc_context {\n+    std::string endpoint;\n+    std::string name;\n+    std::shared_ptr<socket_t> sock;\n+    ggml_backend_buffer_type_t buft;\n+};\n+\n+struct ggml_backend_rpc_buffer_context {\n+    std::shared_ptr<socket_t> sock;\n+    std::unordered_map<ggml_backend_buffer_t, void *> base_cache;\n+    uint64_t remote_ptr;\n+    std::string name;\n+};\n+\n+// RPC helper functions\n+\n+static std::shared_ptr<socket_t> make_socket(sockfd_t fd) {\n+#ifdef _WIN32\n+    if (fd == INVALID_SOCKET) {\n+        return nullptr;\n+    }\n+#else\n+    if (fd < 0) {\n+        return nullptr;\n+    }\n+#endif\n+    return std::make_shared<socket_t>(fd);\n+}\n+\n+static bool set_no_delay(sockfd_t sockfd) {\n+    int flag = 1;\n+    // set TCP_NODELAY to disable Nagle's algorithm\n+    int ret = setsockopt(sockfd, IPPROTO_TCP, TCP_NODELAY, (char *)&flag, sizeof(int));\n+    return ret >= 0;\n+}\n+\n+static std::shared_ptr<socket_t> socket_connect(const char * host, int port) {\n+    struct sockaddr_in addr;\n+    auto sockfd = socket(AF_INET, SOCK_STREAM, 0);\n+    auto sock_ptr = make_socket(sockfd);\n+    if (sock_ptr == nullptr) {\n+        return nullptr;\n+    }\n+    if (!set_no_delay(sockfd)) {\n+        fprintf(stderr, \"Failed to set TCP_NODELAY\\n\");\n+        return nullptr;\n+    }\n+    addr.sin_family = AF_INET;\n+    addr.sin_port = htons(port);\n+    struct hostent * server = gethostbyname(host);\n+    if (server == NULL) {\n+        fprintf(stderr, \"Cannot resolve host '%s'\\n\", host);\n+        return nullptr;\n+    }\n+    memcpy(&addr.sin_addr.s_addr, server->h_addr, server->h_length);\n+    if (connect(sock_ptr->fd, (struct sockaddr *)&addr, sizeof(addr)) < 0) {\n+        return nullptr;\n+    }\n+    return sock_ptr;\n+}\n+\n+static std::shared_ptr<socket_t> socket_accept(sockfd_t srv_sockfd) {\n+    auto client_socket_fd = accept(srv_sockfd, NULL, NULL);\n+    auto client_socket = make_socket(client_socket_fd);\n+    if (client_socket == nullptr) {\n+        return nullptr;\n+    }\n+    if (!set_no_delay(client_socket_fd)) {\n+        fprintf(stderr, \"Failed to set TCP_NODELAY\\n\");\n+        return nullptr;\n+    }\n+    return client_socket;\n+}\n+\n+static std::shared_ptr<socket_t> create_server_socket(const char * host, int port) {\n+    auto sockfd = socket(AF_INET, SOCK_STREAM, 0);\n+    auto sock = make_socket(sockfd);\n+    if (sock == nullptr) {\n+        return nullptr;\n+    }\n+\n+    struct sockaddr_in serv_addr;\n+    serv_addr.sin_family = AF_INET;\n+    serv_addr.sin_addr.s_addr = inet_addr(host);\n+    serv_addr.sin_port = htons(port);\n+\n+    if (bind(sockfd, (struct sockaddr *) &serv_addr, sizeof(serv_addr)) < 0) {\n+        return nullptr;\n+    }\n+    if (listen(sockfd, 1) < 0) {\n+        return nullptr;\n+    }\n+    return sock;\n+}\n+\n+static bool send_data(sockfd_t sockfd, const void * data, size_t size) {\n+    size_t bytes_sent = 0;\n+    while (bytes_sent < size) {\n+        ssize_t n = send(sockfd, (const char *)data + bytes_sent, size - bytes_sent, 0);\n+        if (n < 0) {\n+            return false;\n+        }\n+        bytes_sent += n;\n+    }\n+    return true;\n+}\n+\n+static bool recv_data(sockfd_t sockfd, void * data, size_t size) {\n+    size_t bytes_recv = 0;\n+    while (bytes_recv < size) {\n+        ssize_t n = recv(sockfd, (char *)data + bytes_recv, size - bytes_recv, 0);\n+        if (n <= 0) {\n+            return false;\n+        }\n+        bytes_recv += n;\n+    }\n+    return true;\n+}\n+\n+static bool parse_endpoint(const char * endpoint, std::string & host, int & port) {\n+    std::string str(endpoint);\n+    size_t pos = str.find(':');\n+    if (pos == std::string::npos) {\n+        return false;\n+    }\n+    host = str.substr(0, pos);\n+    port = std::stoi(str.substr(pos + 1));\n+    return true;\n+}\n+\n+// RPC request : | rpc_cmd (1 byte) | request_size (8 bytes) | request_data (request_size bytes) |\n+// RPC response: | response_size (8 bytes) | response_data (response_size bytes) |\n+static bool send_rpc_cmd(const std::shared_ptr<socket_t> & sock, enum rpc_cmd cmd, const std::vector<uint8_t> & input, std::vector<uint8_t> & output) {\n+    uint8_t cmd_byte = cmd;\n+    if (!send_data(sock->fd, &cmd_byte, sizeof(cmd_byte))) {\n+        return false;\n+    }\n+    uint64_t input_size = input.size();\n+    if (!send_data(sock->fd, &input_size, sizeof(input_size))) {\n+        return false;\n+    }\n+    if (!send_data(sock->fd, input.data(), input.size())) {\n+        return false;\n+    }\n+    uint64_t output_size;\n+    if (!recv_data(sock->fd, &output_size, sizeof(output_size))) {\n+        return false;\n+    }\n+    if (output_size == 0) {\n+        output.clear();\n+        return true;\n+    }\n+    output.resize(output_size);\n+    if (!recv_data(sock->fd, output.data(), output_size)) {\n+        return false;\n+    }\n+    return true;\n+}\n+\n+// RPC client-side implementation\n+\n+GGML_CALL static const char * ggml_backend_rpc_buffer_get_name(ggml_backend_buffer_t buffer) {\n+    ggml_backend_rpc_buffer_context * ctx = (ggml_backend_rpc_buffer_context *)buffer->context;\n+    return ctx->name.c_str();\n+}\n+\n+GGML_CALL static void ggml_backend_rpc_buffer_free_buffer(ggml_backend_buffer_t buffer) {\n+    ggml_backend_rpc_buffer_context * ctx = (ggml_backend_rpc_buffer_context *)buffer->context;\n+    // input serialization format: | remote_ptr (8 bytes) |\n+    std::vector<uint8_t> input(sizeof(uint64_t), 0);\n+    uint64_t remote_ptr = ctx->remote_ptr;\n+    memcpy(input.data(), &remote_ptr, sizeof(remote_ptr));\n+    std::vector<uint8_t> output;\n+    bool status = send_rpc_cmd(ctx->sock, FREE_BUFFER, input, output);\n+    GGML_ASSERT(status);\n+    GGML_ASSERT(output.empty());\n+    delete ctx;\n+}\n+\n+GGML_CALL static void * ggml_backend_rpc_buffer_get_base(ggml_backend_buffer_t buffer) {\n+    ggml_backend_rpc_buffer_context * ctx = (ggml_backend_rpc_buffer_context *)buffer->context;\n+    if (ctx->base_cache.find(buffer) != ctx->base_cache.end()) {\n+        return ctx->base_cache[buffer];\n+    }\n+    // input serialization format: | remote_ptr (8 bytes) |\n+    std::vector<uint8_t> input(sizeof(uint64_t), 0);\n+    uint64_t remote_ptr = ctx->remote_ptr;\n+    memcpy(input.data(), &remote_ptr, sizeof(remote_ptr));\n+    std::vector<uint8_t> output;\n+    bool status = send_rpc_cmd(ctx->sock, BUFFER_GET_BASE, input, output);\n+    GGML_ASSERT(status);\n+    GGML_ASSERT(output.size() == sizeof(uint64_t));\n+    // output serialization format: | base_ptr (8 bytes) |\n+    uint64_t base_ptr;\n+    memcpy(&base_ptr, output.data(), sizeof(base_ptr));\n+    void * base = reinterpret_cast<void *>(base_ptr);\n+    ctx->base_cache[buffer] = base;\n+    return base;\n+}\n+\n+static rpc_tensor serialize_tensor(const ggml_tensor * tensor) {\n+    rpc_tensor result;\n+    result.id = reinterpret_cast<uint64_t>(tensor);\n+    result.type = tensor->type;\n+    if (tensor->buffer) {\n+        ggml_backend_buffer_t buffer = tensor->buffer;\n+        ggml_backend_rpc_buffer_context * ctx = (ggml_backend_rpc_buffer_context *)buffer->context;\n+        result.buffer = ctx->remote_ptr;\n+    } else {\n+        result.buffer = 0;\n+    }\n+    for (uint32_t i = 0; i < GGML_MAX_DIMS; i++) {\n+        result.ne[i] = tensor->ne[i];\n+        result.nb[i] = tensor->nb[i];\n+    }\n+    result.op = tensor->op;\n+    for (uint32_t i = 0; i < GGML_MAX_OP_PARAMS / sizeof(int32_t); i++) {\n+        result.op_params[i] = tensor->op_params[i];\n+    }\n+    result.flags = tensor->flags;\n+    for (uint32_t i = 0; i < GGML_MAX_SRC; i++) {\n+        result.src[i] = reinterpret_cast<uint64_t>(tensor->src[i]);\n+    }\n+    result.view_src = reinterpret_cast<uint64_t>(tensor->view_src);\n+    result.view_offs = tensor->view_offs;\n+    result.data = reinterpret_cast<uint64_t>(tensor->data);\n+    snprintf(result.name, GGML_MAX_NAME, \"%s\", tensor->name);\n+    return result;\n+}\n+\n+static ggml_tensor * deserialize_tensor(struct ggml_context * ctx, const rpc_tensor * tensor) {\n+    ggml_tensor * result = ggml_new_tensor_4d(ctx, (ggml_type) tensor->type,\n+        tensor->ne[0], tensor->ne[1], tensor->ne[2], tensor->ne[3]);\n+    for (uint32_t i = 0; i < GGML_MAX_DIMS; i++) {\n+        result->nb[i] = tensor->nb[i];\n+    }\n+    result->buffer = reinterpret_cast<ggml_backend_buffer_t>(tensor->buffer);\n+    result->op = (ggml_op) tensor->op;\n+    for (uint32_t i = 0; i < GGML_MAX_OP_PARAMS / sizeof(int32_t); i++) {\n+        result->op_params[i] = tensor->op_params[i];\n+    }\n+    result->flags = tensor->flags;\n+    result->data = reinterpret_cast<void *>(tensor->data);\n+    ggml_set_name(result, tensor->name);\n+    return result;\n+}\n+\n+GGML_CALL static void ggml_backend_rpc_buffer_init_tensor(ggml_backend_buffer_t buffer, ggml_tensor * tensor) {\n+    UNUSED(buffer);\n+    if (ggml_is_quantized(tensor->type)) {\n+        // TODO: this check is due to MATRIX_ROW_PADDING in CUDA and should be generalized\n+        GGML_ASSERT(tensor->ne[0] % 512 == 0 && \"unsupported quantized tensor\");\n+    }\n+}\n+\n+GGML_CALL static void ggml_backend_rpc_buffer_set_tensor(ggml_backend_buffer_t buffer, ggml_tensor * tensor, const void * data, size_t offset, size_t size) {\n+    ggml_backend_rpc_buffer_context * ctx = (ggml_backend_rpc_buffer_context *)buffer->context;\n+    // input serialization format: | rpc_tensor | offset (8 bytes) | data (size bytes) |\n+    size_t input_size = sizeof(rpc_tensor) + sizeof(uint64_t) + size;\n+    std::vector<uint8_t> input(input_size, 0);\n+    rpc_tensor rpc_tensor = serialize_tensor(tensor);\n+    memcpy(input.data(), &rpc_tensor, sizeof(rpc_tensor));\n+    memcpy(input.data() + sizeof(rpc_tensor), &offset, sizeof(offset));\n+    memcpy(input.data() + sizeof(rpc_tensor) + sizeof(offset), data, size);\n+    std::vector<uint8_t> output;\n+    bool status = send_rpc_cmd(ctx->sock, SET_TENSOR, input, output);\n+    GGML_ASSERT(status);\n+}\n+\n+GGML_CALL static void ggml_backend_rpc_buffer_get_tensor(ggml_backend_buffer_t buffer, const ggml_tensor * tensor, void * data, size_t offset, size_t size) {\n+    ggml_backend_rpc_buffer_context * ctx = (ggml_backend_rpc_buffer_context *)buffer->context;\n+    // input serialization format: | rpc_tensor | offset (8 bytes) | size (8 bytes) |\n+    int input_size = sizeof(rpc_tensor) + 2*sizeof(uint64_t);\n+    std::vector<uint8_t> input(input_size, 0);\n+    rpc_tensor rpc_tensor = serialize_tensor(tensor);\n+    memcpy(input.data(), &rpc_tensor, sizeof(rpc_tensor));\n+    memcpy(input.data() + sizeof(rpc_tensor), &offset, sizeof(offset));\n+    memcpy(input.data() + sizeof(rpc_tensor) + sizeof(offset), &size, sizeof(size));\n+    std::vector<uint8_t> output;\n+    bool status = send_rpc_cmd(ctx->sock, GET_TENSOR, input, output);\n+    GGML_ASSERT(status);\n+    GGML_ASSERT(output.size() == size);\n+    // output serialization format: | data (size bytes) |\n+    memcpy(data, output.data(), size);\n+}\n+\n+GGML_CALL static bool ggml_backend_rpc_buffer_cpy_tensor(ggml_backend_buffer_t buffer, const ggml_tensor * src, ggml_tensor * dst) {\n+    // check if src and dst are on the same server\n+    ggml_backend_buffer_t src_buffer = src->buffer;\n+    ggml_backend_rpc_buffer_context * src_ctx = (ggml_backend_rpc_buffer_context *)src_buffer->context;\n+    ggml_backend_buffer_t dst_buffer = dst->buffer;\n+    ggml_backend_rpc_buffer_context * dst_ctx = (ggml_backend_rpc_buffer_context *)dst_buffer->context;\n+    if (src_ctx->sock != dst_ctx->sock) {\n+        return false;\n+    }\n+    ggml_backend_rpc_buffer_context * ctx = (ggml_backend_rpc_buffer_context *)buffer->context;\n+    // input serialization format: | rpc_tensor src | rpc_tensor dst |\n+    int input_size = 2*sizeof(rpc_tensor);\n+    std::vector<uint8_t> input(input_size, 0);\n+    rpc_tensor rpc_src = serialize_tensor(src);\n+    rpc_tensor rpc_dst = serialize_tensor(dst);\n+    memcpy(input.data(), &rpc_src, sizeof(rpc_src));\n+    memcpy(input.data() + sizeof(rpc_src), &rpc_dst, sizeof(rpc_dst));\n+    std::vector<uint8_t> output;\n+    bool status = send_rpc_cmd(ctx->sock, COPY_TENSOR, input, output);\n+    GGML_ASSERT(status);\n+    // output serialization format: | result (1 byte) |\n+    GGML_ASSERT(output.size() == 1);\n+    return output[0];\n+}\n+\n+GGML_CALL static void ggml_backend_rpc_buffer_clear(ggml_backend_buffer_t buffer, uint8_t value) {\n+    ggml_backend_rpc_buffer_context * ctx = (ggml_backend_rpc_buffer_context *)buffer->context;\n+    // serialization format: | bufptr (8 bytes) | value (1 byte) |\n+    int input_size = sizeof(uint64_t) + sizeof(uint8_t);\n+    std::vector<uint8_t> input(input_size, 0);\n+    memcpy(input.data(), &ctx->remote_ptr, sizeof(ctx->remote_ptr));\n+    memcpy(input.data() + sizeof(ctx->remote_ptr), &value, sizeof(value));\n+    std::vector<uint8_t> output;\n+    bool status = send_rpc_cmd(ctx->sock, BUFFER_CLEAR, input, output);\n+    GGML_ASSERT(status);\n+}\n+\n+static ggml_backend_buffer_i ggml_backend_rpc_buffer_interface = {\n+    /* .get_name        = */ ggml_backend_rpc_buffer_get_name,\n+    /* .free_buffer     = */ ggml_backend_rpc_buffer_free_buffer,\n+    /* .get_base        = */ ggml_backend_rpc_buffer_get_base,\n+    /* .init_tensor     = */ ggml_backend_rpc_buffer_init_tensor,\n+    /* .set_tensor      = */ ggml_backend_rpc_buffer_set_tensor,\n+    /* .get_tensor      = */ ggml_backend_rpc_buffer_get_tensor,\n+    /* .cpy_tensor      = */ ggml_backend_rpc_buffer_cpy_tensor,\n+    /* .clear           = */ ggml_backend_rpc_buffer_clear,\n+    /* .reset           = */ NULL,\n+};\n+\n+GGML_CALL static const char * ggml_backend_rpc_buffer_type_name(ggml_backend_buffer_type_t buft) {\n+    ggml_backend_rpc_buffer_type_context * buft_ctx = (ggml_backend_rpc_buffer_type_context *)buft->context;\n+    return buft_ctx->name.c_str();\n+}\n+\n+GGML_CALL static ggml_backend_buffer_t ggml_backend_rpc_buffer_type_alloc_buffer(ggml_backend_buffer_type_t buft, size_t size) {\n+    ggml_backend_rpc_buffer_type_context * buft_ctx = (ggml_backend_rpc_buffer_type_context *)buft->context;\n+    // input serialization format: | size (8 bytes) |\n+    int input_size = sizeof(uint64_t);\n+    std::vector<uint8_t> input(input_size, 0);\n+    memcpy(input.data(), &size, sizeof(size));\n+    std::vector<uint8_t> output;\n+    bool status = send_rpc_cmd(buft_ctx->sock, ALLOC_BUFFER, input, output);\n+    GGML_ASSERT(status);\n+    GGML_ASSERT(output.size() == 2*sizeof(uint64_t));\n+    // output serialization format: | remote_ptr (8 bytes) | remote_size (8 bytes) |\n+    uint64_t remote_ptr;\n+    memcpy(&remote_ptr, output.data(), sizeof(remote_ptr));\n+    size_t remote_size;\n+    memcpy(&remote_size, output.data() + sizeof(uint64_t), sizeof(remote_size));\n+\n+    ggml_backend_buffer_t buffer = ggml_backend_buffer_init(buft,\n+        ggml_backend_rpc_buffer_interface,\n+        new ggml_backend_rpc_buffer_context{buft_ctx->sock, {}, remote_ptr, \"RPC\"},\n+        remote_size);\n+\n+    return buffer;\n+}\n+\n+static size_t get_alignment(const std::shared_ptr<socket_t> & sock) {\n+    // input serialization format: | 0 bytes |\n+    std::vector<uint8_t> input;\n+    std::vector<uint8_t> output;\n+    bool status = send_rpc_cmd(sock, GET_ALIGNMENT, input, output);\n+    GGML_ASSERT(status);\n+    GGML_ASSERT(output.size() == sizeof(uint64_t));\n+    // output serialization format: | alignment (8 bytes) |\n+    uint64_t alignment;\n+    memcpy(&alignment, output.data(), sizeof(alignment));\n+    return alignment;\n+}\n+\n+GGML_CALL static size_t ggml_backend_rpc_buffer_type_get_alignment(ggml_backend_buffer_type_t buft) {\n+    ggml_backend_rpc_buffer_type_context * buft_ctx = (ggml_backend_rpc_buffer_type_context *)buft->context;\n+    return buft_ctx->alignment;\n+}\n+\n+static size_t get_max_size(const std::shared_ptr<socket_t> & sock) {\n+    // input serialization format: | 0 bytes |\n+    std::vector<uint8_t> input;\n+    std::vector<uint8_t> output;\n+    bool status = send_rpc_cmd(sock, GET_MAX_SIZE, input, output);\n+    GGML_ASSERT(status);\n+    GGML_ASSERT(output.size() == sizeof(uint64_t));\n+    // output serialization format: | max_size (8 bytes) |\n+    uint64_t max_size;\n+    memcpy(&max_size, output.data(), sizeof(max_size));\n+    return max_size;\n+}\n+\n+GGML_CALL static size_t ggml_backend_rpc_get_max_size(ggml_backend_buffer_type_t buft) {\n+    ggml_backend_rpc_buffer_type_context * buft_ctx = (ggml_backend_rpc_buffer_type_context *)buft->context;\n+    return buft_ctx->max_size;\n+}\n+\n+GGML_CALL static size_t ggml_backend_rpc_buffer_type_get_alloc_size(ggml_backend_buffer_type_t buft, const ggml_tensor * tensor) {\n+    UNUSED(buft);\n+    return ggml_nbytes(tensor);\n+}\n+\n+GGML_CALL static bool ggml_backend_rpc_buffer_type_supports_backend(ggml_backend_buffer_type_t buft, ggml_backend_t backend) {\n+    if (!ggml_backend_is_rpc(backend)) {\n+        return false;\n+    }\n+    ggml_backend_rpc_buffer_type_context * buft_ctx = (ggml_backend_rpc_buffer_type_context *)buft->context;\n+    ggml_backend_rpc_context * rpc_ctx = (ggml_backend_rpc_context *)backend->context;\n+    return buft_ctx->sock == rpc_ctx->sock;\n+}\n+\n+static ggml_backend_buffer_type_i ggml_backend_rpc_buffer_type_interface = {\n+    /* .get_name         = */ ggml_backend_rpc_buffer_type_name,\n+    /* .alloc_buffer     = */ ggml_backend_rpc_buffer_type_alloc_buffer,\n+    /* .get_alignment    = */ ggml_backend_rpc_buffer_type_get_alignment,\n+    /* .get_max_size     = */ ggml_backend_rpc_get_max_size,\n+    /* .get_alloc_size   = */ ggml_backend_rpc_buffer_type_get_alloc_size,\n+    /* .supports_backend = */ ggml_backend_rpc_buffer_type_supports_backend,\n+    /* .is_host          = */ NULL,\n+};\n+\n+\n+GGML_CALL static const char * ggml_backend_rpc_name(ggml_backend_t backend) {\n+    ggml_backend_rpc_context * rpc_ctx = (ggml_backend_rpc_context *)backend->context;\n+\n+    return rpc_ctx->name.c_str();\n+}\n+\n+GGML_CALL static void ggml_backend_rpc_free(ggml_backend_t backend) {\n+    ggml_backend_rpc_context * rpc_ctx = (ggml_backend_rpc_context *)backend->context;\n+    ggml_backend_rpc_buffer_type_context * buft_ctx = (ggml_backend_rpc_buffer_type_context *)rpc_ctx->buft->context;\n+    delete buft_ctx;\n+    delete rpc_ctx->buft;\n+    delete rpc_ctx;\n+    delete backend;\n+}\n+\n+GGML_CALL static ggml_backend_buffer_type_t ggml_backend_rpc_get_default_buffer_type(ggml_backend_t backend) {\n+    ggml_backend_rpc_context * ctx = (ggml_backend_rpc_context *)backend->context;\n+    return ctx->buft;\n+}\n+\n+GGML_CALL static void ggml_backend_rpc_synchronize(ggml_backend_t backend) {\n+    UNUSED(backend);\n+    // this is no-op because we don't have any async operations\n+}\n+\n+static void add_tensor(ggml_tensor * tensor, std::vector<rpc_tensor> & tensors, std::unordered_set<ggml_tensor*> & visited) {\n+    if (tensor == nullptr) {\n+        return;\n+    }\n+    if (visited.find(tensor) != visited.end()) {\n+        return;\n+    }\n+    visited.insert(tensor);\n+    for (int i = 0; i < GGML_MAX_SRC; i++) {\n+        add_tensor(tensor->src[i], tensors, visited);\n+    }\n+    add_tensor(tensor->view_src, tensors, visited);\n+    tensors.push_back(serialize_tensor(tensor));\n+}\n+\n+static void serialize_graph(const ggml_cgraph * cgraph, std::vector<uint8_t> & output) {\n+    uint32_t n_nodes = cgraph->n_nodes;\n+    std::vector<rpc_tensor> tensors;\n+    std::unordered_set<ggml_tensor*> visited;\n+    for (uint32_t i = 0; i < n_nodes; i++) {\n+        add_tensor(cgraph->nodes[i], tensors, visited);\n+    }\n+    // serialization format:\n+    // | n_nodes (4 bytes) | nodes (n_nodes * sizeof(uint64_t) | n_tensors (4 bytes) | tensors (n_tensors * sizeof(rpc_tensor)) |\n+    uint32_t n_tensors = tensors.size();\n+    int output_size = sizeof(uint32_t) + n_nodes * sizeof(uint64_t) + sizeof(uint32_t) + n_tensors * sizeof(rpc_tensor);\n+    output.resize(output_size, 0);\n+    memcpy(output.data(), &n_nodes, sizeof(n_nodes));\n+    uint64_t * out_nodes = (uint64_t *)(output.data() + sizeof(n_nodes));\n+    for (uint32_t i = 0; i < n_nodes; i++) {\n+        out_nodes[i] = reinterpret_cast<uint64_t>(cgraph->nodes[i]);\n+    }\n+    uint32_t * out_ntensors = (uint32_t *)(output.data() + sizeof(n_nodes) + n_nodes * sizeof(uint64_t));\n+    *out_ntensors = n_tensors;\n+    rpc_tensor * out_tensors = (rpc_tensor *)(output.data() + sizeof(n_nodes) + n_nodes * sizeof(uint64_t) + sizeof(uint32_t));\n+    memcpy(out_tensors, tensors.data(), n_tensors * sizeof(rpc_tensor));\n+}\n+\n+GGML_CALL static enum ggml_status ggml_backend_rpc_graph_compute(ggml_backend_t backend, ggml_cgraph * cgraph) {\n+    ggml_backend_rpc_context * rpc_ctx = (ggml_backend_rpc_context *)backend->context;\n+    std::vector<uint8_t> input;\n+    serialize_graph(cgraph, input);\n+    std::vector<uint8_t> output;\n+    bool status = send_rpc_cmd(rpc_ctx->sock, GRAPH_COMPUTE, input, output);\n+    GGML_ASSERT(status);\n+    GGML_ASSERT(output.size() == 1);\n+    return (enum ggml_status)output[0];\n+}\n+\n+GGML_CALL static bool ggml_backend_rpc_supports_op(ggml_backend_t backend, const ggml_tensor * op) {\n+    UNUSED(backend);\n+    UNUSED(op);\n+    GGML_ASSERT(false && \"not implemented\");\n+    return false;\n+}\n+\n+static ggml_backend_i ggml_backend_rpc_interface = {\n+    /* .get_name                = */ ggml_backend_rpc_name,\n+    /* .free                    = */ ggml_backend_rpc_free,\n+    /* .get_default_buffer_type = */ ggml_backend_rpc_get_default_buffer_type,\n+    /* .set_tensor_async        = */ NULL,\n+    /* .get_tensor_async        = */ NULL,\n+    /* .cpy_tensor_async        = */ NULL,\n+    /* .synchronize             = */ ggml_backend_rpc_synchronize,\n+    /* .graph_plan_create       = */ NULL,\n+    /* .graph_plan_free         = */ NULL,\n+    /* .graph_plan_compute      = */ NULL,\n+    /* .graph_compute           = */ ggml_backend_rpc_graph_compute,\n+    /* .supports_op             = */ ggml_backend_rpc_supports_op,\n+    /* .offload_op              = */ NULL,\n+    /* .event_new               = */ NULL,\n+    /* .event_free              = */ NULL,\n+    /* .event_record            = */ NULL,\n+    /* .event_wait              = */ NULL,\n+    /* .event_synchronize       = */ NULL,\n+};\n+\n+static std::unordered_map<std::string, ggml_backend_t> instances;\n+\n+GGML_API GGML_CALL ggml_backend_buffer_type_t ggml_backend_rpc_buffer_type(const char * endpoint) {\n+    ggml_backend_t backend = ggml_backend_rpc_init(endpoint);\n+    return backend != nullptr ? ggml_backend_rpc_get_default_buffer_type(backend) : nullptr;\n+}\n+\n+GGML_CALL ggml_backend_t ggml_backend_rpc_init(const char * endpoint) {\n+    std::string endpoint_str(endpoint);\n+    if (instances.find(endpoint_str) != instances.end()) {\n+        return instances[endpoint_str];\n+    }\n+#ifdef _WIN32\n+    {\n+        WSADATA wsaData;\n+        int res = WSAStartup(MAKEWORD(2, 2), &wsaData);\n+        if (res != 0) {\n+            return nullptr;\n+        }\n+    }\n+#endif\n+    GGML_PRINT_DEBUG(\"Connecting to %s\\n\", endpoint);\n+    std::string host;\n+    int port;\n+    if (!parse_endpoint(endpoint, host, port)) {\n+        return nullptr;\n+    }\n+    auto sock = socket_connect(host.c_str(), port);\n+    if (sock == nullptr) {\n+        return nullptr;\n+    }\n+    size_t alignment = get_alignment(sock);\n+    size_t max_size = get_max_size(sock);\n+    ggml_backend_rpc_buffer_type_context * buft_ctx = new ggml_backend_rpc_buffer_type_context {\n+        /* .sock   = */ sock,\n+        /* .name   = */ \"RPC\" + std::to_string(sock->fd),\n+        /* .alignment = */ alignment,\n+        /* .max_size = */ max_size\n+    };\n+\n+    ggml_backend_buffer_type_t buft = new ggml_backend_buffer_type {\n+        /* .iface   = */ ggml_backend_rpc_buffer_type_interface,\n+        /* .context = */ buft_ctx\n+    };\n+\n+    ggml_backend_rpc_context * ctx = new ggml_backend_rpc_context {\n+        /* .endpoint = */ endpoint,\n+        /* .name     = */ \"RPC\" + std::to_string(sock->fd),\n+        /* .sock     = */ sock,\n+        /* .buft     = */ buft\n+    };\n+\n+    instances[endpoint] = new ggml_backend {\n+        /* .guid      = */ ggml_backend_rpc_guid(),\n+        /* .interface = */ ggml_backend_rpc_interface,\n+        /* .context   = */ ctx\n+    };\n+\n+    return instances[endpoint];\n+}\n+\n+GGML_API GGML_CALL bool ggml_backend_is_rpc(ggml_backend_t backend) {\n+    return backend != NULL && ggml_guid_matches(backend->guid, ggml_backend_rpc_guid());\n+}\n+\n+static void get_device_memory(const std::shared_ptr<socket_t> & sock, size_t * free, size_t * total) {\n+    // input serialization format: | 0 bytes |\n+    std::vector<uint8_t> input;\n+    std::vector<uint8_t> output;\n+    bool status = send_rpc_cmd(sock, GET_DEVICE_MEMORY, input, output);\n+    GGML_ASSERT(status);\n+    GGML_ASSERT(output.size() == 2*sizeof(uint64_t));\n+    // output serialization format: | free (8 bytes) | total (8 bytes) |\n+    uint64_t free_mem;\n+    memcpy(&free_mem, output.data(), sizeof(free_mem));\n+    uint64_t total_mem;\n+    memcpy(&total_mem, output.data() + sizeof(uint64_t), sizeof(total_mem));\n+    *free = free_mem;\n+    *total = total_mem;\n+}\n+\n+GGML_API GGML_CALL void ggml_backend_rpc_get_device_memory(const char * endpoint, size_t * free, size_t * total) {\n+    ggml_backend_t backend = ggml_backend_rpc_init(endpoint);\n+    if (backend == nullptr) {\n+        *free = 0;\n+        *total = 0;\n+        return;\n+    }\n+    ggml_backend_rpc_context * ctx = (ggml_backend_rpc_context *)backend->context;\n+    get_device_memory(ctx->sock, free, total);\n+}\n+\n+// RPC server-side implementation\n+\n+static void rpc_alloc_buffer(ggml_backend_t backend, const std::vector<uint8_t> & input, std::vector<uint8_t> & output) {\n+    // input serialization format: | size (8 bytes) |\n+    uint64_t size;\n+    memcpy(&size, input.data(), sizeof(size));\n+    ggml_backend_buffer_type_t buft = ggml_backend_get_default_buffer_type(backend);\n+    ggml_backend_buffer_t buffer = ggml_backend_buft_alloc_buffer(buft, size);\n+    uint64_t remote_ptr = reinterpret_cast<uint64_t>(buffer);\n+    uint64_t remote_size = buffer->size;\n+    GGML_PRINT_DEBUG(\"[%s] size: %\" PRIu64 \" -> remote_ptr: %\" PRIx64 \", remote_size: %\" PRIu64 \"\\n\", __func__, size, remote_ptr, remote_size);\n+    // output serialization format: | remote_ptr (8 bytes) | remote_size (8 bytes) |\n+    output.resize(2*sizeof(uint64_t), 0);\n+    memcpy(output.data(), &remote_ptr, sizeof(remote_ptr));\n+    memcpy(output.data() + sizeof(uint64_t), &remote_size, sizeof(remote_size));\n+}\n+\n+static void rpc_get_alignment(ggml_backend_t backend, std::vector<uint8_t> & output) {\n+    ggml_backend_buffer_type_t buft = ggml_backend_get_default_buffer_type(backend);\n+    size_t alignment = ggml_backend_buft_get_alignment(buft);\n+    GGML_PRINT_DEBUG(\"[%s] alignment: %lu\\n\", __func__, alignment);\n+    // output serialization format: | alignment (8 bytes) |\n+    output.resize(sizeof(uint64_t), 0);\n+    memcpy(output.data(), &alignment, sizeof(alignment));\n+}\n+\n+static void rpc_get_max_size(ggml_backend_t backend, std::vector<uint8_t> & output) {\n+    ggml_backend_buffer_type_t buft = ggml_backend_get_default_buffer_type(backend);\n+    size_t max_size = ggml_backend_buft_get_max_size(buft);\n+    GGML_PRINT_DEBUG(\"[%s] max_size: %lu\\n\", __func__, max_size);\n+    // output serialization format: | max_size (8 bytes) |\n+    output.resize(sizeof(uint64_t), 0);\n+    memcpy(output.data(), &max_size, sizeof(max_size));\n+}\n+\n+static void rpc_buffer_get_base(const std::vector<uint8_t> & input, std::vector<uint8_t> & output) {\n+    // input serialization format: | remote_ptr (8 bytes) |\n+    uint64_t remote_ptr;\n+    memcpy(&remote_ptr, input.data(), sizeof(remote_ptr));\n+    GGML_PRINT_DEBUG(\"[%s] remote_ptr: %\" PRIx64 \"\\n\", __func__, remote_ptr);\n+    ggml_backend_buffer_t buffer = reinterpret_cast<ggml_backend_buffer_t>(remote_ptr);\n+    void * base = ggml_backend_buffer_get_base(buffer);\n+    // output serialization format: | base_ptr (8 bytes) |\n+    uint64_t base_ptr = reinterpret_cast<uint64_t>(base);\n+    output.resize(sizeof(uint64_t), 0);\n+    memcpy(output.data(), &base_ptr, sizeof(base_ptr));\n+}\n+\n+static void rpc_free_buffer(const std::vector<uint8_t> & input) {\n+    // input serialization format: | remote_ptr (8 bytes) |\n+    uint64_t remote_ptr;\n+    memcpy(&remote_ptr, input.data(), sizeof(remote_ptr));\n+    GGML_PRINT_DEBUG(\"[%s] remote_ptr: %\" PRIx64 \"\\n\", __func__, remote_ptr);\n+    ggml_backend_buffer_t buffer = reinterpret_cast<ggml_backend_buffer_t>(remote_ptr);\n+    ggml_backend_buffer_free(buffer);\n+}\n+\n+static void rpc_buffer_clear(const std::vector<uint8_t> & input) {\n+    // input serialization format: | remote_ptr (8 bytes) | value (1 byte) |\n+    uint64_t remote_ptr;\n+    memcpy(&remote_ptr, input.data(), sizeof(remote_ptr));\n+    uint8_t value;\n+    memcpy(&value, input.data() + sizeof(uint64_t), sizeof(value));\n+    GGML_PRINT_DEBUG(\"[%s] remote_ptr: %\" PRIx64 \", value: %u\\n\", __func__, remote_ptr, value);\n+    ggml_backend_buffer_t buffer = reinterpret_cast<ggml_backend_buffer_t>(remote_ptr);\n+    ggml_backend_buffer_clear(buffer, value);\n+}\n+\n+static void rpc_set_tensor(const std::vector<uint8_t> & input) {\n+    // serialization format: | rpc_tensor | offset (8 bytes) | data (size bytes) |\n+    const rpc_tensor * in_tensor = (const rpc_tensor *)input.data();\n+    uint64_t offset;\n+    memcpy(&offset, input.data() + sizeof(rpc_tensor), sizeof(offset));\n+    size_t size = input.size() - sizeof(rpc_tensor) - sizeof(offset);\n+\n+    struct ggml_init_params params {\n+        /*.mem_size   =*/ ggml_tensor_overhead(),\n+        /*.mem_buffer =*/ NULL,\n+        /*.no_alloc   =*/ true,\n+    };\n+    struct ggml_context * ctx = ggml_init(params);\n+    ggml_tensor * tensor = deserialize_tensor(ctx, in_tensor);\n+    GGML_PRINT_DEBUG(\"[%s] buffer: %p, data: %p, offset: %\" PRIu64 \", size: %zu\\n\", __func__, (void*)tensor->buffer, tensor->data, offset, size);\n+    const void * data = input.data() + sizeof(rpc_tensor) + sizeof(offset);\n+    ggml_backend_tensor_set(tensor, data, offset, size);\n+    ggml_free(ctx);\n+}\n+\n+static void rpc_get_tensor(const std::vector<uint8_t> & input, std::vector<uint8_t> & output) {\n+    // serialization format: | rpc_tensor | offset (8 bytes) | size (8 bytes) |\n+    const rpc_tensor * in_tensor = (const rpc_tensor *)input.data();\n+    uint64_t offset;\n+    memcpy(&offset, input.data() + sizeof(rpc_tensor), sizeof(offset));\n+    uint64_t size;\n+    memcpy(&size, input.data() + sizeof(rpc_tensor) + sizeof(offset), sizeof(size));\n+\n+    struct ggml_init_params params {\n+        /*.mem_size   =*/ ggml_tensor_overhead(),\n+        /*.mem_buffer =*/ NULL,\n+        /*.no_alloc   =*/ true,\n+    };\n+    struct ggml_context * ctx = ggml_init(params);\n+    ggml_tensor * tensor = deserialize_tensor(ctx, in_tensor);\n+    GGML_PRINT_DEBUG(\"[%s] buffer: %p, data: %p, offset: %\" PRIu64 \", size: %\" PRIu64 \"\\n\", __func__, (void*)tensor->buffer, tensor->data, offset, size);\n+    // output serialization format: | data (size bytes) |\n+    output.resize(size, 0);\n+    ggml_backend_tensor_get(tensor, output.data(), offset, size);\n+    ggml_free(ctx);\n+}\n+\n+static void rpc_copy_tensor(const std::vector<uint8_t> & input, std::vector<uint8_t> & output) {\n+    // serialization format: | rpc_tensor src | rpc_tensor dst |\n+    const rpc_tensor * rpc_src = (const rpc_tensor *)input.data();\n+    const rpc_tensor * rpc_dst = (const rpc_tensor *)(input.data() + sizeof(rpc_src));\n+\n+    struct ggml_init_params params {\n+        /*.mem_size   =*/ 2*ggml_tensor_overhead(),\n+        /*.mem_buffer =*/ NULL,\n+        /*.no_alloc   =*/ true,\n+    };\n+    struct ggml_context * ctx = ggml_init(params);\n+    ggml_tensor * src = deserialize_tensor(ctx, rpc_src);\n+    ggml_tensor * dst = deserialize_tensor(ctx, rpc_dst);\n+    GGML_PRINT_DEBUG(\"[%s] src->buffer: %p, dst->buffer: %p\\n\", __func__, (void*)src->buffer, (void*)dst->buffer);\n+    bool result = ggml_backend_buffer_copy_tensor(src, dst);\n+    // output serialization format: | result (1 byte) |\n+    output.resize(1, 0);\n+    output[0] = result;\n+    ggml_free(ctx);\n+}\n+\n+static struct ggml_tensor * create_node(uint64_t id,\n+                                        struct ggml_context * ctx,\n+                                        const std::unordered_map<uint64_t, const rpc_tensor*> & tensor_ptrs,\n+                                        std::unordered_map<uint64_t, struct ggml_tensor*> & tensor_map) {\n+    if (id == 0) {\n+        return nullptr;\n+    }\n+    if (tensor_map.find(id) != tensor_map.end()) {\n+        return tensor_map[id];\n+    }\n+    const rpc_tensor * tensor = tensor_ptrs.at(id);\n+    struct ggml_tensor * result = deserialize_tensor(ctx, tensor);\n+    tensor_map[id] = result;\n+    for (int i = 0; i < GGML_MAX_SRC; i++) {\n+        result->src[i] = create_node(tensor->src[i], ctx, tensor_ptrs, tensor_map);\n+    }\n+    result->view_src = create_node(tensor->view_src, ctx, tensor_ptrs, tensor_map);\n+    result->view_offs = tensor->view_offs;\n+    return result;\n+}\n+\n+static void rpc_graph_compute(ggml_backend_t backend, const std::vector<uint8_t> & input, std::vector<uint8_t> & output) {\n+    // serialization format:\n+    // | n_nodes (4 bytes) | nodes (n_nodes * sizeof(uint64_t) | n_tensors (4 bytes) | tensors (n_tensors * sizeof(rpc_tensor)) |\n+    uint32_t n_nodes;\n+    memcpy(&n_nodes, input.data(), sizeof(n_nodes));\n+    const uint64_t * nodes = (const uint64_t *)(input.data() + sizeof(n_nodes));\n+    uint32_t n_tensors;\n+    memcpy(&n_tensors, input.data() + sizeof(n_nodes) + n_nodes*sizeof(uint64_t), sizeof(n_tensors));\n+    const rpc_tensor * tensors = (const rpc_tensor *)(input.data() + sizeof(n_nodes) + n_nodes*sizeof(uint64_t) + sizeof(n_tensors));\n+    GGML_PRINT_DEBUG(\"[%s] n_nodes: %u, n_tensors: %u\\n\", __func__, n_nodes, n_tensors);\n+\n+    static size_t buf_size = ggml_tensor_overhead()*(n_nodes + n_tensors) + ggml_graph_overhead_custom(n_nodes, false);\n+    struct ggml_init_params params = {\n+        /*.mem_size   =*/ buf_size,\n+        /*.mem_buffer =*/ NULL,\n+        /*.no_alloc   =*/ true,\n+    };\n+    struct ggml_context * ctx = ggml_init(params);\n+    struct ggml_cgraph * graph = ggml_new_graph_custom(ctx, n_nodes, false);\n+    graph->n_nodes = n_nodes;\n+    std::unordered_map<uint64_t, const rpc_tensor*> tensor_ptrs;\n+    for (uint32_t i = 0; i < n_tensors; i++) {\n+        tensor_ptrs[tensors[i].id] = &tensors[i];\n+    }\n+    std::unordered_map<uint64_t, ggml_tensor*> tensor_map;\n+    for (uint32_t i = 0; i < n_nodes; i++) {\n+        graph->nodes[i] = create_node(nodes[i], ctx, tensor_ptrs, tensor_map);\n+    }\n+    ggml_status status = ggml_backend_graph_compute(backend, graph);\n+    // output serialization format: | status (1 byte) |\n+    output.resize(1, 0);\n+    output[0] = status;\n+    ggml_free(ctx);\n+}\n+\n+static void rpc_serve_client(ggml_backend_t backend, sockfd_t sockfd, size_t free_mem, size_t total_mem) {\n+    while (true) {\n+        uint8_t cmd;\n+        if (!recv_data(sockfd, &cmd, 1)) {\n+            break;\n+        }\n+        std::vector<uint8_t> input;\n+        std::vector<uint8_t> output;\n+        uint64_t input_size;\n+        if (!recv_data(sockfd, &input_size, sizeof(input_size))) {\n+            break;\n+        }\n+        input.resize(input_size);\n+        if (!recv_data(sockfd, input.data(), input_size)) {\n+            break;\n+        }\n+        switch (cmd) {\n+            case ALLOC_BUFFER: {\n+                rpc_alloc_buffer(backend, input, output);\n+                break;\n+            }\n+            case GET_ALIGNMENT: {\n+                rpc_get_alignment(backend, output);\n+                break;\n+            }\n+            case GET_MAX_SIZE: {\n+                rpc_get_max_size(backend, output);\n+                break;\n+            }\n+            case BUFFER_GET_BASE: {\n+                rpc_buffer_get_base(input, output);\n+                break;\n+            }\n+            case FREE_BUFFER: {\n+                rpc_free_buffer(input);\n+                break;\n+            }\n+            case BUFFER_CLEAR: {\n+                rpc_buffer_clear(input);\n+                break;\n+            }\n+            case SET_TENSOR: {\n+                rpc_set_tensor(input);\n+                break;\n+            }\n+            case GET_TENSOR: {\n+                rpc_get_tensor(input, output);\n+                break;\n+            }\n+            case COPY_TENSOR: {\n+                rpc_copy_tensor(input, output);\n+                break;\n+            }\n+            case GRAPH_COMPUTE: {\n+                rpc_graph_compute(backend, input, output);\n+                break;\n+            }\n+            case GET_DEVICE_MEMORY: {\n+                // output serialization format: | free (8 bytes) | total (8 bytes) |\n+                output.resize(2*sizeof(uint64_t), 0);\n+                memcpy(output.data(), &free_mem, sizeof(free_mem));\n+                memcpy(output.data() + sizeof(uint64_t), &total_mem, sizeof(total_mem));\n+                break;\n+            }\n+            default: {\n+                fprintf(stderr, \"Unknown command: %d\\n\", cmd);\n+                return;\n+            }\n+        }\n+        uint64_t output_size = output.size();\n+        if (!send_data(sockfd, &output_size, sizeof(output_size))) {\n+            break;\n+        }\n+        if (!send_data(sockfd, output.data(), output_size)) {\n+            break;\n+        }\n+    }\n+}\n+\n+void start_rpc_server(ggml_backend_t backend, const char * endpoint, size_t free_mem, size_t total_mem) {\n+    std::string host;\n+    int port;\n+    if (!parse_endpoint(endpoint, host, port)) {\n+        return;\n+    }\n+#ifdef _WIN32\n+    {\n+        WSADATA wsaData;\n+        int res = WSAStartup(MAKEWORD(2, 2), &wsaData);\n+        if (res != 0) {\n+            fprintf(stderr, \"WSAStartup failed: %d\\n\", res);\n+            return;\n+        }\n+    }\n+#endif\n+    auto server_socket = create_server_socket(host.c_str(), port);\n+    if (server_socket == nullptr) {\n+        fprintf(stderr, \"Failed to create server socket\\n\");\n+        return;\n+    }\n+    while (true) {\n+        auto client_socket = socket_accept(server_socket->fd);\n+        if (client_socket == nullptr) {\n+            fprintf(stderr, \"Failed to accept client connection\\n\");\n+            return;\n+        }\n+        printf(\"Accepted client connection, free_mem=%zu, total_mem=%zu\\n\", free_mem, total_mem);\n+        rpc_serve_client(backend, client_socket->fd, free_mem, total_mem);\n+        printf(\"Client connection closed\\n\");",
    "line": 1018,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-05-18T02:54:38Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2064596900,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-03-03T18:02:54.069Z",
    "difficultyAssessmentMethod": "manual"
  },
  {
    "repo": "ggerganov/llama.cpp",
    "prNumber": 5927,
    "prTitle": "Add Unicode model filename support for Windows",
    "prAuthor": "BruceMacD",
    "prLink": "https://github.com/ggerganov/llama.cpp/pull/5927",
    "commentAuthor": "slaren",
    "commentBody": "I think it is important to restore the previous locale before returning. This breaks the markdown printer in `llama-bench`, which expects the locale to be set to utf-8.\r\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/ggerganov/llama.cpp/pull/5927#discussion_r1516885391",
    "filePath": "ggml.c",
    "diffHunk": "@@ -20283,7 +20284,22 @@ struct gguf_context * gguf_init_empty(void) {\n }\n \n struct gguf_context * gguf_init_from_file(const char * fname, struct gguf_init_params params) {\n-    FILE * file = fopen(fname, \"rb\");\n+#ifdef _WIN32\n+    setlocale(LC_ALL, \"\");",
    "line": 27,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-03-07T21:56:41Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1923632379,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:58.475Z"
  },
  {
    "repo": "ggerganov/llama.cpp",
    "prNumber": 5218,
    "prTitle": "APIs for rolling back sampler tokens",
    "prAuthor": "l3utterfly",
    "prLink": "https://github.com/ggerganov/llama.cpp/pull/5218",
    "commentAuthor": "dfriehs",
    "commentBody": "If you only erase tokens you indirectly reduce `params.n_prev` each time this function is called - you should at least insert as many zeros as you erase at the front of `ctx->prev`.\r\n\r\nAlso note that this is an imperfect rollback as previously \"forgotten\" tokens (exceeded `n_prev`) cannot be re-remembered.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/ggerganov/llama.cpp/pull/5218#discussion_r1471917293",
    "filePath": "common/sampling.cpp",
    "diffHunk": "@@ -323,3 +327,13 @@ void llama_sampling_accept(\n         llama_grammar_accept_token(ctx_main, ctx_sampling->grammar, id);\n     }\n }\n+\n+void llama_sampling_rollback(\n+        struct llama_sampling_context * ctx_sampling,\n+        int rollback_num) {\n+    if(rollback_num > ctx_sampling->prev.size()) {\n+        rollback_num = ctx_sampling->prev.size();\n+    }\n+\n+    ctx_sampling->prev.erase(ctx_sampling->prev.end() - rollback_num, ctx_sampling->prev.end());",
    "line": 37,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-01-30T20:34:26Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1852303361,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:58.422Z"
  },
  {
    "repo": "ggerganov/llama.cpp",
    "prNumber": 3938,
    "prTitle": "ggml-metal: round up to 16 to fix setThreadgroupMemoryLength assertion",
    "prAuthor": "psugihara",
    "prLink": "https://github.com/ggerganov/llama.cpp/pull/3938",
    "commentAuthor": "ggerganov",
    "commentBody": "This could still fail the check when `ne00 < 256 && ne00 % 4 != 0`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/ggerganov/llama.cpp/pull/3938#discussion_r1382126212",
    "filePath": "ggml-metal.m",
    "diffHunk": "@@ -1348,7 +1348,7 @@ void ggml_metal_graph_compute(\n                             [encoder setBytes:&ne00    length:sizeof( int64_t) atIndex:2];\n                             [encoder setBytes:&nb01    length:sizeof(uint64_t) atIndex:3];\n                             [encoder setBytes:&eps     length:sizeof(   float) atIndex:4];\n-                            [encoder setThreadgroupMemoryLength:nth*sizeof(float) atIndex:0];\n+                            [encoder setThreadgroupMemoryLength:MAX(16, nth*sizeof(float)) atIndex:0];",
    "line": 14,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 224463015,
        "node_id": "REA_lATOJH_K4M5SYZKEzg1hCKc",
        "user": {
          "login": "psugihara",
          "id": 282016,
          "node_id": "MDQ6VXNlcjI4MjAxNg==",
          "avatar_url": "https://avatars.githubusercontent.com/u/282016?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/psugihara",
          "html_url": "https://github.com/psugihara",
          "followers_url": "https://api.github.com/users/psugihara/followers",
          "following_url": "https://api.github.com/users/psugihara/following{/other_user}",
          "gists_url": "https://api.github.com/users/psugihara/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/psugihara/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/psugihara/subscriptions",
          "organizations_url": "https://api.github.com/users/psugihara/orgs",
          "repos_url": "https://api.github.com/users/psugihara/repos",
          "events_url": "https://api.github.com/users/psugihara/events{/privacy}",
          "received_events_url": "https://api.github.com/users/psugihara/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2023-11-03T19:38:39Z"
      }
    ],
    "timestamp": "2023-11-03T19:32:22Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1713411228,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:54:58.471Z"
  },
  {
    "repo": "ggerganov/llama.cpp",
    "prNumber": 1237,
    "prTitle": "Generalize `quantize_fns` for simpler FP16 handling",
    "prAuthor": "sw",
    "prLink": "https://github.com/ggerganov/llama.cpp/pull/1237",
    "commentAuthor": "ggerganov",
    "commentBody": "We hit this assert when both `src0` and `src1` are `F32`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/ggerganov/llama.cpp/pull/1237#discussion_r1253421160",
    "filePath": "ggml.c",
    "diffHunk": "@@ -16544,37 +16189,18 @@ void ggml_graph_compute(struct ggml_context * ctx, struct ggml_cgraph * cgraph)\n                         }\n                         else\n #endif\n-                        if (node->src0->type == GGML_TYPE_F16 && node->src1->type == GGML_TYPE_F32) {\n #if defined(GGML_USE_ACCELERATE) || defined(GGML_USE_OPENBLAS)\n-                            if (ggml_compute_forward_mul_mat_use_blas(node->src0, node->src1, node)) {\n-                                node->n_tasks = 1; // TODO: this actually is doing nothing\n-                                                   //       the threads are still spinning\n+                        if (ggml_compute_forward_mul_mat_use_blas(node->src0, node->src1, node)) {\n+                            node->n_tasks = 1; // TODO: this actually is doing nothing\n+                                               //       the threads are still spinning\n+                            if (node->src0->type != GGML_TYPE_F32) {\n                                 // here we need memory just for single 2D matrix from src0\n                                 cur = GGML_TYPE_SIZE[GGML_TYPE_F32]*(node->src0->ne[0]*node->src0->ne[1]);\n-                            } else {\n-                                cur = GGML_TYPE_SIZE[GGML_TYPE_F16]*ggml_nelements(node->src1);\n-                            }\n-#else\n-                            cur = GGML_TYPE_SIZE[GGML_TYPE_F16]*ggml_nelements(node->src1);\n-#endif\n-                        } else if (node->src0->type == GGML_TYPE_F32 && node->src1->type == GGML_TYPE_F32) {\n-                            cur = 0;\n-#if defined(GGML_USE_ACCELERATE) || defined(GGML_USE_OPENBLAS)\n-                            if (ggml_compute_forward_mul_mat_use_blas(node->src0, node->src1, node)) {\n-                                node->n_tasks = 1;\n                             }\n+                        } else\n #endif\n-                        } else if (ggml_is_quantized(node->src0->type) && node->src1->type == GGML_TYPE_F32) {\n-#if defined(GGML_USE_ACCELERATE) || defined(GGML_USE_OPENBLAS)\n-                            if (ggml_compute_forward_mul_mat_use_blas(node->src0, node->src1, node)) {\n-                                node->n_tasks = 1;\n-                                cur = GGML_TYPE_SIZE[GGML_TYPE_F32]*(node->src0->ne[0]*node->src0->ne[1]);\n-                            } else\n-#endif\n-                            {\n-                                const enum ggml_type type_q = quantize_fns[node->src0->type].vec_dot_type;\n-                                cur = GGML_TYPE_SIZE[type_q]*ggml_nelements(node->src1)/GGML_BLCK_SIZE[type_q];\n-                            }\n+                        if (node->src1->type != vec_dot_type) {\n+                            cur = GGML_TYPE_SIZE[vec_dot_type]*ggml_nelements(node->src1)/GGML_BLCK_SIZE[vec_dot_type];\n                         } else {\n                             GGML_ASSERT(false);",
    "line": 782,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-07-05T17:27:30Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1515012603,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:04.205Z"
  },
  {
    "repo": "ggerganov/llama.cpp",
    "prNumber": 563,
    "prTitle": "Fix usage of F16C intrinsics in AVX code",
    "prAuthor": "slaren",
    "prLink": "https://github.com/ggerganov/llama.cpp/pull/563",
    "commentAuthor": "polkovnikov",
    "commentBody": "@anzz1 @ggerganov  Looks like mistake here! Should be `GGML_FP32_TO_FP16()` instead of `GGML_FP16_TO_FP32()`. See that both load and store function right now use same GGML_FP16_TO_FP32(). It is a VERY BAD mistake! And this commit already merged. It affects ONLY cpus that have AVX while not having F16C, hence it is not very noticable mistake.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/ggerganov/llama.cpp/pull/563#discussion_r1152919291",
    "filePath": "ggml.c",
    "diffHunk": "@@ -1122,13 +1122,36 @@ void dequantize_row_q4_1(const void * restrict x, float * restrict y, int k) {\n #define GGML_F16_EPR  8\n \n // F16 arithmetic is not supported by AVX, so we use F32 instead\n-// we take advantage of the _mm256_cvt intrinsics to convert F16 <-> F32\n \n #define GGML_F32Cx8             __m256\n #define GGML_F32Cx8_ZERO        _mm256_setzero_ps()\n #define GGML_F32Cx8_SET1(x)     _mm256_set1_ps(x)\n+\n+#if defined(__F16C__)\n+// the  _mm256_cvt intrinsics require F16C\n #define GGML_F32Cx8_LOAD(x)     _mm256_cvtph_ps(_mm_loadu_si128((__m128i *)(x)))\n #define GGML_F32Cx8_STORE(x, y) _mm_storeu_si128((__m128i *)(x), _mm256_cvtps_ph(y, 0))\n+#else\n+static inline __m256 __avx_f32cx8_load(ggml_fp16_t *x) {\n+    float tmp[8];\n+\n+    for (int i = 0; i < 8; i++)\n+        tmp[i] = GGML_FP16_TO_FP32(x[i]);\n+\n+    return _mm256_loadu_ps(tmp);\n+}\n+static inline void __avx_f32cx8_store(ggml_fp16_t *x, __m256 y) {\n+    float arr[8];\n+\n+    _mm256_storeu_ps(arr, y);\n+\n+    for (int i = 0; i < 8; i++)\n+        x[i] = GGML_FP16_TO_FP32(arr[i]);",
    "line": 29,
    "reactionCount": 0,
    "reactions": [
      {
        "id": 200400289,
        "node_id": "REA_lATOJH_K4M5EuCb7zgvx3aE",
        "user": {
          "login": "gjmulder",
          "id": 10833500,
          "node_id": "MDQ6VXNlcjEwODMzNTAw",
          "avatar_url": "https://avatars.githubusercontent.com/u/10833500?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/gjmulder",
          "html_url": "https://github.com/gjmulder",
          "followers_url": "https://api.github.com/users/gjmulder/followers",
          "following_url": "https://api.github.com/users/gjmulder/following{/other_user}",
          "gists_url": "https://api.github.com/users/gjmulder/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/gjmulder/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/gjmulder/subscriptions",
          "organizations_url": "https://api.github.com/users/gjmulder/orgs",
          "repos_url": "https://api.github.com/users/gjmulder/repos",
          "events_url": "https://api.github.com/users/gjmulder/events{/privacy}",
          "received_events_url": "https://api.github.com/users/gjmulder/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "eyes",
        "created_at": "2023-03-30T09:01:32Z"
      }
    ],
    "timestamp": "2023-03-30T08:31:46Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1364603045,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:05.951Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 24438,
    "prTitle": "Check the return value of avifDecoderSetIOMemory.",
    "prAuthor": "vrabaud",
    "prLink": "https://github.com/opencv/opencv/pull/24438",
    "commentAuthor": "mshabunin",
    "commentBody": "Won't `decoder` instance leak if we exit earlier due to failed `avifDecoderSetIOMemory` call?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/24438#discussion_r1369707521",
    "filePath": "modules/imgcodecs/src/grfmt_avif.cpp",
    "diffHunk": "@@ -170,6 +158,20 @@ bool AvifDecoder::checkSignature(const String &signature) const {\n     }                                                     \\\n   }\n \n+bool AvifDecoder::checkSignature(const String &signature) const {\n+  avifDecoder *decoder = avifDecoderCreate();\n+  if (!decoder) return false;\n+  OPENCV_AVIF_CHECK_STATUS(\n+      avifDecoderSetIOMemory(\n+          decoder, reinterpret_cast<const uint8_t *>(signature.c_str()),\n+          signature.size()),\n+      decoder);\n+  decoder->io->sizeHint = 1e9;\n+  const avifResult status = avifDecoderParse(decoder);\n+  avifDecoderDestroy(decoder);",
    "line": 33,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-10-24T07:03:37Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1694146786,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:53:57.679Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 23757,
    "prTitle": "Fix calibrate",
    "prAuthor": "siilats",
    "prLink": "https://github.com/opencv/opencv/pull/23757",
    "commentAuthor": "asmorkalov",
    "commentBody": "sample supports both chessboards and charuco boards. The change breaks the first one.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/23757#discussion_r1222922382",
    "filePath": "samples/python/calibrate.py",
    "diffHunk": "@@ -140,7 +142,9 @@ def processImage(fn):\n \n         if debug_dir:\n             vis = cv.cvtColor(img, cv.COLOR_GRAY2BGR)\n-            cv.drawChessboardCorners(vis, pattern_size, corners, found)\n+            # cv.drawChessboardCorners(vis, pattern_size, corners, found)\n+            cv.aruco.drawDetectedCornersCharuco(vis, corners, charucoIds=_charucoIds)",
    "line": 17,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-06-08T11:41:59Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1469720976,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:05.888Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 21358,
    "prTitle": "Fix Fluid Resize Valgrind issue",
    "prAuthor": "AsyaPronina",
    "prLink": "https://github.com/opencv/opencv/pull/21358",
    "commentAuthor": "alalek",
    "commentBody": "Its only hides the problem, but this doesn't resolve that actually.\r\n\r\nOut of bound access should not be resolved through increasing of buffers size.\r\nLoop constraints should be properly checked instead.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/21358#discussion_r775965358",
    "filePath": "modules/gapi/src/backends/fluid/gfluidcore.cpp",
    "diffHunk": "@@ -2787,7 +2787,7 @@ struct LinearScratchDesc {\n                     outW * sizeof(index_t)     +\n                     outH * sizeof(alpha_t)     +\n                     outH * sizeof(index_t) * 2 +\n-                     inW * sizeof(T) * lpi * chanNum;\n+                    (inW + 1) * sizeof(T) * lpi * chanNum;",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-12-28T15:40:36Z",
    "isReviewComment": true,
    "pullRequestReviewId": 840961651,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:07.698Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 21088,
    "prTitle": "Onnx conformance tests",
    "prAuthor": "rogday",
    "prLink": "https://github.com/opencv/opencv/pull/21088",
    "commentAuthor": "alalek",
    "commentBody": "This approach terminates whole test app if data is missing.\r\n\r\n```\r\nterminate called after throwing an instance of 'cv::Exception'\r\n  what():  OpenCV(3.4.16-dev) /home/alalek/projects/opencv/dev/modules/ts/src/ts.cpp:1062: error: (-2:Unspecified error) OpenCV tests: Can't find required data file: dnn/onnx/conformance/node/test_abs/model.onnx in function 'findData'\r\n```\r\n\r\nAs result zero tests are launched including tests without external test data.\r\n\r\n---\r\n\r\nI will fix that with filter updates.",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/opencv/opencv/pull/21088#discussion_r769377714",
    "filePath": "modules/dnn/test/test_onnx_conformance.cpp",
    "diffHunk": "@@ -0,0 +1,1250 @@\n+// This file is part of OpenCV project.\n+// It is subject to the license terms in the LICENSE file found in the top-level directory\n+// of this distribution and at http://opencv.org/license.html.\n+\n+\n+#include \"test_precomp.hpp\"\n+#include <set>\n+#include <string>\n+#include \"npy_blob.hpp\"\n+#include <opencv2/dnn/shape_utils.hpp>\n+\n+#if defined(_MSC_VER)  // workaround for 32-bit MSVC compiler\n+#pragma optimize(\"\", off)\n+#endif\n+\n+\n+#define CV_TEST_TAG_DNN_ERROR_PARSER \"dnn_error_parser\"\n+#define CV_TEST_TAG_DNN_ERROR_NET_SETUP \"dnn_error_net_setup\"\n+#define CV_TEST_TAG_DNN_ERROR_FORWARD \"dnn_error_forward\"\n+#define CV_TEST_TAG_DNN_LAYER_FALLBACK \"dnn_layer_fallback\"\n+#define CV_TEST_TAG_DNN_NO_ACCURACY_CHECK \"dnn_no_accuracy_check\"\n+\n+\n+namespace opencv_test {\n+\n+struct TestCase\n+{\n+    const char* name;\n+    uint32_t inputs;\n+    uint32_t outputs;\n+};\n+\n+static const TestCase testConformanceConfig[] = {\n+    {\"test_abs\", 1, 1},\n+    {\"test_acos\", 1, 1},\n+    {\"test_acos_example\", 1, 1},\n+    {\"test_acosh\", 1, 1},\n+    {\"test_acosh_example\", 1, 1},\n+    {\"test_adagrad\", 5, 2},\n+    {\"test_adagrad_multiple\", 8, 4},\n+    {\"test_adam\", 6, 3},\n+    {\"test_adam_multiple\", 10, 6},\n+    {\"test_add\", 2, 1},\n+    {\"test_add_bcast\", 2, 1},\n+    {\"test_add_uint8\", 2, 1},\n+    {\"test_and2d\", 2, 1},\n+    {\"test_and3d\", 2, 1},\n+    {\"test_and4d\", 2, 1},\n+    {\"test_and_bcast3v1d\", 2, 1},\n+    {\"test_and_bcast3v2d\", 2, 1},\n+    {\"test_and_bcast4v2d\", 2, 1},\n+    {\"test_and_bcast4v3d\", 2, 1},\n+    {\"test_and_bcast4v4d\", 2, 1},\n+    {\"test_argmax_default_axis_example\", 1, 1},\n+    {\"test_argmax_default_axis_example_select_last_index\", 1, 1},\n+    {\"test_argmax_default_axis_random\", 1, 1},\n+    {\"test_argmax_default_axis_random_select_last_index\", 1, 1},\n+    {\"test_argmax_keepdims_example\", 1, 1},\n+    {\"test_argmax_keepdims_example_select_last_index\", 1, 1},\n+    {\"test_argmax_keepdims_random\", 1, 1},\n+    {\"test_argmax_keepdims_random_select_last_index\", 1, 1},\n+    {\"test_argmax_negative_axis_keepdims_example\", 1, 1},\n+    {\"test_argmax_negative_axis_keepdims_example_select_last_index\", 1, 1},\n+    {\"test_argmax_negative_axis_keepdims_random\", 1, 1},\n+    {\"test_argmax_negative_axis_keepdims_random_select_last_index\", 1, 1},\n+    {\"test_argmax_no_keepdims_example\", 1, 1},\n+    {\"test_argmax_no_keepdims_example_select_last_index\", 1, 1},\n+    {\"test_argmax_no_keepdims_random\", 1, 1},\n+    {\"test_argmax_no_keepdims_random_select_last_index\", 1, 1},\n+    {\"test_argmin_default_axis_example\", 1, 1},\n+    {\"test_argmin_default_axis_example_select_last_index\", 1, 1},\n+    {\"test_argmin_default_axis_random\", 1, 1},\n+    {\"test_argmin_default_axis_random_select_last_index\", 1, 1},\n+    {\"test_argmin_keepdims_example\", 1, 1},\n+    {\"test_argmin_keepdims_example_select_last_index\", 1, 1},\n+    {\"test_argmin_keepdims_random\", 1, 1},\n+    {\"test_argmin_keepdims_random_select_last_index\", 1, 1},\n+    {\"test_argmin_negative_axis_keepdims_example\", 1, 1},\n+    {\"test_argmin_negative_axis_keepdims_example_select_last_index\", 1, 1},\n+    {\"test_argmin_negative_axis_keepdims_random\", 1, 1},\n+    {\"test_argmin_negative_axis_keepdims_random_select_last_index\", 1, 1},\n+    {\"test_argmin_no_keepdims_example\", 1, 1},\n+    {\"test_argmin_no_keepdims_example_select_last_index\", 1, 1},\n+    {\"test_argmin_no_keepdims_random\", 1, 1},\n+    {\"test_argmin_no_keepdims_random_select_last_index\", 1, 1},\n+    {\"test_asin\", 1, 1},\n+    {\"test_asin_example\", 1, 1},\n+    {\"test_asinh\", 1, 1},\n+    {\"test_asinh_example\", 1, 1},\n+    {\"test_atan\", 1, 1},\n+    {\"test_atan_example\", 1, 1},\n+    {\"test_atanh\", 1, 1},\n+    {\"test_atanh_example\", 1, 1},\n+    {\"test_averagepool_1d_default\", 1, 1},\n+    {\"test_averagepool_2d_ceil\", 1, 1},\n+    {\"test_averagepool_2d_default\", 1, 1},\n+    {\"test_averagepool_2d_pads\", 1, 1},\n+    {\"test_averagepool_2d_pads_count_include_pad\", 1, 1},\n+    {\"test_averagepool_2d_precomputed_pads\", 1, 1},\n+    {\"test_averagepool_2d_precomputed_pads_count_include_pad\", 1, 1},\n+    {\"test_averagepool_2d_precomputed_same_upper\", 1, 1},\n+    {\"test_averagepool_2d_precomputed_strides\", 1, 1},\n+    {\"test_averagepool_2d_same_lower\", 1, 1},\n+    {\"test_averagepool_2d_same_upper\", 1, 1},\n+    {\"test_averagepool_2d_strides\", 1, 1},\n+    {\"test_averagepool_3d_default\", 1, 1},\n+    {\"test_basic_conv_with_padding\", 2, 1},\n+    {\"test_basic_conv_without_padding\", 2, 1},\n+    {\"test_basic_convinteger\", 3, 1},\n+    {\"test_batchnorm_epsilon\", 5, 1},\n+    {\"test_batchnorm_epsilon_training_mode\", 5, 3},\n+    {\"test_batchnorm_example\", 5, 1},\n+    {\"test_batchnorm_example_training_mode\", 5, 3},\n+    {\"test_bernoulli\", 1, 1},\n+    {\"test_bernoulli_double\", 1, 1},\n+    {\"test_bernoulli_double_expanded\", 1, 1},\n+    {\"test_bernoulli_expanded\", 1, 1},\n+    {\"test_bernoulli_seed\", 1, 1},\n+    {\"test_bernoulli_seed_expanded\", 1, 1},\n+    {\"test_bitshift_left_uint16\", 2, 1},\n+    {\"test_bitshift_left_uint32\", 2, 1},\n+    {\"test_bitshift_left_uint64\", 2, 1},\n+    {\"test_bitshift_left_uint8\", 2, 1},\n+    {\"test_bitshift_right_uint16\", 2, 1},\n+    {\"test_bitshift_right_uint32\", 2, 1},\n+    {\"test_bitshift_right_uint64\", 2, 1},\n+    {\"test_bitshift_right_uint8\", 2, 1},\n+    {\"test_cast_BFLOAT16_to_FLOAT\", 1, 1},\n+    {\"test_cast_DOUBLE_to_FLOAT\", 1, 1},\n+    {\"test_cast_DOUBLE_to_FLOAT16\", 1, 1},\n+    {\"test_cast_FLOAT16_to_DOUBLE\", 1, 1},\n+    {\"test_cast_FLOAT16_to_FLOAT\", 1, 1},\n+    {\"test_cast_FLOAT_to_BFLOAT16\", 1, 1},\n+    {\"test_cast_FLOAT_to_DOUBLE\", 1, 1},\n+    {\"test_cast_FLOAT_to_FLOAT16\", 1, 1},\n+    {\"test_cast_FLOAT_to_STRING\", 1, 1},\n+    {\"test_cast_STRING_to_FLOAT\", 1, 1},\n+    {\"test_castlike_BFLOAT16_to_FLOAT\", 2, 1},\n+    {\"test_castlike_BFLOAT16_to_FLOAT_expanded\", 2, 1},\n+    {\"test_castlike_DOUBLE_to_FLOAT\", 2, 1},\n+    {\"test_castlike_DOUBLE_to_FLOAT16\", 2, 1},\n+    {\"test_castlike_DOUBLE_to_FLOAT16_expanded\", 2, 1},\n+    {\"test_castlike_DOUBLE_to_FLOAT_expanded\", 2, 1},\n+    {\"test_castlike_FLOAT16_to_DOUBLE\", 2, 1},\n+    {\"test_castlike_FLOAT16_to_DOUBLE_expanded\", 2, 1},\n+    {\"test_castlike_FLOAT16_to_FLOAT\", 2, 1},\n+    {\"test_castlike_FLOAT16_to_FLOAT_expanded\", 2, 1},\n+    {\"test_castlike_FLOAT_to_BFLOAT16\", 2, 1},\n+    {\"test_castlike_FLOAT_to_BFLOAT16_expanded\", 2, 1},\n+    {\"test_castlike_FLOAT_to_DOUBLE\", 2, 1},\n+    {\"test_castlike_FLOAT_to_DOUBLE_expanded\", 2, 1},\n+    {\"test_castlike_FLOAT_to_FLOAT16\", 2, 1},\n+    {\"test_castlike_FLOAT_to_FLOAT16_expanded\", 2, 1},\n+    {\"test_castlike_FLOAT_to_STRING\", 2, 1},\n+    {\"test_castlike_FLOAT_to_STRING_expanded\", 2, 1},\n+    {\"test_castlike_STRING_to_FLOAT\", 2, 1},\n+    {\"test_castlike_STRING_to_FLOAT_expanded\", 2, 1},\n+    {\"test_ceil\", 1, 1},\n+    {\"test_ceil_example\", 1, 1},\n+    {\"test_celu\", 1, 1},\n+    {\"test_celu_expanded\", 1, 1},\n+    {\"test_clip\", 3, 1},\n+    {\"test_clip_default_inbounds\", 1, 1},\n+    {\"test_clip_default_int8_inbounds\", 1, 1},\n+    {\"test_clip_default_int8_max\", 2, 1},\n+    {\"test_clip_default_int8_min\", 2, 1},\n+    {\"test_clip_default_max\", 2, 1},\n+    {\"test_clip_default_min\", 2, 1},\n+    {\"test_clip_example\", 3, 1},\n+    {\"test_clip_inbounds\", 3, 1},\n+    {\"test_clip_outbounds\", 3, 1},\n+    {\"test_clip_splitbounds\", 3, 1},\n+    {\"test_compress_0\", 2, 1},\n+    {\"test_compress_1\", 2, 1},\n+    {\"test_compress_default_axis\", 2, 1},\n+    {\"test_compress_negative_axis\", 2, 1},\n+    {\"test_concat_1d_axis_0\", 2, 1},\n+    {\"test_concat_1d_axis_negative_1\", 2, 1},\n+    {\"test_concat_2d_axis_0\", 2, 1},\n+    {\"test_concat_2d_axis_1\", 2, 1},\n+    {\"test_concat_2d_axis_negative_1\", 2, 1},\n+    {\"test_concat_2d_axis_negative_2\", 2, 1},\n+    {\"test_concat_3d_axis_0\", 2, 1},\n+    {\"test_concat_3d_axis_1\", 2, 1},\n+    {\"test_concat_3d_axis_2\", 2, 1},\n+    {\"test_concat_3d_axis_negative_1\", 2, 1},\n+    {\"test_concat_3d_axis_negative_2\", 2, 1},\n+    {\"test_concat_3d_axis_negative_3\", 2, 1},\n+    {\"test_constant\", 0, 1},\n+    {\"test_constant_pad\", 3, 1},\n+    {\"test_constantofshape_float_ones\", 1, 1},\n+    {\"test_constantofshape_int_shape_zero\", 1, 1},\n+    {\"test_constantofshape_int_zeros\", 1, 1},\n+    {\"test_conv_with_autopad_same\", 2, 1},\n+    {\"test_conv_with_strides_and_asymmetric_padding\", 2, 1},\n+    {\"test_conv_with_strides_no_padding\", 2, 1},\n+    {\"test_conv_with_strides_padding\", 2, 1},\n+    {\"test_convinteger_with_padding\", 3, 1},\n+    {\"test_convinteger_without_padding\", 3, 1},\n+    {\"test_convtranspose\", 2, 1},\n+    {\"test_convtranspose_1d\", 2, 1},\n+    {\"test_convtranspose_3d\", 2, 1},\n+    {\"test_convtranspose_autopad_same\", 2, 1},\n+    {\"test_convtranspose_dilations\", 2, 1},\n+    {\"test_convtranspose_kernel_shape\", 2, 1},\n+    {\"test_convtranspose_output_shape\", 2, 1},\n+    {\"test_convtranspose_pad\", 2, 1},\n+    {\"test_convtranspose_pads\", 2, 1},\n+    {\"test_convtranspose_with_kernel\", 2, 1},\n+    {\"test_cos\", 1, 1},\n+    {\"test_cos_example\", 1, 1},\n+    {\"test_cosh\", 1, 1},\n+    {\"test_cosh_example\", 1, 1},\n+    {\"test_cumsum_1d\", 2, 1},\n+    {\"test_cumsum_1d_exclusive\", 2, 1},\n+    {\"test_cumsum_1d_reverse\", 2, 1},\n+    {\"test_cumsum_1d_reverse_exclusive\", 2, 1},\n+    {\"test_cumsum_2d_axis_0\", 2, 1},\n+    {\"test_cumsum_2d_axis_1\", 2, 1},\n+    {\"test_cumsum_2d_negative_axis\", 2, 1},\n+    {\"test_depthtospace_crd_mode\", 1, 1},\n+    {\"test_depthtospace_crd_mode_example\", 1, 1},\n+    {\"test_depthtospace_dcr_mode\", 1, 1},\n+    {\"test_depthtospace_example\", 1, 1},\n+    {\"test_dequantizelinear\", 3, 1},\n+    {\"test_dequantizelinear_axis\", 3, 1},\n+    {\"test_det_2d\", 1, 1},\n+    {\"test_det_nd\", 1, 1},\n+    {\"test_div\", 2, 1},\n+    {\"test_div_bcast\", 2, 1},\n+    {\"test_div_example\", 2, 1},\n+    {\"test_div_uint8\", 2, 1},\n+    {\"test_dropout_default\", 1, 1},\n+    {\"test_dropout_default_mask\", 1, 2},\n+    {\"test_dropout_default_mask_ratio\", 2, 2},\n+    {\"test_dropout_default_old\", 1, 1},\n+    {\"test_dropout_default_ratio\", 2, 1},\n+    {\"test_dropout_random_old\", 1, 1},\n+    {\"test_dynamicquantizelinear\", 1, 3},\n+    {\"test_dynamicquantizelinear_expanded\", 1, 3},\n+    {\"test_dynamicquantizelinear_max_adjusted\", 1, 3},\n+    {\"test_dynamicquantizelinear_max_adjusted_expanded\", 1, 3},\n+    {\"test_dynamicquantizelinear_min_adjusted\", 1, 3},\n+    {\"test_dynamicquantizelinear_min_adjusted_expanded\", 1, 3},\n+    {\"test_edge_pad\", 2, 1},\n+    {\"test_einsum_batch_diagonal\", 1, 1},\n+    {\"test_einsum_batch_matmul\", 2, 1},\n+    {\"test_einsum_inner_prod\", 2, 1},\n+    {\"test_einsum_sum\", 1, 1},\n+    {\"test_einsum_transpose\", 1, 1},\n+    {\"test_elu\", 1, 1},\n+    {\"test_elu_default\", 1, 1},\n+    {\"test_elu_example\", 1, 1},\n+    {\"test_equal\", 2, 1},\n+    {\"test_equal_bcast\", 2, 1},\n+    {\"test_erf\", 1, 1},\n+    {\"test_exp\", 1, 1},\n+    {\"test_exp_example\", 1, 1},\n+    {\"test_expand_dim_changed\", 2, 1},\n+    {\"test_expand_dim_unchanged\", 2, 1},\n+    {\"test_eyelike_populate_off_main_diagonal\", 1, 1},\n+    {\"test_eyelike_with_dtype\", 1, 1},\n+    {\"test_eyelike_without_dtype\", 1, 1},\n+    {\"test_flatten_axis0\", 1, 1},\n+    {\"test_flatten_axis1\", 1, 1},\n+    {\"test_flatten_axis2\", 1, 1},\n+    {\"test_flatten_axis3\", 1, 1},\n+    {\"test_flatten_default_axis\", 1, 1},\n+    {\"test_flatten_negative_axis1\", 1, 1},\n+    {\"test_flatten_negative_axis2\", 1, 1},\n+    {\"test_flatten_negative_axis3\", 1, 1},\n+    {\"test_flatten_negative_axis4\", 1, 1},\n+    {\"test_floor\", 1, 1},\n+    {\"test_floor_example\", 1, 1},\n+    {\"test_gather_0\", 2, 1},\n+    {\"test_gather_1\", 2, 1},\n+    {\"test_gather_2d_indices\", 2, 1},\n+    {\"test_gather_elements_0\", 2, 1},\n+    {\"test_gather_elements_1\", 2, 1},\n+    {\"test_gather_elements_negative_indices\", 2, 1},\n+    {\"test_gather_negative_indices\", 2, 1},\n+    {\"test_gathernd_example_float32\", 2, 1},\n+    {\"test_gathernd_example_int32\", 2, 1},\n+    {\"test_gathernd_example_int32_batch_dim1\", 2, 1},\n+    {\"test_gemm_all_attributes\", 3, 1},\n+    {\"test_gemm_alpha\", 3, 1},\n+    {\"test_gemm_beta\", 3, 1},\n+    {\"test_gemm_default_matrix_bias\", 3, 1},\n+    {\"test_gemm_default_no_bias\", 2, 1},\n+    {\"test_gemm_default_scalar_bias\", 3, 1},\n+    {\"test_gemm_default_single_elem_vector_bias\", 3, 1},\n+    {\"test_gemm_default_vector_bias\", 3, 1},\n+    {\"test_gemm_default_zero_bias\", 3, 1},\n+    {\"test_gemm_transposeA\", 3, 1},\n+    {\"test_gemm_transposeB\", 3, 1},\n+    {\"test_globalaveragepool\", 1, 1},\n+    {\"test_globalaveragepool_precomputed\", 1, 1},\n+    {\"test_globalmaxpool\", 1, 1},\n+    {\"test_globalmaxpool_precomputed\", 1, 1},\n+    {\"test_greater\", 2, 1},\n+    {\"test_greater_bcast\", 2, 1},\n+    {\"test_greater_equal\", 2, 1},\n+    {\"test_greater_equal_bcast\", 2, 1},\n+    {\"test_greater_equal_bcast_expanded\", 2, 1},\n+    {\"test_greater_equal_expanded\", 2, 1},\n+    {\"test_gridsample\", 2, 1},\n+    {\"test_gridsample_aligncorners_true\", 2, 1},\n+    {\"test_gridsample_bicubic\", 2, 1},\n+    {\"test_gridsample_bilinear\", 2, 1},\n+    {\"test_gridsample_border_padding\", 2, 1},\n+    {\"test_gridsample_nearest\", 2, 1},\n+    {\"test_gridsample_reflection_padding\", 2, 1},\n+    {\"test_gridsample_zeros_padding\", 2, 1},\n+    {\"test_gru_batchwise\", 3, 2},\n+    {\"test_gru_defaults\", 3, 1},\n+    {\"test_gru_seq_length\", 4, 1},\n+    {\"test_gru_with_initial_bias\", 4, 1},\n+    {\"test_hardmax_axis_0\", 1, 1},\n+    {\"test_hardmax_axis_1\", 1, 1},\n+    {\"test_hardmax_axis_2\", 1, 1},\n+    {\"test_hardmax_default_axis\", 1, 1},\n+    {\"test_hardmax_example\", 1, 1},\n+    {\"test_hardmax_negative_axis\", 1, 1},\n+    {\"test_hardmax_one_hot\", 1, 1},\n+    {\"test_hardsigmoid\", 1, 1},\n+    {\"test_hardsigmoid_default\", 1, 1},\n+    {\"test_hardsigmoid_example\", 1, 1},\n+    {\"test_hardswish\", 1, 1},\n+    {\"test_hardswish_expanded\", 1, 1},\n+    {\"test_identity\", 1, 1},\n+    {\"test_identity_opt\", 1, 1},\n+    {\"test_identity_sequence\", 1, 1},\n+    {\"test_if\", 1, 1},\n+    {\"test_if_opt\", 1, 1},\n+    {\"test_if_seq\", 1, 1},\n+    {\"test_instancenorm_epsilon\", 3, 1},\n+    {\"test_instancenorm_example\", 3, 1},\n+    {\"test_isinf\", 1, 1},\n+    {\"test_isinf_negative\", 1, 1},\n+    {\"test_isinf_positive\", 1, 1},\n+    {\"test_isnan\", 1, 1},\n+    {\"test_leakyrelu\", 1, 1},\n+    {\"test_leakyrelu_default\", 1, 1},\n+    {\"test_leakyrelu_example\", 1, 1},\n+    {\"test_less\", 2, 1},\n+    {\"test_less_bcast\", 2, 1},\n+    {\"test_less_equal\", 2, 1},\n+    {\"test_less_equal_bcast\", 2, 1},\n+    {\"test_less_equal_bcast_expanded\", 2, 1},\n+    {\"test_less_equal_expanded\", 2, 1},\n+    {\"test_log\", 1, 1},\n+    {\"test_log_example\", 1, 1},\n+    {\"test_logsoftmax_axis_0\", 1, 1},\n+    {\"test_logsoftmax_axis_0_expanded\", 1, 1},\n+    {\"test_logsoftmax_axis_1\", 1, 1},\n+    {\"test_logsoftmax_axis_1_expanded\", 1, 1},\n+    {\"test_logsoftmax_axis_2\", 1, 1},\n+    {\"test_logsoftmax_axis_2_expanded\", 1, 1},\n+    {\"test_logsoftmax_default_axis\", 1, 1},\n+    {\"test_logsoftmax_default_axis_expanded\", 1, 1},\n+    {\"test_logsoftmax_example_1\", 1, 1},\n+    {\"test_logsoftmax_example_1_expanded\", 1, 1},\n+    {\"test_logsoftmax_large_number\", 1, 1},\n+    {\"test_logsoftmax_large_number_expanded\", 1, 1},\n+    {\"test_logsoftmax_negative_axis\", 1, 1},\n+    {\"test_logsoftmax_negative_axis_expanded\", 1, 1},\n+    {\"test_loop11\", 3, 2},\n+    {\"test_loop13_seq\", 3, 1},\n+    {\"test_loop16_seq_none\", 3, 1},\n+    {\"test_lrn\", 1, 1},\n+    {\"test_lrn_default\", 1, 1},\n+    {\"test_lstm_batchwise\", 3, 2},\n+    {\"test_lstm_defaults\", 3, 1},\n+    {\"test_lstm_with_initial_bias\", 4, 1},\n+    {\"test_lstm_with_peepholes\", 8, 1},\n+    {\"test_matmul_2d\", 2, 1},\n+    {\"test_matmul_3d\", 2, 1},\n+    {\"test_matmul_4d\", 2, 1},\n+    {\"test_matmulinteger\", 4, 1},\n+    {\"test_max_example\", 3, 1},\n+    {\"test_max_float16\", 2, 1},\n+    {\"test_max_float32\", 2, 1},\n+    {\"test_max_float64\", 2, 1},\n+    {\"test_max_int16\", 2, 1},\n+    {\"test_max_int32\", 2, 1},\n+    {\"test_max_int64\", 2, 1},\n+    {\"test_max_int8\", 2, 1},\n+    {\"test_max_one_input\", 1, 1},\n+    {\"test_max_two_inputs\", 2, 1},\n+    {\"test_max_uint16\", 2, 1},\n+    {\"test_max_uint32\", 2, 1},\n+    {\"test_max_uint64\", 2, 1},\n+    {\"test_max_uint8\", 2, 1},\n+    {\"test_maxpool_1d_default\", 1, 1},\n+    {\"test_maxpool_2d_ceil\", 1, 1},\n+    {\"test_maxpool_2d_default\", 1, 1},\n+    {\"test_maxpool_2d_dilations\", 1, 1},\n+    {\"test_maxpool_2d_pads\", 1, 1},\n+    {\"test_maxpool_2d_precomputed_pads\", 1, 1},\n+    {\"test_maxpool_2d_precomputed_same_upper\", 1, 1},\n+    {\"test_maxpool_2d_precomputed_strides\", 1, 1},\n+    {\"test_maxpool_2d_same_lower\", 1, 1},\n+    {\"test_maxpool_2d_same_upper\", 1, 1},\n+    {\"test_maxpool_2d_strides\", 1, 1},\n+    {\"test_maxpool_2d_uint8\", 1, 1},\n+    {\"test_maxpool_3d_default\", 1, 1},\n+    {\"test_maxpool_with_argmax_2d_precomputed_pads\", 1, 2},\n+    {\"test_maxpool_with_argmax_2d_precomputed_strides\", 1, 2},\n+    {\"test_maxunpool_export_with_output_shape\", 3, 1},\n+    {\"test_maxunpool_export_without_output_shape\", 2, 1},\n+    {\"test_mean_example\", 3, 1},\n+    {\"test_mean_one_input\", 1, 1},\n+    {\"test_mean_two_inputs\", 2, 1},\n+    {\"test_min_example\", 3, 1},\n+    {\"test_min_float16\", 2, 1},\n+    {\"test_min_float32\", 2, 1},\n+    {\"test_min_float64\", 2, 1},\n+    {\"test_min_int16\", 2, 1},\n+    {\"test_min_int32\", 2, 1},\n+    {\"test_min_int64\", 2, 1},\n+    {\"test_min_int8\", 2, 1},\n+    {\"test_min_one_input\", 1, 1},\n+    {\"test_min_two_inputs\", 2, 1},\n+    {\"test_min_uint16\", 2, 1},\n+    {\"test_min_uint32\", 2, 1},\n+    {\"test_min_uint64\", 2, 1},\n+    {\"test_min_uint8\", 2, 1},\n+    {\"test_mod_broadcast\", 2, 1},\n+    {\"test_mod_int64_fmod\", 2, 1},\n+    {\"test_mod_mixed_sign_float16\", 2, 1},\n+    {\"test_mod_mixed_sign_float32\", 2, 1},\n+    {\"test_mod_mixed_sign_float64\", 2, 1},\n+    {\"test_mod_mixed_sign_int16\", 2, 1},\n+    {\"test_mod_mixed_sign_int32\", 2, 1},\n+    {\"test_mod_mixed_sign_int64\", 2, 1},\n+    {\"test_mod_mixed_sign_int8\", 2, 1},\n+    {\"test_mod_uint16\", 2, 1},\n+    {\"test_mod_uint32\", 2, 1},\n+    {\"test_mod_uint64\", 2, 1},\n+    {\"test_mod_uint8\", 2, 1},\n+    {\"test_momentum\", 5, 2},\n+    {\"test_momentum_multiple\", 8, 4},\n+    {\"test_mul\", 2, 1},\n+    {\"test_mul_bcast\", 2, 1},\n+    {\"test_mul_example\", 2, 1},\n+    {\"test_mul_uint8\", 2, 1},\n+    {\"test_mvn\", 1, 1},\n+    {\"test_mvn_expanded\", 1, 1},\n+    {\"test_neg\", 1, 1},\n+    {\"test_neg_example\", 1, 1},\n+    {\"test_nesterov_momentum\", 5, 2},\n+    {\"test_nllloss_NC\", 2, 1},\n+    {\"test_nllloss_NC_expanded\", 2, 1},\n+    {\"test_nllloss_NCd1\", 2, 1},\n+    {\"test_nllloss_NCd1_expanded\", 2, 1},\n+    {\"test_nllloss_NCd1_ii\", 2, 1},\n+    {\"test_nllloss_NCd1_ii_expanded\", 2, 1},\n+    {\"test_nllloss_NCd1_mean_weight_negative_ii\", 3, 1},\n+    {\"test_nllloss_NCd1_mean_weight_negative_ii_expanded\", 3, 1},\n+    {\"test_nllloss_NCd1_weight\", 3, 1},\n+    {\"test_nllloss_NCd1_weight_expanded\", 3, 1},\n+    {\"test_nllloss_NCd1_weight_ii\", 3, 1},\n+    {\"test_nllloss_NCd1_weight_ii_expanded\", 3, 1},\n+    {\"test_nllloss_NCd1d2\", 2, 1},\n+    {\"test_nllloss_NCd1d2_expanded\", 2, 1},\n+    {\"test_nllloss_NCd1d2_no_weight_reduction_mean_ii\", 2, 1},\n+    {\"test_nllloss_NCd1d2_no_weight_reduction_mean_ii_expanded\", 2, 1},\n+    {\"test_nllloss_NCd1d2_reduction_mean\", 2, 1},\n+    {\"test_nllloss_NCd1d2_reduction_mean_expanded\", 2, 1},\n+    {\"test_nllloss_NCd1d2_reduction_sum\", 2, 1},\n+    {\"test_nllloss_NCd1d2_reduction_sum_expanded\", 2, 1},\n+    {\"test_nllloss_NCd1d2_with_weight\", 3, 1},\n+    {\"test_nllloss_NCd1d2_with_weight_expanded\", 3, 1},\n+    {\"test_nllloss_NCd1d2_with_weight_reduction_mean\", 3, 1},\n+    {\"test_nllloss_NCd1d2_with_weight_reduction_mean_expanded\", 3, 1},\n+    {\"test_nllloss_NCd1d2_with_weight_reduction_sum\", 3, 1},\n+    {\"test_nllloss_NCd1d2_with_weight_reduction_sum_expanded\", 3, 1},\n+    {\"test_nllloss_NCd1d2_with_weight_reduction_sum_ii\", 3, 1},\n+    {\"test_nllloss_NCd1d2_with_weight_reduction_sum_ii_expanded\", 3, 1},\n+    {\"test_nllloss_NCd1d2d3_none_no_weight_negative_ii\", 2, 1},\n+    {\"test_nllloss_NCd1d2d3_none_no_weight_negative_ii_expanded\", 2, 1},\n+    {\"test_nllloss_NCd1d2d3_sum_weight_high_ii\", 3, 1},\n+    {\"test_nllloss_NCd1d2d3_sum_weight_high_ii_expanded\", 3, 1},\n+    {\"test_nllloss_NCd1d2d3d4d5_mean_weight\", 3, 1},\n+    {\"test_nllloss_NCd1d2d3d4d5_mean_weight_expanded\", 3, 1},\n+    {\"test_nllloss_NCd1d2d3d4d5_none_no_weight\", 2, 1},\n+    {\"test_nllloss_NCd1d2d3d4d5_none_no_weight_expanded\", 2, 1},\n+    {\"test_nonmaxsuppression_center_point_box_format\", 5, 1},\n+    {\"test_nonmaxsuppression_flipped_coordinates\", 5, 1},\n+    {\"test_nonmaxsuppression_identical_boxes\", 5, 1},\n+    {\"test_nonmaxsuppression_limit_output_size\", 5, 1},\n+    {\"test_nonmaxsuppression_single_box\", 5, 1},\n+    {\"test_nonmaxsuppression_suppress_by_IOU\", 5, 1},\n+    {\"test_nonmaxsuppression_suppress_by_IOU_and_scores\", 5, 1},\n+    {\"test_nonmaxsuppression_two_batches\", 5, 1},\n+    {\"test_nonmaxsuppression_two_classes\", 5, 1},\n+    {\"test_nonzero_example\", 1, 1},\n+    {\"test_not_2d\", 1, 1},\n+    {\"test_not_3d\", 1, 1},\n+    {\"test_not_4d\", 1, 1},\n+    {\"test_onehot_negative_indices\", 3, 1},\n+    {\"test_onehot_with_axis\", 3, 1},\n+    {\"test_onehot_with_negative_axis\", 3, 1},\n+    {\"test_onehot_without_axis\", 3, 1},\n+    {\"test_optional_get_element\", 1, 1},\n+    {\"test_optional_get_element_sequence\", 1, 1},\n+    {\"test_optional_has_element\", 1, 1},\n+    {\"test_optional_has_element_empty\", 1, 1},\n+    {\"test_or2d\", 2, 1},\n+    {\"test_or3d\", 2, 1},\n+    {\"test_or4d\", 2, 1},\n+    {\"test_or_bcast3v1d\", 2, 1},\n+    {\"test_or_bcast3v2d\", 2, 1},\n+    {\"test_or_bcast4v2d\", 2, 1},\n+    {\"test_or_bcast4v3d\", 2, 1},\n+    {\"test_or_bcast4v4d\", 2, 1},\n+    {\"test_pow\", 2, 1},\n+    {\"test_pow_bcast_array\", 2, 1},\n+    {\"test_pow_bcast_scalar\", 2, 1},\n+    {\"test_pow_example\", 2, 1},\n+    {\"test_pow_types_float\", 2, 1},\n+    {\"test_pow_types_float32_int32\", 2, 1},\n+    {\"test_pow_types_float32_int64\", 2, 1},\n+    {\"test_pow_types_float32_uint32\", 2, 1},\n+    {\"test_pow_types_float32_uint64\", 2, 1},\n+    {\"test_pow_types_int\", 2, 1},\n+    {\"test_pow_types_int32_float32\", 2, 1},\n+    {\"test_pow_types_int32_int32\", 2, 1},\n+    {\"test_pow_types_int64_float32\", 2, 1},\n+    {\"test_pow_types_int64_int64\", 2, 1},\n+    {\"test_prelu_broadcast\", 2, 1},\n+    {\"test_prelu_example\", 2, 1},\n+    {\"test_qlinearconv\", 8, 1},\n+    {\"test_qlinearmatmul_2D\", 8, 1},\n+    {\"test_qlinearmatmul_3D\", 8, 1},\n+    {\"test_quantizelinear\", 3, 1},\n+    {\"test_quantizelinear_axis\", 3, 1},\n+    {\"test_range_float_type_positive_delta\", 3, 1},\n+    {\"test_range_float_type_positive_delta_expanded\", 3, 1},\n+    {\"test_range_int32_type_negative_delta\", 3, 1},\n+    {\"test_range_int32_type_negative_delta_expanded\", 3, 1},\n+    {\"test_reciprocal\", 1, 1},\n+    {\"test_reciprocal_example\", 1, 1},\n+    {\"test_reduce_l1_default_axes_keepdims_example\", 1, 1},\n+    {\"test_reduce_l1_default_axes_keepdims_random\", 1, 1},\n+    {\"test_reduce_l1_do_not_keepdims_example\", 1, 1},\n+    {\"test_reduce_l1_do_not_keepdims_random\", 1, 1},\n+    {\"test_reduce_l1_keep_dims_example\", 1, 1},\n+    {\"test_reduce_l1_keep_dims_random\", 1, 1},\n+    {\"test_reduce_l1_negative_axes_keep_dims_example\", 1, 1},\n+    {\"test_reduce_l1_negative_axes_keep_dims_random\", 1, 1},\n+    {\"test_reduce_l2_default_axes_keepdims_example\", 1, 1},\n+    {\"test_reduce_l2_default_axes_keepdims_random\", 1, 1},\n+    {\"test_reduce_l2_do_not_keepdims_example\", 1, 1},\n+    {\"test_reduce_l2_do_not_keepdims_random\", 1, 1},\n+    {\"test_reduce_l2_keep_dims_example\", 1, 1},\n+    {\"test_reduce_l2_keep_dims_random\", 1, 1},\n+    {\"test_reduce_l2_negative_axes_keep_dims_example\", 1, 1},\n+    {\"test_reduce_l2_negative_axes_keep_dims_random\", 1, 1},\n+    {\"test_reduce_log_sum\", 1, 1},\n+    {\"test_reduce_log_sum_asc_axes\", 1, 1},\n+    {\"test_reduce_log_sum_default\", 1, 1},\n+    {\"test_reduce_log_sum_desc_axes\", 1, 1},\n+    {\"test_reduce_log_sum_exp_default_axes_keepdims_example\", 1, 1},\n+    {\"test_reduce_log_sum_exp_default_axes_keepdims_random\", 1, 1},\n+    {\"test_reduce_log_sum_exp_do_not_keepdims_example\", 1, 1},\n+    {\"test_reduce_log_sum_exp_do_not_keepdims_random\", 1, 1},\n+    {\"test_reduce_log_sum_exp_keepdims_example\", 1, 1},\n+    {\"test_reduce_log_sum_exp_keepdims_random\", 1, 1},\n+    {\"test_reduce_log_sum_exp_negative_axes_keepdims_example\", 1, 1},\n+    {\"test_reduce_log_sum_exp_negative_axes_keepdims_random\", 1, 1},\n+    {\"test_reduce_log_sum_negative_axes\", 1, 1},\n+    {\"test_reduce_max_default_axes_keepdim_example\", 1, 1},\n+    {\"test_reduce_max_default_axes_keepdims_random\", 1, 1},\n+    {\"test_reduce_max_do_not_keepdims_example\", 1, 1},\n+    {\"test_reduce_max_do_not_keepdims_random\", 1, 1},\n+    {\"test_reduce_max_keepdims_example\", 1, 1},\n+    {\"test_reduce_max_keepdims_random\", 1, 1},\n+    {\"test_reduce_max_negative_axes_keepdims_example\", 1, 1},\n+    {\"test_reduce_max_negative_axes_keepdims_random\", 1, 1},\n+    {\"test_reduce_mean_default_axes_keepdims_example\", 1, 1},\n+    {\"test_reduce_mean_default_axes_keepdims_random\", 1, 1},\n+    {\"test_reduce_mean_do_not_keepdims_example\", 1, 1},\n+    {\"test_reduce_mean_do_not_keepdims_random\", 1, 1},\n+    {\"test_reduce_mean_keepdims_example\", 1, 1},\n+    {\"test_reduce_mean_keepdims_random\", 1, 1},\n+    {\"test_reduce_mean_negative_axes_keepdims_example\", 1, 1},\n+    {\"test_reduce_mean_negative_axes_keepdims_random\", 1, 1},\n+    {\"test_reduce_min_default_axes_keepdims_example\", 1, 1},\n+    {\"test_reduce_min_default_axes_keepdims_random\", 1, 1},\n+    {\"test_reduce_min_do_not_keepdims_example\", 1, 1},\n+    {\"test_reduce_min_do_not_keepdims_random\", 1, 1},\n+    {\"test_reduce_min_keepdims_example\", 1, 1},\n+    {\"test_reduce_min_keepdims_random\", 1, 1},\n+    {\"test_reduce_min_negative_axes_keepdims_example\", 1, 1},\n+    {\"test_reduce_min_negative_axes_keepdims_random\", 1, 1},\n+    {\"test_reduce_prod_default_axes_keepdims_example\", 1, 1},\n+    {\"test_reduce_prod_default_axes_keepdims_random\", 1, 1},\n+    {\"test_reduce_prod_do_not_keepdims_example\", 1, 1},\n+    {\"test_reduce_prod_do_not_keepdims_random\", 1, 1},\n+    {\"test_reduce_prod_keepdims_example\", 1, 1},\n+    {\"test_reduce_prod_keepdims_random\", 1, 1},\n+    {\"test_reduce_prod_negative_axes_keepdims_example\", 1, 1},\n+    {\"test_reduce_prod_negative_axes_keepdims_random\", 1, 1},\n+    {\"test_reduce_sum_default_axes_keepdims_example\", 2, 1},\n+    {\"test_reduce_sum_default_axes_keepdims_random\", 2, 1},\n+    {\"test_reduce_sum_do_not_keepdims_example\", 2, 1},\n+    {\"test_reduce_sum_do_not_keepdims_random\", 2, 1},\n+    {\"test_reduce_sum_empty_axes_input_noop_example\", 2, 1},\n+    {\"test_reduce_sum_empty_axes_input_noop_random\", 2, 1},\n+    {\"test_reduce_sum_keepdims_example\", 2, 1},\n+    {\"test_reduce_sum_keepdims_random\", 2, 1},\n+    {\"test_reduce_sum_negative_axes_keepdims_example\", 2, 1},\n+    {\"test_reduce_sum_negative_axes_keepdims_random\", 2, 1},\n+    {\"test_reduce_sum_square_default_axes_keepdims_example\", 1, 1},\n+    {\"test_reduce_sum_square_default_axes_keepdims_random\", 1, 1},\n+    {\"test_reduce_sum_square_do_not_keepdims_example\", 1, 1},\n+    {\"test_reduce_sum_square_do_not_keepdims_random\", 1, 1},\n+    {\"test_reduce_sum_square_keepdims_example\", 1, 1},\n+    {\"test_reduce_sum_square_keepdims_random\", 1, 1},\n+    {\"test_reduce_sum_square_negative_axes_keepdims_example\", 1, 1},\n+    {\"test_reduce_sum_square_negative_axes_keepdims_random\", 1, 1},\n+    {\"test_reflect_pad\", 2, 1},\n+    {\"test_relu\", 1, 1},\n+    {\"test_reshape_allowzero_reordered\", 2, 1},\n+    {\"test_reshape_extended_dims\", 2, 1},\n+    {\"test_reshape_negative_dim\", 2, 1},\n+    {\"test_reshape_negative_extended_dims\", 2, 1},\n+    {\"test_reshape_one_dim\", 2, 1},\n+    {\"test_reshape_reduced_dims\", 2, 1},\n+    {\"test_reshape_reordered_all_dims\", 2, 1},\n+    {\"test_reshape_reordered_last_dims\", 2, 1},\n+    {\"test_reshape_zero_and_negative_dim\", 2, 1},\n+    {\"test_reshape_zero_dim\", 2, 1},\n+    {\"test_resize_downsample_scales_cubic\", 2, 1},\n+    {\"test_resize_downsample_scales_cubic_A_n0p5_exclude_outside\", 2, 1},\n+    {\"test_resize_downsample_scales_cubic_align_corners\", 2, 1},\n+    {\"test_resize_downsample_scales_linear\", 2, 1},\n+    {\"test_resize_downsample_scales_linear_align_corners\", 2, 1},\n+    {\"test_resize_downsample_scales_nearest\", 2, 1},\n+    {\"test_resize_downsample_sizes_cubic\", 2, 1},\n+    {\"test_resize_downsample_sizes_linear_pytorch_half_pixel\", 2, 1},\n+    {\"test_resize_downsample_sizes_nearest\", 2, 1},\n+    {\"test_resize_downsample_sizes_nearest_tf_half_pixel_for_nn\", 2, 1},\n+    {\"test_resize_tf_crop_and_resize\", 3, 1},\n+    {\"test_resize_upsample_scales_cubic\", 2, 1},\n+    {\"test_resize_upsample_scales_cubic_A_n0p5_exclude_outside\", 2, 1},\n+    {\"test_resize_upsample_scales_cubic_align_corners\", 2, 1},\n+    {\"test_resize_upsample_scales_cubic_asymmetric\", 2, 1},\n+    {\"test_resize_upsample_scales_linear\", 2, 1},\n+    {\"test_resize_upsample_scales_linear_align_corners\", 2, 1},\n+    {\"test_resize_upsample_scales_nearest\", 2, 1},\n+    {\"test_resize_upsample_sizes_cubic\", 2, 1},\n+    {\"test_resize_upsample_sizes_nearest\", 2, 1},\n+    {\"test_resize_upsample_sizes_nearest_ceil_half_pixel\", 2, 1},\n+    {\"test_resize_upsample_sizes_nearest_floor_align_corners\", 2, 1},\n+    {\"test_resize_upsample_sizes_nearest_round_prefer_ceil_asymmetric\", 2, 1},\n+    {\"test_reversesequence_batch\", 2, 1},\n+    {\"test_reversesequence_time\", 2, 1},\n+    {\"test_rnn_seq_length\", 4, 1},\n+    {\"test_roialign_aligned_false\", 3, 1},\n+    {\"test_roialign_aligned_true\", 3, 1},\n+    {\"test_round\", 1, 1},\n+    {\"test_scan9_sum\", 2, 2},\n+    {\"test_scan_sum\", 2, 2},\n+    {\"test_scatter_elements_with_axis\", 3, 1},\n+    {\"test_scatter_elements_with_duplicate_indices\", 3, 1},\n+    {\"test_scatter_elements_with_negative_indices\", 3, 1},\n+    {\"test_scatter_elements_without_axis\", 3, 1},\n+    {\"test_scatter_with_axis\", 3, 1},\n+    {\"test_scatter_without_axis\", 3, 1},\n+    {\"test_scatternd\", 3, 1},\n+    {\"test_scatternd_add\", 3, 1},\n+    {\"test_scatternd_multiply\", 3, 1},\n+    {\"test_sce_NCd1_mean_weight_negative_ii\", 3, 1},\n+    {\"test_sce_NCd1_mean_weight_negative_ii_expanded\", 3, 1},\n+    {\"test_sce_NCd1_mean_weight_negative_ii_log_prob\", 3, 2},\n+    {\"test_sce_NCd1_mean_weight_negative_ii_log_prob_expanded\", 3, 2},\n+    {\"test_sce_NCd1d2d3_none_no_weight_negative_ii\", 2, 1},\n+    {\"test_sce_NCd1d2d3_none_no_weight_negative_ii_expanded\", 2, 1},\n+    {\"test_sce_NCd1d2d3_none_no_weight_negative_ii_log_prob\", 2, 2},\n+    {\"test_sce_NCd1d2d3_none_no_weight_negative_ii_log_prob_expanded\", 2, 2},\n+    {\"test_sce_NCd1d2d3_sum_weight_high_ii\", 3, 1},\n+    {\"test_sce_NCd1d2d3_sum_weight_high_ii_expanded\", 3, 1},\n+    {\"test_sce_NCd1d2d3_sum_weight_high_ii_log_prob\", 3, 2},\n+    {\"test_sce_NCd1d2d3_sum_weight_high_ii_log_prob_expanded\", 3, 2},\n+    {\"test_sce_NCd1d2d3d4d5_mean_weight\", 3, 1},\n+    {\"test_sce_NCd1d2d3d4d5_mean_weight_expanded\", 3, 1},\n+    {\"test_sce_NCd1d2d3d4d5_mean_weight_log_prob\", 3, 2},\n+    {\"test_sce_NCd1d2d3d4d5_mean_weight_log_prob_expanded\", 3, 2},\n+    {\"test_sce_NCd1d2d3d4d5_none_no_weight\", 2, 1},\n+    {\"test_sce_NCd1d2d3d4d5_none_no_weight_expanded\", 2, 1},\n+    {\"test_sce_NCd1d2d3d4d5_none_no_weight_log_prob\", 2, 2},\n+    {\"test_sce_NCd1d2d3d4d5_none_no_weight_log_prob_expanded\", 2, 2},\n+    {\"test_sce_mean\", 2, 1},\n+    {\"test_sce_mean_3d\", 2, 1},\n+    {\"test_sce_mean_3d_expanded\", 2, 1},\n+    {\"test_sce_mean_3d_log_prob\", 2, 2},\n+    {\"test_sce_mean_3d_log_prob_expanded\", 2, 2},\n+    {\"test_sce_mean_expanded\", 2, 1},\n+    {\"test_sce_mean_log_prob\", 2, 2},\n+    {\"test_sce_mean_log_prob_expanded\", 2, 2},\n+    {\"test_sce_mean_no_weight_ii\", 2, 1},\n+    {\"test_sce_mean_no_weight_ii_3d\", 2, 1},\n+    {\"test_sce_mean_no_weight_ii_3d_expanded\", 2, 1},\n+    {\"test_sce_mean_no_weight_ii_3d_log_prob\", 2, 2},\n+    {\"test_sce_mean_no_weight_ii_3d_log_prob_expanded\", 2, 2},\n+    {\"test_sce_mean_no_weight_ii_4d\", 2, 1},\n+    {\"test_sce_mean_no_weight_ii_4d_expanded\", 2, 1},\n+    {\"test_sce_mean_no_weight_ii_4d_log_prob\", 2, 2},\n+    {\"test_sce_mean_no_weight_ii_4d_log_prob_expanded\", 2, 2},\n+    {\"test_sce_mean_no_weight_ii_expanded\", 2, 1},\n+    {\"test_sce_mean_no_weight_ii_log_prob\", 2, 2},\n+    {\"test_sce_mean_no_weight_ii_log_prob_expanded\", 2, 2},\n+    {\"test_sce_mean_weight\", 3, 1},\n+    {\"test_sce_mean_weight_expanded\", 3, 1},\n+    {\"test_sce_mean_weight_ii\", 3, 1},\n+    {\"test_sce_mean_weight_ii_3d\", 3, 1},\n+    {\"test_sce_mean_weight_ii_3d_expanded\", 3, 1},\n+    {\"test_sce_mean_weight_ii_3d_log_prob\", 3, 2},\n+    {\"test_sce_mean_weight_ii_3d_log_prob_expanded\", 3, 2},\n+    {\"test_sce_mean_weight_ii_4d\", 3, 1},\n+    {\"test_sce_mean_weight_ii_4d_expanded\", 3, 1},\n+    {\"test_sce_mean_weight_ii_4d_log_prob\", 3, 2},\n+    {\"test_sce_mean_weight_ii_4d_log_prob_expanded\", 3, 2},\n+    {\"test_sce_mean_weight_ii_expanded\", 3, 1},\n+    {\"test_sce_mean_weight_ii_log_prob\", 3, 2},\n+    {\"test_sce_mean_weight_ii_log_prob_expanded\", 3, 2},\n+    {\"test_sce_mean_weight_log_prob\", 3, 2},\n+    {\"test_sce_mean_weight_log_prob_expanded\", 3, 2},\n+    {\"test_sce_none\", 2, 1},\n+    {\"test_sce_none_expanded\", 2, 1},\n+    {\"test_sce_none_log_prob\", 2, 2},\n+    {\"test_sce_none_log_prob_expanded\", 2, 2},\n+    {\"test_sce_none_weights\", 3, 1},\n+    {\"test_sce_none_weights_expanded\", 3, 1},\n+    {\"test_sce_none_weights_log_prob\", 3, 2},\n+    {\"test_sce_none_weights_log_prob_expanded\", 3, 2},\n+    {\"test_sce_sum\", 2, 1},\n+    {\"test_sce_sum_expanded\", 2, 1},\n+    {\"test_sce_sum_log_prob\", 2, 2},\n+    {\"test_sce_sum_log_prob_expanded\", 2, 2},\n+    {\"test_selu\", 1, 1},\n+    {\"test_selu_default\", 1, 1},\n+    {\"test_selu_example\", 1, 1},\n+    {\"test_sequence_insert_at_back\", 2, 1},\n+    {\"test_sequence_insert_at_front\", 3, 1},\n+    {\"test_shape\", 1, 1},\n+    {\"test_shape_clip_end\", 1, 1},\n+    {\"test_shape_clip_start\", 1, 1},\n+    {\"test_shape_end_1\", 1, 1},\n+    {\"test_shape_end_negative_1\", 1, 1},\n+    {\"test_shape_example\", 1, 1},\n+    {\"test_shape_start_1\", 1, 1},\n+    {\"test_shape_start_1_end_2\", 1, 1},\n+    {\"test_shape_start_1_end_negative_1\", 1, 1},\n+    {\"test_shape_start_negative_1\", 1, 1},\n+    {\"test_shrink_hard\", 1, 1},\n+    {\"test_shrink_soft\", 1, 1},\n+    {\"test_sigmoid\", 1, 1},\n+    {\"test_sigmoid_example\", 1, 1},\n+    {\"test_sign\", 1, 1},\n+    {\"test_simple_rnn_batchwise\", 3, 2},\n+    {\"test_simple_rnn_defaults\", 3, 1},\n+    {\"test_simple_rnn_with_initial_bias\", 4, 1},\n+    {\"test_sin\", 1, 1},\n+    {\"test_sin_example\", 1, 1},\n+    {\"test_sinh\", 1, 1},\n+    {\"test_sinh_example\", 1, 1},\n+    {\"test_size\", 1, 1},\n+    {\"test_size_example\", 1, 1},\n+    {\"test_slice\", 5, 1},\n+    {\"test_slice_default_axes\", 3, 1},\n+    {\"test_slice_default_steps\", 4, 1},\n+    {\"test_slice_end_out_of_bounds\", 5, 1},\n+    {\"test_slice_neg\", 5, 1},\n+    {\"test_slice_neg_steps\", 5, 1},\n+    {\"test_slice_negative_axes\", 4, 1},\n+    {\"test_slice_start_out_of_bounds\", 5, 1},\n+    {\"test_softmax_axis_0\", 1, 1},\n+    {\"test_softmax_axis_0_expanded\", 1, 1},\n+    {\"test_softmax_axis_1\", 1, 1},\n+    {\"test_softmax_axis_1_expanded\", 1, 1},\n+    {\"test_softmax_axis_2\", 1, 1},\n+    {\"test_softmax_axis_2_expanded\", 1, 1},\n+    {\"test_softmax_default_axis\", 1, 1},\n+    {\"test_softmax_default_axis_expanded\", 1, 1},\n+    {\"test_softmax_example\", 1, 1},\n+    {\"test_softmax_example_expanded\", 1, 1},\n+    {\"test_softmax_large_number\", 1, 1},\n+    {\"test_softmax_large_number_expanded\", 1, 1},\n+    {\"test_softmax_negative_axis\", 1, 1},\n+    {\"test_softmax_negative_axis_expanded\", 1, 1},\n+    {\"test_softplus\", 1, 1},\n+    {\"test_softplus_example\", 1, 1},\n+    {\"test_softsign\", 1, 1},\n+    {\"test_softsign_example\", 1, 1},\n+    {\"test_spacetodepth\", 1, 1},\n+    {\"test_spacetodepth_example\", 1, 1},\n+    {\"test_split_equal_parts_1d\", 1, 3},\n+    {\"test_split_equal_parts_2d\", 1, 2},\n+    {\"test_split_equal_parts_default_axis\", 1, 3},\n+    {\"test_split_variable_parts_1d\", 2, 2},\n+    {\"test_split_variable_parts_2d\", 2, 2},\n+    {\"test_split_variable_parts_default_axis\", 2, 2},\n+    {\"test_split_zero_size_splits\", 2, 3},\n+    {\"test_sqrt\", 1, 1},\n+    {\"test_sqrt_example\", 1, 1},\n+    {\"test_squeeze\", 2, 1},\n+    {\"test_squeeze_negative_axes\", 2, 1},\n+    {\"test_strnormalizer_export_monday_casesensintive_lower\", 1, 1},\n+    {\"test_strnormalizer_export_monday_casesensintive_nochangecase\", 1, 1},\n+    {\"test_strnormalizer_export_monday_casesensintive_upper\", 1, 1},\n+    {\"test_strnormalizer_export_monday_empty_output\", 1, 1},\n+    {\"test_strnormalizer_export_monday_insensintive_upper_twodim\", 1, 1},\n+    {\"test_strnormalizer_nostopwords_nochangecase\", 1, 1},\n+    {\"test_sub\", 2, 1},\n+    {\"test_sub_bcast\", 2, 1},\n+    {\"test_sub_example\", 2, 1},\n+    {\"test_sub_uint8\", 2, 1},\n+    {\"test_sum_example\", 3, 1},\n+    {\"test_sum_one_input\", 1, 1},\n+    {\"test_sum_two_inputs\", 2, 1},\n+    {\"test_tan\", 1, 1},\n+    {\"test_tan_example\", 1, 1},\n+    {\"test_tanh\", 1, 1},\n+    {\"test_tanh_example\", 1, 1},\n+    {\"test_tfidfvectorizer_tf_batch_onlybigrams_skip0\", 1, 1},\n+    {\"test_tfidfvectorizer_tf_batch_onlybigrams_skip5\", 1, 1},\n+    {\"test_tfidfvectorizer_tf_batch_uniandbigrams_skip5\", 1, 1},\n+    {\"test_tfidfvectorizer_tf_only_bigrams_skip0\", 1, 1},\n+    {\"test_tfidfvectorizer_tf_onlybigrams_levelempty\", 1, 1},\n+    {\"test_tfidfvectorizer_tf_onlybigrams_skip5\", 1, 1},\n+    {\"test_tfidfvectorizer_tf_uniandbigrams_skip5\", 1, 1},\n+    {\"test_thresholdedrelu\", 1, 1},\n+    {\"test_thresholdedrelu_default\", 1, 1},\n+    {\"test_thresholdedrelu_example\", 1, 1},\n+    {\"test_tile\", 2, 1},\n+    {\"test_tile_precomputed\", 2, 1},\n+    {\"test_top_k\", 2, 2},\n+    {\"test_top_k_negative_axis\", 2, 2},\n+    {\"test_top_k_smallest\", 2, 2},\n+    {\"test_training_dropout\", 3, 1},\n+    {\"test_training_dropout_default\", 3, 1},\n+    {\"test_training_dropout_default_mask\", 3, 2},\n+    {\"test_training_dropout_mask\", 3, 2},\n+    {\"test_training_dropout_zero_ratio\", 3, 1},\n+    {\"test_training_dropout_zero_ratio_mask\", 3, 2},\n+    {\"test_transpose_all_permutations_0\", 1, 1},\n+    {\"test_transpose_all_permutations_1\", 1, 1},\n+    {\"test_transpose_all_permutations_2\", 1, 1},\n+    {\"test_transpose_all_permutations_3\", 1, 1},\n+    {\"test_transpose_all_permutations_4\", 1, 1},\n+    {\"test_transpose_all_permutations_5\", 1, 1},\n+    {\"test_transpose_default\", 1, 1},\n+    {\"test_tril\", 1, 1},\n+    {\"test_tril_neg\", 2, 1},\n+    {\"test_tril_one_row_neg\", 1, 1},\n+    {\"test_tril_out_neg\", 2, 1},\n+    {\"test_tril_out_pos\", 2, 1},\n+    {\"test_tril_pos\", 2, 1},\n+    {\"test_tril_square\", 1, 1},\n+    {\"test_tril_square_neg\", 2, 1},\n+    {\"test_tril_zero\", 2, 1},\n+    {\"test_triu\", 1, 1},\n+    {\"test_triu_neg\", 2, 1},\n+    {\"test_triu_one_row\", 2, 1},\n+    {\"test_triu_out_neg_out\", 2, 1},\n+    {\"test_triu_out_pos\", 2, 1},\n+    {\"test_triu_pos\", 2, 1},\n+    {\"test_triu_square\", 1, 1},\n+    {\"test_triu_square_neg\", 2, 1},\n+    {\"test_triu_zero\", 2, 1},\n+    {\"test_unique_not_sorted_without_axis\", 1, 4},\n+    {\"test_unique_sorted_with_axis\", 1, 4},\n+    {\"test_unique_sorted_with_axis_3d\", 1, 4},\n+    {\"test_unique_sorted_with_negative_axis\", 1, 4},\n+    {\"test_unique_sorted_without_axis\", 1, 4},\n+    {\"test_unsqueeze_axis_0\", 2, 1},\n+    {\"test_unsqueeze_axis_1\", 2, 1},\n+    {\"test_unsqueeze_axis_2\", 2, 1},\n+    {\"test_unsqueeze_axis_3\", 1, 1},\n+    {\"test_unsqueeze_negative_axes\", 2, 1},\n+    {\"test_unsqueeze_three_axes\", 2, 1},\n+    {\"test_unsqueeze_two_axes\", 2, 1},\n+    {\"test_unsqueeze_unsorted_axes\", 2, 1},\n+    {\"test_upsample_nearest\", 2, 1},\n+    {\"test_where_example\", 3, 1},\n+    {\"test_where_long_example\", 3, 1},\n+    {\"test_xor2d\", 2, 1},\n+    {\"test_xor3d\", 2, 1},\n+    {\"test_xor4d\", 2, 1},\n+    {\"test_xor_bcast3v1d\", 2, 1},\n+    {\"test_xor_bcast3v2d\", 2, 1},\n+    {\"test_xor_bcast4v2d\", 2, 1},\n+    {\"test_xor_bcast4v3d\", 2, 1},\n+    {\"test_xor_bcast4v4d\", 2, 1},\n+};\n+\n+\n+struct TestCaseInput\n+{\n+    std::vector<std::string> input_paths;\n+    std::vector<std::string> output_paths;\n+    std::string model_path;\n+    std::string name;\n+};\n+\n+std::ostream& operator<<(std::ostream& os, const TestCaseInput& test_case)\n+{\n+    return os << test_case.name;\n+}\n+\n+typedef tuple<TestCaseInput, tuple<Backend, Target> > ONNXConfParams;\n+\n+std::string printOnnxConfParams(const testing::TestParamInfo<ONNXConfParams>& params)\n+{\n+    TestCaseInput test_case = get<0>(params.param);\n+    Backend backend = get<0>(get<1>(params.param));\n+    Target target = get<1>(get<1>(params.param));\n+\n+    std::stringstream ss;\n+    ss << test_case.name << \"_\";\n+    PrintTo(backend, &ss);\n+    ss << \"_\";\n+    PrintTo(target, &ss);\n+\n+    return ss.str();\n+}\n+\n+template<typename TString>\n+static std::string _tf(TString filename, bool required = true)\n+{\n+    return findDataFile(std::string(\"dnn/onnx/\") + filename, required);\n+}\n+\n+std::vector<TestCaseInput> readTestCases()\n+{\n+    std::vector<TestCaseInput> ret;\n+    for (size_t i = 0; i < sizeof(testConformanceConfig) / sizeof(testConformanceConfig[0]); ++i)\n+    {\n+        const TestCase& test_case = testConformanceConfig[i];\n+\n+        TestCaseInput input;\n+\n+        std::string prefix = cv::format(\"conformance/node/%s\", test_case.name);\n+        input.name = test_case.name;\n+        input.model_path = _tf(cv::format(\"%s/model.onnx\", prefix.c_str()));",
    "line": 948,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 141229975,
        "node_id": "REA_lATOAE3xU84t28Wyzghq_5c",
        "user": {
          "login": "rogday",
          "id": 24976862,
          "node_id": "MDQ6VXNlcjI0OTc2ODYy",
          "avatar_url": "https://avatars.githubusercontent.com/u/24976862?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/rogday",
          "html_url": "https://github.com/rogday",
          "followers_url": "https://api.github.com/users/rogday/followers",
          "following_url": "https://api.github.com/users/rogday/following{/other_user}",
          "gists_url": "https://api.github.com/users/rogday/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/rogday/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/rogday/subscriptions",
          "organizations_url": "https://api.github.com/users/rogday/orgs",
          "repos_url": "https://api.github.com/users/rogday/repos",
          "events_url": "https://api.github.com/users/rogday/events{/privacy}",
          "received_events_url": "https://api.github.com/users/rogday/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2021-12-15T09:55:11Z"
      }
    ],
    "timestamp": "2021-12-15T08:38:24Z",
    "isReviewComment": true,
    "pullRequestReviewId": 832474742,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-03-03T18:02:54.078Z",
    "difficultyAssessmentMethod": "manual"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 20038,
    "prTitle": "Update patchNaNs to support CV_64F",
    "prAuthor": "danielenricocahall",
    "prLink": "https://github.com/opencv/opencv/pull/20038",
    "commentAuthor": "alalek",
    "commentBody": "Extra check is required for OpenCL devices without doubles (64F) support.\r\n\r\nLook for code with:\r\n\r\n```\r\nbool doubleSupport = d.doubleFPConfig() > 0;\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/opencv/opencv/pull/20038#discussion_r630363261",
    "filePath": "modules/core/src/mathfuncs.cpp",
    "diffHunk": "@@ -1574,7 +1574,7 @@ static bool ocl_patchNaNs( InputOutputArray _a, float value )\n     int rowsPerWI = ocl::Device::getDefault().isIntel() ? 4 : 1;\n     ocl::Kernel k(\"KF\", ocl::core::arithm_oclsrc,\n                      format(\"-D UNARY_OP -D OP_PATCH_NANS -D dstT=float -D DEPTH_dst=%d -D rowsPerWI=%d\",\n-                            CV_32F, rowsPerWI));\n+                            _a.depth(), rowsPerWI));",
    "line": 11,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-05-11T17:00:00Z",
    "isReviewComment": true,
    "pullRequestReviewId": 656988117,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:09.623Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 18739,
    "prTitle": "[Unix] Fix the OpenGL undetected on Linux, caused by GTK3+ detection snafu",
    "prAuthor": "ebachard",
    "prLink": "https://github.com/opencv/opencv/pull/18739",
    "commentAuthor": "alalek",
    "commentBody": "This change is wrong.\r\nCheck `ocv_check_modules()` implementation - it sets corresponding `HAVE_*` vars.\r\n\r\nP.S. Always clean CMake cache (clean build directory) during dependencies change.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/18739#discussion_r518565806",
    "filePath": "cmake/OpenCVFindLibsGUI.cmake",
    "diffHunk": "@@ -38,7 +38,7 @@ endif()\n ocv_clear_vars(HAVE_GTK HAVE_GTK3 HAVE_GTHREAD HAVE_GTKGLEXT)\n if(WITH_GTK AND NOT HAVE_QT)\n   if(NOT WITH_GTK_2_X)\n-    ocv_check_modules(GTK3 gtk+-3.0)\n+    ocv_check_modules(HAVE_GTK3 gtk+-3.0)\n     if(HAVE_GTK3)",
    "line": 6,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-11-06T07:26:02Z",
    "isReviewComment": true,
    "pullRequestReviewId": 524907590,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:10.031Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 16802,
    "prTitle": "Scale_layer: enable scale layer to handle inputs in batch",
    "prAuthor": "ashishkrshrivastava",
    "prLink": "https://github.com/opencv/opencv/pull/16802",
    "commentAuthor": "alalek",
    "commentBody": "> ` / numWeightsSamples`\r\n\r\nAssertion check for non zero value is necessary.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/16802#discussion_r567229302",
    "filePath": "modules/dnn/src/layers/scale_layer.cpp",
    "diffHunk": "@@ -78,64 +78,94 @@ class ScaleLayerImpl CV_FINAL : public ScaleLayer\n         Mat &outBlob = outputs[0];\n         // There is a mode when we multiply a first blob by a second one\n         // instead of trainable weights.\n-        Mat weights = hasWeights ? (blobs.empty() ? inputs[1] : blobs[0]).reshape(1, 1) : Mat();;\n+        Mat weights = hasWeights ? (blobs.empty() ? inputs[1] : blobs[0]).reshape(1, 1) : Mat();\n         Mat bias = hasBias ? (blobs.empty() ? inputs[1] : blobs.back()).reshape(1, 1) : Mat();\n \n         MatShape inpShape = shape(inpBlob);\n+        const int numSamples = inpShape[0];\n+        const int numWeightsSamples = (hasWeights || hasBias) && blobs.empty() ? numSamples : 1;\n         const int numWeights = !weights.empty() ? weights.total() : bias.total();\n+        const int numWeightsPerSample = numWeights / numWeightsSamples;",
    "line": 12,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-01-30T10:36:54Z",
    "isReviewComment": true,
    "pullRequestReviewId": 579747263,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:11.936Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 10070,
    "prTitle": "Fix #7084 Thin Plate Spline warpImage() error",
    "prAuthor": "lzhbrian",
    "prLink": "https://github.com/opencv/opencv/pull/10070",
    "commentAuthor": "terfendail",
    "commentBody": "This estimation is wrong. According to math evaluations you provide in description here should be\r\n`mapX(x1, y1) = x1 - deltaX` where `deltaX = x1 - x`. You could consider `x1` as new `x`, but in this case you should somehow rename old `x` to retain it in the formula. Therefore if you substitute `deltaX` it would be `mapX(x1, y1) = x1 - (x1 -x)`. So after renaming you get `mapX(x, y) = x - (x - oldX)` instead of `mapX(x, y) = x - (x1 - x)`\r\nFor example the following set of points will be evaluated by the current code incorrectly:\r\nsrc(0,0)->dst(1,0)\r\nsrc(1,0)->dst(1,1)\r\nsrc(1,1)->dst(0,1)\r\nsrc(0,1)->dst(0,0)\r\nIn accordance with the formula dst(0,0) will be back projected to src(-pt.x, -pt.y)=src(-1, 0)(in accordance with `_applyTransformation` behaviour) but it should be src(0,1)\r\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/10070#discussion_r153221455",
    "filePath": "modules/shape/src/tps_trans.cpp",
    "diffHunk": "@@ -161,8 +161,9 @@ void ThinPlateSplineShapeTransformerImpl::warpImage(InputArray transformingImage\n         for (int col = 0; col < theinput.cols; col++)\n         {\n             Point2f pt = _applyTransformation(shapeReference, Point2f(float(col), float(row)), tpsParameters);\n-            mapX.at<float>(row, col) = pt.x;\n-            mapY.at<float>(row, col) = pt.y;\n+\n+            mapX.at<float>(row, col) = col - (pt.x - col);",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2017-11-27T15:05:48Z",
    "isReviewComment": true,
    "pullRequestReviewId": 79195735,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:11.660Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 8685,
    "prTitle": "Update imgwarp.cpp",
    "prAuthor": "woreno",
    "prLink": "https://github.com/opencv/opencv/pull/8685",
    "commentAuthor": "sovrasov",
    "commentBody": "It's seems the code processes a tail of a data. Previous loop has +8 increment, so if `bcols` is not divisible by 8 some elements won't be processed.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/8685#discussion_r114271824",
    "filePath": "modules/imgproc/src/imgwarp.cpp",
    "diffHunk": "@@ -4368,13 +4368,13 @@ class RemapInvoker :\n                                     _mm_storeu_si128((__m128i*)(XY + x1*2 + 8), iy1);\n                                 }\n                             }\n-                        #endif\n-\n+                        #else \n                             for( ; x1 < bcols; x1++ )",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2017-05-02T08:40:43Z",
    "isReviewComment": true,
    "pullRequestReviewId": 35722637,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:11.872Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 8338,
    "prTitle": "added CascadeClassifier tutorial copy - java translated",
    "prAuthor": "siddharthTyagi",
    "prLink": "https://github.com/opencv/opencv/pull/8338",
    "commentAuthor": "berak",
    "commentBody": "CascadeClassifier will not throw any exception, if it failed to load the xml.\r\n\r\ninstead of a try-catch block, you'll have to check `cascade.empty()`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/8338#discussion_r106598844",
    "filePath": "samples/java/CascadeClassifier/src/cv/samples/java/CascadeClassifier.java",
    "diffHunk": "@@ -0,0 +1,173 @@\n+package cv.samples.java;\n+\n+import static org.opencv.imgproc.Imgproc.COLOR_BGR2GRAY;\n+import static org.opencv.imgproc.Imgproc.circle;\n+import static org.opencv.imgproc.Imgproc.cvtColor;\n+import static org.opencv.imgproc.Imgproc.ellipse;\n+import static org.opencv.imgproc.Imgproc.equalizeHist;\n+\n+import java.awt.Image;\n+import java.awt.image.BufferedImage;\n+import java.awt.image.DataBufferByte;\n+import java.io.IOException;\n+import java.io.InputStreamReader;\n+\n+import javax.swing.ImageIcon;\n+import javax.swing.JFrame;\n+import javax.swing.JLabel;\n+\n+import org.opencv.core.Core;\n+import org.opencv.core.Mat;\n+import org.opencv.core.MatOfRect;\n+import org.opencv.core.Point;\n+import org.opencv.core.Rect;\n+import org.opencv.core.Scalar;\n+import org.opencv.core.Size;\n+import org.opencv.videoio.VideoCapture;\n+\n+public class CascadeClassifier {\n+\n+    static {\n+        System.setProperty(\"java.library.path\", System.getProperty(\"java.library.path\") + \":\"\n+                + \"/home/styagi/.workspace/Downloads/opencv-3.2.0/build/lib\");\n+        System.out.println(System.getProperty(\"java.library.path\"));\n+        System.loadLibrary(Core.NATIVE_LIBRARY_NAME);\n+    }\n+    private static org.opencv.objdetect.CascadeClassifier face_cascade;\n+    private static org.opencv.objdetect.CascadeClassifier eyes_cascade;\n+    private static ImageIcon icon;\n+    private static JFrame jframe;\n+\n+    static final String window_name = \"Capture - Face detection\";\n+    private static final int X = 800;\n+    private static final int Y = 600;\n+\n+    public static void main(String[] args) {\n+        if (args.length != 2) {\n+            System.out.println(\"{help h||}\");\n+            System.out.println(\"{face_cascade|../../data/haarcascades/haarcascade_frontalface_alt.xml|}\");\n+            System.out.println(\"{eyes_cascade|../../data/haarcascades/haarcascade_eye_tree_eyeglasses.xml|}\");\n+        }\n+\n+        System.out.println(\n+                \"\\nThis program demonstrates using the cv::CascadeClassifier class to detect objects (Face + eyes) in a video stream.\\n\"\n+                        + \"You can use Haar or LBP features.\\n\\n\");\n+\n+        String face_cascade_name = args[0];\n+        String eyes_cascade_name = args[1];\n+        VideoCapture capture = new VideoCapture(0);\n+\n+        // -- 1. Load the cascades\n+        try {",
    "line": 61,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2017-03-17T07:53:40Z",
    "isReviewComment": true,
    "pullRequestReviewId": 27528102,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:14.327Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 7196,
    "prTitle": "Added support for V4L2_PIX_FMT_Y16",
    "prAuthor": "stbnps",
    "prLink": "https://github.com/opencv/opencv/pull/7196",
    "commentAuthor": "alalek",
    "commentBody": "Problem is here.\n`capture->convert_rgb = false` should be changed explicitly by user only (via set property call with CV_CAP_PROP_CONVERT_RGB = false).\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/7196#discussion_r78561493",
    "filePath": "modules/videoio/src/cap_v4l.cpp",
    "diffHunk": "@@ -466,12 +466,16 @@ static int autosetup_capture_mode_v4l2(CvCaptureCAM_V4L* capture) {\n             V4L2_PIX_FMT_SN9C10X,\n             V4L2_PIX_FMT_SBGGR8,\n             V4L2_PIX_FMT_SGBRG8,\n-            V4L2_PIX_FMT_RGB24\n+            V4L2_PIX_FMT_RGB24,\n+            V4L2_PIX_FMT_Y16\n     };\n \n     for (size_t i = 0; i < sizeof(try_order) / sizeof(__u32); i++) {\n         capture->palette = try_order[i];\n         if (try_palette_v4l2(capture)) {\n+            if (capture->palette == V4L2_PIX_FMT_Y16) {\n+                capture->convert_rgb = false;\n+            }",
    "line": 14,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2016-09-13T13:46:02Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:14.574Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 7103,
    "prTitle": "Fix resolves issue #6366 updated",
    "prAuthor": "souch55",
    "prLink": "https://github.com/opencv/opencv/pull/7103",
    "commentAuthor": "terfendail",
    "commentBody": "Execution will fall into this branch if either trainDescCollection or utrainDescCollection isn't empty. So rows should be populated in accordance.\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/7103#discussion_r74742535",
    "filePath": "modules/features2d/src/matchers.cpp",
    "diffHunk": "@@ -601,22 +601,32 @@ void DescriptorMatcher::checkMasks( InputArrayOfArrays _masks, int queryDescript\n {\n     std::vector<Mat> masks;\n     _masks.getMatVector(masks);\n-\n+    int rows;\n     if( isMaskSupported() && !masks.empty() )\n     {\n         // Check masks\n         size_t imageCount = std::max(trainDescCollection.size(), utrainDescCollection.size() );\n         CV_Assert( masks.size() == imageCount );\n         for( size_t i = 0; i < imageCount; i++ )\n-        {\n-            if( !masks[i].empty() && (!trainDescCollection[i].empty() || !utrainDescCollection[i].empty() ) )\n-            {\n-                int rows = trainDescCollection[i].empty() ? utrainDescCollection[i].rows : trainDescCollection[i].rows;\n+        { \n+            if(!masks[i].empty()){\n+        \t  if(!trainDescCollection[i].empty() || !utrainDescCollection[i].empty())\n+        \t  { \n+                    rows = trainDescCollection[i].rows;",
    "line": 21,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2016-08-15T10:11:04Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:14.328Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 7098,
    "prTitle": "Update HoughCircle_Demo.cpp",
    "prAuthor": "yyyhssss",
    "prLink": "https://github.com/opencv/opencv/pull/7098",
    "commentAuthor": "alalek",
    "commentBody": "You should not truncate key value. This range exceed values of standard char \"[-128;127]\".\n\n```\n(char)0x131 == '1' /*0x31*/\n```\n\nis still \"true\", but it is wrong.\nYou should cast both to bigger type (\"int\" in this case) or try to change compiler options and disable noise warnings.\n",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/opencv/opencv/pull/7098#discussion_r74565867",
    "filePath": "samples/cpp/tutorial_code/ImgTrans/HoughCircle_Demo.cpp",
    "diffHunk": "@@ -91,7 +91,7 @@ int main(int argc, char** argv)\n     // and refresh the content of the output image\n     // until the user presses q or Q\n     int key = 0;\n-    while(key != 'q' && key != 'Q')\n+    while((char) key != 'q' && (char) key != 'Q')",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2016-08-12T09:44:21Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:16.593Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 7029,
    "prTitle": "Fix crash on double-stop of CvVideoCamera",
    "prAuthor": "wolever",
    "prLink": "https://github.com/opencv/opencv/pull/7029",
    "commentAuthor": "terfendail",
    "commentBody": "Looks like self.running could became equal to NO if one calls to [CvVideoCamera pause]. So in such case proper resource deallocation would be skipped.\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/7029#discussion_r73522321",
    "filePath": "modules/videoio/src/cap_ios_video_camera.mm",
    "diffHunk": "@@ -118,6 +122,10 @@ - (void)start;\n \n - (void)stop;\n {\n+    if (self.running == NO) {",
    "line": 15,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2016-08-04T13:35:12Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:16.243Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 4060,
    "prTitle": "IPP code refactored.",
    "prAuthor": "dbudniko",
    "prLink": "https://github.com/opencv/opencv/pull/4060",
    "commentAuthor": "alalek",
    "commentBody": "This code doesn't compile with IPP (not IPPICV): `depth` is not defined here\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/4060#discussion_r32628104",
    "filePath": "modules/core/src/stat.cpp",
    "diffHunk": "@@ -1291,51 +1307,62 @@ static bool ocl_countNonZero( InputArray _src, int & res )\n \n #endif\n \n+#if defined HAVE_IPP\n+namespace cv {\n+\n+static bool ipp_countNonZero( Mat src, int & res )\n+{\n+    Ipp32s count = 0;\n+    IppStatus status = (IppStatus)-1;\n+\n+\n+#if !defined HAVE_IPP_ICV_ONLY\n+    int type = src.type();\n+    IppiSize roiSize = { src.cols, src.rows };\n+    Ipp32s srcstep = (Ipp32s)src.step;\n+    if (src.isContinuous())\n+    {\n+        roiSize.width = (Ipp32s)src.total();\n+        roiSize.height = 1;\n+        srcstep = (Ipp32s)src.total() * CV_ELEM_SIZE(type);\n+    }\n+\n+    if (depth == CV_8U)",
    "line": 159,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2015-06-17T13:53:15Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:18.751Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 3856,
    "prTitle": "Parallel kmeans",
    "prAuthor": "BloodAxe",
    "prLink": "https://github.com/opencv/opencv/pull/3856",
    "commentAuthor": "ilya-lavrenov",
    "commentBody": "if 2 threads process data with the same label, we get data races here\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/3856#discussion_r26952322",
    "filePath": "modules/core/src/kmeans.cpp",
    "diffHunk": "@@ -212,6 +213,68 @@ class KMeansDistanceComputer : public ParallelLoopBody\n     const Mat& centers;\n };\n \n+\n+class KMeansCentersUpdater : public ParallelLoopBody\n+{\n+public:\n+    KMeansCentersUpdater(\n+        const int* _labels,\n+        const Mat& _data,\n+        Mat& _centers)\n+        : labels(_labels)\n+        , data(_data)\n+        , centers(_centers)\n+    {\n+    }\n+\n+    void operator()(const Range& range) const\n+    {\n+        const int begin = range.start;\n+        const int end = range.end;\n+        const int dims = centers.cols;\n+\n+        const float * sample;\n+        int j, k;\n+\n+        for (int i = begin; i < end; ++i)\n+        {\n+            sample = data.ptr<float>(i);\n+            k = labels[i];\n+\n+            float* center = centers.ptr<float>(k);",
    "line": 42,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2015-03-23T16:24:07Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:19.145Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 3845,
    "prTitle": "Modify findTransformECC to support a mask of pixels to consider",
    "prAuthor": "ellbur",
    "prLink": "https://github.com/opencv/opencv/pull/3845",
    "commentAuthor": "vpisarev",
    "commentBody": "you can not expect that the input mask is filled with 1's. OpenCV convention is that it only matters if certain mask pixel is equal to zero or not. Therefore, you should probably apply threshold() function and set non-zero pixels to 1 (but, of course, you should not touch the input mask, you should copy it to temporary array). In other words, you should probably write something like:\n\n<pre>\nMat preMask;\nif(inputMask.empty())\n    preMask = Mat::ones(hd, wd, CV_8U);\nelse\n   threshold(inputMask, preMask, 0, 1, THRESH_BINARY);\n</pre>\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/3845#discussion_r30463411",
    "filePath": "modules/video/src/ecc.cpp",
    "diffHunk": "@@ -397,13 +398,26 @@ double cv::findTransformECC(InputArray templateImage,\n     Mat templateFloat = Mat(hs, ws, CV_32F);// to store the (smoothed) template\n     Mat imageFloat    = Mat(hd, wd, CV_32F);// to store the (smoothed) input image\n     Mat imageWarped   = Mat(hs, ws, CV_32F);// to store the warped zero-mean input image\n-    Mat allOnes\t\t= Mat::ones(hd, wd, CV_8U); //to use it for mask warping\n     Mat imageMask\t\t= Mat(hs, ws, CV_8U); //to store the final mask\n \n+    Mat inputMaskMat = inputMask.getMat();\n+    //to use it for mask warping\n+    Mat preMask =\n+      inputMaskMat.empty() ? Mat::ones(hd, wd, CV_8U) : inputMaskMat;",
    "line": 20,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2015-05-16T18:37:41Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:18.443Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 2900,
    "prTitle": "Ensure that we're not already below required leaf false alarm rate before continuing to get negative samples and evaluate entire frame with detectSingleScale.",
    "prAuthor": "atomicfusion",
    "prLink": "https://github.com/opencv/opencv/pull/2900",
    "commentAuthor": "vpisarev",
    "commentBody": "using &lt;= here is wrong; 1) you potentially access memory outside of an image, 2) when the detected face is on the tile boundary, you will output the same face twice (or even 4 times).\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/2900#discussion_r15144907",
    "filePath": "modules/objdetect/src/cascadedetect.cpp",
    "diffHunk": "@@ -952,9 +952,9 @@ class CascadeClassifierInvoker : public ParallelLoopBody\n \n         int y1 = range.start * stripSize;\n         int y2 = min(range.end * stripSize, processingRectSize.height);\n-        for( int y = y1; y < y2; y += yStep )\n+        for( int y = y1; y <= y2; y += yStep )",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2014-07-19T18:07:52Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:20.955Z"
  },
  {
    "repo": "opencv/opencv",
    "prNumber": 1660,
    "prTitle": "Support Python 3 < version 3.3",
    "prAuthor": "prattmic",
    "prLink": "https://github.com/opencv/opencv/pull/1660",
    "commentAuthor": "SpecLad",
    "commentBody": "Not that easy, I'm afraid. You're leaking the object returned by `PyUnicode_AsUTF8String`.\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/opencv/opencv/pull/1660#discussion_r7120829",
    "filePath": "modules/python/src2/pycompat.hpp",
    "diffHunk": "@@ -56,9 +56,16 @@\n // Python3 strings are unicode, these defines mimic the Python2 functionality.\n #define PyString_Check PyUnicode_Check\n #define PyString_FromString PyUnicode_FromString\n-#define PyString_AsString PyUnicode_AsUTF8\n #define PyString_FromStringAndSize PyUnicode_FromStringAndSize\n #define PyString_Size PyUnicode_GET_SIZE\n+\n+// PyUnicode_AsUTF8 isn't available until Python 3.3\n+#if (PY_VERSION_HEX < 0x03030000)\n+#define PyString_AsString(x) PyBytes_AsString(PyUnicode_AsUTF8String(x))",
    "line": 10,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2013-10-22T09:52:14Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:20.955Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 97421,
    "prTitle": "Fix GDExtension classes inheriting from Resource not using icons in FileSystem",
    "prAuthor": "SaNeOr",
    "prLink": "https://github.com/godotengine/godot/pull/97421",
    "commentAuthor": "akien-mga",
    "commentBody": "This is wrongly assuming that the result of `EditorNode::get_singleton()->get_class_icon(file_info->type)` is valid and can de-referenced.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/97421#discussion_r1777009706",
    "filePath": "editor/editor_file_system.cpp",
    "diffHunk": "@@ -1872,6 +1872,10 @@ void EditorFileSystem::_update_file_icon_path(EditorFileSystemDirectory::FileInf\n \t\t}\n \t}\n \n+\tif (icon_path.is_empty() && !file_info->type.is_empty()) {\n+\t\ticon_path = EditorNode::get_singleton()->get_class_icon(file_info->type)->get_path();",
    "line": 5,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 266780084,
        "node_id": "REA_lATOAO6SJc5p6wQqzg_mvbQ",
        "user": {
          "login": "AThousandShips",
          "id": 96648715,
          "node_id": "U_kgDOBcK-Cw",
          "avatar_url": "https://avatars.githubusercontent.com/u/96648715?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/AThousandShips",
          "html_url": "https://github.com/AThousandShips",
          "followers_url": "https://api.github.com/users/AThousandShips/followers",
          "following_url": "https://api.github.com/users/AThousandShips/following{/other_user}",
          "gists_url": "https://api.github.com/users/AThousandShips/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/AThousandShips/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/AThousandShips/subscriptions",
          "organizations_url": "https://api.github.com/users/AThousandShips/orgs",
          "repos_url": "https://api.github.com/users/AThousandShips/repos",
          "events_url": "https://api.github.com/users/AThousandShips/events{/privacy}",
          "received_events_url": "https://api.github.com/users/AThousandShips/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2024-09-26T13:00:29Z"
      }
    ],
    "timestamp": "2024-09-26T12:51:49Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2331146411,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:50:28.703Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 96158,
    "prTitle": "Enable Metal for macOS x86_64.",
    "prAuthor": "Ozomahtli",
    "prLink": "https://github.com/godotengine/godot/pull/96158",
    "commentAuthor": "stuartcarnie",
    "commentBody": "The behaviour of this loop is undefined, or at least incorrect. The previous version looped from `MTLGPUFamilyApple9` (ordinal value 1009) to `MTLGPUFamilyApple1` (ordinal value 1001), and made a maximum of 9 calls to `[p_device supportsFamily:family]` with valid values of the `MTLGPUFamily` enumeration. \r\n\r\n`MTLGPUFamilyMetal3` has an ordinal value is `5001`. This version could make 1000's of additional calls, and will likely produce undefined behaviour depending on the behaviour of `[p_device supportsFamily:family]` with undefined values.\r\n\r\nFor reference, this is the definition of `MTLGPUFamily` enumeration:\r\n\r\n```objc\r\ntypedef NS_ENUM(NSInteger, MTLGPUFamily)\r\n{\r\n    MTLGPUFamilyApple1  = 1001,\r\n    MTLGPUFamilyApple2  = 1002,\r\n    MTLGPUFamilyApple3  = 1003,\r\n    MTLGPUFamilyApple4  = 1004,\r\n    MTLGPUFamilyApple5  = 1005,\r\n    MTLGPUFamilyApple6  = 1006,\r\n    MTLGPUFamilyApple7  = 1007,\r\n    MTLGPUFamilyApple8  = 1008,\r\n    MTLGPUFamilyApple9  = 1009,\r\n    \r\n    MTLGPUFamilyMac1 API_DEPRECATED_WITH_REPLACEMENT(\"MTLGPUFamilyMac2\", macos(10.15, 13.0), ios(13.0, 16.0)) = 2001,\r\n    MTLGPUFamilyMac2 = 2002,\r\n    \r\n    MTLGPUFamilyCommon1 = 3001,\r\n    MTLGPUFamilyCommon2 = 3002,\r\n    MTLGPUFamilyCommon3 = 3003,\r\n    \r\n    MTLGPUFamilyMacCatalyst1 API_DEPRECATED_WITH_REPLACEMENT(\"MTLGPUFamilyMac2\", macos(10.15, 13.0), ios(13.0, 16.0)) = 4001,\r\n    MTLGPUFamilyMacCatalyst2 API_DEPRECATED_WITH_REPLACEMENT(\"MTLGPUFamilyMac2\", macos(10.15, 13.0), ios(13.0, 16.0)) = 4002,\r\n    \r\n    MTLGPUFamilyMetal3 API_AVAILABLE(macos(13.0), ios(16.0)) = 5001,\r\n} API_AVAILABLE(macos(10.15), ios(13.0));\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/godotengine/godot/pull/96158#discussion_r1733453149",
    "filePath": "drivers/metal/metal_device_properties.mm",
    "diffHunk": "@@ -76,7 +80,7 @@\n \tfeatures = {};\n \n \tfeatures.highestFamily = MTLGPUFamilyApple1;\n-\tfor (MTLGPUFamily family = MTLGPUFamilyApple9; family >= MTLGPUFamilyApple1; --family) {\n+\tfor (MTLGPUFamily family = MTLGPUFamilyMetal3; family >= MTLGPUFamilyApple1; --family) {\n \t\tif ([p_device supportsFamily:family]) {\n \t\t\tfeatures.highestFamily = family;\n \t\t\tbreak;",
    "line": 19,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-08-27T20:08:43Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2264351998,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:54:30.949Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 93119,
    "prTitle": "[Image Font Importer] Adds support for `\\uXXXX` in the kerning config strings.",
    "prAuthor": "bruvzg",
    "prLink": "https://github.com/godotengine/godot/pull/93119",
    "commentAuthor": "DarkMarmot",
    "commentBody": "@bruvzg This bit of code is missing a part to advance past the hex characters and thus includes `u` and whatever 4 hex characters are included after it. I think it just needs `i += 5` here and in the next loop set to fix it. Do I need a demo project for it?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/93119#discussion_r1655695664",
    "filePath": "editor/import/resource_importer_imagefont.cpp",
    "diffHunk": "@@ -291,10 +291,29 @@ Error ResourceImporterImageFont::import(const String &p_source_file, const Strin\n \t\t\tWARN_PRINT(vformat(\"Invalid kerning pairs string: \\\"%s\\\"\", kp));\n \t\t\tcontinue;\n \t\t}\n+\t\tString from_tokens;\n+\t\tfor (int i = 0; i < kp_tokens[0].length(); i++) {\n+\t\t\tif (i <= kp_tokens[0].length() - 6 && kp_tokens[0][i] == '\\\\' && kp_tokens[0][i + 1] == 'u') {\n+\t\t\t\tchar32_t charcode = kp_tokens[0].substr(i + 2, 4).hex_to_int();\n+\t\t\t\tfrom_tokens += charcode;",
    "line": 8,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 258689907,
        "node_id": "REA_lATOAO6SJc5ir-kwzg9rS3M",
        "user": {
          "login": "shanayyy",
          "id": 13399488,
          "node_id": "MDQ6VXNlcjEzMzk5NDg4",
          "avatar_url": "https://avatars.githubusercontent.com/u/13399488?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/shanayyy",
          "html_url": "https://github.com/shanayyy",
          "followers_url": "https://api.github.com/users/shanayyy/followers",
          "following_url": "https://api.github.com/users/shanayyy/following{/other_user}",
          "gists_url": "https://api.github.com/users/shanayyy/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/shanayyy/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/shanayyy/subscriptions",
          "organizations_url": "https://api.github.com/users/shanayyy/orgs",
          "repos_url": "https://api.github.com/users/shanayyy/repos",
          "events_url": "https://api.github.com/users/shanayyy/events{/privacy}",
          "received_events_url": "https://api.github.com/users/shanayyy/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2024-08-02T09:51:44Z"
      }
    ],
    "timestamp": "2024-06-27T01:11:23Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2143218833,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:21.069Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 89004,
    "prTitle": "OpenXR Input Changed Events report prev value",
    "prAuthor": "Kimau",
    "prLink": "https://github.com/godotengine/godot/pull/89004",
    "commentAuthor": "akien-mga",
    "commentBody": "Isn't this backwards with what the logic below does? It seems to me like you're passing the old value first, then the new value.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/89004#discussion_r1507466116",
    "filePath": "servers/xr/xr_positional_tracker.cpp",
    "diffHunk": "@@ -68,8 +68,8 @@ void XRPositionalTracker::_bind_methods() {\n \tClassDB::bind_method(D_METHOD(\"set_input\", \"name\", \"value\"), &XRPositionalTracker::set_input);\n \tADD_SIGNAL(MethodInfo(\"button_pressed\", PropertyInfo(Variant::STRING, \"name\")));\n \tADD_SIGNAL(MethodInfo(\"button_released\", PropertyInfo(Variant::STRING, \"name\")));\n-\tADD_SIGNAL(MethodInfo(\"input_float_changed\", PropertyInfo(Variant::STRING, \"name\"), PropertyInfo(Variant::FLOAT, \"value\")));\n-\tADD_SIGNAL(MethodInfo(\"input_vector2_changed\", PropertyInfo(Variant::STRING, \"name\"), PropertyInfo(Variant::VECTOR2, \"vector\")));\n+\tADD_SIGNAL(MethodInfo(\"input_float_changed\", PropertyInfo(Variant::STRING, \"name\"), PropertyInfo(Variant::FLOAT, \"value\"), PropertyInfo(Variant::FLOAT, \"prev_value\")));",
    "line": 6,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 237546694,
        "node_id": "REA_lATOAO6SJc5Z2huEzg4orMY",
        "user": {
          "login": "AThousandShips",
          "id": 96648715,
          "node_id": "U_kgDOBcK-Cw",
          "avatar_url": "https://avatars.githubusercontent.com/u/96648715?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/AThousandShips",
          "html_url": "https://github.com/AThousandShips",
          "followers_url": "https://api.github.com/users/AThousandShips/followers",
          "following_url": "https://api.github.com/users/AThousandShips/following{/other_user}",
          "gists_url": "https://api.github.com/users/AThousandShips/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/AThousandShips/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/AThousandShips/subscriptions",
          "organizations_url": "https://api.github.com/users/AThousandShips/orgs",
          "repos_url": "https://api.github.com/users/AThousandShips/repos",
          "events_url": "https://api.github.com/users/AThousandShips/events{/privacy}",
          "received_events_url": "https://api.github.com/users/AThousandShips/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2024-02-29T12:02:20Z"
      }
    ],
    "timestamp": "2024-02-29T12:01:23Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1908689953,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:25.355Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 85609,
    "prTitle": "Add premult alpha blending to 3D (spatial) shaders",
    "prAuthor": "QbieShay",
    "prLink": "https://github.com/godotengine/godot/pull/85609",
    "commentAuthor": "akien-mga",
    "commentBody": "I merged a bit too fast, this one is still wrong.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/85609#discussion_r1585994643",
    "filePath": "scene/resources/material.cpp",
    "diffHunk": "@@ -688,6 +688,9 @@ void BaseMaterial3D::_update_shader() {\n \t\tcase BLEND_MODE_MUL:\n \t\t\tcode += \"blend_mul\";\n \t\t\tbreak;\n+\t\tcase BLEND_MODE_PREMULT_ALPHA:\n+\t\t\tcode += \"blend_premul_alpha\";",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-05-01T07:59:32Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2033193511,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:25.377Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 85386,
    "prTitle": "Improve SceneTreeEditor usability",
    "prAuthor": "RedMser",
    "prLink": "https://github.com/godotengine/godot/pull/85386",
    "commentAuthor": "bruvzg",
    "commentBody": "This PR seems to be causing crashes. Probably deferred call should use `ObjectID` instead of raw pointer, otherwise the tree item might be removed before callback execution and pointer will become invalid.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/85386#discussion_r1553057838",
    "filePath": "editor/gui/scene_tree_editor.cpp",
    "diffHunk": "@@ -925,6 +925,27 @@ void SceneTreeEditor::_notification(int p_what) {\n \n \t\t\t_update_tree();\n \t\t} break;\n+\n+\t\tcase NOTIFICATION_VISIBILITY_CHANGED: {\n+\t\t\tif (is_visible()) {\n+\t\t\t\tTreeItem *item = nullptr;\n+\t\t\t\tif (selected) {\n+\t\t\t\t\t// Scroll to selected node.\n+\t\t\t\t\titem = _find(tree->get_root(), selected->get_path());\n+\t\t\t\t} else if (marked.size() == 1) {\n+\t\t\t\t\t// Scroll to a single marked node.\n+\t\t\t\t\tNode *marked_node = *marked.begin();\n+\t\t\t\t\tif (marked_node) {\n+\t\t\t\t\t\titem = _find(tree->get_root(), marked_node->get_path());\n+\t\t\t\t\t}\n+\t\t\t\t}\n+\n+\t\t\t\tif (item) {\n+\t\t\t\t\t// Must wait until tree is properly sized before scrolling.\n+\t\t\t\t\tcallable_mp(tree, &Tree::scroll_to_item).call_deferred(item, true);",
    "line": 21,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 242413312,
        "node_id": "REA_lATOAO6SJc5ckcguzg5y7wA",
        "user": {
          "login": "Zireael07",
          "id": 4525388,
          "node_id": "MDQ6VXNlcjQ1MjUzODg=",
          "avatar_url": "https://avatars.githubusercontent.com/u/4525388?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/Zireael07",
          "html_url": "https://github.com/Zireael07",
          "followers_url": "https://api.github.com/users/Zireael07/followers",
          "following_url": "https://api.github.com/users/Zireael07/following{/other_user}",
          "gists_url": "https://api.github.com/users/Zireael07/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/Zireael07/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/Zireael07/subscriptions",
          "organizations_url": "https://api.github.com/users/Zireael07/orgs",
          "repos_url": "https://api.github.com/users/Zireael07/repos",
          "events_url": "https://api.github.com/users/Zireael07/events{/privacy}",
          "received_events_url": "https://api.github.com/users/Zireael07/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2024-04-05T07:22:11Z"
      }
    ],
    "timestamp": "2024-04-05T07:19:54Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1982165084,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:25.902Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 84643,
    "prTitle": "Fix `Node3D` children using `top_level` in different position in-editor versus runtime",
    "prAuthor": "rsburke4",
    "prLink": "https://github.com/godotengine/godot/pull/84643",
    "commentAuthor": "AThousandShips",
    "commentBody": "Came across this while looking at the code and this check is always false, should the code not be just:\r\n```suggestion\r\n\t\t\t\t\tdata.local_transform = get_transform();\r\n```\r\nWhich I'm not sure is even necessary?",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/godotengine/godot/pull/84643#discussion_r1533788641",
    "filePath": "scene/3d/node_3d.cpp",
    "diffHunk": "@@ -149,7 +149,11 @@ void Node3D::_notification(int p_what) {\n \n \t\t\tif (data.top_level && !Engine::get_singleton()->is_editor_hint()) {\n \t\t\t\tif (data.parent) {\n-\t\t\t\t\tdata.local_transform = data.parent->get_global_transform() * get_transform();\n+\t\t\t\t\tif (!data.top_level) {\n+\t\t\t\t\t\tdata.local_transform = data.parent->get_global_transform() * get_transform();\n+\t\t\t\t\t} else {\n+\t\t\t\t\t\tdata.local_transform = get_transform();\n+\t\t\t\t\t}",
    "line": 9,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-03-21T12:15:36Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1952035463,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:27.537Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 83786,
    "prTitle": "Fix ColorPicker committing extra action to history",
    "prAuthor": "aXu-AP",
    "prLink": "https://github.com/godotengine/godot/pull/83786",
    "commentAuthor": "bs-mwoerner",
    "commentBody": "I think this check may be too late here. At this point, the internal `color` state (that's a class member, not a local variable) has already been overwritten with the return value of `Color::from_string`, so this only skips the change notification, doesn't it?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/83786#discussion_r1424287250",
    "filePath": "scene/gui/color_picker.cpp",
    "diffHunk": "@@ -563,7 +563,7 @@ void ColorPicker::_html_submitted(const String &p_html) {\n \t\tcolor.a = previous_color.a;\n \t}\n \n-\tif (color == previous_color) {\n+\tif (color.to_abgr32() == previous_color.to_abgr32()) {",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-12-12T16:40:34Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1777982519,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:28.255Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 82459,
    "prTitle": "Fix buffered key events not marked as echo events on Linux",
    "prAuthor": "rsubtil",
    "prLink": "https://github.com/godotengine/godot/pull/82459",
    "commentAuthor": "Sauermann",
    "commentBody": "This function has the problem, that it returns `true`, whenever it finds the correct keycode. However in the case of a very long frame, multiple key-down + key-up events can happen and the current algorithm only checks if any key-down happens.\r\nWhat would rather need to happen is, that the `buffered_events` need to be checked from the end for `p_keycode` and returns a boolean based on if the most recend event was a key-down or a key-up.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/82459#discussion_r1387732982",
    "filePath": "core/input/input.cpp",
    "diffHunk": "@@ -270,6 +270,17 @@ bool Input::is_mouse_button_pressed(MouseButton p_button) const {\n \treturn mouse_button_mask.has_flag(mouse_button_to_mask(p_button));\n }\n \n+bool Input::is_buffered_key_pressed(Key p_keycode) const {\n+\t_THREAD_SAFE_METHOD_\n+\tfor (Ref<InputEvent> event : buffered_events) {\n+\t\tRef<InputEventKey> k = event;\n+\t\tif (k.is_valid() && k->get_keycode() == p_keycode && k->is_pressed()) {\n+\t\t\treturn true;\n+\t\t}\n+\t}",
    "line": 11,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-11-09T09:38:55Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1722107935,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:27.928Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 80440,
    "prTitle": "Add custom color support to project folders",
    "prAuthor": "the-sink",
    "prLink": "https://github.com/godotengine/godot/pull/80440",
    "commentAuthor": "KoBeWi",
    "commentBody": "`TTR(E.key.capitalize()))`\r\nThis is wrong. The color names need to be provided as explicit strings.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/80440#discussion_r1347567046",
    "filePath": "editor/filesystem_dock.cpp",
    "diffHunk": "@@ -2798,6 +2892,27 @@ void FileSystemDock::_file_and_folders_fill_popup(PopupMenu *p_popup, Vector<Str\n \t\t}\n \n \t\tp_popup->add_separator();\n+\n+\t\tif (p_paths[0] != \"res://\") {\n+\t\t\tPopupMenu *folder_colors_menu = memnew(PopupMenu);\n+\t\t\tfolder_colors_menu->set_name(\"FolderColor\");\n+\t\t\tfolder_colors_menu->connect(\"id_pressed\", callable_mp(this, &FileSystemDock::_folder_color_index_pressed).bind(folder_colors_menu));\n+\n+\t\t\tp_popup->add_child(folder_colors_menu);\n+\t\t\tp_popup->add_submenu_item(TTR(\"Set Folder Color...\"), \"FolderColor\");\n+\t\t\tp_popup->set_item_icon(-1, get_theme_icon(SNAME(\"CanvasItem\"), SNAME(\"EditorIcons\")));\n+\n+\t\t\tfolder_colors_menu->add_icon_item(get_theme_icon(SNAME(\"Folder\"), SNAME(\"EditorIcons\")), TTR(\"Default (Reset)\"));\n+\t\t\tfolder_colors_menu->set_item_icon_modulate(0, get_theme_color(SNAME(\"folder_icon_color\"), SNAME(\"FileDialog\")));\n+\t\t\tfolder_colors_menu->add_separator();\n+\n+\t\t\tfor (const KeyValue<String, Color> &E : folder_colors) {\n+\t\t\t\tfolder_colors_menu->add_icon_item(get_theme_icon(SNAME(\"Folder\"), SNAME(\"EditorIcons\")), TTR(E.key.capitalize()));",
    "line": 229,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 220944403,
        "node_id": "REA_lATOAO6SJc5QUj3Gzg0rWBM",
        "user": {
          "login": "AThousandShips",
          "id": 96648715,
          "node_id": "U_kgDOBcK-Cw",
          "avatar_url": "https://avatars.githubusercontent.com/u/96648715?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/AThousandShips",
          "html_url": "https://github.com/AThousandShips",
          "followers_url": "https://api.github.com/users/AThousandShips/followers",
          "following_url": "https://api.github.com/users/AThousandShips/following{/other_user}",
          "gists_url": "https://api.github.com/users/AThousandShips/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/AThousandShips/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/AThousandShips/subscriptions",
          "organizations_url": "https://api.github.com/users/AThousandShips/orgs",
          "repos_url": "https://api.github.com/users/AThousandShips/repos",
          "events_url": "https://api.github.com/users/AThousandShips/events{/privacy}",
          "received_events_url": "https://api.github.com/users/AThousandShips/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2023-10-05T15:01:22Z"
      }
    ],
    "timestamp": "2023-10-05T14:59:59Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1660100093,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:29.797Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 73953,
    "prTitle": "Implement column title alignment for Tree",
    "prAuthor": "Barugon",
    "prLink": "https://github.com/godotengine/godot/pull/73953",
    "commentAuthor": "bruvzg",
    "commentBody": "Left/Right should be swapped if `cache.rtl` is `true`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/73953#discussion_r1119640201",
    "filePath": "scene/gui/tree.cpp",
    "diffHunk": "@@ -4045,7 +4045,24 @@ void Tree::_notification(int p_what) {\n \t\t\t\t\tint clip_w = tbrect.size.width - sb->get_minimum_size().width;\n \t\t\t\t\tcolumns.write[i].text_buf->set_width(clip_w);\n \n-\t\t\t\t\tVector2 text_pos = tbrect.position + Point2i(sb->get_offset().x + (tbrect.size.width - columns[i].text_buf->get_size().x) / 2, (tbrect.size.height - columns[i].text_buf->get_size().y) / 2);\n+\t\t\t\t\tVector2 text_pos;\n+\t\t\t\t\tswitch (columns[i].title_alignment) {",
    "line": 6,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-02-28T06:54:53Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1316896656,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:29.784Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 63369,
    "prTitle": "added Curve in state machine interpolation",
    "prAuthor": "jeronimo-schreyer",
    "prLink": "https://github.com/godotengine/godot/pull/63369",
    "commentAuthor": "TokageItLab",
    "commentBody": "Interpolation calculation is wrong; you only need to overwrite blend with curve.\r\n\r\nSuggestion:\r\n```cpp\r\n\t} else { // cross-fading from prev to current\r\n\r\n\t\tfloat blend = xfade_time == 0 ? 0 : (prev_xfading / xfade_time);\r\n\t\tif (xfade_curve.is_valid()) {\r\n\t\t\tblend = xfade_curve->interpolate(blend);\r\n\t\t}\r\n\r\n\t\tif (from_start && !p_seek && switched) { //just switched, seek to start of current\r\n\r\n\t\t\trem = blend_input(current, 0, true, p_seek_root, 1.0 - blend, FILTER_IGNORE, true);\r\n\t\t} else {\r\n\t\t\trem = blend_input(current, p_time, p_seek, p_seek_root, 1.0 - blend, FILTER_IGNORE, true);\r\n\t\t}\r\n\r\n\t\tif (p_seek) {\r\n\t\t\tblend_input(prev, p_time, true, p_seek_root, blend, FILTER_IGNORE, true);\r\n\t\t\ttime = p_time;\r\n\t\t} else {\r\n\t\t\tblend_input(prev, p_time, false, p_seek_root, blend, FILTER_IGNORE, true);\r\n\t\t\ttime += p_time;\r\n\t\t\tprev_xfading -= p_time;\r\n\t\t\tif (prev_xfading < 0) {\r\n\t\t\t\tset_parameter(this->prev, -1);\r\n\t\t\t}\r\n\t\t}\r\n\t}\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/godotengine/godot/pull/63369#discussion_r931903723",
    "filePath": "scene/animation/animation_blend_tree.cpp",
    "diffHunk": "@@ -734,26 +742,27 @@ double AnimationNodeTransition::process(double p_time, bool p_seek, bool p_seek_\n \t\t\ttime += p_time;\n \t\t}\n \n-\t\tif (inputs[current].auto_advance && rem <= xfade) {\n+\t\tif (inputs[current].auto_advance && rem <= xfade_time) {\n \t\t\tset_parameter(this->current, (current + 1) % enabled_inputs);\n \t\t}\n \n \t} else { // cross-fading from prev to current\n \n-\t\tfloat blend = xfade == 0 ? 0 : (prev_xfading / xfade);\n+\t\tfloat blend = xfade_time == 0 ? 0 : (prev_xfading / xfade_time);\n+\t\tfloat curved_blend = (xfade_curve.is_valid()) ? xfade_curve->interpolate(1.0 - blend) : 1.0 - blend;\n \n \t\tif (from_start && !p_seek && switched) { //just switched, seek to start of current\n-\n-\t\t\trem = blend_input(current, 0, true, p_seek_root, 1.0 - blend, FILTER_IGNORE, true);\n+\t\t\trem = blend_input(current, 0, true, p_seek_root, curved_blend, FILTER_IGNORE, true);\n \t\t} else {\n-\t\t\trem = blend_input(current, p_time, p_seek, p_seek_root, 1.0 - blend, FILTER_IGNORE, true);\n+\t\t\trem = blend_input(current, p_time, p_seek, p_seek_root, curved_blend, FILTER_IGNORE, true);\n \t\t}\n \n+\t\tcurved_blend = (xfade_curve.is_valid()) ? xfade_curve->interpolate(blend) : blend;\n \t\tif (p_seek) {\n-\t\t\tblend_input(prev, p_time, true, p_seek_root, blend, FILTER_IGNORE, true);\n+\t\t\tblend_input(prev, p_time, true, p_seek_root, curved_blend, FILTER_IGNORE, true);\n \t\t\ttime = p_time;\n \t\t} else {\n-\t\t\tblend_input(prev, p_time, false, p_seek_root, blend, FILTER_IGNORE, true);\n+\t\t\tblend_input(prev, p_time, false, p_seek_root, curved_blend, FILTER_IGNORE, true);",
    "line": 65,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-07-28T08:01:53Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1053651410,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:31.843Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 63306,
    "prTitle": "Verify and record viewport visibility",
    "prAuthor": "Rindbee",
    "prLink": "https://github.com/godotengine/godot/pull/63306",
    "commentAuthor": "BastiaanOlij",
    "commentBody": "~~Should change this to `if (p_viewport->use_xr && p_xr_interface.is_valid()) {`\r\nThen we can put some of the other checks inside of an `else`. With XR viewports we ignore `update_mode`.~~\r\n\r\nActually scratch that, if `use_xr` is true and `p_xr_interface` is not valid, the viewport should not be drawn. Sorry I forgot about that.\r\n\r\nStill a good idea to put the other checks in an `else`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/63306#discussion_r931706071",
    "filePath": "servers/rendering/renderer_viewport.cpp",
    "diffHunk": "@@ -526,6 +526,67 @@ void RendererViewport::_draw_viewport(Viewport *p_viewport) {\n \t}\n }\n \n+bool RendererViewport::_check_viewport_visible(Viewport *p_viewport, const uint64_t p_pass, Ref<XRInterface> &p_xr_interface) {\n+\tif (p_viewport->last_pass == p_pass && p_pass) {\n+\t\treturn p_viewport->visible; // Returns the computed cached value.\n+\t}\n+\n+\tp_viewport->last_pass = p_pass;\n+\tp_viewport->visible = false;\n+\n+\tif (p_viewport->update_mode == RS::VIEWPORT_UPDATE_DISABLED) {\n+\t\treturn false;\n+\t}\n+\n+\tif (!p_viewport->render_target.is_valid()) {\n+\t\treturn false;\n+\t}\n+\t//ERR_CONTINUE(!p_viewport->render_target.is_valid());\n+\n+\tp_viewport->visible = p_viewport->viewport_to_screen_rect != Rect2();\n+\n+\tif (p_viewport->use_xr) {\n+\t\tif (p_xr_interface.is_valid()) {",
    "line": 24,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-07-28T01:34:30Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1053386950,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:31.822Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 60597,
    "prTitle": "Implement missing Node & Resource placeholders",
    "prAuthor": "reduz",
    "prLink": "https://github.com/godotengine/godot/pull/60597",
    "commentAuthor": "nikitalita",
    "commentBody": "If the intent is to check if the parent is NOT missing resource, this should be `missing_resource == nullptr`. \r\nCurrently, if the parent is not a missing resource, this block will be skipped, the property will be set to the missing resource and will probably fail",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/60597#discussion_r1437969244",
    "filePath": "core/io/resource_format_binary.cpp",
    "diffHunk": "@@ -775,8 +788,32 @@ Error ResourceLoaderBinary::load() {\n \t\t\t\treturn error;\n \t\t\t}\n \n-\t\t\tres->set(name, value);\n+\t\t\tbool set_valid = true;\n+\t\t\tif (value.get_type() == Variant::OBJECT && missing_resource != nullptr) {",
    "line": 49,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-12-29T03:46:32Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1798576158,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:34.123Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 60309,
    "prTitle": "Octahedral Normal/Tangent Compression",
    "prAuthor": "The-O-King",
    "prLink": "https://github.com/godotengine/godot/pull/60309",
    "commentAuthor": "nikitalita",
    "commentBody": "You changed the offset value here; we're getting 2 bytes from `src` here (src is `int8_t`, and we're getting `src[0]` and `src[1]`), so the source offset needs to be incremented by 2 bytes. You're incrementing by 4 bytes here.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/60309#discussion_r1017101020",
    "filePath": "scene/resources/mesh.cpp",
    "diffHunk": "@@ -954,127 +933,93 @@ void _fix_array_compatibility(const Vector<uint8_t> &p_src, uint32_t p_old_forma\n \t\t\t\t\tif ((p_old_format & OLD_ARRAY_COMPRESS_NORMAL) && (p_old_format & OLD_ARRAY_FORMAT_TANGENT) && (p_old_format & OLD_ARRAY_COMPRESS_TANGENT)) {\n \t\t\t\t\t\tfor (uint32_t i = 0; i < p_elements; i++) {\n \t\t\t\t\t\t\tconst int8_t *src = (const int8_t *)&src_vertex_ptr[i * src_vertex_stride + src_offset];\n-\t\t\t\t\t\t\tuint32_t *dst = (uint32_t *)&dst_vertex_ptr[i * dst_vertex_stride + dst_offsets[Mesh::ARRAY_NORMAL]];\n-\t\t\t\t\t\t\tconst Vector2 src_vec(src[0] / 127.0f, src[1] / 127.0f);\n-\n-\t\t\t\t\t\t\tconst Vector3 res = _oct_to_norm(src_vec) * Vector3(0.5, 0.5, 0.5) + Vector3(0.5, 0.5, 0.5);\n-\t\t\t\t\t\t\t*dst = 0;\n-\t\t\t\t\t\t\t*dst |= CLAMP(int(res.x * 1023.0f), 0, 1023);\n-\t\t\t\t\t\t\t*dst |= CLAMP(int(res.y * 1023.0f), 0, 1023) << 10;\n-\t\t\t\t\t\t\t*dst |= CLAMP(int(res.z * 1023.0f), 0, 1023) << 20;\n+\t\t\t\t\t\t\tint16_t *dst = (int16_t *)&dst_vertex_ptr[i * dst_vertex_stride + dst_offsets[Mesh::ARRAY_NORMAL]];\n+\n+\t\t\t\t\t\t\tdst[0] = (int16_t)CLAMP(src[0] / 127.0f * 32767, -32768, 32767);\n+\t\t\t\t\t\t\tdst[1] = (int16_t)CLAMP(src[1] / 127.0f * 32767, -32768, 32767);\n \t\t\t\t\t\t}\n-\t\t\t\t\t\tsrc_offset += sizeof(int8_t) * 2;\n+\t\t\t\t\t\tsrc_offset += sizeof(int16_t) * 2;",
    "line": 46,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-11-08T20:51:33Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1172819018,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:35.877Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 59739,
    "prTitle": "Added Dependency Detection to Fix Nix Flake builds",
    "prAuthor": "IllustratedMan-code",
    "prLink": "https://github.com/godotengine/godot/pull/59739",
    "commentAuthor": "akien-mga",
    "commentBody": "This is invalid, alsa is `dlopen`'ed so it shouldn't be linked.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/59739#discussion_r839784449",
    "filePath": "platform/linuxbsd/detect.py",
    "diffHunk": "@@ -318,6 +321,7 @@ def configure(env):\n     if os.system(\"pkg-config --exists alsa\") == 0:  # 0 means found\n         env[\"alsa\"] = True\n         env.Append(CPPDEFINES=[\"ALSA_ENABLED\", \"ALSAMIDI_ENABLED\"])\n+        env.ParseConfig(\"pkg-config alsa --cflags --libs\")",
    "line": 14,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-03-31T16:05:44Z",
    "isReviewComment": true,
    "pullRequestReviewId": 927845477,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:35.654Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 57063,
    "prTitle": "`SpriteFramesEditor` Show `AtlasTexture`'s source texture path in the frame's tooltip",
    "prAuthor": "kleonc",
    "prLink": "https://github.com/godotengine/godot/pull/57063",
    "commentAuthor": "akien-mga",
    "commentBody": "`SpriteFrames::get_frame()` does return `Texture2D`, this change was wrong.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/57063#discussion_r791946638",
    "filePath": "editor/plugins/sprite_frames_editor_plugin.cpp",
    "diffHunk": "@@ -821,19 +821,30 @@ void SpriteFramesEditor::_update_library(bool p_skip_selector) {\n \n \tfor (int i = 0; i < frames->get_frame_count(edited_anim); i++) {\n \t\tString name;\n-\t\tRef<Texture2D> icon;\n+\t\tRef<Texture> frame = frames->get_frame(edited_anim, i);",
    "line": 5,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 146262281,
        "node_id": "REA_lATOAO6SJc4vNCWOzgi3yQk",
        "user": {
          "login": "kleonc",
          "id": 9283098,
          "node_id": "MDQ6VXNlcjkyODMwOTg=",
          "avatar_url": "https://avatars.githubusercontent.com/u/9283098?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/kleonc",
          "html_url": "https://github.com/kleonc",
          "followers_url": "https://api.github.com/users/kleonc/followers",
          "following_url": "https://api.github.com/users/kleonc/following{/other_user}",
          "gists_url": "https://api.github.com/users/kleonc/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/kleonc/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/kleonc/subscriptions",
          "organizations_url": "https://api.github.com/users/kleonc/orgs",
          "repos_url": "https://api.github.com/users/kleonc/repos",
          "events_url": "https://api.github.com/users/kleonc/events{/privacy}",
          "received_events_url": "https://api.github.com/users/kleonc/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2022-01-25T17:37:01Z"
      }
    ],
    "timestamp": "2022-01-25T17:16:44Z",
    "isReviewComment": true,
    "pullRequestReviewId": 862618093,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:37.516Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 55066,
    "prTitle": "Store panels and docks instances in their classes",
    "prAuthor": "trollodel",
    "prLink": "https://github.com/godotengine/godot/pull/55066",
    "commentAuthor": "TokageItLab",
    "commentBody": "It caused bug, since `editor->get_inspector()` and `editor->get_inspector_dock()` is different.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/55066#discussion_r789385482",
    "filePath": "editor/plugins/animation_player_editor_plugin.cpp",
    "diffHunk": "@@ -1794,9 +1794,9 @@ void AnimationPlayerEditorPlugin::_notification(int p_what) {\n \tswitch (p_what) {\n \t\tcase NOTIFICATION_ENTER_TREE: {\n \t\t\tNode3DEditor::get_singleton()->connect(\"transform_key_request\", callable_mp(this, &AnimationPlayerEditorPlugin::_transform_key_request));\n-\t\t\teditor->get_inspector()->connect(\"property_keyed\", callable_mp(this, &AnimationPlayerEditorPlugin::_property_keyed));\n+\t\t\tInspectorDock::get_singleton()->connect(\"property_keyed\", callable_mp(this, &AnimationPlayerEditorPlugin::_property_keyed));",
    "line": 14,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-01-21T06:12:18Z",
    "isReviewComment": true,
    "pullRequestReviewId": 859143285,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:37.627Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 50964,
    "prTitle": "feat: add HTTPClient implementation using curl as a module",
    "prAuthor": "jonbonazza",
    "prLink": "https://github.com/godotengine/godot/pull/50964",
    "commentAuthor": "Faless",
    "commentBody": "Here, we don't want to set the ip address as the `CURLOPT_URL` but the actual hostname (this is what will be used for the `Host: hostname:port` header).",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/50964#discussion_r723252880",
    "filePath": "modules/mbedtls_curl/http_client_curl.cpp",
    "diffHunk": "@@ -0,0 +1,440 @@\n+/*************************************************************************/\n+/*  http_client_curl.cpp                                                 */\n+/*************************************************************************/\n+/*                       This file is part of:                           */\n+/*                           GODOT ENGINE                                */\n+/*                      https://godotengine.org                          */\n+/*************************************************************************/\n+/* Copyright (c) 2007-2021 Juan Linietsky, Ariel Manzur.                 */\n+/* Copyright (c) 2014-2021 Godot Engine contributors (cf. AUTHORS.md).   */\n+/*                                                                       */\n+/* Permission is hereby granted, free of charge, to any person obtaining */\n+/* a copy of this software and associated documentation files (the       */\n+/* \"Software\"), to deal in the Software without restriction, including   */\n+/* without limitation the rights to use, copy, modify, merge, publish,   */\n+/* distribute, sublicense, and/or sell copies of the Software, and to    */\n+/* permit persons to whom the Software is furnished to do so, subject to */\n+/* the following conditions:                                             */\n+/*                                                                       */\n+/* The above copyright notice and this permission notice shall be        */\n+/* included in all copies or substantial portions of the Software.       */\n+/*                                                                       */\n+/* THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND,       */\n+/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF    */\n+/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.*/\n+/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY  */\n+/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,  */\n+/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE     */\n+/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.                */\n+/*************************************************************************/\n+\n+#include \"http_client_curl.h\"\n+\n+#include \"core/string/print_string.h\"\n+#include \"core/templates/ring_buffer.h\"\n+\n+char const *HTTPClientCurl::methods[10] = {\n+\t\"GET\",\n+\t\"HEAD\",\n+\t\"POST\",\n+\t\"PUT\",\n+\t\"DELETE\",\n+\t\"OPTIONS\",\n+\t\"TRACE\",\n+\t\"CONNECT\",\n+\t\"PATCH\",\n+\t\"MAX\",\n+};\n+\n+RequestContext::~RequestContext() {\n+\tif (header_list) {\n+\t\tmemfree(header_list);\n+\t\theader_list = nullptr;\n+\t}\n+\tif (read_buffer) {\n+\t\tmemfree(read_buffer);\n+\t\tread_buffer = nullptr;\n+\t}\n+}\n+\n+HTTPClient *HTTPClientCurl::_create_func() {\n+\treturn memnew(HTTPClientCurl);\n+}\n+\n+size_t HTTPClientCurl::_header_callback(char *buffer, size_t size, size_t nitems, void *userdata) {\n+\tRequestContext *ctx = (RequestContext *)userdata;\n+\tString s((const char *)buffer);\n+\tVector<String> parts = s.split(\":\");\n+\tif (parts.size() != 2) {\n+\t\treturn size * nitems;\n+\t}\n+\n+\tctx->response_headers->push_back(s);\n+\n+\tString header = parts[0].to_lower();\n+\tString val = parts[1];\n+\t// Trim any whitespace prefix\n+\twhile (val.begins_with(\" \")) {\n+\t\tval = val.trim_prefix(\" \");\n+\t}\n+\n+\t// Use the content length to determine body size.\n+\tif (header == \"content-length\") {\n+\t\t*(ctx->body_size) = val.to_int();\n+\t}\n+\n+\t// If the Connection header is set to \"close\" then\n+\t// keep-alive isn't enabled.\n+\tif (header == \"connection\" && val == \"close\") {\n+\t\t*(ctx->keep_alive) = false;\n+\t}\n+\n+\tif (header == \"transfer-encoding\" && val == \"chunked\") {\n+\t\t*(ctx->body_size) = -1;\n+\t\t*(ctx->chunked) = true;\n+\t}\n+\n+\t*(ctx->has_response) = true;\n+\n+\treturn size * nitems;\n+}\n+\n+size_t HTTPClientCurl::_read_callback(char *buffer, size_t size, size_t nitems, void *userdata) {\n+\tRingBuffer<uint8_t> *b = (RingBuffer<uint8_t> *)userdata;\n+\tint n = b->copy((uint8_t *)buffer, 0, size * nitems);\n+\treturn n;\n+}\n+\n+size_t HTTPClientCurl::_write_callback(char *buffer, size_t size, size_t nitems, void *userdata) {\n+\tRequestContext *ctx = (RequestContext *)userdata;\n+\tPackedByteArray chunk;\n+\tchunk.resize(size * nitems);\n+\tmemcpy(chunk.ptrw(), buffer, size * nitems);\n+\tctx->response_chunks->append(chunk);\n+\t*(ctx->status) = STATUS_BODY;\n+\n+\treturn size * nitems;\n+}\n+\n+curl_slist *HTTPClientCurl::_ip_addr_to_slist(const IPAddress &p_addr) {\n+\tString addr = String(p_addr);\n+\tif (addr.find(\":\") != -1) {\n+\t\taddr = \"[\" + addr + \"]\";\n+\t}\n+\tString h = host + \":\" + String::num_int64(port) + \":\" + addr;\n+\treturn curl_slist_append(nullptr, h.ascii().get_data());\n+}\n+\n+String HTTPClientCurl::_hostname_from_url(const String &p_url) {\n+\tString hostname = p_url.trim_prefix(\"http://\");\n+\thostname = hostname.trim_prefix(\"https://\");\n+\treturn hostname.split(\"/\")[0];\n+}\n+\n+Error HTTPClientCurl::_resolve_dns() {\n+\tIP::ResolverStatus rstatus = IP::get_singleton()->get_resolve_item_status(resolver_id);\n+\tswitch (rstatus) {\n+\t\tcase IP::RESOLVER_STATUS_WAITING:\n+\t\t\treturn OK;\n+\t\tcase IP::RESOLVER_STATUS_DONE: {\n+\t\t\tIPAddress addr = IP::get_singleton()->get_resolve_item_address(resolver_id);\n+\n+\t\t\tError err = _request(addr, true);\n+\n+\t\t\tIP::get_singleton()->erase_resolve_item(resolver_id);\n+\t\t\tresolver_id = IP::RESOLVER_INVALID_ID;\n+\n+\t\t\tif (err != OK) {\n+\t\t\t\tstatus = STATUS_CANT_CONNECT;\n+\t\t\t\treturn err;\n+\t\t\t}\n+\t\t\treturn OK;\n+\t\t} break;\n+\t\tcase IP::RESOLVER_STATUS_NONE:\n+\t\tcase IP::RESOLVER_STATUS_ERROR: {\n+\t\t\tIP::get_singleton()->erase_resolve_item(resolver_id);\n+\t\t\tresolver_id = IP::RESOLVER_INVALID_ID;\n+\t\t\tclose();\n+\t\t\tstatus = STATUS_CANT_RESOLVE;\n+\t\t\treturn ERR_CANT_RESOLVE;\n+\t\t} break;\n+\t}\n+\n+\treturn OK;\n+}\n+\n+Error HTTPClientCurl::_poll_curl() {\n+\tCURLMcode rc = curl_multi_perform(curl, &still_running);\n+\tif (still_running) {\n+\t\trc = curl_multi_wait(curl, nullptr, 0, 1000, nullptr);\n+\t}\n+\n+\tif (rc != CURLM_OK) {\n+\t\tERR_PRINT_ONCE(\"Curl multi error while performing. RC: \" + String::num_int64(rc));\n+\t\treturn FAILED;\n+\t}\n+\n+\tif (still_running == 0) {\n+\t\tint n = 0;\n+\t\tCURLMsg *msg = curl_multi_info_read(curl, &n);\n+\t\tif (msg && msg->msg == CURLMSG_DONE) {\n+\t\t\tif (msg->data.result != CURLE_OK) {\n+\t\t\t\tERR_PRINT_ONCE(\"Curl result failed. RC: \" + String::num_int64(msg->data.result));\n+\t\t\t\tstatus = STATUS_DISCONNECTED;\n+\t\t\t\treturn FAILED;\n+\t\t\t}\n+\t\t\tRequestContext *ctx;\n+\t\t\tCURLcode return_code = curl_easy_getinfo(msg->easy_handle, CURLINFO_RESPONSE_CODE, &response_code);\n+\t\t\tif (return_code != CURLE_OK) {\n+\t\t\t\tERR_PRINT_ONCE(\"Couldnt get curl status code. RC:\" + String::num_int64(return_code));\n+\t\t\t\treturn FAILED;\n+\t\t\t}\n+\t\t\tcurl_easy_getinfo(msg->easy_handle, CURLINFO_PRIVATE, &ctx);\n+\n+\t\t\tmemfree(ctx);\n+\n+\t\t\tcurl_multi_remove_handle(curl, msg->easy_handle);\n+\t\t\tcurl_easy_cleanup(msg->easy_handle);\n+\t\t\tin_flight = false;\n+\t\t}\n+\t}\n+\treturn OK;\n+}\n+\n+RingBuffer<uint8_t> *HTTPClientCurl::_init_upload(CURL *p_chandle, Method p_method, uint8_t *p_body, int p_body_size) {\n+\tRingBuffer<uint8_t> *b = memnew(RingBuffer<uint8_t>);\n+\tb->resize(p_body_size);\n+\tb->write(p_body, p_body_size);\n+\n+\t// Special cases for POST and PUT to configure uploads.\n+\tswitch (p_method) {\n+\t\tcase METHOD_GET:\n+\t\t\tbreak;\n+\t\tcase METHOD_HEAD:\n+\t\t\tbreak;\n+\t\tcase METHOD_POST:\n+\t\t\tcurl_easy_setopt(p_chandle, CURLOPT_POST, 1L);\n+\t\t\tcurl_easy_setopt(p_chandle, CURLOPT_POSTFIELDSIZE_LARGE, (curl_off_t)p_body_size);\n+\t\t\tbreak;\n+\t\tcase METHOD_PUT:\n+\t\t\tcurl_easy_setopt(p_chandle, CURLOPT_UPLOAD, 1L);\n+\t\t\tcurl_easy_setopt(p_chandle, CURLOPT_INFILESIZE_LARGE, (curl_off_t)p_body_size);\n+\t\t\tbreak;\n+\t\tcase METHOD_DELETE:\n+\t\t\tbreak;\n+\t\tcase METHOD_OPTIONS:\n+\t\t\tbreak;\n+\t\tcase METHOD_TRACE:\n+\t\t\tbreak;\n+\t\tcase METHOD_CONNECT:\n+\t\t\tbreak;\n+\t\tcase METHOD_PATCH:\n+\t\t\tbreak;\n+\t\tcase METHOD_MAX:\n+\t\t\tbreak;\n+\t}\n+\n+\t// Somewhat counter intuitively, the read function is actually used by libcurl to send data,\n+\t// while the write function (see below) is used by libcurl to write response data to storage\n+\t// (or in our case, memory).\n+\tcurl_easy_setopt(p_chandle, CURLOPT_READFUNCTION, _read_callback);\n+\tcurl_easy_setopt(p_chandle, CURLOPT_READDATA, b);\n+\treturn b;\n+}\n+\n+RequestContext *HTTPClientCurl::_create_request_context() {\n+\tRequestContext *ctx = memnew(RequestContext);\n+\tctx->response_headers = &response_headers;\n+\tctx->body_size = &body_size;\n+\tctx->status = &status;\n+\tctx->response_chunks = &response_chunks;\n+\tctx->has_response = &response_available;\n+\tctx->chunked = &chunked;\n+\tctx->keep_alive = &keep_alive;\n+\treturn ctx;\n+}\n+\n+Error HTTPClientCurl::_init_dns(CURL *p_chandle, IPAddress p_addr) {\n+\t// TODO: Support resolving multiple addresses.\n+\tcurl_slist *h = _ip_addr_to_slist(p_addr);\n+\tCURLcode return_code = curl_easy_setopt(p_chandle, CURLOPT_RESOLVE, h);\n+\tif (return_code != CURLE_OK) {\n+\t\tERR_PRINT(\"failed to initialize dns resolver: \" + String::num_int64(return_code));\n+\t\treturn FAILED;\n+\t}\n+\treturn OK;\n+}\n+\n+Error HTTPClientCurl::_init_request_headers(CURL *p_chandler, Vector<String> p_headers, RequestContext *p_ctx) {\n+\tfor (int i = 0; i < p_headers.size(); i++) {\n+\t\tp_ctx->header_list = curl_slist_append(p_ctx->header_list, p_headers[i].ascii().get_data());\n+\t}\n+\tif (p_ctx->header_list) {\n+\t\tCURLcode return_code = curl_easy_setopt(p_chandler, CURLOPT_HTTPHEADER, p_ctx->header_list);\n+\t\tif (return_code != CURLE_OK) {\n+\t\t\tERR_PRINT(\"failed to set request headers: \" + String::num_uint64(return_code));\n+\t\t\treturn FAILED;\n+\t\t}\n+\t}\n+\treturn OK;\n+}\n+\n+Error HTTPClientCurl::_request(IPAddress p_addr, bool p_init_dns) {\n+\tString h = p_addr;\n+\tif (h.find(\":\") != -1) {\n+\t\th = \"[\" + h + \"]\";\n+\t}\n+\tCURL *eh = curl_easy_init();\n+\tcurl_easy_setopt(eh, CURLOPT_URL, (scheme + h + \":\" + String::num_int64(port) + url).ascii().get_data());",
    "line": 347,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-10-06T13:18:46Z",
    "isReviewComment": true,
    "pullRequestReviewId": 772682578,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:37.652Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 49373,
    "prTitle": "Remove an unreachable string from the \"Open Scene\" popup.",
    "prAuthor": "Riteo",
    "prLink": "https://github.com/godotengine/godot/pull/49373",
    "commentAuthor": "akien-mga",
    "commentBody": "Well it's used by `case FILE_NEW_INHERITED_SCENE:`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/49373#discussion_r646335178",
    "filePath": "editor/editor_node.cpp",
    "diffHunk": "@@ -2367,7 +2367,7 @@ void EditorNode::_menu_option_confirm(int p_option, bool p_confirmed) {\n \t\t\tif (scene) {\n \t\t\t\tfile->set_current_path(scene->get_filename());\n \t\t\t};\n-\t\t\tfile->set_title(p_option == FILE_OPEN_SCENE ? TTR(\"Open Scene\") : TTR(\"Open Base Scene\"));",
    "line": 4,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-06-07T07:27:59Z",
    "isReviewComment": true,
    "pullRequestReviewId": 677070964,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:38.438Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 47508,
    "prTitle": "Fix Bullet Physics Server",
    "prAuthor": "kalysti",
    "prLink": "https://github.com/godotengine/godot/pull/47508",
    "commentAuthor": "pouleyKetchoupp",
    "commentBody": "The `return` should be still there even if it doesn't return any value. The point is to stop creating the joint to avoid crashes.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/47508#discussion_r607949854",
    "filePath": "modules/bullet/bullet_physics_server.cpp",
    "diffHunk": "@@ -46,81 +46,87 @@\n #include <assert.h>\n \n /**\n-\t@author AndreaCatania\n+\t@author AndreaCatania && sboronczyk\n */\n \n-#define CreateThenReturnRID(owner, ridData) \\\n-\tRID rid = owner.make_rid(ridData);      \\\n-\tridData->set_self(rid);                 \\\n-\tridData->_set_physics_server(this);     \\\n+#define CreateRID(owner, ridData)      \\\n+\tRID rid = owner.make_rid(ridData); \\\n+\tridData->set_self(rid);            \\\n+\tridData->_set_physics_server(this);\n+\n+#define CreateRIDReturn(owner, ridData) \\\n+\tRID rid = owner.make_rid(ridData);  \\\n+\tridData->set_self(rid);             \\\n+\tridData->_set_physics_server(this); \\\n \treturn rid;\n \n-// <--------------- Joint creation asserts\n-/// Assert the body is assigned to a space\n-#define JointAssertSpace(body, bIndex, ret)                                                          \\\n-\tif (!body->get_space()) {                                                                        \\\n-\t\tERR_PRINT(\"Before create a joint the Body\" + String(bIndex) + \" must be added to a space!\"); \\\n-\t\treturn ret;                                                                                  \\\n+#define JointAssertSpace(body, bIndex, ret)                                                           \\\n+\tif (!body->get_space()) {                                                                         \\\n+\t\tERR_PRINTS(\"Before create a joint the Body\" + String(bIndex) + \" must be added to a space!\"); \\\n \t}\n \n /// Assert the two bodies of joint are in the same space\n #define JointAssertSameSpace(bodyA, bodyB, ret)                                                   \\\n \tif (bodyA->get_space() != bodyB->get_space()) {                                               \\\n \t\tERR_PRINT(\"In order to create a joint the Body_A and Body_B must be in the same space!\"); \\\n-\t\treturn RID();                                                                             \\",
    "line": 34,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-04-06T15:23:26Z",
    "isReviewComment": true,
    "pullRequestReviewId": 629083913,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:40.337Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 43914,
    "prTitle": "GDScript: range function type check bug fixed",
    "prAuthor": "ThakeeNathees",
    "prLink": "https://github.com/godotengine/godot/pull/43914",
    "commentAuthor": "Anutrix",
    "commentBody": "Both if and else blocks do the exact same thing.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/43914#discussion_r531780343",
    "filePath": "modules/gdscript/gdscript_analyzer.cpp",
    "diffHunk": "@@ -983,12 +983,14 @@ void GDScriptAnalyzer::resolve_for(GDScriptParser::ForNode *p_for) {\n \t\t\t\t\t\t}\n \n \t\t\t\t\t\tGDScriptParser::DataType arg_type = call->arguments[i]->get_datatype();\n-\t\t\t\t\t\tif (arg_type.kind != GDScriptParser::DataType::BUILTIN) {\n-\t\t\t\t\t\t\tall_is_constant = false;\n-\t\t\t\t\t\t\tpush_error(vformat(R\"*(Invalid argument for \"range()\" call. Argument %d should be int or float but \"%s\" was given.)*\", i + 1, arg_type.to_string()), call->arguments[i]);\n-\t\t\t\t\t\t} else if (arg_type.builtin_type != Variant::INT && arg_type.builtin_type != Variant::FLOAT) {\n-\t\t\t\t\t\t\tall_is_constant = false;\n-\t\t\t\t\t\t\tpush_error(vformat(R\"*(Invalid argument for \"range()\" call. Argument %d should be int or float but \"%s\" was given.)*\", i + 1, arg_type.to_string()), call->arguments[i]);\n+\t\t\t\t\t\tif (!arg_type.is_variant()) {\n+\t\t\t\t\t\t\tif (arg_type.kind != GDScriptParser::DataType::BUILTIN) {\n+\t\t\t\t\t\t\t\tall_is_constant = false;\n+\t\t\t\t\t\t\t\tpush_error(vformat(R\"*(Invalid argument for \"range()\" call. Argument %d should be int or float but \"%s\" was given.)*\", i + 1, arg_type.to_string()), call->arguments[i]);\n+\t\t\t\t\t\t\t} else if (arg_type.builtin_type != Variant::INT && arg_type.builtin_type != Variant::FLOAT) {",
    "line": 14,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-11-27T20:38:20Z",
    "isReviewComment": true,
    "pullRequestReviewId": 540185577,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:40.337Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 43403,
    "prTitle": "Refactored variant constructor logic",
    "prAuthor": "reduz",
    "prLink": "https://github.com/godotengine/godot/pull/43403",
    "commentAuthor": "bruvzg",
    "commentBody": "```\r\nERROR: Condition \"register_funcs.has(p_name)\" is true.\r\n   at: add_register_func (modules/visual_script/visual_script.cpp:2713)\r\n```\r\n\r\n`PackedFloat64Array` constructor is added twice, instead of `PackedFloat32Array`.\r\n",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/godotengine/godot/pull/43403#discussion_r519920314",
    "filePath": "core/variant/variant_construct.cpp",
    "diffHunk": "@@ -0,0 +1,781 @@\n+/*************************************************************************/\n+/*  variant_construct.cpp                                                */\n+/*************************************************************************/\n+/*                       This file is part of:                           */\n+/*                           GODOT ENGINE                                */\n+/*                      https://godotengine.org                          */\n+/*************************************************************************/\n+/* Copyright (c) 2007-2020 Juan Linietsky, Ariel Manzur.                 */\n+/* Copyright (c) 2014-2020 Godot Engine contributors (cf. AUTHORS.md).   */\n+/*                                                                       */\n+/* Permission is hereby granted, free of charge, to any person obtaining */\n+/* a copy of this software and associated documentation files (the       */\n+/* \"Software\"), to deal in the Software without restriction, including   */\n+/* without limitation the rights to use, copy, modify, merge, publish,   */\n+/* distribute, sublicense, and/or sell copies of the Software, and to    */\n+/* permit persons to whom the Software is furnished to do so, subject to */\n+/* the following conditions:                                             */\n+/*                                                                       */\n+/* The above copyright notice and this permission notice shall be        */\n+/* included in all copies or substantial portions of the Software.       */\n+/*                                                                       */\n+/* THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND,       */\n+/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF    */\n+/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.*/\n+/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY  */\n+/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,  */\n+/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE     */\n+/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.                */\n+/*************************************************************************/\n+\n+#include \"variant.h\"\n+\n+#include \"core/core_string_names.h\"\n+#include \"core/crypto/crypto_core.h\"\n+#include \"core/debugger/engine_debugger.h\"\n+#include \"core/io/compression.h\"\n+#include \"core/object/class_db.h\"\n+#include \"core/os/os.h\"\n+#include \"core/templates/local_vector.h\"\n+#include \"core/templates/oa_hash_map.h\"\n+\n+_FORCE_INLINE_ void sarray_add_str(Vector<String> &arr) {\n+}\n+\n+_FORCE_INLINE_ void sarray_add_str(Vector<String> &arr, const String &p_str) {\n+\tarr.push_back(p_str);\n+}\n+\n+template <class... P>\n+_FORCE_INLINE_ void sarray_add_str(Vector<String> &arr, const String &p_str, P... p_args) {\n+\tarr.push_back(p_str);\n+\tsarray_add_str(arr, p_args...);\n+}\n+\n+template <class... P>\n+_FORCE_INLINE_ Vector<String> sarray(P... p_args) {\n+\tVector<String> arr;\n+\tsarray_add_str(arr, p_args...);\n+\treturn arr;\n+}\n+\n+template <class T, class... P>\n+class VariantConstructor {\n+\ttemplate <size_t... Is>\n+\tstatic _FORCE_INLINE_ void construct_helper(T &base, const Variant **p_args, Callable::CallError &r_error, IndexSequence<Is...>) {\n+\t\tr_error.error = Callable::CallError::CALL_OK;\n+\n+#ifdef DEBUG_METHODS_ENABLED\n+\t\tbase = T(VariantCasterAndValidate<P>::cast(p_args, Is, r_error)...);\n+#else\n+\t\tbase = T(VariantCaster<P>::cast(*p_args[Is])...);\n+#endif\n+\t}\n+\n+\ttemplate <size_t... Is>\n+\tstatic _FORCE_INLINE_ void validated_construct_helper(T &base, const Variant **p_args, IndexSequence<Is...>) {\n+\t\tbase = T((*VariantGetInternalPtr<P>::get_ptr(p_args[Is]))...);\n+\t}\n+\n+\ttemplate <size_t... Is>\n+\tstatic _FORCE_INLINE_ void ptr_construct_helper(void *base, const void **p_args, IndexSequence<Is...>) {\n+\t\tPtrToArg<T>::encode(T(PtrToArg<P>::convert(p_args[Is])...), base);\n+\t}\n+\n+public:\n+\tstatic void construct(Variant &r_ret, const Variant **p_args, Callable::CallError &r_error) {\n+\t\tr_error.error = Callable::CallError::CALL_OK;\n+\t\tVariantTypeChanger<T>::change(&r_ret);\n+\t\tconstruct_helper(*VariantGetInternalPtr<T>::get_ptr(&r_ret), p_args, r_error, BuildIndexSequence<sizeof...(P)>{});\n+\t}\n+\n+\tstatic void validated_construct(Variant &r_ret, const Variant **p_args) {\n+\t\tVariantTypeChanger<T>::change(&r_ret);\n+\t\tvalidated_construct_helper(*VariantGetInternalPtr<T>::get_ptr(&r_ret), p_args, BuildIndexSequence<sizeof...(P)>{});\n+\t}\n+\tstatic void ptr_construct(void *base, const void **p_args) {\n+\t\tptr_construct_helper(base, p_args, BuildIndexSequence<sizeof...(P)>{});\n+\t}\n+\n+\tstatic int get_argument_count() {\n+\t\treturn sizeof...(P);\n+\t}\n+\n+\tstatic Variant::Type get_argument_type(int p_arg) {\n+\t\treturn call_get_argument_type<P...>(p_arg);\n+\t}\n+\n+\tstatic Variant::Type get_base_type() {\n+\t\treturn GetTypeInfo<T>::VARIANT_TYPE;\n+\t}\n+};\n+\n+class VariantConstructorObject {\n+public:\n+\tstatic void construct(Variant &r_ret, const Variant **p_args, Callable::CallError &r_error) {\n+\t\tVariantInternal::clear(&r_ret);\n+\t\tif (p_args[0]->get_type() == Variant::NIL) {\n+\t\t\tVariantInternal::object_assign_null(&r_ret);\n+\t\t\tr_error.error = Callable::CallError::CALL_OK;\n+\t\t} else if (p_args[0]->get_type() == Variant::OBJECT) {\n+\t\t\tVariantInternal::object_assign(&r_ret, p_args[0]);\n+\t\t\tr_error.error = Callable::CallError::CALL_OK;\n+\t\t} else {\n+\t\t\tr_error.error = Callable::CallError::CALL_ERROR_INVALID_ARGUMENT;\n+\t\t\tr_error.argument = 0;\n+\t\t\tr_error.expected = Variant::OBJECT;\n+\t\t}\n+\t}\n+\n+\tstatic void validated_construct(Variant &r_ret, const Variant **p_args) {\n+\t\tVariantInternal::clear(&r_ret);\n+\t\tVariantInternal::object_assign(&r_ret, p_args[0]);\n+\t}\n+\tstatic void ptr_construct(void *base, const void **p_args) {\n+\t\tPtrToArg<Object *>::encode(PtrToArg<Object *>::convert(p_args[0]), base);\n+\t}\n+\n+\tstatic int get_argument_count() {\n+\t\treturn 1;\n+\t}\n+\n+\tstatic Variant::Type get_argument_type(int p_arg) {\n+\t\treturn Variant::OBJECT;\n+\t}\n+\n+\tstatic Variant::Type get_base_type() {\n+\t\treturn Variant::OBJECT;\n+\t}\n+};\n+\n+class VariantConstructorNilObject {\n+public:\n+\tstatic void construct(Variant &r_ret, const Variant **p_args, Callable::CallError &r_error) {\n+\t\tif (p_args[0]->get_type() != Variant::NIL) {\n+\t\t\tr_error.error = Callable::CallError::CALL_ERROR_INVALID_ARGUMENT;\n+\t\t\tr_error.argument = 0;\n+\t\t\tr_error.expected = Variant::NIL;\n+\t\t}\n+\n+\t\tVariantInternal::clear(&r_ret);\n+\t\tVariantInternal::object_assign_null(&r_ret);\n+\t}\n+\n+\tstatic void validated_construct(Variant &r_ret, const Variant **p_args) {\n+\t\tVariantInternal::clear(&r_ret);\n+\t\tVariantInternal::object_assign_null(&r_ret);\n+\t}\n+\tstatic void ptr_construct(void *base, const void **p_args) {\n+\t\tPtrToArg<Object *>::encode(nullptr, base);\n+\t}\n+\n+\tstatic int get_argument_count() {\n+\t\treturn 1;\n+\t}\n+\n+\tstatic Variant::Type get_argument_type(int p_arg) {\n+\t\treturn Variant::NIL;\n+\t}\n+\n+\tstatic Variant::Type get_base_type() {\n+\t\treturn Variant::OBJECT;\n+\t}\n+};\n+\n+class VariantConstructorCallableArgs {\n+public:\n+\tstatic void construct(Variant &r_ret, const Variant **p_args, Callable::CallError &r_error) {\n+\t\tObjectID object_id;\n+\t\tStringName method;\n+\n+\t\tif (p_args[0]->get_type() == Variant::NIL) {\n+\t\t\t// leave as is\n+\t\t} else if (p_args[0]->get_type() == Variant::OBJECT) {\n+\t\t\tobject_id = VariantInternal::get_object_id(p_args[0]);\n+\t\t} else {\n+\t\t\tr_error.error = Callable::CallError::CALL_ERROR_INVALID_ARGUMENT;\n+\t\t\tr_error.argument = 0;\n+\t\t\tr_error.expected = Variant::OBJECT;\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tif (p_args[1]->get_type() == Variant::STRING_NAME) {\n+\t\t\tmethod = *VariantGetInternalPtr<StringName>::get_ptr(p_args[1]);\n+\t\t} else if (p_args[1]->get_type() == Variant::STRING) {\n+\t\t\tmethod = *VariantGetInternalPtr<String>::get_ptr(p_args[1]);\n+\t\t} else {\n+\t\t\tr_error.error = Callable::CallError::CALL_ERROR_INVALID_ARGUMENT;\n+\t\t\tr_error.argument = 1;\n+\t\t\tr_error.expected = Variant::STRING_NAME;\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tVariantTypeChanger<Callable>::change(&r_ret);\n+\t\t*VariantGetInternalPtr<Callable>::get_ptr(&r_ret) = Callable(object_id, method);\n+\t}\n+\n+\tstatic void validated_construct(Variant &r_ret, const Variant **p_args) {\n+\t\tVariantTypeChanger<Callable>::change(&r_ret);\n+\t\t*VariantGetInternalPtr<Callable>::get_ptr(&r_ret) = Callable(VariantInternal::get_object_id(p_args[0]), *VariantGetInternalPtr<StringName>::get_ptr(p_args[1]));\n+\t}\n+\tstatic void ptr_construct(void *base, const void **p_args) {\n+\t\tPtrToArg<Callable>::encode(Callable(PtrToArg<Object *>::convert(p_args[0]), PtrToArg<StringName>::convert(p_args[1])), base);\n+\t}\n+\n+\tstatic int get_argument_count() {\n+\t\treturn 2;\n+\t}\n+\n+\tstatic Variant::Type get_argument_type(int p_arg) {\n+\t\tif (p_arg == 0) {\n+\t\t\treturn Variant::OBJECT;\n+\t\t} else {\n+\t\t\treturn Variant::STRING_NAME;\n+\t\t}\n+\t}\n+\n+\tstatic Variant::Type get_base_type() {\n+\t\treturn Variant::CALLABLE;\n+\t}\n+};\n+\n+class VariantConstructorSignalArgs {\n+public:\n+\tstatic void construct(Variant &r_ret, const Variant **p_args, Callable::CallError &r_error) {\n+\t\tObjectID object_id;\n+\t\tStringName method;\n+\n+\t\tif (p_args[0]->get_type() == Variant::NIL) {\n+\t\t\t// leave as is\n+\t\t} else if (p_args[0]->get_type() == Variant::OBJECT) {\n+\t\t\tobject_id = VariantInternal::get_object_id(p_args[0]);\n+\t\t} else {\n+\t\t\tr_error.error = Callable::CallError::CALL_ERROR_INVALID_ARGUMENT;\n+\t\t\tr_error.argument = 0;\n+\t\t\tr_error.expected = Variant::OBJECT;\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tif (p_args[1]->get_type() == Variant::STRING_NAME) {\n+\t\t\tmethod = *VariantGetInternalPtr<StringName>::get_ptr(p_args[1]);\n+\t\t} else if (p_args[1]->get_type() == Variant::STRING) {\n+\t\t\tmethod = *VariantGetInternalPtr<String>::get_ptr(p_args[1]);\n+\t\t} else {\n+\t\t\tr_error.error = Callable::CallError::CALL_ERROR_INVALID_ARGUMENT;\n+\t\t\tr_error.argument = 1;\n+\t\t\tr_error.expected = Variant::STRING_NAME;\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tVariantTypeChanger<Signal>::change(&r_ret);\n+\t\t*VariantGetInternalPtr<Signal>::get_ptr(&r_ret) = Signal(object_id, method);\n+\t}\n+\n+\tstatic void validated_construct(Variant &r_ret, const Variant **p_args) {\n+\t\tVariantTypeChanger<Signal>::change(&r_ret);\n+\t\t*VariantGetInternalPtr<Signal>::get_ptr(&r_ret) = Signal(VariantInternal::get_object_id(p_args[0]), *VariantGetInternalPtr<StringName>::get_ptr(p_args[1]));\n+\t}\n+\tstatic void ptr_construct(void *base, const void **p_args) {\n+\t\tPtrToArg<Signal>::encode(Signal(PtrToArg<Object *>::convert(p_args[0]), PtrToArg<StringName>::convert(p_args[1])), base);\n+\t}\n+\n+\tstatic int get_argument_count() {\n+\t\treturn 2;\n+\t}\n+\n+\tstatic Variant::Type get_argument_type(int p_arg) {\n+\t\tif (p_arg == 0) {\n+\t\t\treturn Variant::OBJECT;\n+\t\t} else {\n+\t\t\treturn Variant::STRING_NAME;\n+\t\t}\n+\t}\n+\n+\tstatic Variant::Type get_base_type() {\n+\t\treturn Variant::CALLABLE;\n+\t}\n+};\n+\n+template <class T>\n+class VariantConstructorToArray {\n+public:\n+\tstatic void construct(Variant &r_ret, const Variant **p_args, Callable::CallError &r_error) {\n+\t\tif (p_args[0]->get_type() != GetTypeInfo<T>::VARIANT_TYPE) {\n+\t\t\tr_error.error = Callable::CallError::CALL_ERROR_INVALID_ARGUMENT;\n+\t\t\tr_error.argument = 0;\n+\t\t\tr_error.expected = GetTypeInfo<T>::VARIANT_TYPE;\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tVariantTypeChanger<Array>::change(&r_ret);\n+\t\tArray &dst_arr = *VariantGetInternalPtr<Array>::get_ptr(&r_ret);\n+\t\tconst T &src_arr = *VariantGetInternalPtr<T>::get_ptr(p_args[0]);\n+\n+\t\tint size = src_arr.size();\n+\t\tdst_arr.resize(size);\n+\t\tfor (int i = 0; i < size; i++) {\n+\t\t\tdst_arr[i] = src_arr[i];\n+\t\t}\n+\t}\n+\n+\tstatic void validated_construct(Variant &r_ret, const Variant **p_args) {\n+\t\tVariantTypeChanger<Array>::change(&r_ret);\n+\t\tArray &dst_arr = *VariantGetInternalPtr<Array>::get_ptr(&r_ret);\n+\t\tconst T &src_arr = *VariantGetInternalPtr<T>::get_ptr(p_args[0]);\n+\n+\t\tint size = src_arr.size();\n+\t\tdst_arr.resize(size);\n+\t\tfor (int i = 0; i < size; i++) {\n+\t\t\tdst_arr[i] = src_arr[i];\n+\t\t}\n+\t}\n+\tstatic void ptr_construct(void *base, const void **p_args) {\n+\t\tArray dst_arr;\n+\t\tT src_arr = PtrToArg<T>::convert(p_args[0]);\n+\n+\t\tint size = src_arr.size();\n+\t\tdst_arr.resize(size);\n+\t\tfor (int i = 0; i < size; i++) {\n+\t\t\tdst_arr[i] = src_arr[i];\n+\t\t}\n+\n+\t\tPtrToArg<Array>::encode(dst_arr, base);\n+\t}\n+\n+\tstatic int get_argument_count() {\n+\t\treturn 1;\n+\t}\n+\n+\tstatic Variant::Type get_argument_type(int p_arg) {\n+\t\treturn GetTypeInfo<T>::VARIANT_TYPE;\n+\t}\n+\n+\tstatic Variant::Type get_base_type() {\n+\t\treturn Variant::ARRAY;\n+\t}\n+};\n+\n+template <class T>\n+class VariantConstructorFromArray {\n+public:\n+\tstatic void construct(Variant &r_ret, const Variant **p_args, Callable::CallError &r_error) {\n+\t\tif (p_args[0]->get_type() != Variant::ARRAY) {\n+\t\t\tr_error.error = Callable::CallError::CALL_ERROR_INVALID_ARGUMENT;\n+\t\t\tr_error.argument = 0;\n+\t\t\tr_error.expected = Variant::ARRAY;\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tVariantTypeChanger<T>::change(&r_ret);\n+\t\tconst Array &src_arr = *VariantGetInternalPtr<Array>::get_ptr(p_args[0]);\n+\t\tT &dst_arr = *VariantGetInternalPtr<T>::get_ptr(&r_ret);\n+\n+\t\tint size = src_arr.size();\n+\t\tdst_arr.resize(size);\n+\t\tfor (int i = 0; i < size; i++) {\n+\t\t\tdst_arr.write[i] = src_arr[i];\n+\t\t}\n+\t}\n+\n+\tstatic void validated_construct(Variant &r_ret, const Variant **p_args) {\n+\t\tVariantTypeChanger<T>::change(&r_ret);\n+\t\tconst Array &src_arr = *VariantGetInternalPtr<Array>::get_ptr(p_args[0]);\n+\t\tT &dst_arr = *VariantGetInternalPtr<T>::get_ptr(&r_ret);\n+\n+\t\tint size = src_arr.size();\n+\t\tdst_arr.resize(size);\n+\t\tfor (int i = 0; i < size; i++) {\n+\t\t\tdst_arr.write[i] = src_arr[i];\n+\t\t}\n+\t}\n+\tstatic void ptr_construct(void *base, const void **p_args) {\n+\t\tArray src_arr = PtrToArg<Array>::convert(p_args[0]);\n+\t\tT dst_arr;\n+\n+\t\tint size = src_arr.size();\n+\t\tdst_arr.resize(size);\n+\t\tfor (int i = 0; i < size; i++) {\n+\t\t\tdst_arr.write[i] = src_arr[i];\n+\t\t}\n+\n+\t\tPtrToArg<T>::encode(dst_arr, base);\n+\t}\n+\n+\tstatic int get_argument_count() {\n+\t\treturn 1;\n+\t}\n+\n+\tstatic Variant::Type get_argument_type(int p_arg) {\n+\t\treturn Variant::ARRAY;\n+\t}\n+\n+\tstatic Variant::Type get_base_type() {\n+\t\treturn GetTypeInfo<T>::VARIANT_TYPE;\n+\t}\n+};\n+\n+class VariantConstructorNil {\n+public:\n+\tstatic void construct(Variant &r_ret, const Variant **p_args, Callable::CallError &r_error) {\n+\t\tif (p_args[0]->get_type() != Variant::NIL) {\n+\t\t\tr_error.error = Callable::CallError::CALL_ERROR_INVALID_ARGUMENT;\n+\t\t\tr_error.argument = 0;\n+\t\t\tr_error.expected = Variant::NIL;\n+\t\t\treturn;\n+\t\t}\n+\n+\t\tr_error.error = Callable::CallError::CALL_OK;\n+\t\tVariantInternal::clear(&r_ret);\n+\t}\n+\n+\tstatic void validated_construct(Variant &r_ret, const Variant **p_args) {\n+\t\tVariantInternal::clear(&r_ret);\n+\t}\n+\tstatic void ptr_construct(void *base, const void **p_args) {\n+\t\tPtrToArg<Variant>::encode(Variant(), base);\n+\t}\n+\n+\tstatic int get_argument_count() {\n+\t\treturn 1;\n+\t}\n+\n+\tstatic Variant::Type get_argument_type(int p_arg) {\n+\t\treturn Variant::NIL;\n+\t}\n+\n+\tstatic Variant::Type get_base_type() {\n+\t\treturn Variant::NIL;\n+\t}\n+};\n+\n+struct VariantConstructData {\n+\tvoid (*construct)(Variant &r_base, const Variant **p_args, Callable::CallError &r_error);\n+\tVariant::ValidatedConstructor validated_construct;\n+\tVariant::PTRConstructor ptr_construct;\n+\tVariant::Type (*get_argument_type)(int);\n+\tint argument_count;\n+\tVector<String> arg_names;\n+};\n+\n+static LocalVector<VariantConstructData> construct_data[Variant::VARIANT_MAX];\n+\n+static void variant_initialize_nil(Variant *v) {\n+\tVariantInternal::clear(v);\n+}\n+\n+template <class T>\n+static void variant_initialize(Variant *v) {\n+\tVariantTypeChanger<T>::change(v);\n+}\n+\n+template <class T>\n+static void variant_initialize_zero(Variant *v) {\n+\tVariantTypeChanger<T>::change(v);\n+\t*VariantGetInternalPtr<T>::get_ptr(v) = 0;\n+}\n+\n+static void variant_initialize_false(Variant *v) {\n+\tVariantTypeChanger<bool>::change(v);\n+\t*VariantGetInternalPtr<bool>::get_ptr(v) = false;\n+}\n+\n+static void variant_initialize_obj(Variant *v) {\n+\tVariantInternal::clear(v);\n+\tVariantInternal::object_assign_null(v);\n+}\n+\n+typedef void (*VariantInitializeFunc)(Variant *v);\n+\n+static VariantInitializeFunc initialize_funcs[Variant::VARIANT_MAX];\n+\n+template <class T>\n+static void add_constructor(const Vector<String> &arg_names) {\n+\tERR_FAIL_COND_MSG(arg_names.size() != T::get_argument_count(), \"Argument names size mismatch for \" + Variant::get_type_name(T::get_base_type()) + \".\");\n+\n+\tVariantConstructData cd;\n+\tcd.construct = T::construct;\n+\tcd.validated_construct = T::validated_construct;\n+\tcd.ptr_construct = T::ptr_construct;\n+\tcd.get_argument_type = T::get_argument_type;\n+\tcd.argument_count = T::get_argument_count();\n+\tcd.arg_names = arg_names;\n+\tconstruct_data[T::get_base_type()].push_back(cd);\n+}\n+\n+void Variant::_register_variant_constructors() {\n+\tadd_constructor<VariantConstructorNil>(sarray(\"from\"));\n+\n+\tadd_constructor<VariantConstructor<bool, bool>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<bool, int64_t>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<bool, double>>(sarray(\"from\"));\n+\n+\tadd_constructor<VariantConstructor<int64_t, int64_t>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<int64_t, double>>(sarray(\"from\"));\n+\n+\tadd_constructor<VariantConstructor<double, double>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<double, int64_t>>(sarray(\"from\"));\n+\n+\tadd_constructor<VariantConstructor<String, String>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<String, StringName>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<String, NodePath>>(sarray(\"from\"));\n+\n+\tadd_constructor<VariantConstructor<Vector2, Vector2>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Vector2, Vector2i>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Vector2, double, double>>(sarray(\"x\", \"y\"));\n+\n+\tadd_constructor<VariantConstructor<Vector2i, Vector2i>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Vector2i, Vector2>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Vector2i, int64_t, int64_t>>(sarray(\"x\", \"y\"));\n+\n+\tadd_constructor<VariantConstructor<Rect2, Rect2>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Rect2, Rect2i>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Rect2, Vector2, Vector2>>(sarray(\"position\", \"size\"));\n+\tadd_constructor<VariantConstructor<Rect2, double, double, double, double>>(sarray(\"x\", \"y\", \"width\", \"height\"));\n+\n+\tadd_constructor<VariantConstructor<Rect2i, Rect2i>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Rect2i, Rect2>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Rect2i, Vector2i, Vector2i>>(sarray(\"position\", \"size\"));\n+\tadd_constructor<VariantConstructor<Rect2i, int64_t, int64_t, int64_t, int64_t>>(sarray(\"x\", \"y\", \"width\", \"height\"));\n+\n+\tadd_constructor<VariantConstructor<Vector3, Vector3>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Vector3, Vector3i>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Vector3, double, double, double>>(sarray(\"x\", \"y\", \"z\"));\n+\n+\tadd_constructor<VariantConstructor<Vector3i, Vector3i>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Vector3i, Vector3>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Vector3i, int64_t, int64_t, int64_t>>(sarray(\"x\", \"y\", \"z\"));\n+\n+\tadd_constructor<VariantConstructor<Transform2D, Transform2D>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Transform2D, Vector2, Vector2, Vector2>>(sarray(\"x\", \"y\", \"origin\"));\n+\n+\tadd_constructor<VariantConstructor<Plane, Plane>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Plane, Vector3, double>>(sarray(\"normal\", \"d\"));\n+\tadd_constructor<VariantConstructor<Plane, Vector3, Vector3>>(sarray(\"point\", \"normal\"));\n+\tadd_constructor<VariantConstructor<Plane, Vector3, Vector3, Vector3>>(sarray(\"point1\", \"point2\", \"point3\"));\n+\n+\tadd_constructor<VariantConstructor<Quat, Quat>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Quat, Basis>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Quat, Vector3>>(sarray(\"euler\"));\n+\tadd_constructor<VariantConstructor<Quat, Vector3, double>>(sarray(\"axis\", \"angle\"));\n+\tadd_constructor<VariantConstructor<Quat, Vector3, Vector3>>(sarray(\"arc_from\", \"arc_to\"));\n+\n+\tadd_constructor<VariantConstructor<::AABB, ::AABB>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<::AABB, Vector3, Vector3>>(sarray(\"position\", \"size\"));\n+\n+\tadd_constructor<VariantConstructor<Basis, Basis>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Basis, Quat>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Basis, Vector3, Vector3, Vector3>>(sarray(\"x\", \"y\", \"z\"));\n+\n+\tadd_constructor<VariantConstructor<Transform, Transform>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<Transform, Basis, Vector3>>(sarray(\"basis\", \"origin\"));\n+\n+\tadd_constructor<VariantConstructor<Color, Color>>(sarray(\"from\"));\n+\n+\tadd_constructor<VariantConstructor<StringName, StringName>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<StringName, String>>(sarray(\"from\"));\n+\n+\tadd_constructor<VariantConstructor<NodePath, NodePath>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructor<NodePath, String>>(sarray(\"from\"));\n+\n+\tadd_constructor<VariantConstructor<RID, RID>>(sarray(\"from\"));\n+\n+\tadd_constructor<VariantConstructorObject>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructorNilObject>(sarray(\"from\"));\n+\n+\tadd_constructor<VariantConstructor<Callable, Callable>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructorCallableArgs>(sarray(\"object\", \"method\"));\n+\n+\tadd_constructor<VariantConstructor<Signal, Signal>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructorSignalArgs>(sarray(\"object\", \"signal\"));\n+\n+\tadd_constructor<VariantConstructor<Dictionary, Dictionary>>(sarray(\"from\"));\n+\n+\tadd_constructor<VariantConstructor<Array, Array>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructorToArray<PackedByteArray>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructorToArray<PackedInt32Array>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructorToArray<PackedInt64Array>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructorToArray<PackedFloat64Array>>(sarray(\"from\"));\n+\tadd_constructor<VariantConstructorToArray<PackedFloat64Array>>(sarray(\"from\"));",
    "line": 598,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-11-09T15:55:47Z",
    "isReviewComment": true,
    "pullRequestReviewId": 526398765,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:41.324Z"
  },
  {
    "repo": "godotengine/godot",
    "prNumber": 42641,
    "prTitle": "Ensure KinematicBodies only interact with other Bodies with matching mask.",
    "prAuthor": "madmiraal",
    "prLink": "https://github.com/godotengine/godot/pull/42641",
    "commentAuthor": "pouleyKetchoupp",
    "commentBody": "Actually after doing more tests I realized this layer check is inverted, a kinematic body should collide with objects it scans in its own mask, not objects which have its own layer in their mask. I'll make a fix in another PR.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/godotengine/godot/pull/42641#discussion_r672702932",
    "filePath": "servers/physics_3d/space_3d_sw.cpp",
    "diffHunk": "@@ -549,7 +549,7 @@ int Space3DSW::_cull_aabb_for_body(Body3DSW *p_body, const AABB &p_aabb) {\n \t\t\tkeep = false;\n \t\t} else if (intersection_query_results[i]->get_type() == CollisionObject3DSW::TYPE_SOFT_BODY) {\n \t\t\tkeep = false;\n-\t\t} else if ((static_cast<Body3DSW *>(intersection_query_results[i])->test_collision_mask(p_body)) == 0) {\n+\t\t} else if (!p_body->layer_in_mask(static_cast<Body3DSW *>(intersection_query_results[i]))) {",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-07-19T23:35:19Z",
    "isReviewComment": true,
    "pullRequestReviewId": 710065052,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:42.999Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 68493,
    "prTitle": "[turbopack] Replace uses of globby in scripts with glob",
    "prAuthor": "bgw",
    "prLink": "https://github.com/vercel/next.js/pull/68493",
    "commentAuthor": "ForsakenHarmony",
    "commentBody": "Unfortunately this is broken, `!` globs just get ignored because of the `|`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/68493#discussion_r1742268286",
    "filePath": "scripts/pack-util.cjs",
    "diffHunk": "@@ -99,7 +103,7 @@ async function packageFiles(path) {\n     .filter((f) => !isGlob(f) && existsSync(join(path, f)))\n     .map((f) => f.replace(/^\\.\\//, ''))\n   const globFiles = allFiles.filter(isGlob)\n-  const globbedFiles = await globby(globFiles, { cwd: path })\n+  const globbedFiles = await glob(`+(${globFiles.join('|')})`, { cwd: path })",
    "line": 25,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-09-03T15:26:59Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2277787423,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:43.487Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 63309,
    "prTitle": "feat(turbopack): Support proxy for `next/font`",
    "prAuthor": "kdy1",
    "prLink": "https://github.com/vercel/next.js/pull/63309",
    "commentAuthor": "sokra",
    "commentBody": "This would break persistent caching since the env var might change between runs.\nUse turbo-tasks-env to read env vars.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/63309#discussion_r1555297865",
    "filePath": "packages/next-swc/crates/next-core/src/next_import_map.rs",
    "diffHunk": "@@ -810,11 +813,20 @@ async fn insert_next_shared_aliases(\n         ImportMapping::Dynamic(Vc::upcast(NextFontGoogleReplacer::new(project_path))).into(),\n     );\n \n+    let proxy_option = match std::env::var(\"http_proxy\") {\n+        Ok(proxy) => Vc::cell(Some(ProxyConfig::Http(proxy))),\n+        Err(_) => match std::env::var(\"https_proxy\") {\n+            Ok(proxy) => Vc::cell(Some(ProxyConfig::Https(proxy))),\n+            Err(_) => Vc::cell(None),\n+        },\n+    };",
    "line": 22,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-04-08T06:45:00Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1985561242,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:43.633Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 51394,
    "prTitle": "Check for type of route handler returned value at build time (via the TS plugin) and at runtime",
    "prAuthor": "joulev",
    "prLink": "https://github.com/vercel/next.js/pull/51394",
    "commentAuthor": "khuezy",
    "commentBody": "@joulev I don't think `ImageResponse` itself is an instance of `Response` so this will break if your `route.ts` is returning an `ImageResponse` (for OG).\r\n\r\nThis line needs to add: `ImageResponse | Promise<ImageResponse>`\r\nand needs to import it at the top:\r\n`import type { NextRequest, ImageResponse } from 'next/server.js'`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/51394#discussion_r1320649525",
    "filePath": "packages/next/src/build/webpack/plugins/next-types-plugin/index.ts",
    "diffHunk": "@@ -107,6 +107,19 @@ if ('${method}' in entry) {\n       '${method}'\n     >\n   >()\n+  checkFields<\n+    Diff<\n+      {\n+        __tag__: '${method}',\n+        __return_type__: Response | Promise<Response>",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-09-09T20:33:36Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1618690804,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:45.713Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 46564,
    "prTitle": "Fix usage of textDecoder to not break utf8 characters",
    "prAuthor": "vadzim",
    "prLink": "https://github.com/vercel/next.js/pull/46564",
    "commentAuthor": "jridgewell",
    "commentBody": "We need to perform a final call to the `textDecoder` here to flush any trailing bytes that have not completed. This only comes up when an incomplete octet set is encountered at the end of of the stream:\r\n\r\n```js\r\nconst chunk = new TextEncoder().encode('abc💩').slice(0, -1);\r\n\r\nconst decoder = new TextDecoder();\r\nlet output = decoder.decode(chunk, { stream: true });\r\n\r\nconsole.assert(output === 'abc');\r\n\r\n// Flush the decoder to receive the final REPLACEMENT CHARACTER\r\n// for the unfinished emoji\r\noutput += decoder.decode();\r\n\r\nconsole.assert(output === 'abc�');",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/vercel/next.js/pull/46564#discussion_r1120865976",
    "filePath": "packages/next/src/server/app-render.tsx",
    "diffHunk": "@@ -1476,10 +1477,11 @@ export async function renderToHTMLOrFlight(\n       renderResult: RenderResult\n     ): Promise<string> => {\n       const renderChunks: string[] = []\n+      const textDecoder = new TextDecoder()\n \n       const writable = {\n         write(chunk: any) {\n-          renderChunks.push(decodeText(chunk))\n+          renderChunks.push(decodeText(chunk, textDecoder))\n         },\n         end() {},\n         destroy() {},",
    "line": 29,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-02-28T22:20:49Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1318751720,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:45.251Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 46371,
    "prTitle": "fix(ts): Fix navigation types",
    "prAuthor": "TadejPolajnar",
    "prLink": "https://github.com/vercel/next.js/pull/46371",
    "commentAuthor": "SukkaW",
    "commentBody": "No. It means that `/// <reference types=\"next/navigation-types/navigation\" />` will be added if appDir is not enabled. It is not the intended behavior.\r\n\r\nYou are not allowed to use `usePathname` if you don't have appDir enabled.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/46371#discussion_r1117373590",
    "filePath": "packages/next/src/lib/typescript/writeAppTypeDeclarations.ts",
    "diffHunk": "@@ -49,16 +49,14 @@ export async function writeAppTypeDeclarations({\n     directives.push('/// <reference types=\"next/image-types/global\" />')\n   }\n \n-  if (isAppDirEnabled) {\n-    if (hasPagesDir) {\n-      directives.push(\n-        '/// <reference types=\"next/navigation-types/compat/navigation\" />'\n-      )\n-    } else {\n-      directives.push(\n-        '/// <reference types=\"next/navigation-types/navigation\" />'\n-      )\n-    }\n+  if (isAppDirEnabled && hasPagesDir) {\n+    directives.push(\n+      '/// <reference types=\"next/navigation-types/compat/navigation\" />'\n+    )\n+  } else {\n+    directives.push(\n+      '/// <reference types=\"next/navigation-types/navigation\" />'\n+    )",
    "line": 21,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-02-24T17:35:59Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1313987843,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:45.521Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 29005,
    "prTitle": "Add/styled jsx swc",
    "prAuthor": "padmaia",
    "prLink": "https://github.com/vercel/next.js/pull/29005",
    "commentAuthor": "kdy1",
    "commentBody": "(Not important)\r\n\r\nThis will panic with a bad error message if argument does not exist.\r\n\r\n```rust\r\nif let Some(Expr::Lit(Lit::Str(Str { value, .. }))) = expr.args.get(0).as_ref().map(|arg| &*arg.expr) {\r\n}\r\n\r\n````\r\n\r\nwill work, and you can add an else clause to report an error with readable error message.",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/vercel/next.js/pull/29005#discussion_r706572429",
    "filePath": "packages/next/build/swc/src/next_dynamic.rs",
    "diffHunk": "@@ -43,6 +47,18 @@ impl Fold for NextDynamicPatcher {\n   }\n \n   fn fold_call_expr(&mut self, expr: CallExpr) -> CallExpr {\n+    if self.is_next_dynamic_first_arg {\n+      if let ExprOrSuper::Expr(e) = &expr.callee {\n+        if let Expr::Ident(Ident { sym, .. }) = &**e {\n+          if sym == \"import\" {\n+            if let Expr::Lit(Lit::Str(Str { value, .. })) = &*expr.args[0].expr {\n+              self.dynamically_imported_specifier = Some(value.to_string());",
    "line": 260,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-09-11T06:45:50Z",
    "isReviewComment": true,
    "pullRequestReviewId": 751895677,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:47.287Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 26864,
    "prTitle": "Added webpack5 to dependencies of using-preact #26826",
    "prAuthor": "DeviousLab",
    "prLink": "https://github.com/vercel/next.js/pull/26864",
    "commentAuthor": "timneutkens",
    "commentBody": "This means there will be 2 versions of webpack running which is not ideal (and will cause failures later). The root cause should be fixed.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/26864#discussion_r662907369",
    "filePath": "examples/using-preact/package.json",
    "diffHunk": "@@ -14,7 +14,9 @@\n     \"preact-render-to-string\": \"^5.1.11\",\n     \"react\": \"npm:@preact/compat\",\n     \"react-dom\": \"npm:@preact/compat\",\n-    \"react-ssr-prepass\": \"npm:preact-ssr-prepass@^1.1.2\"\n+    \"react-ssr-prepass\": \"npm:preact-ssr-prepass@^1.1.2\",\n+    \"webpack\": \"^5.4.0\",",
    "line": 6,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-07-02T10:21:00Z",
    "isReviewComment": true,
    "pullRequestReviewId": 698044674,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:47.373Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 23486,
    "prTitle": "Update `with-docker` example and deployment docs.",
    "prAuthor": "leerob",
    "prLink": "https://github.com/vercel/next.js/pull/23486",
    "commentAuthor": "gwynevans",
    "commentBody": "This fails if you've a clean example without a 'yarn.lock'",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/23486#discussion_r610581317",
    "filePath": "examples/with-docker/Dockerfile",
    "diffHunk": "@@ -1,12 +1,35 @@\n-FROM mhart/alpine-node\n-\n+# Install dependencies only when needed\n+FROM node:alpine AS deps\n+# Check https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine to understand why libc6-compat might be needed.\n+RUN apk add --no-cache libc6-compat\n WORKDIR /app\n+COPY package.json yarn.lock ./",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-04-09T12:20:04Z",
    "isReviewComment": true,
    "pullRequestReviewId": 632351415,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:47.197Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 22619,
    "prTitle": "Make the incremental cache storage and cache providers extensible.",
    "prAuthor": "MartinLG",
    "prLink": "https://github.com/vercel/next.js/pull/22619",
    "commentAuthor": "reboxer",
    "commentBody": "Testing this pull request and apparently this makes the directory to be an empty string and causing `write()` to fail each time it tries to save the files to disk.\r\n\r\n```\r\nFailed to update prerender files for /test [Error: ENOENT: no such file or directory, mkdir ''] {\r\n  errno: -4058,\r\n  code: 'ENOENT',\r\n  syscall: 'mkdir',\r\n  path: ''\r\n}\r\n```\r\n\r\nThe file should require `path` and the line should be `path.dirname(key)` to achieve the same result as the current implementation.\r\n\r\nAlso, `mkdir` could be put in a different method and called before trying to write the HTML and JSON, as it will be called twice for each page.",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/vercel/next.js/pull/22619#discussion_r669078845",
    "filePath": "packages/next/next-server/server/lib/storage.ts",
    "diffHunk": "@@ -0,0 +1,19 @@\n+import { promises } from 'fs'\n+\n+export interface StorageProfiderInterface {\n+  readValue: (key: string) => Promise<string>\n+  write: (key: string, value: string | undefined) => Promise<void>\n+}\n+\n+export class FileSystemStorageProvider implements StorageProfiderInterface {\n+  async readValue(key: string): Promise<string> {\n+    return await promises.readFile(key, 'utf8')\n+  }\n+\n+  async write(key: string, value: string | undefined) {\n+    await promises.mkdir(key.substring(0, key.lastIndexOf('/')), {",
    "line": 14,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-07-13T20:16:05Z",
    "isReviewComment": true,
    "pullRequestReviewId": 705605746,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:47.499Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 17195,
    "prTitle": "Add `with-gsap` example",
    "prAuthor": "galanggg",
    "prLink": "https://github.com/vercel/next.js/pull/17195",
    "commentAuthor": "mareksuscak",
    "commentBody": "The `useRef` doesn't seem to be used correctly across all these examples:\r\n\r\n1. The returned reference can be passed in directly, it should not be reassigned as that defeats the purpose\r\n2. The current reference should be accessed as `line1.current` once point no 1 above is addressed",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/17195#discussion_r688842462",
    "filePath": "examples/with-gsap/components/Content.js",
    "diffHunk": "@@ -0,0 +1,37 @@\n+import { useEffect, useRef } from 'react'\n+import { gsap } from 'gsap'\n+\n+const Content = () => {\n+  let line1 = useRef(null)\n+  useEffect(() => {\n+    gsap.from([line1], 0.6, {\n+      delay: 0.9,\n+      ease: 'power3.out',\n+      y: 24,\n+      stagger: {\n+        amount: 0.15,\n+      },\n+    })\n+  }, [line1])\n+\n+  return (\n+    <p ref={(el) => (line1 = el)} className=\"line\">\n+      A Simple example using{' '}\n+      <a\n+        href=\"https://greensock.com/gsap/\"\n+        style={{ fontWeight: 'bold', textDecoration: 'none' }}\n+      >\n+        GSAP\n+      </a>{' '}\n+      &{' '}\n+      <a\n+        href=\"https://www.npmjs.com/package/react-transition-group\"\n+        style={{ fontWeight: 'bold', textDecoration: 'none' }}\n+      >\n+        react-transition-group\n+      </a>\n+    </p>\n+  )\n+}",
    "line": 35,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-08-14T01:12:50Z",
    "isReviewComment": true,
    "pullRequestReviewId": 730039960,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:49.753Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 16022,
    "prTitle": "Add browser polyfils for Node.js modules (webpack 5 backwards compat)",
    "prAuthor": "timneutkens",
    "prLink": "https://github.com/vercel/next.js/pull/16022",
    "commentAuthor": "merceyz",
    "commentBody": "@timneutkens These should go through `require.resolve`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/16022#discussion_r467751399",
    "filePath": "packages/next/build/webpack-config.ts",
    "diffHunk": "@@ -356,7 +356,16 @@ export default async function getBaseWebpackConfig(\n       'next/router': 'next/dist/client/router.js',\n       'next/config': 'next/dist/next-server/lib/runtime-config.js',\n       'next/dynamic': 'next/dist/next-server/lib/dynamic.js',\n-      next: NEXT_PROJECT_ROOT,\n+      ...(isServer\n+        ? {}\n+        : {\n+            stream: 'stream-browserify',\n+            path: 'path-browserify',\n+            crypto: 'crypto-browserify',\n+            buffer: 'buffer',\n+            vm: 'vm-browserify',",
    "line": 12,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-08-10T08:19:08Z",
    "isReviewComment": true,
    "pullRequestReviewId": 464034539,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:49.384Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 13506,
    "prTitle": "Don't read public folder to check for conflicting pages",
    "prAuthor": "timneutkens",
    "prLink": "https://github.com/vercel/next.js/pull/13506",
    "commentAuthor": "ijjk",
    "commentBody": "This will report a conflict if there's a folder in `public` with the same name as a page even though they don't conflict e.g. `public/about/data.txt` and `pages/about.js`. We probably need to `stat` so we can check if it's a folder or not",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/13506#discussion_r434647718",
    "filePath": "packages/next/build/index.ts",
    "diffHunk": "@@ -232,23 +219,25 @@ export default async function build(dir: string, conf = null): Promise<void> {\n   let hasNonStaticErrorPage: boolean\n \n   if (hasPublicDir) {\n-    try {\n-      await promises.stat(path.join(publicDir, '_next'))\n+    const hasPublicUnderScoreNextDir = await fileExists(\n+      path.join(publicDir, '_next')\n+    )\n+    if (hasPublicUnderScoreNextDir) {\n       throw new Error(PUBLIC_DIR_MIDDLEWARE_CONFLICT)\n-    } catch (err) {}\n+    }\n   }\n \n-  for (let file of publicFiles) {\n-    file = file\n-      .replace(/\\\\/g, '/')\n-      .replace(/\\/index$/, '')\n-      .split(publicDir)\n-      .pop()!\n-\n-    if (mappedPages[file]) {\n-      conflictingPublicFiles.push(file)\n+  // Check if pages conflict with files in `public`\n+  // Only a page of public file can be served, not both.\n+  for (const page in mappedPages) {\n+    const hasPublicPageFile = await fileExists(\n+      path.join(publicDir, page === '/' ? '/index' : page)\n+    )\n+    if (hasPublicPageFile) {",
    "line": 77,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-06-03T15:18:07Z",
    "isReviewComment": true,
    "pullRequestReviewId": 423661406,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:49.082Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 12738,
    "prTitle": "Set environment variable for preview mode",
    "prAuthor": "jescalan",
    "prLink": "https://github.com/vercel/next.js/pull/12738",
    "commentAuthor": "timneutkens",
    "commentBody": "This will leak the variable to other requests causing the preview data to be set in places you don't expect it to. We'll have to figure out a better way to achieve this.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/12738#discussion_r423589698",
    "filePath": "packages/next/next-server/server/render.tsx",
    "diffHunk": "@@ -521,6 +521,10 @@ export async function renderToHTML(\n       previewData = tryGetPreviewData(req, res, previewProps)\n     }\n \n+    // Set environment variable flag for whether or not preview mode is active\n+    if (!!previewData) setConfig()\n+    process.env.__NEXT_PREVIEW_MODE = (!!previewData).toString()",
    "line": 6,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-05-12T09:21:19Z",
    "isReviewComment": true,
    "pullRequestReviewId": 409857342,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:49.001Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 8999,
    "prTitle": "Add src directory support for global CSS",
    "prAuthor": "ykzts",
    "prLink": "https://github.com/vercel/next.js/pull/8999",
    "commentAuthor": "Timer",
    "commentBody": "This should still be `dir`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/8999#discussion_r332798864",
    "filePath": "packages/next/build/webpack-config.ts",
    "diffHunk": "@@ -668,7 +664,7 @@ export default async function getBaseWebpackConfig(\n                             'Custom <App>'\n                           )}. Please move all global CSS imports to ${chalk.cyan(\n                             customAppFile\n-                              ? path.relative(dir, customAppFile)\n+                              ? path.relative(pagesDir, customAppFile)",
    "line": 22,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2019-10-09T01:39:06Z",
    "isReviewComment": true,
    "pullRequestReviewId": 299132013,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:51.481Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 7864,
    "prTitle": "a modal route example with next js",
    "prAuthor": "mohammad-amin-hesam",
    "prLink": "https://github.com/vercel/next.js/pull/7864",
    "commentAuthor": "timneutkens",
    "commentBody": "This breaks Next.js / back button behavior, it should use the Next.js router instead.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/7864#discussion_r301996377",
    "filePath": "examples/next-modal-route/pages/index.js",
    "diffHunk": "@@ -0,0 +1,51 @@\n+import React, { useState, useRef, useEffect } from \"react\";\n+import Link from \"next/link\";\n+import Modal from \"../components/Modal\";\n+\n+const App = () => {\n+  const [modal, setModal] = useState(false);\n+\n+  const _modal = useRef(null);\n+\n+  const handleClick = () => {\n+    setModal(true);\n+    window.history.pushState(\"\", \"\", \"/test\");",
    "line": 12,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2019-07-10T10:34:39Z",
    "isReviewComment": true,
    "pullRequestReviewId": 260007249,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:51.481Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 7704,
    "prTitle": "Experimental module/nomodule support",
    "prAuthor": "janicklas-ralph",
    "prLink": "https://github.com/vercel/next.js/pull/7704",
    "commentAuthor": "Timer",
    "commentBody": "At this point we already know we're in modern-mode, does the `noModule` property within `script` even matter anymore?\r\n\r\nThis is client-side code already being executed that was loaded via the `type=module` directive.\r\n\r\n```suggestion\r\n    if (process.env.__NEXT_MODERN_BUILD) {\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/vercel/next.js/pull/7704#discussion_r307007926",
    "filePath": "packages/next/client/page-loader.js",
    "diffHunk": "@@ -111,9 +116,14 @@ export default class PageLoader {\n     await this.promisedBuildId\n \n     route = this.normalizeRoute(route)\n-    const scriptRoute = route === '/' ? '/index.js' : `${route}.js`\n+    const scriptRoute = PageLoader.getScriptRoute(route)\n \n     const script = document.createElement('script')\n+\n+    if (process.env.__NEXT_MODERN_BUILD && 'noModule' in script) {",
    "line": 9,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2019-07-24T20:32:53Z",
    "isReviewComment": true,
    "pullRequestReviewId": 266269327,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:51.363Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 5737,
    "prTitle": "Use <link rel=“prefetch”> for prefetching",
    "prAuthor": "timneutkens",
    "prLink": "https://github.com/vercel/next.js/pull/5737",
    "commentAuthor": "cramforce",
    "commentBody": "These aren't semantically the same. Prefetch should only be used for future navigations (as in full page loads). For sub-resources fetches (like this one), preload is the right one to use.\r\n\r\nPrefetch may appear to work for client side navigations, but may lead to double-downloads if the prefetch hasn't finished by the time the actual request is made. That is because preload hits the memory cache (which de-dupes requests) while prefetch is only de-duped once the response made it into the disk cache.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/5737#discussion_r236059295",
    "filePath": "packages/next/lib/page-loader.js",
    "diffHunk": "@@ -110,10 +123,30 @@ export default class PageLoader {\n     }\n   }\n \n+  async prefetch (route) {\n+    route = this.normalizeRoute(route)\n+    const scriptRoute = route === '/' ? '/index.js' : `${route}.js`\n+    if (this.prefetchCache.has(scriptRoute)) {\n+      return\n+    }\n+    this.prefetchCache.add(scriptRoute)\n+\n+    const link = document.createElement('link')\n+    // Feature detection is used to see if prefetch is supported, else fall back to preload\n+    // Mainly this is for Safari\n+    // https://caniuse.com/#feat=link-rel-prefetch\n+    // https://caniuse.com/#feat=link-rel-preload\n+    link.rel = supportsPrefetch ? 'prefetch' : 'preload'",
    "line": 47,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2018-11-25T03:04:37Z",
    "isReviewComment": true,
    "pullRequestReviewId": 178067919,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:52.019Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 5722,
    "prTitle": "Avoiding duplicated line on loadable options.",
    "prAuthor": "andersonleite",
    "prLink": "https://github.com/vercel/next.js/pull/5722",
    "commentAuthor": "timneutkens",
    "commentBody": "If `ssr: true` this will break, since the line above is deleting the value",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/5722#discussion_r235557975",
    "filePath": "packages/next-server/lib/dynamic.js",
    "diffHunk": "@@ -115,11 +115,10 @@ export default function dynamic (dynamicOptions: any, options: NextDynamicOption\n \n   // support for disabling server side rendering, eg: dynamic(import('../hello-world'), {ssr: false})\n   if (typeof loadableOptions.ssr === 'boolean') {\n+    delete loadableOptions.ssr\n     if (!loadableOptions.ssr) {",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2018-11-21T22:39:29Z",
    "isReviewComment": true,
    "pullRequestReviewId": 177452252,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:53.579Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 5691,
    "prTitle": "Dynamic import tests fix",
    "prAuthor": "whatever555",
    "prLink": "https://github.com/vercel/next.js/pull/5691",
    "commentAuthor": "timneutkens",
    "commentBody": "`require.resolveWeak` will in all cases be `undefined` while being ran here.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/5691#discussion_r234458691",
    "filePath": "packages/next/build/babel/plugins/react-loadable-plugin.js",
    "diffHunk": "@@ -121,7 +121,7 @@ export default function ({ types: t, template }) {\n                         return t.callExpression(\n                           t.memberExpression(\n                             t.identifier('require'),\n-                            t.identifier('resolveWeak')\n+                            (typeof require.resolveWeak === 'function') ? t.identifier('resolveWeak') : t.identifier('resolve')",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2018-11-18T19:42:47Z",
    "isReviewComment": true,
    "pullRequestReviewId": 176102881,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:53.793Z"
  },
  {
    "repo": "vercel/next.js",
    "prNumber": 3584,
    "prTitle": "Simplify nerv example. (#3573)",
    "prAuthor": "billymoon",
    "prLink": "https://github.com/vercel/next.js/pull/3584",
    "commentAuthor": "timneutkens",
    "commentBody": "By removing this react is used for SSR and nerv for client side rendering. Probably not what you'd want.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vercel/next.js/pull/3584#discussion_r162307577",
    "filePath": "examples/using-nerv/server.js",
    "diffHunk": "@@ -1,29 +0,0 @@\n-const port = parseInt(process.env.PORT, 10) || 3000\n-const dev = process.env.NODE_ENV !== 'production'\n-const moduleAlias = require('module-alias')\n-\n-// For the development version, we'll use React.\n-// Because, it support react hot loading and so on.\n-if (!dev) {\n-  moduleAlias.addAlias('react', 'nervjs')",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2018-01-18T10:51:50Z",
    "isReviewComment": true,
    "pullRequestReviewId": 89740124,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:53.776Z"
  },
  {
    "repo": "apache/kafka",
    "prNumber": 17793,
    "prTitle": "KAFKA-17928: Make remote log manager thread-pool configs dynamic",
    "prAuthor": "peterxcli",
    "prLink": "https://github.com/apache/kafka/pull/17793",
    "commentAuthor": "kamalcph",
    "commentBody": "We also have to update the BrokerDynamicThreadPool.reconfigurableConfigs() method to return only the below configs:\r\n\r\n1. ServerConfigs.NUM_IO_THREADS_CONFIG\r\n2. ReplicationConfigs.NUM_REPLICA_FETCHERS_CONFIG\r\n3. ServerLogConfigs.NUM_RECOVERY_THREADS_PER_DATA_DIR_CONFIG and\r\n4. ServerConfigs.BACKGROUND_THREADS_CONFIG\r\n\r\nOtherwise for the newly added RemoteLogManager configs, it gets double registered as brokerReconfigurable in both BrokerDynamicThreadPool and  RemoteLogDynamicThreadPool.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/apache/kafka/pull/17793#discussion_r1845012900",
    "filePath": "core/src/main/scala/kafka/server/DynamicBrokerConfig.scala",
    "diffHunk": "@@ -771,7 +772,10 @@ object DynamicThreadPool {\n     ServerConfigs.NUM_IO_THREADS_CONFIG,\n     ReplicationConfigs.NUM_REPLICA_FETCHERS_CONFIG,\n     ServerLogConfigs.NUM_RECOVERY_THREADS_PER_DATA_DIR_CONFIG,\n-    ServerConfigs.BACKGROUND_THREADS_CONFIG)\n+    ServerConfigs.BACKGROUND_THREADS_CONFIG, \n+    RemoteLogManagerConfig.REMOTE_LOG_MANAGER_COPIER_THREAD_POOL_SIZE_PROP,\n+    RemoteLogManagerConfig.REMOTE_LOG_MANAGER_EXPIRATION_THREAD_POOL_SIZE_PROP,\n+    RemoteLogManagerConfig.REMOTE_LOG_READER_THREADS_PROP)",
    "line": 16,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 274481523,
        "node_id": "REA_lATOACG9q85t-KmkzhBcQXM",
        "user": {
          "login": "peterxcli",
          "id": 54034701,
          "node_id": "MDQ6VXNlcjU0MDM0NzAx",
          "avatar_url": "https://avatars.githubusercontent.com/u/54034701?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/peterxcli",
          "html_url": "https://github.com/peterxcli",
          "followers_url": "https://api.github.com/users/peterxcli/followers",
          "following_url": "https://api.github.com/users/peterxcli/following{/other_user}",
          "gists_url": "https://api.github.com/users/peterxcli/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/peterxcli/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/peterxcli/subscriptions",
          "organizations_url": "https://api.github.com/users/peterxcli/orgs",
          "repos_url": "https://api.github.com/users/peterxcli/repos",
          "events_url": "https://api.github.com/users/peterxcli/events{/privacy}",
          "received_events_url": "https://api.github.com/users/peterxcli/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "heart",
        "created_at": "2024-11-18T12:31:01Z"
      },
      {
        "id": 274481532,
        "node_id": "REA_lATOACG9q85t-KmkzhBcQXw",
        "user": {
          "login": "peterxcli",
          "id": 54034701,
          "node_id": "MDQ6VXNlcjU0MDM0NzAx",
          "avatar_url": "https://avatars.githubusercontent.com/u/54034701?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/peterxcli",
          "html_url": "https://github.com/peterxcli",
          "followers_url": "https://api.github.com/users/peterxcli/followers",
          "following_url": "https://api.github.com/users/peterxcli/following{/other_user}",
          "gists_url": "https://api.github.com/users/peterxcli/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/peterxcli/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/peterxcli/subscriptions",
          "organizations_url": "https://api.github.com/users/peterxcli/orgs",
          "repos_url": "https://api.github.com/users/peterxcli/repos",
          "events_url": "https://api.github.com/users/peterxcli/events{/privacy}",
          "received_events_url": "https://api.github.com/users/peterxcli/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "hooray",
        "created_at": "2024-11-18T12:31:05Z"
      }
    ],
    "timestamp": "2024-11-16T15:54:40Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2440686910,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:02:42.816Z"
  },
  {
    "repo": "apache/kafka",
    "prNumber": 17046,
    "prTitle": "KAFKA-17347: Add missing client-metrics option to kafka-configs.sh",
    "prAuthor": "AndrewJSchofield",
    "prLink": "https://github.com/apache/kafka/pull/17046",
    "commentAuthor": "chia7712",
    "commentBody": "the arguments generated by this test case is `--client-metrics --alter --entity-name cm --add-config interval.ms=6000,metrics=`, but that is illegal actually since the \"--alter\" is viewed as entity name. It can work since we don't call check and `ConfigCommand#alterConfig` process only first entity. Luckily, \"cm\" is the first entity\r\n\r\nMaybe we can handle this in follow-up as it needs minor refactor. the tests of other resource types have similar issue.\r\n\r\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/apache/kafka/pull/17046#discussion_r1755095302",
    "filePath": "core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java",
    "diffHunk": "@@ -325,6 +358,35 @@ private void verifyGroupConfigUpdate() throws Exception {\n         }\n     }\n \n+\n+    @ClusterTest(types = {Type.KRAFT})\n+    public void testClientMetricsConfigUpdate() throws Exception {\n+        alterOpts = asList(\"--bootstrap-server\", cluster.bootstrapServers(), \"--entity-type\", \"client-metrics\", \"--alter\");\n+        verifyClientMetricsConfigUpdate();\n+\n+        // Test for the --client-metrics alias\n+        alterOpts = asList(\"--bootstrap-server\", cluster.bootstrapServers(), \"--client-metrics\", \"--alter\");",
    "line": 65,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-09-11T16:08:12Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2297773076,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:55.682Z"
  },
  {
    "repo": "apache/kafka",
    "prNumber": 15904,
    "prTitle": "MINOR: fix LogValidatorTest#checkNonCompressed",
    "prAuthor": "chia7712",
    "prLink": "https://github.com/apache/kafka/pull/15904",
    "commentAuthor": "vincent81jiang",
    "commentBody": "If I understand this test case correctly, there might still be a minor issue with \"checkRecompression\":\r\n1. at line 455, `records` should be created with \"CompressionType.NONE\".\r\n2. at line 502, the check should be `assertEquals(1, validatedRecords.batches().asScala.size)`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/apache/kafka/pull/15904#discussion_r1598902252",
    "filePath": "core/src/test/scala/unit/kafka/log/LogValidatorTest.scala",
    "diffHunk": "@@ -488,8 +496,11 @@ class LogValidatorTest {\n     }\n     assertEquals(now + 1, validatingResults.maxTimestampMs,\n       s\"Max timestamp should be ${now + 1}\")\n-    assertEquals(2, validatingResults.shallowOffsetOfMaxTimestamp,\n-      \"Shallow offset of max timestamp should be 2\")\n+\n+    // Both V2 and V1 has single branch in the record when compression is enable, and hence their shallow OffsetOfMaxTimestamp\n+    // is the last offset of the single branch\n+    assertEquals(1, records.batches().asScala.size)",
    "line": 35,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-05-13T18:49:49Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2053454936,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:55.682Z"
  },
  {
    "repo": "apache/kafka",
    "prNumber": 15373,
    "prTitle": "Image test improvements",
    "prAuthor": "ahuang98",
    "prLink": "https://github.com/apache/kafka/pull/15373",
    "commentAuthor": "chia7712",
    "commentBody": "`ReplicaManagerTest` reuse the `IMAGE1` to test the listeners, hence this change break some test cases. Do you have free cycle to fix it? If not, I can file PR to fix it :)",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/apache/kafka/pull/15373#discussion_r1544335647",
    "filePath": "metadata/src/test/java/org/apache/kafka/image/ClusterImageTest.java",
    "diffHunk": "@@ -88,7 +101,7 @@ public class ClusterImageTest {\n             setId(2).\n             setEpoch(123).\n             setIncarnationId(Uuid.fromString(\"hr4TVh3YQiu3p16Awkka6w\")).\n-            setListeners(Arrays.asList(new Endpoint(\"PLAINTEXT\", SecurityProtocol.PLAINTEXT, \"localhost\", 9093))).\n+            setListeners(Arrays.asList(new Endpoint(\"PLAINTEXT\", SecurityProtocol.PLAINTEXT, \"localhost\", 9094))).",
    "line": 50,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-03-29T10:25:36Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1968264637,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:55.489Z"
  },
  {
    "repo": "apache/kafka",
    "prNumber": 14768,
    "prTitle": "KAFKA-14438: Throw error when consumer configured with empty/whitespace-only group.id for AsyncKafkaConsumer",
    "prAuthor": "kirktrue",
    "prLink": "https://github.com/apache/kafka/pull/14768",
    "commentAuthor": "AndrewJSchofield",
    "commentBody": "This works for a group id which is the empty string, but not for a whitespace string. I think `this.groupId.get().trim().isEmpty()` will do it.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/apache/kafka/pull/14768#discussion_r1394820539",
    "filePath": "clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java",
    "diffHunk": "@@ -163,11 +163,9 @@ public class AsyncKafkaConsumer<K, V> implements ConsumerDelegate<K, V> {\n             this.clientId = config.getString(CommonClientConfigs.CLIENT_ID_CONFIG);\n             LogContext logContext = createLogContext(config, groupRebalanceConfig);\n             this.log = logContext.logger(getClass());\n-            groupId.ifPresent(groupIdStr -> {\n-                if (groupIdStr.isEmpty()) {\n-                    log.warn(\"Support for using the empty group id by consumers is deprecated and will be removed in the next major release.\");\n-                }\n-            });\n+\n+            if (this.groupId.isPresent() && this.groupId.get().isEmpty())",
    "line": 10,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-11-15T21:24:23Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1733014092,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:55.495Z"
  },
  {
    "repo": "apache/kafka",
    "prNumber": 14607,
    "prTitle": "KAFKA-14484: [1/N] Move PartitionMetadataFile to storage module",
    "prAuthor": "alok123t",
    "prLink": "https://github.com/apache/kafka/pull/14607",
    "commentAuthor": "jolshan",
    "commentBody": "I don't think this should be a reference comparison. Perhaps a miss in the scala -> java conversion.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/apache/kafka/pull/14607#discussion_r1560454922",
    "filePath": "storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFile.java",
    "diffHunk": "@@ -0,0 +1,141 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License. You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.kafka.storage.internals.checkpoint;\n+\n+import org.apache.kafka.common.Uuid;\n+import org.apache.kafka.common.errors.InconsistentTopicIdException;\n+import org.apache.kafka.common.errors.KafkaStorageException;\n+import org.apache.kafka.common.utils.Utils;\n+import org.apache.kafka.storage.internals.log.LogDirFailureChannel;\n+\n+import java.io.BufferedReader;\n+import java.io.BufferedWriter;\n+import java.io.File;\n+import java.io.FileOutputStream;\n+import java.io.IOException;\n+import java.io.OutputStreamWriter;\n+import java.nio.charset.StandardCharsets;\n+import java.nio.file.Files;\n+import java.nio.file.Path;\n+import java.nio.file.Paths;\n+import java.util.Optional;\n+\n+public class PartitionMetadataFile {\n+    private static final String PARTITION_METADATA_FILE_NAME = \"partition.metadata\";\n+    static final int CURRENT_VERSION = 0;\n+\n+    public static File newFile(File dir) {\n+        return new File(dir, PARTITION_METADATA_FILE_NAME);\n+    }\n+\n+    private final File file;\n+    private final LogDirFailureChannel logDirFailureChannel;\n+\n+    private final Object lock = new Object();\n+    private volatile Optional<Uuid> dirtyTopicIdOpt = Optional.empty();\n+\n+    public PartitionMetadataFile(\n+        final File file,\n+        final LogDirFailureChannel logDirFailureChannel\n+    ) {\n+        this.file = file;\n+        this.logDirFailureChannel = logDirFailureChannel;\n+    }\n+\n+    /**\n+     * Records the topic ID that will be flushed to disk.\n+     */\n+    public void record(Uuid topicId) {\n+        // Topic IDs should not differ, but we defensively check here to fail earlier in the case that the IDs somehow differ.\n+        dirtyTopicIdOpt.ifPresent(dirtyTopicId -> {\n+            if (dirtyTopicId != topicId) {",
    "line": 66,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 243161078,
        "node_id": "REA_lATOACG9q85dAqcKzg5-V_Y",
        "user": {
          "login": "alok123t",
          "id": 13995209,
          "node_id": "MDQ6VXNlcjEzOTk1MjA5",
          "avatar_url": "https://avatars.githubusercontent.com/u/13995209?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/alok123t",
          "html_url": "https://github.com/alok123t",
          "followers_url": "https://api.github.com/users/alok123t/followers",
          "following_url": "https://api.github.com/users/alok123t/following{/other_user}",
          "gists_url": "https://api.github.com/users/alok123t/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/alok123t/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/alok123t/subscriptions",
          "organizations_url": "https://api.github.com/users/alok123t/orgs",
          "repos_url": "https://api.github.com/users/alok123t/repos",
          "events_url": "https://api.github.com/users/alok123t/events{/privacy}",
          "received_events_url": "https://api.github.com/users/alok123t/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2024-04-11T07:50:23Z"
      }
    ],
    "timestamp": "2024-04-11T05:34:13Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1993313546,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:58.004Z"
  },
  {
    "repo": "apache/kafka",
    "prNumber": 13960,
    "prTitle": "KAFKA-15129;[6/N] Remove metrics in ControllerStats when broker shutdown",
    "prAuthor": "hudeqi",
    "prLink": "https://github.com/apache/kafka/pull/13960",
    "commentAuthor": "divijvaidya",
    "commentBody": "remove entry from timerMetricNames as well else it keeps growing",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/apache/kafka/pull/13960#discussion_r1254402158",
    "filePath": "core/src/main/scala/kafka/controller/KafkaController.scala",
    "diffHunk": "@@ -2788,6 +2796,20 @@ private[controller] class ControllerStats {\n   def removeMetric(name: String): Unit = {\n     metricsGroup.removeMetric(name)\n   }\n+\n+  def removeMetrics(): Unit = {\n+    MeterMetricNames.foreach(metricsGroup.removeMetric(_))\n+    timerMetricNames.asScala.foreach(metricsGroup.removeMetric(_))",
    "line": 74,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 210794167,
        "node_id": "REA_lATOACG9q85KxKhuzgyQdrc",
        "user": {
          "login": "hudeqi",
          "id": 16536770,
          "node_id": "MDQ6VXNlcjE2NTM2Nzcw",
          "avatar_url": "https://avatars.githubusercontent.com/u/16536770?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/hudeqi",
          "html_url": "https://github.com/hudeqi",
          "followers_url": "https://api.github.com/users/hudeqi/followers",
          "following_url": "https://api.github.com/users/hudeqi/following{/other_user}",
          "gists_url": "https://api.github.com/users/hudeqi/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/hudeqi/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/hudeqi/subscriptions",
          "organizations_url": "https://api.github.com/users/hudeqi/orgs",
          "repos_url": "https://api.github.com/users/hudeqi/repos",
          "events_url": "https://api.github.com/users/hudeqi/events{/privacy}",
          "received_events_url": "https://api.github.com/users/hudeqi/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2023-07-06T15:42:07Z"
      }
    ],
    "timestamp": "2023-07-06T12:58:54Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1516489697,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:57.575Z"
  },
  {
    "repo": "apache/kafka",
    "prNumber": 13501,
    "prTitle": "MINOR: Use `exists` instead of return in DelayedFetch",
    "prAuthor": "splett2",
    "prLink": "https://github.com/apache/kafka/pull/13501",
    "commentAuthor": "jolshan",
    "commentBody": "Does this have the same semantics if forceComplete returns false?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/apache/kafka/pull/13501#discussion_r1158802468",
    "filePath": "core/src/main/scala/kafka/server/DelayedFetch.scala",
    "diffHunk": "@@ -93,14 +93,14 @@ class DelayedFetch(\n               if (endOffset.onOlderSegment(fetchOffset)) {\n                 // Case F, this can happen when the new fetch operation is on a truncated leader\n                 debug(s\"Satisfying fetch $this since it is fetching later segments of partition $topicIdPartition.\")\n-                return forceComplete()\n+                forceComplete()",
    "line": 14,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-04-05T17:16:32Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1373359023,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:58.121Z"
  },
  {
    "repo": "apache/kafka",
    "prNumber": 12006,
    "prTitle": "KAFKA-13794: Follow up to fix comparator",
    "prAuthor": "ddrid",
    "prLink": "https://github.com/apache/kafka/pull/12006",
    "commentAuthor": "ijuma",
    "commentBody": "Hmm, `hashCode` can have collisions. This doesn't seem right either.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/apache/kafka/pull/12006#discussion_r850003757",
    "filePath": "clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java",
    "diffHunk": "@@ -187,7 +187,7 @@ private static class TopicPartitionEntry {\n         private static final Comparator<ProducerBatch> PRODUCER_BATCH_COMPARATOR = (b1, b2) -> {\n             if (b1.baseSequence() < b2.baseSequence()) return -1;\n             else if (b1.baseSequence() > b2.baseSequence()) return 1;\n-            else return b1.equals(b2) ? 0 : 1;\n+            else return Integer.compare(b1.hashCode(), b2.hashCode());",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-04-14T01:00:08Z",
    "isReviewComment": true,
    "pullRequestReviewId": 941689514,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:59.872Z"
  },
  {
    "repo": "apache/kafka",
    "prNumber": 11991,
    "prTitle": "KAFKA-13794: Fix comparator of inflightBatchesBySequence in TransactionManager",
    "prAuthor": "ddrid",
    "prLink": "https://github.com/apache/kafka/pull/11991",
    "commentAuthor": "artemlivshits",
    "commentBody": "Wouldn't this violate the requirements for the `compare` method?\r\n\r\n>The implementor must ensure that sgn(compare(x, y)) == -sgn(compare(y, x)) for all x and y. (This implies that compare(x, y) must throw an exception if and only if compare(y, x) throws an exception.)\r\n\r\n> The implementor must also ensure that the relation is transitive: ((compare(x, y)>0) && (compare(y, z)>0)) implies compare(x, z)>0.\r\n\r\nObjects that are not equal need to have a stable order otherwise, binary search may not find the objects.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/apache/kafka/pull/11991#discussion_r843285049",
    "filePath": "clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java",
    "diffHunk": "@@ -184,16 +184,22 @@ private void startSequencesAtBeginning(TopicPartition topicPartition, ProducerId\n         // responses which are due to the retention period elapsing, and those which are due to actual lost data.\n         private long lastAckedOffset;\n \n+        private static final Comparator<ProducerBatch> PRODUCER_BATCH_COMPARATOR = (b1, b2) -> {\n+            if (b1.baseSequence() < b2.baseSequence()) return -1;\n+            else if (b1.baseSequence() > b2.baseSequence()) return 1;\n+            else return b1.equals(b2) ? 0 : 1;",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-04-05T21:40:40Z",
    "isReviewComment": true,
    "pullRequestReviewId": 932548069,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:59.915Z"
  },
  {
    "repo": "apache/kafka",
    "prNumber": 11689,
    "prTitle": "Fixed documentation and handles null topicPartition for KAFKA-12841",
    "prAuthor": "philipnee",
    "prLink": "https://github.com/apache/kafka/pull/11689",
    "commentAuthor": "junrao",
    "commentBody": "@philipnee : It seems that we may have introduced a bug here. interceptors.onAcknowledgement() is now called twice, once through interceptCallback.onCompletion() and another through interceptors.onSendError() in line 1010 below.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/apache/kafka/pull/11689#discussion_r852429053",
    "filePath": "clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java",
    "diffHunk": "@@ -995,8 +995,17 @@ private Future<RecordMetadata> doSend(ProducerRecord<K, V> record, Callback call\n             // for other exceptions throw directly\n         } catch (ApiException e) {\n             log.debug(\"Exception occurred during message send:\", e);\n-            if (callback != null)\n-                callback.onCompletion(null, e);\n+            // producer callback will make sure to call both 'callback' and interceptor callback\n+            if (tp == null) {\n+                // set topicPartition to -1 when null\n+                tp = ProducerInterceptors.extractTopicPartition(record);\n+            }\n+\n+            Callback interceptCallback = new InterceptorCallback<>(callback, this.interceptors, tp);\n+\n+            // The onCompletion callback does expect a non-null metadata, but one will be created inside\n+            // the interceptor's onCompletion implementation before the user's callback is invoked.\n+            interceptCallback.onCompletion(null, e);",
    "line": 16,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 159940562,
        "node_id": "REA_lATOACG9q84yzwj9zgmIf9I",
        "user": {
          "login": "philipnee",
          "id": 1930388,
          "node_id": "MDQ6VXNlcjE5MzAzODg=",
          "avatar_url": "https://avatars.githubusercontent.com/u/1930388?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/philipnee",
          "html_url": "https://github.com/philipnee",
          "followers_url": "https://api.github.com/users/philipnee/followers",
          "following_url": "https://api.github.com/users/philipnee/following{/other_user}",
          "gists_url": "https://api.github.com/users/philipnee/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/philipnee/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/philipnee/subscriptions",
          "organizations_url": "https://api.github.com/users/philipnee/orgs",
          "repos_url": "https://api.github.com/users/philipnee/repos",
          "events_url": "https://api.github.com/users/philipnee/events{/privacy}",
          "received_events_url": "https://api.github.com/users/philipnee/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2022-04-18T22:45:48Z"
      }
    ],
    "timestamp": "2022-04-18T21:31:20Z",
    "isReviewComment": true,
    "pullRequestReviewId": 944846541,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:55:59.672Z"
  },
  {
    "repo": "elixir-lang/elixir",
    "prNumber": 13751,
    "prTitle": "Use System.cmd rather than System.shell for Rebar3 to avoid escaping",
    "prAuthor": "josevalim",
    "prLink": "https://github.com/elixir-lang/elixir/pull/13751",
    "commentAuthor": "michallepicki",
    "commentBody": "Dialyzer points out that `Mix.Rebar.local_rebar_path(:rebar3)` always returns a binary so it's truthy, so `|| handle_rebar_not_found(dep)` and the whole `def handle_rebar_not_found` function are unreachable",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/elixir-lang/elixir/pull/13751#discussion_r1699537681",
    "filePath": "lib/mix/lib/mix/tasks/deps.compile.ex",
    "diffHunk": "@@ -207,8 +207,15 @@ defmodule Mix.Tasks.Deps.Compile do\n       {\"TERM\", \"dumb\"}\n     ]\n \n-    cmd = \"#{rebar_cmd(dep)} bare compile --paths #{escape_path(lib_path)}\"\n-    do_command(dep, config, cmd, false, env)\n+    rebar = Mix.Rebar.local_rebar_path(:rebar3) || handle_rebar_not_found(dep)",
    "line": 6,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-08-01T06:56:12Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2211798726,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:01.770Z"
  },
  {
    "repo": "elixir-lang/elixir",
    "prNumber": 12541,
    "prTitle": "add relative_to for formatter_for_file",
    "prAuthor": "DianaOlympos",
    "prLink": "https://github.com/elixir-lang/elixir/pull/12541",
    "commentAuthor": "josevalim",
    "commentBody": "This is broken. `prefix` is meant to be a list and if you pass `:root` as a string, it won't work.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/elixir-lang/elixir/pull/12541#discussion_r1186899034",
    "filePath": "lib/mix/lib/mix/tasks/format.ex",
    "diffHunk": "@@ -251,10 +251,12 @@ defmodule Mix.Tasks.Format do\n   def formatter_for_file(file, opts \\\\ []) do\n     {dot_formatter, formatter_opts} = eval_dot_formatter(opts)\n \n+    prefix = Keyword.get(opts, :root, [])\n+\n     {formatter_opts_and_subs, _sources} =\n-      eval_deps_and_subdirectories(dot_formatter, [], formatter_opts, [dot_formatter])\n+      eval_deps_and_subdirectories(dot_formatter, prefix, formatter_opts, [dot_formatter])",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-05-07T18:58:19Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1415949753,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:01.522Z"
  },
  {
    "repo": "elixir-lang/elixir",
    "prNumber": 7114,
    "prTitle": "Fix Stream.chunk_every/4 odd results when step > count",
    "prAuthor": "albertoalmagro",
    "prLink": "https://github.com/elixir-lang/elixir/pull/7114",
    "commentAuthor": "ggcampinho",
    "commentBody": "I think `count == acc_count` is a problem, you can test with:\r\n```\r\nassert Enum.chunk_every([1, 2, 3, 4, 5, 6, 7], 2, 4, []) == [[1, 2], [5, 6]]\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/elixir-lang/elixir/pull/7114#discussion_r157104327",
    "filePath": "lib/elixir/lib/stream/reducers.ex",
    "diffHunk": "@@ -25,7 +25,7 @@ defmodule Stream.Reducers do\n     end\n \n     after_fun = fn {acc_buffer, acc_count} ->\n-      if leftover == :discard or acc_count == 0 do\n+      if leftover == :discard or acc_count == 0 or (step > count and count == acc_count) do",
    "line": 5,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 17340175,
        "node_id": "MDMyOlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudFJlYWN0aW9uMTczNDAxNzU=",
        "user": {
          "login": "albertoalmagro",
          "id": 671550,
          "node_id": "MDQ6VXNlcjY3MTU1MA==",
          "avatar_url": "https://avatars.githubusercontent.com/u/671550?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/albertoalmagro",
          "html_url": "https://github.com/albertoalmagro",
          "followers_url": "https://api.github.com/users/albertoalmagro/followers",
          "following_url": "https://api.github.com/users/albertoalmagro/following{/other_user}",
          "gists_url": "https://api.github.com/users/albertoalmagro/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/albertoalmagro/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/albertoalmagro/subscriptions",
          "organizations_url": "https://api.github.com/users/albertoalmagro/orgs",
          "repos_url": "https://api.github.com/users/albertoalmagro/repos",
          "events_url": "https://api.github.com/users/albertoalmagro/events{/privacy}",
          "received_events_url": "https://api.github.com/users/albertoalmagro/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2017-12-15T08:21:50Z"
      }
    ],
    "timestamp": "2017-12-15T01:12:41Z",
    "isReviewComment": true,
    "pullRequestReviewId": 83694177,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:03.548Z"
  },
  {
    "repo": "elixir-lang/elixir",
    "prNumber": 6879,
    "prTitle": "Better `mix format` error message when it crashes during formatting file",
    "prAuthor": "hubertlepicki",
    "prLink": "https://github.com/elixir-lang/elixir/pull/6879",
    "commentAuthor": "josevalim",
    "commentBody": "Btw, you need to read the stacktrace as the first step in a rescue. That's because if `Mix.shell().error` try/catch something, then the stacktrace value changes. But no worries, I will fix it locally!",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/elixir-lang/elixir/pull/6879#discussion_r143974800",
    "filePath": "lib/mix/lib/mix/tasks/format.ex",
    "diffHunk": "@@ -177,6 +177,10 @@ defmodule Mix.Tasks.Format do\n     end\n \n     {not_equivalent, not_formatted}\n+  rescue\n+    e ->\n+      Mix.shell().error(\"mix format failed when parsing file: #{file}\")\n+      reraise e, System.stacktrace()",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2017-10-11T10:48:54Z",
    "isReviewComment": true,
    "pullRequestReviewId": 68563139,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:03.402Z"
  },
  {
    "repo": "elixir-lang/elixir",
    "prNumber": 5822,
    "prTitle": "Inspect Opts Printable String Limit",
    "prAuthor": "benwilson512",
    "prLink": "https://github.com/elixir-lang/elixir/pull/5822",
    "commentAuthor": "josevalim",
    "commentBody": "Unfortunately slice works on graphemes while printable? works on codepoints, so you may end-up getting more than what you checked. My suggestion is to move the limit to `escape/2`, which also works on codepoints, and stop escaping when you reach a certain limit.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/elixir-lang/elixir/pull/5822#discussion_r103258323",
    "filePath": "lib/elixir/lib/inspect.ex",
    "diffHunk": "@@ -99,8 +99,9 @@ defimpl Inspect, for: Atom do\n end\n \n defimpl Inspect, for: BitString do\n-  def inspect(term, %Inspect.Opts{binaries: bins, base: base} = opts) when is_binary(term) do\n-    if base == :decimal and (bins == :as_strings or (bins == :infer and String.printable?(term))) do\n+  def inspect(term, %Inspect.Opts{binaries: bins, base: base, printable_limit: printable_limit} = opts) when is_binary(term) do\n+    if base == :decimal and (bins == :as_strings or (bins == :infer and String.printable?(term, printable_limit))) do\n+      term = String.slice(term, 0..printable_limit)",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2017-02-27T17:06:42Z",
    "isReviewComment": true,
    "pullRequestReviewId": 24039421,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:05.513Z"
  },
  {
    "repo": "elixir-lang/elixir",
    "prNumber": 4304,
    "prTitle": "Optimize Enum.random for ranges",
    "prAuthor": "chrismccord",
    "prLink": "https://github.com/elixir-lang/elixir/pull/4304",
    "commentAuthor": "lexmag",
    "commentBody": "`random_index` only works for non negative integers.\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/elixir-lang/elixir/pull/4304#discussion_r53059617",
    "filePath": "lib/elixir/lib/enum.ex",
    "diffHunk": "@@ -2176,6 +2174,14 @@ defmodule Enum do\n   @spec take_random(t, integer) :: list\n   def take_random(_enumerable, 0), do: []\n \n+  def take_random(first..last, 1) when first > last do\n+    take_random(last..first, 1)\n+  end\n+\n+  def take_random(first..last, 1) do\n+    [random_index(last - first) + first]",
    "line": 20,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2016-02-16T18:59:44Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:05.645Z"
  },
  {
    "repo": "elixir-lang/elixir",
    "prNumber": 1045,
    "prTitle": "Pretty printing implemented",
    "prAuthor": "manpages",
    "prLink": "https://github.com/elixir-lang/elixir/pull/1045",
    "commentAuthor": "yrashk",
    "commentBody": "Wadler.TEXT and Wadler.Text will likely not work correctly on platforms with case insensitive file naming (for example, Mac OS X)\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/elixir-lang/elixir/pull/1045#discussion_r4183929",
    "filePath": "lib/elixir/lib/wadler.ex",
    "diffHunk": "@@ -0,0 +1,515 @@\n+defmodule Wadler do\n+  @moduledoc \"\"\"\n+  Pretty printing library inspired by Philip Wadler.\n+\n+  Custom pretty printers can be implemented using\n+  functions, exported from this module.\n+\n+  ## Examples\n+\n+    iex> Wadler.text \"foo\"                      \n+    Wadler.TEXT[string: \"foo\"]\n+    \n+    iex> Wadler.group(Wadler.concat(Wadler.text(\"1\"), Wadler.concat(Wadler.line, Wadler.text(\"2\"))))\n+    Wadler.UNION[\n+      left: Wadler.CONCAT[\n+        left: Wadler.TEXT[string: \"1\"], \n+        right: Wadler.CONCAT[left: Wadler.TEXT[string: \" \"], right: Wadler.TEXT[string: \"2\"]] \n+      ], \n+      right: Wadler.CONCAT[\n+        left: Wadler.TEXT[string: \"1\"], \n+        right: Wadler.CONCAT[left: LINE, right: Wadler.TEXT[string: \"2\"]]\n+      ]\n+    ]\n+\n+  \"\"\"\n+\n+  # Records to work with variant document representation\n+  # Those are generalized by `docentity` type.\n+  # Note that function that returns atom NIL is called `null`\n+  @type docentity :: TEXT.t | CONCAT.t | UNION.t | NEST.t | GLUE.t | NIL | LINE\n+  defrecord TEXT, string: \"\"\n+  defrecord CONCAT, left: nil, right: nil\n+  defrecord UNION, left: nil, right: nil\n+  defrecord NEST, indent: 1, rest: nil\n+  defrecord GLUE, string: \"\" \n+\n+  # Records that represent finalized entities in a document\n+  # Those are generalized by `docfactor` type.\n+  @type docfactor :: Text.t | Line.t | Nil\n+  defrecord Text, string: \"\", rest: nil",
    "line": 40,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2013-05-11T19:03:20Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:08.060Z"
  },
  {
    "repo": "phoenixframework/phoenix",
    "prNumber": 2144,
    "prTitle": "Port tests from phoenix.gen.{html,json,model} to phx.gen.{html,json,schema}",
    "prAuthor": "adamgavlak",
    "prLink": "https://github.com/phoenixframework/phoenix/pull/2144",
    "commentAuthor": "josevalim",
    "commentBody": "This is incorrect :) It should be a belongs_to. :)",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/phoenixframework/phoenix/pull/2144#discussion_r104111852",
    "filePath": "test/mix/tasks/phx.gen.schema_test.exs",
    "diffHunk": "@@ -36,6 +36,98 @@ defmodule Mix.Tasks.Phx.Gen.SchemaTest do\n     end\n   end\n \n+  test \"generates custom table name\", config do\n+    in_tmp_project config.test, fn ->\n+      Gen.Schema.run(~w(Blog.Post posts --table cms_posts))\n+\n+      assert [migration] = Path.wildcard(\"priv/repo/migrations/*_create_blog_post.exs\")\n+\n+      assert_file migration, fn file ->\n+        assert file =~ \"create table(:cms_posts) do\"\n+      end\n+    end\n+  end\n+\n+  test \"generates nested context\", config do\n+    in_tmp_project config.test, fn ->\n+      Gen.Schema.run(~w(Blog.Admin.User users name:string))\n+\n+      assert [migration] = Path.wildcard(\"priv/repo/migrations/*_create_blog_admin_user.exs\")\n+\n+      assert_file migration, fn file ->\n+        assert file =~ \"defmodule Phoenix.Repo.Migrations.CreatePhoenix.Blog.Admin.User do\"\n+        assert file =~ \"create table(:users) do\"\n+      end\n+\n+      assert_file \"lib/phoenix/blog/admin/user.ex\", fn file ->\n+        assert file =~ \"defmodule Phoenix.Blog.Admin.User do\"\n+        assert file =~ \"schema \\\"users\\\" do\"\n+      end\n+    end\n+  end\n+\n+  test \"generates belongs_to associations with association table provided by user\", config do\n+    in_tmp_project config.test, fn ->\n+      Gen.Schema.run(~w(Blog.Post posts title user_id:references:users))\n+\n+      assert [migration] = Path.wildcard(\"priv/repo/migrations/*_create_blog_post.exs\")\n+\n+      assert_file migration, fn file ->\n+        assert file =~ \"add :user_id, {:references, :users}\"",
    "line": 41,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2017-03-03T09:00:38Z",
    "isReviewComment": true,
    "pullRequestReviewId": 24928734,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:08.093Z"
  },
  {
    "repo": "phoenixframework/phoenix",
    "prNumber": 142,
    "prTitle": "Use phoenix and elixir version from mix.exs in task to create new phoeni...",
    "prAuthor": "lau",
    "prLink": "https://github.com/phoenixframework/phoenix/pull/142",
    "commentAuthor": "ericmj",
    "commentBody": "This will get the config of the current mix project when the code is run, which wont exist since you are creating a new mix project. If you `unquote` `Keyword.get(Mix.Project.config, ...)` it will get the mix config when phoenix is being compiled.\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/phoenixframework/phoenix/pull/142#discussion_r14405624",
    "filePath": "lib/mix/tasks/phoenix/new.ex",
    "diffHunk": "@@ -14,7 +14,9 @@ defmodule Mix.Tasks.Phoenix.New do\n     project_path = make_project_path(path, application_name)\n \n     bindings = [application_name: application_name,\n-                application_module: application_module]\n+                application_module: application_module,\n+                phoenix_version: Keyword.get(Mix.Project.config, :version),\n+                elixir_version: Keyword.get(Mix.Project.config, :elixir)]",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2014-07-01T14:10:24Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:07.848Z"
  },
  {
    "repo": "sveltejs/svelte",
    "prNumber": 12948,
    "prTitle": "breaking: deprecate `context=\"module\"` in favor of `module`",
    "prAuthor": "dummdidumm",
    "prLink": "https://github.com/sveltejs/svelte/pull/12948",
    "commentAuthor": "xeho91",
    "commentBody": "Wasn't this supposed to be `e.script_invalid_context(attribute);`?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/sveltejs/svelte/pull/12948#discussion_r1725796624",
    "filePath": "packages/svelte/src/compiler/phases/1-parse/read/script.js",
    "diffHunk": "@@ -60,14 +42,56 @@ export function read_script(parser, start, attributes) {\n \t// TODO is this necessary?\n \tast.start = script_start;\n \n+\t/** @type {'default' | 'module'} */\n+\tlet context = 'default';\n+\n+\tfor (const attribute of /** @type {Attribute[]} */ (attributes)) {\n+\t\tif (RESERVED_ATTRIBUTES.includes(attribute.name)) {\n+\t\t\te.script_reserved_attribute(attribute, attribute.name);\n+\t\t}\n+\n+\t\tif (!ALLOWED_ATTRIBUTES.includes(attribute.name)) {\n+\t\t\tw.script_unknown_attribute(attribute);\n+\t\t}\n+\n+\t\tif (attribute.name === 'module') {\n+\t\t\tif (attribute.value !== true) {\n+\t\t\t\t// Deliberately a generic code to future-proof for potential other attributes\n+\t\t\t\te.script_invalid_attribute_value(attribute, attribute.name);\n+\t\t\t}\n+\n+\t\t\tcontext = 'module';\n+\t\t}\n+\n+\t\tif (attribute.name === 'context') {\n+\t\t\tif (attribute.value === true || !is_text_attribute(attribute)) {\n+\t\t\t\tthrow new Error('TODO');",
    "line": 64,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-08-21T21:56:41Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2252009297,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:07.923Z"
  },
  {
    "repo": "sveltejs/svelte",
    "prNumber": 8443,
    "prTitle": "fix: call all event handlers even if an exception occurs in one",
    "prAuthor": "adiguba",
    "prLink": "https://github.com/sveltejs/svelte/pull/8443",
    "commentAuthor": "benmccann",
    "commentBody": "question for more knowledgeable reviewers: will this file be called during ssr? if so, we probably need to fix this reference to `window`. also note that `reportError` is not yet supported in Node",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/sveltejs/svelte/pull/8443#discussion_r1155232015",
    "filePath": "src/runtime/internal/lifecycle.ts",
    "diffHunk": "@@ -151,6 +149,25 @@ export function bubble(component, event) {\n \n \tif (callbacks) {\n \t\t// @ts-ignore\n-\t\tcallbacks.slice().forEach(fn => fn.call(this, event));\n+\t\tinvoke_callbacks(callbacks, this, event);\n \t}\n }\n+\n+// Invoke all callbacks, even if an error occur\n+function invoke_callbacks(callbacks, source, event) {\n+\tcallbacks.slice().forEach(fn => {\n+\t\ttry {\n+\t\t\tfn.call(source, event);\n+\t\t} catch (err) {\n+\t\t\t// @ts-ignore\n+\t\t\tif (window.reportError) {",
    "line": 27,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-04-02T03:12:10Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1368014049,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:09.634Z"
  },
  {
    "repo": "sveltejs/svelte",
    "prNumber": 7069,
    "prTitle": "fix: correct parent component link for web components",
    "prAuthor": "jsonn",
    "prLink": "https://github.com/sveltejs/svelte/pull/7069",
    "commentAuthor": "lloydzhou",
    "commentBody": "\"init\" function call in `constructor` of `SvelteElement`, can not get `parentNode`, so this PR can not fix the issue.\r\n\r\nyou can get `parentNode` in `connectedCallback`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/sveltejs/svelte/pull/7069#discussion_r967844724",
    "filePath": "src/runtime/internal/Component.ts",
    "diffHunk": "@@ -104,8 +104,24 @@ function make_dirty(component, i) {\n \tcomponent.$$.dirty[(i / 31) | 0] |= (1 << (i % 31));\n }\n \n+function is_svelte_element(component) {\n+  while (component) {\n+    if (component.constructor === SvelteElement)\n+      return true;\n+    component = Object.getPrototypeOf(component);\n+  }\n+  return false;\n+}\n+\n+function find_containing_component(component) {\n+  while (component && !is_svelte_element(component)) {\n+    component = component.parentNode;\n+  }\n+  return component;\n+}\n+\n export function init(component, options, instance, create_fragment, not_equal, props, append_styles, dirty = [-1]) {",
    "line": 20,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-09-11T15:14:13Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1103318017,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:09.686Z"
  },
  {
    "repo": "sveltejs/svelte",
    "prNumber": 5287,
    "prTitle": "Nonpassive event modifier",
    "prAuthor": "98mux",
    "prLink": "https://github.com/sveltejs/svelte/pull/5287",
    "commentAuthor": "tanhauhau",
    "commentBody": "should add validation to prevent `passive` and `nonpassive` to be used together",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/sveltejs/svelte/pull/5287#discussion_r472568942",
    "filePath": "src/compiler/compile/render_dom/wrappers/Element/EventHandler.ts",
    "diffHunk": "@@ -45,12 +45,24 @@ export default class EventHandlerWrapper {\n \n \t\tconst args = [];\n \n-\t\tconst opts = ['passive', 'once', 'capture'].filter(mod => this.node.modifiers.has(mod));\n-\t\tif (opts.length) {\n-\t\t\targs.push((opts.length === 1 && opts[0] === 'capture')\n-\t\t\t\t? TRUE\n-\t\t\t\t: x`{ ${opts.map(opt => p`${opt}: true`)} }`);\n-\t\t} else if (block.renderer.options.dev) {\n+\t\tconst opts = ['nonpassive', 'passive', 'once', 'capture'].filter(mod => this.node.modifiers.has(mod));\n+        if (opts.length) {\n+            let opts_as_string;\n+\n+            if (opts[0] === 'nonpassive') {\n+                opts.shift();\n+\n+                if (!opts.includes('passive')) {\n+                    opts.push('passive');\n+                }\n+                opts_as_string = opts.map(opt => p`${opt}: ${opt === 'passive' ? false : true}`);",
    "line": 20,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-08-19T00:38:56Z",
    "isReviewComment": true,
    "pullRequestReviewId": 469920913,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:09.736Z"
  },
  {
    "repo": "vuejs/core",
    "prNumber": 7963,
    "prTitle": "feat(types): `defineComponent()` with generics support",
    "prAuthor": "yyx990803",
    "prLink": "https://github.com/vuejs/core/pull/7963",
    "commentAuthor": "aa900031",
    "commentBody": "It would not be set correct name, if `options` is anonymous function and set name in `extraOptions`\r\n\r\ne.g\r\n\r\n```ts\r\nconst Comp = defineComponent(() => {\r\n  // ...\r\n}, {\r\n  name: 'Foo',\r\n})\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/vuejs/core/pull/7963#discussion_r1150019471",
    "filePath": "packages/runtime-core/src/apiDefineComponent.ts",
    "diffHunk": "@@ -198,6 +222,11 @@ export function defineComponent<\n ): DefineComponent<PropsOptions, RawBindings, D, C, M, Mixin, Extends, E, EE>\n \n // implementation, close to no-op\n-export function defineComponent(options: unknown) {\n-  return isFunction(options) ? { setup: options, name: options.name } : options\n+export function defineComponent(\n+  options: unknown,\n+  extraOptions?: ComponentOptions\n+) {\n+  return isFunction(options)\n+    ? extend({}, extraOptions, { setup: options, name: options.name })",
    "line": 75,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-03-28T04:42:55Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1360194489,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:11.995Z"
  },
  {
    "repo": "vuejs/core",
    "prNumber": 5306,
    "prTitle": "fix(cssVars): work with calc complex expression",
    "prAuthor": "edison1105",
    "prLink": "https://github.com/vuejs/core/pull/5306",
    "commentAuthor": "yyx990803",
    "commentBody": "This doesn't look right.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/vuejs/core/pull/5306#discussion_r790272681",
    "filePath": "packages/compiler-sfc/src/cssVars.ts",
    "diffHunk": "@@ -13,7 +13,7 @@ import hash from 'hash-sum'\n \n export const CSS_VARS_HELPER = `useCssVars`\n export const cssVarRE =\n-  /\\bv-bind\\s*\\(\\s*(?:'([^']+)'|\"([^\"]+)\"|([^'\"][^;]*))\\s*\\)/g\n+  /\\bv-bind\\s*\\(\\s*(?:'([^']+)'|\"([^\"]+)\"|([^'\"]|[\\w]*|[^;]*))\\s*\\)/g",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-01-23T12:54:56Z",
    "isReviewComment": true,
    "pullRequestReviewId": 860318977,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:12.615Z"
  },
  {
    "repo": "vuejs/core",
    "prNumber": 2254,
    "prTitle": "fix(runtime-dom): v-model.number work with select tag",
    "prAuthor": "edison1105",
    "prLink": "https://github.com/vuejs/core/pull/2254",
    "commentAuthor": "69hunter",
    "commentBody": "@edison1105, I would suggest handling the case of multiple select here.\r\nWhen the `el.multiple` is true, `domValue` will be assigned with an array from `selectedVal`.\r\nThe `domValue = toNumber(domValue)` will cast an array of numbers to number.\r\n\r\nThis will make the multiple select case throw an error of:\r\n```\r\n<select multiple v-model> expects an Array or Set value for its binding, but got Number.\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/vuejs/core/pull/2254#discussion_r499308398",
    "filePath": "packages/runtime-dom/src/directives/vModel.ts",
    "diffHunk": "@@ -166,12 +166,19 @@ export const vModelRadio: ModelDirective<HTMLInputElement> = {\n }\n \n export const vModelSelect: ModelDirective<HTMLSelectElement> = {\n-  created(el, binding, vnode) {\n+  created(el, { modifiers: { number } }, vnode) {\n     addEventListener(el, 'change', () => {\n+      const castToNumber = number\n       const selectedVal = Array.prototype.filter\n         .call(el.options, (o: HTMLOptionElement) => o.selected)\n         .map(getValue)\n-      el._assign(el.multiple ? selectedVal : selectedVal[0])\n+\n+      let domValue: string | number = el.multiple ? selectedVal : selectedVal[0]\n+\n+      if (castToNumber) {\n+        domValue = toNumber(domValue)\n+      }",
    "line": 17,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 86481702,
        "node_id": "MDMyOlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudFJlYWN0aW9uODY0ODE3MDI=",
        "user": {
          "login": "unbyte",
          "id": 5772358,
          "node_id": "MDQ6VXNlcjU3NzIzNTg=",
          "avatar_url": "https://avatars.githubusercontent.com/u/5772358?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/unbyte",
          "html_url": "https://github.com/unbyte",
          "followers_url": "https://api.github.com/users/unbyte/followers",
          "following_url": "https://api.github.com/users/unbyte/following{/other_user}",
          "gists_url": "https://api.github.com/users/unbyte/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/unbyte/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/unbyte/subscriptions",
          "organizations_url": "https://api.github.com/users/unbyte/orgs",
          "repos_url": "https://api.github.com/users/unbyte/repos",
          "events_url": "https://api.github.com/users/unbyte/events{/privacy}",
          "received_events_url": "https://api.github.com/users/unbyte/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2020-10-05T16:53:22Z"
      }
    ],
    "timestamp": "2020-10-05T00:59:10Z",
    "isReviewComment": true,
    "pullRequestReviewId": 501677292,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:14.684Z"
  },
  {
    "repo": "nestjs/nest",
    "prNumber": 14278,
    "prTitle": "fix(core): merge request with tenant context payload durable providers",
    "prAuthor": "chiliman-oOo",
    "prLink": "https://github.com/nestjs/nest/pull/14278",
    "commentAuthor": "kamilmysliwiec",
    "commentBody": "I think I misunderstood what this FR was about.\r\n\r\nDurable providers should not have access to the request-specific attributes (we shouldn't merge the payload with the request) simply because they are **durable** (meaning they are not removed after the request is finished processing). Merging the payload with request objects for durable providers will lead to memory leaks and unexpected behavior of the framework",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/nestjs/nest/pull/14278#discussion_r1871356863",
    "filePath": "packages/core/middleware/middleware-module.ts",
    "diffHunk": "@@ -346,9 +346,7 @@ export class MiddlewareModule<\n         configurable: false,\n       });\n \n-      const requestProviderValue = isTreeDurable\n-        ? contextId.payload\n-        : Object.assign(request, contextId.payload);\n+      const requestProviderValue = Object.assign(request, contextId.payload);",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-12-05T13:08:12Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2481650973,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:40:28.822Z"
  },
  {
    "repo": "nestjs/nest",
    "prNumber": 14185,
    "prTitle": "fix(websockets): Prevent HTTP server early close in Socket.IO shutdown",
    "prAuthor": "sapenlei",
    "prLink": "https://github.com/nestjs/nest/pull/14185",
    "commentAuthor": "kamilmysliwiec",
    "commentBody": "@sapenlei I just realized that this method should be called no matter the `_forceCloseConnections` for non-shared WS servers. This doesn't seem to be the case atm",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/nestjs/nest/pull/14185#discussion_r1856756985",
    "filePath": "packages/websockets/adapters/ws-adapter.ts",
    "diffHunk": "@@ -35,6 +40,9 @@ export abstract class AbstractWsAdapter<\n   }\n \n   public async close(server: TServer) {\n+    if (this._forceCloseConnections) {\n+      return;\n+    }",
    "line": 25,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-11-25T14:53:41Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2458674042,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:50:59.714Z"
  },
  {
    "repo": "nestjs/nest",
    "prNumber": 12188,
    "prTitle": "fix(socket.io): prevent multiple listeners for same socket on disconn…",
    "prAuthor": "lponciolo",
    "prLink": "https://github.com/nestjs/nest/pull/12188",
    "commentAuthor": "kamilmysliwiec",
    "commentBody": "Where do you remove items from this collection?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/nestjs/nest/pull/12188#discussion_r1298377667",
    "filePath": "packages/platform-socket.io/adapters/io-adapter.ts",
    "diffHunk": "@@ -35,25 +36,26 @@ export class IoAdapter extends AbstractWsAdapter {\n   }\n \n   public bindMessageHandlers(\n-    socket: Socket,\n-    handlers: MessageMappingProperties[],\n-    transform: (data: any) => Observable<any>,\n+      socket: Socket,\n+      handlers: MessageMappingProperties[],\n+      transform: (data: any) => Observable<any>,\n   ) {\n-    const disconnect$ = fromEvent(socket, DISCONNECT_EVENT).pipe(\n-      share(),\n-      first(),\n-    );\n+    let disconnect$ = this.disconnectFunctions.get(socket);\n+    if (!disconnect$) {\n+      disconnect$ = fromEvent(socket, DISCONNECT_EVENT).pipe(share(), first());\n+      this.disconnectFunctions.set(socket, disconnect$);",
    "line": 45,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-08-18T12:09:55Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1584453024,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:14.360Z"
  },
  {
    "repo": "nestjs/nest",
    "prNumber": 11674,
    "prTitle": "fix(core): revisit dependencies w/ possibly higher distance",
    "prAuthor": "amadeusjposchmann",
    "prLink": "https://github.com/nestjs/nest/pull/11674",
    "commentAuthor": "kamilmysliwiec",
    "commentBody": "I believe this may lead to infinite loops for circular imports",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/nestjs/nest/pull/11674#discussion_r1208967014",
    "filePath": "packages/core/scanner.ts",
    "diffHunk": "@@ -357,7 +357,7 @@ export class DependenciesScanner {\n \n     const modulesStack = [];\n     const calculateDistance = (moduleRef: Module, distance = 1) => {\n-      if (!moduleRef || modulesStack.includes(moduleRef)) {\n+      if (!moduleRef) {",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-05-29T06:32:47Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1448948284,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:15.142Z"
  },
  {
    "repo": "nestjs/nest",
    "prNumber": 3644,
    "prTitle": "fix(core): update normalize path logic to support global prefix",
    "prAuthor": "joey-kendall",
    "prLink": "https://github.com/nestjs/nest/pull/3644",
    "commentAuthor": "kamilmysliwiec",
    "commentBody": "What if the path contains `(.*)` already? This would result in having the following string: `(.(.*))`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/nestjs/nest/pull/3644#discussion_r386441827",
    "filePath": "packages/platform-fastify/adapters/fastify-adapter.ts",
    "diffHunk": "@@ -144,8 +144,8 @@ export class FastifyAdapter extends AbstractHttpAdapter {\n     requestMethod: RequestMethod,\n   ): (path: string, callback: Function) => any {\n     return (path: string, callback: Function) => {\n-      const re = pathToRegexp(path);\n-      const normalizedPath = path === '/*' ? '' : path;\n+      const normalizedPath = path.replace('*', '(.*)');",
    "line": 6,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-03-02T14:57:38Z",
    "isReviewComment": true,
    "pullRequestReviewId": 367262859,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:14.612Z"
  },
  {
    "repo": "prisma/prisma",
    "prNumber": 17753,
    "prTitle": "integration: add precise engine core error messages when loading `libquery`",
    "prAuthor": "jkomyno",
    "prLink": "https://github.com/prisma/prisma/pull/17753",
    "commentAuthor": "aqrln",
    "commentBody": "```suggestion\r\n      ({ message }) => hasLinkingProblem && message.includes('libgcc_s'),\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/prisma/prisma/pull/17753#discussion_r1097465081",
    "filePath": "packages/engine-core/src/common/errors/utils/handleEngineLoadingErrors.ts",
    "diffHunk": "@@ -0,0 +1,76 @@\n+import { link, type PlatformWithOSResult } from '@prisma/get-platform'\n+import chalk from 'chalk'\n+import { match } from 'ts-pattern'\n+\n+type HandleLibraryLoadingErrorsInput = {\n+  e: Error\n+  platformInfo: PlatformWithOSResult\n+  id: string\n+}\n+\n+export function handleLibraryLoadingErrors(args: HandleLibraryLoadingErrorsInput): string {\n+  const error = args.e as Error & { code?: string }\n+\n+  const systemLibraryNotFound = (library: string) =>\n+    `Prisma cannot find the required \\`${library}\\` system library in your system`\n+  const hasLinkingProblem = error.message.includes('cannot open shared object file')\n+  const referToSystemRequirementsDocs = `Please refer to the documentation about Prisma's system requirements: ${link(\n+    'https://pris.ly/d/system-requirements',\n+  )}`\n+\n+  const errorTitle = `Unable to require(\\`${chalk.dim(args.id)}\\`).`\n+\n+  const potentialReasonMessage = match({ message: error.message, code: error.code })\n+    .with({ code: 'ENOENT' }, () => `File does not exist.`)\n+    .when(\n+      ({ message }) => hasLinkingProblem && message.includes('libz'),\n+      () => {\n+        return `${systemLibraryNotFound('libz')}. Please install it and try again.`\n+      },\n+    )\n+    .when(\n+      ({ message }) => hasLinkingProblem && message.includes('libcc_s'),",
    "line": 32,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-02-06T14:39:14Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1285323419,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:53:33.096Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 53869,
    "prTitle": "Handle setting of nested through records for new records",
    "prAuthor": "joshuay03",
    "prLink": "https://github.com/rails/rails/pull/53869",
    "commentAuthor": "sromano",
    "commentBody": "In the reduce, this line will return a target that might be just one record (not a collection). If the reduce is still looping, next time middle_target will not be able to respond to empty? and will break",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/53869#discussion_r1882532333",
    "filePath": "activerecord/lib/active_record/associations/collection_association.rb",
    "diffHunk": "@@ -273,12 +273,18 @@ def load_target\n         if find_target?\n           @target = merge_target_lists(find_target, target)\n         elsif target.empty? && set_through_target_for_new_record?\n-          @target = if through_reflection.collection?\n-            through_association.target.flat_map do |record|\n-              record.association(reflection.source_reflection_name).target\n+          reflections = reflection.chain\n+          reflections.pop\n+          reflections.reverse!\n+\n+          @target = reflections.reduce(through_association.target) do |middle_target, reflection|\n+            if middle_target.empty?\n+              break []\n+            elsif reflection.collection?\n+              middle_target.flat_map { |record| record.association(reflection.source_reflection_name).target }\n+            else\n+              middle_target.association(reflection.source_reflection_name).target",
    "line": 17,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-12-12T16:56:26Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2500252332,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:00:51.581Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 53702,
    "prTitle": "Fix prepared statements on mysql2 adapter",
    "prAuthor": "zzak",
    "prLink": "https://github.com/rails/rails/pull/53702",
    "commentAuthor": "matthewd",
    "commentBody": "This shouldn't be checking `prepared_statements`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/53702#discussion_r1857962899",
    "filePath": "activerecord/lib/active_record/connection_adapters/mysql2/database_statements.rb",
    "diffHunk": "@@ -48,26 +48,39 @@ def perform_query(raw_connection, sql, binds, type_casted_binds, prepare:, notif\n             # made since we established the connection\n             raw_connection.query_options[:database_timezone] = default_timezone\n \n-            result = if prepare\n-              stmt = @statements[sql] ||= raw_connection.prepare(sql)\n+            result = if !prepared_statements || binds.nil? || binds.empty?",
    "line": 6,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-11-26T07:39:20Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2460640947,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:16.596Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 52644,
    "prTitle": "PG:: Fix Build where clause with nil arguments syntax error from postgres",
    "prAuthor": "maniSHarma7575",
    "prLink": "https://github.com/rails/rails/pull/52644",
    "commentAuthor": "byroot",
    "commentBody": "Thanks for the PR, but this isn't correct as it won't prepare fragment with some bound `nil` values, but:\r\n\r\n  - That's not desirable, `nil` in bound values is fine\r\n  - It doesn't fix the original issue if the nil bound value isn't alone, e.g. `.where(\"id = ? AND name IS ?\", 42, nil)`\r\n\r\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/52644#discussion_r1721318117",
    "filePath": "activerecord/lib/active_record/relation/query_methods.rb",
    "diffHunk": "@@ -1621,7 +1621,7 @@ def build_where_clause(opts, rest = []) # :nodoc:\n             parts = [Arel.sql(opts)]\n           elsif rest.first.is_a?(Hash) && /:\\w+/.match?(opts)\n             parts = [build_named_bound_sql_literal(opts, rest.first)]\n-          elsif opts.include?(\"?\")\n+          elsif opts.include?(\"?\") && rest.compact.present?",
    "line": 5,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 260745822,
        "node_id": "REA_lATNIULOZpk65c4Piqpe",
        "user": {
          "login": "maniSHarma7575",
          "id": 39980734,
          "node_id": "MDQ6VXNlcjM5OTgwNzM0",
          "avatar_url": "https://avatars.githubusercontent.com/u/39980734?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/maniSHarma7575",
          "html_url": "https://github.com/maniSHarma7575",
          "followers_url": "https://api.github.com/users/maniSHarma7575/followers",
          "following_url": "https://api.github.com/users/maniSHarma7575/following{/other_user}",
          "gists_url": "https://api.github.com/users/maniSHarma7575/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/maniSHarma7575/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/maniSHarma7575/subscriptions",
          "organizations_url": "https://api.github.com/users/maniSHarma7575/orgs",
          "repos_url": "https://api.github.com/users/maniSHarma7575/repos",
          "events_url": "https://api.github.com/users/maniSHarma7575/events{/privacy}",
          "received_events_url": "https://api.github.com/users/maniSHarma7575/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2024-08-19T07:44:59Z"
      }
    ],
    "timestamp": "2024-08-19T07:19:31Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2244782710,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:16.675Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 51950,
    "prTitle": "Raise when using key which can't respond to `#to_sym` in EncryptedConfiguration",
    "prAuthor": "zzak",
    "prLink": "https://github.com/rails/rails/pull/51950",
    "commentAuthor": "nnc",
    "commentBody": "@zzak @eileencodes it looks like this call to Hash#deep_symbolize_keys is not doing anything useful here and should be removed. Right?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/51950#discussion_r1719579360",
    "filePath": "activesupport/lib/active_support/encrypted_configuration.rb",
    "diffHunk": "@@ -73,14 +83,23 @@ def validate! # :nodoc:\n     #   # => { some_secret: 123, some_namespace: { another_secret: 789 } }\n     #\n     def config\n-      @config ||= deserialize(read).deep_symbolize_keys\n+      @config ||= deep_symbolize_keys(deserialize(read))\n     end\n \n     def inspect # :nodoc:\n       \"#<#{self.class.name}:#{'%#016x' % (object_id << 1)}>\"\n     end\n \n     private\n+      def deep_symbolize_keys(hash)\n+        hash.deep_symbolize_keys",
    "line": 40,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-08-16T09:11:34Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2242288599,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:16.774Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 51785,
    "prTitle": "Support `touch_all` in batches",
    "prAuthor": "fatkodima",
    "prLink": "https://github.com/rails/rails/pull/51785",
    "commentAuthor": "chaadow",
    "commentBody": "I think this should be \r\n```ruby\r\nassert_equal(\r\n  [time] * Developer.count,\r\n  Developer.all.pluck(:updated_at)\r\n)\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/rails/rails/pull/51785#discussion_r1597770474",
    "filePath": "activerecord/test/cases/batches_test.rb",
    "diffHunk": "@@ -384,6 +385,22 @@ def test_in_batches_update_all_returns_zero_when_no_batches\n     assert_equal 0, Post.where(\"1=0\").in_batches(of: 2).update_all(title: \"updated-title\")\n   end\n \n+  def test_in_batches_touch_all_affect_all_records\n+    time = Time.new(2000, 1, 1, 0, 0, 0)\n+    assert_queries_count(6 + 6) do # 6 selects, 6 updates\n+      Developer.in_batches(of: 2).touch_all(time: time)\n+    end\n+    assert_equal Developer.all.pluck(:updated_at), [time] * Developer.count",
    "line": 22,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-05-13T01:05:29Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2051531620,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:18.384Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 51083,
    "prTitle": "Add `ActiveRecord::Base.with_connection` as a shortcut",
    "prAuthor": "casperisfine",
    "prLink": "https://github.com/rails/rails/pull/51083",
    "commentAuthor": "carlosantoniodasilva",
    "commentBody": "Should these be testing against `connection2`?\r\n\r\n```suggestion\r\n            assert_same leased_connection, connection2\r\n            assert_same ActiveRecord::Base.connection, connection2\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/rails/rails/pull/51083#discussion_r1489472901",
    "filePath": "activerecord/test/cases/connection_handling_test.rb",
    "diffHunk": "@@ -0,0 +1,52 @@\n+# frozen_string_literal: true\n+\n+require \"cases/helper\"\n+\n+module ActiveRecord\n+  class ConnectionHandlingTest < ActiveRecord::TestCase\n+    unless in_memory_db?\n+      test \"#with_connection lease the connection for the duration of the block\" do\n+        ActiveRecord::Base.connection_pool.release_connection\n+        assert_not_predicate ActiveRecord::Base.connection_pool, :active_connection?\n+\n+        ActiveRecord::Base.with_connection do |connection|\n+          assert_predicate ActiveRecord::Base.connection_pool, :active_connection?\n+          assert_same connection, ActiveRecord::Base.connection\n+        end\n+\n+        assert_not_predicate ActiveRecord::Base.connection_pool, :active_connection?\n+      end\n+\n+      test \"#with_connection use the already leased connection if available\" do\n+        leased_connection = ActiveRecord::Base.connection\n+        assert_predicate ActiveRecord::Base.connection_pool, :active_connection?\n+\n+        ActiveRecord::Base.with_connection do |connection|\n+          assert_same leased_connection, connection\n+          assert_same ActiveRecord::Base.connection, connection\n+        end\n+\n+        assert_predicate ActiveRecord::Base.connection_pool, :active_connection?\n+        assert_same ActiveRecord::Base.connection, leased_connection\n+      end\n+\n+      test \"#with_connection is reentrant\" do\n+        leased_connection = ActiveRecord::Base.connection\n+        assert_predicate ActiveRecord::Base.connection_pool, :active_connection?\n+\n+        ActiveRecord::Base.with_connection do |connection|\n+          assert_same leased_connection, connection\n+          assert_same ActiveRecord::Base.connection, connection\n+\n+          ActiveRecord::Base.with_connection do |connection2|\n+            assert_same leased_connection, connection\n+            assert_same ActiveRecord::Base.connection, connection",
    "line": 43,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-02-14T13:35:38Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1880293718,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:18.371Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 51005,
    "prTitle": "Rails test command suggests similar test files when the given file is not found",
    "prAuthor": "zzak",
    "prLink": "https://github.com/rails/rails/pull/51005",
    "commentAuthor": "byroot",
    "commentBody": "@bensheldon indeed. We need to check `exception.path` here to ensure it's the same path we tried to require.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/51005#discussion_r1686864678",
    "filePath": "railties/lib/rails/test_unit/runner.rb",
    "diffHunk": "@@ -48,7 +57,17 @@ def run(argv = [])\n         def load_tests(argv)\n           patterns = extract_filters(argv)\n           tests = list_tests(patterns)\n-          tests.to_a.each { |path| require File.expand_path(path) }\n+          tests.to_a.each do |path|\n+            require File.expand_path(path)\n+          rescue LoadError => exception\n+            all_tests = list_tests([default_test_glob])\n+            corrections = DidYouMean::SpellChecker.new(dictionary: all_tests).correct(path)",
    "line": 25,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-07-22T17:01:13Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2192095681,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:18.445Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 48290,
    "prTitle": "Support nested elements inside <button>",
    "prAuthor": "marckohlbrugge",
    "prLink": "https://github.com/rails/rails/pull/48290",
    "commentAuthor": "javan",
    "commentBody": "This selector won’t match `<button>`s with an implicit type of `\"submit\"`:\r\n```html\r\n<form>\r\n  <button id=\"x\">…</button>\r\n</form>\r\n```\r\n```js\r\n> document.querySelector(\":is(button, input)[type='submit']\")\r\nnull\r\n\r\n> document.getElementById(\"x\").type\r\n\"submit\"\r\n```\r\n\r\nSuggestion:\r\n```js\r\nconst submitButton = event.target.closest(\"input, button\")\r\nif (submitButton && submitButton.type == \"submit\" && submitButton.form) {\r\n```\r\n",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/rails/rails/pull/48290#discussion_r1404632562",
    "filePath": "activestorage/app/javascript/activestorage/ujs.js",
    "diffHunk": "@@ -15,9 +15,9 @@ export function start() {\n }\n \n function didClick(event) {\n-  const { target } = event\n-  if ((target.tagName == \"INPUT\" || target.tagName == \"BUTTON\") && target.type == \"submit\" && target.form) {\n-    submitButtonsByForm.set(target.form, target)\n+  const submitButton = event.target.closest(\":is(button, input)[type='submit']\")\n+  if (submitButton && submitButton.form) {",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-11-24T20:31:30Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1748407781,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:18.462Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 47897,
    "prTitle": "Extend `ActiveRecord::Core#strict_loading!` to accept a block",
    "prAuthor": "seanpdoyle",
    "prLink": "https://github.com/rails/rails/pull/47897",
    "commentAuthor": "p8",
    "commentBody": "As this is a class method I don't think this is threadsafe.\r\n\r\n```\r\nUser.strict_loading!(false)\r\n# another thread calls:\r\n#   User.strict_loading!(true) { sleep 5 }\r\nuser = User.first\r\nuser.comments\r\n# => ActiveRecord::StrictLoadingViolationError as ensure hasn't been called yet.\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/rails/rails/pull/47897#discussion_r1164545253",
    "filePath": "activerecord/lib/active_record/core.rb",
    "diffHunk": "@@ -222,6 +222,56 @@ def self.connection_class_for_self # :nodoc:\n       self.default_role = ActiveRecord.writing_role\n       self.default_shard = :default\n \n+      # Sets instances of the class to strict_loading mode. This will raise an error\n+      # if a record tries to lazily load an association.\n+      #\n+      #   User.strict_loading! # => true\n+      #   user = User.first\n+      #   user.comments\n+      #   => ActiveRecord::StrictLoadingViolationError\n+      #\n+      # ==== Parameters\n+      #\n+      # * +value+ - Boolean specifying whether to enable or disable strict loading.\n+      # * +block+ - Proc within the block, instances of the class will set their\n+      #   strict loading configuration to <tt>value</tt>. Their configuration will\n+      #   be reverted to its original value outside the Proc.\n+      #\n+      # ==== Examples\n+      #\n+      #   User.strict_loading!(false) # => false\n+      #   user = User.first\n+      #   user.comments\n+      #   => #<ActiveRecord::Associations::CollectionProxy>\n+      #\n+      #   User.strict_loading!(true) do\n+      #     user = User.first\n+      #     user.comments\n+      #      => ActiveRecord::StrictLoadingViolationError\n+      #   end\n+      #   user = User.first\n+      #   user.comments\n+      #   => #<ActiveRecord::Associations::CollectionProxy>\n+      #\n+      #   User.strict_loading!(true) # => true\n+      #   user = User.first\n+      #   user.comments\n+      #      => ActiveRecord::StrictLoadingViolationError\n+      def self.strict_loading!(value = true, &block)\n+        original_strict_loading_by_default = strict_loading_by_default\n+        self.strict_loading_by_default = value",
    "line": 41,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-04-12T19:17:34Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1381953844,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:20.360Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 46638,
    "prTitle": "Fix: TextHelper highlight does sanitisation incorrectly",
    "prAuthor": "psantos10",
    "prLink": "https://github.com/rails/rails/pull/46638",
    "commentAuthor": "jeromedalbert",
    "commentBody": "The `(?<!&)` negative lookbehind as it is seems incomplete.\r\n\r\n`highlight(\"x & y\", \"am\")` would result in a desired `\"x &amp; y\"` output where nothing is highlighted. But `highlight(\"x & y\", \"mp\")` would result in an undesired `\"x &a<mark>mp</mark>; y\"` output because `mp` is not immediately preceded by `&`. But it is still part of the overall `&amp;` html entity.\r\n\r\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/46638#discussion_r1807725495",
    "filePath": "actionview/lib/action_view/helpers/text_helper.rb",
    "diffHunk": "@@ -143,11 +143,13 @@ def highlight(text, phrases, options = {}, &block)\n             Regexp === p ? p.to_s : Regexp.escape(p)\n           end.join(\"|\")\n \n+          regex = /(?<!&)(#{match})(?![^<]*?>)/i",
    "line": 4,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-10-20T08:17:45Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2380241695,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:20.476Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 45153,
    "prTitle": "Skip resetting correct counter caches",
    "prAuthor": "fatkodima",
    "prLink": "https://github.com/rails/rails/pull/45153",
    "commentAuthor": "byroot",
    "commentBody": "Uh, this is subject to race conditions :/ \r\n\r\nTo correctly reset a counter cache you need to do an `UPDATE` with a subquery that does the count.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/45153#discussion_r879563455",
    "filePath": "activerecord/lib/active_record/counter_cache.rb",
    "diffHunk": "@@ -48,7 +48,9 @@ def reset_counters(id, *counters, touch: nil)\n           reflection   = child_class._reflections.values.find { |e| e.belongs_to? && e.foreign_key.to_s == foreign_key && e.options[:counter_cache].present? }\n           counter_name = reflection.counter_cache_column\n \n-          updates[counter_name] = object.send(counter_association).count(:all)",
    "line": 4,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-05-23T15:01:57Z",
    "isReviewComment": true,
    "pullRequestReviewId": 981923523,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:20.221Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 40420,
    "prTitle": "Use `$MEMCACHE_SERVERS` as `MemCacheStore` fallback",
    "prAuthor": "sambostock",
    "prLink": "https://github.com/rails/rails/pull/40420",
    "commentAuthor": "movermeyer",
    "commentBody": "Users of `:dalli_store` may have been passing an explicit `nil` parameter for the servers:\r\n\r\n```ruby\r\nconfig.cache_store = :dalli_cache, nil, { expires_in: 2.hour, compress: true }\r\n```\r\n\r\nIf they simply changed `:dalli_cache` and `:mem_cache_store`, this code passes `addresses = [nil]` to Dalli (instead of `nil`, which cause exceptions when people try to access the cache.\r\n\r\n```\r\nNoMethodError: undefined method `match' for nil:NilClass\r\n```\r\n\r\nI've seen at least 2 cases within repos where this was the case, which confused hapless developers who were just trying to migrate in order to clear the deprecation warning (causing them to revert instead of debugging the issue).\r\n\r\nPerhaps we could do something like add a `.compact`:\r\n\r\n```ruby\r\naddresses = nil if addresses.compact.empty?\r\n```\r\n\r\nThis would unify the interface between the two stores.\r\n\r\nOr perhaps raise an exception that explained what they were doing wrong / the difference in interface between `:dalli_store` and `:mem_cache_store`.",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/rails/rails/pull/40420#discussion_r572413764",
    "filePath": "activesupport/lib/active_support/cache/mem_cache_store.rb",
    "diffHunk": "@@ -53,16 +53,18 @@ def self.supports_cache_versioning?\n       ESCAPE_KEY_CHARS = /[\\x00-\\x20%\\x7F-\\xFF]/n\n \n       # Creates a new Dalli::Client instance with specified addresses and options.\n-      # By default address is equal localhost:11211.\n+      # If no addresses are provided, we give nil to Dalli::Client, so it uses its fallbacks:\n+      # - ENV[\"MEMCACHE_SERVERS\"] (if defined)\n+      # - \"127.0.0.1:11211\"        (otherwise)\n       #\n       #   ActiveSupport::Cache::MemCacheStore.build_mem_cache\n-      #     # => #<Dalli::Client:0x007f98a47d2028 @servers=[\"localhost:11211\"], @options={}, @ring=nil>\n+      #     # => #<Dalli::Client:0x007f98a47d2028 @servers=[\"127.0.0.1:11211\"], @options={}, @ring=nil>\n       #   ActiveSupport::Cache::MemCacheStore.build_mem_cache('localhost:10290')\n       #     # => #<Dalli::Client:0x007f98a47b3a60 @servers=[\"localhost:10290\"], @options={}, @ring=nil>\n       def self.build_mem_cache(*addresses) # :nodoc:\n         addresses = addresses.flatten\n         options = addresses.extract_options!\n-        addresses = [\"localhost:11211\"] if addresses.empty?\n+        addresses = nil if addresses.empty?",
    "line": 18,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-02-08T22:12:48Z",
    "isReviewComment": true,
    "pullRequestReviewId": 585972620,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:22.317Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 39945,
    "prTitle": " improve code's style with some doc",
    "prAuthor": "lanzhiheng",
    "prLink": "https://github.com/rails/rails/pull/39945",
    "commentAuthor": "jonathanhefner",
    "commentBody": "This is actually subtly different.  `super()` calls the superclass's `initialize` without any args, but `super` calls the superclass's `initialize` with all defined args to, i.e. `super(constructor)` in this case.\r\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/39945#discussion_r462371875",
    "filePath": "activesupport/lib/active_support/hash_with_indifferent_access.rb",
    "diffHunk": "@@ -60,13 +60,16 @@ def with_indifferent_access\n       dup\n     end\n \n+    # An optimization, override the initialization method `nested_under_indifferent_access`\n+    # who was defined in `activesupport/lib/active_support/core_ext/hash/indifferent_access.rb`.\n+    # If `self.is_a?(HashWithIndifferentAccess)` is true, we don't need to instantiate again.\n     def nested_under_indifferent_access\n       self\n     end\n \n     def initialize(constructor = {})\n       if constructor.respond_to?(:to_hash)\n-        super()\n+        super",
    "line": 14,
    "reactionCount": 2,
    "reactions": [
      {
        "id": 79502795,
        "node_id": "MDMyOlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudFJlYWN0aW9uNzk1MDI3OTU=",
        "user": {
          "login": "eugeneius",
          "id": 432189,
          "node_id": "MDQ6VXNlcjQzMjE4OQ==",
          "avatar_url": "https://avatars.githubusercontent.com/u/432189?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/eugeneius",
          "html_url": "https://github.com/eugeneius",
          "followers_url": "https://api.github.com/users/eugeneius/followers",
          "following_url": "https://api.github.com/users/eugeneius/following{/other_user}",
          "gists_url": "https://api.github.com/users/eugeneius/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/eugeneius/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/eugeneius/subscriptions",
          "organizations_url": "https://api.github.com/users/eugeneius/orgs",
          "repos_url": "https://api.github.com/users/eugeneius/repos",
          "events_url": "https://api.github.com/users/eugeneius/events{/privacy}",
          "received_events_url": "https://api.github.com/users/eugeneius/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2020-07-29T15:16:43Z"
      },
      {
        "id": 79705573,
        "node_id": "MDMyOlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudFJlYWN0aW9uNzk3MDU1NzM=",
        "user": {
          "login": "lanzhiheng",
          "id": 8858472,
          "node_id": "MDQ6VXNlcjg4NTg0NzI=",
          "avatar_url": "https://avatars.githubusercontent.com/u/8858472?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/lanzhiheng",
          "html_url": "https://github.com/lanzhiheng",
          "followers_url": "https://api.github.com/users/lanzhiheng/followers",
          "following_url": "https://api.github.com/users/lanzhiheng/following{/other_user}",
          "gists_url": "https://api.github.com/users/lanzhiheng/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/lanzhiheng/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/lanzhiheng/subscriptions",
          "organizations_url": "https://api.github.com/users/lanzhiheng/orgs",
          "repos_url": "https://api.github.com/users/lanzhiheng/repos",
          "events_url": "https://api.github.com/users/lanzhiheng/events{/privacy}",
          "received_events_url": "https://api.github.com/users/lanzhiheng/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2020-07-31T02:28:12Z"
      }
    ],
    "timestamp": "2020-07-29T15:05:57Z",
    "isReviewComment": true,
    "pullRequestReviewId": 457616710,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:22.108Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 39687,
    "prTitle": "Allow passing I18n locale to ActionMailer::Base#mail",
    "prAuthor": "c960657",
    "prLink": "https://github.com/rails/rails/pull/39687",
    "commentAuthor": "rafaelfranca",
    "commentBody": "If `interpolations.key?(:locale)` is true would not this method call have two `locale` options with the later overriding the former argument? I think we should only pass this option if `interpolations.key?(:locale)` is false.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/39687#discussion_r546104085",
    "filePath": "actionmailer/lib/action_mailer/base.rb",
    "diffHunk": "@@ -888,9 +894,12 @@ def set_content_type(m, user_content_type, class_default) # :doc:\n       # If it does not find a translation for the +subject+ under the specified scope it will default to a\n       # humanized version of the <tt>action_name</tt>.\n       # If the subject has interpolations, you can pass them through the +interpolations+ parameter.\n+      # The locale may be passing in the <tt>locale</tt> key, otherwise the mailer class default or\n+      # `I18n.locale` will be used.\n       def default_i18n_subject(interpolations = {}) # :doc:\n         mailer_scope = self.class.mailer_name.tr(\"/\", \".\")\n-        I18n.t(:subject, **interpolations.merge(scope: [mailer_scope, action_name], default: action_name.humanize))\n+        locale = interpolations.key?(:locale) ? interpolations[:locale] : compute_default(self.class.default[:locale])\n+        I18n.t(:subject, **interpolations.merge(scope: [mailer_scope, action_name], default: action_name.humanize, locale: locale))",
    "line": 39,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-12-18T21:40:56Z",
    "isReviewComment": true,
    "pullRequestReviewId": 555830325,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:24.222Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 38963,
    "prTitle": "Filter sensitive parameters in `ActiveJob` logs by default",
    "prAuthor": "springerigor",
    "prLink": "https://github.com/rails/rails/pull/38963",
    "commentAuthor": "jonathanhefner",
    "commentBody": "Memoizing this here doesn't seem right.  If `parameter_filter` is called twice with different `filter_arguments`, it will return the same `@parameter_filter`.  To prevent multiple allocations, you might need to instantiate this at a higher level.\r\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/38963#discussion_r409129298",
    "filePath": "activejob/lib/active_job/log_subscriber.rb",
    "diffHunk": "@@ -107,12 +107,28 @@ def queue_name(event)\n       def args_info(job)\n         if job.class.log_arguments? && job.arguments.any?\n           \" with arguments: \" +\n-            job.arguments.map { |arg| format(arg).inspect }.join(\", \")\n+            job.arguments\n+              .map { |arg| filter(job.class.filter_arguments, arg) }\n+              .map { |arg| format(arg).inspect }\n+              .join(\", \")\n         else\n           \"\"\n         end\n       end\n \n+      def filter(filter_arguments, arg)\n+        case arg\n+        when Hash\n+          parameter_filter(filter_arguments).filter(arg)\n+        else\n+          arg\n+        end\n+      end\n+\n+      def parameter_filter(filter_arguments)\n+        @parameter_filter ||= ActiveSupport::ParameterFilter.new(filter_arguments)",
    "line": 24,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-04-15T20:57:16Z",
    "isReviewComment": true,
    "pullRequestReviewId": 394127255,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:24.382Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 38659,
    "prTitle": "Inflection support default_locale and fallbacks",
    "prAuthor": "stevecrozz",
    "prLink": "https://github.com/rails/rails/pull/38659",
    "commentAuthor": "ocher",
    "commentBody": "I'm afraid that the above test doesn't check new code introduced by the PR. Value passed to `pluralize` is already pluralized. And even if it wasn't pluralized, it still would work correctly without the new code. \r\n\r\nExample using Rails 6.1.3:\r\n\r\n```\r\n2.7.0 :001 > I18n.default_locale\r\n => :\"en-GB\" \r\n2.7.0 :002 > ActiveSupport::Inflector.pluralize(\"day\")\r\n => \"days\" \r\n2.7.0 :003 > ActiveSupport::Inflector.pluralize(\"day\", :'en-GB')\r\n => \"day\" \r\n```\r\n\r\nOnly the last line returns incorrect result, which is fixed by this PR. ",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/rails/rails/pull/38659#discussion_r579170627",
    "filePath": "activesupport/test/inflector_test.rb",
    "diffHunk": "@@ -33,6 +33,12 @@ def test_pluralize_empty_string\n     assert_equal \"\", ActiveSupport::Inflector.pluralize(\"\")\n   end\n \n+  def test_pluralize_with_fallback\n+    I18n.stub(:default_locale, :\"en-GB\") do\n+      assert_equal \"days\", ActiveSupport::Inflector.pluralize(\"days\")",
    "line": 6,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-02-19T13:06:22Z",
    "isReviewComment": true,
    "pullRequestReviewId": 594168914,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:24.440Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 38019,
    "prTitle": "Restores ability to eager load manually",
    "prAuthor": "fxn",
    "prLink": "https://github.com/rails/rails/pull/38019",
    "commentAuthor": "Edouard-chin",
    "commentBody": "```suggestion\r\n          namespace.eager_load! unless namespace == self.class\r\n```\r\n\r\nThis breaks otherwise with a `#<NoMethodError: protected method `eager_load!' called for #<Shopify::Application:0x00007fd188a72658>>`",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/rails/rails/pull/38019#discussion_r363787440",
    "filePath": "railties/lib/rails/application.rb",
    "diffHunk": "@@ -580,6 +584,26 @@ def validate_secret_key_base(secret_key_base)\n       end\n     end\n \n+    def eager_load!\n+      EAGER_LOAD_MUTEX.synchronize do\n+        return if @eager_loaded\n+\n+        ActiveSupport.run_load_hooks(:before_eager_load, self)\n+\n+        # Checks defined?(Zeitwerk) instead of zeitwerk_enabled? because we want\n+        # to eager load any dependency managed by Zeitwerk regardless of the\n+        # autoloading mode of the application.\n+        Zeitwerk::Loader.eager_load_all if defined?(Zeitwerk)\n+\n+        super unless Rails.autoloaders.zeitwerk_enabled?\n+        config.eager_load_namespaces.each do |namespace|\n+          namespace.eager_load! unless namespace == self",
    "line": 35,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-01-07T14:58:21Z",
    "isReviewComment": true,
    "pullRequestReviewId": 339288256,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:24.313Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 35093,
    "prTitle": "Tighten up the AV::Base constructor",
    "prAuthor": "tenderlove",
    "prLink": "https://github.com/rails/rails/pull/35093",
    "commentAuthor": "y-yagi",
    "commentBody": "If formats is `NULL`, should change the value to `nil`? \r\nIf this is left as `NULL(Object.new)`, it will be incorrectly judged where the value is nil or not. \r\n\r\nFor example, if using web-console, `NoMethodError` will be raise in lookup context. \r\n\r\n```\r\nDEPRECATION WARNING: ActionView::Base instances should be constructed with a view renderer,\r\nassigments, and a controller.\r\n (called from new at /home/y-yagi/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/web-console-3.7.0/lib/web_console/template.rb:21)\r\n\r\nNoMethodError: undefined method `delete' for #<Object:0x000055e2e6120880>\r\n\tfrom /home/y-yagi/src/rails/master_y_yagi/rails/actionview/lib/action_view/lookup_context.rb:258:in `formats='\r\n\tfrom /home/y-yagi/src/rails/master_y_yagi/rails/actionview/lib/action_view/base.rb:206:in `build_renderer'\r\n\tfrom /home/y-yagi/src/rails/master_y_yagi/rails/actionview/lib/action_view/base.rb:243:in `initialize'\r\n\tfrom /home/y-yagi/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/web-console-3.7.0/lib/web_console/template.rb:21:in `new'\r\n\tfrom /home/y-yagi/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/web-console-3.7.0/lib/web_console/template.rb:21:in `render'\r\n\tfrom /home/y-yagi/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/web-console-3.7.0/lib/web_console/middleware.rb:37:in `block in call'\r\n\tfrom /home/y-yagi/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/web-console-3.7.0/lib/web_console/middleware.rb:20:in `catch'\r\n\tfrom /home/y-yagi/.rbenv/versions/2.6.0/lib/ruby/gems/2.6.0/gems/web-console-3.7.0/lib/web_console/middleware.rb:20:in `call'\r\n\tfrom /home/y-yagi/src/rails/master_y_yagi/rails/actionpack/lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'\r\n```\r\n",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/rails/rails/pull/35093#discussion_r252598505",
    "filePath": "actionview/lib/action_view/base.rb",
    "diffHunk": "@@ -197,17 +198,49 @@ def assign(new_assigns) # :nodoc:\n       @_assigns = new_assigns.each { |key, value| instance_variable_set(\"@#{key}\", value) }\n     end\n \n-    def initialize(context = nil, assigns = {}, controller = nil, formats = nil) #:nodoc:\n+    # :stopdoc:\n+\n+    def self.build_renderer(context, controller, formats)\n+      lookup_context = context.is_a?(ActionView::LookupContext) ?\n+        context : ActionView::LookupContext.new(context)\n+      lookup_context.formats  = formats if formats\n+      lookup_context.prefixes = controller._prefixes if controller\n+      ActionView::Renderer.new(lookup_context)\n+    end\n+\n+    def self.empty\n+      with_view_paths([])\n+    end\n+\n+    def self.with_view_paths(view_paths, assigns = {}, controller = nil)\n+      with_context ActionView::LookupContext.new(view_paths), assigns, controller\n+    end\n+\n+    def self.with_context(context, assigns = {}, controller = nil)\n+      new ActionView::Renderer.new(context), assigns, controller\n+    end\n+\n+    NULL = Object.new\n+\n+    # :startdoc:\n+\n+    def initialize(renderer, assigns = {}, controller = nil, formats = NULL) #:nodoc:\n       @_config = ActiveSupport::InheritableOptions.new\n \n-      if context.is_a?(ActionView::Renderer)\n-        @view_renderer = context\n+      unless formats == NULL",
    "line": 53,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2019-01-31T09:53:01Z",
    "isReviewComment": true,
    "pullRequestReviewId": 198503016,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:26.063Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 34704,
    "prTitle": "Remove `report-uri` directive when `nil`",
    "prAuthor": "jacobbednarz",
    "prLink": "https://github.com/rails/rails/pull/34704",
    "commentAuthor": "y-yagi",
    "commentBody": "If have a setting like the original issue, this `uri` will be` Proc` object. Therefore, since here `if` is always true, `report_uri` is always set.\r\nI think that it is necessary to check whether the value is nil after evaluating Proc.\r\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/34704#discussion_r242772479",
    "filePath": "actionpack/lib/action_dispatch/http/content_security_policy.rb",
    "diffHunk": "@@ -175,7 +175,7 @@ def plugin_types(*types)\n     end\n \n     def report_uri(uri)\n-      @directives[\"report-uri\"] = [uri]\n+      @directives[\"report-uri\"] = [uri] if uri",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2018-12-19T02:16:38Z",
    "isReviewComment": true,
    "pullRequestReviewId": 186364148,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:26.135Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 34538,
    "prTitle": "Reuse code in AR::Association#find_target",
    "prAuthor": "bogdan",
    "prLink": "https://github.com/rails/rails/pull/34538",
    "commentAuthor": "kamipo",
    "commentBody": "I've reverted this PR in 93c94973ab574083a8cd1868aae03993ca156c34 since `scope.take` is not the same with `scope.to_a.first`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/34538#discussion_r236735444",
    "filePath": "activerecord/lib/active_record/associations/singular_association.rb",
    "diffHunk": "@@ -31,24 +31,17 @@ def force_reload_reader\n       end\n \n       private\n+\n+        def target_scope\n+          super.limit!(1)\n+        end\n+\n         def scope_for_create\n           super.except!(klass.primary_key)\n         end\n \n         def find_target\n-          scope = self.scope\n-          return scope.take if skip_statement_cache?(scope)",
    "line": 15,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2018-11-27T16:11:35Z",
    "isReviewComment": true,
    "pullRequestReviewId": 178871975,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:26.182Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 33691,
    "prTitle": "Add database configuration to disable advisory locks.",
    "prAuthor": "tgxworld",
    "prLink": "https://github.com/rails/rails/pull/33691",
    "commentAuthor": "georgeclaghorn",
    "commentBody": "Should this be `:advisory_locks_enabled`?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/33691#discussion_r212074328",
    "filePath": "activerecord/lib/active_record/connection_adapters/abstract_adapter.rb",
    "diffHunk": "@@ -77,7 +77,14 @@ class AbstractAdapter\n       SIMPLE_INT = /\\A\\d+\\z/\n \n       attr_accessor :visitor, :pool\n-      attr_reader :schema_cache, :owner, :logger, :prepared_statements, :lock\n+\n+      attr_reader :schema_cache,\n+                  :owner,\n+                  :logger,\n+                  :prepared_statements,\n+                  :lock,\n+                  :advisory_locks",
    "line": 11,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2018-08-22T19:11:31Z",
    "isReviewComment": true,
    "pullRequestReviewId": 148629577,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:26.163Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 31596,
    "prTitle": "Add locale selector to email preview",
    "prAuthor": "morygonzalez",
    "prLink": "https://github.com/rails/rails/pull/31596",
    "commentAuthor": "y-yagi",
    "commentBody": "`locale_select` only appears in `I18n.available_locales.count > 1`. \r\nSo if users have only one locale, this code will occur error.\r\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/31596#discussion_r162535325",
    "filePath": "railties/lib/rails/templates/rails/mailers/email.html.erb",
    "diffHunk": "@@ -116,15 +128,18 @@\n <% end %>\n \n <script>\n-  function formatChanged(form) {\n-    var part_name = form.options[form.selectedIndex].value\n-    var iframe =document.getElementsByName('messageBody')[0];\n-    iframe.contentWindow.location.replace(part_name);\n+  function refreshBody() {\n+    var part_select = document.querySelector('select#part');\n+    var locale_select = document.querySelector('select#locale');\n+    var part_param = part_select.options[part_select.selectedIndex].value;\n+    var locale_param = locale_select.options[locale_select.selectedIndex].value;",
    "line": 38,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2018-01-19T04:23:07Z",
    "isReviewComment": true,
    "pullRequestReviewId": 90009273,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:27.891Z"
  },
  {
    "repo": "laravel/laravel",
    "prNumber": 5837,
    "prTitle": "[9.x] Update console.php",
    "prAuthor": "imanghafoori1",
    "prLink": "https://github.com/laravel/laravel/pull/5837",
    "commentAuthor": "GrahamCampbell",
    "commentBody": "This is actually wrong. `fn ()` is not \"the short version\" of `function ()`. It is only for use where you want to return an expression value. The `Artisan::command` function expects a function of type `callable(): void`, and we were passing `Closure(): void` before this change, which is compatible. You are now passing `Closure(): null`, which is not compatible.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/laravel/laravel/pull/5837#discussion_r822481229",
    "filePath": "routes/console.php",
    "diffHunk": "@@ -14,6 +14,5 @@\n |\n */\n \n-Artisan::command('inspire', function () {\n-    $this->comment(Inspiring::quote());\n-})->purpose('Display an inspiring quote');\n+Artisan::command('inspire', fn () => $this->comment(Inspiring::quote()))",
    "line": 7,
    "reactionCount": 2,
    "reactions": [
      {
        "id": 153165840,
        "node_id": "REA_lATOABxuoc4xBhFNzgkhIBA",
        "user": {
          "login": "baleghsefat",
          "id": 36894319,
          "node_id": "MDQ6VXNlcjM2ODk0MzE5",
          "avatar_url": "https://avatars.githubusercontent.com/u/36894319?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/baleghsefat",
          "html_url": "https://github.com/baleghsefat",
          "followers_url": "https://api.github.com/users/baleghsefat/followers",
          "following_url": "https://api.github.com/users/baleghsefat/following{/other_user}",
          "gists_url": "https://api.github.com/users/baleghsefat/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/baleghsefat/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/baleghsefat/subscriptions",
          "organizations_url": "https://api.github.com/users/baleghsefat/orgs",
          "repos_url": "https://api.github.com/users/baleghsefat/repos",
          "events_url": "https://api.github.com/users/baleghsefat/events{/privacy}",
          "received_events_url": "https://api.github.com/users/baleghsefat/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2022-03-09T10:17:57Z"
      },
      {
        "id": 153218403,
        "node_id": "REA_lATOABxuoc4xBhFNzgkh7WM",
        "user": {
          "login": "fwdmo",
          "id": 27734703,
          "node_id": "MDQ6VXNlcjI3NzM0NzAz",
          "avatar_url": "https://avatars.githubusercontent.com/u/27734703?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/fwdmo",
          "html_url": "https://github.com/fwdmo",
          "followers_url": "https://api.github.com/users/fwdmo/followers",
          "following_url": "https://api.github.com/users/fwdmo/following{/other_user}",
          "gists_url": "https://api.github.com/users/fwdmo/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/fwdmo/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/fwdmo/subscriptions",
          "organizations_url": "https://api.github.com/users/fwdmo/orgs",
          "repos_url": "https://api.github.com/users/fwdmo/repos",
          "events_url": "https://api.github.com/users/fwdmo/events{/privacy}",
          "received_events_url": "https://api.github.com/users/fwdmo/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2022-03-09T15:12:10Z"
      }
    ],
    "timestamp": "2022-03-09T10:03:45Z",
    "isReviewComment": true,
    "pullRequestReviewId": 904128110,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:28.027Z"
  },
  {
    "repo": "django/django",
    "prNumber": 17089,
    "prTitle": "Type judgment is done using Python's own duck-typing mechanism",
    "prAuthor": "geyaning",
    "prLink": "https://github.com/django/django/pull/17089",
    "commentAuthor": "felixxm",
    "commentBody": "This patch will change the current behavior for Pure-paths:\r\n```\r\n>>> to_path(PurePosixPath('x'))\r\nTraceback (most recent call last):\r\n    raise TypeError(\"Invalid path type: %s\" % type(value).__name__)\r\nTypeError: Invalid path type: PurePosixPath\r\n```\r\nwith yout patch:\r\n```\r\n>>> to_path(PurePosixPath('x'))\r\nPosixPath('x')\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/django/django/pull/17089#discussion_r1266304758",
    "filePath": "django/utils/_os.py",
    "diffHunk": "@@ -55,8 +55,6 @@ def symlinks_supported():\n \n def to_path(value):\n     \"\"\"Convert value to a pathlib.Path instance, if not already a Path.\"\"\"\n-    if isinstance(value, Path):\n-        return value\n-    elif not isinstance(value, str):\n-        raise TypeError(\"Invalid path type: %s\" % type(value).__name__)\n-    return Path(value)",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-07-18T06:42:59Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1534302794,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:39:56.152Z"
  },
  {
    "repo": "django/django",
    "prNumber": 16620,
    "prTitle": "[4.1.x] Fixed #34362 -- Fixed support for conditional expression in FilteredRelation",
    "prAuthor": "panicofr",
    "prLink": "https://github.com/django/django/pull/16620",
    "commentAuthor": "charettes",
    "commentBody": "I think this is only _masking_ the crash by dropping the false criteria\r\n\r\nIf it was generating a join along the lines of `LEFT JOIN book AS the_book ON (book.author_id = author.id AND false)`, as should be expected in this case, then `the_book.id` should always be `NULL` as `(book.author_id = author.id AND false)` will always be false.\r\n\r\nYour test demonstrates that the criteria is dropped and produces wrong results.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/django/django/pull/16620#discussion_r1125517929",
    "filePath": "django/db/models/sql/query.py",
    "diffHunk": "@@ -1605,7 +1605,11 @@ def build_filtered_relation_q(\n \n     def add_filtered_relation(self, filtered_relation, alias):\n         filtered_relation.alias = alias\n-        lookups = dict(get_children_from_q(filtered_relation.condition))\n+        lookups = dict(\n+            l\n+            for l in get_children_from_q(filtered_relation.condition)\n+            if isinstance(l, tuple)",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-03-04T19:25:12Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1325101972,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:29.676Z"
  },
  {
    "repo": "django/django",
    "prNumber": 15495,
    "prTitle": "Fixed #30923 -- updated example of rendering template on custom template tags docs",
    "prAuthor": "seanbermejo",
    "prLink": "https://github.com/django/django/pull/15495",
    "commentAuthor": "felixxm",
    "commentBody": "`Template` has not `template` attribute.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/django/django/pull/15495#discussion_r823359376",
    "filePath": "docs/howto/custom-template-tags.txt",
    "diffHunk": "@@ -794,8 +794,10 @@ The ``__init__`` method for the ``Context`` class takes a parameter called\n This is not a very common situation, but it's useful if you're rendering a\n template yourself. For example::\n \n+    from django.template import Context\n+\n     def render(self, context):\n-        t = context.template.engine.get_template('small_fragment.html')\n+        t = context.template.engine.get_template('small_fragment.html').template",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-03-10T05:27:39Z",
    "isReviewComment": true,
    "pullRequestReviewId": 905333137,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:29.644Z"
  },
  {
    "repo": "django/django",
    "prNumber": 15283,
    "prTitle": "Fixed #33407  Refactored the 'forms' CSS file.",
    "prAuthor": "valleyofblackpanther",
    "prLink": "https://github.com/django/django/pull/15283",
    "commentAuthor": "felixxm",
    "commentBody": "Do we have no `ul.inline` anymore? Also, Is this reachable for `div.inline`? I would revert this change.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/django/django/pull/15283#discussion_r778316094",
    "filePath": "django/contrib/admin/static/admin/css/forms.css",
    "diffHunk": "@@ -37,26 +37,26 @@ label {\n \n /* RADIO BUTTONS */\n \n-form ul.radiolist li {\n+form div.radiolist li {\n     list-style-type: none;\n }\n \n-form ul.radiolist label {\n+form div.radiolist label {\n     float: none;\n     display: inline;\n }\n \n-form ul.radiolist input[type=\"radio\"] {\n+form div.radiolist input[type=\"radio\"] {\n     margin: -2px 4px 0 0;\n     padding: 0;\n }\n \n-form ul.inline {\n+form div.inline {\n     margin-left: 0;\n     padding: 0;\n }\n \n-form ul.inline li {\n+form div.inline li {",
    "line": 28,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-01-04T18:56:04Z",
    "isReviewComment": true,
    "pullRequestReviewId": 843900146,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:29.742Z"
  },
  {
    "repo": "django/django",
    "prNumber": 14632,
    "prTitle": "Refs #32922 -- Added \"preferred_language\" property to \"HttpRequest\" object",
    "prAuthor": "pixel365",
    "prLink": "https://github.com/django/django/pull/14632",
    "commentAuthor": "kezabelle",
    "commentBody": "This doesn't take into account the weighting that can be present, and assumes that the first item is the preferred one, which is AFAIK only true if _none_ of the options have a q weight (in which case they all have a `q=1`)",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/django/django/pull/14632#discussion_r669022300",
    "filePath": "django/http/request.py",
    "diffHunk": "@@ -305,6 +305,12 @@ def body(self):\n             self._stream = BytesIO(self._body)\n         return self._body\n \n+    @property\n+    def preferred_language(self):\n+        \"\"\"Returns the client's language in order of priority from the \"Accept-Language\" header\"\"\"\n+        languages = [_.strip() for _ in self.headers.get('Accept-Language', '*').split(',')]\n+        return languages[0].split(';')[0]",
    "line": 8,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 119934197,
        "node_id": "MDMyOlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudFJlYWN0aW9uMTE5OTM0MTk3",
        "user": {
          "login": "ngnpope",
          "id": 2855582,
          "node_id": "MDQ6VXNlcjI4NTU1ODI=",
          "avatar_url": "https://avatars.githubusercontent.com/u/2855582?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/ngnpope",
          "html_url": "https://github.com/ngnpope",
          "followers_url": "https://api.github.com/users/ngnpope/followers",
          "following_url": "https://api.github.com/users/ngnpope/following{/other_user}",
          "gists_url": "https://api.github.com/users/ngnpope/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/ngnpope/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/ngnpope/subscriptions",
          "organizations_url": "https://api.github.com/users/ngnpope/orgs",
          "repos_url": "https://api.github.com/users/ngnpope/repos",
          "events_url": "https://api.github.com/users/ngnpope/events{/privacy}",
          "received_events_url": "https://api.github.com/users/ngnpope/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2021-07-13T21:22:04Z"
      }
    ],
    "timestamp": "2021-07-13T18:44:37Z",
    "isReviewComment": true,
    "pullRequestReviewId": 705530998,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:29.641Z"
  },
  {
    "repo": "django/django",
    "prNumber": 14371,
    "prTitle": "[FEATURE] Add translation of permissions",
    "prAuthor": "maviva",
    "prLink": "https://github.com/django/django/pull/14371",
    "commentAuthor": "ngnpope",
    "commentBody": "This doesn't work. The substitution must happen after the translation:\r\n\r\n```suggestion\r\n            _('Can %(action)s %(verbose_name)s') % {'action': action, 'verbose_name': opts.verbose_name_raw}\r\n```\r\n\r\nI think, in this case, you can use `gettext` instead of `gettext_lazy`.",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/django/django/pull/14371#discussion_r629199997",
    "filePath": "django/contrib/auth/management/__init__.py",
    "diffHunk": "@@ -27,7 +28,7 @@ def _get_builtin_permissions(opts):\n     for action in opts.default_permissions:\n         perms.append((\n             get_permission_codename(action, opts),\n-            'Can %s %s' % (action, opts.verbose_name_raw)\n+            _('Can %(action)s %(verbose_name)s' % {'action': action, 'verbose_name': opts.verbose_name_raw})",
    "line": 13,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-05-10T09:14:41Z",
    "isReviewComment": true,
    "pullRequestReviewId": 655426356,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:32.102Z"
  },
  {
    "repo": "django/django",
    "prNumber": 13922,
    "prTitle": "Fixed #32367 -- Fixed models.W042 is raised on inherited manually specified primary key.",
    "prAuthor": "hramezani",
    "prLink": "https://github.com/django/django/pull/13922",
    "commentAuthor": "charettes",
    "commentBody": "I think this logic would mark `Children.parent_ptr.auto_created = True` when it should be `False`\r\n\r\n```python\r\nclass Parent(models.Model):\r\n    pass\r\n\r\nclass Children(Parent):\r\n    parent_ptr = models.OneToOne(Parent, parent_link=True)\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/django/django/pull/13922#discussion_r560952159",
    "filePath": "django/db/models/options.py",
    "diffHunk": "@@ -280,6 +280,10 @@ def _prepare(self, model):\n                 if already_created:\n                     field = already_created[0]\n                 field.primary_key = True\n+                try:\n+                    field.auto_created = field.reverse_related_fields[0][0].auto_created\n+                except ValueError:\n+                    pass",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-01-20T13:17:46Z",
    "isReviewComment": true,
    "pullRequestReviewId": 572209056,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:31.434Z"
  },
  {
    "repo": "django/django",
    "prNumber": 13484,
    "prTitle": "Fixed #31926 -- Fixed recreating queryset with FilteredRelation when using a pickled Query.",
    "prAuthor": "David-Wobrock",
    "prLink": "https://github.com/django/django/pull/13484",
    "commentAuthor": "charettes",
    "commentBody": "This will crash with `TypeError: 'Q' object is not iterable` if `limit_choices_to` is a `Q` object due to the use of `sorted` hence the previously suggested `if` construct.\r\n\r\nLooking at `make_hashable` it looks like it has a bug as it should be using `sorted` when dealing with `dict` otherwise two dict with different insert order won't generate the same hash. In other words `hash(make_hashable({'foo': 'bar', 'bar': 'foo'})) != hash(make_hashable({'bar': 'foo', 'foo': 'bar'}))` when dict are equals which breaks the expected `__eq__` and `__hash__` property.\r\n\r\nI think the right way forward is to adjust `make_hashable` and use it directly here without the `tuple(sorted(...))` wrapping.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/django/django/pull/13484#discussion_r499571609",
    "filePath": "django/db/models/fields/reverse_related.py",
    "diffHunk": "@@ -115,6 +116,28 @@ def __repr__(self):\n             self.related_model._meta.model_name,\n         )\n \n+    @property\n+    def identity(self):\n+        return (\n+            self.field,\n+            self.model,\n+            self.related_name,\n+            self.related_query_name,\n+            tuple(sorted(make_hashable(self.limit_choices_to))),",
    "line": 19,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-10-05T12:47:37Z",
    "isReviewComment": true,
    "pullRequestReviewId": 502018708,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:31.381Z"
  },
  {
    "repo": "django/django",
    "prNumber": 13043,
    "prTitle": "simplified the cumbersome condition in ModelBase.__new__()",
    "prAuthor": "SergBobrovsky",
    "prLink": "https://github.com/django/django/pull/13043",
    "commentAuthor": "charettes",
    "commentBody": "I'm not sure what's _obvious_ about this change. You turned three `O(1)` constant lookups (`dict`, `dict`, `set`) into a new object materialization (`chain`) that involves iterating over all objects followed by a `O(n)` lookup where `n = len(field_names) + len(new_class.__dict__) + len(inherited_attributes)`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/django/django/pull/13043#discussion_r438105248",
    "filePath": "django/db/models/base.py",
    "diffHunk": "@@ -271,9 +271,9 @@ def __new__(cls, name, bases, attrs, **kwargs):\n \n                 # Add fields from abstract base class if it wasn't overridden.\n                 for field in parent_fields:\n-                    if (field.name not in field_names and\n-                            field.name not in new_class.__dict__ and\n-                            field.name not in inherited_attributes):\n+                    if field.name not in chain(field_names,\n+                                               new_class.__dict__,\n+                                               inherited_attributes):",
    "line": 9,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-06-10T13:05:00Z",
    "isReviewComment": true,
    "pullRequestReviewId": 428030455,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:31.322Z"
  },
  {
    "repo": "django/django",
    "prNumber": 12946,
    "prTitle": "Fixed #27445 -- RadioSelect widget does not work for NullBooleanField.",
    "prAuthor": "smithdc1",
    "prLink": "https://github.com/django/django/pull/12946",
    "commentAuthor": "carltongibson",
    "commentBody": "The assignment to `self.choices` has no effect. Not being a subclass of `ChoiceField`, it's not used in validation. (Nothing fails removing it.)",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/django/django/pull/12946#discussion_r498114046",
    "filePath": "django/forms/fields.py",
    "diffHunk": "@@ -734,6 +734,15 @@ class NullBooleanField(BooleanField):\n     \"\"\"\n     widget = NullBooleanSelect\n \n+    def __init__(self, **kwargs):\n+        super().__init__(**kwargs)\n+        if not isinstance(self.widget, NullBooleanSelect):\n+            self.choices = self.widget.choices = [",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-10-01T09:39:16Z",
    "isReviewComment": true,
    "pullRequestReviewId": 500175352,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:34.288Z"
  },
  {
    "repo": "django/django",
    "prNumber": 12931,
    "prTitle": "Fixed #31603 -- Changed \"Clear all filters\" link to just removes filters.",
    "prAuthor": "hramezani",
    "prLink": "https://github.com/django/django/pull/12931",
    "commentAuthor": "felixxm",
    "commentBody": "This will not preserve other parameters passed via the query string.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/django/django/pull/12931#discussion_r427026496",
    "filePath": "django/contrib/admin/templates/admin/change_list.html",
    "diffHunk": "@@ -60,8 +60,8 @@\n         {% if cl.has_filters %}\n           <div id=\"changelist-filter\">\n             <h2>{% translate 'Filter' %}</h2>\n-            {% if cl.preserved_filters %}<h3 id=\"changelist-filter-clear\">\n-              <a href=\"?{% if cl.is_popup %}_popup=1{% endif %}\">&#10006; {% translate \"Clear all filters\" %}</a>\n+            {% if cl.get_filters_params %}<h3 id=\"changelist-filter-clear\">\n+              <a href=\"?{{ cl.get_clear_all_filters_link }}\">&#10006; {% translate \"Clear all filters\" %}</a>",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-05-19T04:42:48Z",
    "isReviewComment": true,
    "pullRequestReviewId": 414093474,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:33.780Z"
  },
  {
    "repo": "django/django",
    "prNumber": 11854,
    "prTitle": "Fixes #30807 -- Fix permissions when extracting archives",
    "prAuthor": "awtimmering",
    "prLink": "https://github.com/django/django/pull/11854",
    "commentAuthor": "ngnpope",
    "commentBody": "`S_IROTH` is \"other read\", not \"owner read\".",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/django/django/pull/11854#discussion_r329354616",
    "filePath": "django/utils/archive.py",
    "diffHunk": "@@ -100,12 +100,10 @@ class BaseArchive:\n     @staticmethod\n     def _copy_permissions(mode, filename):\n         \"\"\"\n-        If the file in the archive has some permissions (this assumes a file\n-        won't be writable/executable without being readable), apply those\n-        permissions to the unarchived file.\n+        Carry over permissions from the archive, ensuring extracted files are \n+        always owner readable.\n         \"\"\"\n-        if mode & stat.S_IROTH:\n-            os.chmod(filename, mode)\n+        os.chmod(filename, mode | stat.S_IROTH)",
    "line": 12,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2019-09-29T13:54:24Z",
    "isReviewComment": true,
    "pullRequestReviewId": 294685127,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:33.610Z"
  },
  {
    "repo": "django/django",
    "prNumber": 11712,
    "prTitle": "Fixed#30200 Added support to update array using indexes",
    "prAuthor": "nasirhjafri",
    "prLink": "https://github.com/django/django/pull/11712",
    "commentAuthor": "charettes",
    "commentBody": "That won't work if a field is updated twice in the same `update`\r\n\r\ne.g.\r\n\r\n```sql\r\nupdate(jsonfield__key='value', jsonfield__otherkey='othervalue')\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/django/django/pull/11712#discussion_r368241777",
    "filePath": "django/db/models/sql/subqueries.py",
    "diffHunk": "@@ -114,7 +115,9 @@ def add_update_values(self, values):\n         \"\"\"\n         values_seq = []\n         for name, val in values.items():\n-            field = self.get_meta().get_field(name)\n+            lookups, name, _ = self.solve_lookup_type(name)\n+            self.key_lookups[name[0]] = lookups",
    "line": 14,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-01-18T18:38:29Z",
    "isReviewComment": true,
    "pullRequestReviewId": 344956576,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:33.748Z"
  },
  {
    "repo": "django/django",
    "prNumber": 11202,
    "prTitle": "Fixed autocomplete while specified `to_field` in ForeignKey which is not primary",
    "prAuthor": "zthxxx",
    "prLink": "https://github.com/django/django/pull/11202",
    "commentAuthor": "apollo13",
    "commentBody": "`getattr` will throw a `ValueError` if the `to_field` does not exist, this has to be handled.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/django/django/pull/11202#discussion_r277130873",
    "filePath": "django/contrib/admin/views/autocomplete.py",
    "diffHunk": "@@ -24,11 +24,17 @@ def get(self, request, *args, **kwargs):\n             return JsonResponse({'error': '403 Forbidden'}, status=403)\n \n         self.term = request.GET.get('term', '')\n+        self.paginator_class = self.model_admin.paginator\n         self.object_list = self.get_queryset()\n         context = self.get_context_data()\n+\n+        # specified ForeignKey by `AutocompleteMixin.get_url`\n+        # ForeignKey may not be a primary_key\n+        to_field = request.GET.get('_to_field', 'pk')\n+\n         return JsonResponse({\n             'results': [\n-                {'id': str(obj.pk), 'text': str(obj)}\n+                {'id': str(getattr(obj, to_field)), 'text': str(obj)}",
    "line": 23,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2019-04-20T10:26:32Z",
    "isReviewComment": true,
    "pullRequestReviewId": 228873903,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:35.985Z"
  },
  {
    "repo": "django/django",
    "prNumber": 10467,
    "prTitle": "use setdefault for django.utils.translation.trans_real",
    "prAuthor": "waketzheng",
    "prLink": "https://github.com/django/django/pull/10467",
    "commentAuthor": "charettes",
    "commentBody": "Not sure this is desired, as it will create a `DjangoTranslation` instance for each `translation` call while the previous code wasn't. As you can see above `DjangoTranslation.__init__` isn't cheap.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/django/django/pull/10467#discussion_r222013810",
    "filePath": "django/utils/translation/trans_real.py",
    "diffHunk": "@@ -195,9 +195,7 @@ def translation(language):\n     Return a translation object in the default 'django' domain.\n     \"\"\"\n     global _translations\n-    if language not in _translations:\n-        _translations[language] = DjangoTranslation(language)\n-    return _translations[language]\n+    return _translations.setdefault(language, DjangoTranslation(language))",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2018-10-02T16:04:29Z",
    "isReviewComment": true,
    "pullRequestReviewId": 160800740,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:35.918Z"
  },
  {
    "repo": "django/django",
    "prNumber": 9839,
    "prTitle": "Fixed #16470 -- Allowed FileResponse to auto-set some Content headers.",
    "prAuthor": "claudep",
    "prLink": "https://github.com/django/django/pull/9839",
    "commentAuthor": "intgr",
    "commentBody": "I think filename should also be quoted if it includes the literal `\"` character?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/django/django/pull/9839#discussion_r190070736",
    "filePath": "django/http/response.py",
    "diffHunk": "@@ -391,17 +393,60 @@ class FileResponse(StreamingHttpResponse):\n     \"\"\"\n     block_size = 4096\n \n+    def __init__(self, *args, as_attachment=False, filename='', **kwargs):\n+        self.as_attachment = as_attachment\n+        self.filename = filename\n+        super().__init__(*args, **kwargs)\n+\n     def _set_streaming_content(self, value):\n-        if hasattr(value, 'read'):\n-            self.file_to_stream = value\n-            filelike = value\n-            if hasattr(filelike, 'close'):\n-                self._closable_objects.append(filelike)\n-            value = iter(lambda: filelike.read(self.block_size), b'')\n-        else:\n+        if not hasattr(value, 'read'):\n             self.file_to_stream = None\n+            return super()._set_streaming_content(value)\n+\n+        self.file_to_stream = filelike = value\n+        if hasattr(filelike, 'close'):\n+            self._closable_objects.append(filelike)\n+        value = iter(lambda: filelike.read(self.block_size), b'')\n+        self.set_headers(filelike)\n         super()._set_streaming_content(value)\n \n+    def set_headers(self, filelike):\n+        \"\"\"\n+        Set some common response headers (Content-Length, Content-Type, and\n+        Content-Disposition) based on the `filelike` response content.\n+        \"\"\"\n+        encoding_map = {\n+            'bzip2': 'application/x-bzip',\n+            'gzip': 'application/gzip',\n+            'xz': 'application/x-xz',\n+        }\n+        filename = getattr(filelike, 'name', None)\n+        filename = filename if (isinstance(filename, str) and filename) else self.filename\n+        if os.path.isabs(filename):\n+            self['Content-Length'] = os.path.getsize(filelike.name)\n+        elif hasattr(filelike, 'getbuffer'):\n+            self['Content-Length'] = filelike.getbuffer().nbytes\n+\n+        if self.get('Content-Type', '').startswith(settings.DEFAULT_CONTENT_TYPE):\n+            if filename:\n+                content_type, encoding = mimetypes.guess_type(filename)\n+                # Encoding isn't set to prevent browsers from automatically\n+                # uncompressing files.\n+                content_type = encoding_map.get(encoding, content_type)\n+                self['Content-Type'] = content_type or 'application/octet-stream'\n+            else:\n+                self['Content-Type'] = 'application/octet-stream'\n+\n+        if self.as_attachment:\n+            filename = self.filename or os.path.basename(filename)\n+            if filename:\n+                try:\n+                    filename.encode('ascii')\n+                    file_expr = 'filename=\"{}\"'.format(filename)",
    "line": 75,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2018-05-22T22:17:40Z",
    "isReviewComment": true,
    "pullRequestReviewId": 122373838,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:36.052Z"
  },
  {
    "repo": "django/django",
    "prNumber": 9118,
    "prTitle": "bug#28198. Fixed attributes. Now all attributes which are in parent a…",
    "prAuthor": "denys-tarykin",
    "prLink": "https://github.com/django/django/pull/9118",
    "commentAuthor": "charettes",
    "commentBody": "Having child class initialization delete parent attributes won't fly. What if your parent has two children\r\n\r\n```python\r\nclass A(models.Model):\r\n    foo = True\r\n\r\nclass B(A):\r\n    foo = models.TextField()\r\n\r\nclass C(A):\r\n    pass\r\n\r\nassert C.foo  # AttributeError.\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/django/django/pull/9118#discussion_r139983072",
    "filePath": "django/db/models/base.py",
    "diffHunk": "@@ -85,6 +85,12 @@ def __new__(cls, name, bases, attrs):\n         classcell = attrs.pop('__classcell__', None)\n         if classcell is not None:\n             new_attrs['__classcell__'] = classcell\n+        # Fix related to bug #28198.\n+        # Remove duplicate public attributes from parent classes\n+        for key in attrs.keys():\n+            for parent in parents:\n+                if hasattr(parent, key) and not key.startswith('__'):\n+                    delattr(parent, key)",
    "line": 9,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2017-09-20T14:19:44Z",
    "isReviewComment": true,
    "pullRequestReviewId": 63991070,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:37.698Z"
  },
  {
    "repo": "spring-projects/spring-boot",
    "prNumber": 42158,
    "prTitle": "Add Graylog Extended Log Format (GELF) for structured logging",
    "prAuthor": "slissner",
    "prLink": "https://github.com/spring-projects/spring-boot/pull/42158",
    "commentAuthor": "osiegmar",
    "commentBody": "The timestamp uses the wrong (exponential) format – caused by the `doubleValue` call on `BigDecimal`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/spring-projects/spring-boot/pull/42158#discussion_r1746508295",
    "filePath": "spring-boot-project/spring-boot-docs/src/docs/antora/modules/reference/pages/features/logging.adoc",
    "diffHunk": "@@ -490,6 +491,53 @@ logging:\n \n NOTE: configprop:logging.structured.ecs.service.name[] will default to configprop:spring.application.name[] if not specified.\n \n+NOTE: configprop:logging.structured.ecs.service.version[] will default to configprop:spring.application.version[] if not specified.\n+\n+\n+\n+[[features.logging.structured.gelf]]\n+=== Graylog Extended Log Format (GELF)\n+https://go2docs.graylog.org/current/getting_in_log_data/gelf.html[Graylog Extended Log Format] is a JSON based logging format for the Graylog log analytics platform.\n+\n+To enable the Graylog Extended Log Format, set the appropriate `format` property to `gelf`:\n+\n+[configprops,yaml]\n+----\n+logging:\n+  structured:\n+    format:\n+      console: gelf\n+      file: gelf\n+----\n+\n+A log line looks like this:\n+\n+[source,json]\n+----\n+{\"version\":\"1.1\",\"short_message\":\"Hello structured logging!\",\"timestamp\":1.725530750186E9,\"level\":6,\"_level_name\":\"INFO\",\"_process_pid\":9086,\"_process_thread_name\":\"main\",\"host\":\"spring-boot-gelf\",\"_log_logger\":\"com.slissner.springbootgelf.ExampleLogger\",\"_userId\":\"1\",\"_testkey_testmessage\":\"test\"}",
    "line": 35,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-09-06T04:53:39Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2284750182,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:45:11.076Z"
  },
  {
    "repo": "spring-projects/spring-boot",
    "prNumber": 29274,
    "prTitle": "Use emptyList() instead of null",
    "prAuthor": "hjun-park",
    "prLink": "https://github.com/spring-projects/spring-boot/pull/29274",
    "commentAuthor": "spencergibb",
    "commentBody": "There's no guarantee that resolvers is not null since there is no assertion in the constructor.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/spring-projects/spring-boot/pull/29274#discussion_r779259160",
    "filePath": "spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/servlet/error/AbstractErrorController.java",
    "diffHunk": "@@ -62,7 +63,7 @@ public AbstractErrorController(ErrorAttributes errorAttributes, List<ErrorViewRe\n \n \tprivate List<ErrorViewResolver> sortErrorViewResolvers(List<ErrorViewResolver> resolvers) {\n \t\tList<ErrorViewResolver> sorted = new ArrayList<>();\n-\t\tif (resolvers != null) {",
    "line": 21,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 143420157,
        "node_id": "REA_lATOAGAU1s4uco0YzgiMav0",
        "user": {
          "login": "hjun-park",
          "id": 70880695,
          "node_id": "MDQ6VXNlcjcwODgwNjk1",
          "avatar_url": "https://avatars.githubusercontent.com/u/70880695?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/hjun-park",
          "html_url": "https://github.com/hjun-park",
          "followers_url": "https://api.github.com/users/hjun-park/followers",
          "following_url": "https://api.github.com/users/hjun-park/following{/other_user}",
          "gists_url": "https://api.github.com/users/hjun-park/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/hjun-park/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/hjun-park/subscriptions",
          "organizations_url": "https://api.github.com/users/hjun-park/orgs",
          "repos_url": "https://api.github.com/users/hjun-park/repos",
          "events_url": "https://api.github.com/users/hjun-park/events{/privacy}",
          "received_events_url": "https://api.github.com/users/hjun-park/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2022-01-06T07:07:25Z"
      }
    ],
    "timestamp": "2022-01-06T02:24:03Z",
    "isReviewComment": true,
    "pullRequestReviewId": 845228153,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:37.698Z"
  },
  {
    "repo": "spring-projects/spring-boot",
    "prNumber": 26476,
    "prTitle": "Polish SpringApplication",
    "prAuthor": "nguyensach",
    "prLink": "https://github.com/spring-projects/spring-boot/pull/26476",
    "commentAuthor": "wilkinsona",
    "commentBody": "This changes behaviour as any exception from the `close()` call will no longer be caught and logged as a warning.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/spring-projects/spring-boot/pull/26476#discussion_r633079979",
    "filePath": "spring-boot-project/spring-boot/src/main/java/org/springframework/boot/SpringApplication.java",
    "diffHunk": "@@ -802,22 +803,20 @@ private void callRunner(CommandLineRunner runner, ApplicationArguments args) {\n \tprivate void handleRunFailure(ConfigurableApplicationContext context, Throwable exception,\n \t\t\tSpringApplicationRunListeners listeners) {\n \t\ttry {\n-\t\t\ttry {\n-\t\t\t\thandleExitCode(context, exception);\n-\t\t\t\tif (listeners != null) {\n-\t\t\t\t\tlisteners.failed(context, exception);\n-\t\t\t\t}\n-\t\t\t}\n-\t\t\tfinally {\n-\t\t\t\treportFailure(getExceptionReporters(context), exception);\n-\t\t\t\tif (context != null) {\n-\t\t\t\t\tcontext.close();\n-\t\t\t\t}\n+\t\t\thandleExitCode(context, exception);\n+\t\t\tif (listeners != null) {\n+\t\t\t\tlisteners.failed(context, exception);\n \t\t\t}\n \t\t}\n \t\tcatch (Exception ex) {\n \t\t\tlogger.warn(\"Unable to close ApplicationContext\", ex);\n \t\t}\n+\t\tfinally {\n+\t\t\treportFailure(getExceptionReporters(context), exception);\n+\t\t\tif (context != null) {\n+\t\t\t\tcontext.close();",
    "line": 34,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 112177654,
        "node_id": "MDMyOlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudFJlYWN0aW9uMTEyMTc3NjU0",
        "user": {
          "login": "nguyensach",
          "id": 23326432,
          "node_id": "MDQ6VXNlcjIzMzI2NDMy",
          "avatar_url": "https://avatars.githubusercontent.com/u/23326432?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/nguyensach",
          "html_url": "https://github.com/nguyensach",
          "followers_url": "https://api.github.com/users/nguyensach/followers",
          "following_url": "https://api.github.com/users/nguyensach/following{/other_user}",
          "gists_url": "https://api.github.com/users/nguyensach/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/nguyensach/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/nguyensach/subscriptions",
          "organizations_url": "https://api.github.com/users/nguyensach/orgs",
          "repos_url": "https://api.github.com/users/nguyensach/repos",
          "events_url": "https://api.github.com/users/nguyensach/events{/privacy}",
          "received_events_url": "https://api.github.com/users/nguyensach/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2021-05-16T11:46:02Z"
      }
    ],
    "timestamp": "2021-05-16T11:30:45Z",
    "isReviewComment": true,
    "pullRequestReviewId": 660428844,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:37.805Z"
  },
  {
    "repo": "spring-projects/spring-boot",
    "prNumber": 15756,
    "prTitle": "Add more mustache auto configuration",
    "prAuthor": "ayudovin",
    "prLink": "https://github.com/spring-projects/spring-boot/pull/15756",
    "commentAuthor": "wilkinsona",
    "commentBody": "This ignores the input `value` and always returns the value of the `spring.mustache.formatter.value` property.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/spring-projects/spring-boot/pull/15756#discussion_r249700111",
    "filePath": "spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/mustache/MustacheAutoConfiguration.java",
    "diffHunk": "@@ -79,8 +81,31 @@ public void checkTemplateLocationExists() {\n \t@Bean\n \t@ConditionalOnMissingBean\n \tpublic Mustache.Compiler mustacheCompiler(TemplateLoader mustacheTemplateLoader) {\n-\t\treturn Mustache.compiler().withLoader(mustacheTemplateLoader)\n-\t\t\t\t.withCollector(collector());\n+\t\tPropertyMapper pm = PropertyMapper.get().alwaysApplyingWhenNonNull();\n+\t\tMustache.Compiler compiler = Mustache.compiler();\n+\n+\t\tcompiler = pm.from(this.mustache.getDefaultValue())\n+\t\t\t\t.toInstance(compiler::defaultValue, compiler);\n+\t\tcompiler = pm.from(this.mustache.getNullValue()).toInstance(compiler::nullValue,\n+\t\t\t\tcompiler);\n+\n+\t\tcompiler = compiler.withLoader(mustacheTemplateLoader).withCollector(collector());\n+\n+\t\treturn compiler;\n+\t}\n+\n+\t@Bean\n+\t@ConditionalOnMissingBean\n+\t@ConditionalOnProperty(\"spring.mustache.formatter.value\")\n+\tpublic Mustache.Formatter mustacheFormatter() {\n+\t\treturn (value) -> this.mustache.getFormatter().getValue();",
    "line": 34,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2019-01-22T09:30:41Z",
    "isReviewComment": true,
    "pullRequestReviewId": 194906623,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:37.631Z"
  },
  {
    "repo": "spring-projects/spring-boot",
    "prNumber": 4954,
    "prTitle": "Introduce HealthIndicatorRegistry with support for invocation of HealthIndicators",
    "prAuthor": "vpavic",
    "prLink": "https://github.com/spring-projects/spring-boot/pull/4954",
    "commentAuthor": "wilkinsona",
    "commentBody": "This isn't thread-safe\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/spring-projects/spring-boot/pull/4954#discussion_r49944696",
    "filePath": "spring-boot-actuator/src/main/java/org/springframework/boot/actuate/health/DefaultHealthIndicatorRegistry.java",
    "diffHunk": "@@ -0,0 +1,149 @@\n+/*\n+ * Copyright 2012-2016 the original author or authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.springframework.boot.actuate.health;\n+\n+import java.util.Collections;\n+import java.util.HashMap;\n+import java.util.HashSet;\n+import java.util.Map;\n+import java.util.Set;\n+import java.util.concurrent.Callable;\n+import java.util.concurrent.ExecutorService;\n+import java.util.concurrent.Executors;\n+import java.util.concurrent.Future;\n+import java.util.concurrent.ThreadFactory;\n+import java.util.concurrent.atomic.AtomicInteger;\n+\n+import org.apache.commons.logging.Log;\n+import org.apache.commons.logging.LogFactory;\n+\n+import org.springframework.util.Assert;\n+import org.springframework.util.ClassUtils;\n+\n+/**\n+ * Default implementation of {@link HealthIndicatorRegistry}.\n+ *\n+ * @author Vedran Pavic\n+ */\n+public class DefaultHealthIndicatorRegistry implements HealthIndicatorRegistry {\n+\n+\tprivate static final Log logger = LogFactory.getLog(DefaultHealthIndicatorRegistry.class);\n+\n+\tprivate final Map<String, HealthIndicator> healthIndicators =\n+\t\t\tnew HashMap<String, HealthIndicator>();\n+\n+\tprivate DefaultHealthIndicatorRegistryProperties properties;\n+\n+\tprivate ExecutorService executor;\n+\n+\t/**\n+\t * Create a {@link DefaultHealthIndicatorRegistry} instance.\n+\t * @param properties the configuration properties\n+\t */\n+\tpublic DefaultHealthIndicatorRegistry(DefaultHealthIndicatorRegistryProperties properties) {\n+\t\tAssert.notNull(properties, \"Properties must not be null\");\n+\t\tthis.properties = properties;\n+\t\tif (this.properties.isRunInParallel()) {\n+\t\t\tthis.executor = Executors.newFixedThreadPool(\n+\t\t\t\t\tthis.properties.getThreadCount(), new WorkerThreadFactory());\n+\t\t}\n+\t}\n+\n+\t/**\n+\t * Create a {@link DefaultHealthIndicatorRegistry} instance.\n+\t */\n+\tpublic DefaultHealthIndicatorRegistry() {\n+\t\tthis(new DefaultHealthIndicatorRegistryProperties());\n+\t}\n+\n+\t@Override\n+\tpublic void register(String name, HealthIndicator healthIndicator) {\n+\t\tsynchronized (this.healthIndicators) {\n+\t\t\tthis.healthIndicators.put(name, healthIndicator);\n+\t\t}\n+\t}\n+\n+\t@Override\n+\tpublic void unregister(String name) {\n+\t\tsynchronized (this.healthIndicators) {\n+\t\t\tthis.healthIndicators.remove(name);\n+\t\t}\n+\t}\n+\n+\t@Override\n+\tpublic Set<String> getRegisteredNames() {\n+\t\treturn Collections.unmodifiableSet(new HashSet<String>(this.healthIndicators.keySet()));",
    "line": 89,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2016-01-17T11:17:45Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:39.444Z"
  },
  {
    "repo": "docker/compose",
    "prNumber": 11984,
    "prTitle": "Update config/secret handling: Copy files into containers instead of bind mounting",
    "prAuthor": "schaubl",
    "prLink": "https://github.com/docker/compose/pull/11984",
    "commentAuthor": "ndeloof",
    "commentBody": "`file` can actually be a folder. Need to change logic here to produce tar, not just extract content",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/docker/compose/pull/11984#discussion_r1763315834",
    "filePath": "pkg/compose/secrets.go",
    "diffHunk": "@@ -31,7 +32,23 @@ import (\n func (s *composeService) injectSecrets(ctx context.Context, project *types.Project, service types.ServiceConfig, id string) error {\n \tfor _, config := range service.Secrets {\n \t\tfile := project.Secrets[config.Source]\n-\t\tif file.Environment == \"\" {\n+\t\tcontent := file.Content\n+\n+\t\tif file.Environment != \"\" {\n+\t\t\tenv, ok := project.Environment[file.Environment]\n+\t\t\tif !ok {\n+\t\t\t\treturn fmt.Errorf(\"environment variable %q required by file %q is not set\", file.Environment, file.Name)\n+\t\t\t}\n+\t\t\tcontent = env\n+\t\t} else if file.File != \"\" {\n+\t\t\tdata, err := os.ReadFile(file.File)",
    "line": 22,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-09-17T14:05:37Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2309874046,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T01:54:08.910Z"
  },
  {
    "repo": "docker/compose",
    "prNumber": 9169,
    "prTitle": "Add support to pass env-file to docker compose run",
    "prAuthor": "KoditkarVedant",
    "prLink": "https://github.com/docker/compose/pull/9169",
    "commentAuthor": "ndeloof",
    "commentBody": "need to make service envfile an absolute path",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/docker/compose/pull/9169#discussion_r1085699479",
    "filePath": "pkg/compose/run.go",
    "diffHunk": "@@ -127,4 +127,8 @@ func applyRunOptions(project *types.Project, service *types.ServiceConfig, opts\n \tfor k, v := range opts.Labels {\n \t\tservice.Labels = service.Labels.Add(k, v)\n \t}\n+\n+\tif opts.ServiceEnvFiles != nil {\n+\t\tservice.EnvFile = append(service.EnvFile, opts.ServiceEnvFiles...)",
    "line": 6,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-01-24T18:02:47Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1267995354,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:39.478Z"
  },
  {
    "repo": "docker/compose",
    "prNumber": 6476,
    "prTitle": "Use container_name as prefix if explicitly defined",
    "prAuthor": "collin5",
    "prLink": "https://github.com/docker/compose/pull/6476",
    "commentAuthor": "chris-crone",
    "commentBody": "The `prefix_width` can no longer be calculated just from the `service_names` as the longest name could now be a `container_name`.\r\n\r\nAs part of this change, we may be able to avoid passing the whole `config` to `__init__`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/docker/compose/pull/6476#discussion_r273428030",
    "filePath": "compose/cli/log_printer.py",
    "diffHunk": "@@ -19,18 +19,21 @@\n \n class LogPresenter(object):\n \n-    def __init__(self, prefix_width, color_func):\n+    def __init__(self, prefix_width, color_func, config=None):\n         self.prefix_width = prefix_width\n         self.color_func = color_func\n+        self.prefixes = {s['name']: s['container_name'] for s in filter(\n+            lambda service: service.get('container_name', False), config.services if config else [])}\n \n     def present(self, container, line):\n-        prefix = container.name_without_project.ljust(self.prefix_width)\n+        prefix = self.prefixes.get(\n+            container.service, container.name_without_project).ljust(self.prefix_width)\n         return '{prefix} {line}'.format(\n             prefix=self.color_func(prefix + ' |'),\n             line=line)\n \n \n-def build_log_presenters(service_names, monochrome):\n+def build_log_presenters(service_names, monochrome, config=None):",
    "line": 21,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2019-04-09T10:36:30Z",
    "isReviewComment": true,
    "pullRequestReviewId": 224322356,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:39.624Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 30302,
    "prTitle": "Separate out railties tests into two Travis jobs",
    "prAuthor": "maclover7",
    "prLink": "https://github.com/rails/rails/pull/30302",
    "commentAuthor": "kamipo",
    "commentBody": "If `ENV[\"SKIP_TEST_DIRS\"] = \"application\"`, it will also skip `railties/test/generators/application_record_generator_test.rb`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/rails/rails/pull/30302#discussion_r138612983",
    "filePath": "railties/Rakefile",
    "diffHunk": "@@ -13,7 +13,17 @@ namespace :test do\n   task :isolated do\n     dirs = (ENV[\"TEST_DIR\"] || ENV[\"TEST_DIRS\"] || \"**\").split(\",\")\n     test_files = dirs.map { |dir| \"test/#{dir}/*_test.rb\" }\n-    Dir[*test_files].each do |file|\n+    test_files = Dir[*test_files]\n+\n+    skip_dirs = (ENV[\"SKIP_TEST_DIR\"] || ENV[\"SKIP_TEST_DIRS\"] || \"\").split(\",\")\n+\n+    if !skip_dirs.empty?\n+      test_files.reject! do |filename|\n+        skip_dirs.any? { |skip_dir| filename.include?(skip_dir) }",
    "line": 11,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2017-09-13T13:07:14Z",
    "isReviewComment": true,
    "pullRequestReviewId": 62430031,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:41.417Z"
  },
  {
    "repo": "rails/rails",
    "prNumber": 29848,
    "prTitle": "Fix `COUNT(DISTINCT ...)` with `ORDER BY` and `LIMIT`",
    "prAuthor": "kamipo",
    "prLink": "https://github.com/rails/rails/pull/29848",
    "commentAuthor": "metaskills",
    "commentBody": "Hi! I am the maintainer of the SQL Server adapter. I'm just catching up to this change and I found out it breaks all the adapter counts during this code path because this is not a valid syntax:\r\n\r\n```sql\r\nSELECT * FROM ( SELECT 1 ) count\r\n```\r\n\r\nIt would be if `AS one` was used which is provided by `FinderMethods::ONE_AS_ONE`.",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/rails/rails/pull/29848#discussion_r140621038",
    "filePath": "activerecord/lib/active_record/relation/calculations.rb",
    "diffHunk": "@@ -381,14 +386,18 @@ def select_for_count\n       end\n \n       def build_count_subquery(relation, column_name, distinct)\n-        column_alias = Arel.sql(\"count_column\")\n-        subquery_alias = Arel.sql(\"subquery_for_count\")\n+        relation.select_values = [\n+          if column_name == :all\n+            distinct ? table[Arel.star] : Arel.sql(\"1\")",
    "line": 42,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 14232373,
        "node_id": "MDMyOlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudFJlYWN0aW9uMTQyMzIzNzM=",
        "user": {
          "login": "redtachyons",
          "id": 22680876,
          "node_id": "MDQ6VXNlcjIyNjgwODc2",
          "avatar_url": "https://avatars.githubusercontent.com/u/22680876?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/redtachyons",
          "html_url": "https://github.com/redtachyons",
          "followers_url": "https://api.github.com/users/redtachyons/followers",
          "following_url": "https://api.github.com/users/redtachyons/following{/other_user}",
          "gists_url": "https://api.github.com/users/redtachyons/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/redtachyons/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/redtachyons/subscriptions",
          "organizations_url": "https://api.github.com/users/redtachyons/orgs",
          "repos_url": "https://api.github.com/users/redtachyons/repos",
          "events_url": "https://api.github.com/users/redtachyons/events{/privacy}",
          "received_events_url": "https://api.github.com/users/redtachyons/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2017-09-23T12:38:45Z"
      }
    ],
    "timestamp": "2017-09-23T00:52:38Z",
    "isReviewComment": true,
    "pullRequestReviewId": 64726776,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "reReviewedAfterJan27th": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:41.358Z"
  },
  {
    "repo": "hashicorp/terraform",
    "prNumber": 11033,
    "prTitle": "Added support for EMR AutoScalingRole",
    "prAuthor": "tolis-sisiaridis",
    "prLink": "https://github.com/hashicorp/terraform/pull/11033",
    "commentAuthor": "stack72",
    "commentBody": "This defined here and also, on Line 268\r\n\r\nThe declaration on line 268 is the correct one as it's optional and cannot be guaranteed to be here. We would be passing an empty string to the API with this declaration and no autoscaling role being defined",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/hashicorp/terraform/pull/11033#discussion_r105009187",
    "filePath": "builtin/providers/aws/resource_aws_emr_cluster.go",
    "diffHunk": "@@ -253,12 +258,16 @@ func resourceAwsEMRClusterCreate(d *schema.ResourceData, meta interface{}) error\n \n \t\tReleaseLabel:      aws.String(d.Get(\"release_label\").(string)),\n \t\tServiceRole:       aws.String(d.Get(\"service_role\").(string)),\n+\t\tAutoScalingRole:   aws.String(d.Get(\"autoscaling_role\").(string)),",
    "line": 16,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2017-03-08T20:01:35Z",
    "isReviewComment": true,
    "pullRequestReviewId": 25869437,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:43.963Z"
  },
  {
    "repo": "hashicorp/terraform",
    "prNumber": 10172,
    "prTitle": "ns1 provider",
    "prAuthor": "josephholsten",
    "prLink": "https://github.com/hashicorp/terraform/pull/10172",
    "commentAuthor": "pashap",
    "commentBody": "These should be:\n\n```\na.Meta.Up = data.FeedPtr{value.(string)}\n```\n\nThe `data.NewFeed` constructs a new datafeed, whereas we want a 'feed pointer'\n",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/hashicorp/terraform/pull/10172#discussion_r88319945",
    "filePath": "builtin/providers/nsone/resource_record.go",
    "diffHunk": "@@ -0,0 +1,854 @@\n+package nsone\n+\n+import (\n+\t\"bytes\"\n+\t\"errors\"\n+\t\"fmt\"\n+\t\"log\"\n+\t\"regexp\"\n+\t\"sort\"\n+\t\"strconv\"\n+\t\"strings\"\n+\n+\t\"github.com/hashicorp/terraform/helper/hashcode\"\n+\t\"github.com/hashicorp/terraform/helper/schema\"\n+\n+\tnsone \"gopkg.in/ns1/ns1-go.v2/rest\"\n+\t\"gopkg.in/ns1/ns1-go.v2/rest/model/data\"\n+\t\"gopkg.in/ns1/ns1-go.v2/rest/model/dns\"\n+\t\"gopkg.in/ns1/ns1-go.v2/rest/model/filter\"\n+)\n+\n+func recordResource() *schema.Resource {\n+\treturn &schema.Resource{\n+\t\tSchema: map[string]*schema.Schema{\n+\t\t\t// Required\n+\t\t\t\"zone\": &schema.Schema{\n+\t\t\t\tType:     schema.TypeString,\n+\t\t\t\tRequired: true,\n+\t\t\t\tForceNew: true,\n+\t\t\t},\n+\t\t\t\"domain\": &schema.Schema{\n+\t\t\t\tType:     schema.TypeString,\n+\t\t\t\tRequired: true,\n+\t\t\t\tForceNew: true,\n+\t\t\t},\n+\t\t\t\"type\": &schema.Schema{\n+\t\t\t\tType:     schema.TypeString,\n+\t\t\t\tRequired: true,\n+\t\t\t\tForceNew: true,\n+\t\t\t\tValidateFunc: func(v interface{}, k string) (ws []string, es []error) {\n+\t\t\t\t\tvalue := v.(string)\n+\t\t\t\t\tif !regexp.MustCompile(`^(A|AAAA|ALIAS|AFSDB|CNAME|DNAME|HINFO|MX|NAPTR|NS|PTR|RP|SPF|SRV|TXT)$`).MatchString(value) {\n+\t\t\t\t\t\tes = append(es, fmt.Errorf(\n+\t\t\t\t\t\t\t\"only A, AAAA, ALIAS, AFSDB, CNAME, DNAME, HINFO, MX, NAPTR, NS, PTR, RP, SPF, SRV, TXT allowed in %q\", k))\n+\t\t\t\t\t}\n+\t\t\t\t\treturn\n+\t\t\t\t},\n+\t\t\t},\n+\t\t\t// Optional\n+\t\t\t\"ttl\": &schema.Schema{\n+\t\t\t\tType:     schema.TypeInt,\n+\t\t\t\tOptional: true,\n+\t\t\t\tComputed: true,\n+\t\t\t},\n+\t\t\t\"meta\": metaSchema(),\n+\t\t\t\"link\": &schema.Schema{\n+\t\t\t\tType:     schema.TypeString,\n+\t\t\t\tOptional: true,\n+\t\t\t\tForceNew: true,\n+\t\t\t},\n+\t\t\t\"use_client_subnet\": &schema.Schema{\n+\t\t\t\tType:     schema.TypeBool,\n+\t\t\t\tOptional: true,\n+\t\t\t\tDefault:  false,\n+\t\t\t},\n+\t\t\t\"answers\": &schema.Schema{\n+\t\t\t\tType:     schema.TypeSet,\n+\t\t\t\tOptional: true,\n+\t\t\t\tElem: &schema.Resource{\n+\t\t\t\t\tSchema: map[string]*schema.Schema{\n+\t\t\t\t\t\t\"answer\": &schema.Schema{\n+\t\t\t\t\t\t\tType:     schema.TypeString,\n+\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t},\n+\t\t\t\t\t\t\"region\": &schema.Schema{\n+\t\t\t\t\t\t\tType:     schema.TypeString,\n+\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t},\n+\t\t\t\t\t\t\"meta\": &schema.Schema{\n+\t\t\t\t\t\t\tType:     schema.TypeSet,\n+\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t\tElem: &schema.Resource{\n+\t\t\t\t\t\t\t\tSchema: map[string]*schema.Schema{\n+\t\t\t\t\t\t\t\t\t\"field\": &schema.Schema{\n+\t\t\t\t\t\t\t\t\t\tType:     schema.TypeString,\n+\t\t\t\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t\t\t\t},\n+\t\t\t\t\t\t\t\t\t\"feed\": &schema.Schema{\n+\t\t\t\t\t\t\t\t\t\tType:     schema.TypeString,\n+\t\t\t\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t\t\t\t\t//ConflictsWith: []string{\"value\"},\n+\t\t\t\t\t\t\t\t\t},\n+\t\t\t\t\t\t\t\t\t\"value\": &schema.Schema{\n+\t\t\t\t\t\t\t\t\t\tType:     schema.TypeString,\n+\t\t\t\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t\t\t\t\t//ConflictsWith: []string{\"feed\"},\n+\t\t\t\t\t\t\t\t\t},\n+\t\t\t\t\t\t\t\t},\n+\t\t\t\t\t\t\t},\n+\t\t\t\t\t\t\tSet: metaToHash,\n+\t\t\t\t\t\t},\n+\t\t\t\t\t},\n+\t\t\t\t},\n+\t\t\t\tSet: answersToHash,\n+\t\t\t},\n+\t\t\t\"regions\": &schema.Schema{\n+\t\t\t\tType:     schema.TypeSet,\n+\t\t\t\tOptional: true,\n+\t\t\t\tElem: &schema.Resource{\n+\t\t\t\t\tSchema: map[string]*schema.Schema{\n+\t\t\t\t\t\t\"name\": &schema.Schema{\n+\t\t\t\t\t\t\tType:     schema.TypeString,\n+\t\t\t\t\t\t\tRequired: true,\n+\t\t\t\t\t\t},\n+\t\t\t\t\t\t\"georegion\": &schema.Schema{\n+\t\t\t\t\t\t\tType:     schema.TypeString,\n+\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t\tValidateFunc: func(v interface{}, k string) (ws []string, es []error) {\n+\t\t\t\t\t\t\t\tvalue := v.(string)\n+\t\t\t\t\t\t\t\tif !regexp.MustCompile(`^(US-WEST|US-EAST|US-CENTRAL|EUROPE|AFRICA|ASIAPAC|SOUTH-AMERICA)$`).MatchString(value) {\n+\t\t\t\t\t\t\t\t\tes = append(es, fmt.Errorf(\n+\t\t\t\t\t\t\t\t\t\t\"only US-WEST, US-EAST, US-CENTRAL, EUROPE, AFRICA, ASIAPAC, SOUTH-AMERICA allowed in %q\", k))\n+\t\t\t\t\t\t\t\t}\n+\t\t\t\t\t\t\t\treturn\n+\t\t\t\t\t\t\t},\n+\t\t\t\t\t\t},\n+\t\t\t\t\t\t\"country\": &schema.Schema{\n+\t\t\t\t\t\t\tType:     schema.TypeString,\n+\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t},\n+\t\t\t\t\t\t\"us_state\": &schema.Schema{\n+\t\t\t\t\t\t\tType:     schema.TypeString,\n+\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t},\n+\t\t\t\t\t\t\"up\": &schema.Schema{\n+\t\t\t\t\t\t\tType:     schema.TypeBool,\n+\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t},\n+\t\t\t\t\t},\n+\t\t\t\t},\n+\t\t\t\tSet: regionsToHash,\n+\t\t\t},\n+\t\t\t\"filters\": &schema.Schema{\n+\t\t\t\tType:     schema.TypeList,\n+\t\t\t\tOptional: true,\n+\t\t\t\tElem: &schema.Resource{\n+\t\t\t\t\tSchema: map[string]*schema.Schema{\n+\t\t\t\t\t\t\"filter\": &schema.Schema{\n+\t\t\t\t\t\t\tType:     schema.TypeString,\n+\t\t\t\t\t\t\tRequired: true,\n+\t\t\t\t\t\t},\n+\t\t\t\t\t\t\"disabled\": &schema.Schema{\n+\t\t\t\t\t\t\tType:     schema.TypeBool,\n+\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t},\n+\t\t\t\t\t\t\"config\": &schema.Schema{\n+\t\t\t\t\t\t\tType:     schema.TypeMap,\n+\t\t\t\t\t\t\tOptional: true,\n+\t\t\t\t\t\t},\n+\t\t\t\t\t},\n+\t\t\t\t},\n+\t\t\t},\n+\t\t\t// Computed\n+\t\t\t\"id\": &schema.Schema{\n+\t\t\t\tType:     schema.TypeString,\n+\t\t\t\tComputed: true,\n+\t\t\t},\n+\t\t},\n+\t\tCreate: RecordCreate,\n+\t\tRead:   RecordRead,\n+\t\tUpdate: RecordUpdate,\n+\t\tDelete: RecordDelete,\n+\t}\n+}\n+\n+func regionsToHash(v interface{}) int {\n+\tvar buf bytes.Buffer\n+\tr := v.(map[string]interface{})\n+\tbuf.WriteString(fmt.Sprintf(\"%s-\", r[\"name\"].(string)))\n+\tbuf.WriteString(fmt.Sprintf(\"%s-\", r[\"georegion\"].(string)))\n+\tbuf.WriteString(fmt.Sprintf(\"%s-\", r[\"country\"].(string)))\n+\tbuf.WriteString(fmt.Sprintf(\"%s-\", r[\"us_state\"].(string)))\n+\tbuf.WriteString(fmt.Sprintf(\"%t-\", r[\"up\"].(bool)))\n+\treturn hashcode.String(buf.String())\n+}\n+\n+func answersToHash(v interface{}) int {\n+\tvar buf bytes.Buffer\n+\ta := v.(map[string]interface{})\n+\tbuf.WriteString(fmt.Sprintf(\"%s-\", a[\"answer\"].(string)))\n+\tif a[\"region\"] != nil {\n+\t\tbuf.WriteString(fmt.Sprintf(\"%s-\", a[\"region\"].(string)))\n+\t}\n+\tvar metas []int\n+\tswitch t := a[\"meta\"].(type) {\n+\tdefault:\n+\t\tpanic(fmt.Sprintf(\"unexpected type %T\", t))\n+\tcase *schema.Set:\n+\t\tfor _, meta := range t.List() {\n+\t\t\tmetas = append(metas, metaToHash(meta))\n+\t\t}\n+\tcase []map[string]interface{}:\n+\t\tfor _, meta := range t {\n+\t\t\tmetas = append(metas, metaToHash(meta))\n+\t\t}\n+\t}\n+\tsort.Ints(metas)\n+\tfor _, metahash := range metas {\n+\t\tbuf.WriteString(fmt.Sprintf(\"%d-\", metahash))\n+\t}\n+\thash := hashcode.String(buf.String())\n+\tlog.Printf(\"Generated answersToHash %d from %+v\\n\", hash, a)\n+\treturn hash\n+}\n+\n+func metaToHash(v interface{}) int {\n+\tvar buf bytes.Buffer\n+\ts := v.(map[string]interface{})\n+\tbuf.WriteString(fmt.Sprintf(\"%s-\", s[\"field\"].(string)))\n+\tif v, ok := s[\"feed\"]; ok && v.(string) != \"\" {\n+\t\tbuf.WriteString(fmt.Sprintf(\"feed%s-\", v.(string)))\n+\t}\n+\tif v, ok := s[\"value\"]; ok && v.(string) != \"\" {\n+\t\tbuf.WriteString(fmt.Sprintf(\"value%s-\", v.(string)))\n+\t}\n+\n+\thash := hashcode.String(buf.String())\n+\tlog.Printf(\"Generated metaToHash %d from %+v\\n\", hash, s)\n+\treturn hash\n+}\n+\n+func recordToResourceData(d *schema.ResourceData, r *dns.Record) error {\n+\td.SetId(r.ID)\n+\td.Set(\"domain\", r.Domain)\n+\td.Set(\"zone\", r.Zone)\n+\td.Set(\"type\", r.Type)\n+\td.Set(\"ttl\", r.TTL)\n+\tif r.Link != \"\" {\n+\t\td.Set(\"link\", r.Link)\n+\t}\n+\tif len(r.Filters) > 0 {\n+\t\tfilters := make([]map[string]interface{}, len(r.Filters))\n+\t\tfor i, f := range r.Filters {\n+\t\t\tm := make(map[string]interface{})\n+\t\t\tm[\"filter\"] = f.Type\n+\t\t\tif f.Disabled {\n+\t\t\t\tm[\"disabled\"] = true\n+\t\t\t}\n+\t\t\tif f.Config != nil {\n+\t\t\t\tm[\"config\"] = f.Config\n+\t\t\t}\n+\t\t\tfilters[i] = m\n+\t\t}\n+\t\td.Set(\"filters\", filters)\n+\t}\n+\tif len(r.Answers) > 0 {\n+\t\tans := &schema.Set{\n+\t\t\tF: answersToHash,\n+\t\t}\n+\t\tlog.Printf(\"Got back from nsone answers: %+v\", r.Answers)\n+\t\tfor _, answer := range r.Answers {\n+\t\t\tans.Add(answerToMap(*answer))\n+\t\t}\n+\t\tlog.Printf(\"Setting answers %+v\", ans)\n+\t\terr := d.Set(\"answers\", ans)\n+\t\tif err != nil {\n+\t\t\treturn fmt.Errorf(\"[DEBUG] Error setting answers for: %s, error: %#v\", r.Domain, err)\n+\t\t}\n+\t}\n+\tif len(r.Regions) > 0 {\n+\t\tregions := make([]map[string]interface{}, 0, len(r.Regions))\n+\t\tfor regionName, region := range r.Regions {\n+\t\t\tnewRegion := make(map[string]interface{})\n+\t\t\tnewRegion[\"name\"] = regionName\n+\n+\t\t\tmeta := region.Meta\n+\t\t\t// TODO: support as FeedPtr\n+\t\t\tswitch meta.Georegion.(type) {\n+\t\t\tcase nil:\n+\t\t\t\tbreak\n+\t\t\tcase []interface{}:\n+\t\t\t\tgeoregion := region.Meta.Georegion.([]interface{})\n+\t\t\t\tif len(georegion) > 0 {\n+\t\t\t\t\tnewRegion[\"georegion\"] = georegion[0]\n+\t\t\t\t}\n+\t\t\tdefault:\n+\t\t\t\tpanic(fmt.Sprintf(\"meta.Georegion in unexpected type: %#v\", meta.Georegion))\n+\t\t\t}\n+\t\t\t// TODO: support as FeedPtr\n+\t\t\tswitch meta.Country.(type) {\n+\t\t\tcase nil:\n+\t\t\t\tbreak\n+\t\t\tcase []interface{}:\n+\t\t\t\tcountry := region.Meta.Country.([]interface{})\n+\t\t\t\tif len(country) > 0 {\n+\t\t\t\t\tnewRegion[\"country\"] = country[0]\n+\t\t\t\t}\n+\t\t\tdefault:\n+\t\t\t\tpanic(fmt.Sprintf(\"meta.Country in unexpected type: %#v\", meta.Country))\n+\t\t\t}\n+\t\t\t// TODO: support as FeedPtr\n+\t\t\tswitch meta.USState.(type) {\n+\t\t\tcase nil:\n+\t\t\t\tbreak\n+\t\t\tcase []interface{}:\n+\t\t\t\tusState := region.Meta.USState.([]interface{})\n+\t\t\t\tif len(usState) > 0 && usState != nil {\n+\t\t\t\t\tnewRegion[\"us_state\"] = usState[0]\n+\t\t\t\t}\n+\t\t\tdefault:\n+\t\t\t\tpanic(fmt.Sprintf(\"meta.USState in unexpected type: %#v\", meta.USState))\n+\t\t\t}\n+\t\t\t// TODO: support as FeedPtr\n+\t\t\tswitch meta.Up.(type) {\n+\t\t\tcase nil:\n+\t\t\t\tbreak\n+\t\t\tcase bool:\n+\t\t\t\tnewRegion[\"up\"] = region.Meta.Up.(bool)\n+\t\t\tdefault:\n+\t\t\t\tpanic(fmt.Sprintf(\"meta.Up in unexpected type: %#v\", meta.Up))\n+\t\t\t}\n+\t\t\tregions = append(regions, newRegion)\n+\t\t}\n+\t\tlog.Printf(\"Setting regions %+v\", regions)\n+\t\terr := d.Set(\"regions\", regions)\n+\t\tif err != nil {\n+\t\t\treturn fmt.Errorf(\"[DEBUG] Error setting regions for: %s, error: %#v\", r.Domain, err)\n+\t\t}\n+\t}\n+\treturn nil\n+}\n+\n+func answerToMap(a dns.Answer) map[string]interface{} {\n+\tm := make(map[string]interface{})\n+\tm[\"meta\"] = make([]map[string]interface{}, 0)\n+\tm[\"answer\"] = strings.Join(a.Rdata, \" \")\n+\tif a.RegionName != \"\" {\n+\t\tm[\"region\"] = a.RegionName\n+\t}\n+\tif a.Meta != nil {\n+\t\tmetas := &schema.Set{\n+\t\t\tF: metaToHash,\n+\t\t}\n+\t\tmeta := a.Meta\n+\t\t// TODO: set things up to use FeedPtr\n+\t\tswitch meta.Up.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase bool:\n+\t\t\tup := meta.Up.(bool)\n+\t\t\tif up {\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"up\",\n+\t\t\t\t\t\"value\": strconv.Itoa(btoi(up)),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.Up in unexpected type: %#v\", meta.Up))\n+\t\t}\n+\t\tswitch meta.Connections.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase int:\n+\t\t\tconnections := meta.Connections.(int)\n+\t\t\tif connections != 0 {\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"connections\",\n+\t\t\t\t\t\"value\": strconv.Itoa(connections),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.Connections in unexpected type: %#v\", meta.Connections))\n+\t\t}\n+\t\tswitch meta.Requests.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase int:\n+\t\t\trequests := meta.Requests.(int)\n+\t\t\tif requests != 0 {\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"requests\",\n+\t\t\t\t\t\"value\": strconv.Itoa(requests),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.Requests in unexpected type: %#v\", meta.Requests))\n+\t\t}\n+\t\tswitch meta.LoadAvg.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase float64:\n+\t\t\tloadavg := meta.LoadAvg.(float64)\n+\t\t\tif loadavg != 0 {\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"loadavg\",\n+\t\t\t\t\t\"value\": strconv.Itoa(int(loadavg)),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.LoadAvg in unexpected type: %#v\", meta.LoadAvg))\n+\t\t}\n+\t\tswitch meta.Pulsar.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase string:\n+\t\t\tpulsar := meta.Pulsar.(string)\n+\t\t\tif pulsar != \"\" {\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"pulsar\",\n+\t\t\t\t\t\"value\": pulsar,\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.Pulsar in unexpected type: %#v\", meta.Pulsar))\n+\t\t}\n+\t\tswitch meta.Latitude.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase float64:\n+\t\t\tlatitude := meta.Latitude.(float64)\n+\t\t\tif latitude != 0 {\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"latitude\",\n+\t\t\t\t\t\"value\": strconv.Itoa(int(latitude)),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.Latitude in unexpected type: %#v\", meta.Latitude))\n+\t\t}\n+\t\tswitch meta.Longitude.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase float64:\n+\t\t\tlongitude := meta.Longitude.(float64)\n+\t\t\tif longitude != 0 {\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"longitude\",\n+\t\t\t\t\t\"value\": strconv.Itoa(int(longitude)),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.Longitude in unexpected type: %#v\", meta.Longitude))\n+\t\t}\n+\t\tswitch meta.Georegion.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase []string:\n+\t\t\tgeoregion := meta.Georegion.([]string)\n+\t\t\tif len(georegion) != 0 {\n+\t\t\t\tsort.Strings(georegion)\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"georegion\",\n+\t\t\t\t\t\"value\": strings.Join(georegion, \",\"),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.Georegion in unexpected type: %#v\", meta.Georegion))\n+\t\t}\n+\t\tswitch meta.Country.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase []string:\n+\t\t\tcountry := meta.Country.([]string)\n+\t\t\tif len(country) != 0 {\n+\t\t\t\tsort.Strings(country)\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"country\",\n+\t\t\t\t\t\"value\": strings.Join(country, \",\"),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.Country in unexpected type: %#v\", meta.Country))\n+\t\t}\n+\t\tswitch meta.USState.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase []string:\n+\t\t\tusState := meta.USState.([]string)\n+\t\t\tif len(usState) != 0 {\n+\t\t\t\tsort.Strings(usState)\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"us_state\",\n+\t\t\t\t\t\"value\": strings.Join(usState, \",\"),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.USState in unexpected type: %#v\", meta.USState))\n+\t\t}\n+\t\tswitch meta.CAProvince.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase []string:\n+\t\t\tcaProvince := meta.CAProvince.([]string)\n+\t\t\tif len(caProvince) != 0 {\n+\t\t\t\tsort.Strings(caProvince)\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"ca_province\",\n+\t\t\t\t\t\"value\": strings.Join(caProvince, \",\"),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.CAProvince in unexpected type: %#v\", meta.CAProvince))\n+\t\t}\n+\t\tswitch meta.Note.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase string:\n+\t\t\tnote := meta.Note.(string)\n+\t\t\tif note != \"\" {\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"note\",\n+\t\t\t\t\t\"value\": note,\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.Note in unexpected type: %#v\", meta.Note))\n+\t\t}\n+\t\tswitch meta.IPPrefixes.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase []string:\n+\t\t\tipPrefixes := meta.IPPrefixes.([]string)\n+\t\t\tif len(ipPrefixes) != 0 {\n+\t\t\t\tsort.Strings(ipPrefixes)\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"ip_prefixes\",\n+\t\t\t\t\t\"value\": strings.Join(ipPrefixes, \",\"),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.IPPrefixes in unexpected type: %#v\", meta.IPPrefixes))\n+\t\t}\n+\t\tswitch meta.ASN.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase []string:\n+\t\t\tasn := meta.ASN.([]string)\n+\t\t\tif len(asn) != 0 {\n+\t\t\t\tsort.Strings(asn)\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"asn\",\n+\t\t\t\t\t\"value\": strings.Join(asn, \",\"),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.ASN in unexpected type: %#v\", meta.ASN))\n+\t\t}\n+\t\tswitch meta.Priority.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase int:\n+\t\t\tpriority := meta.Priority.(int)\n+\t\t\tif priority != 0 {\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"priority\",\n+\t\t\t\t\t\"value\": strconv.Itoa(priority),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.Priority in unexpected type: %#v\", meta.Priority))\n+\t\t}\n+\t\tswitch meta.Weight.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase float64:\n+\t\t\tweight := meta.Weight.(float64)\n+\t\t\tif weight != 0 {\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"weight\",\n+\t\t\t\t\t\"value\": strconv.Itoa(int(weight)),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.Weight in unexpected type: %#v\", meta.Weight))\n+\t\t}\n+\t\tswitch meta.LowWatermark.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase int:\n+\t\t\tlowWatermark := meta.LowWatermark.(int)\n+\t\t\tif lowWatermark != 0 {\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"low_watermark\",\n+\t\t\t\t\t\"value\": strconv.Itoa(lowWatermark),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.LowWatermark in unexpected type: %#v\", meta.LowWatermark))\n+\t\t}\n+\t\tswitch meta.HighWatermark.(type) {\n+\t\tcase nil:\n+\t\t\tbreak\n+\t\tcase int:\n+\t\t\thighWatermark := meta.HighWatermark.(int)\n+\t\t\tif highWatermark != 0 {\n+\t\t\t\tmetas.Add(map[string]interface{}{\n+\t\t\t\t\t\"field\": \"high_watermark\",\n+\t\t\t\t\t\"value\": strconv.Itoa(highWatermark),\n+\t\t\t\t})\n+\t\t\t}\n+\t\tdefault:\n+\t\t\tpanic(fmt.Sprintf(\"meta.HighWatermark in unexpected type: %#v\", meta.HighWatermark))\n+\t\t}\n+\t\tm[\"meta\"] = metas\n+\t}\n+\treturn m\n+}\n+\n+func btoi(b bool) int {\n+\tif b {\n+\t\treturn 1\n+\t}\n+\treturn 0\n+}\n+\n+func resourceDataToRecord(r *dns.Record, d *schema.ResourceData) error {\n+\tr.ID = d.Id()\n+\tif answers := d.Get(\"answers\").(*schema.Set); answers.Len() > 0 {\n+\t\tal := make([]*dns.Answer, answers.Len())\n+\t\tfor i, answerRaw := range answers.List() {\n+\t\t\tanswer := answerRaw.(map[string]interface{})\n+\t\t\tvar a *dns.Answer\n+\t\t\tv := answer[\"answer\"].(string)\n+\t\t\tswitch d.Get(\"type\") {\n+\t\t\tcase \"TXT\":\n+\t\t\t\ta = dns.NewTXTAnswer(v)\n+\t\t\tdefault:\n+\t\t\t\ta = dns.NewAnswer(strings.Split(v, \" \"))\n+\t\t\t}\n+\t\t\tif v, ok := answer[\"region\"]; ok {\n+\t\t\t\ta.RegionName = v.(string)\n+\t\t\t}\n+\t\t\tif metas := answer[\"meta\"].(*schema.Set); metas.Len() > 0 {\n+\t\t\t\tfor _, metaRaw := range metas.List() {\n+\t\t\t\t\tmeta := metaRaw.(map[string]interface{})\n+\t\t\t\t\tkey := meta[\"field\"].(string)\n+\t\t\t\t\tif value, ok := meta[\"feed\"]; ok && value.(string) != \"\" {\n+\t\t\t\t\t\tswitch key {\n+\t\t\t\t\t\tcase \"up\": // bool\n+\t\t\t\t\t\t\ta.Meta.Up = data.NewFeed(value.(string), data.Config{})",
    "line": 640,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2016-11-16T20:05:44Z",
    "isReviewComment": true,
    "pullRequestReviewId": 8897369,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium",
    "difficultyAssessedAt": "2025-02-27T02:56:43.680Z"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 30640,
    "prTitle": "Core: Fix extracting import path when it's not a core addon",
    "prAuthor": "yannbf",
    "prLink": "https://github.com/storybookjs/storybook/pull/30640",
    "commentAuthor": "greptile-apps[bot]",
    "commentBody": "logic: require.resolve() is called after modifying data.importPath but its result isn't used. Should verify the preview path exists before modifying data.importPath.\n\n```suggestion\n    // Verify the preview path exists before modifying importPath\n    if (!data.isCoreAddon) {\n      const previewPath = path.join(addon, 'preview');\n      require.resolve(previewPath);\n      data.importPath = `${addon}/preview`;\n    }\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/storybookjs/storybook/pull/30640#discussion_r1967127085",
    "filePath": "code/core/src/common/utils/get-addon-annotations.ts",
    "diffHunk": "@@ -34,7 +34,7 @@ export async function getAddonAnnotations(addon: string) {\n \n     // for backwards compatibility, if it's not a core addon we use /preview entrypoint\n     if (!data.isCoreAddon) {\n-      data.importPath = `@storybook/${addon}/preview`;\n+      data.importPath = `${addon}/preview`;\n     }\n \n     require.resolve(path.join(addon, 'preview'));",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2025-02-24T07:19:19Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2636152046,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 30312,
    "prTitle": "CLI: Add codemod for config factory and add command",
    "prAuthor": "yannbf",
    "prLink": "https://github.com/storybookjs/storybook/pull/30312",
    "commentAuthor": "greptile-apps[bot]",
    "commentBody": "logic: getStorybookData is called with previewConfigPath but the error handling for a missing preview config is insufficient. The code assumes previewConfigPath exists on line 172.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/30312#discussion_r1922309530",
    "filePath": "code/lib/cli-storybook/src/add.ts",
    "diffHunk": "@@ -91,29 +95,28 @@ export async function add(\n   const [addonName, inputVersion] = getVersionSpecifier(addon);\n \n   const packageManager = JsPackageManagerFactory.getPackageManager({ force: pkgMgr });\n-  const packageJson = await packageManager.retrievePackageJson();\n-  const { mainConfig, configDir: inferredConfigDir } = getStorybookInfo(\n-    packageJson,\n-    userSpecifiedConfigDir\n-  );\n-  const configDir = userSpecifiedConfigDir || inferredConfigDir || '.storybook';\n+  const { mainConfig, mainConfigPath, configDir, previewConfigPath, storybookVersion } =\n+    await getStorybookData({\n+      packageManager,\n+      configDir: userSpecifiedConfigDir,\n+    });",
    "line": 41,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2025-01-20T12:11:45Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2562229645,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 30274,
    "prTitle": "Next 8.5",
    "prAuthor": "valentinpalkovic",
    "prLink": "https://github.com/storybookjs/storybook/pull/30274",
    "commentAuthor": "greptile-apps[bot]",
    "commentBody": "logic: The regex `/[\\u0300-\\u036f]/g` only handles combining diacritical marks. Some Unicode characters like ñ or æ may not be properly normalized.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/30274#discussion_r1917934168",
    "filePath": "code/frameworks/angular/src/client/angular-beta/AbstractRenderer.ts",
    "diffHunk": "@@ -143,6 +145,27 @@ export abstract class AbstractRenderer {\n     return storyIdIsInvalidHtmlTagName ? `sb-${id.replace(invalidHtmlTag, '')}-component` : id;\n   }\n \n+  /**\n+   * Angular is unable to handle components that have selectors with accented attributes.\n+   *\n+   * Therefore, stories break when meta's title contains accents.\n+   * https://github.com/storybookjs/storybook/issues/29132\n+   *\n+   * This method filters accents from a given raw id. For example, this method converts\n+   * 'Example/Button with an \"é\" accent' into 'Example/Button with an \"e\" accent'.\n+   *\n+   * @memberof AbstractRenderer\n+   * @protected\n+   */\n+  protected generateStoryUIdFromRawStoryUid(rawStoryUid: string | null) {\n+    if (rawStoryUid === null) {\n+      return rawStoryUid;\n+    }\n+\n+    const accentCharacters = /[\\u0300-\\u036f]/g;\n+    return rawStoryUid.normalize('NFD').replace(accentCharacters, '');",
    "line": 33,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2025-01-16T08:20:24Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2555088034,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 30266,
    "prTitle": "Codemod: Use csf-tools in csf factory codemod",
    "prAuthor": "yannbf",
    "prLink": "https://github.com/storybookjs/storybook/pull/30266",
    "commentAuthor": "greptile-apps[bot]",
    "commentBody": "logic: prettier.resolveConfig() is awaited but the result may be undefined, which could cause formatting issues",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/30266#discussion_r1916613524",
    "filePath": "code/lib/codemod/src/transforms/csf-3-to-4.ts",
    "diffHunk": "@@ -171,9 +151,71 @@ export default async function transform(info: FileInfo) {\n     programNode.body.unshift(configImport);\n   }\n \n-  // Generate the transformed code\n-  const { code } = babel.transformFromAstSync(fileNode, info.source, {\n-    parserOpts: { sourceType: 'module' },\n+  function isSpecifierUsed(name: string) {\n+    let isUsed = false;\n+\n+    // Traverse the AST and check for usage of the name\n+    traverse(programNode, {\n+      Identifier(path) {\n+        if (path.node.name === name) {\n+          isUsed = true;\n+          // Stop traversal early if we've found a match\n+          path.stop();\n+        }\n+      },\n+    });\n+\n+    return isUsed;\n+  }\n+\n+  // Remove type imports – now inferred – from @storybook/* packages\n+  const disallowlist = [\n+    'Story',\n+    'StoryFn',\n+    'StoryObj',\n+    'Meta',\n+    'MetaObj',\n+    'ComponentStory',\n+    'ComponentMeta',\n+  ];\n+\n+  programNode.body = programNode.body.filter((node) => {\n+    if (t.isImportDeclaration(node)) {\n+      const { source, specifiers } = node;\n+\n+      if (source.value.startsWith('@storybook/')) {\n+        const allowedSpecifiers = specifiers.filter((specifier) => {\n+          if (t.isImportSpecifier(specifier) && t.isIdentifier(specifier.imported)) {\n+            return !disallowlist.includes(specifier.imported.name);\n+          }\n+          // Retain non-specifier imports (e.g., namespace imports)\n+          return true;\n+        });\n+\n+        // Remove the entire import if no specifiers are left\n+        if (allowedSpecifiers.length > 0) {\n+          node.specifiers = allowedSpecifiers;\n+          return true;\n+        }\n+\n+        // Remove the import if no specifiers remain\n+        return false;\n+      }\n+    }\n+\n+    // Retain all other nodes\n+    return true;\n   });\n-  return code;\n+\n+  let output = printCsf(csf).code;\n+\n+  try {\n+    output = await prettier.format(output, {\n+      ...(await prettier.resolveConfig(info.path)),\n+      filepath: info.path,\n+    });\n+  } catch (e) {",
    "line": 313,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2025-01-15T13:00:50Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2552686249,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 30100,
    "prTitle": "Addon Onboarding: Use @neoconfetti/react as alternative",
    "prAuthor": "yannbf",
    "prLink": "https://github.com/storybookjs/storybook/pull/30100",
    "commentAuthor": "greptile-apps[bot]",
    "commentBody": "logic: using window.innerHeight/Width directly can cause issues if window is undefined (SSR) or resized",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/30100#discussion_r1890070320",
    "filePath": "code/addons/onboarding/src/components/Confetti/Confetti.tsx",
    "diffHunk": "@@ -1,46 +1,34 @@\n-import React, { type ComponentProps, useEffect } from 'react';\n-import { useState } from 'react';\n+import React, { type ComponentProps } from 'react';\n \n import { styled } from 'storybook/internal/theming';\n \n-import ReactConfetti from 'react-confetti-boom';\n+import { Confetti as ReactConfetti } from '@neoconfetti/react';\n \n const Wrapper = styled.div({\n   zIndex: 9999,\n   position: 'fixed',\n   top: 0,\n-  left: 0,\n-  bottom: 0,\n-  right: 0,\n+  left: '50%',\n+  width: '50%',\n+  height: '100%',\n });\n \n-export function Confetti({\n+export const Confetti = React.memo(function Confetti({\n   timeToFade = 5000,\n   colors = ['#CA90FF', '#FC521F', '#66BF3C', '#FF4785', '#FFAE00', '#1EA7FD'],\n   ...confettiProps\n }: ComponentProps<typeof ReactConfetti> & { timeToFade?: number }) {\n-  const [particleCount, setParticleCount] = useState(42);\n-\n-  useEffect(() => {\n-    const timeout = setTimeout(() => {\n-      setParticleCount(0);\n-    }, timeToFade);\n-\n-    return () => {\n-      clearTimeout(timeout);\n-    };\n-  }, [timeToFade]);\n-\n   return (\n     <Wrapper>\n       <ReactConfetti\n-        mode=\"fall\"\n         colors={colors}\n-        shapeSize={14}\n-        particleCount={particleCount}\n-        fadeOutHeight={10}\n+        particleCount={200}\n+        duration={5000}\n+        stageHeight={window.innerHeight}\n+        stageWidth={window.innerWidth}",
    "line": 51,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-12-18T11:20:46Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2511543883,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 30086,
    "prTitle": "UI: Keep failing stories in the sidebar, disregarding filters",
    "prAuthor": "JReinhold",
    "prLink": "https://github.com/storybookjs/storybook/pull/30086",
    "commentAuthor": "greptile-apps[bot]",
    "commentBody": "logic: Test is asserting both 'story-1' and '1' keys exist, but this seems incorrect - should only be checking for one ID format based on the transformation logic",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/30086#discussion_r1888443921",
    "filePath": "code/core/src/manager-api/lib/stories.test.ts",
    "diffHunk": "@@ -216,3 +218,60 @@ describe('transformStoryIndexV4toV5', () => {\n     `);\n   });\n });\n+\n+describe('transformStoryIndexToStoriesHash', () => {\n+  it('does not apply filters to failing stories', () => {\n+    // Arrange - set up an index with two stories, one of which has a failing status\n+    const indexV5: API_PreparedStoryIndex = {\n+      v: 5,\n+      entries: {\n+        '1': {\n+          id: '1',\n+          type: 'story',\n+          title: 'Story 1',\n+          name: 'Story 1',\n+          importPath: './path/to/story-1.ts',\n+          parameters: {},\n+          tags: [],\n+        },\n+        '2': {\n+          id: '2',\n+          type: 'story',\n+          title: 'Story 2',\n+          name: 'Story 2',\n+          importPath: './path/to/story-2.ts',\n+          parameters: {},\n+          tags: [],\n+        },\n+      },\n+    };\n+\n+    const filters: State['filters'] = {\n+      someFilter: () => false,\n+    };\n+\n+    const status: State['status'] = {\n+      '1': { someStatus: { status: 'error', title: 'broken', description: 'very bad' } },\n+      '2': { someStatus: { status: 'success', title: 'perfect', description: 'nice' } },\n+    };\n+\n+    const options = {\n+      provider: {\n+        getConfig: () => ({ sidebar: {} }),\n+      } as any,\n+      docsOptions: { docsMode: false },\n+      filters,\n+      status,\n+    };\n+\n+    // Act - transform the index to hashes\n+    const result = transformStoryIndexToStoriesHash(indexV5, options);\n+\n+    // Assert - the failing story is still present in the result, even though the filters remove all stories\n+    expect(Object.keys(result)).toHaveLength(2);\n+    expect(result['story-1']).toBeTruthy();\n+    expect(result['1']).toBeTruthy();",
    "line": 67,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-12-17T12:35:01Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2508759397,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 30060,
    "prTitle": "Automigration: Improve setup file transformation and version range handling for a11y migration",
    "prAuthor": "valentinpalkovic",
    "prLink": "https://github.com/storybookjs/storybook/pull/30060",
    "commentAuthor": "greptile-apps[bot]",
    "commentBody": "logic: version range ['<8.5.0', '>=8.5.0'] covers all versions and is equivalent to '*'. Consider if this is intentional or if there should be a minimum version requirement.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/30060#discussion_r1883980998",
    "filePath": "code/lib/cli-storybook/src/automigrate/fixes/addon-a11y-addon-test.ts",
    "diffHunk": "@@ -22,8 +22,7 @@ interface AddonA11yAddonTestOptions {\n  */\n export const addonA11yAddonTest: Fix<AddonA11yAddonTestOptions> = {\n   id: 'addonA11yAddonTest',\n-  // TODO: Change to the correct version after testing\n-  versionRange: ['<8.5.0', '*'],\n+  versionRange: ['<8.5.0', '>=8.5.0'],",
    "line": 6,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-12-13T14:01:22Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2502366537,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 30018,
    "prTitle": "Build: Improve task command and error message",
    "prAuthor": "yannbf",
    "prLink": "https://github.com/storybookjs/storybook/pull/30018",
    "commentAuthor": "greptile-apps[bot]",
    "commentBody": "logic: The ready function now takes options but doesn't validate that selectedTask exists. This could cause the function to return false unexpectedly if selectedTask is undefined.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/30018#discussion_r1879742546",
    "filePath": "scripts/tasks/sandbox.ts",
    "diffHunk": "@@ -22,8 +22,24 @@ export const sandbox: Task = {\n \n     return ['run-registry'];\n   },\n-  async ready({ sandboxDir }) {\n-    return pathExists(sandboxDir);\n+  async ready({ sandboxDir }, { task: selectedTask }) {",
    "line": 15,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-12-11T09:55:40Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2494974053,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 29756,
    "prTitle": "RNW-Vite: Add built-in Flow support",
    "prAuthor": "dannyhw",
    "prLink": "https://github.com/storybookjs/storybook/pull/29756",
    "commentAuthor": "greptile-apps[bot]",
    "commentBody": "logic: Regular expression should be anchored with ^ and $ to prevent partial matches in file paths",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/29756#discussion_r1864349748",
    "filePath": "code/frameworks/react-native-web-vite/src/preset.ts",
    "diffHunk": "@@ -77,9 +84,16 @@ export const viteFinal: StorybookConfig['viteFinal'] = async (config, options) =\n       ...pluginReactOptions,\n     })\n   );\n+\n   plugins.push(reactNativeWeb());\n \n-  return reactConfig;\n+  return mergeConfig(reactConfig, {\n+    optimizeDeps: {\n+      esbuildOptions: {\n+        plugins: [esbuildFlowPlugin(new RegExp(/\\.(flow|jsx?)$/), (_path: string) => 'jsx')],",
    "line": 42,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-11-30T16:59:27Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2470942563,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 29584,
    "prTitle": "Core: Implement afterEach",
    "prAuthor": "kasperpeulen",
    "prLink": "https://github.com/storybookjs/storybook/pull/29584",
    "commentAuthor": "greptile-apps[bot]",
    "commentBody": "logic: afterEach should run even if playFunction throws an error. Consider wrapping the play function in try/finally to ensure afterEach always executes.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/29584#discussion_r1836718635",
    "filePath": "code/core/src/preview-api/modules/store/csf/portable-stories.ts",
    "diffHunk": "@@ -408,4 +408,6 @@ async function runStory<TRenderer extends Renderer>(\n     }\n     await playFunction(context);\n   }\n+\n+  await story.applyAfterEach(context);",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-11-11T14:01:21Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2427360737,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 24837,
    "prTitle": "FastBuild: Improve config loading & naming",
    "prAuthor": "ndelangen",
    "prLink": "https://github.com/storybookjs/storybook/pull/24837",
    "commentAuthor": "IanVS",
    "commentBody": "@ndelangen I think the logic here is backwards.  Instead of filtering out disabled addons, it _only allows_ disabled addons, since there is a double bang.  I found that my storybook started breaking in alpha.6 unless I provided an explicit `disabledAddons: []`.  Even just `disabledAddons: ['foo']` broke it, which I think is because it causes this code to execute.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/24837#discussion_r1399669905",
    "filePath": "code/lib/core-common/src/presets.ts",
    "diffHunk": "@@ -255,15 +255,13 @@ export async function loadPreset(\n \n       if (\n         storybookOptions.isCritical !== true &&\n-        storybookOptions.build?.test?.removeNonFastAddons\n+        (storybookOptions.build?.test?.disabledAddons?.length || 0) > 0\n       ) {\n         filter = (i: PresetConfig) => {\n           // @ts-expect-error (Converted from ts-ignore)\n           const name = i.name ? i.name : i;\n \n-          return (\n-            !name.includes('@storybook/addon-docs') && !name.includes('@storybook/addon-coverage')\n-          );\n+          return !!storybookOptions.build?.test?.disabledAddons?.find((n) => name.includes(n));",
    "line": 14,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-11-20T19:43:41Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1740573169,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 24768,
    "prTitle": "Angular: Include object configured styles",
    "prAuthor": "valentinpalkovic",
    "prLink": "https://github.com/storybookjs/storybook/pull/24768",
    "commentAuthor": "andriy-statsenko-lightit",
    "commentBody": "@valentinpalkovic hi. I think there is a slight mistake here since first you use `map` to take the string, but the `filter` will always have a string. Now objects with `\"inject\": false` will not be included in the build as separate files, now they will always be in the `main.css` file",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/24768#discussion_r1598282049",
    "filePath": "code/frameworks/angular/src/server/angular-cli-webpack.js",
    "diffHunk": "@@ -66,6 +66,9 @@ exports.getWebpackConfig = async (baseConfig, { builderOptions, builderContext }\n \n       // Options provided by user\n       ...builderOptions,\n+      styles: builderOptions.styles\n+        ?.map((style) => (typeof style === 'string' ? style : style.input))",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-05-13T10:59:53Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2052365664,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 21852,
    "prTitle": "Remove deprecated flags and properties",
    "prAuthor": "valentinpalkovic",
    "prLink": "https://github.com/storybookjs/storybook/pull/21852",
    "commentAuthor": "vyivel",
    "commentBody": "This branch never gets executed.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/21852#discussion_r1161922014",
    "filePath": "code/addons/toolbars/src/components/ToolbarMenuList.tsx",
    "diffHunk": "@@ -32,12 +32,12 @@ export const ToolbarMenuList: FC<ToolbarMenuListProps> = withKeyboardCycle(\n     }\n \n     // Deprecation support for old \"name of global arg used as title\"\n-    if (showName && !title) {\n+    if (!title) {\n       title = name;\n       deprecate(\n         '`showName` is deprecated as `name` will stop having dual purposes in the future. Please specify a `title` in `globalTypes` instead.'\n       );\n-    } else if (!showName && !icon && !title) {\n+    } else if (!icon && !title) {",
    "line": 20,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-04-10T17:31:05Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1377868819,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 21653,
    "prTitle": "Blocks: fix Canvas block support of deprecated props",
    "prAuthor": "sheriffMoose",
    "prLink": "https://github.com/storybookjs/storybook/pull/21653",
    "commentAuthor": "JReinhold",
    "commentBody": "I don't think it's safe to mutate the props here, you should store it as a new variable instead.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/21653#discussion_r1150582015",
    "filePath": "code/ui/blocks/src/blocks/Canvas.tsx",
    "diffHunk": "@@ -99,10 +99,26 @@ const useDeprecatedPreviewProps = (\n     children,\n     layout: layoutProp,\n     ...props\n-  }: DeprecatedCanvasProps & { of?: ModuleExport; layout?: Layout },\n+  }: DeprecatedCanvasProps & CanvasProps,\n   docsContext: DocsContextProps<Renderer>,\n   sourceContext: SourceContextProps\n ) => {\n+  /* eslint-disable no-param-reassign */\n+  mdxSource = mdxSource || props?.source?.code;\n+  withSource =\n+    withSource ||\n+    (() => {\n+      switch (props.sourceState) {\n+        case 'none':\n+          return SourceState.NONE;\n+        case 'shown':\n+          return SourceState.OPEN;\n+        default:\n+          return SourceState.CLOSED;\n+      }\n+    })();\n+  /* eslint-enable no-param-reassign */",
    "line": 23,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-03-28T13:06:19Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1361034084,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 21049,
    "prTitle": "CLI: Account for pnp when creating main.js in `storybook init`",
    "prAuthor": "yannbf",
    "prLink": "https://github.com/storybookjs/storybook/pull/21049",
    "commentAuthor": "ndelangen",
    "commentBody": "This causes a runtime error still, because the import for path is still removed",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/21049#discussion_r1103001951",
    "filePath": "code/lib/cli/src/generators/configure.test.ts",
    "diffHunk": "@@ -70,6 +70,46 @@ describe('configureMain', () => {\n       export default config;\"\n     `);\n   });\n+\n+  test('should handle resolved paths in pnp', async () => {\n+    await configureMain({\n+      language: SupportedLanguage.JAVASCRIPT,\n+      addons: [\n+        \"%%path.dirname(require.resolve(path.join('@storybook/addon-links', 'package.json')))%%\",\n+        \"%%path.dirname(require.resolve(path.join('@storybook/addon-essentials', 'package.json')))%%\",\n+        \"%%path.dirname(require.resolve(path.join('@storybook/preset-create-react-app', 'package.json')))%%\",\n+        \"%%path.dirname(require.resolve(path.join('@storybook/addon-interactions', 'package.json')))%%\",\n+      ],\n+      storybookConfigFolder: '.storybook',\n+      framework: {\n+        name: \"%%path.dirname(require.resolve(path.join('@storybook/react-webpack5', 'package.json')))%%\",\n+      },\n+    });\n+\n+    const { calls } = (fse.writeFile as unknown as jest.Mock).mock;\n+    const [mainConfigPath, mainConfigContent] = calls[0];\n+\n+    expect(mainConfigPath).toEqual('./.storybook/main.js');\n+    expect(mainConfigContent).toMatchInlineSnapshot(`\n+      \"/** @type { import('@storybook/react-webpack5').StorybookConfig } */\n+      const config = {\n+        \\\\\"stories\\\\\": [\n+          \\\\\"../stories/**/*.mdx\\\\\",\n+          \\\\\"../stories/**/*.stories.@(js|jsx|ts|tsx)\\\\\"\n+        ],\n+        \\\\\"addons\\\\\": [\n+          path.dirname(require.resolve(path.join('@storybook/addon-links', 'package.json'))),\n+          path.dirname(require.resolve(path.join('@storybook/addon-essentials', 'package.json'))),\n+          path.dirname(require.resolve(path.join('@storybook/preset-create-react-app', 'package.json'))),\n+          path.dirname(require.resolve(path.join('@storybook/addon-interactions', 'package.json')))",
    "line": 35,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-02-10T16:54:45Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1293585392,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 18456,
    "prTitle": "fix: addons-background not updating default value",
    "prAuthor": "bytrangle",
    "prLink": "https://github.com/storybookjs/storybook/pull/18456",
    "commentAuthor": "ndelangen",
    "commentBody": "This isn't right, we should not be mutating globals",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/18456#discussion_r895841281",
    "filePath": "addons/backgrounds/src/containers/BackgroundSelector.tsx",
    "diffHunk": "@@ -78,7 +78,14 @@ export const BackgroundSelector: FunctionComponent = memo(() => {\n   );\n \n   const [globals, updateGlobals] = useGlobals();\n-\n+  if (!globals[BACKGROUNDS_PARAM_KEY] && backgroundsConfig.values.length) {\n+    const defaultSetting = backgroundsConfig.values.find(\n+      (value) => value.name === backgroundsConfig.default\n+    );\n+    globals[BACKGROUNDS_PARAM_KEY] = {\n+      value: defaultSetting.value,\n+    };",
    "line": 11,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-06-13T15:12:24Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1004516112,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 15412,
    "prTitle": "other: accordion component",
    "prAuthor": "IgorSzyporyn",
    "prLink": "https://github.com/storybookjs/storybook/pull/15412",
    "commentAuthor": "ndelangen",
    "commentBody": "You're creating a new function every time the `open` prop changes",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/15412#discussion_r662812189",
    "filePath": "lib/components/src/Accordion/Accordion.tsx",
    "diffHunk": "@@ -0,0 +1,207 @@\n+import { styled } from '@storybook/theming';\n+import React, { Children, useCallback, useEffect, useRef, useState, FC } from 'react';\n+import type { AddToMapFn, OpenMap } from './AccordionContext';\n+import { AccordionContext } from './AccordionContext';\n+\n+type AccordionMap = Record<string, { index: number; id: string }>;\n+\n+interface StateChange {\n+  id: string;\n+  index: number;\n+}\n+\n+export type AccordionProps = {\n+  /** Set to true to allow for more than one AccordionItem open at the time */\n+  allowMultipleOpen?: boolean;\n+  /** Ability to control which panel(s) are open or closed externally - or use to set default opens */\n+  open?: number | number[];\n+  /** Set to true to add theme border around the Accordion */\n+  bordered?: boolean;\n+  /** Set to true to add rounded borders from theme to Accordion */\n+  rounded?: boolean;\n+  /**\n+   * Set to true to add theme borders between AccordionItem's\n+   * Note: can be overridden on AccordionItem\n+   */\n+  lined?: boolean;\n+  /**\n+   * Set to true to indent AccordionBody content left to match the AccordionHeader text\n+   * Note: can be overridden on AccordionItem\n+   */\n+  indentBody?: boolean;\n+  /**\n+   * Set to true to apply narrow paddings and smaller text in all AccordionItem's\n+   * Note: can be overridden on AccordionItem\n+   */\n+  narrow?: boolean;\n+  /**\n+   * Set to true to prevent toggle between open and close for all AccordionItem's\n+   * Note: can be overridden on AccordionItem\n+   */\n+  preventToggle?: boolean;\n+  /** Courtesy callback prop for when a new accordion opens */\n+  onOpen?: (change: StateChange) => void;\n+  /** Courtesy callback prop for when an accordion closes */\n+  onClose?: (change: StateChange) => void;\n+} & React.HTMLAttributes<HTMLUListElement>;\n+\n+/**\n+ *\n+ * Controlling wrapper component that will control the open/close functionality to\n+ * child ```<AccordionItem />```'s and style the other support components\n+ * ```<AccordionHeader />``` and ```<AccordionBody />```\n+ *\n+ * Although each component can work independently and be controlled from the outside\n+ * via an **open** prop, it is not recommended to use ```<AccordionItem />```,\n+ *  ```<AccordionHeader />``` and ```<AccordionBody />``` without this controller\n+ *\n+ * If no ```<AccordionBody />``` is inside an ```<AccordionItem />``` the open/close\n+ * functionality will be removed by default, as well as the icon and pointer cursor.\n+ */\n+export const Accordion: FC<AccordionProps> = ({\n+  allowMultipleOpen,\n+  children,\n+  open,\n+  rounded = false,\n+  bordered = false,\n+  narrow, // To be carried to AccordionItem children via context\n+  lined, // To be carried to AccordionItem children via context\n+  indentBody, // To be carried to AccordionItem children via context\n+  preventToggle, // To be carried to AccordionItem children via context\n+  onOpen,\n+  onClose,\n+  ...rest\n+}) => {\n+  const [openState, setOpenState] = useState<OpenMap>({});\n+  const openStateMap = useRef<OpenMap>({});\n+  const accordionMap = useRef<AccordionMap>({});\n+  const accordionMapIndex = useRef(0);\n+\n+  const addToMap: AddToMapFn = useCallback(\n+    (id) => {\n+      const index = accordionMapIndex.current + 1;\n+      accordionMap.current = { ...accordionMap.current, [id]: { id, index } };\n+      accordionMapIndex.current = index;\n+\n+      if (typeof open === 'number') {\n+        openStateMap.current = { ...openStateMap.current, [id]: open === index };\n+      } else if (Array.isArray(open)) {\n+        const isExpanded = open.includes(index);\n+        openStateMap.current = { ...openStateMap.current, [id]: isExpanded };\n+      } else {\n+        openStateMap.current = { ...openStateMap.current, [id]: false };\n+      }\n+    },\n+    [accordionMap, openStateMap, open]",
    "line": 95,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 118537964,
        "node_id": "MDMyOlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudFJlYWN0aW9uMTE4NTM3OTY0",
        "user": {
          "login": "IgorSzyporyn",
          "id": 6172338,
          "node_id": "MDQ6VXNlcjYxNzIzMzg=",
          "avatar_url": "https://avatars.githubusercontent.com/u/6172338?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/IgorSzyporyn",
          "html_url": "https://github.com/IgorSzyporyn",
          "followers_url": "https://api.github.com/users/IgorSzyporyn/followers",
          "following_url": "https://api.github.com/users/IgorSzyporyn/following{/other_user}",
          "gists_url": "https://api.github.com/users/IgorSzyporyn/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/IgorSzyporyn/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/IgorSzyporyn/subscriptions",
          "organizations_url": "https://api.github.com/users/IgorSzyporyn/orgs",
          "repos_url": "https://api.github.com/users/IgorSzyporyn/repos",
          "events_url": "https://api.github.com/users/IgorSzyporyn/events{/privacy}",
          "received_events_url": "https://api.github.com/users/IgorSzyporyn/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2021-07-02T11:07:13Z"
      }
    ],
    "timestamp": "2021-07-02T07:50:30Z",
    "isReviewComment": true,
    "pullRequestReviewId": 697918110,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 14822,
    "prTitle": "Added if on viewMode to avoid incorrect Settings Router load",
    "prAuthor": "dChancellor",
    "prLink": "https://github.com/storybookjs/storybook/pull/14822",
    "commentAuthor": "ndelangen",
    "commentBody": "viewMode changes over time, but this will never re-evaluate because of useMemo without dependencies..\r\n\r\nThis will mean the setting page will never, ever render anything...",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/14822#discussion_r627332460",
    "filePath": "lib/ui/src/app.tsx",
    "diffHunk": "@@ -47,11 +47,16 @@ const App = React.memo<AppProps>(\n           {\n             key: 'settings',\n             render: () => <SettingsPages />,\n-            route: (({ children }) => (\n-              <Route path=\"/settings\" startsWith>\n-                {children}\n-              </Route>\n-            )) as FunctionComponent,\n+            route: (({ children }) => {\n+              if (viewMode === 'settings') {",
    "line": 10,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-05-06T11:24:19Z",
    "isReviewComment": true,
    "pullRequestReviewId": 653299655,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 12403,
    "prTitle": "Add preact/compat aliases by default",
    "prAuthor": "developit",
    "prLink": "https://github.com/storybookjs/storybook/pull/12403",
    "commentAuthor": "merceyz",
    "commentBody": "```suggestion\r\n        react: path.dirname(require.resolve('preact/compat/package.json')),\r\n        'react-dom': path.dirname(require.resolve('preact/compat/package.json')),\r\n```\r\nMy bad, needs to get the entry path otherwise node will load from `main` instead of letting webpack load from `module`",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/storybookjs/storybook/pull/12403#discussion_r503573637",
    "filePath": "app/preact/src/server/framework-preset-preact.ts",
    "diffHunk": "@@ -9,3 +11,20 @@ export function babelDefault(config: TransformOptions) {\n     ],\n   };\n }\n+\n+export function webpackFinal(config: Configuration) {\n+  return {\n+    ...config,\n+    resolve: {\n+      ...config.resolve,\n+      // Prefer top-level aliases\n+      modules: [path.resolve('node_modules'), ...config.resolve.modules],\n+      // Alias react imports to \"preact/compat\":\n+      alias: {\n+        ...config.resolve.alias,\n+        react: require.resolve('preact/compat'),\n+        'react-dom': require.resolve('preact/compat'),",
    "line": 23,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-10-12T22:53:23Z",
    "isReviewComment": true,
    "pullRequestReviewId": 506963593,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 6553,
    "prTitle": "Tech/move graphql addon to tab",
    "prAuthor": "ndelangen",
    "prLink": "https://github.com/storybookjs/storybook/pull/6553",
    "commentAuthor": "travi",
    "commentBody": "having this set to true is causing me some issues with the latest `@next` release because true does not match the expected shape of `process`, which is normally an object. \r\n\r\nin the case i'm running into, the library checks that `process` exists and then tries to search for the `env` property using the `in` operator, but fails since `in` cannot be used on a boolean. \r\n\r\nif this really needs to be included in the default config, could it at least be set to an object to match the contract of what `process` would normally be?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/6553#discussion_r282690991",
    "filePath": "lib/core/src/server/manager/manager-webpack.config.js",
    "diffHunk": "@@ -58,9 +58,44 @@ export default ({ configDir, configType, entries, dll, outputDir, cache, babelOp\n       new webpack.DefinePlugin({ 'process.env': stringified }),\n       new CaseSensitivePathsPlugin(),\n       new Dotenv({ silent: true }),\n+      // graphql sources check process variable\n+      new DefinePlugin({\n+        process: JSON.stringify(true),",
    "line": 13,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2019-05-09T22:34:07Z",
    "isReviewComment": true,
    "pullRequestReviewId": 235855916,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "storybookjs/storybook",
    "prNumber": 5007,
    "prTitle": "Make to work on create react app v2 storybook v4.1.1",
    "prAuthor": "pavinthan",
    "prLink": "https://github.com/storybookjs/storybook/pull/5007",
    "commentAuthor": "igor-dv",
    "commentBody": "at this point `craWebpackConfigFile` is not a real path and fs can't really find it. I think that's why all the tests are failing.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/storybookjs/storybook/pull/5007#discussion_r243105854",
    "filePath": "app/react/src/server/cra-config.js",
    "diffHunk": "@@ -83,8 +83,13 @@ export function getCraWebpackConfig(mode) {\n \n   const craWebpackConfig =\n     mode === 'production' ? 'config/webpack.config.prod' : 'config/webpack.config.dev';\n+  \n+  const craWebpackConfigFile = path.join(pathToReactScripts, craWebpackConfig);\n \n-  let pathToWebpackConfig = require.resolve(path.join(pathToReactScripts, craWebpackConfig));\n+  let pathToWebpackConfig;\n+  if (fs.existsSync(craWebpackConfigFile)) {",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2018-12-19T22:58:24Z",
    "isReviewComment": true,
    "pullRequestReviewId": 186787107,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 98691,
    "prTitle": "BackendSrv: Support streaming chunked responses",
    "prAuthor": "ryantxu",
    "prLink": "https://github.com/grafana/grafana/pull/98691",
    "commentAuthor": "Clarity-89",
    "commentBody": "```suggestion\r\n          process()\r\n            .then(() => {\r\n              console.log(requestId, 'complete');\r\n              observer.complete();\r\n            }) // runs in background\r\n            .catch((e) => {\r\n              console.log(requestId, 'catch', e);\r\n              observer.error(e);\r\n            }); // from abort\r\n        },\r\n```\r\n\r\nI think we need to switch the order of `then/catch`, otherwise the errors in `then` won't be caught. Also a good idea to forward the error to observer so it's notified when `reader.read()` fails. ",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/grafana/grafana/pull/98691#discussion_r1916004939",
    "filePath": "public/app/core/services/backend_srv.ts",
    "diffHunk": "@@ -142,6 +142,83 @@ export class BackendSrv implements BackendService {\n     });\n   }\n \n+  chunkRequestId = 1;\n+\n+  chunked(options: BackendSrvRequest): Observable<FetchResponse<Uint8Array | undefined>> {\n+    const requestId = options.requestId ?? `chunked-${this.chunkRequestId++}`;\n+    const controller = new AbortController();\n+    const url = parseUrlFromOptions(options);\n+    const init = parseInitFromOptions({\n+      ...options,\n+      requestId,\n+      abortSignal: controller.signal,\n+    });\n+\n+    return new Observable((observer) => {\n+      let done = false;\n+      // Calling fromFetch explicitly avoids the request queue\n+      const sub = this.dependencies.fromFetch(url, init).subscribe({\n+        next: (response) => {\n+          const rsp = {\n+            status: response.status,\n+            statusText: response.statusText,\n+            ok: response.ok,\n+            headers: response.headers,\n+            url: response.url,\n+            type: response.type,\n+            redirected: response.redirected,\n+            config: options,\n+            traceId: response.headers.get(GRAFANA_TRACEID_HEADER) ?? undefined,\n+            data: undefined,\n+          };\n+\n+          if (!response.body) {\n+            observer.next(rsp);\n+            observer.complete();\n+            return;\n+          }\n+\n+          const reader = response.body.getReader();\n+          async function process() {\n+            while (reader && !done) {\n+              if (controller.signal.aborted) {\n+                reader.cancel(controller.signal.reason);\n+                console.log(requestId, 'signal.aborted');\n+                return;\n+              }\n+              const chunk = await reader.read();\n+              observer.next({\n+                ...rsp,\n+                data: chunk.value,\n+              });\n+              if (chunk.done) {\n+                done = true;\n+                console.log(requestId, 'done');\n+              }\n+            }\n+          }\n+          process()\n+            .catch((e) => {\n+              console.log(requestId, 'catch', e);\n+            }) // from abort\n+            .then(() => {\n+              console.log(requestId, 'complete');\n+              observer.complete();\n+            }); // runs in background\n+        },",
    "line": 67,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2025-01-15T06:27:56Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2551656088,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 78719,
    "prTitle": "DashboardScene: Enable scene tracking information",
    "prAuthor": "dprokop",
    "prLink": "https://github.com/grafana/grafana/pull/78719",
    "commentAuthor": "ivanortegaalba",
    "commentBody": "If we set this API, it means if two independent objects call this callback it will unexpectedly remove the other component metadata.\r\n\r\nWhy don't we just delegate the responsibility of removing the meta extensions to the service consumer?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/78719#discussion_r1407614769",
    "filePath": "public/app/core/services/echo/Echo.ts",
    "diffHunk": "@@ -66,8 +67,16 @@ export class Echo implements EchoSrv {\n     });\n   };\n \n+  setMetaExtensions = (extensions: Record<string, unknown>) => {\n+    this._metaExtensions = extensions;\n+    return () => {\n+      this._metaExtensions = {};\n+    };",
    "line": 27,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-11-28T11:27:10Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1752658999,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 78636,
    "prTitle": "Dashboard: Change cursor sync (graphTooltip) to shared cursor",
    "prAuthor": "torkelo",
    "prLink": "https://github.com/grafana/grafana/pull/78636",
    "commentAuthor": "dprokop",
    "commentBody": "@torkelo I think this is the problem why once created dashboards default to crosshair. this will always yield Crosshair for default saved graphTooltip = 0.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/78636#discussion_r1413524729",
    "filePath": "public/app/features/dashboard/state/DashboardModel.ts",
    "diffHunk": "@@ -144,7 +143,7 @@ export class DashboardModel implements TimeModel {\n     this.timezone = data.timezone ?? '';\n     this.weekStart = data.weekStart ?? '';\n     this.editable = data.editable !== false;\n-    this.graphTooltip = data.graphTooltip || 0;\n+    this.graphTooltip = data.graphTooltip || DashboardCursorSync.Crosshair;",
    "line": 22,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-12-04T08:30:38Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1761835621,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 77957,
    "prTitle": "K8s: Refactor metrics to share k8s registry",
    "prAuthor": "toddtreece",
    "prLink": "https://github.com/grafana/grafana/pull/77957",
    "commentAuthor": "torkelo",
    "commentBody": "@toddtreece this moves the setBuildInfo to after Cfg is created (setting.NewCfgFromArgs) leading to empty Cfg.BuildVersion , leading to wrong CDN url (and no assets loaded) ",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/77957#discussion_r1415604811",
    "filePath": "pkg/cmd/grafana-server/commands/cli.go",
    "diffHunk": "@@ -111,6 +109,9 @@ func RunServer(opts ServerOptions) error {\n \t\treturn err\n \t}\n \n+\tsetBuildInfo(metrics.ProvideRegisterer(cfg), opts)\n+\tcheckPrivileges()\n+",
    "line": 24,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-12-05T13:23:06Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1765071227,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 76914,
    "prTitle": "Fix: Accessibility labels for Inline Switch",
    "prAuthor": "milenagd",
    "prLink": "https://github.com/grafana/grafana/pull/76914",
    "commentAuthor": "Clarity-89",
    "commentBody": "This removes the label association with the input as now `label` doesn't have any value that labels it. I think the issue raised is with the `InlineSwitch` component, that has an extra label, not with the `Switch` component.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/76914#discussion_r1367679104",
    "filePath": "packages/grafana-ui/src/components/Switch/Switch.tsx",
    "diffHunk": "@@ -36,9 +36,10 @@ export const Switch = React.forwardRef<HTMLInputElement, Props>(\n           }}\n           id={switchIdRef.current}\n           {...inputProps}\n+          aria-label={label ?? 'Toggle switch'}\n           ref={ref}\n         />\n-        <label htmlFor={switchIdRef.current} aria-label={label ?? 'Toggle switch'} />\n+        <label htmlFor={switchIdRef.current} />",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-10-21T06:52:15Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1691202877,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 74048,
    "prTitle": "Replace signed in user for identity.requester",
    "prAuthor": "linoman",
    "prLink": "https://github.com/grafana/grafana/pull/74048",
    "commentAuthor": "Jguer",
    "commentBody": "return err. in case there is a failure in auth broker and it gives you an invalid ID (not an int), you want to avoid it getting passed around",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/74048#discussion_r1310387217",
    "filePath": "pkg/services/user/identity.go",
    "diffHunk": "@@ -51,6 +54,20 @@ func (u *SignedInUser) ToUserDisplayDTO() *UserDisplayDTO {\n \t}\n }\n \n+// Static function to parse a requester into a UserDisplayDTO\n+func NewUserDisplayDTOFromRequester(requester identity.Requester) (*UserDisplayDTO, error) {\n+\tnamespaceID, identifier := requester.GetNamespacedID()\n+\tif namespaceID != identity.NamespaceUser && namespaceID != identity.NamespaceServiceAccount {\n+\t\tidentifier = \"0\"\n+\t}\n+\tuserID, _ := identity.IntIdentifier(namespaceID, identifier)",
    "line": 20,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-08-30T14:39:12Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1602873445,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 70115,
    "prTitle": "Explore: Add runQueries keybinding",
    "prAuthor": "gelicia",
    "prLink": "https://github.com/grafana/grafana/pull/70115",
    "commentAuthor": "torkelo",
    "commentBody": "If I am typing inside an input in a query editor and hit this shortcut it will not execute a query with the change I have just made (most editors only commit the model change on blur / enter) ",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/70115#discussion_r1231295748",
    "filePath": "public/app/features/explore/ExplorePage.tsx",
    "diffHunk": "@@ -55,7 +56,11 @@ export default function ExplorePage(props: GrafanaRouteComponentProps<{}, Explor\n \n   useEffect(() => {\n     keybindings.setupTimeRangeBindings(false);\n-  }, [keybindings]);\n+\n+    keybindings.bindWithExploreId('shift+enter', (exploreId) => {\n+      dispatch(runQueries({ exploreId }));\n+    });",
    "line": 16,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-06-15T16:43:17Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1482022297,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 62033,
    "prTitle": "API: Permit Cache-Control (browser caching) for datasource resources",
    "prAuthor": "kylebrandt",
    "prLink": "https://github.com/grafana/grafana/pull/62033",
    "commentAuthor": "gtk-grafana",
    "commentBody": "ccHeaderValues is a string of comma separated values, so if the cache control includes a max-age this check will fail.\r\nFor example, I would expect to be able to set the following headers in the datasource resource.go:\r\n```\r\n Cache-Control: private, max-age=806400\r\n X-Grafana-Cache: y\r\n```\r\nand have that pass this check.",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/grafana/grafana/pull/62033#discussion_r1099183298",
    "filePath": "pkg/middleware/middleware.go",
    "diffHunk": "@@ -95,3 +98,24 @@ func AddCustomResponseHeaders(cfg *setting.Cfg) web.Handler {\n \t\t})\n \t}\n }\n+\n+func allowCacheControl(rw web.ResponseWriter) bool {\n+\tccHeaderValues := rw.Header().Values(\"Cache-Control\")\n+\n+\tif len(ccHeaderValues) == 0 {\n+\t\treturn false\n+\t}\n+\n+\tfoundPrivate := false\n+\tfoundPublic := false\n+\tfor _, val := range ccHeaderValues {",
    "line": 43,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-02-07T20:28:58Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1287952465,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 60981,
    "prTitle": "Alerting: Support customizable timeout for screenshots",
    "prAuthor": "grobinson-grafana",
    "prLink": "https://github.com/grafana/grafana/pull/60981",
    "commentAuthor": "yuri-tceretian",
    "commentBody": "this can be asserted by comparing with `context.DeadlineExceeded`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/60981#discussion_r1061835505",
    "filePath": "pkg/services/ngalert/image/service_test.go",
    "diffHunk": "@@ -30,90 +31,116 @@ func TestScreenshotImageService(t *testing.T) {\n \t\tuploads     = imguploader.NewMockImageUploader(ctrl)\n \t)\n \n-\ts := NewScreenshotImageService(cache, &limiter, log.NewNopLogger(), screenshots, images,\n+\ts := NewScreenshotImageService(cache, &limiter, log.NewNopLogger(), screenshots, 5*time.Second, images,\n \t\tNewUploadingService(uploads, prometheus.NewRegistry()))\n \n \tctx := context.Background()\n \n-\t// assert that the cache is checked for an existing image\n-\tcache.EXPECT().Get(gomock.Any(), \"M2DGZaRLXtg=\").Return(models.Image{}, false)\n-\n-\t// assert that a screenshot is taken\n-\tscreenshots.EXPECT().Take(gomock.Any(), screenshot.ScreenshotOptions{\n-\t\tDashboardUID: \"foo\",\n-\t\tPanelID:      1,\n-\t\tTimeout:      screenshotTimeout,\n-\t}).Return(&screenshot.Screenshot{\n-\t\tPath: \"foo.png\",\n-\t}, nil)\n-\n-\t// assert that the screenshot is made into an image and uploaded\n-\tuploads.EXPECT().Upload(gomock.Any(), \"foo.png\").\n-\t\tReturn(\"https://example.com/foo.png\", nil)\n-\n-\t// assert that the image is saved into the database\n-\texpected := models.Image{\n-\t\tID:    1,\n-\t\tToken: \"foo\",\n-\t\tPath:  \"foo.png\",\n-\t\tURL:   \"https://example.com/foo.png\",\n-\t}\n-\n-\t// assert that the image is saved into the cache\n-\tcache.EXPECT().Set(gomock.Any(), \"M2DGZaRLXtg=\", expected).Return(nil)\n-\n-\timage, err := s.NewImage(ctx, &models.AlertRule{\n-\t\tOrgID:        1,\n-\t\tUID:          \"foo\",\n-\t\tDashboardUID: pointer.String(\"foo\"),\n-\t\tPanelID:      pointer.Int64(1)})\n-\trequire.NoError(t, err)\n-\tassert.Equal(t, expected, *image)\n-\n-\t// assert that the cache is checked for an existing image\n-\tcache.EXPECT().Get(gomock.Any(), \"rTOWVcbRidk=\").Return(models.Image{}, false)\n-\n-\t// assert that a screenshot is taken\n-\tscreenshots.EXPECT().Take(gomock.Any(), screenshot.ScreenshotOptions{\n-\t\tDashboardUID: \"bar\",\n-\t\tPanelID:      1,\n-\t\tTimeout:      screenshotTimeout,\n-\t}).Return(&screenshot.Screenshot{\n-\t\tPath: \"bar.png\",\n-\t}, nil)\n-\n-\t// the screenshot is made into an image and uploaded, but the upload returns an error\n-\tuploads.EXPECT().Upload(gomock.Any(), \"bar.png\").\n-\t\tReturn(\"\", errors.New(\"failed to upload bar.png\"))\n-\n-\t// and then saved into the database, but without a URL\n-\texpected = models.Image{\n-\t\tID:    2,\n-\t\tToken: \"bar\",\n-\t\tPath:  \"bar.png\",\n-\t}\n-\n-\t// assert that the image is saved into the cache, but without a URL\n-\tcache.EXPECT().Set(gomock.Any(), \"rTOWVcbRidk=\", expected).Return(nil)\n-\n-\timage, err = s.NewImage(ctx, &models.AlertRule{\n-\t\tOrgID:        1,\n-\t\tUID:          \"bar\",\n-\t\tDashboardUID: pointer.String(\"bar\"),\n-\t\tPanelID:      pointer.Int64(1)})\n-\trequire.NoError(t, err)\n-\tassert.Equal(t, expected, *image)\n-\n-\texpected = models.Image{Path: \"baz.png\", URL: \"https://example.com/baz.png\"}\n-\n-\t// assert that the cache is checked for an existing image and it is returned\n-\tcache.EXPECT().Get(gomock.Any(), \"8hJuVe20rVE=\").Return(expected, true)\n-\n-\timage, err = s.NewImage(ctx, &models.AlertRule{\n-\t\tOrgID:        1,\n-\t\tUID:          \"baz\",\n-\t\tDashboardUID: pointer.String(\"baz\"),\n-\t\tPanelID:      pointer.Int64(1)})\n-\trequire.NoError(t, err)\n-\tassert.Equal(t, expected, *image)\n+\tt.Run(\"image is taken, uploaded, saved to database and cached\", func(t *testing.T) {\n+\t\t// assert that the cache is checked for an existing image\n+\t\tcache.EXPECT().Get(gomock.Any(), \"M2DGZaRLXtg=\").Return(models.Image{}, false)\n+\n+\t\t// assert that a screenshot is taken\n+\t\tscreenshots.EXPECT().Take(gomock.Any(), screenshot.ScreenshotOptions{\n+\t\t\tDashboardUID: \"foo\",\n+\t\t\tPanelID:      1,\n+\t\t\tTimeout:      5 * time.Second,\n+\t\t}).Return(&screenshot.Screenshot{\n+\t\t\tPath: \"foo.png\",\n+\t\t}, nil)\n+\n+\t\t// assert that the screenshot is made into an image and uploaded\n+\t\tuploads.EXPECT().Upload(gomock.Any(), \"foo.png\").\n+\t\t\tReturn(\"https://example.com/foo.png\", nil)\n+\n+\t\t// assert that the image is saved into the database\n+\t\texpected := models.Image{\n+\t\t\tID:    1,\n+\t\t\tToken: \"foo\",\n+\t\t\tPath:  \"foo.png\",\n+\t\t\tURL:   \"https://example.com/foo.png\",\n+\t\t}\n+\n+\t\t// assert that the image is saved into the cache\n+\t\tcache.EXPECT().Set(gomock.Any(), \"M2DGZaRLXtg=\", expected).Return(nil)\n+\n+\t\timage, err := s.NewImage(ctx, &models.AlertRule{\n+\t\t\tOrgID:        1,\n+\t\t\tUID:          \"foo\",\n+\t\t\tDashboardUID: pointer.String(\"foo\"),\n+\t\t\tPanelID:      pointer.Int64(1)})\n+\t\trequire.NoError(t, err)\n+\t\tassert.Equal(t, expected, *image)\n+\t})\n+\n+\tt.Run(\"image is taken, upload return error, saved to database without URL and cached\", func(t *testing.T) {\n+\t\t// assert that the cache is checked for an existing image\n+\t\tcache.EXPECT().Get(gomock.Any(), \"rTOWVcbRidk=\").Return(models.Image{}, false)\n+\n+\t\t// assert that a screenshot is taken\n+\t\tscreenshots.EXPECT().Take(gomock.Any(), screenshot.ScreenshotOptions{\n+\t\t\tDashboardUID: \"bar\",\n+\t\t\tPanelID:      1,\n+\t\t\tTimeout:      5 * time.Second,\n+\t\t}).Return(&screenshot.Screenshot{\n+\t\t\tPath: \"bar.png\",\n+\t\t}, nil)\n+\n+\t\t// the screenshot is made into an image and uploaded, but the upload returns an error\n+\t\tuploads.EXPECT().Upload(gomock.Any(), \"bar.png\").\n+\t\t\tReturn(\"\", errors.New(\"failed to upload bar.png\"))\n+\n+\t\t// and then saved into the database, but without a URL\n+\t\texpected := models.Image{\n+\t\t\tID:    2,\n+\t\t\tToken: \"bar\",\n+\t\t\tPath:  \"bar.png\",\n+\t\t}\n+\n+\t\t// assert that the image is saved into the cache, but without a URL\n+\t\tcache.EXPECT().Set(gomock.Any(), \"rTOWVcbRidk=\", expected).Return(nil)\n+\n+\t\timage, err := s.NewImage(ctx, &models.AlertRule{\n+\t\t\tOrgID:        1,\n+\t\t\tUID:          \"bar\",\n+\t\t\tDashboardUID: pointer.String(\"bar\"),\n+\t\t\tPanelID:      pointer.Int64(1)})\n+\t\trequire.NoError(t, err)\n+\t\tassert.Equal(t, expected, *image)\n+\t})\n+\n+\tt.Run(\"image is returned from cache\", func(t *testing.T) {\n+\t\texpected := models.Image{Path: \"baz.png\", URL: \"https://example.com/baz.png\"}\n+\n+\t\t// assert that the cache is checked for an existing image and it is returned\n+\t\tcache.EXPECT().Get(gomock.Any(), \"8hJuVe20rVE=\").Return(expected, true)\n+\n+\t\timage, err := s.NewImage(ctx, &models.AlertRule{\n+\t\t\tOrgID:        1,\n+\t\t\tUID:          \"baz\",\n+\t\t\tDashboardUID: pointer.String(\"baz\"),\n+\t\t\tPanelID:      pointer.Int64(1)})\n+\t\trequire.NoError(t, err)\n+\t\tassert.Equal(t, expected, *image)\n+\t})\n+\n+\tt.Run(\"error is returned when timeout is exceeded\", func(t *testing.T) {\n+\t\t// assert that the cache is checked for an existing image\n+\t\tcache.EXPECT().Get(gomock.Any(), \"jtThkFaZLA4=\").Return(models.Image{}, false)\n+\n+\t\t// assert that when the timeout is exceeded an error is returned\n+\t\tscreenshots.EXPECT().Take(gomock.Any(), screenshot.ScreenshotOptions{\n+\t\t\tDashboardUID: \"qux\",\n+\t\t\tPanelID:      1,\n+\t\t\tTimeout:      5 * time.Second,\n+\t\t}).Return(nil, context.DeadlineExceeded)\n+\n+\t\timage, err := s.NewImage(ctx, &models.AlertRule{\n+\t\t\tOrgID:        1,\n+\t\t\tUID:          \"qux\",\n+\t\t\tDashboardUID: pointer.String(\"qux\"),\n+\t\t\tPanelID:      pointer.Int64(1)})\n+\t\tassert.EqualError(t, err, \"context deadline exceeded\")",
    "line": 203,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-01-04T19:55:56Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1236406245,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 59982,
    "prTitle": "QueryVariable: use datasource variable as source",
    "prAuthor": "ivanortegaalba",
    "prLink": "https://github.com/grafana/grafana/pull/59982",
    "commentAuthor": "torkelo",
    "commentBody": "This should not be needed as getDataSourceSrv already interpolates it, so if you do. \r\n\r\n ```\r\nreturn getDataSourceSrv().get(this.state.datasource, { __sceneObject: { text: '__sceneObject', value: this }});\r\n```\r\n\r\nit should work ",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/grafana/grafana/pull/59982#discussion_r1045561354",
    "filePath": "public/app/features/scenes/variables/variants/query/QueryVariable.tsx",
    "diffHunk": "@@ -125,6 +125,19 @@ export class QueryVariable extends MultiValueVariable<QueryVariableState> {\n     );\n   }\n \n+  private async getDataSource(): Promise<DataSourceApi> {\n+    const ds = this.state.datasource ?? '';\n+    if (typeof ds === 'string') {\n+      const interpolatedDS = sceneGraph.interpolate(this, ds);\n+      if (Array.isArray(interpolatedDS) && interpolatedDS.length > 0) {\n+        return getDataSourceSrv().get(String(interpolatedDS[0]));\n+      }\n+      return getDataSourceSrv().get(String(interpolatedDS));\n+    }\n+\n+    return getDataSourceSrv().get();\n+  }",
    "line": 42,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-12-12T09:08:04Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1213135401,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 55052,
    "prTitle": "Proof of concept: FieldTypeFloat64 replaced FieldTypeNullableFloat64 …",
    "prAuthor": "gtk-grafana",
    "prLink": "https://github.com/grafana/grafana/pull/55052",
    "commentAuthor": "kylebrandt",
    "commentBody": "Line 372 will panic at runtime (basically run any query but `0/0` and it will panic). This is because a nullablefloat64 takes pointers to float64, so 372 needs to become `&value`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/55052#discussion_r969589762",
    "filePath": "pkg/tsdb/prometheus/buffered/time_series_query.go",
    "diffHunk": "@@ -362,7 +362,7 @@ func matrixToDataFrames(matrix model.Matrix, query *PrometheusQuery, frames data\n \t\t\ttags[string(k)] = string(v)\n \t\t}\n \t\ttimeField := data.NewFieldFromFieldType(data.FieldTypeTime, len(v.Values))\n-\t\tvalueField := data.NewFieldFromFieldType(data.FieldTypeFloat64, len(v.Values))\n+\t\tvalueField := data.NewFieldFromFieldType(data.FieldTypeNullableFloat64, len(v.Values))",
    "line": 5,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 181584042,
        "node_id": "REA_lATOAOaWjc45ysQCzgrSwKo",
        "user": {
          "login": "gtk-grafana",
          "id": 109082771,
          "node_id": "U_kgDOBoB4kw",
          "avatar_url": "https://avatars.githubusercontent.com/u/109082771?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/gtk-grafana",
          "html_url": "https://github.com/gtk-grafana",
          "followers_url": "https://api.github.com/users/gtk-grafana/followers",
          "following_url": "https://api.github.com/users/gtk-grafana/following{/other_user}",
          "gists_url": "https://api.github.com/users/gtk-grafana/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/gtk-grafana/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/gtk-grafana/subscriptions",
          "organizations_url": "https://api.github.com/users/gtk-grafana/orgs",
          "repos_url": "https://api.github.com/users/gtk-grafana/repos",
          "events_url": "https://api.github.com/users/gtk-grafana/events{/privacy}",
          "received_events_url": "https://api.github.com/users/gtk-grafana/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "hooray",
        "created_at": "2022-09-13T12:59:49Z"
      }
    ],
    "timestamp": "2022-09-13T12:55:34Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1105745936,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 51372,
    "prTitle": "Alerting: Add support for images in Pushover alerts",
    "prAuthor": "grobinson-grafana",
    "prLink": "https://github.com/grafana/grafana/pull/51372",
    "commentAuthor": "JacobsonMT",
    "commentBody": "A similar consideration as I mentioned for Telegram: \r\n\r\n`withStoredImages` will short-circuit if `func(index int, image *ngmodels.Image)` returns an error. This means that if an image fails to send for whatever reason, no further images will attempt to send.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/51372#discussion_r907883551",
    "filePath": "pkg/services/ngalert/notifier/channels/pushover.go",
    "diffHunk": "@@ -157,112 +167,129 @@ func (pn *PushoverNotifier) SendResolved() bool {\n }\n \n func (pn *PushoverNotifier) genPushoverBody(ctx context.Context, as ...*types.Alert) (map[string]string, bytes.Buffer, error) {\n-\tvar b bytes.Buffer\n-\n-\truleURL := joinUrlPath(pn.tmpl.ExternalURL.String(), \"/alerting/list\", pn.log)\n-\n-\talerts := types.Alerts(as...)\n-\n-\tvar tmplErr error\n-\ttmpl, _ := TmplText(ctx, pn.tmpl, as, pn.log, &tmplErr)\n-\n+\tb := bytes.Buffer{}\n \tw := multipart.NewWriter(&b)\n-\tboundary := GetBoundary()\n-\tif boundary != \"\" {\n+\n+\t// tests use a non-random boundary separator\n+\tif boundary := GetBoundary(); boundary != \"\" {\n \t\terr := w.SetBoundary(boundary)\n \t\tif err != nil {\n \t\t\treturn nil, b, err\n \t\t}\n \t}\n \n-\t// Add the user token\n-\terr := w.WriteField(\"user\", tmpl(pn.UserKey))\n-\tif err != nil {\n-\t\treturn nil, b, err\n+\tvar tmplErr error\n+\ttmpl, _ := TmplText(ctx, pn.tmpl, as, pn.log, &tmplErr)\n+\n+\tif err := w.WriteField(\"user\", tmpl(pn.UserKey)); err != nil {\n+\t\treturn nil, b, fmt.Errorf(\"failed to write the user: %w\", err)\n \t}\n \n-\t// Add the api token\n-\terr = w.WriteField(\"token\", pn.APIToken)\n-\tif err != nil {\n-\t\treturn nil, b, err\n+\tif err := w.WriteField(\"token\", pn.APIToken); err != nil {\n+\t\treturn nil, b, fmt.Errorf(\"failed to write the token: %w\", err)\n \t}\n \n-\t// Add priority\n+\tstatus := types.Alerts(as...).Status()\n \tpriority := pn.AlertingPriority\n-\tif alerts.Status() == model.AlertResolved {\n+\tif status == model.AlertResolved {\n \t\tpriority = pn.OKPriority\n \t}\n-\terr = w.WriteField(\"priority\", strconv.Itoa(priority))\n-\tif err != nil {\n-\t\treturn nil, b, err\n+\tif err := w.WriteField(\"priority\", strconv.Itoa(priority)); err != nil {\n+\t\treturn nil, b, fmt.Errorf(\"failed to write the priority: %w\", err)\n \t}\n \n \tif priority == 2 {\n-\t\terr = w.WriteField(\"retry\", strconv.Itoa(pn.Retry))\n-\t\tif err != nil {\n-\t\t\treturn nil, b, err\n+\t\tif err := w.WriteField(\"retry\", strconv.Itoa(pn.Retry)); err != nil {\n+\t\t\treturn nil, b, fmt.Errorf(\"failed to write retry: %w\", err)\n \t\t}\n \n-\t\terr = w.WriteField(\"expire\", strconv.Itoa(pn.Expire))\n-\t\tif err != nil {\n-\t\t\treturn nil, b, err\n+\t\tif err := w.WriteField(\"expire\", strconv.Itoa(pn.Expire)); err != nil {\n+\t\t\treturn nil, b, fmt.Errorf(\"failed to write expire: %w\", err)\n \t\t}\n \t}\n \n-\t// Add device\n \tif pn.Device != \"\" {\n-\t\terr = w.WriteField(\"device\", tmpl(pn.Device))\n-\t\tif err != nil {\n-\t\t\treturn nil, b, err\n+\t\tif err := w.WriteField(\"device\", tmpl(pn.Device)); err != nil {\n+\t\t\treturn nil, b, fmt.Errorf(\"failed to write the device: %w\", err)\n \t\t}\n \t}\n \n-\t// Add sound\n-\tsound := tmpl(pn.AlertingSound)\n-\tif alerts.Status() == model.AlertResolved {\n-\t\tsound = tmpl(pn.OKSound)\n-\t}\n-\tif sound != \"default\" {\n-\t\terr = w.WriteField(\"sound\", sound)\n-\t\tif err != nil {\n-\t\t\treturn nil, b, err\n-\t\t}\n+\tif err := w.WriteField(\"title\", tmpl(DefaultMessageTitleEmbed)); err != nil {\n+\t\treturn nil, b, fmt.Errorf(\"failed to write the title: %w\", err)\n \t}\n \n-\t// Add title\n-\terr = w.WriteField(\"title\", tmpl(DefaultMessageTitleEmbed))\n-\tif err != nil {\n-\t\treturn nil, b, err\n+\truleURL := joinUrlPath(pn.tmpl.ExternalURL.String(), \"/alerting/list\", pn.log)\n+\tif err := w.WriteField(\"url\", ruleURL); err != nil {\n+\t\treturn nil, b, fmt.Errorf(\"failed to write the URL: %w\", err)\n \t}\n \n-\t// Add URL\n-\terr = w.WriteField(\"url\", ruleURL)\n-\tif err != nil {\n-\t\treturn nil, b, err\n-\t}\n-\t// Add URL title\n-\terr = w.WriteField(\"url_title\", \"Show alert rule\")\n-\tif err != nil {\n-\t\treturn nil, b, err\n+\tif err := w.WriteField(\"url_title\", \"Show alert rule\"); err != nil {\n+\t\treturn nil, b, fmt.Errorf(\"failed to write the URL title: %w\", err)\n \t}\n \n-\t// Add message\n-\terr = w.WriteField(\"message\", tmpl(pn.Message))\n-\tif err != nil {\n-\t\treturn nil, b, err\n+\tif err := w.WriteField(\"message\", tmpl(pn.Message)); err != nil {\n+\t\treturn nil, b, fmt.Errorf(\"failed write the message: %w\", err)\n \t}\n \n-\tif tmplErr != nil {\n-\t\tpn.log.Warn(\"failed to template pushover message\", \"err\", tmplErr.Error())\n+\t// Pushover supports at most one image attachment with a maximum size of pushoverMaxFileSize.\n+\t// If the image is larger than pushoverMaxFileSize then return an error.\n+\t_ = withStoredImages(ctx, pn.log, pn.images, func(index int, image *ngmodels.Image) error {",
    "line": 193,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 172021925,
        "node_id": "REA_lATOAOaWjc42HTQfzgpA2KU",
        "user": {
          "login": "grobinson-grafana",
          "id": 85952834,
          "node_id": "MDQ6VXNlcjg1OTUyODM0",
          "avatar_url": "https://avatars.githubusercontent.com/u/85952834?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/grobinson-grafana",
          "html_url": "https://github.com/grobinson-grafana",
          "followers_url": "https://api.github.com/users/grobinson-grafana/followers",
          "following_url": "https://api.github.com/users/grobinson-grafana/following{/other_user}",
          "gists_url": "https://api.github.com/users/grobinson-grafana/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/grobinson-grafana/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/grobinson-grafana/subscriptions",
          "organizations_url": "https://api.github.com/users/grobinson-grafana/orgs",
          "repos_url": "https://api.github.com/users/grobinson-grafana/repos",
          "events_url": "https://api.github.com/users/grobinson-grafana/events{/privacy}",
          "received_events_url": "https://api.github.com/users/grobinson-grafana/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2022-06-28T08:39:54Z"
      }
    ],
    "timestamp": "2022-06-27T23:34:26Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1020900603,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 50537,
    "prTitle": "CLI: Allow relative symlinks in zip archives when installing plugins",
    "prAuthor": "marefr",
    "prLink": "https://github.com/grafana/grafana/pull/50537",
    "commentAuthor": "jmatosgrafana",
    "commentBody": "@marefr When running `isSymlinkRelativeTo(\"/base\", \"../..\", \"/base/plugins/symlink.txt\")` it returns true but I was expecting false",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/50537#discussion_r898946872",
    "filePath": "pkg/plugins/manager/installer/installer.go",
    "diffHunk": "@@ -607,12 +594,39 @@ func extractSymlink(file *zip.File, filePath string) error {\n \tif _, err := io.Copy(buf, src); err != nil {\n \t\treturn fmt.Errorf(\"%v: %w\", \"failed to copy symlink contents\", err)\n \t}\n-\tif err := os.Symlink(strings.TrimSpace(buf.String()), filePath); err != nil {\n+\n+\tsymlinkPath := strings.TrimSpace(buf.String())\n+\tif !isSymlinkRelativeTo(basePath, symlinkPath, filePath) {\n+\t\treturn fmt.Errorf(\"symlink %q pointing outside plugin directory is not allowed\", filePath)\n+\t}\n+\n+\tif err := os.Symlink(symlinkPath, filePath); err != nil {\n \t\treturn fmt.Errorf(\"failed to make symbolic link for %v: %w\", filePath, err)\n \t}\n \treturn nil\n }\n \n+// isSymlinkRelativeTo checks whether symlinkDestPath is relative to basePath.\n+// symlinkOrigPath is the path to file holding the symbolic link.\n+func isSymlinkRelativeTo(basePath string, symlinkDestPath string, symlinkOrigPath string) bool {\n+\tif filepath.IsAbs(symlinkDestPath) {\n+\t\treturn false\n+\t} else {",
    "line": 80,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-06-16T10:39:24Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1008847077,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 45020,
    "prTitle": "Explore: Add t * keybindings to change time range",
    "prAuthor": "gelicia",
    "prLink": "https://github.com/grafana/grafana/pull/45020",
    "commentAuthor": "torkelo",
    "commentBody": "\r\nthis inverts the logic here, which means all callers needs to pass false, when they previously passed true \r\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/45020#discussion_r864033494",
    "filePath": "public/app/features/dashboard/services/TimeSrv.ts",
    "diffHunk": "@@ -276,20 +276,19 @@ export class TimeSrv {\n     this.setAutoRefresh(this.previousAutoRefresh);\n   }\n \n-  setTime(time: RawTimeRange, fromRouteUpdate?: boolean) {\n+  setTime(time: RawTimeRange, updateUrl = true) {",
    "line": 158,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-05-03T17:46:34Z",
    "isReviewComment": true,
    "pullRequestReviewId": 960757672,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 43547,
    "prTitle": "Serviceaccounts: migration state handling",
    "prAuthor": "eleijonmarck",
    "prLink": "https://github.com/grafana/grafana/pull/43547",
    "commentAuthor": "donomii",
    "commentBody": "You need a mutex here, and probably at the start of every function involved in migrations.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/43547#discussion_r777367273",
    "filePath": "pkg/services/serviceaccounts/database/database.go",
    "diffHunk": "@@ -61,26 +63,133 @@ func deleteServiceAccountInTransaction(sess *sqlstore.DBSession, orgID, serviceA\n \treturn nil\n }\n \n+// TODO: write test\n+/*\n+ write benchmarks if possible\n+*/\n func (s *ServiceAccountsStoreImpl) UpgradeServiceAccounts(ctx context.Context) error {\n+\tcanStart, err := s.startMigration(ctx, orgID)\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\tif !canStart {\n+\t\t// inprogress\n+\t\treturn nil\n+\t}\n \tbasicKeys := s.sqlStore.GetNonServiceAccountAPIKeys(ctx)\n \tif len(basicKeys) > 0 {\n \t\ts.log.Info(\"Launching background thread to upgrade API keys to service accounts\", \"numberKeys\", len(basicKeys))\n \t\tgo func() {\n-\t\t\tfor _, key := range basicKeys {\n-\t\t\t\tsa, err := s.sqlStore.CreateServiceAccountForApikey(ctx, key.OrgId, key.Name, key.Role)\n-\t\t\t\tif err != nil {\n-\t\t\t\t\ts.log.Error(\"Failed to create service account for API key\", \"err\", err, \"keyId\", key.Id)\n-\t\t\t\t\tcontinue\n-\t\t\t\t}\n-\n-\t\t\t\terr = s.sqlStore.UpdateApikeyServiceAccount(ctx, key.Id, sa.Id)\n-\t\t\t\tif err != nil {\n-\t\t\t\t\ts.log.Error(\"Failed to attach new service account to API key\", \"err\", err, \"keyId\", key.Id, \"newServiceAccountId\", sa.Id)\n-\t\t\t\t\tcontinue\n-\t\t\t\t}\n-\t\t\t\ts.log.Debug(\"Updated basic api key\", \"keyId\", key.Id, \"newServiceAccountId\", sa.Id)\n+\t\t\terr := s.migrateToServiceAccounts(basicKeys, orgID)\n+\t\t\tif err != nil {\n+\t\t\t\ts.log.Error(\"Failed to upgrade API keys to service accounts\", \"err\", err)\n \t\t\t}\n+\n \t\t}()\n+\t} else {\n+\t\t// no basic apikeys found\n+\t\treturn s.updateMigrationLog(ctx, orgID, true, nil)\n \t}\n \treturn nil\n }\n+\n+func (s *ServiceAccountsStoreImpl) migrateToServiceAccounts(basicKeys []*models.ApiKey, orgID int64) error {",
    "line": 62,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-01-03T09:28:05Z",
    "isReviewComment": true,
    "pullRequestReviewId": 842580849,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 43030,
    "prTitle": "Orgs: move duplicate API calls to Redux",
    "prAuthor": "thisisobate",
    "prLink": "https://github.com/grafana/grafana/pull/43030",
    "commentAuthor": "Clarity-89",
    "commentBody": "This action does an async API request, but looking at the code, the page location will be changed possibly before the request is completed. One issue I noticed is, if for some reason changing org fails, the user will still be redirected to the root page, but for the wrong org. Also I think it's a bit inconsistent that we set location this time directly in component, but other time in redux action. ",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/43030#discussion_r769384189",
    "filePath": "public/app/features/org/SelectOrgPage.tsx",
    "diffHunk": "@@ -19,17 +21,23 @@ const navModel = {\n const getUserOrgs = async () => {\n   return await getBackendSrv().get('/api/user/orgs');\n };\n-const setUserOrg = async (org: UserOrg) => {\n-  return await getBackendSrv()\n-    .post('/api/user/using/' + org.orgId)\n-    .then(() => {\n-      window.location.href = config.appSubUrl + '/';\n-    });\n+\n+const mapDispatchToProps = {\n+  setUserOrganization,\n };\n \n-export const SelectOrgPage: FC = () => {\n+const connector = connect(null, mapDispatchToProps);\n+\n+type Props = ConnectedProps<typeof connector>;\n+\n+export const SelectOrgPage: FC<Props> = ({ setUserOrganization }) => {\n   const [orgs, setOrgs] = useState<UserOrg[]>();\n \n+  const setUserOrg = async (org: UserOrg) => {\n+    setUserOrganization(org.orgId);",
    "line": 33,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-12-15T08:44:59Z",
    "isReviewComment": true,
    "pullRequestReviewId": 832483264,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 41653,
    "prTitle": "Live: optionally send queries over websocket connection",
    "prAuthor": "FZambia",
    "prLink": "https://github.com/grafana/grafana/pull/41653",
    "commentAuthor": "ArturWierzbicki",
    "commentBody": "`options.frame` is passed from the main thread to web worker and `DataFrame` class is not serializable due to Vectors",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/41653#discussion_r760031372",
    "filePath": "packages/grafana-runtime/src/services/live.ts",
    "diffHunk": "@@ -20,12 +21,20 @@ export interface LiveDataFilter {\n  */\n export interface LiveDataStreamOptions {\n   addr: LiveChannelAddress;\n-  frame?: DataFrame; // initial results\n+  frame?: DataFrameJSON; // initial results",
    "line": 13,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-12-01T10:05:35Z",
    "isReviewComment": true,
    "pullRequestReviewId": 820046817,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "grafana/grafana",
    "prNumber": 39208,
    "prTitle": "[v8.1.x] BarChart: fix stale bar values and x axis labels",
    "prAuthor": "leeoniya",
    "prLink": "https://github.com/grafana/grafana/pull/39208",
    "commentAuthor": "DanCech",
    "commentBody": "plot isn't defined in 8.1.x, so this causes an undefined error",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/grafana/grafana/pull/39208#discussion_r710334672",
    "filePath": "packages/grafana-ui/src/components/uPlot/Plot.tsx",
    "diffHunk": "@@ -109,6 +109,14 @@ export class UPlotChart extends React.Component<PlotProps, UPlotChartState> {\n       this.reinitPlot();\n     } else if (!sameData(prevProps, this.props)) {\n       ctx.plot?.setData(this.props.data);\n+\n+      // this is a uPlot cache-busting hack for bar charts in case x axis labels changed\n+      // since the x scale's \"range\" doesnt change, the axis size doesnt get recomputed, which is where the tick labels are regenerated & cached\n+      // the more expensive, more proper/thorough way to do this is to force all axes to recalc: plot?.redraw(false, true);\n+      if (ctx.plot && typeof this.props.data[0][0] === 'string') {\n+        //@ts-ignore\n+        plot.axes[0]._values = this.props.data[0];",
    "line": 10,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-09-16T17:33:05Z",
    "isReviewComment": true,
    "pullRequestReviewId": 756589939,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "langgenius/dify",
    "prNumber": 12280,
    "prTitle": "[feat] enable claude 3.5 and nova to support document",
    "prAuthor": "warren830",
    "prLink": "https://github.com/langgenius/dify/pull/12280",
    "commentAuthor": "hjlarry",
    "commentBody": "the `DocumentPromptMessageContent` seems not has `file_name` `file_type` attr",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/langgenius/dify/pull/12280#discussion_r1900495400",
    "filePath": "api/core/model_runtime/model_providers/bedrock/llm/llm.py",
    "diffHunk": "@@ -456,7 +458,60 @@ def _convert_prompt_message_to_dict(self, message: PromptMessage) -> dict:\n                             \"image\": {\"format\": mime_type.replace(\"image/\", \"\"), \"source\": {\"bytes\": image_content}}\n                         }\n                         sub_messages.append(sub_message_dict)\n+                    elif message_content.type == PromptMessageContentType.DOCUMENT:\n+                        message_content = cast(DocumentPromptMessageContent, message_content)\n+                        file_name = message_content.file_name\n+                        file_data = message_content.data\n+                        file_format = message_content.file_type.lower()",
    "line": 17,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2025-01-02T01:43:34Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2526964541,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "langgenius/dify",
    "prNumber": 4588,
    "prTitle": "feat: support tidb vector ",
    "prAuthor": "Weaxs",
    "prLink": "https://github.com/langgenius/dify/pull/4588",
    "commentAuthor": "JohnJyong",
    "commentBody": "this will caused : TypeError: object of type 'NoneType' has no len()",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/langgenius/dify/pull/4588#discussion_r1627441768",
    "filePath": "api/core/rag/datasource/vdb/tidb_vector/tidb_vector.py",
    "diffHunk": "@@ -0,0 +1,214 @@\n+import json\n+import logging\n+from typing import Any\n+\n+import sqlalchemy\n+from pydantic import BaseModel, root_validator\n+from sqlalchemy import JSON, TEXT, Column, DateTime, String, Table, create_engine, insert\n+from sqlalchemy import text as sql_text\n+from sqlalchemy.orm import Session, declarative_base\n+\n+from core.rag.datasource.vdb.vector_base import BaseVector\n+from core.rag.models.document import Document\n+from extensions.ext_redis import redis_client\n+\n+logger = logging.getLogger(__name__)\n+\n+\n+class TiDBVectorConfig(BaseModel):\n+    host: str\n+    port: int\n+    user: str\n+    password: str\n+    database: str\n+\n+    @root_validator()\n+    def validate_config(cls, values: dict) -> dict:\n+        if not values['host']:\n+            raise ValueError(\"config TIDB_VECTOR_HOST is required\")\n+        if not values['port']:\n+            raise ValueError(\"config TIDB_VECTOR_PORT is required\")\n+        if not values['user']:\n+            raise ValueError(\"config TIDB_VECTOR_USER is required\")\n+        if not values['password']:\n+            raise ValueError(\"config TIDB_VECTOR_PASSWORD is required\")\n+        if not values['database']:\n+            raise ValueError(\"config TIDB_VECTOR_DATABASE is required\")\n+        return values\n+\n+\n+class TiDBVector(BaseVector):\n+\n+    def _table(self, dim: int) -> Table:\n+        from tidb_vector.sqlalchemy import VectorType\n+        return Table(\n+            self._collection_name,\n+            self._orm_base.metadata,\n+            Column('id', String(36), primary_key=True, nullable=False),\n+            Column(\"vector\", VectorType(dim), nullable=False, comment=\"\" if self._distance_func is None else f\"hnsw(distance={self._distance_func})\"),\n+            Column(\"text\", TEXT, nullable=False),\n+            Column(\"meta\", JSON, nullable=False),\n+            Column(\"create_time\", DateTime, server_default=sqlalchemy.text(\"CURRENT_TIMESTAMP\")),\n+            Column(\"update_time\", DateTime, server_default=sqlalchemy.text(\"CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP\")),\n+            extend_existing=True\n+        )\n+\n+    def __init__(self, collection_name: str, config: TiDBVectorConfig, distance_func: str = 'cosine'):\n+        super().__init__(collection_name)\n+        self._client_config = config\n+        self._url = (f\"mysql+pymysql://{config.user}:{config.password}@{config.host}:{config.port}/{config.database}?\"\n+                     f\"ssl_verify_cert=true&ssl_verify_identity=true\")\n+        self._distance_func = distance_func.lower()\n+        self._engine = create_engine(self._url)\n+        self._orm_base = declarative_base()\n+        self._dimension = 1536\n+\n+    def create(self, texts: list[Document], embeddings: list[list[float]], **kwargs):\n+        logger.info(\"create collection and add texts, collection_name: \" + self._collection_name)\n+        self._create_collection(len(embeddings[0]))\n+        self.add_texts(texts, embeddings)\n+        self._dimension = len(embeddings[0])\n+        pass\n+\n+    def _create_collection(self, dimension: int):\n+        logger.info(\"_create_collection, collection_name \" + self._collection_name)\n+        lock_name = 'vector_indexing_lock_{}'.format(self._collection_name)\n+        with redis_client.lock(lock_name, timeout=20):\n+            collection_exist_cache_key = 'vector_indexing_{}'.format(self._collection_name)\n+            if redis_client.get(collection_exist_cache_key):\n+                return\n+            with Session(self._engine) as session:\n+                session.begin()\n+                drop_statement = sql_text(f\"\"\"DROP TABLE IF EXISTS {self._collection_name}; \"\"\")\n+                session.execute(drop_statement)\n+                create_statement = sql_text(f\"\"\"\n+                    CREATE TABLE IF NOT EXISTS {self._collection_name} (\n+                        id CHAR(36) PRIMARY KEY,\n+                        text TEXT NOT NULL,\n+                        meta JSON NOT NULL,\n+                        vector VECTOR<FLOAT>({dimension}) NOT NULL COMMENT \"hnsw(distance={self._distance_func})\",\n+                        create_time DATETIME DEFAULT CURRENT_TIMESTAMP,\n+                        update_time DATETIME DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP\n+                    );\n+                \"\"\")\n+                session.execute(create_statement)\n+                # tidb vector not support 'CREATE/ADD INDEX' now\n+                session.commit()\n+            redis_client.set(collection_exist_cache_key, 1, ex=3600)\n+\n+    def add_texts(self, documents: list[Document], embeddings: list[list[float]], **kwargs):\n+        table = self._table(len(embeddings[0]))\n+        ids = self._get_uuids(documents)\n+        metas = [d.metadata for d in documents]\n+        texts = [d.page_content for d in documents]\n+\n+        chunks_table_data = []\n+        with self._engine.connect() as conn:\n+            with conn.begin():\n+                for id, text, meta, embedding in zip(\n+                        ids, texts, metas, embeddings\n+                ):\n+                    chunks_table_data.append({\"id\": id, \"vector\": embedding, \"text\": text, \"meta\": meta})\n+\n+                    # Execute the batch insert when the batch size is reached\n+                    if len(chunks_table_data) == 500:\n+                        conn.execute(insert(table).values(chunks_table_data))\n+                        # Clear the chunks_table_data list for the next batch\n+                        chunks_table_data.clear()\n+\n+                # Insert any remaining records that didn't make up a full batch\n+                if chunks_table_data:\n+                    conn.execute(insert(table).values(chunks_table_data))\n+        return ids\n+\n+    def text_exists(self, id: str) -> bool:\n+        result = self.get_ids_by_metadata_field('doc_id', id)\n+        return len(result) > 0",
    "line": 126,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-06-05T10:18:35Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2098693423,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "langgenius/dify",
    "prNumber": 4115,
    "prTitle": "feat: verify environment variables",
    "prAuthor": "TinsFox",
    "prLink": "https://github.com/langgenius/dify/pull/4115",
    "commentAuthor": "crazywoola",
    "commentBody": "Error: ❌ Attempted to access a server-side environment variable on the client",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/langgenius/dify/pull/4115#discussion_r1639706628",
    "filePath": "web/context/app-context.tsx",
    "diffHunk": "@@ -91,7 +92,7 @@ export const AppContextProvider: FC<AppContextProviderProps> = ({ children }) =>\n       const result = await userProfileResponse.json()\n       setUserProfile(result)\n       const current_version = userProfileResponse.headers.get('x-version')\n-      const current_env = process.env.NODE_ENV === 'development' ? 'DEVELOPMENT' : userProfileResponse.headers.get('x-env')\n+      const current_env = env.NODE_ENV === 'development' ? 'DEVELOPMENT' : userProfileResponse.headers.get('x-env')",
    "line": 13,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-06-14T11:49:37Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2118197227,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "infiniflow/ragflow",
    "prNumber": 5017,
    "prTitle": "Iframe should support input variables",
    "prAuthor": "gstrat88",
    "prLink": "https://github.com/infiniflow/ragflow/pull/5017",
    "commentAuthor": "cike8899",
    "commentBody": "searchParams cannot be traversed by Object.entries. You can use searchParams.entries. Also, pay attention to type checking errors.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/infiniflow/ragflow/pull/5017#discussion_r1957520952",
    "filePath": "web/src/pages/chat/shared-hooks.ts",
    "diffHunk": "@@ -22,19 +22,27 @@ export const useSendButtonDisabled = (value: string) => {\n \n export const useGetSharedChatSearchParams = () => {\n   const [searchParams] = useSearchParams();\n-\n+  const dataPrefix = \"data_\";\n+  const data = {};\n+  \n+  for (const [key, value] of Object.entries(searchParams)) {",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2025-02-17T02:58:15Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2619879528,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "Budibase/budibase",
    "prNumber": 14724,
    "prTitle": "Fix enterprise vulns",
    "prAuthor": "shogunpurple",
    "prLink": "https://github.com/Budibase/budibase/pull/14724",
    "commentAuthor": "samwho",
    "commentBody": "You'll want to `await` this. Bit of a sharp corner in the API. ",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/Budibase/budibase/pull/14724#discussion_r1790572559",
    "filePath": "packages/server/src/sdk/app/rows/tests/utils.spec.ts",
    "diffHunk": "@@ -332,4 +333,46 @@ describe(\"validate\", () => {\n       })\n     })\n   })\n+\n+  describe(\"XSS Safe mode\", () => {\n+    const getTable = (): Table => ({\n+      type: \"table\",\n+      _id: generateTableID(),\n+      name: \"table\",\n+      sourceId: INTERNAL_TABLE_SOURCE_ID,\n+      sourceType: TableSourceType.INTERNAL,\n+      schema: {\n+        text: {\n+          name: \"sometext\",\n+          type: FieldType.STRING,\n+        },\n+      },\n+    })\n+    it.each([\n+      \"SELECT * FROM users WHERE username = 'admin' --\",\n+      \"SELECT * FROM users WHERE id = 1; DROP TABLE users;\",\n+      \"1' OR '1' = '1\",\n+      \"' OR 'a' = 'a\",\n+      \"<script>alert('XSS');</script>\",\n+      '\"><img src=x onerror=alert(1)>',\n+      \"</script><script>alert('test')</script>\",\n+      \"<div onmouseover=\\\"alert('XSS')\\\">Hover over me!</div>\",\n+      \"'; EXEC sp_msforeachtable 'DROP TABLE ?'; --\",\n+      \"{alert('Injected')}\",\n+      \"UNION SELECT * FROM users\",\n+      \"INSERT INTO users (username, password) VALUES ('admin', 'password')\",\n+      \"/* This is a comment */ SELECT * FROM users\",\n+      '<iframe src=\"http://malicious-site.com\"></iframe>',\n+    ])(\"test potentially unsafe input: %s\", async input => {\n+      withEnv({ XSS_SAFE_MODE: \"1\" }, async () => {",
    "line": 43,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 268237494,
        "node_id": "REA_lATOC15Oss5qufgPzg_8-rY",
        "user": {
          "login": "shogunpurple",
          "id": 11256663,
          "node_id": "MDQ6VXNlcjExMjU2NjYz",
          "avatar_url": "https://avatars.githubusercontent.com/u/11256663?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/shogunpurple",
          "html_url": "https://github.com/shogunpurple",
          "followers_url": "https://api.github.com/users/shogunpurple/followers",
          "following_url": "https://api.github.com/users/shogunpurple/following{/other_user}",
          "gists_url": "https://api.github.com/users/shogunpurple/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/shogunpurple/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/shogunpurple/subscriptions",
          "organizations_url": "https://api.github.com/users/shogunpurple/orgs",
          "repos_url": "https://api.github.com/users/shogunpurple/repos",
          "events_url": "https://api.github.com/users/shogunpurple/events{/privacy}",
          "received_events_url": "https://api.github.com/users/shogunpurple/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2024-10-07T17:01:35Z"
      }
    ],
    "timestamp": "2024-10-07T16:53:04Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2352484024,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "epicweb-dev/epic-stack",
    "prNumber": 111,
    "prTitle": "simplify createRequestHandler",
    "prAuthor": "onemen",
    "prLink": "https://github.com/epicweb-dev/epic-stack/pull/111",
    "commentAuthor": "kentcdodds",
    "commentBody": "This change won't work because we need to make certain every request uses the latest version of the `devBuild` variable. With the changes here it will only ever use the first version.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/epicweb-dev/epic-stack/pull/111#discussion_r1210798702",
    "filePath": "server/index.ts",
    "diffHunk": "@@ -72,27 +72,15 @@ app.use(\n \t}),\n )\n \n-async function getRequestHandlerOptions(\n-\tbuild: ServerBuild,\n-): Promise<Parameters<typeof createRequestHandler>[0]> {\n+function getRequestHandler(build: ServerBuild): RequestHandler {\n \tfunction getLoadContext(_: any, res: any) {\n \t\treturn { cspNonce: res.locals.cspNonce }\n \t}\n-\treturn { build, mode: MODE, getLoadContext }\n+\treturn createRequestHandler({ build, mode: MODE, getLoadContext })\n }\n \n-app.all(\n-\t'*',\n-\tprocess.env.NODE_ENV === 'development'\n-\t\t? async (req, res, next) => {\n-\t\t\t\treturn createRequestHandler(await getRequestHandlerOptions(devBuild))(",
    "line": 28,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-05-30T20:36:57Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1451776979,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "triggerdotdev/trigger.dev",
    "prNumber": 1703,
    "prTitle": "Alert Webhook improvements",
    "prAuthor": "matt-aitken",
    "prLink": "https://github.com/triggerdotdev/trigger.dev/pull/1703",
    "commentAuthor": "coderabbitai[bot]",
    "commentBody": "_:bulb: Verification agent_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n**Verify the security header naming convention.**\n\nThe header name `x-trigger-signature-hmacsha256` follows good practices by:\n1. Using the `x-` prefix for custom headers\n2. Including the hash algorithm in the name\n\n\nLet's verify if this header name is consistently used across the codebase:\n\n---\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Description: Check for consistent usage of the signature header name\nrg -i \"trigger.*signature\" --type ts\n```\n\nLength of output: 372\n\n---\n\n\n\n</details>\n\n**Inconsistent header naming found in the codebase.**\n\n- The constant `SIGNATURE_HEADER_NAME` is defined as `\"x-trigger-signature-hmacsha256\"` in `packages/trigger-sdk/src/v3/webhooks.ts` and used as such in `apps/webapp/app/v3/services/alerts/deliverAlert.server.ts`.\n- However, in `apps/webapp/app/services/runs/deliverRunSubscription.server.ts`, it is referenced as `\"X-Trigger-Signature-256\"`, which deviates from the defined convention.\n- **Action Required:** Update the header name in `deliverRunSubscription.server.ts` to either import and use `SIGNATURE_HEADER_NAME` or change it to `\"x-trigger-signature-hmacsha256\"` for consistency and adherence to common security practices.\n\n<!-- This is an auto-generated comment by CodeRabbit -->",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/triggerdotdev/trigger.dev/pull/1703#discussion_r1954518979",
    "filePath": "packages/trigger-sdk/src/v3/webhooks.ts",
    "diffHunk": "@@ -0,0 +1,171 @@\n+import { Webhook } from \"@trigger.dev/core/v3\";\n+import { subtle } from \"../imports/uncrypto.js\";\n+\n+/**\n+ * The type of error thrown when a webhook fails to parse or verify\n+ */\n+export class WebhookError extends Error {\n+  constructor(message: string) {\n+    super(message);\n+    this.name = \"WebhookError\";\n+  }\n+}\n+\n+/** Header name used for webhook signatures */\n+const SIGNATURE_HEADER_NAME = \"x-trigger-signature-hmacsha256\";",
    "line": 15,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2025-02-13T13:38:56Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2615024081,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "triggerdotdev/trigger.dev",
    "prNumber": 1676,
    "prTitle": "Force upgrade v1 batches to v3",
    "prAuthor": "ericallam",
    "prLink": "https://github.com/triggerdotdev/trigger.dev/pull/1676",
    "commentAuthor": "coderabbitai[bot]",
    "commentBody": "_:bulb: Verification agent_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n**Verify response structure compatibility with clients.**\n\nThe response structure has been modified:\n- `batchId` now uses `result.id` instead of `result.batch.friendlyId`\n- `runs` array now contains only run IDs\n\nPlease ensure that these changes are backward compatible or that all clients are updated to handle the new response format.\n\nLet's search for clients using the old response format:\n\n---\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Search for usages of the old response format\nrg -A 2 'batch\\.friendlyId|runs\\['\n```\n\nLength of output: 26025\n\n---\n\n\n\n</details>\n\n**Response structure change may break clients expecting the old format**\n\nWe’ve confirmed that the tasks endpoint now returns:\n- A property named “batchId” derived from result.id (instead of the previous result.batch.friendlyId)\n- A “runs” array containing only run IDs (instead of full run objects)\n\nHowever, our grep search shows that many parts of the codebase (including several API endpoints, presenters, and even documentation examples) still reference the old format using batch.friendlyId and expect run objects or properties in a particular structure.\n\n• Clients consuming the response from this endpoint may be assuming a nested “batch” object with a “friendlyId” property.\n• Several areas (e.g. routes in resources/orgs… and API endpoints like api.v1.batches.$batchId.ts, as well as tests in references/v3-catalog) continue to use the previous field names.\n\nPlease ensure that either:\n- The clients calling the tasks endpoint are updated to use the new “batchId” value and a flat runs array, or\n- A backward compatibility layer is provided so that both response formats can be supported during the migration\n\n<!-- This is an auto-generated comment by CodeRabbit -->",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/triggerdotdev/trigger.dev/pull/1676#discussion_r1945459104",
    "filePath": "apps/webapp/app/routes/api.v1.tasks.$taskId.batch.ts",
    "diffHunk": "@@ -106,8 +108,8 @@ export async function action({ request, params }: ActionFunctionArgs) {\n \n     return json(\n       {\n-        batchId: result.batch.friendlyId,\n-        runs: result.runs,\n+        batchId: result.id,\n+        runs: result.runs.map((run) => run.id),",
    "line": 46,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2025-02-06T21:15:27Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2599972545,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "triggerdotdev/trigger.dev",
    "prNumber": 1657,
    "prTitle": "db efficiency improvements",
    "prAuthor": "ericallam",
    "prLink": "https://github.com/triggerdotdev/trigger.dev/pull/1657",
    "commentAuthor": "coderabbitai[bot]",
    "commentBody": "_:bulb: Codebase verification_\n\n**Deployment lookup unique constraint missing**\n\n- The Prisma schema for the WorkerDeployment model does not enforce a unique constraint on the (projectId, shortCode) combination, which could lead to duplicate deployments being returned.  \n- Please update the schema (e.g., add `@@unique([projectId, shortCode])`) to guarantee uniqueness.\n\n\n\n<details>\n<summary>🔗 Analysis chain</summary>\n\n**Verify uniqueness constraint on deployment lookup.**\n\nThe change from `findUniqueOrThrow` to `findFirstOrThrow` assumes that the combination of `projectId` and `shortCode` is unique. Please ensure there's a unique constraint in the schema to prevent duplicate deployments.\n\nRun the following script to verify the schema constraint:\n\n</details>\n\n<details>\n<summary>🏁 Scripts executed</summary>\n\nThe following scripts were executed for the analysis:\n\nScript:\n\n```shell\n#!/bin/bash\n# Description: Check for unique constraint on workerDeployment table.\n# Expect: A unique constraint on projectId and shortCode.\n\nast-grep --pattern $'model WorkerDeployment {\n  $$$\n  @@unique([$_])\n  $$$\n}'\n\n```\n\nLength of output: 78\n\n---\n\nScript:\n\n```shell\n#!/bin/bash\n# Description: Verify the unique constraint on the WorkerDeployment model in the Prisma schema.\n# This script searches for the WorkerDeployment model in any \"schema.prisma\" file and looks for a unique constraint\n# defined on the combination of projectId and shortCode.\n#\n# It uses 'rg' (ripgrep) to search for the relevant pattern in the repository.\n#\n# Expected Output: Lines from the Prisma schema where the unique constraint is defined.\n#\n# Note: If no output is returned, please verify manually that the unique constraint exists.\n\n# First, try to locate the schema.prisma file(s)\nschema_file=$(fd -e prisma -e \"prisma\" | head -n 1)\n\nif [ -n \"$schema_file\" ]; then\n  echo \"Searching in $schema_file for the unique constraint on (projectId, shortCode)...\"\n  rg -n \"model\\s+WorkerDeployment\\s+\\{([^}]*?)@@unique\\(\\[projectId,\\s*shortCode\\]\\)\" \"$schema_file\" || echo \"Unique constraint not found in $schema_file.\"\nelse\n  echo \"schema.prisma file not found through fd. Searching entire repository for WorkerDeployment model...\"\n  rg -n \"model\\s+WorkerDeployment\" . | tee /tmp/workerDeployment.txt\n  echo \"Now, check the above output for any @@unique constraint with [projectId, shortCode].\"\nfi\n\n```\n\nLength of output: 705\n\n---\n\nScript:\n\n```shell\n#!/bin/bash\n# Description: Re-verify the unique constraint on the WorkerDeployment model in the Prisma schema with a flexible regex.\n# This script searches in the schema.prisma file for a unique constraint defined on the combination of projectId and shortCode,\n# regardless of their order in the @@unique attribute.\n#\n# The regex matches either [projectId, shortCode] or [shortCode, projectId].\n\nschema_file=$(fd -e prisma -e \"prisma\" | head -n 1)\n\nif [ -n \"$schema_file\" ]; then\n  echo \"Searching in $schema_file for the unique constraint on (projectId, shortCode) with flexible ordering...\"\n  rg -n \"model\\s+WorkerDeployment\\s+\\{([^}]*?)@@unique\\(\\[\\s*((projectId\\s*,\\s*shortCode)|(shortCode\\s*,\\s*projectId))\\s*\\]\\)\" \"$schema_file\" || echo \"Unique constraint not found in $schema_file.\"\nelse\n  echo \"schema.prisma file not found. Searching entire repository for WorkerDeployment model...\"\n  rg -n \"model\\s+WorkerDeployment\" . | tee /tmp/workerDeployment.txt\n  echo \"Now, check the above output for any @@unique constraint with [projectId, shortCode] (or reverse order).\"\nfi\n\n```\n\nLength of output: 792\n\n</details>\n\n<!-- This is an auto-generated comment by CodeRabbit -->",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/triggerdotdev/trigger.dev/pull/1657#discussion_r1939423206",
    "filePath": "apps/webapp/app/presenters/v3/DeploymentPresenter.server.ts",
    "diffHunk": "@@ -53,12 +53,10 @@ export class DeploymentPresenter {\n       },\n     });\n \n-    const deployment = await this.#prismaClient.workerDeployment.findUniqueOrThrow({\n+    const deployment = await this.#prismaClient.workerDeployment.findFirstOrThrow({\n       where: {\n-        projectId_shortCode: {\n-          projectId: project.id,\n-          shortCode: deploymentShortCode,\n-        },\n+        projectId: project.id,\n+        shortCode: deploymentShortCode,\n       },",
    "line": 13,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2025-02-03T13:59:24Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2589987578,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "triggerdotdev/trigger.dev",
    "prNumber": 1541,
    "prTitle": "Realtime streams now powered by electric",
    "prAuthor": "ericallam",
    "prLink": "https://github.com/triggerdotdev/trigger.dev/pull/1541",
    "commentAuthor": "coderabbitai[bot]",
    "commentBody": "_:warning: Potential issue_\n\n**Fix potential memory leak in delayed stream implementation**\n\nThe delayed stream implementation has several issues that need to be addressed:\n1. The interval is not cleaned up if the stream is aborted or encounters an error\n2. The delay is hard-coded to 100ms\n\nConsider this improved implementation:\n\n```diff\n function createDelayedTestShapeStream(\n   shapes: SubscribeRunRawShape[]\n ): ReadableStream<SubscribeRunRawShape> {\n   return new ReadableStream({\n     start: async (controller) => {\n       // Emit first shape immediately\n       if (shapes.length > 0) {\n         controller.enqueue(shapes[0]);\n       }\n\n       let currentShapeIndex = 1;\n+      let intervalId: NodeJS.Timeout;\n\n       // Emit remaining shapes with delay\n-      const interval = setInterval(() => {\n+      intervalId = setInterval(() => {\n         if (currentShapeIndex >= shapes.length) {\n-          clearInterval(interval);\n+          clearInterval(intervalId);\n           controller.close();\n           return;\n         }\n         controller.enqueue(shapes[currentShapeIndex++]!);\n       }, 100);\n+\n+      // Clean up interval on cancel\n+      return () => {\n+        clearInterval(intervalId);\n+      };\n     },\n+    cancel() {\n+      // Additional safety cleanup\n+      controller.close();\n+    }\n   });\n }\n```\n\nAlso consider:\n1. Making the delay configurable via a parameter\n2. Adding error handling for malformed shapes\n\n\n> Committable suggestion skipped: line range outside the PR's diff.\n\n<!-- This is an auto-generated comment by CodeRabbit -->",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/triggerdotdev/trigger.dev/pull/1541#discussion_r1876806111",
    "filePath": "packages/core/test/runStream.test.ts",
    "diffHunk": "@@ -33,64 +31,54 @@ class TestStreamSubscriptionFactory implements StreamSubscriptionFactory {\n     this.streams.set(`${runId}:${streamKey}`, chunks);\n   }\n \n-  createSubscription(runId: string, streamKey: string): StreamSubscription {\n+  createSubscription(\n+    metadata: Record<string, unknown>,\n+    runId: string,\n+    streamKey: string\n+  ): StreamSubscription {\n     const chunks = this.streams.get(`${runId}:${streamKey}`) ?? [];\n     return new TestStreamSubscription(chunks);\n   }\n }\n \n-// Create a real test provider that uses an array of shapes\n-class TestShapeProvider implements RunShapeProvider {\n-  private shapes: SubscribeRunRawShape[];\n-  private unsubscribed = false;\n-\n-  constructor(shapes: SubscribeRunRawShape[]) {\n-    this.shapes = shapes;\n-  }\n-\n-  async onShape(callback: (shape: SubscribeRunRawShape) => Promise<void>): Promise<() => void> {\n-    // Process all shapes immediately\n-    for (const shape of this.shapes) {\n-      if (this.unsubscribed) break;\n-      await callback(shape);\n-    }\n-\n-    return () => {\n-      this.unsubscribed = true;\n-    };\n-  }\n+// Remove the RunShapeProvider implementations and replace with stream creators\n+function createTestShapeStream(\n+  shapes: SubscribeRunRawShape[]\n+): ReadableStream<SubscribeRunRawShape> {\n+  return new ReadableStream({\n+    start: async (controller) => {\n+      // Emit all shapes immediately\n+      for (const shape of shapes) {\n+        controller.enqueue(shape);\n+      }\n+      controller.close();\n+    },\n+  });\n }\n \n-// Add this new provider that can emit shapes over time\n-class DelayedTestShapeProvider implements RunShapeProvider {\n-  private shapes: SubscribeRunRawShape[];\n-  private unsubscribed = false;\n-  private currentShapeIndex = 0;\n-\n-  constructor(shapes: SubscribeRunRawShape[]) {\n-    this.shapes = shapes;\n-  }\n-\n-  async onShape(callback: (shape: SubscribeRunRawShape) => Promise<void>): Promise<() => void> {\n-    // Only emit the first shape immediately\n-    if (this.shapes.length > 0) {\n-      await callback(this.shapes[this.currentShapeIndex++]!);\n-    }\n-\n-    // Set up an interval to emit remaining shapes\n-    const interval = setInterval(async () => {\n-      if (this.unsubscribed || this.currentShapeIndex >= this.shapes.length) {\n-        clearInterval(interval);\n-        return;\n+function createDelayedTestShapeStream(\n+  shapes: SubscribeRunRawShape[]\n+): ReadableStream<SubscribeRunRawShape> {\n+  return new ReadableStream({\n+    start: async (controller) => {\n+      // Emit first shape immediately\n+      if (shapes.length > 0) {\n+        controller.enqueue(shapes[0]);\n       }\n-      await callback(this.shapes[this.currentShapeIndex++]!);\n-    }, 100);\n \n-    return () => {\n-      this.unsubscribed = true;\n-      clearInterval(interval);\n-    };\n-  }\n+      let currentShapeIndex = 1;\n+\n+      // Emit remaining shapes with delay\n+      const interval = setInterval(() => {\n+        if (currentShapeIndex >= shapes.length) {\n+          clearInterval(interval);\n+          controller.close();\n+          return;\n+        }\n+        controller.enqueue(shapes[currentShapeIndex++]!);\n+      }, 100);\n+    },\n+  });",
    "line": 112,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-12-09T21:45:16Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2490177161,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "triggerdotdev/trigger.dev",
    "prNumber": 1524,
    "prTitle": "Add blob support",
    "prAuthor": "SjxSubham",
    "prLink": "https://github.com/triggerdotdev/trigger.dev/pull/1524",
    "commentAuthor": "coderabbitai[bot]",
    "commentBody": "_:warning: Potential issue_\n\n**Fix function redeclaration and add error handling.**\n\nThe `stringifyIO` function is redeclared, which will cause runtime errors. Additionally, the Blob handling needs better error handling.\n\nApply this diff to fix the issues:\n\n```diff\n-// Add Blob support in the stringifyIO function\n-export async function stringifyIO(value: any): Promise<IOPacket> {\n+// Update existing stringifyIO function\n-if (value === undefined) {\n-  return { dataType: \"application/json\" };\n-}\n-\n-if (typeof value === \"string\") {\n-  return { data: value, dataType: \"text/plain\" };\n-}\n-\n+// Add Blob support\nif (value instanceof Blob) {\n  const reader = new FileReader();\n  return new Promise((resolve, reject) => {\n    reader.onloadend = () => {\n+     if (!reader.result) {\n+       reject(new Error('Failed to read Blob'));\n+       return;\n+     }\n      resolve({ data: reader.result as string, dataType: \"application/blob\" });\n    };\n    reader.onerror = reject;\n    reader.readAsDataURL(value);\n  });\n}\n\n-try {\n-  const { stringify } = await loadSuperJSON();\n-  const data = stringify(value);\n-  return { data, dataType: \"application/super+json\" };\n-} catch {\n-  return { data: value, dataType: \"application/json\" };\n-}\n```\n\n\n> Committable suggestion skipped: line range outside the PR's diff.\n\n<details>\n<summary>🧰 Tools</summary>\n\n<details>\n<summary>🪛 Biome (1.9.4)</summary>\n\n[error] 192-192: Shouldn't redeclare 'stringifyIO'. Consider to delete it or rename it.\n\n'stringifyIO' is defined here:\n\n\n(lint/suspicious/noRedeclare)\n\n</details>\n\n</details>\n\n<!-- This is an auto-generated comment by CodeRabbit -->",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/triggerdotdev/trigger.dev/pull/1524#discussion_r1866263223",
    "filePath": "packages/core/src/v3/utils/ioSerialization.ts",
    "diffHunk": "@@ -188,7 +188,65 @@ export async function conditionallyImportPacket(\n     return result ?? packet;\n   }\n }\n+// Add Blob support in the stringifyIO function\n+export async function stringifyIO(value: any): Promise<IOPacket> {\n+  if (value === undefined) {\n+    return { dataType: \"application/json\" };\n+  }\n+\n+  if (typeof value === \"string\") {\n+    return { data: value, dataType: \"text/plain\" };\n+  }\n+\n+  if (value instanceof Blob) {\n+    const reader = new FileReader();\n+    return new Promise((resolve, reject) => {\n+      reader.onloadend = () => {\n+        resolve({ data: reader.result as string, dataType: \"application/blob\" });\n+      };\n+      reader.onerror = reject;\n+      reader.readAsDataURL(value);\n+    });\n+  }\n+\n+  try {\n+    const { stringify } = await loadSuperJSON();\n+    const data = stringify(value);\n+    return { data, dataType: \"application/super+json\" };\n+  } catch {\n+    return { data: value, dataType: \"application/json\" };\n+  }\n+}",
    "line": 32,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-12-02T17:09:03Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2473363885,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "triggerdotdev/trigger.dev",
    "prNumber": 457,
    "prTitle": "Framework: supported for Express",
    "prAuthor": "MAYANK-TRIPATH",
    "prLink": "https://github.com/triggerdotdev/trigger.dev/pull/457",
    "commentAuthor": "matt-aitken",
    "commentBody": "This isn't how you define jobs, you use `client.defineJob`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/triggerdotdev/trigger.dev/pull/457#discussion_r1338688839",
    "filePath": "docs/_snippets/manual-setup-express.mdx",
    "diffHunk": "@@ -1 +1,187 @@\n-We're in the process of building support for the Express framework. You can follow along with progress or contribute via [this GitHub issue](https://github.com/triggerdotdev/trigger.dev/issues).\n+---\n+title: \"Express\"\n+sidebarTitle: \"Express\"\n+description: \"How to manually setup Trigger.dev in your Express project\"\n+---\n+\n+<Accordion defaultOpen title=\"Don't have an Express project yet to add Trigger.dev to? No problem, you can complete the Manual Setup using a blank Express project:\">\n+Create a blank project by creating a new Express application:\n+\n+```bash\n+npm init -y\n+npm install express\n+```\n+\n+Trigger.dev works with Express applications.\n+\n+</Accordion>\n+\n+## Installing Required Packages\n+\n+Start by installing the necessary packages in your Express.js project directory. You can use npm, pnpm, or yarn as your package manager.\n+\n+<CodeGroup>\n+\n+```bash npm\n+\n+npm install @trigger.dev/sdk express @trigger-dev/express\n+\n+\n+```\n+\n+```bash pnpm\n+pnpm install @trigger.dev/sdk express @trigger-dev/express\n+\n+\n+```\n+\n+```bash yarn\n+yarn add @trigger.dev/sdk express @trigger-dev/express\n+\n+```\n+\n+</CodeGroup>\n+\n+<br />\n+\n+<Note>Ensure that you execute this command within a Express project.</Note>\n+\n+## Obtaining the Development API Key\n+\n+To locate your development API key, login to the [Trigger.dev\n+dashboard](https://cloud.trigger.dev) and select the Project you want to\n+connect to. Then click on the Environments & API Keys tab in the left menu.\n+You can copy your development API Key from the field at the top of this page.\n+(Your development key will start with `tr_dev_`).\n+\n+## Adding Environment Variables\n+\n+Create a `.env.local` file at the root of your project and include your Trigger API key and URL like this:\n+\n+```bash\n+\n+TRIGGER_API_KEY=ENTER_YOUR_DEVELOPMENT_API_KEY_HERE\n+TRIGGER_API_URL=https://cloud.trigger.dev\n+\n+```\n+\n+Replace `ENTER_YOUR_DEVELOPMENT_API_KEY_HERE` with the actual API key obtained from the previous step.\n+\n+## Configuring the Trigger Client\n+\n+To set up the Trigger Client for your project, follow these steps:\n+\n+1. **Create Configuration File:**\n+\n+   In your project directory, create a configuration file named `trigger.ts` or `trigger.js`, depending on whether your project uses TypeScript (`.ts`) or JavaScript (`.js`).\n+\n+2. **Choose Directory:**\n+\n+   Depending on your project structure, choose the appropriate directory for the configuration file. If your project uses a `src` directory, create the file within it. Otherwise, create it directly in the project root.\n+\n+3. **Add Configuration Code:**\n+\n+   Open the configuration file you created and add the following code:\n+\n+   ```typescript\n+   // trigger.ts (for TypeScript) or trigger.js (for JavaScript)\n+\n+  // trigger.ts\n+\n+import express, { Express } from 'express';\n+import { TriggerClient } from '@trigger.dev/sdk';\n+\n+const app: Express = express();\n+const port: number = process.env.PORT ? parseInt(process.env.PORT) : 3000;\n+\n+const triggerClient: TriggerClient = new TriggerClient({\n+  id: 'my-express-app',\n+  apiKey: process.env.TRIGGER_API_KEY || '',\n+  apiUrl: process.env.TRIGGER_API_URL || '',\n+});\n+\n+// Your Express.js app configuration and routes go here\n+\n+app.listen(port, () => {\n+  console.log(`Server is running on port ${port}`);\n+});\n+\n+   ```\n+ Replace **\"my-express-app\"** with an appropriate identifier for your project.\n+\n+ ## Creating the Example Job\n+\n+1. Create a folder named `Jobs` in your project directory\n+2. Inside the `Jobs` folder, add two files named `example.(ts/js)` and `index.(ts/js)`.\n+\n+<CodeGroup>\n+\n+```typescript example.(ts/js)\n+// example.ts\n+\n+import { eventTrigger, JobDefinition } from '@trigger.dev/sdk';\n+import { client } from './trigger';\n+\n+const exampleJob: JobDefinition = {",
    "line": 126,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-09-27T14:18:01Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1646725527,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "formbricks/formbricks",
    "prNumber": 4611,
    "prTitle": "chore: use Playwright cloud",
    "prAuthor": "mattinannt",
    "prLink": "https://github.com/formbricks/formbricks/pull/4611",
    "commentAuthor": "coderabbitai[bot]",
    "commentBody": "_:warning: Potential issue_\n\n**Critical Issue: `environmentId` may be undefined when initializing the server**\n\nIn the `beforeAll` hook, the server is created and starts listening before `environmentId` is assigned. This means that when the server is serving the HTML content, `environmentId` could be `undefined`, leading to incorrect or incomplete HTML being served.\n\n\n\nTo fix this issue, consider initializing `environmentId` before starting the server, or moving the server setup inside the test after `environmentId` is assigned. Here's how you could adjust the code:\n\n```diff\n-test.describe(\"JS Package Test\", async () => {\n-  let server: http.Server;\n-  let environmentId: string;\n\n-  test.beforeAll(async () => {\n-    // Create a simple HTTP server\n-    server = http.createServer((_, res) => {\n-      const htmlContent = HTML_TEMPLATE.replace(\"ENVIRONMENT_ID\", environmentId || \"\");\n-      res.writeHead(200, { \"Content-Type\": \"text/html\" });\n-      res.end(htmlContent);\n-    });\n\n-    await new Promise<void>((resolve) => {\n-      server.listen(3004, () => resolve());\n-    });\n-  });\n\n+test.describe(\"JS Package Test\", async () => {\n+  let server: http.Server;\n+  let environmentId: string;\n\n   test(\"Create, display and validate PMF survey\", async ({ page, users }) => {\n     // Create and login user\n     const user = await users.create();\n     await user.login();\n\n     await page.waitForURL(/\\/environments\\/[^/]+\\/surveys/);\n\n     // Extract environmentId early in the test\n     environmentId =\n       /\\/environments\\/([^/]+)\\/surveys/.exec(page.url())?.[1] ??\n       (() => {\n         throw new Error(\"Unable to parse environmentId from URL\");\n       })();\n\n+    // Create a simple HTTP server\n+    server = http.createServer((_, res) => {\n+      const htmlContent = HTML_TEMPLATE.replace(\"ENVIRONMENT_ID\", environmentId || \"\");\n+      res.writeHead(200, { \"Content-Type\": \"text/html\" });\n+      res.end(htmlContent);\n+    });\n\n+    await new Promise<void>((resolve) => {\n+      server.listen(3004, () => resolve());\n+    });\n\n     // Rest of your test code...\n```\n\n\n> Committable suggestion skipped: line range outside the PR's diff.\n\n<!-- This is an auto-generated comment by CodeRabbit -->",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/formbricks/formbricks/pull/4611#discussion_r1918153562",
    "filePath": "apps/web/playwright/js.spec.ts",
    "diffHunk": "@@ -1,125 +1,144 @@\n import { expect } from \"@playwright/test\";\n+import http from \"http\";\n import { test } from \"./lib/fixtures\";\n-import { replaceEnvironmentIdInHtml } from \"./utils/helper\";\n+\n+const HTML_TEMPLATE = `<head>\n+  <script type=\"text/javascript\">\n+    !(function () {\n+      var t = document.createElement(\"script\");\n+      (t.type = \"text/javascript\"), (t.async = !0), (t.src = \"http://localhost:3000/js/formbricks.umd.cjs\");\n+      var e = document.getElementsByTagName(\"script\")[0];\n+      e.parentNode.insertBefore(t, e),\n+        setTimeout(function () {\n+          formbricks.init({\n+            environmentId: \"ENVIRONMENT_ID\",\n+            userId: \"RANDOM_USER_ID\",\n+            apiHost: \"http://localhost:3000\",\n+          });\n+        }, 500);\n+    })();\n+  </script>\n+</head>\n+\n+<body style=\"background-color: #fff\">\n+  <p>This is my sample page using the Formbricks JS javascript widget</p>\n+</body>\n+`;\n \n test.describe(\"JS Package Test\", async () => {\n+  let server: http.Server;\n   let environmentId: string;\n \n-  test(\"Tests\", async ({ page, users }) => {\n-    await test.step(\"Admin creates an In-App Survey\", async () => {\n-      const user = await users.create();\n-      await user.login();\n-\n-      await page.waitForURL(/\\/environments\\/[^/]+\\/surveys/);\n-\n-      await page.getByRole(\"heading\", { name: \"Product Market Fit (Superhuman)\" }).isVisible();\n-      await page.getByRole(\"heading\", { name: \"Product Market Fit (Superhuman)\" }).click();\n-\n-      await page.getByRole(\"button\", { name: \"Use this template\" }).isVisible();\n-      await page.getByRole(\"button\", { name: \"Use this template\" }).click();\n-\n-      await page.waitForURL(/\\/environments\\/[^/]+\\/surveys\\/[^/]+\\/edit/);\n-\n-      await page.getByRole(\"button\", { name: \"Settings\", exact: true }).click();\n-\n-      await expect(page.locator(\"#howToSendCardTrigger\")).toBeVisible();\n-      await page.locator(\"#howToSendCardTrigger\").click();\n-\n-      await expect(page.locator(\"#howToSendCardOption-app\")).toBeVisible();\n-      await page.locator(\"#howToSendCardOption-app\").click();\n+  test.beforeAll(async () => {\n+    // Create a simple HTTP server\n+    server = http.createServer((_, res) => {\n+      const htmlContent = HTML_TEMPLATE.replace(\"ENVIRONMENT_ID\", environmentId || \"\");\n+      res.writeHead(200, { \"Content-Type\": \"text/html\" });\n+      res.end(htmlContent);\n+    });\n \n-      await page.locator(\"#whenToSendCardTrigger\").click();\n+    await new Promise<void>((resolve) => {\n+      server.listen(3004, () => resolve());\n+    });\n+  });",
    "line": 67,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2025-01-16T09:52:28Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2555406047,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "formbricks/formbricks",
    "prNumber": 4350,
    "prTitle": "fix: next js 15 stale experimental flags",
    "prAuthor": "gupta-piyush19",
    "prLink": "https://github.com/formbricks/formbricks/pull/4350",
    "commentAuthor": "coderabbitai[bot]",
    "commentBody": "_:bulb: Codebase verification_\n\n**Export configuration mismatch detected**\n\nThe verification revealed an inconsistency in the configuration export. The file exports `withNextIntl(nextConfig)` but the Sentry conditional logic that creates `exportConfig` is never used. This could prevent the new `serverExternalPackages` and `outputFileTracingIncludes` configurations from working with Sentry.\n\n- `apps/web/next.config.mjs`: The `exportConfig` variable is created but never exported, while `nextConfig` is directly used in the export statement.\n\n\n\n<details>\n<summary>🔗 Analysis chain</summary>\n\n**Verify build process with new configurations.**\n\nThe new root-level configurations need to work correctly with both Sentry and non-Sentry exports. Please verify the build process succeeds and packages are correctly bundled.\n\n\n\n\nAlso applies to: 293-297\n\n---\n\nThe previous search in workflows didn't yield results, so let's examine the actual config file and build-related configurations to understand how these new settings are integrated.\n\n</details>\n\n<details>\n<summary>🏁 Scripts executed</summary>\n\nThe following scripts were executed for the analysis:\n\nScript:\n\n```shell\n#!/bin/bash\n# Search for any build-related issues or warnings in recent commits\nrg -l \"serverExternalPackages|outputFileTracingIncludes\" .github/workflows/\n\n```\n\nLength of output: 77\n\n---\n\nScript:\n\n```shell\n#!/bin/bash\n# Check the next.config.mjs file structure and exports\ncat apps/web/next.config.mjs\n\n# Look for any related build configurations\nrg -g '*.{json,yaml,yml}' -l \"build.*web\" .\n\n```\n\nLength of output: 8487\n\n</details>\n\n<!-- This is an auto-generated comment by CodeRabbit -->",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/formbricks/formbricks/pull/4350#discussion_r1853307837",
    "filePath": "apps/web/next.config.mjs",
    "diffHunk": "@@ -20,13 +20,12 @@ const nextConfig = {\n   assetPrefix: process.env.ASSET_PREFIX_URL || undefined,\n   output: \"standalone\",\n   poweredByHeader: false,\n+  serverExternalPackages: [\"@aws-sdk\"],\n+  outputFileTracingIncludes: {\n+    \"app/api/packages\": [\"../../packages/js-core/dist/*\", \"../../packages/surveys/dist/*\"],\n+  },",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-11-22T05:29:30Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2453360168,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "formbricks/formbricks",
    "prNumber": 4228,
    "prTitle": "fix: toast translation",
    "prAuthor": "Dhruwang",
    "prLink": "https://github.com/formbricks/formbricks/pull/4228",
    "commentAuthor": "coderabbitai[bot]",
    "commentBody": "_:bulb: Codebase verification_\n\n**Translation key path mismatch detected**\n\nThe translation key in the code `environments.settings.profile.profile_updated_successfully` doesn't match the actual key structure in the i18n files where it's defined simply as `profile_updated_successfully`. This will result in the raw key being displayed instead of the translated message.\n\n- Update line 48 in `EditProfileDetailsForm.tsx` to use the correct translation key: `t(\"profile_updated_successfully\")`\n\n\n\n<details>\n<summary>🔗 Analysis chain</summary>\n\n**LGTM! Verify translation key exists.**\n\nThe updated translation key follows a more specific hierarchical structure that better reflects the context of the profile settings.\n\n\nLet's verify the translation key exists in the i18n files:\n\n</details>\n\n<details>\n<summary>🏁 Scripts executed</summary>\n\nThe following scripts were executed for the analysis:\n\nScript:\n\n```shell\n#!/bin/bash\n# Description: Search for the new translation key in i18n files\n# Test: Look for the new translation key. Expect: At least one match in translation files.\nrg \"profile_updated_successfully\" -g \"*.{json,ts,js,tsx,jsx}\"\n\n```\n\nLength of output: 607\n\n</details>\n\n<!-- This is an auto-generated comment by CodeRabbit -->",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/formbricks/formbricks/pull/4228#discussion_r1827460489",
    "filePath": "apps/web/app/(app)/environments/[environmentId]/settings/(account)/profile/components/EditProfileDetailsForm.tsx",
    "diffHunk": "@@ -45,7 +45,7 @@ export const EditProfileDetailsForm = ({ user }: { user: TUser }) => {\n       const name = data.name.trim();\n       const locale = data.locale;\n       await updateUserAction({ name, locale });\n-      toast.success(t(\"common.profile_updated_successfully\"));\n+      toast.success(t(\"environments.settings.profile.profile_updated_successfully\"));",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-11-04T09:51:58Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2412613978,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "formbricks/formbricks",
    "prNumber": 4118,
    "prTitle": "Add keyboard shortcuts for reordering survey questions",
    "prAuthor": "vishwamartur",
    "prLink": "https://github.com/formbricks/formbricks/pull/4118",
    "commentAuthor": "coderabbitai[bot]",
    "commentBody": "_:warning: Potential issue_\n\n**Fix effect dependencies and memoize handler.**\n\nThe effect hook is missing handleKeyDown in its dependency array, and the handler should be memoized:\n\n```diff\n+const handleKeyDown = useCallback((event: KeyboardEvent) => {\n   // ... existing handler code ...\n-}, [activeQuestionId, questions, moveQuestion, finalizePosition, resetPosition]);\n\n useEffect(() => {\n   window.addEventListener(\"keydown\", handleKeyDown);\n   return () => {\n     window.removeEventListener(\"keydown\", handleKeyDown);\n   };\n-}, [activeQuestionId, questions]);\n+}, [handleKeyDown]);\n```\n\n\n> Committable suggestion was skipped due to low confidence.\n\n<!-- This is an auto-generated comment by CodeRabbit -->",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/formbricks/formbricks/pull/4118#discussion_r1821987763",
    "filePath": "apps/web/app/(app)/(survey-editor)/environments/[environmentId]/surveys/[surveyId]/edit/components/KeyboardShortcuts.tsx",
    "diffHunk": "@@ -0,0 +1,55 @@\n+import { useEffect } from \"react\";\n+\n+interface KeyboardShortcutsProps {\n+  activeQuestionId: string | null;\n+  moveQuestion: (questionIndex: number, up: boolean) => void;\n+  finalizePosition: () => void;\n+  resetPosition: () => void;\n+  questions: { id: string }[];\n+}\n+\n+const KeyboardShortcuts = ({\n+  activeQuestionId,\n+  moveQuestion,\n+  finalizePosition,\n+  resetPosition,\n+  questions,\n+}: KeyboardShortcutsProps) => {\n+  const handleKeyDown = (event: KeyboardEvent) => {\n+    if (activeQuestionId === null) return;\n+\n+    const currentIndex = questions.findIndex((question) => question.id === activeQuestionId);\n+\n+    switch (event.key) {\n+      case \"ArrowUp\":\n+        if (currentIndex > 0) {\n+          moveQuestion(currentIndex, true);\n+        }\n+        break;\n+      case \"ArrowDown\":\n+        if (currentIndex < questions.length - 1) {\n+          moveQuestion(currentIndex, false);\n+        }\n+        break;\n+      case \"Enter\":\n+        finalizePosition();\n+        break;\n+      case \"Escape\":\n+        resetPosition();\n+        break;\n+      default:\n+        break;\n+    }\n+  };\n+\n+  useEffect(() => {\n+    window.addEventListener(\"keydown\", handleKeyDown);\n+    return () => {\n+      window.removeEventListener(\"keydown\", handleKeyDown);\n+    };\n+  }, [activeQuestionId, questions]);",
    "line": 50,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-10-30T06:58:02Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2403787310,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "formbricks/formbricks",
    "prNumber": 3688,
    "prTitle": "fix: adding packages for vite plugins",
    "prAuthor": "pandeymangg",
    "prLink": "https://github.com/formbricks/formbricks/pull/3688",
    "commentAuthor": "coderabbitai[bot]",
    "commentBody": "_:bulb: Codebase verification_\n\n\n**Import Path Issue for `copyCompiledAssetsPlugin`**\n\nThe new import path points to `packages/vite-plugins/copy-compiled-assets.ts`, but the file does not exist. Please verify the location of `copyCompiledAssetsPlugin` or ensure the file is added to `packages/vite-plugins`.\n\n\n\n<details>\n<summary>🔗 Analysis chain</summary>\n\n**Verify the new import path for `copyCompiledAssetsPlugin`**\n\nThe import path for `copyCompiledAssetsPlugin` has been updated to reflect the new package structure mentioned in the PR objectives. This change aligns with the goal of introducing a new package under `packages/vite-plugins` for Vite plugins.\n\nHowever, to ensure this change is correct and doesn't introduce any issues:\n\n1. Confirm that the file `copy-compiled-assets.ts` (or `copy-compiled-assets/index.ts`) exists in the `packages/vite-plugins` directory.\n2. Verify that the `copyCompiledAssetsPlugin` is correctly exported from this new location.\n3. Check if similar changes have been made in other files that might be using this plugin (e.g., other `vite.config.ts` files in the project).\n\n\nRun the following script to verify the new structure and usage:\n\n\n\nIf all checks pass, this change is likely correct and consistent with the PR objectives.\n\n\n</details>\n\n<details>\n<summary>🏁 Scripts executed</summary>\n\nThe following scripts were executed for the analysis:\n\nScript:\n\n```shell\n#!/bin/bash\n# Description: Verify the new structure and usage of copyCompiledAssetsPlugin\n\n# Test 1: Check if the new file exists\necho \"Checking if the new file exists:\"\nfd --type f --full-path \"packages/vite-plugins/copy-compiled-assets.(ts|js|tsx|jsx)\"\n\n# Test 2: Verify the export of copyCompiledAssetsPlugin\necho \"Verifying the export of copyCompiledAssetsPlugin:\"\nrg --type typescript \"export.*copyCompiledAssetsPlugin\" \"packages/vite-plugins\"\n\n# Test 3: Check for other usages of copyCompiledAssetsPlugin\necho \"Checking for other usages of copyCompiledAssetsPlugin:\"\nrg --type typescript \"import.*copyCompiledAssetsPlugin\" -g \"!packages/surveys/vite.config.ts\"\n\n```\n\nLength of output: 635\n\n---\n\nScript:\n\n```shell\n#!/bin/bash\n# Description: Verify the new structure and usage of copyCompiledAssetsPlugin\n\n# Test 1: Check if the new file exists\necho \"Checking if the new file exists:\"\nfd --type f --full-path 'packages/vite-plugins/copy-compiled-assets.ts' packages/vite-plugins\n\n# Test 2: Verify the export of copyCompiledAssetsPlugin\necho \"Verifying the export of copyCompiledAssetsPlugin:\"\nrg \"export\\s+const\\s+copyCompiledAssetsPlugin\" packages/vite-plugins/copy-compiled-assets.ts\n\n# Test 3: Check for other usages of copyCompiledAssetsPlugin\necho \"Checking for other usages of copyCompiledAssetsPlugin:\"\nrg \"import\\s+.*copyCompiledAssetsPlugin\" --glob '!packages/surveys/vite.config.ts' packages/\n\n```\n\nLength of output: 785\n\n</details>\n\n<!-- This is an auto-generated comment by CodeRabbit -->",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/formbricks/formbricks/pull/3688#discussion_r1799069927",
    "filePath": "packages/surveys/vite.config.ts",
    "diffHunk": "@@ -3,7 +3,7 @@ import { resolve } from \"path\";\n import { defineConfig, loadEnv } from \"vite\";\n import dts from \"vite-plugin-dts\";\n import tsconfigPaths from \"vite-tsconfig-paths\";\n-import { copyCompiledAssetsPlugin } from \"../copyCompiledAssetsPlugin/vite.config\";\n+import { copyCompiledAssetsPlugin } from \"../vite-plugins/copy-compiled-assets\";",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-10-14T09:27:19Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2365920210,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "formbricks/formbricks",
    "prNumber": 3229,
    "prTitle": "chore: update -brand with -brand-dark",
    "prAuthor": "nawinsharma",
    "prLink": "https://github.com/formbricks/formbricks/pull/3229",
    "commentAuthor": "coderabbitai[bot]",
    "commentBody": "_:bulb: Codebase verification_\n\n\n**Issue Found: 'fb-bg-brand-dark' is not defined in the Tailwind configuration.**\n\nPlease ensure that `'fb-bg-brand-dark'` is defined in your Tailwind configuration to align with the updated class name. This will ensure the progress bar displays with the intended dark brand color.\n\n\n\n<details>\n<summary>🔗 Analysis chain</summary>\n\n**LGTM! Class name updated correctly.**\n\nThe change from `fb-bg-brand` to `fb-bg-brand-dark` is in line with the PR objectives and should correctly update the progress bar's fill color to the new brand-dark color.\n\n\nTo ensure the visual change is consistent across different themes or color schemes, please run the following verification:\n\n\n\nPlease review the results to ensure all necessary updates have been made and that the new color is properly defined in your Tailwind configuration.\n\n</details>\n\n<details>\n<summary>🏁 Scripts executed</summary>\n\nThe following scripts were executed for the analysis:\n\nScript:\n\n```shell\n#!/bin/bash\n# Description: Check for any other occurrences of 'fb-bg-brand' that might need updating\n# and verify that 'fb-bg-brand-dark' is defined in the project's Tailwind configuration.\n\necho \"Checking for remaining 'fb-bg-brand' occurrences:\"\nrg --type tsx --type css 'fb-bg-brand'\n\necho \"\\nVerifying 'fb-bg-brand-dark' in Tailwind config:\"\nrg --type js --type ts 'brand-dark' | rg 'tailwind'\n\n```\n\nLength of output: 348\n\n---\n\nScript:\n\n```shell\n#!/bin/bash\n# Description: Check for any remaining occurrences of 'fb-bg-brand' in .tsx and .css files\n# and verify that 'fb-bg-brand-dark' is defined in the Tailwind configuration.\n\necho \"Checking for remaining 'fb-bg-brand' occurrences in .tsx and .css files:\"\nfd --extension tsx --extension css 'fb-bg-brand' || echo \"No remaining 'fb-bg-brand' occurrences found.\"\n\necho -e \"\\nVerifying 'fb-bg-brand-dark' is defined in Tailwind configuration:\"\nfd --extension js --extension ts --extension js 'tailwind.config.*' | xargs grep -H 'fb-bg-brand-dark' || echo \"'fb-bg-brand-dark' is not defined in Tailwind configuration.\"\n\n```\n\nLength of output: 604\n\n</details>\n\n<!-- This is an auto-generated comment by CodeRabbit -->",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/formbricks/formbricks/pull/3229#discussion_r1781837352",
    "filePath": "packages/surveys/src/components/general/AutoCloseProgressBar.tsx",
    "diffHunk": "@@ -7,7 +7,7 @@ export const AutoCloseProgressBar = ({ autoCloseTimeout }: AutoCloseProgressBarP\n     <div className=\"fb-bg-accent-bg fb-h-2 fb-w-full fb-overflow-hidden fb-rounded-full\">\n       <div\n         key={autoCloseTimeout}\n-        className=\"fb-bg-brand fb-z-20 fb-h-2 fb-rounded-full\"\n+        className=\"fb-bg-brand-dark fb-z-20 fb-h-2 fb-rounded-full\"",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-09-30T22:04:18Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2338705942,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "excalidraw/excalidraw",
    "prNumber": 6080,
    "prTitle": "feat: Custom actions",
    "prAuthor": "DanielJGeiger",
    "prLink": "https://github.com/excalidraw/excalidraw/pull/6080",
    "commentAuthor": "valgussev",
    "commentBody": "You might want to plug in `isActionEnabled` check into `_openContextMenu` function in order to make sure disabled by `registerDisableFn` call actions are not added into `ContextMenu`. Otherwise we will see those actions available in the context menu but click won't do anything.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/excalidraw/excalidraw/pull/6080#discussion_r1064032578",
    "filePath": "src/actions/manager.tsx",
    "diffHunk": "@@ -173,13 +235,37 @@ export class ActionManager {\n     return null;\n   };\n \n-  isActionEnabled = (action: Action) => {\n-    const elements = this.getElementsIncludingDeleted();\n+  isActionEnabled = (",
    "line": 68,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-01-07T18:21:55Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1239694649,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "excalidraw/excalidraw",
    "prNumber": 5723,
    "prTitle": "feat: Support labels for arrow 🔥",
    "prAuthor": "ad1992",
    "prLink": "https://github.com/excalidraw/excalidraw/pull/5723",
    "commentAuthor": "dwelle",
    "commentBody": "`prevElementWithCanvas.boundTextElementVersion !== boundTextElementVersion` returns true in most cases due to comparing `undefined` with `null`, making the canvas regenerate every time.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/excalidraw/excalidraw/pull/5723#discussion_r1035190437",
    "filePath": "src/renderer/renderElement.ts",
    "diffHunk": "@@ -656,11 +666,12 @@ const generateElementWithCanvas = (\n     prevElementWithCanvas &&\n     prevElementWithCanvas.canvasZoom !== zoom.value &&\n     !renderConfig?.shouldCacheIgnoreZoom;\n-\n+  const boundTextElementVersion = getBoundTextElement(element)?.version;\n   if (\n     !prevElementWithCanvas ||\n     shouldRegenerateBecauseZoom ||\n-    prevElementWithCanvas.theme !== renderConfig.theme\n+    prevElementWithCanvas.theme !== renderConfig.theme ||\n+    prevElementWithCanvas.boundTextElementVersion !== boundTextElementVersion",
    "line": 66,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 188353013,
        "node_id": "REA_lATODcka_M49s8Clzgs6CfU",
        "user": {
          "login": "ad1992",
          "id": 11256141,
          "node_id": "MDQ6VXNlcjExMjU2MTQx",
          "avatar_url": "https://avatars.githubusercontent.com/u/11256141?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/ad1992",
          "html_url": "https://github.com/ad1992",
          "followers_url": "https://api.github.com/users/ad1992/followers",
          "following_url": "https://api.github.com/users/ad1992/following{/other_user}",
          "gists_url": "https://api.github.com/users/ad1992/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/ad1992/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/ad1992/subscriptions",
          "organizations_url": "https://api.github.com/users/ad1992/orgs",
          "repos_url": "https://api.github.com/users/ad1992/repos",
          "events_url": "https://api.github.com/users/ad1992/events{/privacy}",
          "received_events_url": "https://api.github.com/users/ad1992/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2022-12-01T08:00:36Z"
      }
    ],
    "timestamp": "2022-11-29T19:25:01Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1198217208,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "excalidraw/excalidraw",
    "prNumber": 96,
    "prTitle": "Z-index",
    "prAuthor": "paulomenezes",
    "prLink": "https://github.com/excalidraw/excalidraw/pull/96",
    "commentAuthor": "vjeux",
    "commentBody": "This is the problem you described. If you have two elements selected [A, B], then you're going to push them in the reverse order [B, A]. So they will be \"swapped\"",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/excalidraw/excalidraw/pull/96#discussion_r363016292",
    "filePath": "src/index.tsx",
    "diffHunk": "@@ -721,6 +739,39 @@ class App extends React.Component<{}, AppState> {\n     }\n   };\n \n+  private deleteSelectedElements = () => {\n+    deleteSelectedElements();\n+    this.forceUpdate();\n+  };\n+\n+  private moveToFront = () => {\n+    const elementsWithIndexes = getSelectedElementsWithIndexes();\n+\n+    elementsWithIndexes.forEach(elementWithIndex => {\n+      elements.splice(elementWithIndex.index, 1);\n+    });\n+\n+    elementsWithIndexes.forEach(elementWithIndex => {\n+      elements.push(elementWithIndex.element);\n+    });\n+\n+    this.forceUpdate();\n+  };\n+\n+  private sendToBack = () => {\n+    const elementsWithIndexes = getSelectedElementsWithIndexes();\n+\n+    elementsWithIndexes.forEach(elementWithIndex => {\n+      elements.splice(elementWithIndex.index, 1);\n+    });\n+\n+    elementsWithIndexes.forEach(elementWithIndex => {\n+      elements.splice(0, 0, elementWithIndex.element);",
    "line": 67,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 59036665,
        "node_id": "MDMyOlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudFJlYWN0aW9uNTkwMzY2NjU=",
        "user": {
          "login": "paulomenezes",
          "id": 10564179,
          "node_id": "MDQ6VXNlcjEwNTY0MTc5",
          "avatar_url": "https://avatars.githubusercontent.com/u/10564179?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/paulomenezes",
          "html_url": "https://github.com/paulomenezes",
          "followers_url": "https://api.github.com/users/paulomenezes/followers",
          "following_url": "https://api.github.com/users/paulomenezes/following{/other_user}",
          "gists_url": "https://api.github.com/users/paulomenezes/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/paulomenezes/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/paulomenezes/subscriptions",
          "organizations_url": "https://api.github.com/users/paulomenezes/orgs",
          "repos_url": "https://api.github.com/users/paulomenezes/repos",
          "events_url": "https://api.github.com/users/paulomenezes/events{/privacy}",
          "received_events_url": "https://api.github.com/users/paulomenezes/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2020-01-04T04:58:18Z"
      }
    ],
    "timestamp": "2020-01-04T04:55:24Z",
    "isReviewComment": true,
    "pullRequestReviewId": 338337727,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "apollographql/apollo-client",
    "prNumber": 9697,
    "prTitle": "Add export specification",
    "prAuthor": "tobiasdiez",
    "prLink": "https://github.com/apollographql/apollo-client/pull/9697",
    "commentAuthor": "rschristian",
    "commentBody": "Without `\"type\": \"module\"` set, `.js` is interpreted as CJS, not ESM. You need to use `.mjs` to refer to ESM in a CJS package (which is the default).",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/apollographql/apollo-client/pull/9697#discussion_r1140963442",
    "filePath": "package.json",
    "diffHunk": "@@ -16,6 +16,23 @@\n   \"main\": \"./dist/main.cjs\",\n   \"module\": \"./dist/index.js\",\n   \"types\": \"./dist/index.d.ts\",\n+  \"exports\": {\n+    \".\": {\n+      \"import\": \"./dist/index.js\",",
    "line": 6,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-03-18T07:52:37Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1346945601,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "apollographql/apollo-client",
    "prNumber": 9407,
    "prTitle": "POC reproduction of Issue #9204",
    "prAuthor": "jamesopti",
    "prLink": "https://github.com/apollographql/apollo-client/pull/9407",
    "commentAuthor": "benjamn",
    "commentBody": "One fun bug: this `useMemo` works great as long as `options` is undefined (just `useQuery(query)`), but as soon as you call `useQuery(query, {...})` with options, that's a fresh object for `useMemo`, so `watchQueryOptions` gets regenerated with every `useMemo` call.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/apollographql/apollo-client/pull/9407#discussion_r824234462",
    "filePath": "src/react/hooks/useQuery.ts",
    "diffHunk": "@@ -29,9 +29,12 @@ export function useQuery<\n   const context = useContext(getApolloContext());\n   const client = useApolloClient(options?.client);\n   const defaultWatchQueryOptions = client.defaultOptions.watchQuery;\n+  const watchQueryOptions = useMemo(\n+    () => createWatchQueryOptions(query, options, defaultWatchQueryOptions),\n+    [query, options, defaultWatchQueryOptions]\n+  )",
    "line": 7,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-03-10T22:39:54Z",
    "isReviewComment": true,
    "pullRequestReviewId": 906566346,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "wagmi-dev/wagmi",
    "prNumber": 1335,
    "prTitle": "fix: use `eth_accounts` for `getSigner` on InjectedConnector",
    "prAuthor": "jxom",
    "prLink": "https://github.com/wevm/wagmi/pull/1335",
    "commentAuthor": "tmm",
    "commentBody": "Need to call `eth_requestAccounts` for cases where:\r\n- `UNSTABLE_shimOnConnectSelectAccount` is `false`\r\n- `UNSTABLE_shimOnConnectSelectAccount` is `true` and account isn't connected (because `wallet_requestPermissions` is never called).",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/wevm/wagmi/pull/1335#discussion_r1028344002",
    "filePath": "packages/core/src/connectors/metaMask.ts",
    "diffHunk": "@@ -61,25 +64,28 @@ export class MetaMaskConnector extends InjectedConnector {\n \n       // Attempt to show wallet select prompt with `wallet_requestPermissions` when\n       // `shimDisconnect` is active and account is in disconnected state (flag in storage)\n+      let account: Address | null = null\n       if (\n         this.#UNSTABLE_shimOnConnectSelectAccount &&\n         this.options?.shimDisconnect &&\n         !getClient().storage?.getItem(this.shimDisconnectKey)\n       ) {\n-        const accounts = await provider\n-          .request({\n-            method: 'eth_accounts',\n-          })\n-          .catch(() => [])\n-        const isConnected = !!accounts[0]\n+        account = await this.getAccount().catch(() => null)\n+        const isConnected = !!account\n         if (isConnected)\n           await provider.request({\n             method: 'wallet_requestPermissions',\n             params: [{ eth_accounts: {} }],\n           })\n       }\n \n-      const account = await this.getAccount()\n+      if (!account) {\n+        const accounts = await provider.request({\n+          method: 'eth_requestAccounts',\n+        })\n+        account = getAddress(accounts[0] as string)\n+      }",
    "line": 38,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-11-21T17:31:12Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1188688240,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "drizzle-team/drizzle-orm",
    "prNumber": 3005,
    "prTitle": "Drizzle-kit/views",
    "prAuthor": "AleksandrSherman",
    "prLink": "https://github.com/drizzle-team/drizzle-orm/pull/3005",
    "commentAuthor": "ps-george",
    "commentBody": "This regex breaks if I have any views in my database that are defined on more than one line or somewhat complex e.g. with a CTE:\r\n\r\n```sql\r\nCREATE VIEW latest_user_logs AS WITH ranked_logs AS ( SELECT\r\n        ul.id,\r\n        ul.user_id,\r\n        ul.entry,\r\n        ul.dt_timestamp,\r\n        date(datetime(dt_timestamp, 'unixepoch')) AS log_date,\r\n        ROW_NUMBER() OVER (\r\n            PARTITION BY ul.user_id, ul.type, date(datetime(dt_timestamp, 'unixepoch'))\r\n            ORDER BY ul.dt_created DESC\r\n        ) AS rn\r\n    FROM user_logs ul\r\n)\r\nSELECT id, user_id, entry, log_date, dt_timestamp\r\nFROM ranked_logs\r\nWHERE rn = 1\r\nORDER BY log_date DESC;\r\n```\r\n\r\nI got a very dubious error even in verbose mode that was hard to track down:\r\n\r\n```\r\n> drizzle-kit push --verbose\r\n\r\nNo config path provided, using default 'drizzle.config.ts'\r\n[⣷] Pulling schema from database...\r\nCould not process view\r\n```\r\n\r\nAt the very least here we could put a better log message, that includes the view name and sql:\r\n\r\n```javascript\r\n\t\tif (!match) {\r\n\t\t\tconsole.log(`Could not process view, ${viewName}`);\r\n\t\t\tconsole.debug(`${viewName} SQL`, sql);\r\n\t\t\tprocess.exit(1);\r\n\t\t}\r\n```\r\n\r\nBut it would be good to fix the regex entirely.\r\n\r\nWorkaround at the moment is I changed my view to a subquery and put it all on one line.",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/drizzle-team/drizzle-orm/pull/3005#discussion_r1867767595",
    "filePath": "drizzle-kit/src/serializer/sqliteSerializer.ts",
    "diffHunk": "@@ -696,10 +783,48 @@ WHERE\n \t\tprogressCallback('enums', 0, 'done');\n \t}\n \n+\tconst views = await db.query(\n+\t\t`SELECT name AS view_name, sql AS sql FROM sqlite_master WHERE type = 'view';`,\n+\t);\n+\n+\tviewsCount = views.length;\n+\n+\tif (progressCallback) {\n+\t\tprogressCallback('views', viewsCount, 'fetching');\n+\t}\n+\tfor (const view of views) {\n+\t\tconst viewName = view['view_name'];\n+\t\tconst sql = view['sql'];\n+\n+\t\tconst regex = new RegExp(`\\\\bAS\\\\b\\\\s+(SELECT.+)$`, 'i');\n+\t\tconst match = sql.match(regex);\n+\n+\t\tif (!match) {\n+\t\t\tconsole.log('Could not process view');\n+\t\t\tprocess.exit(1);\n+\t\t}",
    "line": 184,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-12-03T13:56:55Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2475755510,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "drizzle-team/drizzle-orm",
    "prNumber": 449,
    "prTitle": "[MYSQL] Full text search (match against)",
    "prAuthor": "corbanvilla",
    "prLink": "https://github.com/drizzle-team/drizzle-orm/pull/449",
    "commentAuthor": "Angelelz",
    "commentBody": "This line is passing true to the unique parameter. Yet, in the IndexBuilder constructor it throws an error if fulltext and unique are both true. If I'm understanding this correctly, there is a mistake.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/drizzle-team/drizzle-orm/pull/449#discussion_r1290879273",
    "filePath": "drizzle-orm/src/mysql-core/indexes.ts",
    "diffHunk": "@@ -99,3 +109,7 @@ export function index(name: string): IndexBuilderOn {\n export function uniqueIndex(name: string): IndexBuilderOn {\n \treturn new IndexBuilderOn(name, true);\n }\n+\n+export function fulltextIndex(name: string): IndexBuilderOn {\n+\treturn new IndexBuilderOn(name, true);",
    "line": 36,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-08-11T04:22:35Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1572981274,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "mantinedev/mantine",
    "prNumber": 5786,
    "prTitle": "[@mantine/dates] Fix: minimum-date is not in current month and value is not provided",
    "prAuthor": "msv96",
    "prLink": "https://github.com/mantinedev/mantine/pull/5786",
    "commentAuthor": "rilrom",
    "commentBody": "When `clearable: true` and you remove a selected value, visually it's removed from the UI however `_date` still gets set to the `minDate` instead of `null`.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/mantinedev/mantine/pull/5786#discussion_r1499199528",
    "filePath": "packages/@mantine/dates/src/components/DateInput/DateInput.tsx",
    "diffHunk": "@@ -167,7 +167,7 @@ export const DateInput = factory<DateInputFactory>((_props, ref) => {\n \n   useEffect(() => {\n     if (controlled) {\n-      setDate(value!);\n+      setDate(value ? value! : minDate!);",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-02-22T12:54:32Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1895785852,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "mantinedev/mantine",
    "prNumber": 412,
    "prTitle": "[@mantine/core] MultiSelect - fix dropdown and clearable issues",
    "prAuthor": "achmurali",
    "prLink": "https://github.com/mantinedev/mantine/pull/412",
    "commentAuthor": "rtivital",
    "commentBody": "This won't work for controlled input – dropdown will open when the value is set externally:\r\n\r\n```tsx\r\nimport { useState } from 'react';\r\nimport { MultiSelect } from '@mantine/core';\r\n\r\nfunction Demo() {\r\n  const [value, setValue] = useState(null);\r\n  return (\r\n    <div>\r\n      <MultiSelect data={['hello']} value={value} onChange={setValue} />\r\n      <button type=\"button\" onClick={() => setValue(['hello', 'there'])}>set value</button>\r\n    </div>\r\n  )\r\n}\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/mantinedev/mantine/pull/412#discussion_r748180796",
    "filePath": "src/mantine-core/src/components/MultiSelect/MultiSelect.tsx",
    "diffHunk": "@@ -313,6 +313,11 @@ export const MultiSelect = forwardRef<HTMLInputElement, MultiSelectProps>(\n       );\n     }, [searchValue]);\n \n+    useDidUpdate(() => {\n+      //using greater than equal to take into account creatable type.\n+      if (!disabled && _value.length >= data.length) setDropdownOpened(false);",
    "line": 6,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2021-11-12T11:25:18Z",
    "isReviewComment": true,
    "pullRequestReviewId": 804689840,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "xyflow/react-flow",
    "prNumber": 2877,
    "prTitle": "feat(reactflow): add isValidConnection prop ",
    "prAuthor": "moklick",
    "prLink": "https://github.com/xyflow/xyflow/pull/2877",
    "commentAuthor": "danielgek",
    "commentBody": "@moklick this change causes a bug for folks using a redux store:\r\n```\r\nindex.js:2820 Uncaught TypeError: Cannot add property selected, object is not extensible\r\n    at index.js:2820:18\r\n    at Array.reduce (<anonymous>)\r\n    at getSelectionChanges (index.js:2817:18)\r\n    at addSelectedEdges (index.js:3544:28)\r\n    at onEdgeClick (index.js:1210:17)\r\n    at HTMLUnknownElement.callCallback2 (react-dom.development.js:4164:14)\r\n    at Object.invokeGuardedCallbackDev (react-dom.development.js:4213:16)\r\n    at invokeGuardedCallback (react-dom.development.js:4277:31)\r\n    at invokeGuardedCallbackAndCatchFirstError (react-dom.development.js:4291:25)\r\n    at executeDispatch (react-dom.development.js:9041:3)\r\n```\r\n\r\nReverting this set state fixes the problem but i'm not sure if impacts other features implemented on this pr, i can summit a pr reverting to the old way ",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/xyflow/xyflow/pull/2877#discussion_r1135900418",
    "filePath": "packages/core/src/store/index.ts",
    "diffHunk": "@@ -33,8 +33,8 @@ const createRFStore = () =>\n       return Array.from(get().nodeInternals.values());\n     },\n     setEdges: (edges: Edge[]) => {\n-      const { defaultEdgeOptions = {} } = get();\n-      set({ edges: edges.map((e) => ({ ...defaultEdgeOptions, ...e })) });",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-03-14T16:54:25Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1339795598,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "xyflow/react-flow",
    "prNumber": 568,
    "prTitle": "updates to allow for drag and drop onto FlowRenderer",
    "prAuthor": "jasonpul",
    "prLink": "https://github.com/xyflow/xyflow/pull/568",
    "commentAuthor": "MadSciencist",
    "commentBody": "The project() function should be called from OnLoadParams -  otherwise it doesn't work when using ReactFlowProvider.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/xyflow/xyflow/pull/568#discussion_r508484856",
    "filePath": "example/src/DragAndDrop/index.js",
    "diffHunk": "@@ -0,0 +1,64 @@\n+import React, { useState } from 'react';\n+import ReactFlow, { removeElements, addEdge, Background, project } from 'react-flow-renderer';\n+import NodeLibrary from './NodeLibrary'\n+import {v4 as uuid} from 'uuid'\n+import './index.css'\n+\n+\n+\n+const onLoad = (reactFlowInstance) => console.log('flow loaded:', reactFlowInstance);\n+const onNodeDragStop = (event, node) => console.log('drag stop', node);\n+const onElementClick = (event, element) => console.log('click', element);\n+\n+const nodeStore = {\n+  'Node1': (position) => ({ id: uuid().toString(), type: 'input', data: { label: 'Node 1' }, position: position }),\n+  'Node2': (position) => ({ id: uuid().toString(), data: { label: 'Node 2' }, position: position }),\n+}\n+\n+const initialElements = [\n+  { id: '1', type: 'input', data: { label: 'Node 1' }, position: { x: 250, y: 5 } },\n+  { id: '2', data: { label: 'Node 2' }, position: { x: 100, y: 100 } },\n+  { id: 'e1-2', source: '1', target: '2', animated: true },\n+];\n+\n+const DragAndDrop = () => {\n+  const [elements, setElements] = useState(initialElements);\n+\n+  const onElementsRemove = (elementsToRemove) => setElements((els) => removeElements(elementsToRemove, els));\n+  const onConnect = (params) => setElements((els) => addEdge(params, els));\n+\n+  const handleDrop = (event) => {\n+    const data = JSON.parse(event.dataTransfer.getData('dragItem'))\n+    if (data) {\n+      const mouseX = event.clientX\n+      const mouseY = event.clientY\n+      const position = project({x: mouseX, y: mouseY})",
    "line": 35,
    "reactionCount": 1,
    "reactions": [
      {
        "id": 88257080,
        "node_id": "MDMyOlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudFJlYWN0aW9uODgyNTcwODA=",
        "user": {
          "login": "TheOnlyArtz",
          "id": 30025874,
          "node_id": "MDQ6VXNlcjMwMDI1ODc0",
          "avatar_url": "https://avatars.githubusercontent.com/u/30025874?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/TheOnlyArtz",
          "html_url": "https://github.com/TheOnlyArtz",
          "followers_url": "https://api.github.com/users/TheOnlyArtz/followers",
          "following_url": "https://api.github.com/users/TheOnlyArtz/following{/other_user}",
          "gists_url": "https://api.github.com/users/TheOnlyArtz/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/TheOnlyArtz/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/TheOnlyArtz/subscriptions",
          "organizations_url": "https://api.github.com/users/TheOnlyArtz/orgs",
          "repos_url": "https://api.github.com/users/TheOnlyArtz/repos",
          "events_url": "https://api.github.com/users/TheOnlyArtz/events{/privacy}",
          "received_events_url": "https://api.github.com/users/TheOnlyArtz/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2020-10-21T07:46:48Z"
      }
    ],
    "timestamp": "2020-10-20T13:07:30Z",
    "isReviewComment": true,
    "pullRequestReviewId": 512686584,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "jaredpalmer/formik",
    "prNumber": 1398,
    "prTitle": "Change setFieldValue to return a Promise #529",
    "prAuthor": "nzyoni",
    "prLink": "https://github.com/jaredpalmer/formik/pull/1398",
    "commentAuthor": "hertzg",
    "commentBody": "```suggestion\r\n                .then(() => resolve())\r\n```\r\nTo make sure the promise returned resolves with the same result in all cases.\r\nThis introduces inconsistency in resolved values as the `runValidations` will resolve to `FormikErrors<Values>` which will be passed as a result of our promise while in other cases below our promise is resolved with no value (just `resolve()`).",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/jaredpalmer/formik/pull/1398#discussion_r279120453",
    "filePath": "src/Formik.tsx",
    "diffHunk": "@@ -384,20 +384,28 @@ export class Formik<Values = FormikValues> extends React.Component<\n     value: any,\n     shouldValidate: boolean = true\n   ) => {\n-    if (this.didMount) {\n-      // Set form field by name\n-      this.setState(\n-        prevState => ({\n-          ...prevState,\n-          values: setIn(prevState.values, field, value),\n-        }),\n-        () => {\n-          if (this.props.validateOnChange && shouldValidate) {\n-            this.runValidations(this.state.values);\n+    return new Promise((resolve, reject) => {\n+      if (this.didMount) {\n+        // Set form field by name\n+        this.setState(\n+          prevState => ({\n+            ...prevState,\n+            values: setIn(prevState.values, field, value),\n+          }),\n+          () => {\n+            if (this.props.validateOnChange && shouldValidate) {\n+              this.runValidations(this.state.values)\n+                .then(resolve)",
    "line": 25,
    "reactionCount": 2,
    "reactions": [
      {
        "id": 46383159,
        "node_id": "MDMyOlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudFJlYWN0aW9uNDYzODMxNTk=",
        "user": {
          "login": "konojunya",
          "id": 12035578,
          "node_id": "MDQ6VXNlcjEyMDM1NTc4",
          "avatar_url": "https://avatars.githubusercontent.com/u/12035578?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/konojunya",
          "html_url": "https://github.com/konojunya",
          "followers_url": "https://api.github.com/users/konojunya/followers",
          "following_url": "https://api.github.com/users/konojunya/following{/other_user}",
          "gists_url": "https://api.github.com/users/konojunya/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/konojunya/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/konojunya/subscriptions",
          "organizations_url": "https://api.github.com/users/konojunya/orgs",
          "repos_url": "https://api.github.com/users/konojunya/repos",
          "events_url": "https://api.github.com/users/konojunya/events{/privacy}",
          "received_events_url": "https://api.github.com/users/konojunya/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2019-07-11T06:18:28Z"
      },
      {
        "id": 52758763,
        "node_id": "MDMyOlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudFJlYWN0aW9uNTI3NTg3NjM=",
        "user": {
          "login": "sroze",
          "id": 804625,
          "node_id": "MDQ6VXNlcjgwNDYyNQ==",
          "avatar_url": "https://avatars.githubusercontent.com/u/804625?v=4",
          "gravatar_id": "",
          "url": "https://api.github.com/users/sroze",
          "html_url": "https://github.com/sroze",
          "followers_url": "https://api.github.com/users/sroze/followers",
          "following_url": "https://api.github.com/users/sroze/following{/other_user}",
          "gists_url": "https://api.github.com/users/sroze/gists{/gist_id}",
          "starred_url": "https://api.github.com/users/sroze/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/sroze/subscriptions",
          "organizations_url": "https://api.github.com/users/sroze/orgs",
          "repos_url": "https://api.github.com/users/sroze/repos",
          "events_url": "https://api.github.com/users/sroze/events{/privacy}",
          "received_events_url": "https://api.github.com/users/sroze/received_events",
          "type": "User",
          "user_view_type": "public",
          "site_admin": false
        },
        "content": "+1",
        "created_at": "2019-10-09T09:45:49Z"
      }
    ],
    "timestamp": "2019-04-26T22:25:18Z",
    "isReviewComment": true,
    "pullRequestReviewId": 231381737,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "emotion-js/emotion",
    "prNumber": 1692,
    "prTitle": "fix(core / styled): fix wrap the display name in styled and withEmotionCache",
    "prAuthor": "zthxxx",
    "prLink": "https://github.com/emotion-js/emotion/pull/1692",
    "commentAuthor": "Andarist",
    "commentBody": "there is no way for the `Component` to have a `.displayName` as it's always the anonymous function ",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/emotion-js/emotion/pull/1692#discussion_r357968719",
    "filePath": "packages/styled-base/src/index.js",
    "diffHunk": "@@ -43,6 +43,20 @@ let createStyled: CreateStyled = (tag: any, options?: StyledOptions) => {\n   const isReal = tag.__emotion_real === tag\n   const baseTag = (isReal && tag.__emotion_base) || tag\n \n+  const displayName =\n+    identifierName !== undefined\n+      ? identifierName\n+      : `Styled(${\n+          typeof baseTag === 'string'\n+            ? baseTag\n+            : baseTag.displayName || baseTag.name || 'Component'\n+        })`\n+\n+  const injectDisplayName = Component => {\n+    Component.displayName = Component.displayName || displayName",
    "line": 14,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2019-12-15T10:29:41Z",
    "isReviewComment": true,
    "pullRequestReviewId": 332255530,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "react-hook-form/react-hook-form",
    "prNumber": 2054,
    "prTitle": "fix #2050 update dirty when input unmount",
    "prAuthor": "bluebill1049",
    "prLink": "https://github.com/react-hook-form/react-hook-form/pull/2054",
    "commentAuthor": "keiya01",
    "commentBody": "@bluebill1049 \r\nI'm sorry if I am wrong.\r\nI think it should `!isEmptyObject(dirtyFieldsRef.current)` because this code return true when `dirtyFieldsRef` is empty.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/react-hook-form/react-hook-form/pull/2054#discussion_r449724845",
    "filePath": "src/useForm.ts",
    "diffHunk": "@@ -608,8 +608,10 @@ export function useForm<\n \n           if (\n             readFormStateRef.current.isValid ||\n-            readFormStateRef.current.touched\n+            readFormStateRef.current.touched ||\n+            readFormStateRef.current.isDirty\n           ) {\n+            isDirtyRef.current = isEmptyObject(dirtyFieldsRef.current);",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2020-07-04T00:49:50Z",
    "isReviewComment": true,
    "pullRequestReviewId": 442578302,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "react-hook-form/react-hook-form",
    "prNumber": 666,
    "prTitle": "💪V4",
    "prAuthor": "bluebill1049",
    "prLink": "https://github.com/react-hook-form/react-hook-form/pull/666",
    "commentAuthor": "AhmedAymanM",
    "commentBody": "what I get from the test message is that `isReValidateOnSubmit` should be `false` and `isReValidateOnBlur` should be `true`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/react-hook-form/react-hook-form/pull/666#discussion_r361102481",
    "filePath": "src/logic/skipValidation.test.ts",
    "diffHunk": "@@ -0,0 +1,131 @@\n+import skipValidation from './skipValidation';\n+\n+describe('should skip validation', () => {\n+  it('when is onSubmit mode and re-validate on Submit', () => {\n+    expect(\n+      skipValidation({\n+        hasError: false,\n+        isBlurEvent: false,\n+        isOnSubmit: true,\n+        isReValidateOnSubmit: true,\n+        isOnBlur: false,\n+        isReValidateOnBlur: false,\n+        isSubmitted: false,\n+      }),\n+    ).toBeTruthy();\n+  });\n+\n+  it('when is onSubmit mode and not submitted yet', () => {\n+    expect(\n+      skipValidation({\n+        hasError: false,\n+        isBlurEvent: false,\n+        isOnSubmit: true,\n+        isReValidateOnSubmit: false,\n+        isOnBlur: false,\n+        isReValidateOnBlur: false,\n+        isSubmitted: false,\n+      }),\n+    ).toBeTruthy();\n+  });\n+\n+  it('when on blur mode, not blur event and error gets clear', () => {\n+    expect(\n+      skipValidation({\n+        hasError: false,\n+        isBlurEvent: false,\n+        isOnSubmit: false,\n+        isReValidateOnSubmit: false,\n+        isOnBlur: true,\n+        isReValidateOnBlur: false,\n+        isSubmitted: false,\n+      }),\n+    ).toBeTruthy();\n+  });\n+\n+  it('when re-validate mode is blur, not blur event and has error ', () => {\n+    expect(\n+      skipValidation({\n+        hasError: true,\n+        isBlurEvent: false,\n+        isOnSubmit: false,\n+        isReValidateOnSubmit: true,\n+        isOnBlur: false,\n+        isReValidateOnBlur: false,",
    "line": 54,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2019-12-24T08:32:00Z",
    "isReviewComment": true,
    "pullRequestReviewId": 336126537,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "testing-library/react-testing-library",
    "prNumber": 259,
    "prTitle": "fix(TS): add queries typings",
    "prAuthor": "chochihim",
    "prLink": "https://github.com/testing-library/react-testing-library/pull/259",
    "commentAuthor": "joeporpeglia",
    "commentBody": "@chochihim @kentcdodds heads up, the `...args` expression here causes TS builds to fail when `--noImplicitAny` is set.\r\n\r\n```\r\nType error: Rest parameter 'args' implicitly has an 'any[]' type.  TS7019\r\n\r\n    4 |\r\n    5 | interface Query extends Function {\r\n  > 6 |   (container: HTMLElement, ...args): HTMLElement[] | HTMLElement | null\r\n      |                            ^\r\n    7 | }\r\n    8 |\r\n    9 | interface Queries {\r\n```",
    "commentBodyIncludesCodeSnippet": true,
    "commentLink": "https://github.com/testing-library/react-testing-library/pull/259#discussion_r245386319",
    "filePath": "typings/index.d.ts",
    "diffHunk": "@@ -1,31 +1,44 @@\n-import {getQueriesForElement} from 'dom-testing-library'\n+import {queries, BoundFunction} from 'dom-testing-library'\n \n export * from 'dom-testing-library'\n \n-type GetsAndQueries = ReturnType<typeof getQueriesForElement>\n+interface Query extends Function {\n+  (container: HTMLElement, ...args): HTMLElement[] | HTMLElement | null",
    "line": 8,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2019-01-04T18:49:29Z",
    "isReviewComment": true,
    "pullRequestReviewId": 189483935,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "mongodb/mongo",
    "prNumber": 1071,
    "prTitle": "SERVER-22902：forbid autoIndexId option when createCollection",
    "prAuthor": "zydcom",
    "prLink": "https://github.com/mongodb/mongo/pull/1071",
    "commentAuthor": "milkie",
    "commentBody": "This error message is incorrect.  This code applies to all modes of operation, not just \"replica set\".\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/mongodb/mongo/pull/1071#discussion_r66432233",
    "filePath": "src/mongo/db/dbcommands.cpp",
    "diffHunk": "@@ -528,10 +528,10 @@ class CmdCreate : public Command {\n                      string& errmsg,\n                      BSONObjBuilder& result) {\n         if (cmdObj.hasField(\"autoIndexId\")) {\n-            const char* deprecationWarning =\n-                \"the autoIndexId option is deprecated and will be removed in a future release\";\n-            warning() << deprecationWarning;\n-            result.append(\"note\", deprecationWarning);\n+            if (!cmdObj[\"autoIndexId\"].trueValue()) {\n+                errmsg = \"autoIndexId option cannot be false in replica set\";",
    "line": 9,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2016-06-09T12:37:07Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "mongodb/mongo",
    "prNumber": 205,
    "prTitle": "SERVER-4345 Add support processing fifo files in mongorestore",
    "prAuthor": "azat",
    "prLink": "https://github.com/mongodb/mongo/pull/205",
    "commentAuthor": "amschwerin",
    "commentBody": "In the event that the file is truncated, the old code would alert for failure in the event that the input file was truncated, and did not contain an even multiple of 4 bytes.  This change will silently stop processing, which is a behavior change.\n",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/mongodb/mongo/pull/205#discussion_r694609",
    "filePath": "src/mongo/tools/tool.cpp",
    "diffHunk": "@@ -485,11 +490,21 @@\n         boost::scoped_array<char> buf_holder(new char[BUF_SIZE]);\n         char * buf = buf_holder.get();\n \n-        ProgressMeter m( fileLength );\n-        m.setUnits( \"bytes\" );\n+        // no progress is available for FIFO\n+        // only for regular files\n+        boost::scoped_ptr<ProgressMeter> m(NULL);\n+        if (!fifo) {\n+            m.reset(new ProgressMeter( fileLength ));\n+            // boost::scoped_ptr<ProgressMeter> m( fileLength );\n+            m->setUnits( \"bytes\" );\n+        }\n \n-        while ( read < fileLength ) {\n+        while ( true ) {\n             size_t amt = fread(buf, 1, 4, file);\n+            // end of fifo/file\n+            if ( feof(file) ) {\n+                break;",
    "line": 63,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2012-04-17T13:45:20Z",
    "isReviewComment": true,
    "pullRequestReviewId": null,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "redis/redis",
    "prNumber": 12921,
    "prTitle": "Prevent nodes with invalid IDs from being propagated through gossip",
    "prAuthor": "BCathcart",
    "prLink": "https://github.com/redis/redis/pull/12921",
    "commentAuthor": "madolson",
    "commentBody": "I realized something after merging this. Sender could be NULL if the node is not known, one of the reasons this could happen is the sender is malicious, so we need to need to add NULL checks around sender here.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/redis/redis/pull/12921#discussion_r1462674339",
    "filePath": "src/cluster_legacy.c",
    "diffHunk": "@@ -2051,6 +2086,14 @@ void clusterProcessGossipSection(clusterMsg *hdr, clusterLink *link) {\n     clusterMsgDataGossip *g = (clusterMsgDataGossip*) hdr->data.ping.gossip;\n     clusterNode *sender = link->node ? link->node : clusterLookupNode(hdr->sender, CLUSTER_NAMELEN);\n \n+    /* Abort if the gossip contains invalid node IDs to avoid adding incorrect information to\n+     * the nodes dictionary. An invalid ID indicates memory corruption on the sender side. */\n+    int invalid_ids = verifyGossipSectionNodeIds(g, count);\n+    if (invalid_ids) {\n+        serverLog(LL_WARNING, \"Node %.40s (%s) gossiped %d nodes with invalid IDs.\", sender->name, sender->human_nodename, invalid_ids);",
    "line": 50,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-01-23T03:08:23Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1837785394,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "redis/redis",
    "prNumber": 11102,
    "prTitle": "Fix overflow in redis-benchmark",
    "prAuthor": "tezc",
    "prLink": "https://github.com/redis/redis/pull/11102",
    "commentAuthor": "judeng",
    "commentBody": "This is a subtle overflow bug, I see other `ustime` in redis-cli redis-server has been fixed.\r\nI'm wondering why redis tools implement some common functions repeatedly...",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/redis/redis/pull/11102#discussion_r943305359",
    "filePath": "src/redis-benchmark.c",
    "diffHunk": "@@ -229,19 +229,13 @@ static long long ustime(void) {\n     long long ust;\n \n     gettimeofday(&tv, NULL);\n-    ust = ((long)tv.tv_sec)*1000000;\n+    ust = ((long long)tv.tv_sec)*1000000;",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-08-11T09:55:39Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1069463324,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "redis/redis",
    "prNumber": 10681,
    "prTitle": "Dedicated member to hold RedisModuleCommand",
    "prAuthor": "guybe7",
    "prLink": "https://github.com/redis/redis/pull/10681",
    "commentAuthor": "oranagra",
    "commentBody": "this is actually a bug fix?\r\nfor SPUBLISH, it previously it used to return `Invalid arguments specified for command` (since `getKeysFromCommandWithSpecs` would return 0), but now it'll return `The command has no key arguments`",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/redis/redis/pull/10681#discussion_r867512005",
    "filePath": "src/server.c",
    "diffHunk": "@@ -4709,7 +4706,7 @@ void getKeysSubcommandImpl(client *c, int with_flags) {\n     if (!cmd) {\n         addReplyError(c,\"Invalid command specified\");\n         return;\n-    } else if (cmd->getkeys_proc == NULL && cmd->key_specs_num == 0) {\n+    } else if (!doesCommandHaveKeys(cmd)) {",
    "line": 19,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-05-08T16:09:21Z",
    "isReviewComment": true,
    "pullRequestReviewId": 965456807,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "redis/redis",
    "prNumber": 10570,
    "prTitle": "Optimize performance for config setting in config.c",
    "prAuthor": "hwware",
    "prLink": "https://github.com/redis/redis/pull/10570",
    "commentAuthor": "sundb",
    "commentBody": "missing `dictReleaseIterator`?",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/redis/redis/pull/10570#discussion_r848999837",
    "filePath": "src/config.c",
    "diffHunk": "@@ -881,35 +881,33 @@ void configSetCommand(client *c) {\n                 addModuleConfigApply(module_configs_apply, config->privdata);\n             } else if (config->interface.apply) {\n                 /* Check if this apply function is already stored */\n-                int exists = 0;\n-                for (j = 0; apply_fns[j] != NULL && j <= i; j++) {\n-                    if (apply_fns[j] == config->interface.apply) {\n-                        exists = 1;\n-                        break;\n-                    }\n-                }\n-                /* Apply function not stored, store it */\n-                if (!exists) {\n-                    apply_fns[j] = config->interface.apply;\n-                    config_map_fns[j] = i;\n+                config_name = sdsnew(config->name);\n+                if (!(dictFind(apply_fns, config_name))) {\n+                    dictAdd(apply_fns, sdsnew(config->name), &config->interface);\n                 }\n+                sdsfree(config_name);\n             }\n         }\n     }\n \n     /* Apply all configs after being set */\n-    for (i = 0; i < config_count && apply_fns[i] != NULL; i++) {\n-        if (!apply_fns[i](&errstr)) {\n-            serverLog(LL_WARNING, \"Failed applying new configuration. Possibly related to new %s setting. Restoring previous settings.\", config_names[config_map_fns[i]]);\n-            restoreBackupConfig(set_configs_dict, old_values_dict, config_count, apply_fns, NULL);\n-            err_arg_name = config_names[config_map_fns[i]];\n+    di = dictGetIterator(apply_fns);\n+    while ((de = dictNext(di)) != NULL) {\n+        sds config_name = dictGetKey(de);\n+        typeInterface *apply_fn_interface = dictGetVal(de);\n+        if (!apply_fn_interface->apply(&errstr)) {\n+            serverLog(LL_WARNING, \"Failed applying new configuration. Possibly related to new %s setting. Restoring previous settings.\", config_name);\n+            restoreBackupConfig(set_configs, old_values, apply_fns, NULL);\n+            err_arg_name = config_name;\n             goto err;",
    "line": 253,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2022-04-13T01:49:22Z",
    "isReviewComment": true,
    "pullRequestReviewId": 940314314,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "flutter/flutter",
    "prNumber": 152621,
    "prTitle": "Fixed [DropdownMenu] providing a focusNode, the text cursor is lost after disabling the widget and enabling it again, fixes #152478",
    "prAuthor": "D-extremity",
    "prLink": "https://github.com/flutter/flutter/pull/152621",
    "commentAuthor": "QuncCccccc",
    "commentBody": "If the focusNode initially set `canRequestFocus` to false, then currently the dropdown menu should not be able to get focused, but this change here may cause a breaking change. It seems when we enable dropdown menu again, `widget.focusNode.canRequestFocus` then return false and cause the issue.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/flutter/flutter/pull/152621#discussion_r1726579471",
    "filePath": "packages/flutter/lib/src/material/dropdown_menu.dart",
    "diffHunk": "@@ -563,7 +563,7 @@ class _DropdownMenuState<T> extends State<DropdownMenu<T>> {\n   }\n \n   bool canRequestFocus() {\n-    return widget.focusNode?.canRequestFocus ?? widget.requestFocusOnTap\n+    return widget.requestFocusOnTap",
    "line": 5,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2024-08-22T08:18:27Z",
    "isReviewComment": true,
    "pullRequestReviewId": 2253818185,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  },
  {
    "repo": "flutter/flutter",
    "prNumber": 139706,
    "prTitle": "Don't send images to Gold on release branches",
    "prAuthor": "Piinks",
    "prLink": "https://github.com/flutter/flutter/pull/139706",
    "commentAuthor": "Hixie",
    "commentBody": "this doesn't seem right? it makes us use the local file comparator on the main branch on Cirrus, for example, whereas before we used the skipping one.",
    "commentBodyIncludesCodeSnippet": false,
    "commentLink": "https://github.com/flutter/flutter/pull/139706#discussion_r1421071649",
    "filePath": "packages/flutter_goldens/lib/flutter_goldens.dart",
    "diffHunk": "@@ -413,9 +418,11 @@ class FlutterSkippingFileComparator extends FlutterGoldenFileComparator {\n   /// If we are in a CI environment, LUCI or Cirrus, but are not using the other\n   /// comparators, we skip.\n   static bool isAvailableForEnvironment(Platform platform) {\n-    return platform.environment.containsKey('SWARMING_TASK_ID')\n+    return (platform.environment.containsKey('SWARMING_TASK_ID')\n       // Some builds are still being run on Cirrus, we should skip these.\n-      || platform.environment.containsKey('CIRRUS_CI');\n+      || platform.environment.containsKey('CIRRUS_CI'))\n+      // If we are in CI, skip on branches that are not main.\n+      && !_kMainBranch.hasMatch(platform.environment['GIT_BRANCH'] ?? '');",
    "line": 40,
    "reactionCount": 0,
    "reactions": [],
    "timestamp": "2023-12-08T22:21:30Z",
    "isReviewComment": true,
    "pullRequestReviewId": 1773243960,
    "LLMReviewed": true,
    "LLMReviewPassed": true,
    "difficultyLevel": "medium"
  }
]