Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtimes aren't updated when updates are pushed to the repository #4

Closed
thomasgouveia opened this issue Apr 27, 2023 · 0 comments · Fixed by #17
Closed

Runtimes aren't updated when updates are pushed to the repository #4

thomasgouveia opened this issue Apr 27, 2023 · 0 comments · Fixed by #17
Assignees
Labels

Comments

@thomasgouveia
Copy link
Member

thomasgouveia commented Apr 27, 2023

Currently, when the registry boot up, it will download the available runtimes into /tmp/morty-runtimes.

See : https://github.com/morty-faas/morty/blob/main/registry/builder/builder.go#L68

This is an issue today, because if the registry is running and if the runtimes repository is updated during this time, we will need to restart the registry to re-download the runtimes.

The idea here is to fix this behavior by adding a mechanism to refresh the runtimes when they are updated.

One way to fix that will be to avoid downloading the runtimes on start, but download the good runtime for each build. This way, we simply ensure that all builds will use the latest version of the runtimes available. It will not impact a lot the performance of each build (depending on the network).

We can use the Subdirectories feature of the go-getter to download a specific folder from a repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants