From 347f39c663e1c038d74baca113cbd9d50aad1e04 Mon Sep 17 00:00:00 2001
From: "Brian J. Cardiff" <bcardiff@gmail.com>
Date: Mon, 29 Jul 2019 14:53:00 -0300
Subject: [PATCH] Annotate return types of abstract methods

---
 src/lib/definition_mixins/argument.cr        | 4 ++--
 src/lib/definition_mixins/option.cr          | 2 +-
 src/lib/definitions/bool_option.cr           | 4 ++--
 src/lib/definitions/handler.cr               | 2 +-
 src/lib/definitions/not_option.cr            | 4 ++--
 src/lib/definitions/string_argument.cr       | 2 +-
 src/lib/definitions/string_array_argument.cr | 2 +-
 src/lib/definitions/string_array_option.cr   | 2 +-
 src/lib/definitions/string_option.cr         | 2 +-
 src/lib/definitions/terminator.cr            | 4 ++--
 src/lib/definitions/unknown.cr               | 4 ++--
 11 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/src/lib/definition_mixins/argument.cr b/src/lib/definition_mixins/argument.cr
index b79b1e6..7bf343c 100644
--- a/src/lib/definition_mixins/argument.cr
+++ b/src/lib/definition_mixins/argument.cr
@@ -6,11 +6,11 @@ module Optarg::DefinitionMixins
       module ArgumentModule
         abstract def visitable?(parser) : Bool
 
-        def completion_length(gen)
+        def completion_length(gen) : Int32
           1
         end
 
-        def completion_max_occurs(gen)
+        def completion_max_occurs(gen) : Int32
           1
         end
       end
diff --git a/src/lib/definition_mixins/option.cr b/src/lib/definition_mixins/option.cr
index f15ad3d..e52b2fe 100644
--- a/src/lib/definition_mixins/option.cr
+++ b/src/lib/definition_mixins/option.cr
@@ -8,7 +8,7 @@ module Optarg::DefinitionMixins
       include ::Optarg::DefinitionMixins::VisitConcatenated
 
       module OptionModule
-        def completion_max_occurs(gen)
+        def completion_max_occurs(gen) : Int32
           1
         end
       end
diff --git a/src/lib/definitions/bool_option.cr b/src/lib/definitions/bool_option.cr
index ba86890..a6f22c4 100644
--- a/src/lib/definitions/bool_option.cr
+++ b/src/lib/definitions/bool_option.cr
@@ -17,11 +17,11 @@ module Optarg::Definitions
       visit parser, name
     end
 
-    def completion_length(gen)
+    def completion_length(gen) : Int32
       1
     end
 
-    def completion_max_occurs(gen)
+    def completion_max_occurs(gen) : Int32
       default_value.get? == true ? 0 : 1
     end
   end
diff --git a/src/lib/definitions/handler.cr b/src/lib/definitions/handler.cr
index e13e92d..6de6f3c 100644
--- a/src/lib/definitions/handler.cr
+++ b/src/lib/definitions/handler.cr
@@ -2,7 +2,7 @@ module Optarg::Definitions
   abstract class Handler < Base
     include DefinitionMixins::Option
 
-    def completion_length(gen)
+    def completion_length(gen) : Int32
       1
     end
   end
diff --git a/src/lib/definitions/not_option.cr b/src/lib/definitions/not_option.cr
index c3cf9f6..795427c 100644
--- a/src/lib/definitions/not_option.cr
+++ b/src/lib/definitions/not_option.cr
@@ -23,11 +23,11 @@ module Optarg::Definitions
       visit parser, name
     end
 
-    def completion_length(gen)
+    def completion_length(gen) : Int32
       1
     end
 
-    def completion_max_occurs(gen)
+    def completion_max_occurs(gen) : Int32
       bool.default_value.get? == true ? 1 : 0
     end
   end
diff --git a/src/lib/definitions/string_argument.cr b/src/lib/definitions/string_argument.cr
index d395274..85f6b6c 100644
--- a/src/lib/definitions/string_argument.cr
+++ b/src/lib/definitions/string_argument.cr
@@ -8,7 +8,7 @@ module Optarg::Definitions
       initialize_scalar_value_argument default: default, required: required, any_of: any_of
     end
 
-    def visitable?(parser)
+    def visitable?(parser) : Bool
       !parser.args[Typed::Type].has_key?(value_key)
     end
 
diff --git a/src/lib/definitions/string_array_argument.cr b/src/lib/definitions/string_array_argument.cr
index bee495c..47a569a 100644
--- a/src/lib/definitions/string_array_argument.cr
+++ b/src/lib/definitions/string_array_argument.cr
@@ -9,7 +9,7 @@ module Optarg::Definitions
       initialize_completion complete
     end
 
-    def visitable?(parser)
+    def visitable?(parser) : Bool
       true
     end
 
diff --git a/src/lib/definitions/string_array_option.cr b/src/lib/definitions/string_array_option.cr
index 55a5551..e5eb5f8 100644
--- a/src/lib/definitions/string_array_option.cr
+++ b/src/lib/definitions/string_array_option.cr
@@ -14,7 +14,7 @@ module Optarg::Definitions
       Parser.new_node(parser[0..1], self)
     end
 
-    def completion_length(gen)
+    def completion_length(gen) : Int32
       2
     end
   end
diff --git a/src/lib/definitions/string_option.cr b/src/lib/definitions/string_option.cr
index 2eae9a4..5bd3ca6 100644
--- a/src/lib/definitions/string_option.cr
+++ b/src/lib/definitions/string_option.cr
@@ -18,7 +18,7 @@ module Optarg::Definitions
       raise UnsupportedConcatenation.new(parser, self)
     end
 
-    def completion_length(gen)
+    def completion_length(gen) : Int32
       2
     end
   end
diff --git a/src/lib/definitions/terminator.cr b/src/lib/definitions/terminator.cr
index 1b1124c..f8daf2b 100644
--- a/src/lib/definitions/terminator.cr
+++ b/src/lib/definitions/terminator.cr
@@ -10,11 +10,11 @@ module Optarg::Definitions
       Parser.new_node(parser[0..0], self)
     end
 
-    def completion_length(gen)
+    def completion_length(gen) : Int32
       1
     end
 
-    def completion_max_occurs(gen)
+    def completion_max_occurs(gen) : Int32
       1
     end
   end
diff --git a/src/lib/definitions/unknown.cr b/src/lib/definitions/unknown.cr
index 6307122..745c605 100644
--- a/src/lib/definitions/unknown.cr
+++ b/src/lib/definitions/unknown.cr
@@ -4,11 +4,11 @@ module Optarg::Definitions
       super "@unknown", metadata: metadata, unknown: true
     end
 
-    def completion_length(gen)
+    def completion_length(gen) : Int32
       1
     end
 
-    def completion_max_occurs(gen)
+    def completion_max_occurs(gen) : Int32
       1
     end
   end