🆕 Added Biome. Formatted and made code suggestions

Author: mountainash

.editorconfig

@@ -7,7 +7,6 @@ indent_style = tab
 end_of_line = lf
 charset = utf-8
 trim_trailing_whitespace = true
-insert_final_newline = false
 
 [package.json]
 indent_style = space

.prettierrc

@@ -0,0 +1,7 @@
+{
+	"recommendations": [
+		"biomejs.biome",
+		"streetsidesoftware.code-spell-checker",
+		"davidanson.vscode-markdownlint"
+	]
+}

.vscode/extensions.json

@@ -18,13 +18,26 @@
 		"statusBar.foreground": "#FFF",
 		"statusBar.border": "#586573"
 	},
-    "cSpell.words": [
+	"cSpell.words": [
 		"Asana",
+		"biomejs",
 		"Dominik",
 		"doubleclick",
+		"hideothers",
+		"keychain",
 		"keystorename",
 		"keytar",
+		"loginbutton",
+		"loginform",
+		"loginkeys",
+		"loginpassword",
+		"loginsubmitted",
+		"loginusername",
+		"Nuxt",
+		"Omnibutton",
 		"Schmitt",
-		"Taskana"
+		"selectall",
+		"Taskana",
+		"Topbar"
 	]
-}
+}

.vscode/settings.json

@@ -0,0 +1,43 @@
+{
+	"$schema": "https://biomejs.dev/schemas/1.9.3/schema.json",
+	"files": {
+		"ignore": ["dist/**/*"]
+	},
+	"organizeImports": {
+		"enabled": true
+	},
+	"formatter": {
+		"enabled": true,
+		"useEditorconfig": true,
+		"indentStyle": "tab",
+		"indentWidth": 4,
+		"lineEnding": "lf",
+		"lineWidth": 80,
+		"attributePosition": "auto"
+	},
+	"linter": {
+		"enabled": true,
+		"rules": {
+			"recommended": true,
+			"complexity": { "noForEach": "off" }
+		}
+	},
+	"javascript": {
+		"formatter": {
+			"jsxQuoteStyle": "single",
+			"quoteProperties": "asNeeded",
+			"trailingCommas": "es5",
+			"semicolons": "always",
+			"arrowParentheses": "always",
+			"bracketSpacing": true,
+			"bracketSameLine": false,
+			"quoteStyle": "single",
+			"attributePosition": "auto"
+		}
+	},
+	"vcs": {
+		"enabled": true,
+		"clientKind": "git",
+		"useIgnoreFile": true
+	}
+}

biome.json

@@ -8,16 +8,16 @@ ipcRenderer.on('new-task', () => {
 });
 
 ipcRenderer.on('show-preferences', () => {
-	document.querySelector('.TopbarSettingsMenuButton').click();
-	document.querySelector('.TopbarSettingsMenu-settings').click();
+	document.querySelector('.TopbarSettingsMenuButton')?.click();
+	document.querySelector('.TopbarSettingsMenu-settings')?.click();
 });
 
 document.addEventListener('readystatechange', async () => {
 	const DomHooks = {
-		'loginform': '.LoginEmailPasswordForm',
-		'loginusername': 'input[name=e]',
-		'loginpassword': 'input[name=p]',
-		'loginbutton': '[role=button]'
+		loginform: '.LoginEmailPasswordForm',
+		loginusername: 'input[name=e]',
+		loginpassword: 'input[name=p]',
+		loginbutton: '[role=button]',
 	};
 
 	if (document.location.pathname.endsWith('/login')) {
@@ -32,19 +32,19 @@ document.addEventListener('readystatechange', async () => {
 		const event = new Event('HTMLEvents');
 		event.initEvent('change', true, false);
 
-		if (loginkeys && loginkeys.username) {
+		if (loginkeys?.username) {
 			loginusername.value = loginkeys.username;
 			loginusername.dispatchEvent(event);
 		}
 
-		if (loginkeys && loginkeys.password) {
+		if (loginkeys?.password) {
 			loginpassword.value = loginkeys.password;
 			loginpassword.dispatchEvent(event);
 		}
 
-		const loginsubmitted = async function() {
-			let username = loginusername.value;
-			let password = loginpassword.value;
+		const loginsubmitted = async () => {
+			const username = loginusername.value;
+			const password = loginpassword.value;
 
 			if (username && password) {
 				await keyStore.deleteKeys(); // delete any exiting logins
@@ -55,14 +55,14 @@ document.addEventListener('readystatechange', async () => {
 		// add a listener to the form to capture login details and store them
 		// would be nice to add to just the <FORM> submit event, but React/Nuxt (used by Asana) captures the events lower in the DOM
 		// loginform.addEventListener('submit', loginsubmitted);
-		loginform.querySelector(DomHooks.loginbutton).addEventListener('click', loginsubmitted);
+		loginform
+			.querySelector(DomHooks.loginbutton)
+			.addEventListener('click', loginsubmitted);
 		loginusername.addEventListener('keyup', (e) => {
-			if (e.code == 'Enter')
-				loginsubmitted()
+			if (e.code === 'Enter') loginsubmitted();
 		});
 		loginpassword.addEventListener('keyup', (e) => {
-			if (e.code == 'Enter')
-				loginsubmitted()
+			if (e.code === 'Enter') loginsubmitted();
 		});
 	}
-});
+});

browser.cjs

@@ -4,4 +4,4 @@
 .SidebarInvite,
 .TopbarHelpMenuButton-button /* Most of these are in Taskana's Help menu */ {
 	display: none !important;
-}
+}

browser.css

@@ -1,9 +1,9 @@
-import { app, BrowserWindow, Menu, shell, ipcMain } from 'electron';
-import electronUpdater from 'electron-updater';
+import fs from 'node:fs';
+import path from 'node:path';
+import { BrowserWindow, Menu, app, ipcMain, shell } from 'electron';
 import contextMenu from 'electron-context-menu';
 import Store from 'electron-store';
-import path from 'node:path';
-import fs from 'node:fs';
+import electronUpdater from 'electron-updater';
 import menu from './menu/index.js';
 
 const config = new Store();
@@ -47,7 +47,7 @@ function updateBadgeInfo(title) {
 function createMainWindow() {
 	contextMenu();
 
-	let opts = {
+	const opts = {
 		title: app.getName(),
 		width: 1200,
 		height: 600,
@@ -60,7 +60,7 @@ function createMainWindow() {
 			preload: path.resolve(app.getAppPath(), 'browser.cjs'),
 			partition: 'persist:asana',
 			spellcheck: true,
-		}
+		},
 	};
 	Object.assign(opts, config.get('winBounds'));
 
@@ -91,7 +91,7 @@ function createMainWindow() {
 	return win;
 }
 
-if ( !app.requestSingleInstanceLock() ) {
+if (!app.requestSingleInstanceLock()) {
 	app.quit();
 }
 
@@ -104,9 +104,11 @@ app.on('second-instance', () => {
 
 ipcMain.on('update-menu', () => {
 	Menu.setApplicationMenu(menu.slice(1));
-})
+});
 
-app.on('before-quit', () => isQuitting = true);
+app.on('before-quit', () => {
+	isQuitting = true;
+});
 
 app.on('ready', () => {
 	mainWindow = createMainWindow();
@@ -116,8 +118,7 @@ app.on('ready', () => {
 
 	// Open new browser window on external open
 	page.setWindowOpenHandler(({ url }) => {
-		if ( basicURL(url) )
-			shell.openExternal(url);
+		if (basicURL(url)) shell.openExternal(url);
 
 		return { action: 'deny' }; // prevent a new Electron window
 	});
@@ -160,4 +161,4 @@ app.on('activate', () => {
 	if (BrowserWindow.getAllWindows().length === 0) {
 		createMainWindow();
 	}
-});
+});

index.js

@@ -1,30 +1,38 @@
 export default {
 	label: 'Edit',
-	submenu: [{
-		label: 'Undo',
-		accelerator: 'CommandOrControl+Z',
-		role: 'undo'
-	}, {
-		label: 'Redo',
-		accelerator: 'Shift+CommandOrControl+Z',
-		role: 'redo'
-	}, {
-		type: 'separator'
-	}, {
-		label: 'Cut',
-		accelerator: 'CommandOrControl+X',
-		role: 'cut'
-	}, {
-		label: 'Copy',
-		accelerator: 'CommandOrControl+C',
-		role: 'copy'
-	}, {
-		label: 'Paste',
-		accelerator: 'CommandOrControl+V',
-		role: 'paste'
-	}, {
-		label: 'Select All',
-		accelerator: 'CommandOrControl+A',
-		role: 'selectall'
-	}]
-}
+	submenu: [
+		{
+			label: 'Undo',
+			accelerator: 'CommandOrControl+Z',
+			role: 'undo',
+		},
+		{
+			label: 'Redo',
+			accelerator: 'Shift+CommandOrControl+Z',
+			role: 'redo',
+		},
+		{
+			type: 'separator',
+		},
+		{
+			label: 'Cut',
+			accelerator: 'CommandOrControl+X',
+			role: 'cut',
+		},
+		{
+			label: 'Copy',
+			accelerator: 'CommandOrControl+C',
+			role: 'copy',
+		},
+		{
+			label: 'Paste',
+			accelerator: 'CommandOrControl+V',
+			role: 'paste',
+		},
+		{
+			label: 'Select All',
+			accelerator: 'CommandOrControl+A',
+			role: 'selectall',
+		},
+	],
+};

menu/edit.js

@@ -1,5 +1,5 @@
-import { app, shell } from 'electron';
 import os from 'node:os';
+import { app, shell } from 'electron';
 
 export default {
 	label: 'Help',
@@ -17,7 +17,10 @@ export default {
 		},
 		{
 			label: 'Keyboard Shortcuts',
-			click: () => shell.openExternal('https://asana.com/guide/help/faq/shortcuts'),
+			click: () =>
+				shell.openExternal(
+					'https://asana.com/guide/help/faq/shortcuts'
+				),
 		},
 		{
 			type: 'separator',
@@ -54,7 +57,8 @@ export default {
 		},
 		{
 			label: `${app.getName()} Website...`,
-			click: () => shell.openExternal('https://mountainash.github.io/taskana/'),
+			click: () =>
+				shell.openExternal('https://mountainash.github.io/taskana/'),
 		},
 		{
 			label: 'Report an Issue...',
@@ -65,8 +69,12 @@ export default {
 ${app.getName()} ${app.getVersion()}
 ${process.platform} ${process.arch} ${os.release()}`;
 
-				shell.openExternal(`https://github.com/mountainash/taskana/issues/new?body=${encodeURIComponent(body)}`);
+				shell.openExternal(
+					`https://github.com/mountainash/taskana/issues/new?body=${encodeURIComponent(
+						body
+					)}`
+				);
 			},
 		},
 	],
-};
+};

menu/help.js

@@ -1,11 +1,11 @@
 import { Menu } from 'electron';
 
+import edit from './edit.js';
+import help from './help.js';
 import main from './main.js';
 import tasks from './tasks.js';
-import edit from './edit.js';
 import window from './window.js';
-import help from './help.js';
 
 const template = [main, tasks, edit, window, help];
 
-export default Menu.buildFromTemplate(template);
+export default Menu.buildFromTemplate(template);

menu/index.js

@@ -52,4 +52,4 @@ export default {
 			click: () => app.quit(),
 		},
 	],
-};
+};