Add extra checks in execute_and_wait_until_completion(..) (ros2#1346)

- Add check if process was terminated by the signal or really exited

Signed-off-by: Michael Orlov <[email protected]>

Author: morlov-apexai

rosbag2_test_common/include/rosbag2_test_common/process_execution_helpers_unix.hpp

@@ -60,13 +60,17 @@ int execute_and_wait_until_completion(const std::string & command, const std::st
   if (ret_ch_dir != 0) {
     return EXIT_FAILURE;
   }
-  auto exitcode = std::system(command.c_str());
+  auto status = std::system(command.c_str());
   ret_ch_dir = chdir(previous_dir);
   if (ret_ch_dir != 0) {
     return EXIT_FAILURE;
   }
-
-  return WEXITSTATUS(exitcode);
+  EXPECT_EQ(WIFEXITED(status), true) << "status = " << status;
+  if (WIFSIGNALED(status)) {
+    // Process terminated by signal
+    return WTERMSIG(status);
+  }
+  return WEXITSTATUS(status);
 }
 
 ProcessHandle start_execution(const std::string & command)