Skip to content

Commit 3365f8f

Browse files
authored
Change subscriptions from GenericSubscripton to SubscriptionBase (ros2#1337)
Signed-off-by: Emerson Knapp <[email protected]>
1 parent af4ca0c commit 3365f8f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

rosbag2_transport/include/rosbag2_transport/recorder.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class Recorder : public rclcpp::Node
9696
topics_using_fallback_qos() const;
9797

9898
ROSBAG2_TRANSPORT_PUBLIC
99-
const std::unordered_map<std::string, std::shared_ptr<rclcpp::GenericSubscription>> &
99+
const std::unordered_map<std::string, std::shared_ptr<rclcpp::SubscriptionBase>> &
100100
subscriptions() const;
101101

102102
ROSBAG2_TRANSPORT_PUBLIC

rosbag2_transport/src/rosbag2_transport/recorder.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class RecorderImpl
8383
rosbag2_storage::StorageOptions storage_options_;
8484
rosbag2_transport::RecordOptions record_options_;
8585
std::atomic<bool> stop_discovery_;
86-
std::unordered_map<std::string, std::shared_ptr<rclcpp::GenericSubscription>> subscriptions_;
86+
std::unordered_map<std::string, std::shared_ptr<rclcpp::SubscriptionBase>> subscriptions_;
8787

8888
private:
8989
void topics_discovery();
@@ -643,7 +643,7 @@ Recorder::topics_using_fallback_qos() const
643643
return pimpl_->topics_warned_about_incompatibility_;
644644
}
645645

646-
const std::unordered_map<std::string, std::shared_ptr<rclcpp::GenericSubscription>> &
646+
const std::unordered_map<std::string, std::shared_ptr<rclcpp::SubscriptionBase>> &
647647
Recorder::subscriptions() const
648648
{
649649
return pimpl_->subscriptions_;

0 commit comments

Comments
 (0)