Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse href to make the external prop obsolete #2

Open
fsdiogo opened this issue Apr 16, 2020 · 0 comments
Open

Parse href to make the external prop obsolete #2

fsdiogo opened this issue Apr 16, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@fsdiogo
Copy link
Contributor

fsdiogo commented Apr 16, 2020

As mentioned in #1 (comment), it is possible to parse href to infer if the route is internal or external, making the external prop obsolete, or just a fallback to be overridden.

/cc @zebateira @paulobmarcos @PedroMiguelSS
@fsdiogo fsdiogo added the enhancement New feature or request label Apr 16, 2020
@fsdiogo fsdiogo mentioned this issue Apr 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fsdiogo