Update ktlint to version 1.8.0

Author: rvandermeulen

app/src/androidTest/java/org/mozilla/reference/browser/ui/robots/AddToHomeScreenRobot.kt

@@ -22,6 +22,7 @@ class AddToHomeScreenRobot {
         when (Build.VERSION.SDK_INT) {
             // For Android Oreo(API 26) to Android 11(API 30), click the "Add Automatically" button
             in Build.VERSION_CODES.O..Build.VERSION_CODES.R -> clickAddAutomaticallyButton()
+
             // For Android 12(API 31) to Vanilla Ice Cream(API 35), click the "Add to Home Screen" button
             in Build.VERSION_CODES.S..Build.VERSION_CODES.VANILLA_ICE_CREAM -> clickAddToHomeScreenButton()
         }

app/src/main/java/org/mozilla/reference/browser/BrowserActivity.kt

@@ -125,11 +125,15 @@ open class BrowserActivity : AppCompatActivity() {
         attrs: AttributeSet,
     ): View? =
         when (name) {
-            EngineView::class.java.name ->
+            EngineView::class.java.name -> {
                 components.core.engine
                 .createView(context, attrs)
                 .asView()
-            else -> super.onCreateView(parent, name, context, attrs)
+            }
+
+            else -> {
+                super.onCreateView(parent, name, context, attrs)
+            }
         }
 
     private fun onNonFatalCrash(crash: Crash) {

app/src/main/java/org/mozilla/reference/browser/ExternalAppBrowserActivity.kt

@@ -26,6 +26,7 @@ class ExternalAppBrowserActivity : BrowserActivity() {
                 WebAppManifest.DisplayMode.MINIMAL_UI,
                 WebAppManifest.DisplayMode.BROWSER,
                 -> null
+
                 else -> null
             }
 

app/src/main/java/org/mozilla/reference/browser/addons/AddonSettingsActivity.kt

@@ -54,11 +54,15 @@ class AddonSettingsActivity : AppCompatActivity() {
         attrs: AttributeSet,
     ): View? =
         when (name) {
-            EngineView::class.java.name ->
+            EngineView::class.java.name -> {
                 components.core.engine
                 .createView(context, attrs)
                 .asView()
-            else -> super.onCreateView(parent, name, context, attrs)
+            }
+
+            else -> {
+                super.onCreateView(parent, name, context, attrs)
+            }
         }
 
     /**

app/src/main/java/org/mozilla/reference/browser/addons/WebExtensionActionPopupActivity.kt

@@ -54,11 +54,15 @@ class WebExtensionActionPopupActivity : AppCompatActivity() {
         attrs: AttributeSet,
     ): View? =
         when (name) {
-            EngineView::class.java.name ->
+            EngineView::class.java.name -> {
                 components.core.engine
                 .createView(context, attrs)
                 .asView()
-            else -> super.onCreateView(parent, name, context, attrs)
+            }
+
+            else -> {
+                super.onCreateView(parent, name, context, attrs)
+            }
         }
 
     /**

app/src/main/java/org/mozilla/reference/browser/settings/SettingsActivity.kt

@@ -37,7 +37,10 @@ class SettingsActivity :
             onBackPressedDispatcher.onBackPressed()
             true
         }
-        else -> super.onOptionsItemSelected(item)
+
+        else -> {
+            super.onOptionsItemSelected(item)
+        }
     }
 
     override fun updateTitle(titleResId: Int) {

app/src/main/java/org/mozilla/reference/browser/tabs/TabsToolbar.kt

@@ -38,6 +38,7 @@ class TabsToolbar
                     }
                     closeTabsTray?.invoke()
                 }
+
                 R.id.closeTab -> {
                     when (isPrivateTray) {
                         true -> tabsUseCases.removePrivateTabs.invoke()

gradle/libs.versions.toml

@@ -44,7 +44,7 @@ androidx-test-uiautomator = "2.3.0"
 dependency-analysis = "3.4.1"
 detekt = "1.23.8"
 jspecify = "1.0.0"
-ktlint = "1.7.1"
+ktlint = "1.8.0"
 
 # Third Party Testing
 hamcrest = "1.3"