Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve time-to-fail when a task group doesn't pass CoT #348

Closed
mitchhentges opened this issue Jun 20, 2019 · 1 comment
Closed

Improve time-to-fail when a task group doesn't pass CoT #348

mitchhentges opened this issue Jun 20, 2019 · 1 comment

Comments

@mitchhentges
Copy link
Contributor

In mobile, we often have a task group workflow of:

decision task -> build (takes a long time) -> sign -> push

If the decision task isn't valid for CoT, we don't realize until the sign task runs. Since the build task takes so long (upwards of an hour, in some cases), this can consume a lot of time. If decision task CoT checking happened sooner, this could improve productivity.

end-to-end CoT verification may help with this?

@escapewindow
Copy link
Contributor

I think having a check in taskgraph that prevents trusted scriptworkers from downloading from non-trusted worker pools may help most or all of the root cause of this issue. Also, once the decision task with unknown validity runs, we can run verify_cot against it, without waiting for the build to finish. If the decision task itself is invalid, we can find that out quickly.

Also,

  • worker identity, once implemented, will allow us to remove cot keypairs from worker pools, and
  • the artifact metadata rfc, once implemented, will allow us to use platform-supported artifact guarantees, rather than rely on CoT layers on top of the platform.

End-to-end CoT verification would allow us to find out automatically during the decision task and/or build, and is my preferred solution here.

More discussion here. I think these are valid concerns, with plans to address. Since they're being tracked elsewhere, I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants