[Bug]: forwarding with Request Review from Mozilla Legal a report attached which was escalated first from cinder to rev tools

[ioanarusiczki]

What happened?

Followup for #15078

I've mentioned into #15255 that an add-on reported for add-on policies when it's forwared to Legal Escalation Cinder queue (checkbox checked) the report continues to be visible in the dsa section. Yet in this case the flag for HR is removed.

When an add-on or theme is forwarded with a dsa report which was escalated from Cinder the same thing is happening plus the HR flag is not removed

Example with a theme https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/635056
Example with an add-on https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635067

What did you expect to happen?

Probably the reports should no longer be displayed in the dsa section.
Also the flag for HR with the due date should be removed and versions cleared from the Manual Review queue.

A note
Checking around I sent to the Legal Escalations some add-ons which are flagged for HR for different reasons than having reports/appeals attached
a recommended https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/634976
auto-approval disabled or scanner rules
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635068
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/634521

They're present in Legal Escalation, the review history in rev tools displays this. They continue to be flagged for HR, and available in the Manual Review queue. -> I think this should be expected

Is there an existing issue for this?

• I have searched the existing issues

┆Issue is synchronized with this Jira Task

[ioanarusiczki]

I tested on AMO stage and it worked, NHR is removed from the review pages. I still find these scenarios confusing 😕, I wonder if that would ever make a real use case?

I tried :

1. Developer appeal resolved from Cider's T&S Escalations queue after the report has been forwarded from Cinder to AMO rev tools and then back to Cinder Legal Escalations queue
   on AMO https://reviewers.addons.allizom.org/en-US/reviewers/review-listed/2244544#review-actions
   in Cinder https://stage.cinder.nonprod.webservices.mozgcp.net/job/196ae9bf-d804-4a8a-ac3a-3034656a9d85

Note: stage listings escalate policy - looking weird (does not have Escalate to AMO), so I chose another policy that would forward the report to amo. Could be fixed from queue's settings (did not check it yet)

2. Theme report resolved with ignore policy in Legal Escalations queue after report has been forwarded from Cinder to amo and then back to Legal
   https://stage.cinder.nonprod.webservices.mozgcp.net/job/84a40404-3425-4ed0-8c98-e6e7452fb71c

Reading my note about flagged in awaiting review and forwarded to legal -> would help knowing if this would be the case, would versions flagged because of scanner rules, being part of a promoted group which requires manual approval or disabled auto-approval go to Legal ? 🙃

For example if I forwarded an add-on awaiting review because it has auto-approval disabled , it stays flagged for moderation in rev tools too https://reviewers.addons.allizom.org/en-US/reviewers/review-listed/2244546#review-actions
Then I tried to disable content from Cinder Legal Escalations queue https://reviewers.addons.allizom.org/en-US/reviewers/review-listed/2244546 but won't work (that's scenario 2 from #15255 (comment))

[eviljeff]

@ioanarusiczki I'm unclear if you're saying the things you tried worked or didn't work. Or if they are different things than described in comment0. Are you saying that the bug isn't resolved at all? Or it is resolved but you found other bugs? Or it's resolved and you're documenting your testing steps.

[ioanarusiczki]

I tried to extract what's left with questions marks from this issue into #15278