Skip to content

Commit 74ee920

Browse files
Merge branch 'main' into dependabot/pip/protobuf-4.25.8
2 parents f3f66f7 + 9eac6a1 commit 74ee920

File tree

60 files changed

+301
-964
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

60 files changed

+301
-964
lines changed

.circleci/config.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ workflows:
5959
sql/mozfun/.* validate-routines true
6060
sql/moz-fx-data-shared-prod/udf/.* validate-routines true
6161
sql/moz-fx-data-shared-prod/udf_js/.* validate-routines true
62+
bqetl_project.yaml trigger-sql-generation true
6263
bqetl_project.yaml validate-sql true
6364
bqetl_project.yaml validate-routines true
6465
dags.yaml validate-sql true

.circleci/workflows.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1134,8 +1134,8 @@ jobs:
11341134
name: Manually trigger integration tests for fork
11351135
# yamllint disable rule:line-length
11361136
command: |
1137-
apt update
1138-
apt install jq -y
1137+
sudo apt update
1138+
sudo apt install jq -y
11391139
11401140
CIRCLE_PR_BRANCH=`curl -s https://api.github.com/repos/${CIRCLE_PROJECT_USERNAME}/${CIRCLE_PROJECT_REPONAME}/pulls/${CIRCLE_PR_NUMBER} | jq -r '.head.label'`
11411141

bigquery_etl/format_sql/format.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import os
55
import os.path
66
import sys
7-
from functools import partial
7+
from functools import cache, partial
88
from multiprocessing.pool import Pool
99
from pathlib import Path
1010
from typing import Tuple
@@ -16,6 +16,7 @@
1616
from bigquery_etl.util.common import qualify_table_references_in_file
1717

1818

19+
@cache
1920
def skip_format():
2021
"""Return a list of configured queries for which formatting should be skipped."""
2122
return [
@@ -25,6 +26,7 @@ def skip_format():
2526
]
2627

2728

29+
@cache
2830
def skip_qualifying_references():
2931
"""Return a list of configured queries where fully qualifying references should be skipped."""
3032
return [

bqetl_project.yaml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,7 @@ generate:
373373
- firefox_reality_pc
374374
- lockwise_android
375375
- lockwise_ios
376+
- mozilla_vpn # VPN events are in `main` pings rather than `events` pings (DENG-8596).
376377
- tiktokreporter_ios
377378
- tiktokreporter_android
378379
metrics_as_struct_apps:
@@ -563,6 +564,23 @@ generate:
563564
geo_deprecation:
564565
include_app_ids:
565566
- org_mozilla_ios_klar
567+
- org_mozilla_klar
568+
- org_mozilla_ios_focus
569+
- org_mozilla_focus
570+
- org_mozilla_focus_beta
571+
- org_mozilla_focus_nightly
572+
- org_mozilla_ios_firefox
573+
- org_mozilla_ios_firefoxbeta
574+
- org_mozilla_ios_fennec
575+
- org_mozilla_firefox
576+
- org_mozilla_firefox_beta
577+
- org_mozilla_fenix
578+
- org_mozilla_fenix_nightly
579+
- org_mozilla_fennec_aurora
580+
- firefox_desktop
581+
- firefox_desktop_background_update
582+
- firefox_desktop_background_defaultagent
583+
- firefox_desktop_background_tasks
566584
skip_tables:
567585
- newtab
568586

requirements.txt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -654,9 +654,9 @@ google-api-core[grpc]==2.17.1 \
654654
# google-cloud-core
655655
# google-cloud-datacatalog-lineage
656656
# google-cloud-storage
657-
google-auth==2.41.1 \
658-
--hash=sha256:754843be95575b9a19c604a848a41be03f7f2afd8c019f716dc1f51ee41c639d \
659-
--hash=sha256:b76b7b1f9e61f0cb7e88870d14f6a94aeef248959ef6992670efee37709cbfd2
657+
google-auth==2.42.0 \
658+
--hash=sha256:9bbbeef3442586effb124d1ca032cfb8fb7acd8754ab79b55facd2b8f3ab2802 \
659+
--hash=sha256:f8f944bcb9723339b0ef58a73840f3c61bc91b69bf7368464906120b55804473
660660
# via
661661
# -r requirements.in
662662
# gcsfs

sql/moz-fx-data-shared-prod/firefox_desktop/clients_first_seen/view.sql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ SELECT
5252
b.architecture AS baseline_architecture,
5353
b.is_desktop AS baseline_is_desktop,
5454
b.windows_version AS baseline_windows_version,
55-
b.normalized_app_name AS baseline_normalized_app_name
55+
b.normalized_app_name AS baseline_normalized_app_name,
56+
b.app_build_id AS baseline_app_build_id
5657
FROM
5758
`moz-fx-data-shared-prod.firefox_desktop.metrics_clients_first_seen` m
5859
FULL OUTER JOIN

sql/moz-fx-data-shared-prod/firefox_desktop/glean_baseline_clients_first_seen/view.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ SELECT
2727
bcfs.locale,
2828
bcfs.normalized_os,
2929
bcfs.app_display_version,
30+
bcfs.app_build_id,
3031
bcfs.normalized_channel,
3132
bcfs.normalized_os_version,
3233
bcfs.isp,

sql/moz-fx-data-shared-prod/firefox_desktop_derived/clients_first_seen_28_days_later_v1/query.sql

Lines changed: 63 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ WITH clients_first_seen_28_days_ago AS (
4242
metric_installation_first_seen_version AS installation_first_seen_version,
4343
baseline_windows_build_number AS windows_build_number,
4444
baseline_windows_version AS windows_version,
45-
baseline_legacy_telemetry_profile_group_id AS profile_group_id
45+
baseline_legacy_telemetry_profile_group_id AS profile_group_id,
46+
baseline_app_build_id AS app_build_id
4647
FROM
4748
`moz-fx-data-shared-prod.firefox_desktop.clients_first_seen`
4849
WHERE
@@ -63,24 +64,65 @@ clients_first_seen_28_days_ago_with_days_seen AS (
6364
AND cls.submission_date = @submission_date
6465
)
6566
SELECT
66-
* REPLACE (
67-
COALESCE(
68-
days_seen_bits,
69-
mozfun.bits28.from_string('0000000000000000000000000000')
70-
) AS days_seen_bits,
71-
COALESCE(
72-
days_active_bits,
73-
mozfun.bits28.from_string('0000000000000000000000000000')
74-
) AS days_active_bits,
75-
COALESCE(
76-
days_visited_1_uri_bits,
77-
mozfun.bits28.from_string('0000000000000000000000000000')
78-
) AS days_visited_1_uri_bits,
79-
COALESCE(
80-
days_interacted_bits,
81-
mozfun.bits28.from_string('0000000000000000000000000000')
82-
) AS days_interacted_bits
83-
),
67+
client_id,
68+
sample_id,
69+
first_seen_date,
70+
architecture,
71+
app_name,
72+
locale,
73+
app_version,
74+
xpcom_abi,
75+
distribution_id,
76+
partner_distribution_version,
77+
partner_distributor,
78+
partner_distributor_channel,
79+
partner_id,
80+
attribution_campaign,
81+
attribution_content,
82+
attribution_dltoken,
83+
attribution_dlsource,
84+
attribution_experiment,
85+
attribution_medium,
86+
attribution_source,
87+
attribution_ua,
88+
attribution_variation,
89+
apple_model_id,
90+
isp_name,
91+
normalized_channel,
92+
country,
93+
normalized_os,
94+
normalized_os_version,
95+
startup_profile_selection_reason,
96+
installation_first_seen_admin_user,
97+
installation_first_seen_default_path,
98+
installation_first_seen_failure_reason,
99+
installation_first_seen_from_msi,
100+
installation_first_seen_install_existed,
101+
installation_first_seen_installer_type,
102+
installation_first_seen_other_inst,
103+
installation_first_seen_other_msix_inst,
104+
installation_first_seen_profdir_existed,
105+
installation_first_seen_silent,
106+
installation_first_seen_version,
107+
windows_build_number,
108+
windows_version,
109+
profile_group_id,
110+
COALESCE(
111+
days_seen_bits,
112+
mozfun.bits28.from_string('0000000000000000000000000000')
113+
) AS days_seen_bits,
114+
COALESCE(
115+
days_active_bits,
116+
mozfun.bits28.from_string('0000000000000000000000000000')
117+
) AS days_active_bits,
118+
COALESCE(
119+
days_visited_1_uri_bits,
120+
mozfun.bits28.from_string('0000000000000000000000000000')
121+
) AS days_visited_1_uri_bits,
122+
COALESCE(
123+
days_interacted_bits,
124+
mozfun.bits28.from_string('0000000000000000000000000000')
125+
) AS days_interacted_bits,
84126
COALESCE(
85127
BIT_COUNT(mozfun.bits28.from_string('1111111000000000000000000000') & days_seen_bits) >= 5,
86128
FALSE
@@ -109,6 +151,7 @@ SELECT
109151
) > 0,
110152
FALSE
111153
) AS qualified_week4,
112-
@submission_date AS submission_date
154+
@submission_date AS submission_date,
155+
app_build_id
113156
FROM
114157
clients_first_seen_28_days_ago_with_days_seen

sql/moz-fx-data-shared-prod/firefox_desktop_derived/clients_first_seen_28_days_later_v1/schema.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -205,3 +205,9 @@ fields:
205205
type: DATE
206206
mode: NULLABLE
207207
description: The date when the telemetry ping is received on the server side.
208+
- name: app_build_id
209+
type: STRING
210+
mode: NULLABLE
211+
description: |-
212+
The build identifier generated by the CI system (e.g. "1234/A").
213+
If the value was not provided through configuration, this metric gets set to Unknown.
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
friendly_name: Looker User Reported Issues
2+
description: |-
3+
Links to the following spreedsheet with user reported issues in Looker:
4+
https://docs.google.com/spreadsheets/d/1joJXR9A8pjdpxEVKAXphXqPh-vy8yRZXs57UZwmUZVs/edit
5+
owners:
6+
7+
external_data:
8+
format: google_sheets
9+
source_uris:
10+
- https://docs.google.com/spreadsheets/d/1joJXR9A8pjdpxEVKAXphXqPh-vy8yRZXs57UZwmUZVs/edit
11+
options:
12+
skip_leading_rows: 1
13+
range: Form Responses 1

0 commit comments

Comments
 (0)