From 995592429c351d2ba9393d486db92e33f5b3e8c4 Mon Sep 17 00:00:00 2001 From: Lauren Zugai Date: Tue, 28 Jan 2025 16:08:53 -0600 Subject: [PATCH] fix(l10n): Ensure a11y text is displayed on Complete Reset PW page for service=relay Because: * This text is not being rendered as it should be on this page This commit: * Passes the missed prop into CompleteResetPassword from the container component, updates the optional type fixes FXA-11016 --- .../src/pages/ResetPassword/CompleteResetPassword/container.tsx | 1 + .../src/pages/ResetPassword/CompleteResetPassword/interfaces.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/fxa-settings/src/pages/ResetPassword/CompleteResetPassword/container.tsx b/packages/fxa-settings/src/pages/ResetPassword/CompleteResetPassword/container.tsx index 6d5294d6027..3138cd8e965 100644 --- a/packages/fxa-settings/src/pages/ResetPassword/CompleteResetPassword/container.tsx +++ b/packages/fxa-settings/src/pages/ResetPassword/CompleteResetPassword/container.tsx @@ -363,6 +363,7 @@ const CompleteResetPasswordContainer = ({ recoveryKeyExists, estimatedSyncDeviceCount, }} + isDesktopServiceRelay={integration.isDesktopRelay()} integrationIsSync={integration.isSync()} locationState={location.state as CompleteResetPasswordLocationState} /> diff --git a/packages/fxa-settings/src/pages/ResetPassword/CompleteResetPassword/interfaces.ts b/packages/fxa-settings/src/pages/ResetPassword/CompleteResetPassword/interfaces.ts index 448b5805c0e..2d9e0cb437e 100644 --- a/packages/fxa-settings/src/pages/ResetPassword/CompleteResetPassword/interfaces.ts +++ b/packages/fxa-settings/src/pages/ResetPassword/CompleteResetPassword/interfaces.ts @@ -44,7 +44,7 @@ export interface CompleteResetPasswordProps { estimatedSyncDeviceCount?: number; recoveryKeyExists?: boolean; integrationIsSync: boolean; - isDesktopServiceRelay?: boolean; + isDesktopServiceRelay: boolean; } export type AccountResetData = {