Merge pull request #66 from GnomedDev/extract-if #125
Annotations
35 warnings
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
fmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
usage of a legacy numeric method:
src/lib.rs#L3988
warning: usage of a legacy numeric method
--> src/lib.rs:3988:36
|
3988 | assert_eq!(v.len(), usize::max_value() - 1);
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
3988 - assert_eq!(v.len(), usize::max_value() - 1);
3988 + assert_eq!(v.len(), usize::MAX - 1);
|
|
|
usage of a legacy numeric method:
src/lib.rs#L3987
warning: usage of a legacy numeric method
--> src/lib.rs:3987:58
|
3987 | for _ in v.drain(usize::max_value() - 1..=usize::max_value() - 1) {}
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
3987 - for _ in v.drain(usize::max_value() - 1..=usize::max_value() - 1) {}
3987 + for _ in v.drain(usize::max_value() - 1..=usize::MAX - 1) {}
|
|
|
usage of a legacy numeric method:
src/lib.rs#L3987
warning: usage of a legacy numeric method
--> src/lib.rs:3987:33
|
3987 | for _ in v.drain(usize::max_value() - 1..=usize::max_value() - 1) {}
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
3987 - for _ in v.drain(usize::max_value() - 1..=usize::max_value() - 1) {}
3987 + for _ in v.drain(usize::MAX - 1..=usize::max_value() - 1) {}
|
|
|
usage of a legacy numeric method:
src/lib.rs#L3985
warning: usage of a legacy numeric method
--> src/lib.rs:3985:30
|
3985 | v.set_len(usize::max_value());
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
3985 - v.set_len(usize::max_value());
3985 + v.set_len(usize::MAX);
|
|
|
usage of a legacy numeric method:
src/lib.rs#L3983
warning: usage of a legacy numeric method
--> src/lib.rs:3983:57
|
3983 | let mut v = ThinVec::<()>::with_capacity(usize::max_value());
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
3983 - let mut v = ThinVec::<()>::with_capacity(usize::max_value());
3983 + let mut v = ThinVec::<()>::with_capacity(usize::MAX);
|
|
|
usage of a legacy numeric method:
src/lib.rs#L3981
warning: usage of a legacy numeric method
--> src/lib.rs:3981:36
|
3981 | assert_eq!(v.len(), usize::max_value() - 1);
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
3981 - assert_eq!(v.len(), usize::max_value() - 1);
3981 + assert_eq!(v.len(), usize::MAX - 1);
|
|
|
usage of a legacy numeric method:
src/lib.rs#L3980
warning: usage of a legacy numeric method
--> src/lib.rs:3980:33
|
3980 | for _ in v.drain(usize::max_value() - 1..) {}
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
3980 - for _ in v.drain(usize::max_value() - 1..) {}
3980 + for _ in v.drain(usize::MAX - 1..) {}
|
|
|
usage of a legacy numeric method:
src/lib.rs#L3978
warning: usage of a legacy numeric method
--> src/lib.rs:3978:30
|
3978 | v.set_len(usize::max_value());
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
3978 - v.set_len(usize::max_value());
3978 + v.set_len(usize::MAX);
|
|
|
usage of a legacy numeric method:
src/lib.rs#L3976
warning: usage of a legacy numeric method
--> src/lib.rs:3976:57
|
3976 | let mut v = ThinVec::<()>::with_capacity(usize::max_value());
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
|
3976 - let mut v = ThinVec::<()>::with_capacity(usize::max_value());
3976 + let mut v = ThinVec::<()>::with_capacity(usize::MAX);
|
|
|
importing legacy numeric constants:
src/lib.rs#L3399
warning: importing legacy numeric constants
--> src/lib.rs:3399:9
|
3399 | use core::usize;
| ^^^^^^^^^^^
|
= help: remove this import
= note: then `usize::<CONST>` will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` on by default
|
|
replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take`:
src/lib.rs#L2471
warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take`
--> src/lib.rs:2471:31
|
2471 | let mut vec = mem::replace(&mut this.vec, ThinVec::new());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut this.vec)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default
= note: `#[warn(clippy::mem_replace_with_default)]` on by default
|
|
field `0` is never read:
src/lib.rs#L3772
warning: field `0` is never read
--> src/lib.rs:3772:21
|
3772 | struct Elem(i32);
| ---- ^^^
| |
| field in this struct
|
= help: consider removing this field
|
|
field `0` is never read:
src/lib.rs#L3045
warning: field `0` is never read
--> src/lib.rs:3045:24
|
3045 | struct Align16(u8);
| ------- ^^
| |
| field in this struct
|
= help: consider removing this field
= note: `#[warn(dead_code)]` on by default
|
|
unneeded sub `cfg` when there is only one condition:
src/lib.rs#L4566
warning: unneeded sub `cfg` when there is only one condition
--> src/lib.rs:4566:11
|
4566 | #[cfg(all(feature = "gecko-ffi"))]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `feature = "gecko-ffi"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg
= note: `#[warn(clippy::non_minimal_cfg)]` on by default
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docs
Failed to save: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0w0usaAAAAACyicf92HpWT5wV+8rri/vSQkwyQUEyMDMwMTA3MDI5AEVkZ2U=
|
|
docs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docs
Failed to restore: Cache service responded with 400
|
|
docs
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docs
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
docs
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
msrv
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
msrv
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
msrv
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
msrv
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|