Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Commit 08fdfaa

Browse files
authored
Use the default appservices megazord, not the deprecated fenix megazord. (#2867)
The custom "fenix" megazord contains all the same code as appears in the default appservices megazord, so consumers who are using it are adding complexity to their build process for no gain. The appservices team intend to stop building the fenix megazord and instead encourage consumers to use the default full megazord. See additional discussion in mozilla/application-services#1466. This PR removes the megazord substitution rules, meaning FirefoxReality will get the full megazord by default. Fenix is making a corresponding change over in mozilla-mobile/fenix#8742.
1 parent 03cfac8 commit 08fdfaa

File tree

2 files changed

+4
-18
lines changed

2 files changed

+4
-18
lines changed

app/build.gradle

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -485,18 +485,6 @@ dependencies {
485485
implementation deps.android_components.glean
486486
implementation deps.app_services.rustlog
487487

488-
// For production builds, the native code for all `org.mozilla.appservices`
489-
// dependencies gets compiled together into a single "megazord" build, and
490-
// different megazords are published for different subsets of features. Ref
491-
// https://mozilla.github.io/application-services/docs/applications/consuming-megazord-libraries.html
492-
// For now we can jut use the one that's specifically designed for Fenix.
493-
implementation deps.app_services.megazord
494-
modules {
495-
module('org.mozilla.appservices:full-megazord') {
496-
replacedBy('org.mozilla.appservices:fenix-megazord', 'prefer the fenix megazord, to reduce final application size')
497-
}
498-
}
499-
500488
// TODO this should not be necessary at all, see Services.kt
501489
implementation deps.work.runtime
502490

@@ -520,9 +508,9 @@ dependencies {
520508
testImplementation deps.junit
521509
testImplementation deps.atsl.core
522510
testImplementation deps.robolectric
523-
testImplementation deps.app_services.megazord_forUnitTests
524511
testImplementation deps.app_services.rustlog
525512
testImplementation deps.android_components.support_test
513+
testImplementation deps.android_components.support_test_appservices
526514
testImplementation deps.telemetry.glean_unittests
527515
testImplementation deps.work.testing
528516

versions.gradle

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,8 @@ versions.android_components = "28.0.1"
2929
// Note that android-components also depends on application-services,
3030
// and in fact is our main source of appservices-related functionality.
3131
// The version number below tracks the application-services version
32-
// that we depend on directly for the fenix-megazord (and for it's
33-
// forUnitTest variant), and it's important that it be kept in
34-
// sync with the version used by android-components above.
32+
// that we depend on directly for its rustlog package, and it's important
33+
// that it be kept insync with the version used by android-components above.
3534
versions.mozilla_appservices = "0.48.2"
3635
versions.mozilla_speech = "1.0.10"
3736
versions.openwnn = "1.3.7"
@@ -78,11 +77,10 @@ android_components.lib_fetch = "org.mozilla.components:lib-fetch-httpurlconnecti
7877
android_components.support_rustlog = "org.mozilla.components:support-rustlog:$versions.android_components"
7978
android_components.support_rusthttp = "org.mozilla.components:support-rusthttp:$versions.android_components"
8079
android_components.support_test = "org.mozilla.components:support-test:$versions.android_components"
80+
android_components.support_test_appservices = "org.mozilla.components:support-test-appservices:$versions.android_components"
8181
deps.android_components = android_components
8282

8383
def app_services = [:]
84-
app_services.megazord = "org.mozilla.appservices:fenix-megazord:${versions.mozilla_appservices}"
85-
app_services.megazord_forUnitTests = "org.mozilla.appservices:fenix-megazord-forUnitTests:${versions.mozilla_appservices}"
8684
app_services.rustlog = "org.mozilla.appservices:rustlog:${versions.mozilla_appservices}"
8785
deps.app_services = app_services
8886

0 commit comments

Comments
 (0)