Add StickyTouchListener (#2096)

Author: MortimerGoro

app/src/common/shared/org/mozilla/vrbrowser/ui/views/HoneycombButton.java

@@ -8,6 +8,7 @@
 import android.util.AttributeSet;
 import android.util.Log;
 import android.view.MotionEvent;
+import android.view.View;
 import android.widget.ImageView;
 import android.widget.LinearLayout;
 import android.widget.TextView;
@@ -19,6 +20,7 @@
 import org.mozilla.vrbrowser.R;
 import org.mozilla.vrbrowser.utils.DeviceType;
 import org.mozilla.vrbrowser.utils.SystemUtils;
+import org.mozilla.vrbrowser.utils.ViewUtils;
 
 public class HoneycombButton extends LinearLayout {
 
@@ -83,10 +85,12 @@ private void initialize(Context aContext) {
         inflate(aContext, R.layout.honeycomb_button, this);
 
         setClickable(true);
+        setLongClickable(false);
 
         mIcon = findViewById(R.id.settings_button_icon);
         if (mIcon != null) {
             mIcon.setImageDrawable(mButtonIcon);
+            mIcon.setClickable(false);
         }
 
         mText = findViewById(R.id.settings_button_text);
@@ -95,16 +99,24 @@ private void initialize(Context aContext) {
             if (mButtonTextSize > 0) {
                 mText.getLayoutParams().width = (int) mButtonTextSize;
             }
+            mText.setClickable(false);
         }
 
         mSecondaryText = findViewById(R.id.settings_secondary_text);
         if (mSecondaryText != null) {
             mSecondaryText.setText(mSecondaryButtonText);
+            mSecondaryText.setClickable(false);
         }
 
         setOnHoverListener((view, motionEvent) -> false);
     }
 
+
+    @Override
+    public void setOnClickListener(@Nullable OnClickListener aListener) {
+        ViewUtils.setStickyClickListener(this, aListener);
+    }
+
     @Override
     public void setOnHoverListener(final OnHoverListener l) {
         super.setOnHoverListener((view, motionEvent) -> {

app/src/common/shared/org/mozilla/vrbrowser/utils/ViewUtils.java

@@ -10,6 +10,7 @@
 import android.text.style.ClickableSpan;
 import android.text.style.URLSpan;
 import android.util.Log;
+import android.view.MotionEvent;
 import android.view.View;
 import android.view.ViewGroup;
 import android.view.ViewParent;
@@ -170,4 +171,41 @@ public static void placeSelection(@NonNull EditText aView, int offset1, int offs
         int end = Math.max(offset1, offset2);
         aView.setSelection(start, end);
     }
+
+    static class StickyClickListener implements View.OnTouchListener {
+        private boolean mTouched;
+        private View.OnClickListener mClickListener;
+
+        StickyClickListener(View.OnClickListener aListener) {
+            mClickListener = aListener;
+        }
+
+        @Override
+        public boolean onTouch(View view, MotionEvent event) {
+            view.getParent().requestDisallowInterceptTouchEvent(true);
+            switch (event.getAction()) {
+                case MotionEvent.ACTION_DOWN:
+                    mTouched = true;
+                    break;
+                case MotionEvent.ACTION_UP:
+                    if (mTouched && ViewUtils.isInsideView(view, (int)event.getRawX(), (int)event.getRawY())) {
+                        view.requestFocus();
+                        view.requestFocusFromTouch();
+                        if (mClickListener != null) {
+                            mClickListener.onClick(view);
+                        }
+                    }
+                    mTouched = false;
+                    break;
+                case MotionEvent.ACTION_CANCEL:
+                    mTouched = false;
+                    break;
+            }
+            return false;
+        }
+    }
+
+    public static void setStickyClickListener(@NonNull View aView, View.OnClickListener aCallback) {
+        aView.setOnTouchListener(new StickyClickListener(aCallback));
+    }
 }