Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Commit 3481381

Browse files
authored
Fixes #3555 Fixes #3556 Media controls fixes (#3562)
* Media controls forward seek tooltip fix * Force media controls always to be flat
1 parent 96877ff commit 3481381

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/MediaControlsWidget.java

+2-8
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import org.mozilla.geckoview.MediaElement;
1919
import org.mozilla.vrbrowser.R;
2020
import org.mozilla.vrbrowser.browser.Media;
21-
import org.mozilla.vrbrowser.browser.SettingsStore;
2221
import org.mozilla.vrbrowser.databinding.MediaControlsBinding;
2322
import org.mozilla.vrbrowser.ui.views.MediaSeekBar;
2423
import org.mozilla.vrbrowser.ui.views.VolumeControl;
@@ -100,12 +99,7 @@ private void initialize(Context aContext) {
10099
placement.worldWidth = 0.5f;
101100
placement.parentAnchorX = 0.65f;
102101
placement.parentAnchorY = 0.4f;
103-
placement.cylinderMapRadius = 0.0f;
104-
placement.cylinder = SettingsStore.getInstance(getContext()).isCurvedModeEnabled();
105-
if (mWidgetManager.getCylinderDensity() > 0) {
106-
placement.rotationAxisY = 1.0f;
107-
placement.rotation = (float) Math.toRadians(-7);
108-
}
102+
placement.cylinder = false;
109103
if (mProjectionMenu.isVisible()) {
110104
mProjectionMenu.hide(KEEP_WIDGET);
111105

@@ -260,7 +254,7 @@ protected void initializeWidgetPlacement(WidgetPlacement aPlacement) {
260254
aPlacement.anchorY = 0.5f;
261255
aPlacement.parentAnchorX = 0.5f;
262256
aPlacement.parentAnchorY = 0.0f;
263-
aPlacement.cylinderMapRadius = 0.0f; // Do not map X when this widget uses cylindrical layout.
257+
aPlacement.cylinder = false;
264258
}
265259

266260
public void setParentWidget(int aHandle) {

app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/NavigationBarWidget.java

-1
Original file line numberDiff line numberDiff line change
@@ -827,7 +827,6 @@ private void enterVRVideo(@VideoProjectionMenuWidget.VideoProjectionFlags int aP
827827
mMediaControlsWidget.setMedia(mFullScreenMedia);
828828
mMediaControlsWidget.setParentWidget(mAttachedWindow.getHandle());
829829
mMediaControlsWidget.setProjectionSelectorEnabled(true);
830-
mMediaControlsWidget.getPlacement().cylinder = SettingsStore.getInstance(getContext()).isCurvedModeEnabled();
831830
mWidgetManager.updateWidget(mMediaControlsWidget);
832831
mWidgetManager.showVRVideo(mAttachedWindow.getHandle(), aProjection);
833832
}

app/src/main/res/layout/media_controls.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
style="?attr/mediaControlsButtonStyle"
7171
android:layout_weight="1"
7272
android:src="@drawable/ic_icon_media_seek_forward_30"
73-
android:tooltipText="@{String.format(@string/video_controls_seek_forward, 10)}"
73+
android:tooltipText="@{String.format(@string/video_controls_seek_forward, 30)}"
7474
app:tooltipDensity="@dimen/tray_tooltip_density"
7575
app:tooltipPosition="bottom"
7676
app:tooltipLayout="@layout/tooltip_tray"/>

0 commit comments

Comments
 (0)