Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Commit 7a444d0

Browse files
keianhzobluemarvin
authored andcommitted
Improved L10n support for settings (#2609)
1 parent 3f50729 commit 7a444d0

File tree

9 files changed

+21
-11
lines changed

9 files changed

+21
-11
lines changed

app/src/main/res/layout/options_footer.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
<RelativeLayout
1111
android:layout_width="match_parent"
12-
android:layout_height="wrap_content"
12+
android:layout_height="match_parent"
1313
android:gravity="center">
1414

1515
<View

app/src/main/res/layout/options_header.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
<LinearLayout
2929
android:layout_width="match_parent"
30-
android:layout_height="wrap_content"
30+
android:layout_height="match_parent"
3131
android:orientation="vertical">
3232

3333
<RelativeLayout

app/src/main/res/layout/setting_button.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33

44
<LinearLayout
55
android:layout_width="match_parent"
6-
android:layout_height="@dimen/developer_options_row_width"
6+
android:layout_height="match_parent"
7+
android:paddingTop="5dp"
8+
android:paddingBottom="5dp"
79
android:orientation="vertical">
810

911
<RelativeLayout
@@ -19,7 +21,7 @@
1921
android:layout_marginEnd="10dp"
2022
android:layout_toStartOf="@+id/button"
2123
android:gravity="center_vertical"
22-
tools:text="Edit Setting Description" />
24+
tools:text="@string/privacy_options_popups_reset" />
2325

2426
<TextView
2527
android:id="@+id/button"

app/src/main/res/layout/setting_edit.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33

44
<LinearLayout
55
android:layout_width="match_parent"
6-
android:layout_height="@dimen/developer_options_row_width"
6+
android:layout_height="match_parent"
7+
android:paddingTop="5dp"
8+
android:paddingBottom="5dp"
79
android:orientation="vertical">
810

911
<RelativeLayout

app/src/main/res/layout/setting_radio_group.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33

44
<LinearLayout
55
android:layout_width="match_parent"
6-
android:layout_height="@dimen/developer_options_row_width"
6+
android:layout_height="match_parent"
7+
android:paddingTop="5dp"
8+
android:paddingBottom="5dp"
79
android:orientation="vertical">
810

911
<RelativeLayout

app/src/main/res/layout/setting_radio_group_v.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33

44
<LinearLayout
55
android:layout_width="match_parent"
6-
android:layout_height="wrap_content"
6+
android:layout_height="match_parent"
7+
android:paddingTop="5dp"
8+
android:paddingBottom="5dp"
79
android:orientation="vertical">
810

911
<RelativeLayout
@@ -17,7 +19,7 @@
1719
android:layout_alignParentStart="true"
1820
android:layout_alignParentTop="true"
1921
android:layout_centerVertical="true"
20-
android:layout_marginBottom="20dp"
22+
android:layout_marginBottom="10dp"
2123
tools:text="Radio Setting Description" />
2224

2325
<RadioGroup

app/src/main/res/layout/setting_switch.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
<LinearLayout
66
android:id="@+id/layout"
77
android:layout_width="match_parent"
8-
android:layout_height="@dimen/developer_options_row_width"
8+
android:layout_height="match_parent"
9+
android:paddingTop="5dp"
10+
android:paddingBottom="5dp"
911
android:orientation="vertical">
1012

1113
<RelativeLayout

app/src/main/res/values/dimen.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@
134134
<dimen name="options_height">385dp</dimen>
135135

136136
<!-- Developer Panel -->
137-
<dimen name="options_button_width">120dp</dimen>
137+
<dimen name="options_button_width">140dp</dimen>
138138
<dimen name="options_button_height">30dp</dimen>
139139
<dimen name="options_text_height">30dp</dimen>
140140
<dimen name="developer_options_row_width">40dp</dimen>

app/src/main/res/values/styles.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,7 @@
363363

364364
<style name="settingsButtonDescriptionText">
365365
<item name="android:layout_width">wrap_content</item>
366-
<item name="android:layout_height">@dimen/options_text_height</item>
366+
<item name="android:layout_height">wrap_content</item>
367367
<item name="android:gravity">center</item>
368368
<item name="android:textColor">@color/fog</item>
369369
<item name="android:textSize">@dimen/text_medium_size</item>

0 commit comments

Comments
 (0)