Fixes issues after switching the tracking protection (#2125)

keianhzo · bluemarvin · commit a0ec4bd98ed9 · 2019-11-01T10:15:03.000-07:00
* Fix tracking update issues

* Add listeners to the new session after recreating
diff --git a/app/src/common/shared/org/mozilla/vrbrowser/browser/engine/Session.java b/app/src/common/shared/org/mozilla/vrbrowser/browser/engine/Session.java
@@ -404,6 +404,7 @@ private void recreateSession() {
         if (previous.mSession != null) {
             closeSession(previous.mSession);
         }
+        setupSessionListeners(mState.mSession);
 
         for (SessionChangeListener listener : mSessionChangeListeners) {
             listener.onCurrentSessionChange(previous.mSession, mState.mSession);
@@ -723,7 +724,7 @@ protected void setMultiprocess(final boolean aEnabled) {
     protected void setTrackingProtection(final boolean aEnabled) {
         if (mState.mSettings.isTrackingProtectionEnabled() != aEnabled) {
             mState.mSettings.setTrackingProtectionEnabled(aEnabled);
-            recreateSession();
+            mState.mSession.getSettings().setUseTrackingProtection(aEnabled);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -404,6 +404,7 @@ private void recreateSession() {`
`404`	`404`	`if (previous.mSession != null) {`
`405`	`405`	`closeSession(previous.mSession);`
`406`	`406`	`}`
	`407`	`+ setupSessionListeners(mState.mSession);`
`407`	`408`
`408`	`409`	`for (SessionChangeListener listener : mSessionChangeListeners) {`
`409`	`410`	`listener.onCurrentSessionChange(previous.mSession, mState.mSession);`
`@@ -723,7 +724,7 @@ protected void setMultiprocess(final boolean aEnabled) {`
`723`	`724`	`protected void setTrackingProtection(final boolean aEnabled) {`
`724`	`725`	`if (mState.mSettings.isTrackingProtectionEnabled() != aEnabled) {`
`725`	`726`	`mState.mSettings.setTrackingProtectionEnabled(aEnabled);`
`726`		`- recreateSession();`
	`727`	`+ mState.mSession.getSettings().setUseTrackingProtection(aEnabled);`
`727`	`728`	`}`
`728`	`729`	`}`
`729`	`730`