Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Commit aee8a16

Browse files
keianhzoMortimerGoro
authored andcommitted
Close Library panels when clicking on an anchor (#2403)
1 parent 5ae1cbb commit aee8a16

File tree

5 files changed

+16
-0
lines changed

5 files changed

+16
-0
lines changed

app/src/common/shared/org/mozilla/vrbrowser/ui/callbacks/BookmarksCallback.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,5 @@ default void onFxALogin(@NonNull View view) {}
1313
default void onFxASynSettings(@NonNull View view) {}
1414
default void onShowContextMenu(@NonNull View view, Bookmark item, boolean isLastVisibleItem) {}
1515
default void onHideContextMenu(@NonNull View view) {}
16+
default void onClickItem(@NonNull View view, Bookmark item) {}
1617
}

app/src/common/shared/org/mozilla/vrbrowser/ui/callbacks/HistoryCallback.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,5 @@ default void onFxALogin(@NonNull View view) {}
1313
default void onFxASynSettings(@NonNull View view) {}
1414
default void onShowContextMenu(@NonNull View view, @NonNull VisitInfo item, boolean isLastVisibleItem) {}
1515
default void onHideContextMenu(@NonNull View view) {}
16+
default void onClickItem(@NonNull View view, @NonNull VisitInfo item) {}
1617
}

app/src/common/shared/org/mozilla/vrbrowser/ui/views/BookmarksView.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,8 @@ public void onClick(@NonNull View view, @NonNull Bookmark item) {
159159

160160
Session session = SessionStore.get().getActiveSession();
161161
session.loadUri(item.getUrl());
162+
163+
mBookmarksViewListeners.forEach((listener) -> listener.onClickItem(view, item));
162164
}
163165

164166
@Override

app/src/common/shared/org/mozilla/vrbrowser/ui/views/HistoryView.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,8 @@ public void onClick(View view, VisitInfo item) {
160160

161161
Session session = SessionStore.get().getActiveSession();
162162
session.loadUri(item.getUrl());
163+
164+
mHistoryViewListeners.forEach((listener) -> listener.onClickItem(view, item));
163165
}
164166

165167
@Override

app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/WindowWidget.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1439,6 +1439,11 @@ public void onHideContextMenu(@NonNull View view) {
14391439
public void onFxALogin(@NonNull View view) {
14401440
hideBookmarks();
14411441
}
1442+
1443+
@Override
1444+
public void onClickItem(@NonNull View view, Bookmark item) {
1445+
hideBookmarks();
1446+
}
14421447
};
14431448

14441449
private HistoryCallback mHistoryListener = new HistoryCallback() {
@@ -1473,6 +1478,11 @@ public void onHideContextMenu(@NonNull View view) {
14731478
public void onFxALogin(@NonNull View view) {
14741479
hideHistory();
14751480
}
1481+
1482+
@Override
1483+
public void onClickItem(@NonNull View view, @NonNull VisitInfo item) {
1484+
hideHistory();
1485+
}
14761486
};
14771487

14781488
private void hideContextMenus() {

0 commit comments

Comments
 (0)