Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Commit dd3477c

Browse files
keianhzoMortimerGoro
authored andcommitted
Fixes L10n with the prompt widget (#2607)
1 parent 6a253bd commit dd3477c

File tree

4 files changed

+14
-10
lines changed

4 files changed

+14
-10
lines changed

app/src/main/res/layout/prompt_auth.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,8 @@
132132

133133
<CheckBox
134134
android:id="@+id/showPasswordCheckbox"
135-
android:layout_marginStart="5dp"
136-
style="@style/settingsSwitch" />
135+
style="@style/checkbox"
136+
android:layout_marginStart="5dp"/>
137137

138138
</LinearLayout>
139139

app/src/main/res/layout/prompt_dialog.xml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,7 @@
9393
android:layout_above="@+id/buttonsLayout">
9494
<CheckBox
9595
android:id="@+id/checkbox"
96-
android:layout_width="wrap_content"
97-
android:layout_height="match_parent"
98-
android:button="@drawable/checkbox"
99-
android:layout_gravity="center_horizontal"
100-
android:textSize="@dimen/text_medium_size"
101-
android:text="Checkbox"
96+
style="@style/checkbox"
10297
tools:text="Checkbox" />
10398
</FrameLayout>
10499

app/src/main/res/values/dimen.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -243,7 +243,7 @@
243243

244244
<!-- Prompt dialog -->
245245
<dimen name="prompt_dialog_width">450dp</dimen>
246-
<dimen name="prompt_dialog_height">365dp</dimen>
246+
<dimen name="prompt_dialog_height">375dp</dimen>
247247
<dimen name="prompt_dialog_padding_top">20dp</dimen>
248248
<dimen name="prompt_dialog_padding_bottom">42dp</dimen>
249249
<dimen name="prompt_dialog_padding_sides">64dp</dimen>

app/src/main/res/values/styles.xml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,14 +297,23 @@
297297

298298
<style name="settingsSwitch">
299299
<item name="android:layout_width">wrap_content</item>
300-
<item name="android:layout_height">wrap_content</item>
300+
<item name="android:layout_height">match_parent</item>
301301
<item name="android:switchMinWidth">0dp</item>
302302
<item name="android:textOff">""</item>
303303
<item name="android:textOn">""</item>
304304
<item name="android:thumb">@drawable/switch_thumb</item>
305305
<item name="android:track">@drawable/switch_track</item>
306306
</style>
307307

308+
<style name="checkbox">
309+
<item name="android:layout_width">wrap_content</item>
310+
<item name="android:layout_height">match_parent</item>
311+
<item name="android:button">@drawable/checkbox</item>
312+
<item name="android:layout_gravity">center_horizontal</item>
313+
<item name="android:textSize">@dimen/text_medium_size</item>
314+
<item name="android:paddingStart">5dp</item>
315+
</style>
316+
308317
<style name="settingsHelpButton">
309318
<item name="android:layout_width">20dp</item>
310319
<item name="android:layout_height">20dp</item>

0 commit comments

Comments
 (0)