Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Commit e862905

Browse files
MortimerGorokeianhzo
authored andcommitted
Fix cropped items in Selection Action menu (#2382)
1 parent 6c4a78f commit e862905

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

app/src/common/shared/org/mozilla/vrbrowser/ui/widgets/dialogs/SelectionActionWidget.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ public interface Delegate {
3535
private Point mPosition;
3636
private LinearLayout mContainer;
3737
private int mMinButtonWidth;
38+
private int mMaxButtonWidth;
3839
private Collection<String> mActions;
3940

4041
public SelectionActionWidget(Context aContext) {
@@ -45,7 +46,8 @@ public SelectionActionWidget(Context aContext) {
4546
private void initialize() {
4647
inflate(getContext(), R.layout.selection_action_menu, this);
4748
mContainer = findViewById(R.id.selectionMenuContainer);
48-
mMinButtonWidth = WidgetPlacement.pixelDimension(getContext(), R.dimen.autocompletion_widget_min_item_width);
49+
mMinButtonWidth = WidgetPlacement.pixelDimension(getContext(), R.dimen.selection_action_item_min_width);
50+
mMaxButtonWidth = WidgetPlacement.pixelDimension(getContext(), R.dimen.selection_action_item_max_width);
4951
mBackHandler = () -> {
5052
onDismiss();
5153
};
@@ -156,6 +158,7 @@ private UITextButton createButton(int aStringId, String aAction, OnClickListener
156158
}
157159
LinearLayout.LayoutParams params = new LinearLayout.LayoutParams(ViewGroup.LayoutParams.WRAP_CONTENT, ViewGroup.LayoutParams.WRAP_CONTENT);
158160
button.setMinWidth(mMinButtonWidth);
161+
button.setMaxWidth(mMaxButtonWidth);
159162
params.gravity = CENTER_VERTICAL;
160163
button.setLayoutParams(params);
161164
button.setTag(aAction);

app/src/main/res/values/dimen.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -245,6 +245,10 @@
245245
<dimen name="context_menu_corner_radius">20dp</dimen>
246246
<item name="context_menu_z_distance" format="float" type="dimen">0.1</item>
247247

248+
<!-- Selection Action Menu -->
249+
<dimen name="selection_action_item_min_width">56dp</dimen>
250+
<dimen name="selection_action_item_max_width">300dp</dimen>
251+
248252
<!-- Library Menu -->
249253
<dimen name="library_menu_width">320dp</dimen>
250254
<dimen name="library_menu_item_height">60dp</dimen>

0 commit comments

Comments
 (0)