This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Add virtual controller to NoAPI immersive mode #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortimerGoro
approved these changes
May 24, 2019
| @@ -154,8 +180,10 @@ DeviceDelegateNoAPI::SetClipPlanes(const float aNear, const float aFar) { | |||
| void | |||
| DeviceDelegateNoAPI::SetControllerDelegate(ControllerDelegatePtr& aController) { | |||
| m.controller = aController; | |||
| m.controller->CreateController(0, -1, ""); | |||
| m.controller->CreateController(0, -1, "FxR Virtual Controller"); | |||
There was a problem hiding this comment.
Should we use a common controller name here for the engines which filter by controller name?
There was a problem hiding this comment.
I was using the Daydream controller name string initially, but was curious what would happen if I used a unique name most everything I tried worked. But it doesn't work with hubs. so I guess I could use a known string. I tried using "Oculus Touch (Right)" and Hubs actually won't start in FxR NoAPI. I've tried all the different known controller names and none of them really work so I'm inclined to just leave it.
bluemarvin
force-pushed
the
noapi-immersive
branch
from
86e249b to
b21b27b
Compare
MortimerGoro
approved these changes
May 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.