This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Fixes #3276 Update search codes #3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue(#3276) says it should be |
|
What exactly changed to cause this? |
|
What exactly changed to cause this? And I'm really confused, this patch seems to be still using b-1-m-o? Per the original report, it;s: firefox-b-1-o | firefox-b-o |
keianhzo
force-pushed
the
v10/fix_search_codes
branch
from
f738aa4 to
d0727f6
Compare
keianhzo
force-pushed
the
v10/fix_search_codes
branch
from
d0727f6 to
51b478b
Compare
|
@mkaply So we only need to update google-b-m and google-b-1-m to use firefox-b-o and firefox-b-1-o respectively? So just to confirm, google and google-2018 stay the same? I've updated the PR. |
bluemarvin
approved these changes
Apr 30, 2020
|
I'm still not sure what it should be but the current PR matches what is reported in the initial issue now. |
|
I'm going to land this for rc4 and if it needs further adjustment we can address in a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3276 Update search codes and cleanup old dead code not needed anymore.
Override default AC Google search plugins to include the correct search codes.
@mkaply Can please verify if everything looks good? Also we still have some overrides for search plugins that I'm not sure if still apply: #248 (comment)