Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Fix editing only the first field on a DoubleEditSetting #986

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

MortimerGoro
Copy link
Contributor

Fixes #955

@ghost ghost assigned MortimerGoro Mar 7, 2019
@ghost ghost added the in progress label Mar 7, 2019
@philip-lamb
Copy link
Contributor

Saving the entered value now works, but there are some other weird issues here with resizing. I'll log them in another issue.

@bluemarvin
Copy link
Contributor

The screen size and max screen size settings pre-date dynamic window resizing. I'm not sure it even makes sense to have these in the visual prefs anymore.

Copy link
Contributor

@cvan cvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Window Size vs. Max. Window Size: to me personally, this is confusing. I was surprised when I inputted a larger width for the width of Window Size and it rejected my value when I clicked the Save button. Then, I realised it was because the value was greater than that of the width of Max. Window Size. To reiterate what's been said in the other reviews, do we need Max. Window Size? Or can we revisit the use cases of these two fields?

I think I reported this before – and apologies if it's already filed – but focusing/pressing on the input field causes the entire field to be highlighted. That is, you cannot edit the values without first clearing them. Let me know if there's not an existing bug for this, and I'll file one.

Thanks!

@MortimerGoro
Copy link
Contributor Author

@cvan I'm going to merge this fix. We can create another issue for that problem if it isn't already filled

@MortimerGoro MortimerGoro merged commit 1e98122 into master Mar 8, 2019
@ghost ghost removed the in progress label Mar 8, 2019
@bluemarvin bluemarvin deleted the edit_text_bug branch March 8, 2019 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants