Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions to fix t/Policy/Variables/require_localized_punctuation_vars.t failures. #102

Open
GeJ opened this issue Sep 28, 2016 · 3 comments

Comments

@GeJ
Copy link

GeJ commented Sep 28, 2016

I did some digging, and it seems that it comes down to this :

You are using Minilla with Module::Build::Tiny to issue your releases. Furthermore in minil.toml you trigger require_localized_punctuation_vars.PL as a release hook. As a consequence you generate the t/Policy/Variables/require_localized_punctuation_vars.t file based on your environment (your Perl version and your B::Keywords version) that might not match the one of the module's user and thus causes the recently reported failures.

Possible fixes :

  • Switch to Module::Build and explicitly declare the PL_files section in minil.toml;
  • Put the PL file somewhere within lib and adjust the path to generate the test file. Module::Build::Tiny will run the file during its build phase and should not try to install it;
  • Create a new extend_Build_PL.PL file somewhere (in /author maybe), that would basically alter the Build.PL file to force it to run require_localized_punctuation_vars.PL after it called the Build_PL() function. And declare this file in Minilla's release.hooks section. Yes! This is ugly...

If you don't feel to do it yourself, let me know which one has your preference and I'll try to implement it.

Thanks for your work on this module.

Regards.

@zdm
Copy link

zdm commented Apr 10, 2017

Hey, could this issue be fixed?

@HenkPoley
Copy link

At the moment this blocks normal installation of Perl::Lint on Ubuntu 18.04.2 (on WSL 1809 kernel)

It does install of course with cpam -f (force)

@jgherbert
Copy link

Ditto as tested on MacOS 10.14.3 default perl, and in 5.16.0 within perlbrew; fails on those tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants