Mpv does not display its version number with the Nightly builds. #15789
Labels
Comments
|
Hmm, it's because the action runners do shallow checkouts and the version generation is just the hash. |
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 2, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 2, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 2, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 2, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 2, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 2, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 3, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 5, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 5, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. This is complicated enough to warrant bring back version.py since we can't just do a one line command. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 5, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. This is complicated enough to warrant bring back version.py since we can't just do a one line command. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 5, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. This is complicated enough to warrant bring back version.py since we can't just do a one line command. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 5, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. This is complicated enough to warrant bring back version.py since we can't just do a one line command. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 5, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. This is complicated enough to warrant bring back version.py since we can't just do a one line command. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 5, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. This is complicated enough to warrant bring back version.py since we can't just do a one line command. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 5, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. This is complicated enough to warrant bring back version.py since we can't just do a one line command. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 5, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. This is complicated enough to warrant bring back version.py since we can't just do a one line command. Fixes mpv-player#15789.
Dudemanguy
added a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 5, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the hash. This is complicated enough to warrant bring back version.py since we can't just do a one line command. Fixes mpv-player#15789.
Dudemanguy
pushed a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 5, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the commit hash. Fixes mpv-player#15789.
Dudemanguy
pushed a commit
to Dudemanguy/mpv
that referenced
this issue
Feb 5, 2025
If the cloned repo is shallow (e.g. like the default github actions settings), the git describe command won't actually be able to fetch any tags and will instead just get a hash. The resulting binary version string will end up being that git hash. While it does tell you the exact commit, it's not exactly helpful when wanting to know the general version at a glance. For the case where we do have a git directory but no available tags, build a version string using the mpv version + the commit hash. Fixes mpv-player#15789.
|
Thanks ! It's Works |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mpv Information
Other Information
Reproduction Steps
Hello,
I downloaded the ARM version of mpv for macOS from this link: https://nightly.link/mpv-player/mpv/workflows/build/master/mpv-macos-15-arm, to use it with the Karaoke Mugen software.
Karaoke Mugen runs a detection of the mpv version in use and displays the following messages:
Karaoke Mugen is unable to determine the mpv version and assumes that my version is lower than 0.33.
After running the command
mpv --version:Expected Behavior
--mpv version should return the version number (0.39) in addition to the build.
Actual Behavior
--mpv version does not display the mpv version number (0.39).
Log File
Sample Files
No response
I carefully read all instruction and confirm that I did the following:
--log-file=output.txt.The text was updated successfully, but these errors were encountered: