-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MKV crop tags applied but DAR not re-adjusted, resulting in wrong display dimensions #15800
Comments
It's known issue and defined like that, because this is what most the files are using and what makes actually sense in the bigger picture. You can read previous discussions here #13446 and https://gitlab.com/mbunkus/mkvtoolnix/-/issues/2389 To not repeat everything, the key-points are:
Based on that and other extensive discussion, we decided to not endorse and follow the current Matroska specification, which makes only things more complex and awkward to handle in the context of various players. There was an idea to amend Matroska spec to update the wording to reflect more closely what the reality is. But we didn't follow up on this and it's my fault probably, because I didn't have time initially and forgot later. Also note that mpv is only reacting to already established state of affairs, I tried to apply spec-compliant behavior in f8db02b, which were reverted in 81102b0 and then was an attempt to reapply it in #13446 Note that we could have compact option to handle this in mpv, but it doesn't resolve bigger issue of supporting non-cropping aware players, so the option in mpv wouldn't really change this... and Matroska files with crop would still be inherently broken. |
Thank you for the history @kasper93 . |
I see that Matroska cropping has been added in FFmpeg not so long ago. It's probably good reminder that we should follow-up on this topic with Matroska spec. I will try to draft email about this. I will keep it open for now, because this issue is not really fully resolved. |
mpv Information
Other Information
Reproduction Steps
First, note this text of Matroska spec notes (https://www.matroska.org/technical/notes.html):
Also note the following from the element specifications (https://www.matroska.org/technical/elements.html):
Given the following:
ffmpeg -f lavfi -i testsrc=duration=10:size=1280x720:rate=30 TestSrc.mkv
Now, open the file in mpv.
Observe that the view is squished, and not rendered to 4:3.
Expected Behavior
Let us now observe the behavior after transcoding the video with FFmpeg, which honors the crop tags and sets the correct SAR.
The transcoded file now gets the correct SAR in mpv and presents in 4:3 as expected
:
Actual Behavior
See "Reproduction Steps"
Log File
Attached (without --gpu-debug as that seemed to cause unrelated issues)
output.txt
Sample Files
ffmpeg -f lavfi -i testsrc=duration=10:size=1280x720:rate=30 TestSrc.mkv
I carefully read all instruction and confirm that I did the following:
--log-file=output.txt
.The text was updated successfully, but these errors were encountered: