NodeMaterialObserver: Detect geometry exchange. #30409
Merged
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
commented
Jan 27, 2025
| @@ -362,6 +363,13 @@ class NodeMaterialObserver { | |||
| const storedAttributeNames = Object.keys( storedAttributes ); | |||
| const currentAttributeNames = Object.keys( attributes ); | |||
|
|
|||
| if ( storedGeometryData.id !== geometry.id ) { | |||
There was a problem hiding this comment.
To clarify this does not introduce a "ping-pong" effect since the storedGeometryData is maintained per render object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #30398.
Description
NodeMaterialObservermust detect a geometry exchange otherwiseGeometries.updateForRender()is not correctly called which means attributes might not be in a valid state.Below is the code block that must be executed in order to avoid the errors/warnings mentioned in #30398.
three.js/src/renderers/common/Renderer.js
Lines 2767 to 2778 in d969abd