Improve git gutter

[evanrichter]

The git gutter colors are all the same gray, it would be nice to add red for deletions, and green for insertions in my opinion!

[mrmcc3]

Thanks for the feedback. Yeah I had the same thought initially and had green/red/blue in an early version. Here are some thoughts

• deletions diff.minus being a different shape were enough for me.

• additions diff.plus and changes diff.delta weren't consistent. for example I could add 2 lines and change one and it would all show up as a change. So differentiating between the two didn't provide much of a benefit for me.

• One thing I'm a fan of (from alabaster/zenbones) are simple rules.

  • If I see red anywhere in the editor immediately I know without thinking its an error
  • If i see orange boom its a warning
  • If i see blue it's information
  • Green it's a string

  By overloading uses of these colors the rules get a bit more complex. Maybe not on first glance of a theme but when you use it a lot over time you come to appreciate the simple rules... less cognitive overhead so you can focus on the code.

Anyway that's all pretty opinionated. Maybe there are some colors/shades I could use to make the git gutter look better without breaking the simple rules. In the meantime you could always experiment by inheriting "yo"

inherits = "yo"
"diff.plus" = { fg = "..." }
"diff.minus" = { fg = "..." }
"diff.delta" = { fg = "..." }

[evanrichter]

I appreciate the consistency and minimal use of colors-- I'll experiment with inheritance for now and see if diff colors make a significant difference for me :)