Revert registry artifacts when a DB error occurs while adding a revision

Author: msm1992

components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/APIProviderImpl.java

@@ -5863,7 +5863,20 @@ public String addAPIRevision(APIRevision apiRevision, String organization) throw
                     ExceptionCodes.from(ExceptionCodes.API_REVISION_UUID_NOT_FOUND));
         }
         apiRevision.setRevisionUUID(revisionUUID);
-        apiMgtDAO.addAPIRevision(apiRevision);
+        try {
+            apiMgtDAO.addAPIRevision(apiRevision);
+        } catch (APIManagementException e) {
+            try {
+                    apiPersistenceInstance.deleteAPIRevision(new Organization(organization), apiId.getUUID(), revisionUUID,
+                                    revisionId);
+                } catch (APIPersistenceException e1) {
+                    String errorMessage = "Failed to remove revision registry artifacts";
+                    throw new APIManagementException(errorMessage, ExceptionCodes.from(ExceptionCodes.
+                                    ERROR_DELETING_API_REVISION, apiRevision.getApiUUID()));
+                }
+            throw new APIManagementException("Failed to add API Revision entry of API UUID "
+                            + apiRevision.getApiUUID(), e);
+        }
         if (importExportAPI != null) {
             try {
                 File artifact = importExportAPI