Fix wrong operator use for string comparisons

msm1992 · msm1992 · commit f8875016cd4e · 2024-07-09T10:31:04.000+05:30
diff --git a/components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/AbstractAPIManager.java b/components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/AbstractAPIManager.java
@@ -339,13 +339,13 @@ public List<Documentation> getAllDocumentation(String uuid, String organization)
                                 convertedList.add(DocumentMapper.INSTANCE.toDocumentation(docList.get(i)));
                             }
                             if (APIConstants.DOC_OWNER_VISIBILITY.equals(String.valueOf(doc.getVisibility()))) {
-                                if (APIConstants.WSO2_ANONYMOUS_USER != username
+                                if (!APIConstants.WSO2_ANONYMOUS_USER.equals(username)
                                         && !isTenantDomainNotMatching(organization)) {
                                     convertedList.add(DocumentMapper.INSTANCE.toDocumentation(docList.get(i)));
                                 }
                             }
                             if (APIConstants.DOC_SHARED_VISIBILITY.equals(String.valueOf(doc.getVisibility()))) {
-                                if (APIConstants.WSO2_ANONYMOUS_USER != username
+                                if (!APIConstants.WSO2_ANONYMOUS_USER.equals(username)
                                         && !isTenantDomainNotMatching(organization)){
                                     privateDocs.add(DocumentMapper.INSTANCE.toDocumentation(docList.get(i)));
                                 }
@@ -455,11 +455,11 @@ public boolean isDocVisible(org.wso2.carbon.apimgt.persistence.dto.Documentation
         if (APIConstants.DOC_API_BASED_VISIBILITY.equals(String.valueOf(doc.getVisibility()))) {
             validDoc = true;
         } else if (APIConstants.DOC_OWNER_VISIBILITY.equals(String.valueOf(doc.getVisibility()))) {
-            if (APIConstants.WSO2_ANONYMOUS_USER != username && !isTenantDomainNotMatching(requestedTenantDomain)) {
+            if (!APIConstants.WSO2_ANONYMOUS_USER.equals(username) && !isTenantDomainNotMatching(requestedTenantDomain)) {
                 validDoc = true;
             }
         } else if (APIConstants.DOC_SHARED_VISIBILITY.equals(String.valueOf(doc.getVisibility()))) {
-            if (APIConstants.WSO2_ANONYMOUS_USER != username && !isTenantDomainNotMatching(requestedTenantDomain)) {
+            if (!APIConstants.WSO2_ANONYMOUS_USER.equals(username) && !isTenantDomainNotMatching(requestedTenantDomain)) {
                 try {
                     if (validatePrivateScopes(username, loggedInTenantDomain)) {
                         validDoc = true;

Original file line number	Diff line number	Diff line change
`@@ -339,13 +339,13 @@ public List<Documentation> getAllDocumentation(String uuid, String organization)`
`339`	`339`	`convertedList.add(DocumentMapper.INSTANCE.toDocumentation(docList.get(i)));`
`340`	`340`	`}`
`341`	`341`	`if (APIConstants.DOC_OWNER_VISIBILITY.equals(String.valueOf(doc.getVisibility()))) {`
`342`		`- if (APIConstants.WSO2_ANONYMOUS_USER != username`
	`342`	`+ if (!APIConstants.WSO2_ANONYMOUS_USER.equals(username)`
`343`	`343`	`&& !isTenantDomainNotMatching(organization)) {`
`344`	`344`	`convertedList.add(DocumentMapper.INSTANCE.toDocumentation(docList.get(i)));`
`345`	`345`	`}`
`346`	`346`	`}`
`347`	`347`	`if (APIConstants.DOC_SHARED_VISIBILITY.equals(String.valueOf(doc.getVisibility()))) {`
`348`		`- if (APIConstants.WSO2_ANONYMOUS_USER != username`
	`348`	`+ if (!APIConstants.WSO2_ANONYMOUS_USER.equals(username)`
`349`	`349`	`&& !isTenantDomainNotMatching(organization)){`
`350`	`350`	`privateDocs.add(DocumentMapper.INSTANCE.toDocumentation(docList.get(i)));`
`351`	`351`	`}`
`@@ -455,11 +455,11 @@ public boolean isDocVisible(org.wso2.carbon.apimgt.persistence.dto.Documentation`
`455`	`455`	`if (APIConstants.DOC_API_BASED_VISIBILITY.equals(String.valueOf(doc.getVisibility()))) {`
`456`	`456`	`validDoc = true;`
`457`	`457`	`} else if (APIConstants.DOC_OWNER_VISIBILITY.equals(String.valueOf(doc.getVisibility()))) {`
`458`		`- if (APIConstants.WSO2_ANONYMOUS_USER != username && !isTenantDomainNotMatching(requestedTenantDomain)) {`
	`458`	`+ if (!APIConstants.WSO2_ANONYMOUS_USER.equals(username) && !isTenantDomainNotMatching(requestedTenantDomain)) {`
`459`	`459`	`validDoc = true;`
`460`	`460`	`}`
`461`	`461`	`} else if (APIConstants.DOC_SHARED_VISIBILITY.equals(String.valueOf(doc.getVisibility()))) {`
`462`		`- if (APIConstants.WSO2_ANONYMOUS_USER != username && !isTenantDomainNotMatching(requestedTenantDomain)) {`
	`462`	`+ if (!APIConstants.WSO2_ANONYMOUS_USER.equals(username) && !isTenantDomainNotMatching(requestedTenantDomain)) {`
`463`	`463`	`try {`
`464`	`464`	`if (validatePrivateScopes(username, loggedInTenantDomain)) {`
`465`	`465`	`validDoc = true;`