You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are circular dependencies between API and GOR. (See Field.GOR_default() and the comment thereafter in field.py). Currently, there is a smart default method to compute GOR from API gravity, but the reverse (computing API from GOR) is commented out. The current approach of creating a dependency network to determine the order of processing smart defaults does not support cycles.
There is a question about the implementation of method Field.WIR_default(), which sets WIR from WOR. In OPGEEv3, this code added one to the WOR default, which at the time of implementation, was 6. The question is whether WIR should default to 7 or always be WOR + 1 (the latter being what is implemented currently.)
A cryptic comment at the end of field.py says:
# TODO: decide how to handle "associated gas defaults", which is just global vs CA-LCFS values currently
Unclear what this means, but it should be explored.
There are circular dependencies between
API
andGOR
. (SeeField.GOR_default()
and the comment thereafter in field.py). Currently, there is a smart default method to computeGOR
fromAPI
gravity, but the reverse (computingAPI
fromGOR
) is commented out. The current approach of creating a dependency network to determine the order of processing smart defaults does not support cycles.There is a question about the implementation of method
Field.WIR_default()
, which setsWIR
fromWOR
. In OPGEEv3, this code added one to theWOR
default, which at the time of implementation, was 6. The question is whetherWIR
should default to 7 or always beWOR
+ 1 (the latter being what is implemented currently.)A cryptic comment at the end of field.py says:
Unclear what this means, but it should be explored.
[Seeking input from @wennanlong]
The text was updated successfully, but these errors were encountered: