Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions to Smart Defaults #11

Open
rjplevin opened this issue Sep 10, 2024 · 1 comment
Open

Revisions to Smart Defaults #11

rjplevin opened this issue Sep 10, 2024 · 1 comment

Comments

@rjplevin
Copy link
Collaborator

rjplevin commented Sep 10, 2024

  1. There are circular dependencies between API and GOR. (See Field.GOR_default() and the comment thereafter in field.py). Currently, there is a smart default method to compute GOR from API gravity, but the reverse (computing API from GOR) is commented out. The current approach of creating a dependency network to determine the order of processing smart defaults does not support cycles.

  2. There is a question about the implementation of method Field.WIR_default(), which sets WIR from WOR. In OPGEEv3, this code added one to the WOR default, which at the time of implementation, was 6. The question is whether WIR should default to 7 or always be WOR + 1 (the latter being what is implemented currently.)

  3. A cryptic comment at the end of field.py says:

# TODO: decide how to handle "associated gas defaults", which is just global vs CA-LCFS values currently

Unclear what this means, but it should be explored.

[Seeking input from @wennanlong]

@wennanlong
Copy link
Collaborator

This is the future work that will be discussed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants